Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Paolo Bonzini
On 11/06/2011 09:17 PM, Pekka Enberg wrote: No. I want to try new tool/old kernel and old tool/new kernel (kernel can be either guest or host, depending on the nature of the bug), and then bisect just one. (*) And that's the exceptional case, and only KVM tool developers really should

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-07 Thread Paolo Bonzini
On 11/06/2011 09:14 PM, Thomas Schmitt wrote: Hi, i have finished CD and DVD tests with drive file=/dev/sg2,if=virtio -cdrom /dvdbuffer/pseudo_drive There is substantial improvement towards if=scsi. Actually everything works like a charm now. :)) Cool. So you might have unveiled some

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, Nov 7, 2011 at 10:00 AM, Paolo Bonzini pbonz...@redhat.com wrote: No, having the source code in Linux kernel tree is perfectly useless for the exceptional case, and forces you to go through extra hoops to build only one component.  Small hoops such as adding -- tools/kvm to git bisect

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, Nov 7, 2011 at 10:00 AM, Paolo Bonzini pbonz...@redhat.com wrote: (BTW, I'm also convinced like Ted that not having a defined perf ABI might have made sense in the beginning, but it has now devolved into bad software engineering practice). I'm not a perf maintainer so I don't know what

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 09:09 AM, Pekka Enberg wrote: We are obviously also using specifications but as you damn well should know, specifications don't matter nearly as much as working code. Specifications matter much more than working code. Quirks are a fact of life but should always come second.

Re: [Qemu-devel] [v8 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor

2011-11-07 Thread Supriya Kannery
On 11/04/2011 07:59 AM, Zhi Yong Wu wrote: On Sun, Oct 30, 2011 at 6:33 PM, Supriya Kannery supri...@linux.vnet.ibm.com wrote: Currently cache setting of a block device cannot be changed without restarting a running VM. Following patchset is for enabling dynamic change of cache setting for

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On 11/07/2011 09:09 AM, Pekka Enberg wrote: We are obviously also using specifications but as you damn well should know, specifications don't matter nearly as much as working code. On Mon, 7 Nov 2011, Paolo Bonzini wrote: Specifications matter much more than working code. Quirks are a fact of

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-07 Thread Zhi Yong Wu
On Thu, Nov 3, 2011 at 2:05 AM, Thomas Schmitt scdbac...@gmx.net wrote: Hi, i wrote: The sense code is listed in MMC as:    B 00 06 I/O PROCESS TERMINATED Paolo Bonzini wrote: Is it good or bad? :)  I see it even in the very first command. It does not indicate success. MMC only has the

Re: [Qemu-devel] [v8 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor

2011-11-07 Thread Zhi Yong Wu
On Mon, Nov 7, 2011 at 4:38 PM, Supriya Kannery supri...@linux.vnet.ibm.com wrote: On 11/04/2011 07:59 AM, Zhi Yong Wu wrote: On Sun, Oct 30, 2011 at 6:33 PM, Supriya Kannery supri...@linux.vnet.ibm.com  wrote: Currently cache setting of a block device cannot be changed without restarting a

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 09:45 AM, Pekka Enberg wrote: Specifications matter much more than working code. Quirks are a fact of life but should always come second. To quote Linus: And I have seen _lots_ of total crap work that was based on specs. It's _the_ single worst way to write software,

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On 11/07/2011 09:45 AM, Pekka Enberg wrote: Specifications matter much more than working code.  Quirks are a fact of life but should always come second. To quote Linus:   And I have seen _lots_ of total crap work that was based on specs. It's _the_ single worst way to write software,

Re: [Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations

2011-11-07 Thread Kevin Wolf
Am 06.11.2011 15:27, schrieb Avi Kivity: On 10/20/2011 01:16 PM, Paolo Bonzini wrote: This does the first part of the conversion to coroutines, by wrapping bdrv_read implementations to take the read side of the rwlock. Drivers that implement bdrv_read rather than bdrv_co_readv can then

Re: [Qemu-devel] backing_file Path

2011-11-07 Thread Kevin Wolf
Am 07.11.2011 08:46, schrieb Zhi Hui Li: when I trace the code of qemu-img.c, I found in the image file, the backing_file use the relative path, I think Maybe it has some problems. for example: 1: qemu-img create -o backing_file=../ aa.img 5G 2: qemu-system-x86_64 aa.img if

Re: [Qemu-devel] [PATCH] readline: Fix buffer overrun on re-add to history

2011-11-07 Thread Stefan Hajnoczi
On Fri, Nov 04, 2011 at 11:10:01AM +0100, Markus Armbruster wrote: readline_hist_add() moves the history entry to the end of history. It uses memmove() to move rs-history[idx + 1..] to rs-history[idx..]. However, its size argument is off by two array elements, so it writes one element beyond

Re: [Qemu-devel] [Qemu-trivial] [PATCH] xen-platform: Fix IO port read/write functions

2011-11-07 Thread Stefan Hajnoczi
On Fri, Nov 04, 2011 at 03:35:11PM +, Anthony PERARD wrote: Somehow, the read/write functions handle an offset that does not exist anymore. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/xen_platform.c | 18 +- 1 files changed, 9 insertions(+), 9

Re: [Qemu-devel] [PATCH v2] block: Use bdrv functions to replace file operation in cow.c

2011-11-07 Thread Stefan Hajnoczi
On Mon, Nov 07, 2011 at 02:52:17PM +0800, Li Zhi Hui wrote: @@ -260,10 +261,15 @@ static int cow_create(const char *filename, QEMUOptionParameter *options) options++; } -cow_fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, - 0644); -if

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

2011-11-07 Thread Gerd Hoffmann
Hi, Agreed. If we can know the virtual device for KVM in a better way (e.g. any specific PCI SSID or such), we can narrow the condition more safely. PCI Subsystem ID 1af4:1100 is qemu/kvm (not only Intel HDA, most other emulated pci devices have it too). Complete entry: 00:04.0 0403:

[Qemu-devel] [PULL 0/5] Trivial patches for 2 to 7 November 2011

2011-11-07 Thread Stefan Hajnoczi
Anthony: These patches fix bugs and are small. I think we should consider including them in 1.0. The following changes since commit 932eacc158c064935c7bab920c88a93a629e1ca4: Merge branch 'xtensa' of git://jcmvbkbc.spb.ru/dumb/qemu-xtensa (2011-11-02 20:52:23 +) are available in the git

[Qemu-devel] [PATCH 3/5] cmd: Fix potential memory leak

2011-11-07 Thread Stefan Hajnoczi
From: Pavel Borzenkov pavel.borzen...@gmail.com Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- cmd.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/cmd.c b/cmd.c index 75415d8..0806e18

[Qemu-devel] [PATCH 4/5] readline: Fix buffer overrun on re-add to history

2011-11-07 Thread Stefan Hajnoczi
From: Markus Armbruster arm...@redhat.com readline_hist_add() moves the history entry to the end of history. It uses memmove() to move rs-history[idx + 1..] to rs-history[idx..]. However, its size argument is off by two array elements, so it writes one element beyond rs-history[], and reads two.

[Qemu-devel] [PATCH 2/5] cmd: Fix potential NULL pointer dereference

2011-11-07 Thread Stefan Hajnoczi
From: Pavel Borzenkov pavel.borzen...@gmail.com Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- cmd.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/cmd.c b/cmd.c index a6e3ef4..75415d8

[Qemu-devel] [PATCH 1/5] cmd: Fix coding style in cmd.c

2011-11-07 Thread Stefan Hajnoczi
From: Pavel Borzenkov pavel.borzen...@gmail.com Before the next patches, fix coding style of the affected functions. Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- cmd.c | 168

[Qemu-devel] [PATCH 5/5] xen-platform: Fix IO port read/write functions

2011-11-07 Thread Stefan Hajnoczi
From: Anthony PERARD anthony.per...@citrix.com Somehow, the read/write functions handle an offset that does not exist anymore. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/xen_platform.c | 18 +- 1

Re: [Qemu-devel] qemu-kvm crashes doing migration with disks + blkdebug files (does not happen with qemu)

2011-11-07 Thread Kevin Wolf
Am 05.11.2011 03:16, schrieb Lucas Meneghel Rodrigues: Hi folks, qemu-kvm is segfaulting when executing migration with blkdebug files. 19:50:02 DEBUG| Git repo qemu_kvm uri: git://github.com/avikivity/qemu.git 19:50:02 DEBUG| Git repo qemu_kvm branch: master 19:50:30 INFO | Commit hash

Re: [Qemu-devel] [v8 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor

2011-11-07 Thread Supriya Kannery
On 11/07/2011 02:19 PM, Zhi Yong Wu wrote: On Mon, Nov 7, 2011 at 4:38 PM, Supriya Kannery supri...@linux.vnet.ibm.com wrote: On 11/04/2011 07:59 AM, Zhi Yong Wu wrote: On Sun, Oct 30, 2011 at 6:33 PM, Supriya Kannery supri...@linux.vnet.ibm.comwrote: Currently cache setting of a block

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

2011-11-07 Thread Konstantin Ozerkov
On 07.11.11 12:25, Gerd Hoffmann wrote: Hi, Agreed. If we can know the virtual device for KVM in a better way (e.g. any specific PCI SSID or such), we can narrow the condition more safely. PCI Subsystem ID 1af4:1100 is qemu/kvm (not only Intel HDA, most other emulated pci devices have it

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-07 Thread Thomas Schmitt
Hi, drive file=/dev/sg2,if=virtio -cdrom /dvdbuffer/pseudo_drive Actually everything works like a charm now. :)) Cool. So you might have unveiled some kernel bugs too (host crashes are never desirable!) The USB drive is back at the test machine. I'm running the planned BD-RE tests on

Re: [Qemu-devel] [PATCH 1/2] net: truncate output file when using dump backend

2011-11-07 Thread Stefan Hajnoczi
On Sun, Nov 06, 2011 at 10:52:04PM +0100, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau hpous...@reactos.org --- net/dump.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Gerd Hoffmann
Hi, Usable - I've tried kvm-tool several times and still (today) fail to get a standard SUSE image (with a kernel I have to compile and provide separately...) up and running *). Likely a user mistake, but none that is very obvious. At least to me. Same here. No support for booting from

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-07 Thread Fabien Chouteau
On 04/11/2011 19:45, Lluís Vilanova wrote: Stefan Hajnoczi writes: On Thu, Nov 03, 2011 at 10:35:28AM +0100, Fabien Chouteau wrote: On 03/11/2011 08:44, Stefan Hajnoczi wrote: On Wed, Nov 2, 2011 at 5:39 PM, Fabien Chouteau chout...@adacore.com wrote: On 29/10/2011 15:52, Alexander Graf

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, Nov 7, 2011 at 12:11 PM, Gerd Hoffmann kra...@redhat.com wrote: No support for booting from CDROM. No support for booting from Network. Thus no way to install a new guest image. Sure. It's a pain point which we need to fix. On Mon, Nov 7, 2011 at 12:11 PM, Gerd Hoffmann

Re: [Qemu-devel] [qemu-kvm unittest regression] Re: Autotest | Job ID: 2011 Upstream qemu-kvm.git sanity 11-01-2011 00:04:02 | Status: 1 Completed | Success Rate: 94.74 %

2011-11-07 Thread Marcelo Tosatti
On Tue, Nov 01, 2011 at 02:08:54PM -0200, Lucas Meneghel Rodrigues wrote: On 11/01/2011 12:17 PM, kvm-autotest wrote: Job ID: 2011 Job name: Upstream qemu-kvm.git sanity 11-01-2011 00:04:02 Summary: Host: Status: Completed Status: 1 Completed Execution time (HH:MM:SS): 01:17:02 User tests

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Gerd Hoffmann
Hi, It's not just about code, it's as much about culture and development process. Indeed. The BSDs have both kernel and the base system in a single repository. There are probably good reasons for (and against) it. In Linux we don't have that culture. No tool (except perf) lives in the

Re: [Qemu-devel] [v8 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor

2011-11-07 Thread Zhi Yong Wu
On Mon, Nov 7, 2011 at 5:35 PM, Supriya Kannery supri...@linux.vnet.ibm.com wrote: On 11/07/2011 02:19 PM, Zhi Yong Wu wrote: On Mon, Nov 7, 2011 at 4:38 PM, Supriya Kannery supri...@linux.vnet.ibm.com  wrote: On 11/04/2011 07:59 AM, Zhi Yong Wu wrote: On Sun, Oct 30, 2011 at 6:33 PM,

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Kevin Wolf
Am 06.11.2011 19:31, schrieb Ted Ts'o: On Sun, Nov 06, 2011 at 11:08:10AM -0600, Anthony Liguori wrote: I'm quite happy with KVM tool and hope they continue working on it. My only real wish is that they wouldn't copy QEMU so much and would try bolder things that are fundamentally different

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Sasha Levin
On Mon, Nov 7, 2011 at 12:23 PM, Gerd Hoffmann kra...@redhat.com wrote:  Hi, It's not just about code, it's as much about culture and development process. Indeed.  The BSDs have both kernel and the base system in a single repository.  There are probably good reasons for (and against) it.

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

2011-11-07 Thread Gerd Hoffmann
Hi, We discuss Intel ICH/AC'97 (snd-intel8x0) here, but I hope that PCI SSID is same. Hmm, it's not, the ac97 emulation doesn't use the default qemu subsystem id for some reason. Here is the entry: [root@fedora ~]# lspci -vns6 00:06.0 0401: 8086:2415 (rev 01) Subsystem: 8086:

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

2011-11-07 Thread Takashi Iwai
At Mon, 07 Nov 2011 10:25:24 +0100, Gerd Hoffmann wrote: Hi, Agreed. If we can know the virtual device for KVM in a better way (e.g. any specific PCI SSID or such), we can narrow the condition more safely. PCI Subsystem ID 1af4:1100 is qemu/kvm (not only Intel HDA, most other

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

2011-11-07 Thread Takashi Iwai
At Mon, 07 Nov 2011 11:35:49 +0100, Gerd Hoffmann wrote: Hi, We discuss Intel ICH/AC'97 (snd-intel8x0) here, but I hope that PCI SSID is same. Hmm, it's not, the ac97 emulation doesn't use the default qemu subsystem id for some reason. Here is the entry: [root@fedora ~]# lspci

Re: [Qemu-devel] [RFC 1/6] block: add request tracking

2011-11-07 Thread Zhi Yong Wu
On Mon, Oct 17, 2011 at 11:47 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The block layer does not know about pending requests.  This information is necessary for copy-on-read since overlapping requests must be serialized to prevent races that corrupt the image. Add a simple

[Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Gerd Hoffmann
This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id (1af4:1100) instead. Cc: Takashi Iwai ti...@suse.de

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 11:30 AM, Sasha Levin wrote: In Linux we don't have that culture. No tool (except perf) lives in the kernel repo. I fail to see why kvm-tool is that much different from udev, util-linux, iproute, filesystem tools, that it should be included. tools/power was merged in just

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 11:04 AM, Thomas Schmitt wrote: In a thread on linux-hotplug, /dev/sg* is declared to be deprecated in favor of/dev/bsg/* and /dev/sr*. Will this become a problem ? I think /dev/bsg is backwards-compatible more or less, but it would help if it had decent documentation in the

Re: [Qemu-devel] [PATCH 1/3] sonic: fix typo

2011-11-07 Thread Andreas Färber
Would be nice to add description: Remove a doubled semicolon. Am 06.11.2011 22:48, schrieb Hervé Poussineau: Signed-off-by: Hervé Poussineau hpous...@reactos.org Reviewed-by: Andreas Färber afaer...@suse.de Andreas --- hw/dp8393x.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH 2/3] sonic: fix netcard reset

2011-11-07 Thread Andreas Färber
Am 06.11.2011 22:48, schrieb Hervé Poussineau: From: Herv Poussineau hpous...@reactos.org Typo. At least to me it's not obvious why this is correct, so please add an explanatory patch description. Andreas Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/dp8393x.c |3 +-- 1

Re: [Qemu-devel] [PATCH] fix segfault on fd-migration starting

2011-11-07 Thread Juan Quintela
Wen Congyang we...@cn.fujitsu.com wrote: We set s-mon to NULL in migrate_init. But we will use it to search fd when do fd-migration, and it will cause qemu crashed. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- migration.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH v2] block: Use bdrv functions to replace file operation in cow.c

2011-11-07 Thread Kevin Wolf
Am 07.11.2011 07:52, schrieb Li Zhi Hui: Since common file operation functions lack of error detection, so change them to bdrv series functions. v2: Only contains the function modified. v1: Fix coding style and convert file operation functions to bdrv functions. Signed-off-by: Li Zhi Hui

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-07 Thread Zhi Yong Wu
On Mon, Nov 7, 2011 at 7:13 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 11/07/2011 11:04 AM, Thomas Schmitt wrote: In a thread on linux-hotplug, /dev/sg* is declared to be deprecated in favor of/dev/bsg/* and /dev/sr*. Will this become a problem ? I think /dev/bsg is backwards-compatible

Re: [Qemu-devel] Hi Natalia.. A query regarding QEMU

2011-11-07 Thread Gerd Hoffmann
Hi, What I can tell you is that Android phones/tablets are USB devices, and QEMU have an incomplete support for REAL USB devices with QEMU behaving as an USB host. But QEMU is not designed currently to work as a USB device to a real USB host. If you want to code that support yourself,

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 12:24 PM, Zhi Yong Wu wrote: It didn't work for me I started up one os=rh6.1 guest with above options. On guest: [root@localhost ~]# mount /dev/sr0 /tmp/1 mount: you must specify the filesystem type [root@localhost ~]# You asked for a virtio disk, not a SCSI disk. The CD-ROM

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, 7 Nov 2011, Gerd Hoffmann wrote: It's not just about code, it's as much about culture and development process. Indeed. The BSDs have both kernel and the base system in a single repository. There are probably good reasons for (and against) it. In Linux we don't have that culture. No

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, 7 Nov 2011, Kevin Wolf wrote: Makes it a lot less hackable for me unless you want to restrict the set of potential developers to Linux kernel developers... We're not restricting potential developers to Linux kernel folks. We're making it easy for them because we believe that the KVM

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-07 Thread Zhi Yong Wu
On Mon, Nov 7, 2011 at 7:29 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 11/07/2011 12:24 PM, Zhi Yong Wu wrote: It didn't work for me I started up one os=rh6.1 guest with above options. On guest: [root@localhost ~]# mount /dev/sr0 /tmp/1 mount: you must specify the filesystem type

Re: [Qemu-devel] [RFC 1/6] block: add request tracking

2011-11-07 Thread Stefan Hajnoczi
On Mon, Nov 7, 2011 at 11:00 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Mon, Oct 17, 2011 at 11:47 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: +/** + * Enable tracking of incoming requests + * + * Request tracking can be safely used by multiple users at the same time, + *

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, Nov 7, 2011 at 1:02 PM, Paolo Bonzini pbonz...@redhat.com wrote: Indeed I do not see any advantage, since all the interfaces they use are stable anyway (sysfs, msr.ko). If they had gone in x86info, for example, my distro (F16, not exactly conservative) would have likely picked those

Re: [Qemu-devel] [RFC 4/6] block: request overlap detection

2011-11-07 Thread Zhi Yong Wu
On Mon, Oct 17, 2011 at 11:47 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Detect overlapping requests and remember to align to cluster boundaries if the image format uses them.  This assumes that allocating I/O is performed in cluster granularity - which is true for qcow2, qed, etc.

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-07 Thread Lluís Vilanova
Fabien Chouteau writes: On 04/11/2011 19:45, Lluís Vilanova wrote: I've only had a brief look into the changes, but I think the mechanism I implemented has a cleaner fit into QEMU, thanks to previous feedback from this list. I don't know about your implementation, can you give more

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Kevin Wolf
Am 07.11.2011 12:38, schrieb Pekka Enberg: On Mon, 7 Nov 2011, Kevin Wolf wrote: Makes it a lot less hackable for me unless you want to restrict the set of potential developers to Linux kernel developers... We're not restricting potential developers to Linux kernel folks. We're making it

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ingo Molnar
* Pekka Enberg penb...@cs.helsinki.fi wrote: On Mon, 7 Nov 2011, Gerd Hoffmann wrote: It's not just about code, it's as much about culture and development process. Indeed. The BSDs have both kernel and the base system in a single repository. There are probably good reasons for (and

Re: [Qemu-devel] [qemu-kvm unittest regression] Re: Autotest | Job ID: 2011 Upstream qemu-kvm.git sanity 11-01-2011 00:04:02 | Status: 1 Completed | Success Rate: 94.74 %

2011-11-07 Thread Cleber Rosa
On 11/07/2011 07:21 AM, Marcelo Tosatti wrote: On Tue, Nov 01, 2011 at 02:08:54PM -0200, Lucas Meneghel Rodrigues wrote: On 11/01/2011 12:17 PM, kvm-autotest wrote: Job ID: 2011 Job name: Upstream qemu-kvm.git sanity 11-01-2011 00:04:02 Summary: Host: Status: Completed Status: 1 Completed

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Gerd Hoffmann
On 11/07/11 12:34, Pekka Enberg wrote: On Mon, 7 Nov 2011, Gerd Hoffmann wrote: It's not just about code, it's as much about culture and development process. Indeed. The BSDs have both kernel and the base system in a single repository. There are probably good reasons for (and against) it.

Re: [Qemu-devel] qemu-kvm crashes doing migration with disks + blkdebug files (does not happen with qemu)

2011-11-07 Thread Lucas Meneghel Rodrigues
On 11/07/2011 07:29 AM, Kevin Wolf wrote: Am 05.11.2011 03:16, schrieb Lucas Meneghel Rodrigues: Hi folks, qemu-kvm is segfaulting when executing migration with blkdebug files. 19:50:02 DEBUG| Git repo qemu_kvm uri: git://github.com/avikivity/qemu.git 19:50:02 DEBUG| Git repo qemu_kvm branch:

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Gerd Hoffmann
On 11/07/11 12:44, Pekka Enberg wrote: On Mon, Nov 7, 2011 at 1:02 PM, Paolo Bonzini pbonz...@redhat.com wrote: Indeed I do not see any advantage, since all the interfaces they use are stable anyway (sysfs, msr.ko). If they had gone in x86info, for example, my distro (F16, not exactly

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, Nov 7, 2011 at 2:18 PM, Gerd Hoffmann kra...@redhat.com wrote: tools/ lacks a separation into kernel hacker's testing+debugging toolbox and userspace tools.  It lacks proper buildsystem integration for the userspace tools, there is no make tools and also no make tools_install.  

Re: [Qemu-devel] [PATCH] Support for UDP unicast network backend

2011-11-07 Thread Jan Kiszka
On 2011-11-07 15:01, Benjamin wrote: Here is the updated patch, using only localaddr. mcast expects it to be addr whereas udp expects addr:port. It's documented in the help output. I also corrected the error message when checking udp parameters. Sorry, missed that: please never forget to run

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Avi Kivity
On 11/07/2011 12:30 PM, Sasha Levin wrote: On Mon, Nov 7, 2011 at 12:23 PM, Gerd Hoffmann kra...@redhat.com wrote: Hi, It's not just about code, it's as much about culture and development process. Indeed. The BSDs have both kernel and the base system in a single repository.

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ted Ts'o
On Mon, Nov 07, 2011 at 01:08:50PM +0100, Gerd Hoffmann wrote: perf *is* an exception today. It might make sense to change that. But IMHO it only makes sense if there is a really broad agreement on it and other core stuff moves into the kernel too. Then you'll be able to get advantages

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
Hi Avi, On Mon, Nov 7, 2011 at 2:26 PM, Avi Kivity a...@redhat.com wrote: tools/power was merged in just 2 versions ago, do you think that merging that was a mistake? Things like tools/power may make sense, most of the code is tied to the kernel interfaces.  tools/kvm is 20k lines and is

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
Hi Ted, On Mon, Nov 7, 2011 at 2:29 PM, Ted Ts'o ty...@mit.edu wrote: And the same problems will exist with kvm-tool.  What if you need to release a new version of kvm-tool?  Does that mean that you have to release a new set of kernel binaries?  It's a mess, and there's a reason why we don't

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ted Ts'o
On Mon, Nov 07, 2011 at 02:29:45PM +0200, Pekka Enberg wrote: So what do you think about perf then? The amount of code that talks to the kernel is much smaller than that of the KVM tool. I think it's a mess, because it's never clear whether perf needs to be upgraded when I upgrade the kernel,

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Avi Kivity
On 11/07/2011 02:29 PM, Pekka Enberg wrote: Hi Avi, On Mon, Nov 7, 2011 at 2:26 PM, Avi Kivity a...@redhat.com wrote: tools/power was merged in just 2 versions ago, do you think that merging that was a mistake? Things like tools/power may make sense, most of the code is tied to the

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ted Ts'o
On Mon, Nov 07, 2011 at 02:42:57PM +0200, Pekka Enberg wrote: On Mon, Nov 7, 2011 at 2:29 PM, Ted Ts'o ty...@mit.edu wrote: Because it's a stupid, idiotic thing to do. The discussion is turning into whether or not linux/tools makes sense or not. I wish you guys would have had it before perf

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, Nov 7, 2011 at 2:47 PM, Ted Ts'o ty...@mit.edu wrote: Perf was IMHO an overreaction caused by the fact that systemtap and oprofile people packaged and released the sources in a way that kernel developers didn't like. I don't think perf should be used as a precendent that now argues

Re: [Qemu-devel] [PATCH 1.0] qxl: fix vga port initialization.

2011-11-07 Thread Alon Levy
On Thu, Nov 03, 2011 at 06:21:54PM +0100, Gerd Hoffmann wrote: Commit 0a039dc70096b768d3810afa50ba1d214768aaf4 broke vga modes for qxl-vga by loosing vga_ioport_read windup. qxl needs to hook into vga port writes only and used to realize that by letting vga_init() do the work for both reads

Re: [Qemu-devel] [PATCH] Support for UDP unicast network backend

2011-11-07 Thread Benjamin
On 11/07/11 12:23, Jan Kiszka wrote: On 2011-11-07 15:01, Benjamin wrote: Here is the updated patch, using only localaddr. mcast expects it to be addr whereas udp expects addr:port. It's documented in the help output. I also corrected the error message when checking udp parameters. Sorry,

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, Nov 7, 2011 at 2:47 PM, Ted Ts'o ty...@mit.edu wrote: I don't think perf should be used as a precendent that now argues that any new kernel utility should be moved into the kernel sources.  Does it make sense to move all of mount, fsck, login, etc., into the kernel sources?  There are

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Anthony Liguori
On 11/07/2011 05:57 AM, Ingo Molnar wrote: * Pekka Enbergpenb...@cs.helsinki.fi wrote: On Mon, 7 Nov 2011, Gerd Hoffmann wrote: It's not just about code, it's as much about culture and development process. Indeed. The BSDs have both kernel and the base system in a single repository.

Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-11-07 Thread Markus Armbruster
I apologize for the lateness of this review. Paolo Bonzini pbonz...@redhat.com writes: Signed-off-by: Paolo Bonzini pbonz...@redhat.com The commit message should explain why we need this callback. The cover letter says support for eject requests is required by udev 173. Please elaborate on

[Qemu-devel] [PATCH] hw/omap_gpio: Fix infinite recursion when doing 8/16 bit reads

2011-11-07 Thread Peter Maydell
Fix a long-standing bug which meant that any attempt to do an 8 or 16 bit read from the OMAP GPIO module would cause qemu to crash due to an infinite recursion. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- This has actually been in the code since the original OMAP2 support was added

Re: [Qemu-devel] Summary of CD, DVD passthrough tests with -drive if=scsi

2011-11-07 Thread Markus Armbruster
Thomas Schmitt scdbac...@gmx.net writes: Hi, since i had to give up the plan to test BD burning, i now post the first summary of passthrough testing on base of if=scsi . [Awesome stuff snipped...] Thanks a lot! We could use more tests like that. Has anyone thought of keeping your tests

Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 02:21 PM, Markus Armbruster wrote: The commit message should explain why we need this callback. The cover letter says support for eject requests is required by udev 173. Please elaborate on that. Well, first and foremost eject requests are in the spec. :) The fact that recent

Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-11-07 Thread Kevin Wolf
Am 07.11.2011 14:36, schrieb Paolo Bonzini: On 11/07/2011 02:21 PM, Markus Armbruster wrote: The commit message should explain why we need this callback. The cover letter says support for eject requests is required by udev 173. Please elaborate on that. Well, first and foremost eject

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-07 Thread Fabien Chouteau
On 07/11/2011 12:50, Lluís Vilanova wrote: Fabien Chouteau writes: On 04/11/2011 19:45, Lluís Vilanova wrote: I've only had a brief look into the changes, but I think the mechanism I implemented has a cleaner fit into QEMU, thanks to previous feedback from this list. I don't know about

[Qemu-devel] Guest hangs on reboot with Windows Server 2003

2011-11-07 Thread Stefan Hajnoczi
For QEMU 1.0 Test Day I'm hitting a guest hang with Windows Server 2003 whenever it tries to reboot. The QEMU monitor is available and working. I'm using a qcow2 image over IDE, but this may not be qcow2/block related. This is a regression and does not occur under Debian 0.14.1+dfsg-3. I am

Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 02:49 PM, Kevin Wolf wrote: 2. eject with -f should really never be needed, but it does whatever is needed to be able to follow up with a change command. It turns out it is really unlock and ask the guest to eject combined, but that's the implementation, not the model.

Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-11-07 Thread Kevin Wolf
Am 07.11.2011 14:56, schrieb Paolo Bonzini: On 11/07/2011 02:49 PM, Kevin Wolf wrote: 2. eject with -f should really never be needed, but it does whatever is needed to be able to follow up with a change command. It turns out it is really unlock and ask the guest to eject combined, but

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-07 Thread Lluís Vilanova
Fabien Chouteau writes: The process is basically: * Add trace events that can work during TCG code generation (e.g., start TB, start instruction fetch, memory access, etc.) * Let the user select which trace events to instrument, including both regular trace events and TCG trace events

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id

Re: [Qemu-devel] Summary of CD, DVD passthrough tests with -drive if=scsi

2011-11-07 Thread Thomas Schmitt
Hi, Markus Armbruster wrote: Has anyone thought of keeping your tests around for regression testing purposes? The full tour lasts a whole workday and needs human attention. I still did not come to test the newest proposals of Paolo Bonzini and Zhi Yong Wu, because the last BD-R test was

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Gerd Hoffmann
On 11/07/11 15:17, Avi Kivity wrote: On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread 青云
I know kgdb can test kernel,but I haven't succeed . -- Original -- From: Pekka Enberg; Date: 2011年11月7日(星期一) 下午4:57 To: Paolo Bonzini; Cc: Alexander Graf; k...@vger.kernel.org list; qemu-devel Developers; linux-ker...@vger.kernel.org List; Blue Swirl; Avi

Re: [Qemu-devel] Summary of CD, DVD passthrough tests with -drive if=scsi

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 03:31 PM, Thomas Schmitt wrote: The next release will hopefully happen in a few weeks and be able to work in the guest system out of the box. GNU/Linux, FreeBSD, Solaris are supported on real systems, currently. (Can FreeBSD and Solaris use virtio drives ?) Perhaps, but probably

[Qemu-devel] [PATCH 1.0] Replace WriteFileEx with WriteFile in qemu_create_pidfile

2011-11-07 Thread Fabien Chouteau
The function that writes pidfile for win32 uses WriteFileEx which is an asynchronous IO function. The arguments given to WriteFileEx are allocated on the stack and one of them is in out. When the IO operation is actually executed the calling function has already returned, so the arguments are no

Re: [Qemu-devel] [RFC 4/6] block: request overlap detection

2011-11-07 Thread Stefan Hajnoczi
On Mon, Nov 7, 2011 at 11:49 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Mon, Oct 17, 2011 at 11:47 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Detect overlapping requests and remember to align to cluster boundaries if the image format uses them.  This assumes that allocating I/O

[Qemu-devel] Summary of Anthony's 'next' queue

2011-11-07 Thread Anthony Liguori
Hi, This is a summary of the patches that I have queued in my next tree that were identified as 1.1 candidates. These patches will not be applied until after the 1.1 tree opens (December 1st). These patches have not been tested yet and may receive additional review comments. This note is

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 08:33 AM, Gerd Hoffmann wrote: On 11/07/11 15:17, Avi Kivity wrote: On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild

Re: [Qemu-devel] [PATCH 1.0] Replace WriteFileEx with WriteFile in qemu_create_pidfile

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 03:36 PM, Fabien Chouteau wrote: The function that writes pidfile for win32 uses WriteFileEx which is an asynchronous IO function. The arguments given to WriteFileEx are allocated on the stack and one of them is in out. When the IO operation is actually executed the calling

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 04:33 PM, Gerd Hoffmann wrote: On 11/07/11 15:17, Avi Kivity wrote: On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 08:42 AM, Avi Kivity wrote: On 11/07/2011 04:33 PM, Gerd Hoffmann wrote: On 11/07/11 15:17, Avi Kivity wrote: On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 04:44 PM, Anthony Liguori wrote: This a guest ABI change. Do we want -M support for it? Given that the old subsystem id isn't valid I'd say no unless someone comes up with a good reason. Do we know that Windows won't complain about it? I thought the original motivation for

  1   2   3   >