Add wrappers that let you get/set properties using normal C data types.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/qemu/object.h | 70 +
qom/object.c | 119 +
2 files changed, 180
Commit a7c36ee4920ea3acc227a0248dd161693f207357 added code for a net
bridge and explicitly said that this is very Linux centric.
Indeed, compilation failed for w32, so the bridge code is now
conditional. Hosts which don't support it can simply remove the
definition of CONFIG_NET_BRIDGE.
The interface loop can be performed only on the parent object. It
does not need to be done on each interface. Similarly, we can
simplify the code by switching early from the implementation
object to the parent object.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
qom/object.c | 38
Drop the special free callback. Instead, register a regular
release method in the non-legacy property.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c | 19 ---
hw/qdev.c|8 +---
hw/qdev.h|2 +-
3 files changed, 14
Similarly, use the object properties also to set the default
values of the qdev properties. This requires reordering
registration and initialization.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c | 29 ++---
hw/qdev.c|4 ++--
Am 04.02.2012 00:43, schrieb Anthony Liguori:
On 02/03/2012 06:11 PM, q...@buildbot.b1-systems.de wrote:
The Buildbot has detected a new failure on builder default_mingw32
while building qemu.
Full details are available at:
Move the creation of QmpInputVisitor and QmpOutputVisitor from
qmp.c to qom/object.c, since it's the only practical way to access
object properties.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/qemu/qom-qobject.h | 43 +++
qmp.c
This allows to restrict partial matches to objects of the expected
type. It will let people use bare names to reference drives
even though their name might be the same as a device's (e.g.
-drive id=hd0,if=none,... -device ...,drive=hd0,id=hd0).
As a useful byproduct, this fixes a problem with
Make the OMAP clocks QOM objects, so that they we can put them in a branch
of the object graph and turn the pointer properties into links.
As in the current code, the clocks are copied into a freshly allocated
memory block when they are initialized. However, the templates now
have a separate
Also generalize the code so that we can have more enum properties
in the future.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c | 62 +-
hw/qdev.h|1 +
qemu-common.h|1 +
3 files changed, 33
We need the print method to put double quotes, but parsing is not special.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c | 11 ---
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-addr.c |2 --
hw/qdev-properties.c | 38 +-
hw/qdev.h| 21 -
3 files changed, 1 insertions(+), 60 deletions(-)
diff --git a/hw/qdev-addr.c
Integer properties did not work.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index d69a987..debb37f 100644
--- a/hw/qdev-properties.c
+++
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
qom/object.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index a89e9e3..c0f6d54 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -13,8 +13,6 @@
#include qemu/object.h
#include
There's no need to call into -parse and -print manually. The
QOM legacy properties do that for us.
Furthermore, in some cases legacy and static properties have exactly
the same behavior, and we could drop the legacy properties right away.
Add an appropriate fallback to prepare for this.
Here is the patch series from last thursday, on steroids.
Patches 1 to 12 include the QOM parts of the previous series, plus
other things I found after a more thorough code review. In particular
I implemented the restriction of partial-path search to a particular
type, fixed some problems with
Part 1 is OMAP and is included in the qdev series. This one covers
devices that should never have used PROP_PTR in the first place.
The other parts will have to wait for QOMification of buses and CPUs.
Paolo Bonzini (3):
smbus: fix writes
smbus_eeprom: remove PTR property
vmmouse: replace
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
qom/object.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index b26272f..314fc7a 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -871,7 +871,7 @@ static void
These can set a link to any object, as long as it is included in
the composition tree.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/qemu/object.h | 24
qom/object.c | 25 +
2 files changed, 49 insertions(+), 0
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/smbus.c|4 ++--
hw/smbus.h|4 ++--
hw/smbus_eeprom.c | 39 +--
3 files changed, 25 insertions(+), 22 deletions(-)
diff --git a/hw/smbus.c b/hw/smbus.c
index 4ff2342..969d46d
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/qemu/object.h | 25 +++--
qom/object.c | 26 ++
2 files changed, 41 insertions(+), 10 deletions(-)
diff --git a/include/qemu/object.h b/include/qemu/object.h
index
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c | 61 ++---
1 files changed, 42 insertions(+), 19 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index dea287a..42b9b24 100644
--- a/hw/qdev-properties.c
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/qemu/object.h | 76 +++--
1 files changed, 73 insertions(+), 3 deletions(-)
diff --git a/include/qemu/object.h b/include/qemu/object.h
index ab1c48c..ad7d32d 100644
---
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/pc.c |7 +++
hw/pc.h |1 -
hw/pckbd.c |7 +--
hw/vmmouse.c | 11 +++
4 files changed, 11 insertions(+), 15 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 7f3aa65..76787c7 100644
--- a/hw/pc.c
+++
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/qemu/object.h | 22 +++---
1 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/include/qemu/object.h b/include/qemu/object.h
index 9d0251d..ab1c48c 100644
--- a/include/qemu/object.h
+++
Everything is already in place to turn the clock properties into links.
Cc: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/omap_clk.c |2 +-
hw/omap_gpio.c | 46 --
hw/omap_intc.c | 26
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
qom/object.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 4d21f0a..a89e9e3 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -368,9 +368,10 @@ void object_delete(Object
SMBus protocol sends offset and length before the actual data that
is transferred. So we need to skip two bytes rather than one.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/smbus.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/smbus.c b/hw/smbus.c
In some cases, a legacy property does need a special print method
but not a special parse method. In this case, we can reuse the get/set
from the static (non-legacy) property.
If neither parse nor print is needed, though, do not register the
legacy property at all. The previous patch ensures
PCI addresses are set with qdev_prop_uint32. Thus we make the QOM
property accept a device and function encoded in an 8-bit integer,
instead of the magic dd.f hex string.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c | 28 +---
1 files
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
qom/object.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 75be582..e8418bc 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -819,6 +819,12 @@ void
Do not poke anymore in the struct when accessing qdev properties.
Instead, ask the object to set the right value.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-addr.c |5 ++-
hw/qdev-properties.c | 78 ++---
hw/qdev.h
qdev_prop_set is not needed anymore except for hacks, simplify it and
inline it.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c | 26 +++---
1 files changed, 7 insertions(+), 19 deletions(-)
diff --git a/hw/qdev-properties.c
Pointer properties (except for PROP_PTR of course) should not need a
legacy counterpart. In the future, relative paths will ensure that
QEMU will support the same syntax as now for drives etc..
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/qdev-properties.c | 128
On Thu, Feb 2, 2012 at 01:49, Alexander Graf ag...@suse.de wrote:
Hi Blue / Aurelien,
This is my current patch queue for ppc. Please pull.
Thanks, pulled.
Alex
The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7:
Michael Roth (1):
main-loop: For tools,
On Tue, Jan 31, 2012 at 06:56, Wei Yang weiy...@linux.vnet.ibm.com wrote:
Tested on i386 platform.
Signed-off-by: Wei Yangweiy...@linux.vnet.ibm.com
Nack. Definitions should reside in files where they are used, only in
header files when they are used by multiple sources.
---
qemu-timer.c |
2012/1/31 Günther Schmidt gue.schm...@web.de:
Hi everyone,
I'm trying to build qemu on Oracle Solars 11 x64. I've figure out that I
need to set the --disable-guest-agent for ./configure, but there are other
errors I do not know how to fix.
Setting LD_LIBRARY_PATH to /usr/lib/mps/amd64 helps
Am 04.02.2012 03:43, schrieb Peter Maydell:
On 3 February 2012 20:58, Mark Langsdorf mark.langsd...@calxeda.com wrote:
Signed-off-by: Mark Langsdorf mark.langsd...@calxeda.com
---
MAINTAINERS |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS
Fix this error:
/src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
/src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
but not used [-Werror=unused-but-set-variable]
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
target-ppc/helper.c |3 ---
1 files
Thanks, applied.
On Sat, Feb 4, 2012 at 08:24, Stefan Weil s...@weilnetz.de wrote:
Commit a7c36ee4920ea3acc227a0248dd161693f207357 added code for a net
bridge and explicitly said that this is very Linux centric.
Indeed, compilation failed for w32, so the bridge code is now
conditional. Hosts
On Fri, Feb 3, 2012 at 23:41, Anthony Liguori aligu...@us.ibm.com wrote:
Untested but simple enough.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
There are still some problems, though build does not fail anymore:
CCusb-bsd.o
/src/qemu/usb-bsd.c:417: warning: initialization from
On Fri, Feb 3, 2012 at 12:02, Jan Kiszka jan.kis...@siemens.com wrote:
Helpful to understand guest configurations of things like the i440FX's
PAM.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
memory.c | 6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git
On 2012-02-04 13:12, Blue Swirl wrote:
On Fri, Feb 3, 2012 at 12:02, Jan Kiszka jan.kis...@siemens.com wrote:
Helpful to understand guest configurations of things like the i440FX's
PAM.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
memory.c |6 --
1 files changed, 4
On Sat, Feb 4, 2012 at 12:23, Jan Kiszka jan.kis...@web.de wrote:
On 2012-02-04 13:12, Blue Swirl wrote:
On Fri, Feb 3, 2012 at 12:02, Jan Kiszka jan.kis...@siemens.com wrote:
Helpful to understand guest configurations of things like the i440FX's
PAM.
Signed-off-by: Jan Kiszka
Thanks, pulled.
On Fri, Feb 3, 2012 at 14:49, riku.voi...@linaro.org wrote:
From: Riku Voipio riku.voi...@linaro.org
The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7:
main-loop: For tools, initialize timers as part of qemu_init_main_loop()
(2012-02-01 14:45:02
Hi all,
is there a .inf file that makes a Windows XP guest no longer complaining
about the missing drivers for the qemu host option -vga std?
I tried several manual Windows .inf file copies / merges, but either the
exclamation mark in the Device Manager persisted or it falls back to
640x480
Hello Paolo,
What will be fixed/enhanced by this patch?
Scenario?
Can you also add a more detailed commit message.
Thnx.
Ciao,
Gerhard
--
http://www.wiesinger.com/
On Sat, 4 Feb 2012, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/pc.c |7 +++
On Sun, Jan 29, 2012 at 19:12, Blue Swirl blauwir...@gmail.com wrote:
Patch 1 has been sent several times, though the logic has been copied
from flawed implementations before.
Other patches should be trivial.
Pushed. I compared vga.o object files with codiff and objdump
disassembler before
On 02/04/2012 02:03 PM, Gerhard Wiesinger wrote:
Hello Paolo,
What will be fixed/enhanced by this patch? Scenario?
Nothing, it's just a cleanup. It's a step towards removing PROP_PTR.
Paolo
I am barely able to understand this inline function:
static inline int sas_ss_flags(unsigned long sp)
{
return (target_sigaltstack_used.ss_size == 0 ? SS_DISABLE
: on_sig_stack(sp) ? SS_ONSTACK : 0);
}
(signal.c @97)
... and it seems wrong to me when used in the following
Am Donnerstag 02 Februar 2012, 22:12:48 schrieb Stefan Weil:
config.h was missing in cpu.h.
Cc: Michael Walle mich...@walle.cc
Signed-off-by: Stefan Weil s...@weilnetz.de
---
target-lm32/cpu.h |1 +
target-lm32/helper.c|5 -
target-lm32/translate.c |8
On 2012-02-04 13:32, Blue Swirl wrote:
On Sat, Feb 4, 2012 at 12:23, Jan Kiszka jan.kis...@web.de wrote:
On 2012-02-04 13:12, Blue Swirl wrote:
On Fri, Feb 3, 2012 at 12:02, Jan Kiszka jan.kis...@siemens.com wrote:
Helpful to understand guest configurations of things like the i440FX's
PAM.
From: Jan Kiszka jan.kis...@siemens.com
Helpful to understand guest configurations of things like the i440FX's
PAM or the state of ROM devices.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
Changes in v2:
- encode R and W separately
- print ROMD memory region state as well
memory.c |
The conversion to memory regions broke lazy ROMD switching by forgetting
to update the rom_mode state variable.
Signed-off-by: Jan Kiszka jan.kis...@web.de
---
hw/pflash_cfi02.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c
index
On Sat, Feb 4, 2012 at 14:57, Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
Helpful to understand guest configurations of things like the i440FX's
PAM or the state of ROM devices.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
Changes in v2:
- encode
From: Jan Kiszka jan.kis...@siemens.com
Helpful to understand guest configurations of things like the i440FX's
PAM or the state of ROM devices.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
Changes in v3:
- refactored writable condition (which DO makes sense as a ROM device
is either
On Fri, Feb 03, 2012 at 05:16:27PM -0200, Luiz Capitulino wrote:
On Fri, 03 Feb 2012 11:23:05 -0600
Michael Roth mdr...@linux.vnet.ibm.com wrote:
I'd been tracking Gerd's QMP wakeup series as the s3 resolution we need
for guest-suspend, is that still the case?
Yes. But now I remembered
On 2012-02-04 14:15, Blue Swirl wrote:
On Sun, Jan 29, 2012 at 19:12, Blue Swirl blauwir...@gmail.com wrote:
Patch 1 has been sent several times, though the logic has been copied
from flawed implementations before.
Other patches should be trivial.
Pushed. I compared vga.o object files with
On Sat, Feb 4, 2012 at 16:16, Jan Kiszka jan.kis...@web.de wrote:
On 2012-02-04 14:15, Blue Swirl wrote:
On Sun, Jan 29, 2012 at 19:12, Blue Swirl blauwir...@gmail.com wrote:
Patch 1 has been sent several times, though the logic has been copied
from flawed implementations before.
Other
On 02/04/2012 05:54 AM, Blue Swirl wrote:
On Fri, Feb 3, 2012 at 23:41, Anthony Liguorialigu...@us.ibm.com wrote:
Untested but simple enough.
Signed-off-by: Anthony Liguorialigu...@us.ibm.com
There are still some problems, though build does not fail anymore:
CCusb-bsd.o
On 02/04/2012 12:51 AM, Paolo Bonzini wrote:
On 02/04/2012 04:03 AM, Anthony Liguori wrote:
There's no object_ref() in qdev_device_add(). The 2 references come
from adding a child link to /peripheral and via object_new().
Sure, but there's when the object_new() reference becomes unreachable.
On Sat, Feb 4, 2012 at 17:07, Anthony Liguori anth...@codemonkey.ws wrote:
On 02/04/2012 05:54 AM, Blue Swirl wrote:
On Fri, Feb 3, 2012 at 23:41, Anthony Liguorialigu...@us.ibm.com wrote:
Untested but simple enough.
Signed-off-by: Anthony Liguorialigu...@us.ibm.com
There are still some
On Sat, Feb 4, 2012 at 17:26, Blue Swirl blauwir...@gmail.com wrote:
On Sat, Feb 4, 2012 at 17:07, Anthony Liguori anth...@codemonkey.ws wrote:
On 02/04/2012 05:54 AM, Blue Swirl wrote:
On Fri, Feb 3, 2012 at 23:41, Anthony Liguorialigu...@us.ibm.com wrote:
Untested but simple enough.
On 2012-02-04 18:39, Blue Swirl wrote:
Fix confusion in length calculation in commit
cd7a45c95ecf2404810f3c6becb7cb83c5010ad8.
Reported-by: Jan Kiszka jan.kis...@web.de
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/framebuffer.c |2 +-
hw/sm501.c |4 ++--
hw/vga.c
Thanks,
I'll check this problem.
Vadim.
- Original Message -
From: Charles.Tsai-蔡清海-研究發展部 charles.t...@cloudena.com
To: Charles.Tsai-蔡清海-研究發展部 charles.t...@cloudena.com, Vadim Rozenfeld
vroze...@redhat.com
Cc: Michael Roth mdr...@linux.vnet.ibm.com, Stefan Hajnoczi
stefa...@gmail.com,
Original Message
Subject: oVirt Beijing - March 21st
Date: Fri, 03 Feb 2012 15:52:41 -0500
From: Carl Trieloff cctriel...@redhat.com
Spread the word/ come join us!
http://www.ovirt.org/news-and-events/workshop/
Carl
Each target use #define marco (in target-xxx/cpu.h) to rename cpu_exec
(cpu-exec.c) to cpu_xxx_exec, then defines its own cpu_loop which calls
cpu_xxx_exec. So basically, cpu-exec.c is not i386 (only) emulator main
execution loop. This patch correctes the comment of this file and does
Hi,
starting your own toy kernel is a fun thing to do and there are many
tutorials out there on how to do it. Unfortunately when one wants to
write a kernel in 64bit it becomes much harder because one can't
compile 64bit code as elf32 image and converting a elf64 image to
elf32 format is a
On 4 February 2012 14:26, Alex Barcelo abarc...@ac.upc.edu wrote:
I am barely able to understand this inline function:
static inline int sas_ss_flags(unsigned long sp)
{
return (target_sigaltstack_used.ss_size == 0 ? SS_DISABLE
: on_sig_stack(sp) ? SS_ONSTACK : 0);
}
The Buildbot has detected a new failure on builder default_x86_64_fedora16
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_x86_64_fedora16/builds/164
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build:
Hello
Can I run code compiled for ARM920T core in QEMU?
I am learning Embedded Linux for ARM processor. This is very crucial for my
studies. In future will have to work on AT91RM9200 atmel board with ARM920T
cpu.
Embedded Linux version that I am working on is 2.6.17.
I am struggling to set up an
On 01/24/12 20:58, Markus Armbruster wrote:
Stefan Hajnoczistefa...@gmail.com writes:
On Tue, Jan 24, 2012 at 6:22 PM, Benjaminmlspira...@gmail.com wrote:
Hello Stefan,
Hi,
Please send QEMU development emails to the mailing list so others can
help or we can avoid duplicating work in case
72 matches
Mail list logo