[Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-13 Thread Amos Kong
VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked VMS_VARRAY_UINT32 bit of field-flags in vmstate_load_state(), but we don't check this bit in vmstate_save_state(). Signed-off-by: Amos Kong ak...@redhat.com --- savevm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH/RFC 3/7] Close socket when closing QEMUFile

2012-03-13 Thread Igor Mitsyanko
On 03/12/2012 05:11 PM, Marc-André Lureau wrote: --- migration-tcp.c |9 + migration-unix.c |9 + savevm.c |1 + 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index f567898..056867c 100644 ---

Re: [Qemu-devel] [Spice-devel] seamless migration with spice

2012-03-13 Thread Gerd Hoffmann
On 03/12/12 19:45, Yonit Halperin wrote: Hi, On 03/12/2012 03:50 PM, Gerd Hoffmann wrote: Hi, Can you explain/exemplify, why sending data as a blob (either by (a) or (b)), that is verified only by the two ends that actually use it, is a problem? It tends to be not very robust.

Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events

2012-03-13 Thread Gerd Hoffmann
On 03/12/12 16:50, Alon Levy wrote: On Mon, Mar 12, 2012 at 01:43:11PM +0200, Alon Levy wrote: On Mon, Mar 12, 2012 at 11:20:55AM +0100, Gerd Hoffmann wrote: On 03/11/12 20:26, Alon Levy wrote: dprint is still used for qxl_init_common one time prints. I think we shouldn't simply convert the

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-13 Thread Wen Congyang
At 03/12/2012 06:33 PM, Avi Kivity Wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to only be used by Linux, which has kexec facilities, and you can put talk to

[Qemu-devel] [Bug 953754] [NEW] one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows): Linux(RHEL6u1) kvm.git Commit:186195928e8149b27cdd603a660dace454969f2b qemu-kvm Commit: 81bdec908fb2be0ccaff1d4ee67956c509e440ad Host Kernel

Re: [Qemu-devel] [PULL] Update seabios to 1.6.3.2

2012-03-13 Thread Gerd Hoffmann
Hi, How extensively did you test the new seabios changes and are you able to recreate? Given the small number of changes just a quick smoke test (boot linux guest). gcc version 4.6.1 (Ubuntu/Linaro 4.6.1-9ubuntu3) gcc (GCC) 4.4.6 20110731 (Red Hat 4.4.6-3) GNU ld version

Re: [Qemu-devel] [Spice-devel] seamless migration with spice

2012-03-13 Thread Yonit Halperin
Hi, On 03/13/2012 08:40 AM, Gerd Hoffmann wrote: On 03/12/12 19:45, Yonit Halperin wrote: Hi, On 03/12/2012 03:50 PM, Gerd Hoffmann wrote: Hi, Can you explain/exemplify, why sending data as a blob (either by (a) or (b)), that is verified only by the two ends that actually use it, is a

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
** Attachment added: guest dmesg log https://bugs.launchpad.net/qemu/+bug/953754/+attachment/2861052/+files/dmesg-guest.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/953754 Title: one of

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
** Attachment added: lspci -vvv 82576 NIC in guest https://bugs.launchpad.net/qemu/+bug/953754/+attachment/2861057/+files/lspci-guest-82576.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
** Description changed: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows): Linux(RHEL6u1) kvm.git Commit:186195928e8149b27cdd603a660dace454969f2b qemu-kvm Commit: 81bdec908fb2be0ccaff1d4ee67956c509e440ad Host

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
** Attachment added: lspci -vvv 82576 NIC in host https://bugs.launchpad.net/qemu/+bug/953754/+attachment/2861055/+files/lspci-host-82576.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/953754

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
** Attachment added: lspci -vvv I350 NIC in host https://bugs.launchpad.net/qemu/+bug/953754/+attachment/2861054/+files/lspci-host-I350.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/953754

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
** Attachment added: host dmesg log https://bugs.launchpad.net/qemu/+bug/953754/+attachment/2861051/+files/dmesg-host.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/953754 Title: one of the

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
And if you try with smp=4, you may see some error info from qemu. assigned_dev_update_msix_mmio: No such device or address fail to set MSI-X entry number for MSIX! Invalid argument The message is generated from the funtion assigned_dev_update_msix_mmio in hw/device-assignment.c 1035 r =

Re: [Qemu-devel] [Spice-devel] seamless migration with spice

2012-03-13 Thread Gerd Hoffmann
Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more complicated if you can avoid it. Especially since there is no functional reason for making the qemu/client capabilities/versions dependent on the server internal

[Qemu-devel] [Bug 953754] Re: one of the two assigned NICs doesn’t work in SMP guest.

2012-03-13 Thread Yongjie Ren
** Attachment added: lspci -vvv I350 NIC in guest https://bugs.launchpad.net/qemu/+bug/953754/+attachment/2861056/+files/lspci-guest-I350.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/953754

Re: [Qemu-devel] [PATCH/RFC 4/7] Allow saving screendump to a UNIX socket

2012-03-13 Thread Gerd Hoffmann
Hi, By using the 'unix:' prefix notation, similar to the migration uri, we can now dump to a UNIX socket. IO is still sync hw/vga.c| 64 +- This calls for a screendump.c IMHO. vga.c is big enougth already and screendump hasn't

Re: [Qemu-devel] qom: add test tools (resend from qom: dynamic properties)

2012-03-13 Thread Zhi Yong Wu
On Tue, Feb 21, 2012 at 4:50 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: AFAICT tell the qom tool got dropped from Anthony's qom: dynamic properties and composition tree series due to some hardcoded paths for the QMP socket. I've since ended up adding support for user-specified paths to

Re: [Qemu-devel] [PATCH V2 0/2] QOM: small object creation fix

2012-03-13 Thread Igor Mitsyanko
On 02/28/2012 03:57 PM, Igor Mitsyanko wrote: Eliminate impossibility of creating objects of types with @instance_size == 0. v1-v2: type's instance size now initialized during type initialization. type_class_init() renamed (in additional patch) Igor Mitsyanko (2): qom: if

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-13 Thread Itamar Heim
On 03/12/2012 10:19 PM, Ayal Baron wrote: - Original Message - On 03/12/2012 02:12 PM, Itamar Heim wrote: On 03/12/2012 09:01 PM, Anthony Liguori wrote: It's a trade off. From a RAS perspective, it's helpful to have information about the host available in the guest. If you're

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-13 Thread Avi Kivity
On 03/13/2012 08:44 AM, Wen Congyang wrote: At 03/12/2012 06:33 PM, Avi Kivity Wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to only be used by Linux,

Re: [Qemu-devel] [PATCH 3/4 v2 RESEND] block: add dirty flag status to qemu-img

2012-03-13 Thread Kevin Wolf
Am 12.03.2012 19:18, schrieb Stefan Hajnoczi: On Wed, Mar 07, 2012 at 05:22:58PM +0800, Dong Xu Wang wrote: From: Dong Xu Wang wdon...@linux.vnet.ibm.com Some block drivers can verify their image files are clean or not. So we can show it while using qemu-img info. Signed-off-by: Dong Xu

[Qemu-devel] [V4 PATCH 0/5] Send the gratuitous packets by guest

2012-03-13 Thread Jason Wang
This an update of series that let guest and qemu to be co-operated to send gratuitous packets when needed such as after migration, loadvm and continuing. As it's hard for qemu to track the network configuration in guest such as bondings, vlans or ipv6. So current gratuitous may not work under

[Qemu-devel] [V4 PATCH 2/5] net: announce self after vm start

2012-03-13 Thread Jason Wang
This patch moves qemu_announce_self() to vm_start() and add a new parameters to control whether sending gratuitous packet is needed. There are several reasons to do this: - Gratuitous packet is also needed when we resume a stopped vm or successfully load a state. - Sending gratuitous packets

[Qemu-devel] [V4 PATCH 1/5] net: reset the count after rounds of announcing

2012-03-13 Thread Jason Wang
As it would be called after continue a stopped guest. Signed-off-by: Jason Wang jasow...@redhat.com --- savevm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 80be1ff..5b59826 100644 --- a/savevm.c +++ b/savevm.c @@ -144,6 +144,7 @@ static

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Peter Maydell
On 13 March 2012 00:16, Anthony Liguori anth...@codemonkey.ws wrote: I think this is a good demonstration of what the problem is.  Unclear responsibility.  I'm pretty sure that Blue thought that Alex would handle the patch.  I'm pretty sure that Alex thought Blue would handle the patch. Yes,

Re: [Qemu-devel] [V4 PATCH 2/5] net: announce self after vm start

2012-03-13 Thread Paolo Bonzini
Il 13/03/2012 09:56, Jason Wang ha scritto: This patch moves qemu_announce_self() to vm_start() and add a new parameters to control whether sending gratuitous packet is needed. There are several reasons to do this: - Gratuitous packet is also needed when we resume a stopped vm or

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-13 Thread Daniel P. Berrange
On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to only be used by Linux, which has kexec facilities, and

Re: [Qemu-devel] [PATCH v1 09/12] net: Rename non_vlan_clients to net_clients

2012-03-13 Thread Mark Wu
On 03/09/2012 05:00 PM, zwu.ker...@gmail.com wrote: From: Stefan Hajnoczistefa...@linux.vnet.ibm.com There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to

[Qemu-devel] [V4 PATCH 3/5] net: model specific announcing support

2012-03-13 Thread Jason Wang
This patch introduces a function pointer in NetClientInfo which is called during self announcement. With this, each kind of card can announce the link with a specific way. The old method is still kept for cards that have not implemented this or old guest. The first user would be virtio-net.

[Qemu-devel] [V4 PATCH 5/5] virtio-net: compat guest announce support.

2012-03-13 Thread Jason Wang
Disable guest announce for compat machine types. Signed-off-by: Jason Wang jasow...@redhat.com --- hw/pc_piix.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 6c5c40f..780b607 100644 --- a/hw/pc_piix.c

Re: [Qemu-devel] [PATCH v1 09/12] net: Rename non_vlan_clients to net_clients

2012-03-13 Thread Zhi Yong Wu
On Tue, Mar 13, 2012 at 5:23 PM, Mark Wu wu...@linux.vnet.ibm.com wrote: On 03/09/2012 05:00 PM, zwu.ker...@gmail.com wrote: From: Stefan Hajnoczistefa...@linux.vnet.ibm.com There is no longer a distinction between vlan clients and non-vlan clients in the net core.  The net core only knows

[Qemu-devel] [V4 PATCH 4/5] virtio-net: notify guest to annouce itself

2012-03-13 Thread Jason Wang
It's hard to track all mac addresses and their usage (vlan, bondings, ipv6) in qemu to send proper gratuitous packet. The better choice is to let guest to send them. So, this patch introduces a new rw config status bit of virtio-net, VIRTIO_NET_S_ANNOUNCE which is used to notify guest to announce

Re: [Qemu-devel] [PATCH 3/4 v2 RESEND] block: add dirty flag status to qemu-img

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 10:03:51AM +0100, Kevin Wolf wrote: Am 12.03.2012 19:18, schrieb Stefan Hajnoczi: On Wed, Mar 07, 2012 at 05:22:58PM +0800, Dong Xu Wang wrote: From: Dong Xu Wang wdon...@linux.vnet.ibm.com Some block drivers can verify their image files are clean or not. So we

Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events

2012-03-13 Thread Alon Levy
On Tue, Mar 13, 2012 at 07:42:17AM +0100, Gerd Hoffmann wrote: On 03/12/12 16:50, Alon Levy wrote: On Mon, Mar 12, 2012 at 01:43:11PM +0200, Alon Levy wrote: On Mon, Mar 12, 2012 at 11:20:55AM +0100, Gerd Hoffmann wrote: On 03/11/12 20:26, Alon Levy wrote: dprint is still used for

Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events

2012-03-13 Thread Gerd Hoffmann
Hi, What about having the frequent (read: too frequent to use stderr to dump them since they clutter the screen, unless you 'stop' before each monitor command) have a postfix _freq? This is a stopgap, but helpful one, you can then do: trace-event qxl* on trace-event qxl*freq off

Re: [Qemu-devel] [PATCH] slirp: Fix compiler warning for w64

2012-03-13 Thread Jan Kiszka
On 2012-03-10 21:20, Stefan Weil wrote: Casting a pointer to an integer value must use uintptr_t or intptr_t (not long) for portable code. MinGW-w64 requires this because sizeof(long) != sizeof(void *) for w64 hosts, so casting to long raises a compiler warning. I use uintptr_t instead of

Re: [Qemu-devel] [PATCH] qcow2: Remove unused parameter in get_cluster_table()

2012-03-13 Thread Stefan Hajnoczi
On Mon, Mar 12, 2012 at 4:48 PM, Kevin Wolf kw...@redhat.com wrote: Since everything goes through the cache, callers don't use the L2 table offset any more. Signed-off-by: Kevin Wolf kw...@redhat.com ---  block/qcow2-cluster.c |   18 --  1 files changed, 8 insertions(+), 10

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-13 Thread Gerd Hoffmann
On 03/13/12 05:22, Benjamin Herrenschmidt wrote: As such I would rather fix the access locations instead. This basically means adding this small patch on top of my previous one (I haven't spotted any other error) : Squashed into the original patch and added to the usb patch queue. cheers,

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-13 Thread Lai Jiangshan
On 02/16/2012 08:51 PM, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = cpu-pc, +.qdev.size = sizeof(CPUPC), +.qdev.reset = cpu_device_reset, +.init =

Re: [Qemu-devel] [PATCH 3/4 v2 RESEND] block: add dirty flag status to qemu-img

2012-03-13 Thread Kevin Wolf
Am 13.03.2012 10:33, schrieb Stefan Hajnoczi: On Tue, Mar 13, 2012 at 10:03:51AM +0100, Kevin Wolf wrote: Am 12.03.2012 19:18, schrieb Stefan Hajnoczi: On Wed, Mar 07, 2012 at 05:22:58PM +0800, Dong Xu Wang wrote: From: Dong Xu Wang wdon...@linux.vnet.ibm.com Some block drivers can verify

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket in PNG format

2012-03-13 Thread Jan Kiszka
On 2012-03-12 22:22, Michael Roth wrote: On Mon, Mar 12, 2012 at 01:57:14PM -0500, Anthony Liguori wrote: On 03/12/2012 01:56 PM, Marc-André Lureau wrote: On Mon, Mar 12, 2012 at 7:53 PM, Anthony Liguorianth...@codemonkey.ws wrote: Why not just return the screendump through QMP? in

Re: [Qemu-devel] [PATCH 1/3] ide: Adds model=s qdev option, allowing the user to override the default disk model name QEMU HARDDISK

2012-03-13 Thread Stefan Hajnoczi
On Mon, Mar 12, 2012 at 8:05 PM, Floris Bos b...@je-eigen-domein.nl wrote: Some Linux distributions use the /dev/disk/by-id/scsi-SATA_name-of-disk-model_serial addressing scheme when refering to partitions in /etc/fstab and elsewhere. This causes problems when starting a disk image taken from

Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events

2012-03-13 Thread Alon Levy
On Tue, Mar 13, 2012 at 10:47:54AM +0100, Gerd Hoffmann wrote: Hi, What about having the frequent (read: too frequent to use stderr to dump them since they clutter the screen, unless you 'stop' before each monitor command) have a postfix _freq? This is a stopgap, but helpful one, you

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-13 Thread Gerd Hoffmann
Hi, I do to, except when they fix broken behaviour. More seriously, do you have other concerns with the mixemu code? Sure - it adds overhead. The point of this patchset is to kill the overhead if possible, i.e. try to pass down the volume the guest asked for all the way down to the

Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events

2012-03-13 Thread Alon Levy
On Tue, Mar 13, 2012 at 10:47:54AM +0100, Gerd Hoffmann wrote: Hi, What about having the frequent (read: too frequent to use stderr to dump them since they clutter the screen, unless you 'stop' before each monitor command) have a postfix _freq? This is a stopgap, but helpful one, you

Re: [Qemu-devel] [PATCH 3/3] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name

2012-03-13 Thread Stefan Hajnoczi
On Mon, Mar 12, 2012 at 8:05 PM, Floris Bos b...@je-eigen-domein.nl wrote: diff --git a/hw/ide/core.c b/hw/ide/core.c index 3e50c52..b48e5c2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -166,6 +166,13 @@ static void ide_identify(IDEState *s)     if (dev dev-conf.discard_granularity) {

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-13 Thread Kevin Wolf
Am 13.03.2012 11:19, schrieb Gerd Hoffmann: Hi, I do to, except when they fix broken behaviour. More seriously, do you have other concerns with the mixemu code? Sure - it adds overhead. The point of this patchset is to kill the overhead if possible, i.e. try to pass down the volume

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-13 Thread Gerd Hoffmann
On 03/13/12 11:33, Kevin Wolf wrote: Am 13.03.2012 11:19, schrieb Gerd Hoffmann: Hi, I do to, except when they fix broken behaviour. More seriously, do you have other concerns with the mixemu code? Sure - it adds overhead. The point of this patchset is to kill the overhead if possible,

Re: [Qemu-devel] [PATCH 07/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers

2012-03-13 Thread David Gibson
On Fri, Mar 09, 2012 at 11:11:41AM +0100, Paolo Bonzini wrote: Il 09/03/2012 06:01, David Gibson ha scritto: [snip] +static void dma_bdrv_cancel(void *opaque) +{ +DMAAIOCB *dbs = opaque; + +bdrv_aio_cancel(dbs-acb); +dma_bdrv_unmap(dbs); +qemu_iovec_destroy(dbs-iov);

[Qemu-devel] [PATCH 1/2] return available ioeventfds count in kvm_has_many_ioeventfds()

2012-03-13 Thread Amos Kong
Older kernels have a 6 device limit on the KVM io bus. This patch makes kvm_has_many_ioeventfds() return available ioeventfd count. ioeventfd will be disabled if there is no 7 available ioeventfds. Signed-off-by: Amos Kong ak...@redhat.com --- hw/virtio-pci.c |2 +- kvm-all.c |9

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Andreas Färber
Am 12.03.2012 19:03, schrieb Lluís Vilanova: Stefano Stabellini writes: [...] Patches are being posted to the list that don't get any reviews at all. Other patches get reviewed the first time, then once they are reposted they don't get any other reviews or acked-by or reviewed-by. What are

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Stefan Hajnoczi
On Mon, Mar 12, 2012 at 8:43 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 12 March 2012 20:29, Anthony Liguori anth...@codemonkey.ws wrote: On 03/12/2012 03:24 PM, Peter Maydell wrote: I agree that that's a specific area it would be nice to do better in. It seems to me that the

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Stefan Hajnoczi
On Mon, Mar 12, 2012 at 8:12 PM, Stefan Weil s...@weilnetz.de wrote: Am 12.03.2012 18:06, schrieb Stefano Stabellini: Maybe every maintainer can maintain a short summary of what he maintains, how (s)he does it (repository, expected response time, ...) in the QEMU wiki. I just added

[Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Amos Kong
Boot up guest with 232 virtio-blk disk, qemu will abort for fail to allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), and check if available ioeventfd exists. If not, virtio-pci will fallback to userspace, and don't use ioeventfd for io notification. --- Amos Kong (2):

[Qemu-devel] [PATCH 2/2] virtio-pci: fallback to userspace when there is no enough available ioeventfd

2012-03-13 Thread Amos Kong
Qemu already supported multiple function devices, pci-bridge would support more pci devices. But iobus dev in kernel are limited. If there is no enough available ioeventfd, then clean VIRTIO_PCI_FLAG_USE_IOEVENTFD bit, virtio-pci would fallback to userspace. Signed-off-by: Amos Kong

[Qemu-devel] [PATCH 1/2] return available ioeventfds count in kvm_has_many_ioeventfds()

2012-03-13 Thread Amos Kong
Older kernels have a 6 device limit on the KVM io bus. This patch makes kvm_has_many_ioeventfds() return available ioeventfd count. ioeventfd will be disabled if there is no 7 available ioeventfds. Signed-off-by: Amos Kong ak...@redhat.com --- hw/virtio-pci.c |2 +- kvm-all.c |9

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-13 Thread Benjamin Herrenschmidt
On Tue, 2012-03-13 at 10:57 +0100, Gerd Hoffmann wrote: On 03/13/12 05:22, Benjamin Herrenschmidt wrote: As such I would rather fix the access locations instead. This basically means adding this small patch on top of my previous one (I haven't spotted any other error) : Squashed into the

Re: [Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices

2012-03-13 Thread Paolo Bonzini
Il 05/03/2012 15:05, Peter Maydell ha scritto: Direct usage of rt_clock should be discouraged. For RTC devices the user cannot choose to follow the host clock with respect to NTP adjustment and daylight savings changes. For other devices it does not provide determinism together with

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-13 Thread Avi Kivity
On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket in PNG format

2012-03-13 Thread Stefan Hajnoczi
On Mon, Mar 12, 2012 at 7:27 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: On Mon, Mar 12, 2012 at 7:06 PM, Stefan Hajnoczi stefa...@gmail.com wrote: I think ppm for lossless and png for small file size are good options to have.  Beyond that it's up to the caller to deal with the

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Stefano Stabellini
On Mon, 12 Mar 2012, Michael Roth wrote: Thanks Stefano. I plan on doing a lot of work with migration in the future, and as such try to keep tabs on the migration-related stuff on qemu-devel. I often don't get around to actually reviewing things though, and that's been nagging me for a while

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-13 Thread Marc-André Lureau
On Tue, Mar 13, 2012 at 11:19 AM, Gerd Hoffmann kra...@redhat.com wrote: I think we should remove the mixemu configure option.  It makes code bitrot.  Patch #4 proves that.  If you want to keep it because of the overhead or other reasons I'd suggest to make it a runtime option. To be fair, the

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-13 Thread Andreas Färber
Am 13.03.2012 10:32, schrieb Lai Jiangshan: On 02/16/2012 08:51 PM, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = cpu-pc, +.qdev.size = sizeof(CPUPC), +

Re: [Qemu-devel] [PATCHv3 3/9] allow qemu_iovec_from_buffer() to specify offset from which to start copying

2012-03-13 Thread Kevin Wolf
Am 12.03.2012 20:14, schrieb Michael Tokarev: Similar to qemu_iovec_memset(QEMUIOVector *qiov, size_t offset, int c, size_t bytes); the new prototype is: qemu_iovec_from_buf(QEMUIOVector *qiov, size_t offset, const void *buf, size_t bytes); The

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket in PNG format

2012-03-13 Thread Marc-André Lureau
Hi - Mensaje original - Yeah it wants png, jpeg, tiff. What I'm concerned about is that QEMU should be doing emulation/virtualization, not processing images for an end-user. Its main loop is not structured to do utility tasks unrelated to running the guest. If implemented properly

Re: [Qemu-devel] [PATCH v2] block: push recursive flushing up from drivers

2012-03-13 Thread Kevin Wolf
Am 12.03.2012 18:26, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 22 ++ block/blkdebug.c |7 --- block/cow.c |6 -- block/qcow.c |6 -- block/qcow2.c|6 -- block/qed.c

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket in PNG format

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 11:14 AM, Marc-André Lureau mlur...@redhat.com wrote: Hi - Mensaje original - Yeah it wants png, jpeg, tiff.  What I'm concerned about is that QEMU should be doing emulation/virtualization, not processing images for an end-user.  Its main loop is not

[Qemu-devel] Minimal ARM LPAE support

2012-03-13 Thread Alexey Starikovskiy
Minimal ARM LPAE support. Sufficient to boot Linux kernel on vexpress-a15 Signed-off-by: Alexey Starikovskiy aysta...@gmail.com --- target-arm/cpu.h | 11 +- target-arm/helper.c| 239 target-arm/helper.h|2

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 10:42 AM, Amos Kong ak...@redhat.com wrote: Boot up guest with 232 virtio-blk disk, qemu will abort for fail to allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), and check if available ioeventfd exists. If not, virtio-pci will fallback to userspace,

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Kevin Wolf
Am 12.03.2012 18:34, schrieb Stefano Stabellini: On Mon, 12 Mar 2012, Anthony Liguori wrote: On 03/12/2012 12:06 PM, Stefano Stabellini wrote: Hi all, I don't mean to steer any controversy or start any flame wars here, but rather I want to point out a problem in the QEMU Community that is

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Stefano Stabellini
On Mon, 12 Mar 2012, Anthony Liguori wrote: OK, so the actual problem seems to be that not all the source files that are supposed to be Supported are actually supported. And of course some key files, like savevm.c are not even Maintained!! For example if I am not mistaken we are missing an

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-03-13 Thread Peter Lieven
On 11.02.2012 09:55, Corentin Chary wrote: On Thu, Feb 9, 2012 at 7:08 PM, Peter Lievenp...@dlh.net wrote: Hi, is anyone aware if there are still problems when enabling the threaded vnc server? I saw some VMs crashing when using a qemu-kvm build with --enable-vnc-thread. qemu-kvm-1.0[22646]:

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Stefano Stabellini
On Tue, 13 Mar 2012, Kevin Wolf wrote: Am 12.03.2012 18:34, schrieb Stefano Stabellini: On Mon, 12 Mar 2012, Anthony Liguori wrote: On 03/12/2012 12:06 PM, Stefano Stabellini wrote: Hi all, I don't mean to steer any controversy or start any flame wars here, but rather I want to point

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-13 Thread David Gibson
On Tue, Mar 13, 2012 at 10:57:37AM +0100, Gerd Hoffmann wrote: On 03/13/12 05:22, Benjamin Herrenschmidt wrote: As such I would rather fix the access locations instead. This basically means adding this small patch on top of my previous one (I haven't spotted any other error) : Squashed

Re: [Qemu-devel] [PATCH 07/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers

2012-03-13 Thread David Gibson
On Fri, Mar 09, 2012 at 10:43:35AM +0100, Kevin Wolf wrote: Am 09.03.2012 06:01, schrieb David Gibson: [snip] @@ -104,10 +104,20 @@ static void dma_complete(DMAAIOCB *dbs, int ret) } } +static void dma_bdrv_cancel(void *opaque) +{ +DMAAIOCB *dbs = opaque; + +

Re: [Qemu-devel] [PATCH RESEND v5 2/6] Introduce save_devices

2012-03-13 Thread Stefano Stabellini
On Mon, 12 Mar 2012, Anthony Liguori wrote: On 02/28/2012 09:51 AM, Stefano Stabellini wrote: - add an is_ram flag to SaveStateEntry; - add an is_ram parameter to register_savevm_live; - introduce a save_devices monitor command that can be used to save the state of non-ram devices.

Re: [Qemu-devel] [PATCH 1/2] return available ioeventfds count in kvm_has_many_ioeventfds()

2012-03-13 Thread Jan Kiszka
Please tag uq/master patches with PATCH uq/master. On 2012-03-13 11:42, Amos Kong wrote: Older kernels have a 6 device limit on the KVM io bus. This patch makes kvm_has_many_ioeventfds() return available ioeventfd count. ioeventfd will be disabled if there is no 7 available ioeventfds.

Re: [Qemu-devel] [PATCH 07/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers

2012-03-13 Thread Kevin Wolf
Am 13.03.2012 11:42, schrieb David Gibson: On Fri, Mar 09, 2012 at 10:43:35AM +0100, Kevin Wolf wrote: Am 09.03.2012 06:01, schrieb David Gibson: [snip] @@ -104,10 +104,20 @@ static void dma_complete(DMAAIOCB *dbs, int ret) } } +static void dma_bdrv_cancel(void *opaque) +{ +

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Amos Kong
On 13/03/12 19:23, Stefan Hajnoczi wrote: On Tue, Mar 13, 2012 at 10:42 AM, Amos Kongak...@redhat.com wrote: Boot up guest with 232 virtio-blk disk, qemu will abort for fail to allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), and check if available ioeventfd exists. If not,

Re: [Qemu-devel] [PATCH 1/2] return available ioeventfds count in kvm_has_many_ioeventfds()

2012-03-13 Thread Amos Kong
On 13/03/12 19:50, Jan Kiszka wrote: Please tag uq/master patches with PATCH uq/master. On 2012-03-13 11:42, Amos Kong wrote: Older kernels have a 6 device limit on the KVM io bus. This patch makes kvm_has_many_ioeventfds() return available ioeventfd count. ioeventfd will be disabled if there

Re: [Qemu-devel] [PATCH] aio: move BlockDriverAIOCB to qemu-aio.h

2012-03-13 Thread Kevin Wolf
Am 12.03.2012 17:01, schrieb Paolo Bonzini: And remove several block_int.h inclusions that should not be there. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 3/3] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name

2012-03-13 Thread Kevin Wolf
Am 13.03.2012 11:29, schrieb Stefan Hajnoczi: On Mon, Mar 12, 2012 at 8:05 PM, Floris Bos b...@je-eigen-domein.nl wrote: diff --git a/hw/ide/core.c b/hw/ide/core.c index 3e50c52..b48e5c2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -166,6 +166,13 @@ static void ide_identify(IDEState *s)

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-13 Thread malc
On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: On Tue, Mar 13, 2012 at 11:19 AM, Gerd Hoffmann kra...@redhat.com wrote: I think we should remove the mixemu configure option.  It makes code bitrot.  Patch #4 proves that.  If you want to keep it because of the overhead or other reasons I'd

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Paolo Bonzini
Il 13/03/2012 12:27, Kevin Wolf ha scritto: Point taken. However maintainers should also be responsible of reviewing patches of infrequent write-only contributors. Yes, but maintainers are overloaded because they also need to review patches of frequent write-only contributors. Frequent

Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

2012-03-13 Thread Andreas Färber
Am 12.03.2012 10:38, schrieb Igor Mammedov: On 03/10/2012 03:28 AM, Andreas Färber wrote: Reintroduce CPUState as QOM object: It's abstract and derived directly from TYPE_OBJECT for compatibility with the user emulators. The identifier CPUState avoids conflicts between CPU() and the struct.

[Qemu-devel] [PATCH 03/14] usb-ehci: drop unused isoch_pause variable

2012-03-13 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-ehci.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 58811d3..60f9f5b

[Qemu-devel] [PATCH 11/14] uhci: renumber uhci_handle_td return codes

2012-03-13 Thread Gerd Hoffmann
Step #2 (separate for better bisectability): renumber so the silly '-1' goes away. Pick a range which doesn't overlap the old values. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-uhci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 08/14] uhci: cancel on schedule stop.

2012-03-13 Thread Gerd Hoffmann
Cancel any in-flight transaction when the guest stops the uhci schedule. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-uhci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 416f703..5177e33 100644 ---

[Qemu-devel] main-system-bus

2012-03-13 Thread Wanpeng Li
Hi all: I am confused with what's the meaning of main-system-bus, it emulates physical bus like FSB(front side bus) or just a virtual bus as the root of device tree. Regards, Wanpeng Li

Re: [Qemu-devel] [PATCH 1/2] return available ioeventfds count in kvm_has_many_ioeventfds()

2012-03-13 Thread Jan Kiszka
On 2012-03-13 13:00, Amos Kong wrote: On 13/03/12 19:50, Jan Kiszka wrote: Please tag uq/master patches with PATCH uq/master. On 2012-03-13 11:42, Amos Kong wrote: Older kernels have a 6 device limit on the KVM io bus. This patch makes kvm_has_many_ioeventfds() return available ioeventfd

Re: [Qemu-devel] [PATCH 3/3] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name

2012-03-13 Thread Floris Bos / Maxnet
On 03/13/2012 01:06 PM, Kevin Wolf wrote: Am 13.03.2012 11:29, schrieb Stefan Hajnoczi: On Mon, Mar 12, 2012 at 8:05 PM, Floris Bosb...@je-eigen-domein.nl wrote: diff --git a/hw/ide/core.c b/hw/ide/core.c index 3e50c52..b48e5c2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -166,6 +166,13

Re: [Qemu-devel] [PATCH RFC v4 02/20] target-arm: Introduce QOM ARMCPUClass

2012-03-13 Thread Igor Mitsyanko
On 03/10/2012 08:53 PM, Andreas Färber wrote: Create a CPU subclass, and register classes matching all CPU models except for pxa270, which is an alias for pxa270-a0. Let arm_cpu_list() enumerate CPU subclasses in alphabetical order, except for special value any. Replace

[Qemu-devel] [PATCH 3/3] [v2] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name

2012-03-13 Thread Floris Bos
Linux guests can address disks by their unique World Wide Name number (e.g. /dev/disk/by-id/wwn-0x5001517959123522) This patch adds support for assigning a World Wide Name number to a virtual IDE disk. Cc: kw...@redhat.com Signed-off-by: Floris Bos d...@noc-ps.com --- hw/ide/core.c | 29

Re: [Qemu-devel] main-system-bus

2012-03-13 Thread Andreas Färber
Hi, Am 13.03.2012 13:23, schrieb Wanpeng Li: I am confused with what's the meaning of main-system-bus, it emulates physical bus like FSB(front side bus) or just a virtual bus as the root of device tree. The latter. It's an artificial construct that was needed for tree-oriented qdev and is

Re: [Qemu-devel] [PATCH v11 0/9] PC system flash support

2012-03-13 Thread Paolo Bonzini
Il 22/02/2012 08:18, Jordan Justen ha scritto: Enable flash emulation in a PC system using pflash_cfi01. Jordan, can you document this on the wiki (http://wiki.qemu.org/ChangeLog/1.1#x86)? I found http://wiki.qemu.org/Features/PC_System_Flash but I do not really understand what it is used for

[Qemu-devel] [RfC PATCH] usb/vmstate: add parent dev path

2012-03-13 Thread Gerd Hoffmann
... to make vmstate id string truely unique with multiple host controllers, i.e. move from 1/usb-ptr to :00:01.3/1/usb-ptr (usb tabled connected to piix3 uhci). This is needed in case you have multiple USB busses in a virtual machine to make sure the section names are unique. Obviously this

[Qemu-devel] [PATCH 06/14] uhci: pass addr to uhci_async_alloc

2012-03-13 Thread Gerd Hoffmann
Also do async-td initialization in uhci_async_alloc now. Prepares for adding tracepoints. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-uhci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index

[Qemu-devel] [PATCH 09/14] uhci: tracing support

2012-03-13 Thread Gerd Hoffmann
Zap DPRINTF, add tracepoints instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-uhci.c | 87 +++- trace-events | 31 +++ 2 files changed, 63 insertions(+), 55 deletions(-) diff --git a/hw/usb/hcd-uhci.c

  1   2   3   4   >