Re: [Qemu-devel] [RFC][PATCH 05/14 v9] Add API to get memory mapping

2012-03-16 Thread HATAYAMA Daisuke
From: Wen Congyang we...@cn.fujitsu.com Subject: [RFC][PATCH 05/14 v9] Add API to get memory mapping Date: Wed, 14 Mar 2012 10:07:48 +0800 Add API to get all virtual address and physical address mapping. If the guest doesn't use paging, the virtual address is equal to the phyical address. The

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-16 Thread Wen Congyang
At 03/16/2012 11:23 AM, HATAYAMA Daisuke Wrote: From: Wen Congyang we...@cn.fujitsu.com Subject: [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory Date: Wed, 14 Mar 2012 10:11:35 +0800 +/* + * QEMU dump + * + * Copyright Fujitsu, Corp. 2011 + * Now

Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file

2012-03-16 Thread Wen Congyang
At 03/16/2012 09:48 AM, HATAYAMA Daisuke Wrote: From: Wen Congyang we...@cn.fujitsu.com Subject: [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file Date: Wed, 14 Mar 2012 10:09:26 +0800 +memset(note, 0, note_size); +if (type == 0) { +note32 =

Re: [Qemu-devel] [RFC][PATCH 05/14 v9] Add API to get memory mapping

2012-03-16 Thread Wen Congyang
At 03/16/2012 11:52 AM, HATAYAMA Daisuke Wrote: From: Wen Congyang we...@cn.fujitsu.com Subject: [RFC][PATCH 05/14 v9] Add API to get memory mapping Date: Wed, 14 Mar 2012 10:07:48 +0800 } + +int qemu_get_guest_memory_mapping(MemoryMappingList *list) +{ +CPUState *env; +

Re: [Qemu-devel] [RFC][PATCH 05/14 v9] Add API to get memory mapping

2012-03-16 Thread Wen Congyang
At 03/16/2012 02:38 PM, HATAYAMA Daisuke Wrote: From: Wen Congyang we...@cn.fujitsu.com Subject: [RFC][PATCH 05/14 v9] Add API to get memory mapping Date: Wed, 14 Mar 2012 10:07:48 +0800 Add API to get all virtual address and physical address mapping. If the guest doesn't use paging, the

Re: [Qemu-devel] qemu gdb issue

2012-03-16 Thread Jacques
Hi Mulyadi, I see what you mean. How do I know if this is happening? When I do 'x/i $eip' I get a completely sane result with exactly the instructions I want. On 03/15/2012 07:13 PM, Mulyadi Santosa wrote: Hi... On Thu, Mar 15, 2012 at 23:03, Jacques jacq...@rambo-mes.net wrote: I'm running

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-03-16 Thread Martin Pitt
Is this still an issue in the -vmware package now? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/918791 Title: qemu-kvm dies when using vmvga driver and unity in the guest Status in QEMU: New

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-16 Thread Wen Congyang
At 03/15/2012 07:46 PM, Avi Kivity Wrote: On 03/15/2012 01:25 PM, Jan Kiszka wrote: There was such vm exit (KVM_EXIT_HYPERCALL), but it was deemed to be a bad idea. BTW, this would help a lot in emulating hypercalls of other hypervisors (or of KVM's VAPIC in the absence of in-kernel irqchip

Re: [Qemu-devel] [PATCH 2/2] Drop obsolete nographic timer

2012-03-16 Thread Jan Kiszka
On 2012-03-16 01:52, Marek Vasut wrote: Dear Jan Kiszka, On 2012-03-15 19:12, Marek Vasut wrote: Dear Marek Vasut, Dear Jan Kiszka, On 2012-03-10 07:19, Marek Vasut wrote: Dear Jan Kiszka, We flush coalesced MMIO in the device models now, and VNC - for which this was once introduced -

Re: [Qemu-devel] pci-assign can not work

2012-03-16 Thread Jan Kiszka
On 2012-03-16 03:38, Wen Congyang wrote: At 03/15/2012 06:21 PM, Wen Congyang Wrote: Hi all When I use pci-assign, I meet the following error: Failed to assign irq for hostdev0: Input/output error Perhaps you are assigning a device that shares an IRQ with another device? Is it a bug or I

Re: [Qemu-devel] pci-assign can not work

2012-03-16 Thread Wen Congyang
At 03/16/2012 04:27 PM, Jan Kiszka Wrote: On 2012-03-16 03:38, Wen Congyang wrote: At 03/15/2012 06:21 PM, Wen Congyang Wrote: Hi all When I use pci-assign, I meet the following error: Failed to assign irq for hostdev0: Input/output error Perhaps you are assigning a device that shares an

Re: [Qemu-devel] [PATCH 2/2] Drop obsolete nographic timer

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 09:17, Jan Kiszka ha scritto: I'm starting to understand the issue: The serial port can only accept a single byte. Once this arrived, serial_can_receive1 returns 0, and the backend fd is not longer polled by the io-thread. This should change again as soon as the guest read that

[Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start

2012-03-16 Thread Jason Wang
qemu_announce_self() were moved to vm_start(). This is because we may want to let guest to send the gratuitous packets. After this change, we need to check the previous run state (RUN_STATE_INMIGRATE) to decide whether an announcement is needed. Signed-off-by: Jason Wang jasow...@redhat.com ---

[Qemu-devel] [V5 PATCH 0/4] Send gratuitous packets by guest

2012-03-16 Thread Jason Wang
This an update of series that let guest and qemu to be co-operated to send gratuitous packets when needed such as after migration, loadvm and continuing. As it's hard for qemu to track the network configuration in guest such as bondings, vlans or ipv6. So current gratuitous may not work under

[Qemu-devel] [V5 PATCH 3/4] virtio-net: notify guest to annouce itself

2012-03-16 Thread Jason Wang
It's hard to track all mac addresses and their usage (vlan, bondings, ipv6) in qemu to send proper gratuitous packet. The better choice is to let guest to send them. So, this patch introduces a new rw config status bit of virtio-net, VIRTIO_NET_S_ANNOUNCE which is used to notify guest to announce

[Qemu-devel] [V5 PATCH 4/4] virtio-net: compat guest announce support.

2012-03-16 Thread Jason Wang
Disable guest announce for compat machine types. Signed-off-by: Jason Wang jasow...@redhat.com --- hw/pc_piix.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 6c5c40f..780b607 100644 --- a/hw/pc_piix.c

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-16 Thread Amos Kong
On 14/03/12 19:46, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivitya...@redhat.com wrote: On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivitya...@redhat.com wrote: On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012

[Qemu-devel] [RESEND PATCH] ioapic: fix build with DEBUG_IOAPIC

2012-03-16 Thread Jason Wang
ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’ Signed-off-by: Jason Wang jasow...@redhat.com --- hw/ioapic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index 3fee011..1ff31a1 100644 ---

Re: [Qemu-devel] [PATCH v4 4/9] MSI-X state save/load invocations moved to PCI Device save/load callbacks to avoid code duplication in MSI-X-enabled devices that support live migration

2012-03-16 Thread Dmitry Fleytman
Michael, Great. I believe higher level API if what really needed here. I'll revert this patch and move msix_load/store invocations into the device code. Thanks. On Fri, Mar 16, 2012 at 1:00 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Mar 15, 2012 at 11:09:03PM +0200, Dmitry Fleytman

Re: [Qemu-devel] [PATCH v2] Man page: Add -global description

2012-03-16 Thread Gerd Hoffmann
Hi, commit 82aff428155d469ab705294486cc26cb34947999 Author: Anthony Liguori aligu...@us.ibm.com Date: Fri Dec 23 11:30:45 2011 -0600 qdev: don't allow globals to be set by bus name So I think we can safely break it :-) There are compat properties using that (turn off new pci features

Re: [Qemu-devel] Adding make check to the QEMU buildbot

2012-03-16 Thread Gerd Hoffmann
On 03/15/12 18:21, Stefan Weil wrote: Am 15.03.2012 09:06, schrieb Stefan Hajnoczi: QEMU has grown a number of sanity tests that can be run using make check. They are fast and do not require many resources. Is it possible to add make check after the build? We may have to deal with some

Re: [Qemu-devel] [RFC PATCH 06/17] block: use bdrv_{co, aio}_discard for write_zeroes operations

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 01:47, Richard Laager ha scritto: On Thu, 2012-03-15 at 10:36 +0100, Paolo Bonzini wrote: Changing across guest boots is a minor problem, but changing across migration must be avoided at all costs. BTW, after this discussion I think we can instead report discard_granularity =

Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 09:54, Jason Wang ha scritto: qemu_announce_self() were moved to vm_start(). This is because we may want to let guest to send the gratuitous packets. After this change, we need to check the previous run state (RUN_STATE_INMIGRATE) to decide whether an announcement is needed.

Re: [Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines

2012-03-16 Thread Kevin Wolf
Am 15.03.2012 22:28, schrieb Stefan Weil: Am 05.03.2012 18:40, schrieb Paolo Bonzini: Conversion to coroutines simplifies the code and removes the need to duplicate common features of the block layer. Each step in the conversion is detailed in the corresponding commit message. Tested with

Re: [Qemu-devel] [PATCH 5/7] vdi: leave bounce buffering to block layer

2012-03-16 Thread Kevin Wolf
Am 05.03.2012 18:40, schrieb Paolo Bonzini: vdi.c really works as if it implemented bdrv_read and bdrv_write. However, because only vector I/O is supported by the asynchronous callbacks, it went through extra pain to bounce-buffer the I/O. With the conversion to coroutines bdrv_read and

Re: [Qemu-devel] [PATCH] softfloat: fix for C99

2012-03-16 Thread Andreas Färber
Am 09.02.2012 17:38, schrieb Avi Kivity: On 02/09/2012 06:20 PM, Andreas Färber wrote: Am 27.12.2011 17:15, schrieb Andreas Färber: Am 27.12.2011 16:11, schrieb Avi Kivity: C99 appears to consider compound literals as non-constants, and complains when they are used in static initializers.

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-16 Thread Wen Congyang
At 03/15/2012 01:18 AM, Luiz Capitulino Wrote: On Wed, 14 Mar 2012 10:11:35 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The command's usage: dump [-p] file file should be start with file:(the file's path) or fd:(the fd's name). Note: 1. If you want to use gdb to analyse the core,

Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start

2012-03-16 Thread Jason Wang
On 03/16/2012 05:43 PM, Paolo Bonzini wrote: Il 16/03/2012 09:54, Jason Wang ha scritto: qemu_announce_self() were moved to vm_start(). This is because we may want to let guest to send the gratuitous packets. After this change, we need to check the previous run state (RUN_STATE_INMIGRATE) to

Re: [Qemu-devel] pci-assign can not work

2012-03-16 Thread Jan Kiszka
On 2012-03-16 09:38, Wen Congyang wrote: At 03/16/2012 04:27 PM, Jan Kiszka Wrote: On 2012-03-16 03:38, Wen Congyang wrote: At 03/15/2012 06:21 PM, Wen Congyang Wrote: Hi all When I use pci-assign, I meet the following error: Failed to assign irq for hostdev0: Input/output error Perhaps

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Andreas Färber
Am 16.03.2012 10:23, schrieb Lee Essen: This fixes a number of issues with the build process (namely ensuring the use of bash), adds specific support for the Illumos port of KVM and fixes a few general Solaris compatibility issues. There are still some things outstanding: - there's a

Re: [Qemu-devel] [RESEND PATCH] ioapic: fix build with DEBUG_IOAPIC

2012-03-16 Thread Andreas Färber
Am 16.03.2012 10:10, schrieb Jason Wang: ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’ Signed-off-by: Jason Wang jasow...@redhat.com PRIx64 is indeed needed here. However, this drops the 08 without mention in the commit message - was it

Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 11:13, Jason Wang ha scritto: The problem with staying in the INMIGRATE is that we can not figure out when the migration is completed when using '-S', so this kind of transition were forbidden by qmp_cont(). Looks like we need a new state such as RUN_STATE_MIGRATE_PRELAUNCH?

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-16 Thread Amos Kong
On 14/03/12 22:58, Michael Roth wrote: On Wed, Mar 14, 2012 at 04:33:14PM +0800, Amos Kong wrote: On 14/03/12 00:39, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:47:45AM +0800, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration().

Re: [Qemu-devel] [PATCH v6 2/6] Introduce save_devices

2012-03-16 Thread Stefano Stabellini
On Thu, 15 Mar 2012, Anthony Liguori wrote: diff --git a/qapi-schema.json b/qapi-schema.json index d0b6792..7f938ff 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1593,3 +1593,21 @@ { 'command': 'qom-list-types', 'data': { '*implements': 'str', '*abstract': 'bool' },

Re: [Qemu-devel] [PATCH v6 2/6] Introduce save_devices

2012-03-16 Thread Stefano Stabellini
On Thu, 15 Mar 2012, Luiz Capitulino wrote: On Thu, 15 Mar 2012 15:16:15 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 03/15/2012 01:19 PM, Stefano Stabellini wrote: - add an is_ram flag to SaveStateEntry; - register_savevm_live sets is_ram for live_savevm devices; -

Re: [Qemu-devel] lsi_scsi: error: ORDERED queue not implemented

2012-03-16 Thread Paolo Bonzini
Il 15/03/2012 23:30, Marius Cirsta ha scritto: qemu-system-arm --version QEMU emulator version 1.0,1, Copyright (c) 2003-2008 Fabrice Bellard and I have a premade ARM image which I start with: qemu-system-arm -M versatilepb -m 256 -kernel vmlinuz-3.1-versatile-fw5 -hda initrd-arm.img

Re: [Qemu-devel] [PATCH v4 9/9] VMXNET3 paravirtualized device integration. Interface type vmxnet3 added.

2012-03-16 Thread Paolo Bonzini
Il 15/03/2012 22:09, Dmitry Fleytman ha scritto: Signed-off-by: Dmitry Fleytman dmi...@daynix.com Signed-off-by: Yan Vugenfirer y...@daynix.com --- Makefile.objs |1 + default-configs/pci.mak |1 + hw/pci.c|2 ++ hw/pci.h|1 +

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 10:23, Lee Essen ha scritto: diff --git a/Makefile.objs b/Makefile.objs index 226b01d..c2a440a 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -373,12 +373,12 @@ else trace.h: trace.h-timestamp endif trace.h-timestamp: $(SRC_PATH)/trace-events

[Qemu-devel] [PATCH v7 0/6] save/restore on Xen

2012-03-16 Thread Stefano Stabellini
Hi all, this is the seventh version of the Xen save/restore patch series. We have been discussing this issue for quite a while on #qemu and qemu-devel: http://marc.info/?l=qemu-develm=132346828427314w=2 http://marc.info/?l=qemu-develm=132377734605464w=2 Please review the second patch:

[Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Lee Essen
Adds support to configure for controlling which shell to use, defaults to sh as before but adds bash for Solaris/Illumos builds. Plus ensures that tracetool is called with a shell. Signed-off-by: Lee Essen lee.es...@nowonline.co.uk -- configure |7 +-- 1 files changed, 5

[Qemu-devel] [PATCH v7 1/6] cirrus_vga: do not reset videoram

2012-03-16 Thread Stefano Stabellini
There is no need to set the videoram to 0xff in cirrus_reset, because it is the BIOS' job. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v7 6/6] xen: do not allocate RAM during INMIGRATE runstate

2012-03-16 Thread Stefano Stabellini
From: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- xen-all.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index

[Qemu-devel] [PATCH v7 5/6] xen mapcache: check if memory region has moved.

2012-03-16 Thread Stefano Stabellini
From: Anthony PERARD anthony.per...@citrix.com This patch changes the xen_map_cache behavior. Before trying to map a guest addr, mapcache will look into the list of range of address that have been moved (physmap/set_memory). There is currently one memory space like this, the vram, moved from were

Re: [Qemu-devel] [PATCHv4 00/11] cleanup/consolidate iovec functions

2012-03-16 Thread Paolo Bonzini
Il 15/03/2012 22:00, Michael Tokarev ha scritto: This is cleanup/consolidation of iovec-related low-level routines in qemu. The plan is to make library functions more understandable, consistent and useful, and to drop numerous implementations of the same thing. The patch changes

[Qemu-devel] [PATCH 2/5] use SHELL in Makefiles

2012-03-16 Thread Lee Essen
Use the SHELL macro (set in configure) to ensure tracetool and hxtool are correctly called. Signed-off-by: Lee Essen lee.es...@nowonline.co.uk --- Makefile.objs |6 +++--- Makefile.target |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile.objs

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Andreas Färber
Am 16.03.2012 13:02, schrieb Lee Essen: Adds support to configure for controlling which shell to use, defaults to sh as before but adds bash for Solaris/Illumos builds. Plus ensures that tracetool is called with a shell. Signed-off-by: Lee Essen lee.es...@nowonline.co.uk --

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Peter Maydell
On 16 March 2012 12:02, Lee Essen lee.es...@nowonline.co.uk wrote: Adds support to configure for controlling which shell to use, defaults to sh as before but adds bash for Solaris/Illumos builds. Plus ensures that tracetool is called with a shell. Ugh. If we have bashisms in our shell

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 12:14, Andreas Färber wrote: Am 16.03.2012 13:02, schrieb Lee Essen: target_list= @@ -442,6 +443,7 @@ SunOS) # have to select again, because `uname -m` returns i86pc # even on an x86_64 box. solariscpu=`isainfo -k` + shell=bash Are you sure this is safe

[Qemu-devel] [PATCH v7 3/6] Set runstate to INMIGRATE earlier

2012-03-16 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Luiz Capitulino lcapitul...@redhat.com --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 12:20, Lee Essen wrote: On 16 Mar 2012, at 12:14, Andreas Färber wrote: Am 16.03.2012 13:02, schrieb Lee Essen: target_list= @@ -442,6 +443,7 @@ SunOS) # have to select again, because `uname -m` returns i86pc # even on an x86_64 box. solariscpu=`isainfo -k`

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Andreas Färber
Am 16.03.2012 13:15, schrieb Peter Maydell: On 16 March 2012 12:02, Lee Essen lee.es...@nowonline.co.uk wrote: Adds support to configure for controlling which shell to use, defaults to sh as before but adds bash for Solaris/Illumos builds. Plus ensures that tracetool is called with a

[Qemu-devel] [PATCH v7 2/6] Introduce save-devices-state

2012-03-16 Thread Stefano Stabellini
- add an is_ram flag to SaveStateEntry; - register_savevm_live sets is_ram for live_savevm devices; - introduce a save-devices-state QAPI command that can be used to save the state of all devices, but not the RAM or the block devices of the VM. Changes in v7: - rename save_devices to

[Qemu-devel] [PATCH v7 4/6] xen: record physmap changes to xenstore

2012-03-16 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- xen-all.c | 78 - 1 files changed,

[Qemu-devel] [PATCH] Kick io-thread on qemu_chr_accept_input

2012-03-16 Thread Jan Kiszka
Once a chr frontend is able to receive input again, we need to inform the io-thread about this fact. Otherwise, main_loop_wait may continue to select without the related backend file descriptor in its set. This can cause high input latencies if only low-rate events arrive otherwise.

Re: [Qemu-devel] Adding make check to the QEMU buildbot

2012-03-16 Thread Anthony Liguori
On 03/15/2012 12:21 PM, Stefan Weil wrote: Am 15.03.2012 09:06, schrieb Stefan Hajnoczi: QEMU has grown a number of sanity tests that can be run using make check. They are fast and do not require many resources. Is it possible to add make check after the build? We may have to deal with some

[Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Lee Essen
Signed-off-by: Lee Essen lee.es...@nowonline.co.uk --- scripts/tracetool |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..2e43d05 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -123,7 +123,7 @@ get_argc()

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Peter Maydell
On 16 March 2012 12:24, Andreas Färber andreas.faer...@web.de wrote: Am 16.03.2012 13:15, schrieb Peter Maydell: This shouldn't be necessary -- tracetool has a #!/bin/sh at the top. If it needs bash then that should be fixed. No, please. I'd be okay with setting shell=bash in a reasonably

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Andreas Färber
Am 16.03.2012 13:20, schrieb Lee Essen: On 16 Mar 2012, at 12:14, Andreas Färber wrote: Am 16.03.2012 13:02, schrieb Lee Essen: +echo SHELL=$shell $config_host_mak Why? See patch 2/7 … there are several calls to tracetool that hardcode sh in the Makefile … again if the better

Re: [Qemu-devel] [RFC PATCH 00/10] make qed and live migration usage safe

2012-03-16 Thread Benoît Canet
gentle ping :) On Tue, Mar 6, 2012 at 6:32 PM, Benoît Canet benoit.ca...@gmail.com wrote: QED + live migration is an unsafe and disabled mix. This patchset make qed and live migration safe to use. The check of QED images is delayed during the incoming migration. After the migration

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Andreas Färber
Am 16.03.2012 13:29, schrieb Lee Essen: Signed-off-by: Lee Essen lee.es...@nowonline.co.uk --- scripts/tracetool |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..2e43d05 100755 --- a/scripts/tracetool +++

[Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michal Privoznik
Hi guys, I was just implementing support for guest-sync-delimited into libvirt. My intent is to issue this command prior any other command to determine if GA is available or not. The big advantage is - it doesn't change the state of the guest so from libvirt POV it's harmless. The other big

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 12:44, Andreas Färber wrote: Am 16.03.2012 13:29, schrieb Lee Essen: Signed-off-by: Lee Essen lee.es...@nowonline.co.uk --- scripts/tracetool |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Jan Kiszka
On 2012-03-16 10:23, Lee Essen wrote: This fixes a number of issues with the build process (namely ensuring the use of bash), adds specific support for the Illumos port of KVM and fixes a few general Solaris compatibility issues. There are still some things outstanding: - there's a

Re: [Qemu-devel] [PATCH] Kick io-thread on qemu_chr_accept_input

2012-03-16 Thread Anthony Liguori
On 03/16/2012 07:25 AM, Jan Kiszka wrote: Once a chr frontend is able to receive input again, we need to inform the io-thread about this fact. Otherwise, main_loop_wait may continue to select without the related backend file descriptor in its set. This can cause high input latencies if only

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 13:29, Lee Essen ha scritto: @@ -123,7 +123,7 @@ get_argc() # Get the format string including double quotes for a trace event get_fmt() { -puts ${1#*)} +puts ${1#*} } Eric, can you look at this? Is it a bashism or a Solaris bug? I would write it, to be

Re: [Qemu-devel] [PATCH] Kick io-thread on qemu_chr_accept_input

2012-03-16 Thread Jan Kiszka
On 2012-03-16 14:16, Anthony Liguori wrote: On 03/16/2012 07:25 AM, Jan Kiszka wrote: Once a chr frontend is able to receive input again, we need to inform the io-thread about this fact. Otherwise, main_loop_wait may continue to select without the related backend file descriptor in its set.

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 14:00, Lee Essen ha scritto: /tmp/patch/qemu/scripts/tracetool[520]: local: not found [No such file or directory] /tmp/patch/qemu/scripts/tracetool[66]: local: not found [No such file or directory] /tmp/patch/qemu/scripts/tracetool[136]: local: not found [No such file or

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Andreas Färber
Am 16.03.2012 14:00, schrieb Lee Essen: On 16 Mar 2012, at 12:44, Andreas Färber wrote: Am 16.03.2012 13:29, schrieb Lee Essen: Signed-off-by: Lee Essen lee.es...@nowonline.co.uk --- scripts/tracetool |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Andreas Färber
Am 16.03.2012 14:19, schrieb Paolo Bonzini: Il 16/03/2012 14:00, Lee Essen ha scritto: /tmp/patch/qemu/scripts/tracetool[520]: local: not found [No such file or directory] /tmp/patch/qemu/scripts/tracetool[66]: local: not found [No such file or directory]

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 13:14, Jan Kiszka wrote: On 2012-03-16 10:23, Lee Essen wrote: +#ifdef __sun__ +#include sys/kvm.h +#else #include linux/kvm.h #include linux/kvm_para.h +#endif As Paolo already said, this should somehow be centralised. Yep, fair point. I'll address this one.

[Qemu-devel] [PATCH] hw/qxl.c: Fix compilation failures on 32 bit hosts

2012-03-16 Thread Peter Maydell
Fix compilation failures on 32 bit hosts (cast from pointer to integer of different size; %ld expects 'long int' not uint64_t). Reported-by: Steve Langasek steve.langa...@canonical.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/qxl.c | 16 1 files changed, 8

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-03-16 Thread Serge Hallyn
@Martin, No - Im still not sure about its responsibilities, so I don't know whether it's deemed a bug that it is using negative values, but certainly (virtualized) hardware shouldn't crash due to it, so that's where we're fixing it. So I'll mark the -vmware package part of the bug invalid.

[Qemu-devel] RFC: double free in qmp_output_visitor_cleanup()

2012-03-16 Thread Laszlo Ersek
Hi, we seem to have found a double free in qmp_output_visitor_cleanup(). Please read the analysis below (that is based on commit e4e6aa14) and please tell me if you'd like me to write a patch for solution (a) or solution (b), as described at the bottom. Paolo wrote a test case to trigger the

Re: [Qemu-devel] [PATCH] hw/qxl.c: Fix compilation failures on 32 bit hosts

2012-03-16 Thread Stefan Weil
Am 16.03.2012 14:50, schrieb Peter Maydell: Fix compilation failures on 32 bit hosts (cast from pointer to integer of different size; %ld expects 'long int' not uint64_t). Reported-by: Steve Langaseksteve.langa...@canonical.com Signed-off-by: Peter Maydellpeter.mayd...@linaro.org --- hw/qxl.c

Re: [Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michael Roth
On Fri, Mar 16, 2012 at 01:47:42PM +0100, Michal Privoznik wrote: Hi guys, I was just implementing support for guest-sync-delimited into libvirt. My intent is to issue this command prior any other command to determine if GA is available or not. The big advantage is - it doesn't change the

Re: [Qemu-devel] [PATCH] hw/qxl.c: Fix compilation failures on 32 bit hosts

2012-03-16 Thread Peter Maydell
On 16 March 2012 14:37, Stefan Weil s...@weilnetz.de wrote:          fprintf(stderr, -                qxl: %s: error: current_async = %d != %ld = cookie-io\n, +                qxl: %s: error: current_async = %d != % PRId64 = cookie-io\n,                  __func__, current_async, cookie-io);

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Eric Blake
On 03/16/2012 07:18 AM, Paolo Bonzini wrote: Il 16/03/2012 13:29, Lee Essen ha scritto: @@ -123,7 +123,7 @@ get_argc() # Get the format string including double quotes for a trace event get_fmt() { -puts ${1#*)} This says to call puts with the first argument of get_fmt, except with

Re: [Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Eric Blake
On 03/16/2012 06:47 AM, Michal Privoznik wrote: Hi guys, I was just implementing support for guest-sync-delimited into libvirt. My intent is to issue this command prior any other command to determine if GA is available or not. The big advantage is - it doesn't change the state of the

[Qemu-devel] [PATCH] virtio-spec: split virtio-net device status filed into ro and rw byte

2012-03-16 Thread Jason Wang
This patch splits the device status field of virtio-net into ro and rw byte. This would simplify the implementation of both host and guest and make the layout more clean. As VIRTIO_NET_S_ANNOUNCE is a rw bit, it was moved to bit 8 (0x100). btw. looks like there's no implementation that depends on

Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start

2012-03-16 Thread Jason Wang
On 03/16/2012 06:45 PM, Paolo Bonzini wrote: Il 16/03/2012 11:13, Jason Wang ha scritto: The problem with staying in the INMIGRATE is that we can not figure out when the migration is completed when using '-S', so this kind of transition were forbidden by qmp_cont(). Looks like we

[Qemu-devel] [Bug 954099] Re: Assertion failed arp_table.c line 41 on raspberry pi fedora image boot up

2012-03-16 Thread Akarsh
This bug is related to ARM based processor emulation and has been fixed in Linaro QEMU(qemu-linaro). You can install qemu-linaro to solve the problem. This can be confirmed with the following link(Point 6) : http://www.cnx-software.com/2012/03/08/instructions-to-run-raspberry-pi-

Re: [Qemu-devel] [PATCH v6 2/6] Introduce save_devices

2012-03-16 Thread Eric Blake
On 03/15/2012 02:34 PM, Luiz Capitulino wrote: On Thu, 15 Mar 2012 15:16:15 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 03/15/2012 01:19 PM, Stefano Stabellini wrote: - add an is_ram flag to SaveStateEntry; - register_savevm_live sets is_ram for live_savevm devices; - introduce

[Qemu-devel] [Bug 899961] Re: qemu/kvm locks up when run 32bit userspace with 64bit kernel

2012-03-16 Thread Michael Tokarev
Forgot to mention: tcg appears to be unaffected - so far anyway. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/899961 Title: qemu/kvm locks up when run 32bit userspace with 64bit kernel Status in

[Qemu-devel] [Bug 899961] Re: qemu/kvm locks up when run 32bit userspace with 64bit kernel

2012-03-16 Thread Michael Tokarev
After some more digging I found out that qemu also has this very issue, but it happens a bit differently. In particular, this very same winXP test guest freezes in upstream qemu with -enable-kvm on _shutdown_, not on restart. In qemu-kvm it happens on restart but not on shutdown. And bisecting

Re: [Qemu-devel] [PATCH v7 2/6] Introduce save-devices-state

2012-03-16 Thread Eric Blake
On 03/16/2012 06:13 AM, Stefano Stabellini wrote: - add an is_ram flag to SaveStateEntry; - register_savevm_live sets is_ram for live_savevm devices; - introduce a save-devices-state QAPI command that can be used to save the state of all devices, but not the RAM or the block devices of the

Re: [Qemu-devel] [PATCH v7 2/6] Introduce save-devices-state

2012-03-16 Thread Anthony Liguori
On 03/16/2012 10:49 AM, Eric Blake wrote: On 03/16/2012 06:13 AM, Stefano Stabellini wrote: - add an is_ram flag to SaveStateEntry; - register_savevm_live sets is_ram for live_savevm devices; - introduce a save-devices-state QAPI command that can be used to save the state of all devices, but

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Eric Blake
On 03/16/2012 06:35 AM, Peter Maydell wrote: The issue here is really just getting a fully POSIX-conformant shell. And the way I expect this to work is by executing configure and make in such a shell and by not having hardcoded /bin/sh creep in through some shebang line. The way I expect

Re: [Qemu-devel] [PATCH v6 2/6] Introduce save_devices

2012-03-16 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Eric Blake wrote: On 03/15/2012 02:34 PM, Luiz Capitulino wrote: On Thu, 15 Mar 2012 15:16:15 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 03/15/2012 01:19 PM, Stefano Stabellini wrote: - add an is_ram flag to SaveStateEntry; - register_savevm_live

[Qemu-devel] [Bug 954099] Re: Assertion failed arp_table.c line 41 on raspberry pi fedora image boot up

2012-03-16 Thread Peter Maydell
It's probably also fixed in upstream qemu master since I haven't deliberately put anything in to qemu-linaro to fix it -- we've almost certainly just picked up the fix from upstream. Incidentally -M versatilepb -cpu arm1136-r2 is veering slightly into unsupported territory, since there's no such

Re: [Qemu-devel] [PATCH v7 2/6] Introduce save-devices-state

2012-03-16 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Eric Blake wrote: On 03/16/2012 06:13 AM, Stefano Stabellini wrote: - add an is_ram flag to SaveStateEntry; - register_savevm_live sets is_ram for live_savevm devices; - introduce a save-devices-state QAPI command that can be used to save the state of all

Re: [Qemu-devel] [PATCH v7 2/6] Introduce save-devices-state

2012-03-16 Thread Eric Blake
On 03/16/2012 09:58 AM, Anthony Liguori wrote: +These operations are normally used with migration (see migration.txt), +however it is also possible to save the state of all devices to file, +without saving the RAM or the block devices of the VM. + +This operation is called save-devices-state

Re: [Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michal Privoznik
On 16.03.2012 15:49, Michael Roth wrote: On Fri, Mar 16, 2012 at 01:47:42PM +0100, Michal Privoznik wrote: Hi guys, I was just implementing support for guest-sync-delimited into libvirt. My intent is to issue this command prior any other command to determine if GA is available or not. The

Re: [Qemu-devel] [PATCHv4 01/11] virtio-serial-bus: use correct lengths in control_out() message

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: In case of more than one control message, the code will use size of the largest message so far for all subsequent messages, instead of using size of current one. Fix it. Signed-off-by: Michael Tokarevm...@tls.msk.ru --- hw/virtio-serial-bus.c |

Re: [Qemu-devel] [PATCHv4 02/11] change iov_* function prototypes to be more appropriate

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: Reorder arguments to be more natural, readable and consistent with other iov_* functions, and change argument names, from: iov_from_buf(iov, iov_cnt, buf, iov_off, size) to iov_from_buf(iov, iov_cnt, offset, buf, bytes) The result becomes

Re: [Qemu-devel] [PATCHv4 03/11] rewrite iov_* functions

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: This changes implementations of all iov_* functions, completing the previous step. All iov_* functions now ensure that this offset argument is within the iovec (using assertion), but lets to specify `bytes' value larger than actual length of the

Re: [Qemu-devel] [PATCHv4 03/11] rewrite iov_* functions

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: This changes implementations of all iov_* functions, completing the previous step. All iov_* functions now ensure that this offset argument is within the iovec (using assertion), but lets to specify `bytes' value larger than actual length of the

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Peter Maydell
On 16 March 2012 15:58, Eric Blake ebl...@redhat.com wrote: On 03/16/2012 06:35 AM, Peter Maydell wrote: The way I expect this to work is that /bin/sh should be a posix shell... Then your expectations are wrong.  POSIX itself says that /bin/sh need not be the POSIX shell, and merely requires

Re: [Qemu-devel] [PATCHv4 05/11] allow qemu_iovec_from_buffer() to specify offset from which to start copying

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: Similar to qemu_iovec_memset(QEMUIOVector *qiov, size_t offset, int c, size_t bytes); the new prototype is: qemu_iovec_from_buf(QEMUIOVector *qiov, size_t offset, const void *buf, size_t bytes); The

Re: [Qemu-devel] [PATCHv4 09/11] export iov_send_recv() and use it in iov_send() and iov_recv()

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: Rename do_sendv_recvv() to iov_send_recv(), change its last arg (do_send) from int to bool, export it in iov.h, and made the two callers of it (iov_send() and iov_recv()) to be trivial #defines just adding 5th arg. iov_send_recv() will be used

Re: [Qemu-devel] [PATCHv4 10/11] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

2012-03-16 Thread Anthony Liguori
On 03/15/2012 04:00 PM, Michael Tokarev wrote: The same as for non-coroutine versions in previous patches: rename arguments to be more obvious, change type of arguments from int to size_t where appropriate, and use common code for send and receive paths (with one extra argument) since these are

  1   2   >