Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-24 Thread Kelvin Wang
On Wed, May 23, 2012 at 05:45:33PM +0300, Michael S. Tsirkin wrote: On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote: Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: 2, Run qemu with the option -monitor. 3, In the guest, insert necessary modules: for m in

Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind

2012-05-24 Thread Alon Levy
On Wed, May 23, 2012 at 08:59:22PM +0200, Gerd Hoffmann wrote: On 05/22/12 17:29, Alon Levy wrote: We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. So you get valgrind warnings

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-24 Thread Michael S. Tsirkin
On Thu, May 24, 2012 at 02:31:00PM +0800, Kelvin Wang wrote: On Wed, May 23, 2012 at 05:45:33PM +0300, Michael S. Tsirkin wrote: On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote: Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: 2, Run qemu with the option -monitor.

Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind

2012-05-24 Thread Gerd Hoffmann
On 05/24/12 08:43, Alon Levy wrote: On Wed, May 23, 2012 at 08:59:22PM +0200, Gerd Hoffmann wrote: On 05/22/12 17:29, Alon Levy wrote: We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset.

Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit

2012-05-24 Thread Gerd Hoffmann
On 05/03/12 21:32, malc wrote: On Thu, 3 May 2012, Jan Kiszka wrote: Not only clean up enabled voices but any registered one. Backends like pulsaudio rely on unconditional fini handler invocations. This fixes Memory pool destroyed but not all memory blocks freed! warnings on VM shutdowns

Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit

2012-05-24 Thread Gerd Hoffmann
On 05/03/12 20:56, Jan Kiszka wrote: Not only clean up enabled voices but any registered one. Backends like pulsaudio rely on unconditional fini handler invocations. This fixes Memory pool destroyed but not all memory blocks freed! warnings on VM shutdowns when pa is used. Signed-off-by:

Re: [Qemu-devel] Signal management in qemu-user

2012-05-24 Thread Alex Barcelo
On Thu, May 24, 2012 at 1:04 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 23 May 2012 23:38, Alex Barcelo abarc...@ac.upc.edu wrote: This *always* goes wrong without calling the signal handler I haven't looked too closely, but I suspect we're just not paying any attention to whether

[Qemu-devel] [PATCH v2] Prevent disk data loss when closing qemu

2012-05-24 Thread Pavel Dovgaluk
Prevent disk data loss when closing qemu console window under Windows 7. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@gmail.com --- os-win32.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/os-win32.c b/os-win32.c index ad76370..66c39b8 100644 --- a/os-win32.c +++

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-24 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Il 23/05/2012 08:48, Pavel Dovgaluk ha scritto: I'm not against your patch and it's probably 1.1 material, but there may be more shutdown logic that we're missing if you close the console window.

[Qemu-devel] [RFC PATCH] PCI: Introduce INTx check mask API

2012-05-24 Thread Alexey Kardashevskiy
[Found while debugging VFIO on POWER but it is platform independent] There is a feature in PCI (=2.3?) to mask/unmask INTx via PCI_COMMAND and PCI_STATUS registers. And there is some API to support that (commit a2e27787f893621c5a6b865acf6b7766f8671328). I have a network adapter: 0001:00:01.0

Re: [Qemu-devel] [QEMU 1.1 PATCH v3] Expose CPUID leaf 7 only for -cpu host

2012-05-24 Thread Gleb Natapov
On Mon, May 21, 2012 at 11:27:02AM -0300, Eduardo Habkost wrote: Changes v2 - v3; - Check for kvm_enabled() before setting cpuid_7_0_ebx_features Changes v1 - v2: - Use kvm_arch_get_supported_cpuid() instead of host_cpuid() on cpu_x86_fill_host(). We should use

[Qemu-devel] [RfC PATCH 0/2] vga: make ram size configurable

2012-05-24 Thread Gerd Hoffmann
Hi, This is part of the plan to vanish the remaining differences between qemu and qemu-kvm. qemu has 8 MB vram, whereas qemu-kvm has 16 MB. Making it configurable allows to keep qemu's default for compatibility reasons while satisfying qemu-kvm users too. Also adds new options like reducing

[Qemu-devel] [RfC PATCH 1/2] vga: raise xres+yres limits

2012-05-24 Thread Gerd Hoffmann
The vgabios will check whenever any given video mode will fit into the given video memory before adding it to the list of available modes, so there is no need to keep xmax * ymax * 32bpp lower than VGA_RAM_SIZE. Lets raise the limits a bit. Should be good for a few years, display sizes are not

[Qemu-devel] [RfC PATCH 2/2] vga: make vram size configurable

2012-05-24 Thread Gerd Hoffmann
Zap the global VGA_RAM_SIZE #define, make the vga ram size configurable for standard vga and vmware vga. cirrus and qxl are left with a fixed size (and private VGA_RAM_SIZE #define) for now. qxl needs some non-trivial adjustments in the mode list handling deal with a runtime-configurable size,

Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind

2012-05-24 Thread Gerd Hoffmann
Hi, I'll go queue it up. Ahem, doesn't apply cleanly. Guess this is just a patch ordering issue though. Can you send all your pending qxl bits as single patch series please, so I don't have to play trial-and-error to figure the correct order? thanks, Gerd

Re: [Qemu-devel] [PATCH] version: update version info

2012-05-24 Thread Stefan Hajnoczi
On Thu, May 24, 2012 at 10:54:46AM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- VERSION |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Try: $ git log -p ./VERSION Anthony manages this

[Qemu-devel] [RESEND PATCH 1.1] vnc: fix segfault in vnc_display_pw_expire()

2012-05-24 Thread Gerd Hoffmann
NULL pointer dereference in case no vnc server is configured. Catch this and return -EINVAL like vnc_display_password() does. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index

Re: [Qemu-devel] [PATCH] version: update version info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 4:53 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Thu, May 24, 2012 at 10:54:46AM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com ---  VERSION |    2 +-  1 files changed, 1

[Qemu-devel] [PATCH v4 1/3] fdc: floppy drive should be visible after start without media

2012-05-24 Thread Pavel Hrdina
If you start guest with floppy drive but without media inserted, guest still should see floppy drive pressent. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hw/pc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 4d34a33..967c17a 100644 ---

[Qemu-devel] [PATCH v4 3/3] fdc-test: introduced qtest no_media_on_start and cmos qtest for floppy

2012-05-24 Thread Pavel Hrdina
As default a guest has always one floppy drive so 0x10 byte in CMOS has to have 0x40 value. Higher 4 bits means that the first floppy drive is 1.44 Mb 35 drive and lower 4 bits means the second drive is not present. After the guest starts DSKCHG bit in DIR register should be set. If there is no

[Qemu-devel] [PATCH v4 2/3] fdc: fix media detection

2012-05-24 Thread Pavel Hrdina
We have to set up 'media_changed' after guest start so floppy driver could detect that there is no media in drive. For this purpose we call 'fdctrl_change_cb' instead of 'fd_revalidate' in 'fdctrl_connect_drives'. 'fd_revalidate' is called inside 'fdctrl_change_cb'. We still have to set default

[Qemu-devel] [PATCH v4 0/3] fdc: fix media handling

2012-05-24 Thread Pavel Hrdina
This patch series fixes handling of FDC when you don't have media inserted. Guest should see floppy drive if you start guest without media and should detect that there is no media in drive. Signed-off-by: Pavel Hrdina phrd...@redhat.com Pavel Hrdina (3): fdc: floppy drive should be visible

Re: [Qemu-devel] [PATCH qom-next 5/6] target-i386: make initialize CPU in QOM way

2012-05-24 Thread Igor Mammedov
On 05/23/2012 11:27 PM, Andreas Färber wrote: Am 23.05.2012 18:39, schrieb Igor Mammedov: Make CPU creation/initialization consistent with QOM object behavior in this, by moving tcg and apic initialization from board level into CPU's initfn/realize calls and cpu_model property setter. Which

[Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind

2012-05-24 Thread Alon Levy
We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. Signed-off-by: Alon Levy al...@redhat.com --- ui/spice-display.c |2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/

2012-05-24 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 49 +++-- hw/qxl.h |3 ++- 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3da3399..8777ba9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -30,7 +30,7 @@

[Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode

2012-05-24 Thread Alon Levy
Tested with linux guest. Not sure how to check actual performance affect of this. Checked with the previously send traceevent that the kvm ioctl to start/stop dirty logging is being called. (KVM_SET_USER_MEMORY_REGION). Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |2 ++ 1 file

Re: [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind

2012-05-24 Thread Alon Levy
On Thu, May 24, 2012 at 12:38:11PM +0300, Alon Levy wrote: We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. This was supposed to be in reply to 4fbdf65f.8070...@redhat.com, rebased on

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 08:31, Kelvin Wang ha scritto: If the point is to avoid need for manual bus rescans that's good. But please do not touch the legacy commands. So, may I sent another patch to avoid need for manual bus rescans? The virtio spec supports sending events for added and removed

[Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
For all devices print id, mode and guest_bug status. Known problems: Prints devices from highest id to lowest. Signed-off-by: Alon Levy al...@redhat.com --- hmp.c| 11 +++ hw/qxl.c | 22 ++ qapi-schema.json | 47

Re: [Qemu-devel] [PATCH v2 15/15] net: invoke qemu_can_send_packet only before net queue sending function

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 06:05, Zhi Yong Wu ha scritto: On Thu, May 24, 2012 at 12:00 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/05/2012 17:14, zwu.ker...@gmail.com ha scritto: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/queue.c

Re: [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 09:42, Pavel Dovgaluk ha scritto: Prevent disk data loss when closing qemu console window under Windows 7. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@gmail.com --- os-win32.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/os-win32.c

[Qemu-devel] [PATCH v2 0/3] Simpletrace v2: Support multiple args, strings.

2012-05-24 Thread Harsh Prateek Bora
Existing simpletrace backend allows to trace at max 6 args and does not support strings. This newer tracelog format gets rid of fixed size records and therefore allows to trace variable number of args including strings. Sample trace: v9fs_version 0.000 tag=0x id=0x64 msize=0x2000

[Qemu-devel] [PATCH v2 2/3] Simpletrace v2: Add support for multiple args, strings.

2012-05-24 Thread Harsh Prateek Bora
A newer tracelog format which gets rid of fixed size trace records and therefore allows to trace multiple arguments as well as strings in trace events. Sample trace: v9fs_version 0.000 tag=0x id=0x64 msize=0x2000 version=9P2000.L v9fs_version_return 6.705 tag=0x id=0x64 msize=0x2000

[Qemu-devel] [PATCH v2 3/3] Update simpletrace.py to support new v2 log format

2012-05-24 Thread Harsh Prateek Bora
With this patch, simpletrace.py can parse the older as well as the newer log format which supports variable arguments and strings. Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- scripts/simpletrace.py | 138 +--- 1 files changed, 95

Re: [Qemu-devel] The image size of instance VM keeps growing

2012-05-24 Thread Charles . Tsai-蔡清海-研究發展部
Stefan, Can you explain why a 64KB could be allocated for each sector write? Right now, I am testing a VM with 8G virtual disk space. The disk only has 12.6 MB free space left when I run the test. I am going to see what will happen in this test case.

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has to called with the exact physical address of the breakpoint we add/remove, not just the page's base address. Otherwise we easily fail to flush the right TB.

[Qemu-devel] [PATCH] qcow2: Check qcow2_alloc_clusters_at() return value

2012-05-24 Thread Kevin Wolf
When using qcow2_alloc_clusters_at(), the cluster allocation code checked the wrong variable for an error code. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/block/qcow2-cluster.c

Re: [Qemu-devel] [PATCH 1.1] vga: Initialise VRAM with 0

2012-05-24 Thread Stefano Stabellini
On Wed, 23 May 2012, Stefan Weil wrote: The VNC code reads this memory before it is written by BIOS or other code. Avoid random values by setting the VRAM to 0. This bug was reported by Valgrind. Please do not apply this patch: it breaks VGA restore on Xen: the videoram is saved and restored

[Qemu-devel] [PATCH 1/1] Fix geometry sector calculation

2012-05-24 Thread Christian Borntraeger
Currently the sector value for the geometry is masked, even if the user usesa command line parameter that explicitely gives a number. This breaks dasd devices on s390. A dasd device can have a physical block size of 4096 (== same for logical block size) and a typcial geometry of 15 heads and 12

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has to called with the exact physical address of the breakpoint we add/remove, not just the page's base address.

Re: [Qemu-devel] [PATCH qom-next 49/59] target-i386: Drop version 5 CPU VMState support

2012-05-24 Thread Juan Quintela
Andreas Färber afaer...@suse.de wrote: Version 5 contained the halted field, that we are about to move from CPUX86State to CPUState. To avoid inventing new VMSTATE macros for calculating a negative offset from CPUX86State to the field in CPUState, rather bump the minimum version from 3 to 6.

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-24 Thread Kelvin Wang
On Thu, May 24, 2012 at 12:00:29PM +0200, Paolo Bonzini wrote: Il 24/05/2012 08:31, Kelvin Wang ha scritto: If the point is to avoid need for manual bus rescans that's good. But please do not touch the legacy commands. So, may I sent another patch to avoid need for manual bus rescans?

[Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Markus Armbruster
Beware: second patch is the product of voodoo-coding. Markus Armbruster (2): qom: Give type_get_by_name() external linkage qmp: New command qom-new include/qemu/object.h |8 qapi-schema.json | 22 ++ qmp-commands.hx |5 + qmp.c

[Qemu-devel] [PATCH RFC 1/2] qom: Give type_get_by_name() external linkage

2012-05-24 Thread Markus Armbruster
Following the type_register() precedence, the definition returns TypeImpl *, while the declaration returns Type. Fine, because the latter is actually a typedef for the former. For the record, I don't think this typedef'ing away the * is a good idea. It only complicates matters. When I see

[Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Markus Armbruster
To create objects via QMP. Test case: $ upstream-qemu --enable-kvm -S -m 384 -vnc :0 -monitor stdio -chardev socket,id=qmp,path=test-qmp,server=on,wait=off -mon mode=control,chardev=qmp Conversation on the qmp socket: {QMP: {version: {qemu: {micro: 93, minor: 0, major: 1}, package: },

Re: [Qemu-devel] [PATCH 1.1 1/1] Fix geometry sector calculation

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 13:22, Christian Borntraeger ha scritto: Currently the sector value for the geometry is masked, even if the user usesa command line parameter that explicitely gives a number. This breaks dasd devices on s390. A dasd device can have a physical block size of 4096 (== same for

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 13:43, Markus Armbruster ha scritto: Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack additional magic performed by qdev_try_create(), and almost certainly won't work. True. With the patches on the list, all that adev_try_create does is really

Re: [Qemu-devel] [PATCH v2 15/15] net: invoke qemu_can_send_packet only before net queue sending function

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 6:07 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/05/2012 06:05, Zhi Yong Wu ha scritto: On Thu, May 24, 2012 at 12:00 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/05/2012 17:14, zwu.ker...@gmail.com ha scritto: From: Zhi Yong Wu wu...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v2 15/15] net: invoke qemu_can_send_packet only before net queue sending function

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 13:58, Zhi Yong Wu ha scritto: But you will copy packets uselessly. The code before the patch simply left them on the tap file descriptor. This is better because it involves the kernel in flow control. You are introducing bufferbloat. You are correct, but can_send_packet

Re: [Qemu-devel] [RFC PATCH] PCI: Introduce INTx check mask API

2012-05-24 Thread Jan Kiszka
On 2012-05-24 04:44, Alexey Kardashevskiy wrote: [Found while debugging VFIO on POWER but it is platform independent] There is a feature in PCI (=2.3?) to mask/unmask INTx via PCI_COMMAND and PCI_STATUS registers. Yes, 2.3 introduced this. Masking is done via command register, checking if

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has to called with the exact physical address

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Jan Kiszka
On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 12:14, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net.c |1 - 1 files

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has

Re: [Qemu-devel] [RfC PATCH 2/2] vga: make vram size configurable

2012-05-24 Thread Jan Kiszka
On 2012-05-24 05:44, Gerd Hoffmann wrote: Zap the global VGA_RAM_SIZE #define, make the vga ram size configurable for standard vga and vmware vga. cirrus and qxl are left with a fixed size (and private VGA_RAM_SIZE #define) for now. qxl needs some non-trivial adjustments in the mode list

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 8:09 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 12:14, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Clarify comments of tb_invalidate_phys_[page_]range

2012-05-24 Thread Stefan Hajnoczi
On Wed, May 23, 2012 at 11:41:53PM -0300, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com They could suggest that all TBs of the page containing the range would be invalidated. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- exec.c | 22 -- 1 files

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Andreas Färber
Am 24.05.2012 13:43, schrieb Markus Armbruster: Beware: second patch is the product of voodoo-coding. Hm, I don't like the voodoo. ;) I would rather expose a proper C API like object_try_new(const char *, Error **) than opening up the TypeImpl internals to the public and hand-coding it

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 8:09 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 12:14, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com

[Qemu-devel] [PATCH v2] qcow2: Check qcow2_alloc_clusters_at() return value

2012-05-24 Thread Kevin Wolf
When using qcow2_alloc_clusters_at(), the cluster allocation code checked the wrong variable for an error code. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de

Re: [Qemu-devel] [PATCH v2] Prevent disk data loss when closing qemu

2012-05-24 Thread Andreas Färber
Am 24.05.2012 09:42, schrieb Pavel Dovgaluk: Prevent disk data loss when closing qemu console window under Windows 7. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@gmail.com --- os-win32.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/os-win32.c

Re: [Qemu-devel] buildbot failure in qemu on block_openbsd_4.9

2012-05-24 Thread Luiz Capitulino
On Thu, 24 May 2012 03:03:52 +0200 q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder block_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_openbsd_4.9/builds/222 For anyone following this:

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 8:09 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 12:14, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Anthony Liguori
On 05/24/2012 06:51 AM, Paolo Bonzini wrote: Il 24/05/2012 13:43, Markus Armbruster ha scritto: Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack additional magic performed by qdev_try_create(), and almost certainly won't work. True. With the patches on the list, all that

Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Gerd Hoffmann
On 05/24/12 11:38, Alon Levy wrote: For all devices print id, mode and guest_bug status. Queued up 1+2+4 For this one I wanna have an additional ack from qmp camp. Also a nit: # @SpiceInfo # # Information about the SPICE session. @@ -683,12 +721,17 @@ # # @channels: a list of

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Andreas Färber
Am 24.05.2012 14:58, schrieb Anthony Liguori: On 05/24/2012 06:51 AM, Paolo Bonzini wrote: Il 24/05/2012 13:43, Markus Armbruster ha scritto: Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack additional magic performed by qdev_try_create(), and almost certainly won't work.

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Anthony Liguori
On 05/24/2012 06:43 AM, Markus Armbruster wrote: To create objects via QMP. Test case: $ upstream-qemu --enable-kvm -S -m 384 -vnc :0 -monitor stdio -chardev socket,id=qmp,path=test-qmp,server=on,wait=off -mon mode=control,chardev=qmp Conversation on the qmp socket: {QMP: {version: {qemu:

Re: [Qemu-devel] [PATCH 1.1 1/1] Fix geometry sector calculation

2012-05-24 Thread Alexander Graf
On 24.05.2012, at 13:48, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/05/2012 13:22, Christian Borntraeger ha scritto: Currently the sector value for the geometry is masked, even if the user usesa command line parameter that explicitely gives a number. This breaks dasd devices on s390. A

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Anthony Liguori
On 05/24/2012 07:32 AM, Andreas Färber wrote: Am 24.05.2012 13:43, schrieb Markus Armbruster: Beware: second patch is the product of voodoo-coding. Hm, I don't like the voodoo. ;) I would rather expose a proper C API like object_try_new(const char *, Error **) than opening up the TypeImpl

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-24 Thread Igor Mammedov
On 05/23/2012 11:26 PM, Peter Maydell wrote: On 23 May 2012 22:09, Igor Mammedovimamm...@redhat.com wrote: For cpu-hotplug it was suggested to use device_add/del interface for it. To do so in a generalized way hot-plugged cpu should follow general QOM object creation sequence, i.e. - create

Re: [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu

2012-05-24 Thread Anthony Liguori
On 05/24/2012 05:10 AM, Paolo Bonzini wrote: Il 24/05/2012 09:42, Pavel Dovgaluk ha scritto: Prevent disk data loss when closing qemu console window under Windows 7. Signed-off-by: Pavel Dovgalyukpavel.dovga...@gmail.com --- os-win32.c |6 +- 1 files changed, 5 insertions(+), 1

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Peter Maydell
On 24 May 2012 14:06, Anthony Liguori anth...@codemonkey.ws wrote: There are very few places where errors can be handled gracefully.  They are exceptions and can be treated as such. I think it's far better for the QOM infrastructure to assert when it detects something bad because 99% of the

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-24 Thread Peter Maydell
On 24 May 2012 14:10, Igor Mammedov imamm...@redhat.com wrote: On 05/23/2012 11:26 PM, Peter Maydell wrote: I think your self-sufficient CPU object should probably be a container QOM object which contains the CPU core itself and the APIC device. Then the container object's initialisation can

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-24 Thread Jan Kiszka
On 2012-05-24 10:10, Igor Mammedov wrote: On 05/23/2012 11:26 PM, Peter Maydell wrote: On 23 May 2012 22:09, Igor Mammedovimamm...@redhat.com wrote: For cpu-hotplug it was suggested to use device_add/del interface for it. To do so in a generalized way hot-plugged cpu should follow general

Re: [Qemu-devel] [PATCH 1.1 1/1] Fix geometry sector calculation

2012-05-24 Thread Christian Borntraeger
On 24/05/12 15:06, Alexander Graf wrote: On 24.05.2012, at 13:48, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/05/2012 13:22, Christian Borntraeger ha scritto: Currently the sector value for the geometry is masked, even if the user usesa command line parameter that explicitely gives a

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Jan Kiszka
On 2012-05-24 09:27, Zhi Yong Wu wrote: On Thu, May 24, 2012 at 8:09 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 12:14, zwu.ker...@gmail.com wrote: From: Zhi Yong

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Jan Kiszka
On 2012-05-24 09:34, Zhi Yong Wu wrote: On Thu, May 24, 2012 at 8:09 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 12:14, zwu.ker...@gmail.com wrote: From: Zhi Yong

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Andreas Färber
Am 24.05.2012 04:12, schrieb TeLeMan: I won't use my Chinese name because I think it's my privacy. That exactly is touching the core point: Signed-off-by is about transparency and taking responsibility for your actions, not hiding in anonymity. It's a certification of whom the code came from

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-24 Thread Igor Mammedov
On 05/24/2012 03:25 PM, Jan Kiszka wrote: On 2012-05-24 10:10, Igor Mammedov wrote: On 05/23/2012 11:26 PM, Peter Maydell wrote: On 23 May 2012 22:09, Igor Mammedovimamm...@redhat.com wrote: For cpu-hotplug it was suggested to use device_add/del interface for it. To do so in a generalized

[Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-24 Thread Paolo Bonzini
changes from v1: - added per-job iostatus - added description of persistent dirty bitmap The same content is also at http://wiki.qemu.org/Features/LiveBlockMigration/1.2 QMP changes for error handling == * query-block-jobs: BlockJobInfo gets two new fields, paused

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 14:58, Anthony Liguori ha scritto: We should change that to a parent_bus property, parent_bus is a property with the QOM bus series I missed that... BTW do we need an object_property_add_link_readonly? Paolo

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-24 Thread Andreas Färber
Am 24.05.2012 15:10, schrieb Igor Mammedov: On 05/23/2012 11:26 PM, Peter Maydell wrote: On 23 May 2012 22:09, Igor Mammedovimamm...@redhat.com wrote: For cpu-hotplug it was suggested to use device_add/del interface for it. To do so in a generalized way hot-plugged cpu should follow general

Re: [Qemu-devel] [PATCH v2] Prevent disk data loss when closing qemu

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 14:49, Andreas Färber ha scritto: -exit(STATUS_CONTROL_C_EXIT); +qemu_system_shutdown_request(); +/* Windows 7 kills application when the function returns. + Sleep here to give QEMU a try for closing */ +Sleep(1); How do we know that 1 is

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Igor Mammedov
On 05/24/2012 03:04 PM, Anthony Liguori wrote: On 05/24/2012 06:43 AM, Markus Armbruster wrote: To create objects via QMP. Test case: $ upstream-qemu --enable-kvm -S -m 384 -vnc :0 -monitor stdio -chardev socket,id=qmp,path=test-qmp,server=on,wait=off -mon mode=control,chardev=qmp

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-24 Thread Ori Mamluk
On 24/05/2012 16:41, Paolo Bonzini wrote: The dirty bitmap is managed by these QMP commands: * blockdev-dirty-enable: takes a file name used for the dirty bitmap, and an optional granularity. Setting the granularity will not be supported in the initial version. * query-block-dirty: returns

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Andreas Färber
Am 24.05.2012 15:48, schrieb Igor Mammedov: On 05/24/2012 03:04 PM, Anthony Liguori wrote: I'm not sure how I feel about this. I never intended for a user to be able to create objects that were arbitrary children of other objects. In some ways, I think this is almost too powerful of an

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Anthony Liguori
On 05/24/2012 08:48 AM, Igor Mammedov wrote: On 05/24/2012 03:04 PM, Anthony Liguori wrote: On 05/24/2012 06:43 AM, Markus Armbruster wrote: To create objects via QMP. Test case: $ upstream-qemu --enable-kvm -S -m 384 -vnc :0 -monitor stdio -chardev

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Anthony Liguori
On 05/24/2012 09:01 AM, Andreas Färber wrote: Am 24.05.2012 15:48, schrieb Igor Mammedov: On 05/24/2012 03:04 PM, Anthony Liguori wrote: I'm not sure how I feel about this. I never intended for a user to be able to create objects that were arbitrary children of other objects. In some ways, I

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 24.05.2012 13:43, schrieb Markus Armbruster: Beware: second patch is the product of voodoo-coding. Hm, I don't like the voodoo. ;) I would rather expose a proper C API like object_try_new(const char *, Error **) than opening up the TypeImpl

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Anthony Liguori
On 05/24/2012 08:18 AM, Peter Maydell wrote: On 24 May 2012 14:06, Anthony Liguorianth...@codemonkey.ws wrote: There are very few places where errors can be handled gracefully. They are exceptions and can be treated as such. I think it's far better for the QOM infrastructure to assert when

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Anthony Liguori
On 05/24/2012 08:44 AM, Paolo Bonzini wrote: Il 24/05/2012 14:58, Anthony Liguori ha scritto: We should change that to a parent_bus property, parent_bus is a property with the QOM bus series I missed that... BTW do we need an object_property_add_link_readonly? Do we want it to be a

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 9:30 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:27, Zhi Yong Wu wrote: On Thu, May 24, 2012 at 8:09 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 9:33 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:34, Zhi Yong Wu wrote: On Thu, May 24, 2012 at 8:09 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 16:00, Ori Mamluk ha scritto: The dirty bitmap is managed by these QMP commands: * blockdev-dirty-enable: takes a file name used for the dirty bitmap, and an optional granularity. Setting the granularity will not be supported in the initial version. * query-block-dirty:

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:11, Max Filippov wrote: On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Peter Maydell
On 24 May 2012 15:10, Anthony Liguori anth...@codemonkey.ws wrote: On 05/24/2012 08:18 AM, Peter Maydell wrote: Last time I was trying to argue for keeping the create, set properties, realize interface for devices/objects as simple as possible you wanted it to have an error-return interface

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:12, Zhi Yong Wu wrote: On Thu, May 24, 2012 at 9:30 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:27, Zhi Yong Wu wrote: On Thu, May 24, 2012 at 8:09 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-23 23:42, Zhi Yong Wu wrote: On Wed, May 23, 2012 at

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 05/24/2012 06:43 AM, Markus Armbruster wrote: To create objects via QMP. Test case: $ upstream-qemu --enable-kvm -S -m 384 -vnc :0 -monitor stdio -chardev socket,id=qmp,path=test-qmp,server=on,wait=off -mon mode=control,chardev=qmp

  1   2   >