Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 22:38, Blue Swirl ha scritto: >> > It's a whole lot of churn though, and clobbers the history for most QMP >> > functions. It also seems like a strange thing for clang to complain >> > about... > Not really, it's just C99: > http://en.wikipedia.org/wiki/Restrict > > Prefixing would

Re: [Qemu-devel] [RFC-v5] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 22:52, Eric Northup ha scritto: > It seems to me like this is not the way that virtio devices are supposed > to behave - if a guest splits a virtio_scsi_cmd_req or _resp across a > page boundary, then this code won't work. Buffers can cover several pages. Of course, data buffers hav

Re: [Qemu-devel] [RFC PATCH 2/4] block: add live block commit functionality

2012-07-31 Thread Kevin Wolf
Am 31.07.2012 19:55, schrieb Jeff Cody: > On 07/31/2012 01:51 PM, Eric Blake wrote: >> On 07/30/2012 11:16 PM, Jeff Cody wrote: >>> This adds the live commit coroutine. This iteration focuses on the >>> commit only below the active layer, and not the active layer itself. >>> >>> The behaviour is s

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-07-31 Thread Kevin Wolf
Am 31.07.2012 19:17, schrieb Eric Blake: > On 07/30/2012 03:34 PM, Supriya Kannery wrote: >> raw-posix driver changes for bdrv_reopen_xx functions to >> safely reopen image files. Reopening of image files while >> changing hostcache dynamically is handled here. >> >> Signed-off-by: Supriya Kannery

[Qemu-devel] [PATCH 3/3] vfio: Enable vfio-pci and mark supported

2012-07-31 Thread Alex Williamson
Signed-off-by: Alex Williamson --- MAINTAINERS |5 + configure | 12 hw/i386/Makefile.objs |1 + 3 files changed, 18 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d219d2..9680d69 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -460,6

[Qemu-devel] [PATCH 1/3] vfio: Import vfio kernel header

2012-07-31 Thread Alex Williamson
Signed-off-by: Alex Williamson --- linux-headers/linux/vfio.h | 368 1 file changed, 368 insertions(+) create mode 100644 linux-headers/linux/vfio.h diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h new file mode 100644 index 000

[Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2

2012-07-31 Thread Alex Williamson
VFIO kernel support was just merged into Linux, so I'd like to formally propose inclusion of the QEMU vfio-pci driver for QEMU 1.2. Included here is support for x86 PCI device assignment. PCI INTx is not yet enabled, but devices making use of either MSI or MSI-X work. The level irqfd and eoifd su

[Qemu-devel] virtio-blk: Something bizarre with VIRTIO_BLK_T_GET_ID

2012-07-31 Thread Benjamin Herrenschmidt
Hi Anthony ! I was looking at virtio-blk.c as an example of some details regarding the use of virtio queues. One thing I'm implementing is a request/reponse model similar to what it does. One thing I noticed that sounds off to me but I might have missed something is the handling of the "GET_ID" r

[Qemu-devel] [PATCH] Remove ill-advised fallback when we cannot allocate from -mem-path

2012-07-31 Thread David Gibson
When the -mem-path option is specified we try to allocate memory for guest RAM from mmap()ing files in the given path rather than from anonymous memory as usual. If we are unable to allocate memory from the path, we fall back to anonymous memory, with a rather cryptic error message. This fallback

Re: [Qemu-devel] [RFC-v5] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-31 Thread Eric Northup
On Thu, Jul 26, 2012 at 4:43 PM, Nicholas A. Bellinger wrote: > [...] > +static void vhost_scsi_handle_vq(struct vhost_scsi *vs) > +{ > + struct vhost_virtqueue *vq = &vs->vqs[2]; > + struct virtio_scsi_cmd_req v_req; > + struct tcm_vhost_tpg *tv_tpg; > + struct tcm_vhost_c

[Qemu-devel] [PATCH] eventfd: making it thread safe

2012-07-31 Thread David Gibson
From: Alexey Kardashevskiy QEMU uses IO handlers to run select() in the main loop. The handlers list is managed by qemu_set_fd_handler() helper which works fine when called from the main thread as it is called when select() is not waiting. However IO handlers list can be changed in the thread ot

Re: [Qemu-devel] [kvmarm] [PATCH] target-arm: kvm: use KVM_SET_SREGS to set target to Cortex A15

2012-07-31 Thread Antonios Motakis
On Wed, Jul 25, 2012 at 8:17 AM, Rusty Russell wrote: > On Tue, 17 Jul 2012 19:19:16 +0100, Peter Maydell < > peter.mayd...@linaro.org> wrote: > > So I can't see anything better than "complain and return failure > > from kvm_arch_init_vcpu() if the guest CPU isn't going to work". > > OK, here's wh

[Qemu-devel] [RESEND PULL REQUEST] UniCore32 PUV3 machine support

2012-07-31 Thread gxt
are available in the git repository at: git://github.com/gxt/QEMU.git unicore32 Andreas Färber (1): target-unicore32: Drop UC32_CPUID macros Guan Xuetao (14): unicore32-softmmu: Add unicore32-softmmu build support unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) inst

[Qemu-devel] [PATCHv2] unicore32-softmmu: Add a minimal curses screen support

2012-07-31 Thread gxt
From: Guan Xuetao This patch adds a minimal curses screen support for unicore32-softmmu. We assume 80*30 screen size to minimize the implementation. Two problems are not solved, but they are innocuous. 1. curses windows will be blank when switching to monitor screen and back 2. backspace is not h

[Qemu-devel] [PATCHv3 3/3] unicore32: Close dump-option of cpu_dump_state_ucf64 function

2012-07-31 Thread gxt
From: Guan Xuetao Since of tedious output, we close dump-option of cpu_dump_state_ucf64 function. Signed-off-by: Guan Xuetao --- target-unicore32/translate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-unicore32/translate.c b/target-unicore32/translate.c in

[Qemu-devel] [PATCHv3 1/3] unicore32: Split UniCore-F64 instruction helpers from helper.c

2012-07-31 Thread gxt
From: Guan Xuetao This patch just splits ucf64 instruction simulation helpers from helper.c. Also, two checkpatch warnings are solved. v1->v2: adjust copyright information for new ucf64_helper.c Signed-off-by: Guan Xuetao --- target-unicore32/Makefile.objs |2 + target-unicore32/helper.c

[Qemu-devel] [PATCHv3 2/3] unicore32: Disintegrate cpu_dump_state_ucf64 function

2012-07-31 Thread gxt
From: Guan Xuetao This patch disintegrates cpu_dump_state_ucf64 function from cpu_dump_state. Signed-off-by: Guan Xuetao --- target-unicore32/translate.c | 41 + 1 files changed, 25 insertions(+), 16 deletions(-) diff --git a/target-unicore32/translat

Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog

2012-07-31 Thread Alexander Graf
On 20.07.2012, at 07:23, Bharat Bhushan wrote: > Enable the KVM emulated watchdog if KVM supports (use the > capability enablement in watchdog handler). Also watchdog exit > (KVM_EXIT_WATCHDOG) handling is added. > Watchdog state machine is cleared whenever VM state changes to running. > This is

Re: [Qemu-devel] [PATCH] memory: add cmd line option to omit guest memory from qmeu core dump

2012-07-31 Thread Anthony Liguori
Eric Blake writes: > On 07/31/2012 06:07 PM, Anthony Liguori wrote: >> Jason Baron writes: >> >>> Add a new '[,dump=on|off]' option to the '-m' memory option. When 'dump=off' >>> is specified, guest memory is omitted from the core dump. The default >>> behavior >>> continues to be to include g

Re: [Qemu-devel] [kvmarm] [PATCH] target-arm: kvm: use KVM_SET_SREGS to set target to Cortex A15

2012-07-31 Thread Rusty Russell
On Tue, 31 Jul 2012 23:52:20 +0200, Antonios Motakis wrote: > Hello, > > I've been trying to get your msr-ops linux-kvm & qemu branches to work, but > so far I've not had any luck booting a guest. I'll nuke my setup and start > over tomorrow to make sure I don't have something broken. Are there

Re: [Qemu-devel] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v3)

2012-07-31 Thread Kevin O'Connor
On Wed, Jul 25, 2012 at 03:45:28PM -0300, Eduardo Habkost wrote: > Changes v2 -> v3: > - Report I/O APIC ID = 0 on MP-table, too > > Changes v1 -> v2: > - Patch 1/2: cosmetic whitespace change > - Patch 2/2: use size suffixes on asm instructions on smp.c > - New patch descriptions > > Eduardo

Re: [Qemu-devel] [PATCH] memory: add cmd line option to omit guest memory from qmeu core dump

2012-07-31 Thread Eric Blake
On 07/31/2012 06:07 PM, Anthony Liguori wrote: > Jason Baron writes: > >> Add a new '[,dump=on|off]' option to the '-m' memory option. When 'dump=off' >> is specified, guest memory is omitted from the core dump. The default >> behavior >> continues to be to include guest memory when a core dump

Re: [Qemu-devel] [PATCH] memory: add cmd line option to omit guest memory from qmeu core dump

2012-07-31 Thread Anthony Liguori
Jason Baron writes: > Add a new '[,dump=on|off]' option to the '-m' memory option. When 'dump=off' > is specified, guest memory is omitted from the core dump. The default behavior > continues to be to include guest memory when a core dump is triggered. In my > testing, this brought the core dump

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-07-31 Thread Anthony Liguori
Paolo Bonzini writes: > Il 30/07/2012 18:04, blauwir...@gmail.com ha scritto: >> From: Blue Swirl >> >> Clang compiler complained about use of reserved word 'restrict' in SLIRP >> and QAPI. >> >> Rename 'restrict' to 'restricted' which also matches other SLIRP code. > > Can't do it, this chang

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-07-31 Thread Michael Roth
On Tue, Jul 31, 2012 at 08:38:45PM +, Blue Swirl wrote: > On Tue, Jul 31, 2012 at 6:55 PM, Michael Roth > wrote: > > On Tue, Jul 31, 2012 at 04:56:50PM +, Blue Swirl wrote: > >> On Tue, Jul 31, 2012 at 12:58 PM, Luiz Capitulino > >> wrote: > >> > On Tue, 31 Jul 2012 09:28:43 +0200 > >> >

Re: [Qemu-devel] [PATCH v4] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-07-31 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Tue, Jul 31, 2012 at 02:52:07PM -0500, Anthony Liguori wrote: >> Paul Moore writes: >> >> > On Friday, June 08, 2012 05:38:12 PM Paul Moore wrote: >> >> FIPS 140-2 requires disabling certain ciphers, including DES, which is >> >> used >> >> by VNC to obscure p

Re: [Qemu-devel] [GIT PULL (PATCH 0/4)] VFIO driver for v3.6

2012-07-31 Thread Alex Williamson
On Tue, 2012-07-31 at 08:53 -0600, Alex Williamson wrote: > On Mon, 2012-07-30 at 22:11 -0700, Linus Torvalds wrote: > > On Mon, Jul 30, 2012 at 4:17 PM, Alex Williamson > > wrote: > > > > > > I'm pretty anxious to find out as well. Linus, ping, any thoughts on > > > including this in 3.6? Thank

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-07-31 Thread Blue Swirl
On Tue, Jul 31, 2012 at 6:55 PM, Michael Roth wrote: > On Tue, Jul 31, 2012 at 04:56:50PM +, Blue Swirl wrote: >> On Tue, Jul 31, 2012 at 12:58 PM, Luiz Capitulino >> wrote: >> > On Tue, 31 Jul 2012 09:28:43 +0200 >> > Paolo Bonzini wrote: >> > >> >> Il 30/07/2012 18:04, blauwir...@gmail.com

Re: [Qemu-devel] [v2 Patch 0/9]block: Image file reopen and dynamic host pagecache change

2012-07-31 Thread Jeff Cody
On 07/30/2012 05:34 PM, Supriya Kannery wrote: > For changing host pagecache setting of a running VM, it is > important to have a safe way of reopening its image file. > Hi Supriya, I never received patches 6 or 8, either through the list or at my direct email address - looking at the qemu-deve

Re: [Qemu-devel] [PATCH v4] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-07-31 Thread Paul Moore
On Tuesday, July 31, 2012 09:12:57 PM Daniel P. Berrange wrote: > On Tue, Jul 31, 2012 at 02:52:07PM -0500, Anthony Liguori wrote: > > Paul Moore writes: > > > On Friday, June 08, 2012 05:38:12 PM Paul Moore wrote: > > >> FIPS 140-2 requires disabling certain ciphers, including DES, which is > > >

[Qemu-devel] [PATCH] memory: add cmd line option to omit guest memory from qmeu core dump

2012-07-31 Thread Jason Baron
Add a new '[,dump=on|off]' option to the '-m' memory option. When 'dump=off' is specified, guest memory is omitted from the core dump. The default behavior continues to be to include guest memory when a core dump is triggered. In my testing, this brought the core dump size down from 384MB to 6 MB o

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-31 Thread Eric Blake
On 07/31/2012 12:54 PM, Orit Wasserman wrote: Subject line is stale. > The management can enable/disable a capability for the next migration by using > migrate_set_capabilities QMP command. The QMP command is spelled migrate-set-capabilities. > The management can query the current migration cap

Re: [Qemu-devel] [PATCH 00/11] configure: Fix -Werror issues

2012-07-31 Thread Blue Swirl
Thanks, applied patches 1 to 10. On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell wrote: > This patch series: > 1. turns off -Werror for configure tests > 2. fixes a large pile of warnings in various configure tests > 3. turns on -Werror for configure tests again, but in a way that means > t

Re: [Qemu-devel] [PATCH] configure: Split valgrind test into pragma test and valgrind.h test

2012-07-31 Thread Blue Swirl
Thanks, applied. On Mon, Jul 30, 2012 at 3:13 PM, Peter Maydell wrote: > Split the configure test that checks for valgrind into two, one > part checking whether we have the gcc pragma to disable unused-but-set > variables, and the other part checking for the existence of valgrind.h. > The first o

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Hannes Reinecke
On 07/31/2012 05:45 PM, Paolo Bonzini wrote: Il 31/07/2012 17:15, Anthony Liguori ha scritto: Andreas Färber writes: Am 31.07.2012 16:50, schrieb Paolo Bonzini: Il 31/07/2012 16:46, Andreas Färber ha scritto: Why would megasas be in master but not compiled/linked? Because Anthony objected

Re: [Qemu-devel] [PATCH v4] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-07-31 Thread Daniel P. Berrange
On Tue, Jul 31, 2012 at 02:52:07PM -0500, Anthony Liguori wrote: > Paul Moore writes: > > > On Friday, June 08, 2012 05:38:12 PM Paul Moore wrote: > >> FIPS 140-2 requires disabling certain ciphers, including DES, which is used > >> by VNC to obscure passwords when they are sent over the network.

[Qemu-devel] [PATCH 02/11] Add migrate_set_capabilities and query-migrate-capabilities

2012-07-31 Thread Orit Wasserman
The management can enable/disable a capability for the next migration by using migrate-set-apabilities QMP command. The management can query the current migration capabilities using query-migrate-capabilities QMP command. The user can use migrate_set_capability and 'info migrate_capabilities' HMP c

Re: [Qemu-devel] [PATCH v4] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-07-31 Thread Anthony Liguori
Paul Moore writes: > On Friday, June 08, 2012 05:38:12 PM Paul Moore wrote: >> FIPS 140-2 requires disabling certain ciphers, including DES, which is used >> by VNC to obscure passwords when they are sent over the network. The >> solution for FIPS users is to disable the use of VNC password auth

[Qemu-devel] [PATCH 03/11] Add XBZRLE documentation

2012-07-31 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- docs/xbzrle.txt | 136 +++ 1 files changed, 136 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index 000..1463c0a ---

[Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-07-31 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 38 ++ hmp.c|6 ++ migration.c |6 ++ migration.h

[Qemu-devel] [PATCH 04/11] Add cache handling functions

2012-07-31 Thread Orit Wasserman
Add MRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs |1 + cutils.c |9 ++ include/qemu/page_cache.h |

[Qemu-devel] [PATCH 06/11] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-31 Thread Orit Wasserman
For performance we are encoding long word at a time. For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp(): using ((lword - 0x0101010101010101) & (~lword) & 0x8080808080808080) test to find out if any byte in the long word is zero. Signed-off-by: Benoit Hudzia Signed-off-by: Pe

[Qemu-devel] [PATCH 08/11] Add migrate_set_cachesize command

2012-07-31 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2, it will be rounded down to the nearest power of 2). If XBZRLE cache size is too small there will be many cache miss. New query-migrate-cache-size QMP command and 'info migrate-cache-size' HMP command to query cache value. Signed-

[Qemu-devel] [PATCH 07/11] Add XBZRLE to ram_save_block and ram_save_live

2012-07-31 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed, then send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBZRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia Signed-

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-07-31 Thread Michael Roth
On Tue, Jul 31, 2012 at 04:56:50PM +, Blue Swirl wrote: > On Tue, Jul 31, 2012 at 12:58 PM, Luiz Capitulino > wrote: > > On Tue, 31 Jul 2012 09:28:43 +0200 > > Paolo Bonzini wrote: > > > >> Il 30/07/2012 18:04, blauwir...@gmail.com ha scritto: > >> > From: Blue Swirl > >> > > >> > Clang comp

Re: [Qemu-devel] [RFC] Factor out fifos / circular buffers

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 02:20 PM, Peter Crosthwaite wrote: Hi All, A lot of devices have little internal fifos that are often implemented as circular buffers in the device state. Any reason to not factor that out into a helper module? Was thinkin just a struct defintion containing the key elements (the ui

[Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-07-31 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 28 hmp.c| 13 + migration.c | 17 + migrati

[Qemu-devel] [PATCH 11/11] Restart optimization on stage3 update version

2012-07-31 Thread Orit Wasserman
From: Juan Quintela Signed-off-by: Juan Quintela --- arch_init.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 9833d54..21031d1 100644 --- a/arch_init.c +++ b/arch_init.c @@ -273,14 +273,16 @@ static void save_bl

[Qemu-devel] [PATCH 05/11] Add uleb encoding/decoding functions

2012-07-31 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- cutils.c | 33 + qemu-common.h |8 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index b0bdd4b..700f943 100644 --- a/cutils.c +++

[Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-31 Thread Orit Wasserman
The management can enable/disable a capability for the next migration by using migrate_set_capabilities QMP command. The management can query the current migration capabilities using query-migrate-capabilities QMP command. The user can use migrate_set_capability and 'info migrate_capabilities' HMP

[Qemu-devel] [PATCH 01/11] Add migration capabilities

2012-07-31 Thread Orit Wasserman
Add migration capabilities that can be queried by the management using query-migration-supported-capabilities command. The management can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only XBZRLE). Signed-off-by: Orit Wasserman

[Qemu-devel] [PATCH 00/11] Migration next v8

2012-07-31 Thread Orit Wasserman
Changes from v7: rename migrate-set-parameter to migrate-set-capabilities rename query-migrate-parameters to query-migrate-capabilities renamse query-migration-capabilities to query-migration-supported-capabilities fix query_migration_supported_capabilties to return a list add query-migrate-cache-s

Re: [Qemu-devel] [RFC PATCH 1/4] block: add support functions for live commit, to find and delete images.

2012-07-31 Thread Jeff Cody
On 07/31/2012 01:34 PM, Eric Blake wrote: > On 07/30/2012 11:16 PM, Jeff Cody wrote: >> Add bdrv_find_image(), bdrv_find_base(), and bdrv_delete_intermediate(). >> >> bdrv_find_image(): given a filename and a BDS, find the image in the chain >> that matches the passed filename.

Re: [Qemu-devel] [PATCH 14/47] stream: add on-error argument

2012-07-31 Thread Eric Blake
On 07/24/2012 05:03 AM, Paolo Bonzini wrote: > This patch adds support for error management to streaming. > > Signed-off-by: Paolo Bonzini > --- > +++ b/qapi-schema.json > @@ -1656,17 +1656,23 @@ > # > # @speed: #optional the maximum speed, in bytes per second > # > +# @on-error: #optional t

Re: [Qemu-devel] [RFC PATCH 4/4] QAPI: add command for live block commit, 'block-commit'

2012-07-31 Thread Eric Blake
On 07/30/2012 11:16 PM, Jeff Cody wrote: > The command for live block commit is added, which has the following > arguments: > > device: the block device to perform the commit on (mandatory) > base: the base image to commit into; optional (if not specified, > it is the underlying original

Re: [Qemu-devel] [RFC PATCH 3/4] qerror: new errors for live block commit, QERR_TOP_NOT_FOUND

2012-07-31 Thread Eric Blake
On 07/30/2012 11:16 PM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > qerror.c |4 > qerror.h |3 +++ > 2 files changed, 7 insertions(+) > > diff --git a/qerror.c b/qerror.c > index 25c2733..69a59ab 100644 > --- a/qerror.c > +++ b/qerror.c > @@ -307,6 +307,10 @@ static const Q

Re: [Qemu-devel] [PATCH V4 10/12] SD card users: optimize access to SDClass methods

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 10:15 PM, Anthony Liguori wrote: How many loop iterations that? 300us is a huge amount of time, unless you were looping on every byte, I have a hard time understanding that delta. I'm not sure I understand what you mean, I did loop on every byte, that's how our SD model works. S

Re: [Qemu-devel] [v2 Patch 4/9]block: vmdk image file reopen

2012-07-31 Thread Eric Blake
On 07/30/2012 03:35 PM, Supriya Kannery wrote: > vmdk driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. > > Signed-off-by: Supriya Kannery > > --- > @@ -588,7 +596,6 @@ static int vmdk_par

Re: [Qemu-devel] [PATCH v4] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-07-31 Thread Paul Moore
On Friday, June 08, 2012 05:38:12 PM Paul Moore wrote: > FIPS 140-2 requires disabling certain ciphers, including DES, which is used > by VNC to obscure passwords when they are sent over the network. The > solution for FIPS users is to disable the use of VNC password auth when the > host system is

Re: [Qemu-devel] [RFC PATCH 2/4] block: add live block commit functionality

2012-07-31 Thread Jeff Cody
On 07/31/2012 01:51 PM, Eric Blake wrote: > On 07/30/2012 11:16 PM, Jeff Cody wrote: >> This adds the live commit coroutine. This iteration focuses on the >> commit only below the active layer, and not the active layer itself. >> >> The behaviour is similar to block streaming; the sectors are walk

Re: [Qemu-devel] [RFC PATCH 1/4] block: add support functions for live commit, to find and delete images.

2012-07-31 Thread Eric Blake
On 07/30/2012 11:16 PM, Jeff Cody wrote: > Add bdrv_find_image(), bdrv_find_base(), and bdrv_delete_intermediate(). > > bdrv_find_image(): given a filename and a BDS, find the image in the chain > that matches the passed filename. > > bdrv_find_base(): given a BDS, find the

Re: [Qemu-devel] [RFC PATCH 2/4] block: add live block commit functionality

2012-07-31 Thread Eric Blake
On 07/30/2012 11:16 PM, Jeff Cody wrote: > This adds the live commit coroutine. This iteration focuses on the > commit only below the active layer, and not the active layer itself. > > The behaviour is similar to block streaming; the sectors are walked > through, and anything that exists above 'b

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 06:56 PM, Peter Maydell wrote: On 27 July 2012 20:29, Igor Mitsyanko wrote: +VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0, wpgrps_size, +sizeof(unsigned long)), Isn't this trying to use wpgrps_size as the number of unsigned longs in the bitmap,

Re: [Qemu-devel] [PATCH V4 10/12] SD card users: optimize access to SDClass methods

2012-07-31 Thread Anthony Liguori
Igor Mitsyanko writes: > On 07/31/2012 07:43 PM, Peter Maydell wrote: >> On 27 July 2012 20:29, Igor Mitsyanko wrote: >>> Rather that repeatedly call SD_GET_CLASS() in a loop, call it once before >>> a loop starts. >> Anthony claims that SD_GET_CLASS should be cheap enough that we don't >> need

Re: [Qemu-devel] [PATCH V4 10/12] SD card users: optimize access to SDClass methods

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 09:47 PM, Peter Maydell wrote: On 31 July 2012 18:33, Igor Mitsyanko wrote: On 07/31/2012 07:43 PM, Peter Maydell wrote: Anthony claims that SD_GET_CLASS should be cheap enough that we don't need to hoist it out of loops like this. Do you have profiling data or similar that cause

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Peter Maydell
On 31 July 2012 18:56, Blue Swirl wrote: > On Tue, Jul 31, 2012 at 4:40 PM, Peter Maydell > wrote: >> I believe the valgrind test patch should fix the issues Blue Swirl >> was seeing with the 11-patch series (and I tested it on debian >> squeeze which I think has the same gcc Blue was using). >>

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Blue Swirl
On Tue, Jul 31, 2012 at 4:40 PM, Peter Maydell wrote: > On 31 July 2012 17:33, Stefan Weil wrote: >> please apply http://patchwork.ozlabs.org/patch/171067/, >> or we'll get a 4th bug fix for this. >> >> Peter sent a series with this one and more patches on >> 2012-07-18 (1st: http://patchwork.ozl

Re: [Qemu-devel] [PATCH V4 10/12] SD card users: optimize access to SDClass methods

2012-07-31 Thread Peter Maydell
On 31 July 2012 18:33, Igor Mitsyanko wrote: > On 07/31/2012 07:43 PM, Peter Maydell wrote: >> Anthony claims that SD_GET_CLASS should be cheap enough that we don't >> need to hoist it out of loops like this. Do you have profiling data >> or similar that caused you to write this patch? > Well, I'

Re: [Qemu-devel] [v2 Patch 9/9]block: Enhance "info block" to display host cache setting

2012-07-31 Thread Eric Blake
On 07/30/2012 03:36 PM, Supriya Kannery wrote: > Enhance "info block" to display hostcache setting for each > block device. > > Example: > (qemu) info block > ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 > > Enhanced to display "hostcache" setting: > (qemu) info block > ide

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Aneesh Kumar K.V
Stefan Weil writes: > Am 31.07.2012 08:52, schrieb Aneesh Kumar K.V: >> Avi Kivity writes: >> >>> - avoid assigned-but-not-used error >>> - avoid missing return error >>> >>> Signed-off-by: Avi Kivity >> >> Acked-by: Aneesh Kumar K.V >> >> >>> --- >>> configure | 2 +- >>> 1 file

Re: [Qemu-devel] [PATCH V4 10/12] SD card users: optimize access to SDClass methods

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 07:43 PM, Peter Maydell wrote: On 27 July 2012 20:29, Igor Mitsyanko wrote: Rather that repeatedly call SD_GET_CLASS() in a loop, call it once before a loop starts. Anthony claims that SD_GET_CLASS should be cheap enough that we don't need to hoist it out of loops like this. Do y

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-07-31 Thread Peter Maydell
On 23 July 2012 15:21, Peter Maydell wrote: > On 29 June 2012 15:04, Anthony Liguori wrote: >> On 06/28/2012 12:51 PM, Peter Maydell wrote: >>> On 20 June 2012 15:44, Anthony Liguori wrote: This avoids the problem associated with having multiple target specific files in a single direct

[Qemu-devel] [PULL] VirtFS update

2012-07-31 Thread Aneesh Kumar K.V
Hi Anthony, I have merged the configure fix which is sent as a part of http://thread.gmane.org/gmane.comp.emulators.qemu/160620/focus=160634 The following changes since commit 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: Merge remote-tracking branch 'mst/tags/for_anthony' into staging (2012-07

Re: [Qemu-devel] [PATCH] hw/armv7m_nvic: Fix incorrect default for num-irqs property

2012-07-31 Thread Peter Maydell
On 31 July 2012 01:37, Peter Crosthwaite wrote: > On Tue, Jul 24, 2012 at 8:39 PM, Peter Maydell > wrote: >> Fix an incorrect default value for the num-irqs property >> >> Signed-off-by: Peter Maydell > > Tested-by: Peter Crosthwaite > > Should I have one of those reported-by things here as we

[Qemu-devel] [PATCH 6/6 v11] add-cow: support qemu-iotests

2012-07-31 Thread Dong Xu Wang
add qemu-iotests support for add-cow file format. Signed-off-by: Dong Xu Wang --- tests/qemu-iotests/017 |2 +- tests/qemu-iotests/020 |2 +- tests/qemu-iotests/check |4 ++-- tests/qemu-iotests/common|6 ++ tests/qemu-iotests/common.rc | 19 +++

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-07-31 Thread Eric Blake
On 07/30/2012 03:34 PM, Supriya Kannery wrote: > raw-posix driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. > > Signed-off-by: Supriya Kannery > > --- > Index: qemu/block/raw.c >

Re: [Qemu-devel] Adding a parameter to a helper

2012-07-31 Thread Jose Cano Reyes
Ok, I am going to try... In fact, I did it before posting Laurent, but I don't understand it completely. Anyway, thanks a lot for your help. Jose. El 31/07/12 17:14, Laurent Desnogues escribió: On Tue, Jul 31, 2012 at 5:09 PM, Jose Cano Reyes wrote: - So, how ca I obtain the value

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 08:17 PM, Peter Maydell wrote: On 31 July 2012 16:29, Markus Armbruster wrote: Igor Mitsyanko writes: QEMU requires all objects derived from TYPE_DEVICE to be connected to some bus, if no bus was specified in new object class description, QEMU practically assumes this object to

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Blue Swirl
On Tue, Jul 31, 2012 at 4:40 PM, Peter Maydell wrote: > On 31 July 2012 17:33, Stefan Weil wrote: >> please apply http://patchwork.ozlabs.org/patch/171067/, >> or we'll get a 4th bug fix for this. >> >> Peter sent a series with this one and more patches on >> 2012-07-18 (1st: http://patchwork.ozl

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Blue Swirl
On Tue, Jul 31, 2012 at 4:20 PM, Stefan Weil wrote: > Am 31.07.2012 17:51, schrieb Peter Maydell: >> >> On 31 July 2012 16:49, Stefan Weil wrote: >>> >>> Yes, QEMU creates files in 3 levels. We could use >>> >>> rm -f *.[od] */*.[od] */*/*.[od] >>> >>> I suggest using the wrapper $(call quie

[Qemu-devel] [PATCH 3/6] add-cow file format

2012-07-31 Thread Dong Xu Wang
This is the implementation code for add-cow file format. Because image_file might be very huge, then we can't read entire bitmap into memory, we must use a cache. Since qcow-cache.c has implemted cache code, we can create our cache code based on it. Signed-off-by: Dong Xu Wang --- block/Makefile

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-07-31 Thread Blue Swirl
On Tue, Jul 31, 2012 at 12:58 PM, Luiz Capitulino wrote: > On Tue, 31 Jul 2012 09:28:43 +0200 > Paolo Bonzini wrote: > >> Il 30/07/2012 18:04, blauwir...@gmail.com ha scritto: >> > From: Blue Swirl >> > >> > Clang compiler complained about use of reserved word 'restrict' in SLIRP >> > and QAPI.

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-31 Thread Alex Williamson
On Tue, 2012-07-31 at 15:34 +0300, Avi Kivity wrote: > On 07/31/2012 01:29 AM, Alex Williamson wrote: > >> > >> If the region size is zero, then both memory_region_del_subregion() > >> (assuming the region is parented) and munmap() do nothing. So you could > >> call this unconditionally. > > > >

[Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public

2012-07-31 Thread Dong Xu Wang
In add-cow file format, we will use path_has_protocol and we will read a NUL-terminated string from image , qed_read_string has done the samething, so make the two functions public, then we will reuse them directly. While creating images files, if no size is specified, will use size of backing fil

[Qemu-devel] [PATCH 5/6 v11] add-cow: hmp and qmp interface

2012-07-31 Thread Dong Xu Wang
add HMP and QMP support for add-cow format. Because add-cow does not work like other image formats, it will use image-file, so we need add add-cow support while doing snapshot. Signed-off-by: Dong Xu Wang --- hmp-commands.hx |8 ++-- hmp.c|5 - qapi-schema.json |

[Qemu-devel] [PATCH 4/6 v11] add-cow: support snapshot_blkde

2012-07-31 Thread Dong Xu Wang
add-cow will let raw file support snapshot_blkdev indirectly. Signed-off-by: Dong Xu Wang --- blockdev.c | 45 + docs/live-block-ops.txt | 11 ++- 2 files changed, 47 insertions(+), 9 deletions(-) diff --git a/blockdev.c b/blo

[Qemu-devel] [PATCH 1/6 v11] docs: spec for add-cow file format

2012-07-31 Thread Dong Xu Wang
Introduce a new file format:add-cow. The usage can be found at this patch. Signed-off-by: Dong Xu Wang --- Now add-cow is still using QEMUOptionParameter, not QemuOpts, I will send a seperate patch series to convert. docs/specs/add-cow.txt | 128 +++

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Peter Maydell
On 31 July 2012 17:33, Stefan Weil wrote: > please apply http://patchwork.ozlabs.org/patch/171067/, > or we'll get a 4th bug fix for this. > > Peter sent a series with this one and more patches on > 2012-07-18 (1st: http://patchwork.ozlabs.org/patch/171686/). > At least the first 10 of them should

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Stefan Weil
Am 31.07.2012 08:52, schrieb Aneesh Kumar K.V: Avi Kivity writes: - avoid assigned-but-not-used error - avoid missing return error Signed-off-by: Avi Kivity Acked-by: Aneesh Kumar K.V --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/confi

Re: [Qemu-devel] [GIT PULL (PATCH 0/4)] VFIO driver for v3.6

2012-07-31 Thread Alex Williamson
On Mon, 2012-07-30 at 22:11 -0700, Linus Torvalds wrote: > On Mon, Jul 30, 2012 at 4:17 PM, Alex Williamson > wrote: > > > > I'm pretty anxious to find out as well. Linus, ping, any thoughts on > > including this in 3.6? Thanks, > > I just pulled it, but then I unpulled again when I realized it

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Stefan Weil
Am 31.07.2012 17:51, schrieb Peter Maydell: On 31 July 2012 16:49, Stefan Weil wrote: Yes, QEMU creates files in 3 levels. We could use rm -f *.[od] */*.[od] */*/*.[od] I suggest using the wrapper $(call quiet-command,...) to suppress printing of all removed file names. My worry was no

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Peter Maydell
On 31 July 2012 16:29, Markus Armbruster wrote: > Igor Mitsyanko writes: >> QEMU requires all objects derived from TYPE_DEVICE to be connected to >> some bus, if no bus was specified in new object class description, >> QEMU practically assumes this object to be a sysbus device and >> connects it

Re: [Qemu-devel] KVM call minutes July 31th

2012-07-31 Thread Andreas Färber
Am 31.07.2012 18:06, schrieb Igor Mammedov: > - Original Message - >> From: "Eduardo Habkost" >> To: "Juan Quintela" , "Anthony Liguori" >> >> Cc: qemu-devel@nongnu.org, "KVM devel mailing list" >> Sent: Tuesday, July 31, 2012 5:40:14 PM >> Subject: Re: [Qemu-devel] KVM call minutes Jul

Re: [Qemu-devel] KVM call minutes July 31th

2012-07-31 Thread Igor Mammedov
- Original Message - > From: "Eduardo Habkost" > To: "Juan Quintela" , "Anthony Liguori" > > Cc: qemu-devel@nongnu.org, "KVM devel mailing list" > Sent: Tuesday, July 31, 2012 5:40:14 PM > Subject: Re: [Qemu-devel] KVM call minutes July 31th > > On Tue, Jul 31, 2012 at 04:32:05PM +0200

Re: [Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpudefs

2012-07-31 Thread Eduardo Habkost
On Fri, Jul 27, 2012 at 08:37:18AM -0500, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > target-i386/cpu.c | 22 ++ > 1 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 6b9659f..b398439 100644 >

Re: [Qemu-devel] KVM call minutes July 31th

2012-07-31 Thread Andreas Färber
Am 31.07.2012 17:40, schrieb Eduardo Habkost: > On Tue, Jul 31, 2012 at 04:32:05PM +0200, Juan Quintela wrote: >> - 1.2 plans for CPU model versioning/compatibility (eduardo) >> (global properties vs QOM vs qdev) >> how to do it ? configuration file? moving back to the code? >> different ex

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-07-31 Thread Luiz Capitulino
On Tue, 31 Jul 2012 17:13:46 +0300 Orit Wasserman wrote: > On 07/31/2012 04:16 PM, Luiz Capitulino wrote: > > On Tue, 31 Jul 2012 11:31:09 +0300 > > Orit Wasserman wrote: > > > >> On 07/30/2012 10:37 PM, Luiz Capitulino wrote: > >>> On Sun, 29 Jul 2012 12:43:02 +0300 > >>> Orit Wasserman wrote

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Peter Maydell
On 31 July 2012 16:49, Stefan Weil wrote: > Yes, QEMU creates files in 3 levels. We could use > > rm -f *.[od] */*.[od] */*/*.[od] > > I suggest using the wrapper $(call quiet-command,...) > to suppress printing of all removed file names. My worry was not so much what we print as that we migh

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Stefan Weil
Am 31.07.2012 17:00, schrieb Peter Maydell: On 31 July 2012 15:38, Daniel P. Berrange wrote: Isn't using 'find' somewhat overkill here really. QEMU only creates .o and .d files in 2 levels of directory, so sure we can just avoid find entirely rm -f *.[od] */*.[od] That's exactly the bug t

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 17:15, Anthony Liguori ha scritto: > Andreas Färber writes: > >> Am 31.07.2012 16:50, schrieb Paolo Bonzini: >>> Il 31/07/2012 16:46, Andreas Färber ha scritto: >> Why would megasas be in master but not compiled/linked? > Because Anthony objected to how it picks the initiato

  1   2   3   >