Re: [Qemu-devel] [PATCH] ppc405_uc: Fix buffer overflow

2012-08-31 Thread Stefan Weil
Am 01.09.2012 08:23, schrieb Alexander Graf: On 31.08.2012, at 22:45, Markus Armbruster wrote: Andreas Färber writes: static uint32_t dcr_read_pob (void *opaque, int dcrn) ... Reviewed-by: Andreas Färber We could alternatively leave besr[2] and access it with hardcoded 0..1. Min

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Alexander Graf
On 31.08.2012, at 13:54, Jason Baron wrote: > On Fri, Aug 31, 2012 at 01:29:46PM -0700, Alexander Graf wrote: >> On 31.08.2012, at 12:15, Jason Baron wrote: >> >>> On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Graf wrote: On 31.08.2012, at 07:23, Jason Baron wrote: > On F

Re: [Qemu-devel] [PATCH] ppc405_uc: Fix buffer overflow

2012-08-31 Thread Alexander Graf
On 31.08.2012, at 22:45, Markus Armbruster wrote: > Andreas Färber writes: > >> Am 31.08.2012 22:21, schrieb Stefan Weil: >>> Report from smatch: >>> >>> ppc405_uc.c:209 dcr_read_pob(12) error: buffer overflow 'pob->besr' 2 <= 2 >>> ppc405_uc.c:232 dcr_write_pob(12) error: buffer overflow 'p

Re: [Qemu-devel] [PATCH] ppc405_uc: Fix buffer overflow

2012-08-31 Thread Markus Armbruster
Andreas Färber writes: > Am 31.08.2012 22:21, schrieb Stefan Weil: >> Report from smatch: >> >> ppc405_uc.c:209 dcr_read_pob(12) error: buffer overflow 'pob->besr' 2 <= 2 >> ppc405_uc.c:232 dcr_write_pob(12) error: buffer overflow 'pob->besr' 2 <= 2 >> >> The old code reads and writes besr[POB0

Re: [Qemu-devel] [PATCH for-1.2] hw/armv7m_nvic: Correctly register GIC region when setting up NVIC

2012-08-31 Thread Peter Maydell
On 31 August 2012 19:16, Anthony Liguori wrote: > Peter Maydell writes: >> Hi Anthony; I realised somewhat belatedly that this bugfix >> should probably go into 1.2 if possible. Can we still >> squeeze it in or is it too late? >> >> Patchwork url: http://patchwork.ozlabs.org/patch/180315/ > > It'

Re: [Qemu-devel] [PATCH] ppc405_uc: Fix buffer overflow

2012-08-31 Thread Andreas Färber
Am 31.08.2012 22:21, schrieb Stefan Weil: > Report from smatch: > > ppc405_uc.c:209 dcr_read_pob(12) error: buffer overflow 'pob->besr' 2 <= 2 > ppc405_uc.c:232 dcr_write_pob(12) error: buffer overflow 'pob->besr' 2 <= 2 > > The old code reads and writes besr[POB0_BESR1 - POB0_BESR0] or besr[2] >

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 01:29:46PM -0700, Alexander Graf wrote: > On 31.08.2012, at 12:15, Jason Baron wrote: > > > On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Graf wrote: > >> On 31.08.2012, at 07:23, Jason Baron wrote: > >> > >>> On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf wro

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 01:29:46PM -0700, Alexander Graf wrote: > On 31.08.2012, at 12:15, Jason Baron wrote: > > > On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Graf wrote: > >> On 31.08.2012, at 07:23, Jason Baron wrote: > >> > >>> On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf wro

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Alexander Graf
On 31.08.2012, at 12:15, Jason Baron wrote: > On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Graf wrote: >> On 31.08.2012, at 07:23, Jason Baron wrote: >> >>> On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf wrote: Am 23.08.2012 23:09, schrieb Jason Baron: > While testing q35

[Qemu-devel] [PATCH] ppc405_uc: Fix buffer overflow

2012-08-31 Thread Stefan Weil
Report from smatch: ppc405_uc.c:209 dcr_read_pob(12) error: buffer overflow 'pob->besr' 2 <= 2 ppc405_uc.c:232 dcr_write_pob(12) error: buffer overflow 'pob->besr' 2 <= 2 The old code reads and writes besr[POB0_BESR1 - POB0_BESR0] or besr[2] which is one too much. Signed-off-by: Stefan Weil ---

Re: [Qemu-devel] [v2 Patch 8/9]block: Cmd "block_set_hostcache" for dynamic cache change

2012-08-31 Thread Jeff Cody
On 08/01/2012 02:44 PM, Supriya Kannery wrote: > New command "block_set_hostcache" added for dynamically changing > host pagecache setting of a block device. > > Usage: > block_set_hostcache > = block device > = on/off > > Example: > (qemu) block_set_hostcache ide0-hd0 off > > Signe

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Graf wrote: > On 31.08.2012, at 07:23, Jason Baron wrote: > > > On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf wrote: > >> Am 23.08.2012 23:09, schrieb Jason Baron: > >>> While testing q35, I found that windows 7 (specifically, windows 7 >

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Alexander Graf
On 31.08.2012, at 07:23, Jason Baron wrote: > On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf wrote: >> Am 23.08.2012 23:09, schrieb Jason Baron: >>> While testing q35, I found that windows 7 (specifically, windows 7 ultimate >>> with sp1 x64), wouldn't install because it can't find the cdro

Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 05:55:45PM +0200, Andreas Färber wrote: > Am 30.08.2012 20:00, schrieb Jason Baron: > > Add support for ahci migration. This patch builds upon the patches posted > > previously by Andreas Faerber: > > > > http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01538.html >

Re: [Qemu-devel] Deprecating "cpudef" on QEMU 1.2

2012-08-31 Thread Eduardo Habkost
On Fri, Aug 31, 2012 at 06:26:34PM +0200, Andreas Färber wrote: > Am 31.08.2012 18:07, schrieb Eduardo Habkost: > > Anthony, I remeber we quickly discussed on #qemu about deprecting the > > support for "cpudef" config sections on QEMU 1.2. But as cpudef is not > > documented anywhere, we would simp

Re: [Qemu-devel] [PATCH] Don't require encryption password for 'qemu-img info' command

2012-08-31 Thread Eric Blake
On 08/31/2012 10:26 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The encryption password is only required if I/O is going to be > performed on a disk image. The 'qemu-img info' command merely > reports metadata, so it should not ask for a decryption password > > Signed-off-by:

Re: [Qemu-devel] [PATCH for-1.2] hw/armv7m_nvic: Correctly register GIC region when setting up NVIC

2012-08-31 Thread Anthony Liguori
Peter Maydell writes: > Hi Anthony; I realised somewhat belatedly that this bugfix > should probably go into 1.2 if possible. Can we still > squeeze it in or is it too late? > > Patchwork url: http://patchwork.ozlabs.org/patch/180315/ It's too late for GA. Can go in via stable though. Regards,

[Qemu-devel] [PATCH] Upgrade to SeaBIOS v1.7.1

2012-08-31 Thread Kevin O'Connor
Log of SeaBIOS changes since 5a023065: Kevin O'Connor (1): Make iasl option check work with older versions of iasl. Paolo Bonzini (1): scsi: add AMD PCscsi driver Signed-off-by: Kevin O'Connor --- This release contains two patches since the last SeaBIOS pull into the QEMU repo. The first

Re: [Qemu-devel] [SeaBIOS] [ANNOUNCE] SeaBIOS 1.7.1

2012-08-31 Thread Fred .
Great to see a new release out! :) Now lets merge some new stuff! :D On Fri, Aug 31, 2012 at 7:31 PM, Kevin O'Connor wrote: > The 1.7.1 version of SeaBIOS has now been released. For more > information on the release, please see: > > http://seabios.org/Releases > > > New in this release: > > * I

Re: [Qemu-devel] [PATCH for-1.2] hw/armv7m_nvic: Correctly register GIC region when setting up NVIC

2012-08-31 Thread Peter Maydell
Hi Anthony; I realised somewhat belatedly that this bugfix should probably go into 1.2 if possible. Can we still squeeze it in or is it too late? Patchwork url: http://patchwork.ozlabs.org/patch/180315/ thanks -- PMM On 28 August 2012 00:41, Meador Inge wrote: > When setting up the NVIC memory

[Qemu-devel] [ANNOUNCE] SeaBIOS 1.7.1

2012-08-31 Thread Kevin O'Connor
The 1.7.1 version of SeaBIOS has now been released. For more information on the release, please see: http://seabios.org/Releases New in this release: * Initial support for booting from USB attached scsi (USB UAS) drives * USB EHCI 64bit controller support * USB MSC multi-LUN device support * S

Re: [Qemu-devel] [PATCH] Add ability to build without any targets enabled

2012-08-31 Thread Stefan Weil
Am 31.08.2012 19:15, schrieb Peter Maydell: On 31 August 2012 18:06, Daniel P. Berrange wrote: From: "Daniel P. Berrange" The qemu-img, qemu-nbd and qemu-io tools are quite useful in their own right. eg LXC can use qemu-img and qemu-nbd to support running of containers with qcow2 images. As su

Re: [Qemu-devel] Deprecating "cpudef" on QEMU 1.2

2012-08-31 Thread Anthony Liguori
Andreas Färber writes: > Am 31.08.2012 18:07, schrieb Eduardo Habkost: >> Anthony, I remeber we quickly discussed on #qemu about deprecting the >> support for "cpudef" config sections on QEMU 1.2. But as cpudef is not >> documented anywhere, we would simply document that on the 1.2 Release >> Not

Re: [Qemu-devel] [PATCH v2] hw: Add VMware's GETHZ command.

2012-08-31 Thread Jan Kiszka
On 2012-08-31 19:20, Don Slutz wrote: > This is known is linux as VMWARE_PORT_CMD_GETHZ. > > Signed-off-by: Don Slutz > --- > hw/vmport.c | 23 ++- > 1 files changed, 22 insertions(+), 1 deletions(-) > > diff --git a/hw/vmport.c b/hw/vmport.c > index a4f52ee..e856255 10064

[Qemu-devel] [PATCH] Don't require encryption password for 'qemu-img info' command

2012-08-31 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The encryption password is only required if I/O is going to be performed on a disk image. The 'qemu-img info' command merely reports metadata, so it should not ask for a decryption password Signed-off-by: Daniel P. Berrange --- qemu-img.c | 21 +++--

[Qemu-devel] [PATCH v2] hw: Add VMware's GETHZ command.

2012-08-31 Thread Don Slutz
This is known is linux as VMWARE_PORT_CMD_GETHZ. Signed-off-by: Don Slutz --- hw/vmport.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/hw/vmport.c b/hw/vmport.c index a4f52ee..e856255 100644 --- a/hw/vmport.c +++ b/hw/vmport.c @@ -31,8 +31,9 @@

Re: [Qemu-devel] [PATCH] Add ability to build without any targets enabled

2012-08-31 Thread Peter Maydell
On 31 August 2012 18:06, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The qemu-img, qemu-nbd and qemu-io tools are quite useful in their > own right. eg LXC can use qemu-img and qemu-nbd to support running > of containers with qcow2 images. As such it is reasonable to allow > buildi

Re: [Qemu-devel] [PATCH] hw: Add VMware's GETHZ command.

2012-08-31 Thread Jan Kiszka
On 2012-08-31 18:57, Don Slutz wrote: > On 08/31/12 12:22, Jan Kiszka wrote: >> On 2012-08-31 17:30, Don Slutz wrote: >>> This is known is linux as VMWARE_PORT_CMD_GETHZ. >>> >>> Signed-off-by: Don Slutz >>> --- >>> hw/vmport.c | 22 +- >>> 1 files changed, 21 insertions(+

[Qemu-devel] [PATCH] Add ability to build without any targets enabled

2012-08-31 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The qemu-img, qemu-nbd and qemu-io tools are quite useful in their own right. eg LXC can use qemu-img and qemu-nbd to support running of containers with qcow2 images. As such it is reasonable to allow building these tools, without enabling any QEMU targets. This change

Re: [Qemu-devel] [PATCH] x86: enforce DPL checking on task gate switches invoked through IDT

2012-08-31 Thread Peter Maydell
On 31 August 2012 17:54, Don Slutz wrote: > I think it makes sense to move the next 2 checks into the switch (no real > code flow change). I agree (for symmetry). If you do that then I think the combination of those two patches means that in the task gate case we do the !(e2 & DESC_P_MASK) check

Re: [Qemu-devel] [PATCH] hw: Add VMware's GETHZ command.

2012-08-31 Thread Don Slutz
On 08/31/12 12:22, Jan Kiszka wrote: On 2012-08-31 17:30, Don Slutz wrote: This is known is linux as VMWARE_PORT_CMD_GETHZ. Signed-off-by: Don Slutz --- hw/vmport.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/vmport.c b/hw/vmport.c index

Re: [Qemu-devel] [PATCH] x86: enforce DPL checking on task gate switches invoked through IDT

2012-08-31 Thread Don Slutz
On 08/17/12 11:30, Alex ZUEPKE wrote: Hi, x86 software emulation (non-KVM mode) does not check privilege levels on task gate switches ... so one can invoke a kernel's double fault handler from user space -- very bad. Expected behaviour (testcase works with any linux distribution + gcc): $ ca

[Qemu-devel] [Bug 1042654] Re: Floppy disks and network not working on NT 3.1 on Qemu 1.2 rc1

2012-08-31 Thread TC1988
nice :) but what about the network? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1042654 Title: Floppy disks and network not working on NT 3.1 on Qemu 1.2 rc1 Status in QEMU: New Bug descripti

Re: [Qemu-devel] Deprecating "cpudef" on QEMU 1.2

2012-08-31 Thread Andreas Färber
Am 31.08.2012 18:07, schrieb Eduardo Habkost: > Anthony, I remeber we quickly discussed on #qemu about deprecting the > support for "cpudef" config sections on QEMU 1.2. But as cpudef is not > documented anywhere, we would simply document that on the 1.2 Release > Notes. > > I am sending this just

Re: [Qemu-devel] [PATCH] hw: Add VMware's GETHZ command.

2012-08-31 Thread Jan Kiszka
On 2012-08-31 17:30, Don Slutz wrote: > This is known is linux as VMWARE_PORT_CMD_GETHZ. > > Signed-off-by: Don Slutz > --- > hw/vmport.c | 22 +- > 1 files changed, 21 insertions(+), 1 deletions(-) > > diff --git a/hw/vmport.c b/hw/vmport.c > index a4f52ee..37dbf91 100644

Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Kevin Wolf
Am 31.08.2012 17:41, schrieb Jason Baron: > On Fri, Aug 31, 2012 at 04:47:37PM +0200, Kevin Wolf wrote: >> Am 30.08.2012 20:00, schrieb Jason Baron: >>> Add support for ahci migration. This patch builds upon the patches posted >>> previously by Andreas Faerber: >>> >>> http://lists.gnu.org/archive/

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-08-31 Thread Andreas Färber
Hi, Am 31.08.2012 16:12, schrieb Alberto Garcia: > Ping We are currently in Hard Freeze, new devices will not get accepted before the release, and our review may focus on bug fixes. http://wiki.qemu.org/Planning/1.2 I remember having had a brief look through your patches and they looked pretty

[Qemu-devel] Deprecating "cpudef" on QEMU 1.2

2012-08-31 Thread Eduardo Habkost
Anthony, I remeber we quickly discussed on #qemu about deprecting the support for "cpudef" config sections on QEMU 1.2. But as cpudef is not documented anywhere, we would simply document that on the 1.2 Release Notes. I am sending this just to confirm: this is still the current plan, right? -- E

Re: [Qemu-devel] [PATCH v4] ivshmem: add 64bit option

2012-08-31 Thread Cam Macdonell
Can this patch be included in 1.2? Thanks, Cam On Thu, Aug 23, 2012 at 6:49 AM, Gerd Hoffmann wrote: > This patch adds a "use64" property which will make the ivshmem driver > register a 64bit memory bar when set, so you have something to play with > when testing 64bit pci bits. It also allows t

Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Andreas Färber
Am 30.08.2012 20:00, schrieb Jason Baron: > Add support for ahci migration. This patch builds upon the patches posted > previously by Andreas Faerber: > > http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01538.html > > (I hope I am giving Andreas proper credit for his work.) Not quite. :)

Re: [Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 06:35:13PM +0300, Michael S. Tsirkin wrote: > On Fri, Aug 31, 2012 at 10:45:52AM -0400, Jason Baron wrote: > > On Fri, Aug 31, 2012 at 11:42:27AM +0300, Michael S. Tsirkin wrote: > > > Some minor nits below. If you dont get to it I will tweak this patch > > > when I apply it

Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 04:47:37PM +0200, Kevin Wolf wrote: > Am 30.08.2012 20:00, schrieb Jason Baron: > > Add support for ahci migration. This patch builds upon the patches posted > > previously by Andreas Faerber: > > > > http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01538.html > > >

Re: [Qemu-devel] [PATCH 1/2] pcie: drop version_id field for live migration

2012-08-31 Thread Michael S. Tsirkin
On Fri, Aug 31, 2012 at 10:46:51AM -0400, Jason Baron wrote: > On Fri, Aug 31, 2012 at 11:44:54AM +0300, Michael S. Tsirkin wrote: > > On Thu, Aug 30, 2012 at 01:51:10PM -0400, Jason Baron wrote: > > > While testing q35 live migration, I found that the migration would abort > > > with > > > the fo

[Qemu-devel] [Bug 1042654] Re: Floppy disks and network not working on NT 3.1 on Qemu 1.2 rc1

2012-08-31 Thread Kevin Wolf
Found someone who had a copy of NT 3.1 handy and he bisected it to: commit 2fee00885a9ea4db69bbfc1ba8ccf95f2ae9aec6 Author: Pavel Hrdina Date: Fri Jun 22 12:33:55 2012 +0200 fdc: fix interrupt handling If you call the SENSE INTERRUPT STATUS command while there is no interrupt

Re: [Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-31 Thread Michael S. Tsirkin
On Fri, Aug 31, 2012 at 10:45:52AM -0400, Jason Baron wrote: > On Fri, Aug 31, 2012 at 11:42:27AM +0300, Michael S. Tsirkin wrote: > > Some minor nits below. If you dont get to it I will tweak this patch > > when I apply it early next week. > > > > On Thu, Aug 30, 2012 at 01:51:15PM -0400, Jason B

[Qemu-devel] [PATCH] hw: Add VMware's GETHZ command.

2012-08-31 Thread Don Slutz
This is known is linux as VMWARE_PORT_CMD_GETHZ. Signed-off-by: Don Slutz --- hw/vmport.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/vmport.c b/hw/vmport.c index a4f52ee..37dbf91 100644 --- a/hw/vmport.c +++ b/hw/vmport.c @@ -26,13 +26,15 @@

[Qemu-devel] [PATCH for-1.2 11/11] uas: move transfer kickoff

2012-08-31 Thread Gerd Hoffmann
Kick next scsi transfer from request release callback instead of command completion callback, otherwise we might get stuck in case scsi_req_unref() doesn't release the request instantly due to someone else holding a reference too. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-uas.c |3 +-- 1 f

[Qemu-devel] [PATCH for-1.2 02/11] usb: Halt ep queue en cancel pending packets on a packet error

2012-08-31 Thread Gerd Hoffmann
From: Hans de Goede For controllers which queue up more then 1 packet at a time, we must halt the ep queue, and inside the controller code cancel all pending packets on an error. There are multiple reasons for this: 1) Guests expect the controllers to halt ep queues on error, so that they get th

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-08-31 Thread Jeff Cody
On 08/31/2012 10:49 AM, Kevin Wolf wrote: > Am 31.08.2012 16:42, schrieb Jeff Cody: >> On 08/30/2012 06:15 PM, Eric Blake wrote: >>> On 08/30/2012 11:47 AM, Jeff Cody wrote: This is derived from the Supriya Kannery's reopen patches. This contains the raw-posix driver changes for the

[Qemu-devel] [PATCH for-1.2 09/11] ehci: handle TD deactivation of inflight packets

2012-08-31 Thread Gerd Hoffmann
Check the TDs of inflight packets, cancel packets in case the guest clears the active bit. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 38 +++--- 1 files changed, 23 insertions(+), 15 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c inde

[Qemu-devel] [PATCH for-1.2 06/11] ehci: Remove unnecessary ehci_flush_qh call

2012-08-31 Thread Gerd Hoffmann
From: Hans de Goede ehci_qh_do_overlay() already calls ehci_flush_qh() before it returns, calling it twice is useless. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/h

[Qemu-devel] [PATCH for-1.2 04/11] ehci: Fix NULL ptr deref when unplugging an USB dev with an iso stream active

2012-08-31 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index f43d690..a3aea6d 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1598,7 +1598,7 @@ static int e

[Qemu-devel] [PATCH for-1.2 05/11] ehci: Schedule async-bh when IAAD bit gets set

2012-08-31 Thread Gerd Hoffmann
From: Hans de Goede After the "ehci: Print a warning when a queue unexpectedly contains packets on cancel" commit. Under certain reproducable conditions I was getting the following message: "EHCI: Warning queue not empty on queue reset". After aprox. 8 hours of debugging I've finally found the c

[Qemu-devel] [PATCH for-1.2 07/11] ehci: simplify ehci_state_executing

2012-08-31 Thread Gerd Hoffmann
From: Hans de Goede ehci_state_executing does not need to check for p->usb_status == USB_RET_ASYNC or USB_RET_PROCERR, since ehci_execute_complete already does a similar check and will trigger an assert if either value is encountered. USB_RET_ASYNC should never be the packet status when execute_

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-08-31 Thread Kevin Wolf
Am 31.08.2012 16:42, schrieb Jeff Cody: > On 08/30/2012 06:15 PM, Eric Blake wrote: >> On 08/30/2012 11:47 AM, Jeff Cody wrote: >>> This is derived from the Supriya Kannery's reopen patches. >>> >>> This contains the raw-posix driver changes for the bdrv_reopen_* >>> functions. All changes are sta

[Qemu-devel] [PATCH for-1.2 03/11] usb: unique packet ids

2012-08-31 Thread Gerd Hoffmann
This patch adds IDs to usb packets. Those IDs are (a) supposed to be unique for the lifecycle of a packet (from packet setup until the packet is either completed or canceled) and (b) stable across migration. uhci, ohci, ehci and xhci use the guest physical address of the transfer descriptor for t

Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Kevin Wolf
Am 30.08.2012 20:00, schrieb Jason Baron: > Add support for ahci migration. This patch builds upon the patches posted > previously by Andreas Faerber: > > http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01538.html > > (I hope I am giving Andreas proper credit for his work.) > > I've test

Re: [Qemu-devel] [PATCH 1/2] pcie: drop version_id field for live migration

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 11:44:54AM +0300, Michael S. Tsirkin wrote: > On Thu, Aug 30, 2012 at 01:51:10PM -0400, Jason Baron wrote: > > While testing q35 live migration, I found that the migration would abort > > with > > the following error: "Unknown savevm section type 76". > > > > The error is

Re: [Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 11:42:27AM +0300, Michael S. Tsirkin wrote: > Some minor nits below. If you dont get to it I will tweak this patch > when I apply it early next week. > > On Thu, Aug 30, 2012 at 01:51:15PM -0400, Jason Baron wrote: > > The Advanced Error Interrupt Message Number (bits 31:27

[Qemu-devel] [PATCH for-1.2 08/11] ehci: add ehci_cancel_queue()

2012-08-31 Thread Gerd Hoffmann
Factor out function to cancel all packets of a queue. No behavior change. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index b6169ce..30e5e8f 100644

Re: [Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit'

2012-08-31 Thread Jeff Cody
On 08/30/2012 07:06 PM, Eric Blake wrote: > On 08/30/2012 11:47 AM, Jeff Cody wrote: >> The command for live block commit is added, which has the following >> arguments: >> >> device: the block device to perform the commit on (mandatory) >> base: the base image to commit into; optional (if not sp

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-08-31 Thread Jeff Cody
On 08/30/2012 06:15 PM, Eric Blake wrote: > On 08/30/2012 11:47 AM, Jeff Cody wrote: >> This is derived from the Supriya Kannery's reopen patches. >> >> This contains the raw-posix driver changes for the bdrv_reopen_* >> functions. All changes are staged into a temporary scratch buffer >> during t

Re: [Qemu-devel] [RFC v2 PATCH 4/6] qerror: new error for live block commit, QERR_TOP_NOT_FOUND

2012-08-31 Thread Jeff Cody
On 08/30/2012 06:55 PM, Eric Blake wrote: > On 08/30/2012 11:47 AM, Jeff Cody wrote: >> Signed-off-by: Jeff Cody >> --- >> qerror.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/qerror.h b/qerror.h >> index d0a76a4..7396184 100644 >> --- a/qerror.h >> +++ b/qerror.h >> @@ -219,6

Re: [Qemu-devel] [PATCH v8 0/7] convert sendkey to qapi

2012-08-31 Thread Luiz Capitulino
On Fri, 31 Aug 2012 10:56:19 +0800 Amos Kong wrote: > This series converted 'sendkey' command to qapi. The raw value > in hexadecimal format is not supported by 'send-key' of qmp. I've applied this to the qmp-next branch. Thanks Amos! > > Amos Kong (7): > fix doc of using raw values with se

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 12:12:22PM +0200, Kevin Wolf wrote: > Am 23.08.2012 23:09, schrieb Jason Baron: > > While testing q35, I found that windows 7 (specifically, windows 7 ultimate > > with sp1 x64), wouldn't install because it can't find the cdrom or disk > > drive. > > The failure message is:

[Qemu-devel] [PATCH for-1.2 01/11] fix info qtree indention

2012-08-31 Thread Gerd Hoffmann
Without the patch bus properties are are not in line with the other properties: [ ... ] dev: fw_cfg, id "" ctl_iobase = 0x510 data_iobase = 0x511 irq 0 mmio /0002 mmio /0001 [ ... ] With the patch applied everythi

[Qemu-devel] [PULL for-1.2 00/11] usb patch queue

2012-08-31 Thread Gerd Hoffmann
Hi, This patch series brings a some last-minute usb bugfixes for 1.2. The new usb packet queuing code added in the 1.2 devel cycle fails to handle some corner cases correctly and some regressions sneaked in. Most of this is in the ehci emulation. Also included is a 'info qtree' fix which is s

[Qemu-devel] [PATCH for-1.2 10/11] ehci: Fix interrupt endpoints no longer working

2012-08-31 Thread Gerd Hoffmann
From: Hans de Goede One of the recent changes (likely the addition of queuing support) has broken interrupt endpoints, this patch fixes this. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-ehci

[Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-08-31 Thread Alberto Garcia
Ping Patches here: http://patchwork.ozlabs.org/patch/179657/ http://patchwork.ozlabs.org/patch/179658/ Description: https://lists.gnu.org/archive/html/qemu-devel/2012-08/msg04173.html Berto

Re: [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G

2012-08-31 Thread Don Slutz
On 08/31/12 08:30, Fred Oliveira wrote: The check using INT_MAX (2147483647) is wrong in this case. Signed-off-by: Fred Oliveira --- target-i386/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 423e009..cbc172e 100644

[Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G

2012-08-31 Thread Fred Oliveira
The check using INT_MAX (2147483647) is wrong in this case. Signed-off-by: Fred Oliveira --- target-i386/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 423e009..cbc172e 100644 --- a/target-i386/cpu.c +++ b/target-i386/c

Re: [Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-08-31 Thread Luiz Capitulino
On Fri, 31 Aug 2012 14:18:55 +0200 Kevin Wolf wrote: > Am 31.08.2012 08:26, schrieb Markus Armbruster: > > Luiz Capitulino writes: > > > >> On Wed, 15 Aug 2012 09:41:43 +0200 > >> Pavel Hrdina wrote: > >> > >>> Signed-off-by: Pavel Hrdina > >>> --- > >>> block.c| 25 +

[Qemu-devel] qemu 1.2 segfault on shutdown (ioh->deleted == false, io->fd == -1)

2012-08-31 Thread Richard W.M. Jones
I'm tracking this bug here: https://bugzilla.redhat.com/show_bug.cgi?id=853408 Does anyone recognize this segfault on shutdown when using either a console or a virtio-serial char device? It's only caught in Fedora because we compile with 'fortify source' so the attempt to modify a negative offse

Re: [Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-08-31 Thread Luiz Capitulino
On Fri, 31 Aug 2012 08:26:38 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 15 Aug 2012 09:41:43 +0200 > > Pavel Hrdina wrote: > > > >> Signed-off-by: Pavel Hrdina > >> --- > >> block.c| 25 + > >> block.h| 3 ++

Re: [Qemu-devel] VHDX support

2012-08-31 Thread Kevin Wolf
Am 30.08.2012 09:36, schrieb Alex Bligh: > Is anyone currently working on VHDX (as opposed to VHD) support, as used > by the most recent version of Hyper-V? If not, would you be interested > in patches? I'm not aware of anyone working on it yet. Patches are welcome, of course. Kevin

Re: [Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-08-31 Thread Kevin Wolf
Am 31.08.2012 08:26, schrieb Markus Armbruster: > Luiz Capitulino writes: > >> On Wed, 15 Aug 2012 09:41:43 +0200 >> Pavel Hrdina wrote: >> >>> Signed-off-by: Pavel Hrdina >>> --- >>> block.c| 25 + >>> block.h| 3 ++- >>> block/qcow2-sn

Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Alexandre DERUMIER
works fine here with debian squeeze + debian wheezy guests. - Mail original - De: "Jason Baron" À: kw...@redhat.com, afaer...@suse.de, ag...@suse.de Cc: qemu-devel@nongnu.org, yamah...@valinux.co.jp, "alex williamson" , aligu...@us.ibm.com, "jan kiszka" Envoyé: Jeudi 30 Août 2012 20:

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Kevin Wolf
Am 23.08.2012 23:09, schrieb Jason Baron: > While testing q35, I found that windows 7 (specifically, windows 7 ultimate > with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. > The failure message is: 'A required cd/dvd device driver is missing. If you > have a driver flop

Re: [Qemu-devel] [PATCH 1/2] pcie: drop version_id field for live migration

2012-08-31 Thread Juan Quintela
Jason Baron wrote: > While testing q35 live migration, I found that the migration would abort with > the following error: "Unknown savevm section type 76". Before we start, migration of PCI is ugly due to backwards compatibility. > The error is due to this check failing in 'vmstate_load_state()'

Re: [Qemu-devel] [PATCH 1/2] pcie: drop version_id field for live migration

2012-08-31 Thread Michael S. Tsirkin
On Thu, Aug 30, 2012 at 01:51:10PM -0400, Jason Baron wrote: > While testing q35 live migration, I found that the migration would abort with > the following error: "Unknown savevm section type 76". > > The error is due to this check failing in 'vmstate_load_state()': > > while(field->name) {

Re: [Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-31 Thread Michael S. Tsirkin
Some minor nits below. If you dont get to it I will tweak this patch when I apply it early next week. On Thu, Aug 30, 2012 at 01:51:15PM -0400, Jason Baron wrote: > The Advanced Error Interrupt Message Number (bits 31:27 of the Root > Error Status Register) is updated when the number of msi messa

Re: [Qemu-devel] [PATCH 5/6] Fix enumeration typo error

2012-08-31 Thread Stefan Hajnoczi
On Thu, Aug 23, 2012 at 01:14:25PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > qapi-schema-guest.json |2 +- > qapi-schema.json |4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits

Re: [Qemu-devel] [PATCH v2] Fix buffer run out in eepro100.

2012-08-31 Thread Bo Yang
>>> Stefan Hajnoczi 08/30/12 7:42 PM >>> On Thu, Aug 30, 2012 at 9:38 AM, Bo Yang wrote: > On 08/30/2012 04:04 PM, Stefan Hajnoczi wrote: >> On Wed, Aug 29, 2012 at 09:17:43PM +0200, Stefan Weil wrote: >>> Am 29.08.2012 13:26, schrieb Bo Yang: This is reported by QA. When installing os wit

[Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-08-31 Thread Don Slutz
This is primarily done so that the guest will think it is running under vmware when hypervisor=vmware is specified as a property of a cpu. Also allow this to work in accel=tcg mode. The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and hyper_extra_b can be used to further adjust wha

[Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-08-31 Thread Don Slutz
This is primarily done so that the guest will think it is running under vmware when hypervisor=vmware is specified as a property of a cpu. Also allow this to work in accel=tcg mode. The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and hyper_extra_b can be used to further adjust wha

Re: [Qemu-devel] [Spice-devel] [PATCH] Add new client_present and client capabilities fields to QXLRom

2012-08-31 Thread Gerd Hoffmann
Hi, >> Hmm, when the server is able to translate a8 ops into non-a8 ops using >> server-side rendering, then there is no need to notify the guest about >> the client capabilities. > > To be clear, this ability doesn't exist at the moment, and it would be a > significant chunk of work to add it.

Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command

2012-08-31 Thread Markus Armbruster
Eric Blake writes: > On 08/22/2012 11:14 PM, Lei Li wrote: >> Signed-off-by: Lei Li > > Subject line uses '_', but the QMP command uses '-' [1] > >> --- >> hmp-commands.hx | 16 >> hmp.c| 15 +++ >> hmp.h|1 + >> qapi-schema.json |

Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command

2012-08-31 Thread Markus Armbruster
Lei Li writes: > Signed-off-by: Lei Li > --- > hmp-commands.hx | 16 > hmp.c| 15 +++ > hmp.h|1 + > qapi-schema.json | 28 > qemu-char.c | 36 > qmp-commands

Re: [Qemu-devel] [PATCH 6/6] Expose MemCharDriver via command line

2012-08-31 Thread Markus Armbruster
Lei Li writes: > Signed-off-by: Lei Li > --- > qemu-char.c | 24 > qemu-config.c |3 +++ > qemu-options.hx | 10 ++ > 3 files changed, 37 insertions(+), 0 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index ff6651b..36f4ecc 100644 > ---