Re: [Qemu-devel] boot device order has no effect for virtio-scsi devices

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 02:03, ching ha scritto: i add boot order and the virtual machine still boot from hard disk instead of cd-rom disk type='file' device='disk' driver name='qemu' type='raw' cache='unsafe' io='native'/ source file='/Linux.raw_image'/ target dev='sda'

[Qemu-devel] [PATCH (stable, 1.2)] add missing pty_chr_update_read_handler() in qemu_chr_open_pty()

2012-09-04 Thread Michael Tokarev
Currently pty code does not register i/o handler properly, so that one have to ping the pty in order for qemu to work, or else it is sitting in main loop doing nothing and using 100% CPU. qemu -nographic -kernel /boot/vmlinuz-$(uname -r) -append console=ttyS0 -serial pty shows this nicely: the

Re: [Qemu-devel] [PATCH 1/6] libqblock APIs

2012-09-04 Thread Wenchao Xia
Thank u for the careful reviewing of my codes, I will write down the typo errors you mentioned on a note. On 09/03/2012 03:18 AM, Wenchao Xia wrote: This patch contains the major APIs in the library. Important APIs: 1 QBroker. These structure was used to retrieve errors, every thread

Re: [Qemu-devel] [PATCH 1/6] libqblock APIs

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 05:15, Wenchao Xia ha scritto: Can you use GError instead? read through the GError doc, GError is defined as following: struct GError { GQuark domain; gint code; gchar *message; }; I am worried about the message member, I guess program would be

Re: [Qemu-devel] apparently missing yet another notify_event()

2012-09-04 Thread Paolo Bonzini
Il 03/09/2012 20:13, Michael Tokarev ha scritto: There's a new bugreport filed against qemu-kvm in debian, which looks very similar to what we already had before -- https://bugs.launchpad.net/qemu/+bug/1021649 which were fixed by adding qemu_notify_event() call. Later on these

Re: [Qemu-devel] apparently missing yet another notify_event()

2012-09-04 Thread Michael Tokarev
On 04.09.2012 10:53, Paolo Bonzini wrote: Il 03/09/2012 20:13, Michael Tokarev ha scritto: [] qemu -nographic -kernel /boot/vmlinuz-$(uname -r) -append console=ttyS0 -serial pty This will hang with 100% CPU usage until something is sent to the pty. Enter key is enough. [] Could it be

Re: [Qemu-devel] [PATCH 1/6] libqblock APIs

2012-09-04 Thread Wenchao Xia
于 2012-9-3 22:05, Paolo Bonzini 写道: Il 03/09/2012 15:56, Eric Blake ha scritto: Exactly how does the *pnum argument work? This interface looks like it isn't fully thought out yet. Either I want to know if a chunk of sectors is allocated (I supply start and length of sectors to check),

Re: [Qemu-devel] [PATCH for 1.2] qemu-timer: properly arm alarm timer for timers set by device initialization

2012-09-04 Thread Michael Tokarev
On 03.09.2012 19:34, Paolo Bonzini wrote: QEMU will hang when fed the following command-line qemu-system-mips -kernel vmlinux-2.6.32-5-4kc-malta -append console=ttyS0 -nographic -net none The -net none is important otherwise it seems some events are generated causing the things to

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Wenchao Xia
于 2012-9-3 22:20, Eric Blake 写道: On 09/03/2012 03:18 AM, Wenchao Xia wrote: This patch contains public type and defines used in APIs. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-types.h | 228 +++ 1 files changed,

Re: [Qemu-devel] [PATCH 3/6] libqblock error handling

2012-09-04 Thread Wenchao Xia
于 2012-9-3 22:22, Eric Blake 写道: On 09/03/2012 03:18 AM, Wenchao Xia wrote: This patch contains error handling APIs. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-error.c | 44 +++ libqblock/libqblock-error.h |

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Wenchao Xia
于 2012-9-3 23:18, Paolo Bonzini 写道: Il 03/09/2012 16:28, Eric Blake ha scritto: +/* this file contains helper function used internally. */ +#define SECTOR_SIZE (512) Hard-coding this feels wrong, in this day and age of disks with 4096 sectors. Why isn't this a per-image property? In this

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Wenchao Xia
On Mon, Sep 3, 2012 at 9:18 AM, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch contains public type and defines used in APIs. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-types.h | 228 +++ 1 files

Re: [Qemu-devel] [PATCH V7 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Jan Kiszka
On 2012-09-03 12:03, Julien Grall wrote: This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/acpi_piix4.c | 151

Re: [Qemu-devel] [PATCH] slirp: Fix error reported by static code analysis and remove wrong type casts

2012-09-04 Thread Jan Kiszka
On 2012-09-03 23:08, Peter Maydell wrote: On 3 September 2012 21:34, Stefan Weil s...@weilnetz.de wrote: Report from smatch: slirp/tcp_subr.c:127 tcp_respond(17) error: we previously assumed 'tp' could be null (see line 124) Fix this by checking 'tp' before reading its elements. The type

Re: [Qemu-devel] [PATCH 1/6] libqblock APIs

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 09:05, Wenchao Xia ha scritto: That said, QEMU's internal bdrv_is_allocated function does have one not entirely appealing property: the block at start + *pnum might have the same state as the block at start + *pnum - 1, even if *pnum length. We may want to work around this in

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 09:10, Wenchao Xia ha scritto: + +/** + * QBlockInfoImageStatic: information about the block image. + * + * @loc: location info. + * @fmt_type: format type. + * @virt_size: virtual size in bytes. + * @backing_loc: backing file location, its type is QB_PROT_NONE if not

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 09:19, Wenchao Xia ha scritto: +struct QBlockOption_prot_file { QBlockOptionProtFile +char *filename; 'const' There is a problem, this member would be used in information retrieving, so it will be set to a pointer to a string allocated at runtime, and later be

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 09:15, Wenchao Xia ha scritto: +/* this file contains helper function used internally. */ +#define SECTOR_SIZE (512) Hard-coding this feels wrong, in this day and age of disks with 4096 sectors. Why isn't this a per-image property? In this day and age of disks with 4096

Re: [Qemu-devel] [PATCH] slirp: Fix error reported by static code analysis and remove wrong type casts

2012-09-04 Thread Peter Maydell
On 4 September 2012 08:27, Jan Kiszka jan.kis...@web.de wrote: Indeed, this is a XXX Should never fail case - according to the code that checks tp at the call site. But as no one seriously understands slirp details, we are better safe than sorry. Actually it looks like you can get here with

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Avi Kivity
On 09/03/2012 07:33 PM, Paolo Bonzini wrote: Il 03/09/2012 18:30, Avi Kivity ha scritto: The values above are what every user of the PIC cascaded on our targets must program to use them. So We will find them in the state once any relevant guest code was able to run (e.g. the BIOS).

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-04 Thread Avi Kivity
On 09/03/2012 10:32 PM, Blue Swirl wrote: On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity a...@redhat.com wrote: On 08/29/2012 11:27 AM, Markus Armbruster wrote: I don't see a point in making contributors avoid non-problems that might conceivably become trivial problems some day. Especially when

Re: [Qemu-devel] [PULL for usb-next]: Move usb-redir over to using more usb-core infra + misc ehci fixes

2012-09-04 Thread Gerd Hoffmann
Hi, I've made a tree with my current usb-redir work for upstream here: including some more ehci fixes is here, can you please add the patches from there to your usb-next tree? In general it is better to work against master not usb-next as usb-next is a moving target. A little hard in this

Re: [Qemu-devel] [PATCH 1/6] libqblock APIs

2012-09-04 Thread Wenchao Xia
于 2012-9-4 14:50, Paolo Bonzini 写道: Il 04/09/2012 05:15, Wenchao Xia ha scritto: Can you use GError instead? read through the GError doc, GError is defined as following: struct GError { GQuark domain; gint code; gchar *message; }; I am worried about the

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 10:16, Avi Kivity ha scritto: But the point of subsections is to succeed migration in the common case, assuming there is more than one case that doesn't affect guest operation. According to the patch, if icw3 == 4 !(eclr 4), then behaviour will change. With the standard

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Avi Kivity
On 09/04/2012 12:15 PM, Paolo Bonzini wrote: Il 04/09/2012 10:16, Avi Kivity ha scritto: But the point of subsections is to succeed migration in the common case, assuming there is more than one case that doesn't affect guest operation. According to the patch, if icw3 == 4 !(eclr 4), then

Re: [Qemu-devel] [PULL for usb-next]: Move usb-redir over to using more usb-core infra + misc ehci fixes

2012-09-04 Thread Hans de Goede
Hi, On 09/04/2012 10:36 AM, Gerd Hoffmann wrote: Hi, I've made a tree with my current usb-redir work for upstream here: including some more ehci fixes is here, can you please add the patches from there to your usb-next tree? In general it is better to work against master not usb-next as

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread BALATON Zoltan
On Tue, 4 Sep 2012, Avi Kivity wrote: On 09/04/2012 12:15 PM, Paolo Bonzini wrote: Il 04/09/2012 10:16, Avi Kivity ha scritto: But the point of subsections is to succeed migration in the common case, assuming there is more than one case that doesn't affect guest operation. According to the

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Avi Kivity
On 09/04/2012 12:29 PM, BALATON Zoltan wrote: On Tue, 4 Sep 2012, Avi Kivity wrote: On 09/04/2012 12:15 PM, Paolo Bonzini wrote: Il 04/09/2012 10:16, Avi Kivity ha scritto: But the point of subsections is to succeed migration in the common case, assuming there is more than one case that

[Qemu-devel] [PATCH 0/3] fdc: Fix FD_SR0_SEEK flag

2012-09-04 Thread Kevin Wolf
Pavel, does this make sense to you? It seems to fix the NT 3.1 floppy driver. Kevin Wolf (3): fdc: Remove status0 parameter from fdctrl_set_fifo() fdc: Fix false FD_SR0_SEEK fdc-test: Check READ ID hw/fdc.c | 38 ++ tests/fdc-test.c | 68

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Jan Kiszka
On 2012-09-04 11:37, Avi Kivity wrote: On 09/04/2012 12:29 PM, BALATON Zoltan wrote: On Tue, 4 Sep 2012, Avi Kivity wrote: On 09/04/2012 12:15 PM, Paolo Bonzini wrote: Il 04/09/2012 10:16, Avi Kivity ha scritto: But the point of subsections is to succeed migration in the common case,

[Qemu-devel] [PATCH 2/3] fdc: Fix false FD_SR0_SEEK

2012-09-04 Thread Kevin Wolf
fdctrl_start/stop_transfer() used to set FD_SR0_SEEK no matter if there actually was a seek or not. This is obviously wrong. fdctrl_start_transfer() has this information because it performs the seek itself. fdctrl_stop_transfer() gets status0 passed and callers already take care of setting

Re: [Qemu-devel] [PULL for usb-next]: Move usb-redir over to using more usb-core infra + misc ehci fixes

2012-09-04 Thread Gerd Hoffmann
Hi, Fulfilling your request would mean wrapping 90% of all function prototypes in hw/usb/redirect.c with #ifdef magic. Which I find rather ugly. If you prefer the ifdef's over the hard version requirement, I can do the ifdef-s, but my preference is to just put the hard version dependency

[Qemu-devel] [PATCH 1/3] fdc: Remove status0 parameter from fdctrl_set_fifo()

2012-09-04 Thread Kevin Wolf
It decided whether an interrupt is triggered. Only one caller made use of this functionality, so move the code there. In this one caller, the interrupt must actually be triggered unconditionally, like it was before commit 2fee0088. For example, a successful read without an implied seek can result

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 11:51, Jan Kiszka ha scritto: I don't mean to say we shouldn't care about them, but there are likely to be a lot more users doing backwards migration than users running those guests, let alone migrating them (forwards or backwards). The pragmatic choice is clear. BTW,

[Qemu-devel] [PATCH 3/3] fdc-test: Check READ ID

2012-09-04 Thread Kevin Wolf
ST0 shouldn't include 0x20 (FD_SR0_SEEK) after READ ID. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/fdc-test.c | 66 ++ 1 files changed, 66 insertions(+), 0 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index

Re: [Qemu-devel] [PATCH-v2 qemu] qxl: Add set_client_capabilities() interface to QXLInterface

2012-09-04 Thread Gerd Hoffmann
Hi, static void qxl_enter_vga_mode(PCIQXLDevice *d) @@ -1292,7 +1315,7 @@ static void qxl_set_mode(PCIQXLDevice *d, int modenr, int loadvm) d-mode = QXL_MODE_COMPAT; d-cmdflags = QXL_COMMAND_FLAG_COMPAT; -#ifdef QXL_COMMAND_FLAG_COMPAT_16BPP /* new in spice 0.6.1 */ +#if

Re: [Qemu-devel] [PATCH for 1.2] qemu-timer: properly arm alarm timer for timers set by device initialization

2012-09-04 Thread Aurelien Jarno
On Mon, Sep 03, 2012 at 05:34:32PM +0200, Paolo Bonzini wrote: QEMU will hang when fed the following command-line qemu-system-mips -kernel vmlinux-2.6.32-5-4kc-malta -append console=ttyS0 -nographic -net none The -net none is important otherwise it seems some events are generated

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Avi Kivity
On 09/04/2012 01:06 PM, Paolo Bonzini wrote: Il 04/09/2012 11:51, Jan Kiszka ha scritto: I don't mean to say we shouldn't care about them, but there are likely to be a lot more users doing backwards migration than users running those guests, let alone migrating them (forwards or

Re: [Qemu-devel] boot device order has no effect for virtio-scsi devices

2012-09-04 Thread ching
On 09/04/2012 02:23 PM, Paolo Bonzini wrote: Il 04/09/2012 02:03, ching ha scritto: i add boot order and the virtual machine still boot from hard disk instead of cd-rom disk type='file' device='disk' driver name='qemu' type='raw' cache='unsafe' io='native'/ source

Re: [Qemu-devel] [PATCH] ide: Fix error messages from static code analysis (no real error)

2012-09-04 Thread Kevin Wolf
Am 03.09.2012 22:13, schrieb Stefan Weil: Report from smatch: hw/ide/core.c:1472 ide_exec_cmd(423) error: buffer overflow 'smart_attributes' 8 = 29 hw/ide/core.c:1474 ide_exec_cmd(425) error: buffer overflow 'smart_attributes' 8 = 29 hw/ide/core.c:1475 ide_exec_cmd(426) error: buffer

Re: [Qemu-devel] [PATCH V7 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Julien Grall
On 09/04/2012 08:24 AM, Jan Kiszka wrote: On 2012-09-03 12:03, Julien Grall wrote: This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Gralljulien.gr...@citrix.com --- hw/acpi_piix4.c | 151

Re: [Qemu-devel] [PATCH 1/6] libqblock APIs

2012-09-04 Thread Eric Blake
On 09/04/2012 12:42 AM, Wenchao Xia wrote: +/** + * libqblock_init: Initialize the library + */ +void libqblock_init(void); Is this function safe to call more than once? Even tighter, is it safe to call this function simultaneously from multiple threads? No, it should be only called

Re: [Qemu-devel] [PATCH V7 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Jan Kiszka
On 2012-09-04 13:27, Julien Grall wrote: On 09/04/2012 08:24 AM, Jan Kiszka wrote: On 2012-09-03 12:03, Julien Grall wrote: This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Eric Blake
On 09/04/2012 01:15 AM, Wenchao Xia wrote: 于 2012-9-3 23:18, Paolo Bonzini 写道: Il 03/09/2012 16:28, Eric Blake ha scritto: +/* this file contains helper function used internally. */ +#define SECTOR_SIZE (512) Hard-coding this feels wrong, in this day and age of disks with 4096 sectors. Why

Re: [Qemu-devel] [PATCH V7 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Jan Kiszka
On 2012-09-04 13:37, Jan Kiszka wrote: On 2012-09-04 13:27, Julien Grall wrote: On 09/04/2012 08:24 AM, Jan Kiszka wrote: On 2012-09-03 12:03, Julien Grall wrote: This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener.

Re: [Qemu-devel] [Bug 893956] Re: qemu-img bug with dynamic vhd

2012-09-04 Thread Stefan Hajnoczi
On Mon, Sep 3, 2012 at 10:41 AM, franxico 893...@bugs.launchpad.net wrote: Hi, I'm having the same problem. I'm using qemu-img 1.0, running from a Ubuntu Server 12.04 x64 on a SW RAID, ext4. The .VHD has 29GB and was made using disk2vhd. Here is the command and the results: sudo kvm-img

Re: [Qemu-devel] boot device order has no effect for virtio-scsi devices

2012-09-04 Thread Eric Blake
On 09/04/2012 04:53 AM, ching wrote: On 09/04/2012 02:23 PM, Paolo Bonzini wrote: Il 04/09/2012 02:03, ching ha scritto: i add boot order and the virtual machine still boot from hard disk instead of cd-rom disk type='file' device='disk' driver name='qemu' type='raw' cache='unsafe'

Re: [Qemu-devel] [PATCH 1/3] vmware_vga: Cleanup and remove duplicated info from local state

2012-09-04 Thread BALATON Zoltan
Ping! http://patchwork.ozlabs.org/patch/179449/ On Thu, 23 Aug 2012, BALATON Zoltan wrote: Removed info from vmsvga_state that is available from elsewhere and thus was duplicated here unnecessarily. Also includes some coding style fixes suggested by checkpatch.pl. Signed-off-by: BALATON Zoltan

Re: [Qemu-devel] [PATCH V6 2/2] qemu-img: Add json output option to the info command.

2012-09-04 Thread Kevin Wolf
Am 27.08.2012 09:15, schrieb Benoît Canet: This option --output=[human|json] make qemu-img info output on human or JSON representation at the choice of the user. example: { snapshots: [ { vm-clock-nsec: 637102488, name: vm-20120821145509,

[Qemu-devel] [ANNOUNCE] QEMU 1.2.0-rc3 release

2012-09-04 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the third and final release candidate for the QEMU 1.2 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.2.0-rc3.tar.bz2 You can

[Qemu-devel] VM Communications inner a network bridge

2012-09-04 Thread GaoYi
Hi all, When 2 VMs are started on the same network bridge, will the TCP/IP packets between them still go through the router (actually these 2 VMs share the same physical network card)? If so, is it possible to just pass the packets inner the network card? Best, Yi

Re: [Qemu-devel] KVM call agenda for Tuesday, September 4th

2012-09-04 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. As the memory region protection topic has been re-called, there are no topic for this week. Call gets cancelled. Have a nice week, Juan.

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-09-04 Thread Gerd Hoffmann
On 08/30/12 14:49, Alejandro Martinez Ruiz wrote: Some xHC drivers (most notably on Windows and BSD systems) read the first capability registers using 1 and 2 bytes accesses, since this is how they are defined in section 5.3 of the xHCI specs. Enabling these kind of read accesses allows

Re: [Qemu-devel] [PATCH 1/6] libqblock APIs

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 13:35, Eric Blake ha scritto: No, it should be only called once, any other thread should not call it again, will document it. About the multiple thread user case, qemu block layer can't support that now, will fix that later. What a shame. That makes libraries much harder to

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 13:38, Eric Blake ha scritto: Since qemu does not support it now, yes, you can ignore it for now. But please make sure that you aren't hard-coding it into the API - that is, make sure that the API can someday grow to support larger sector sizes with minimal impact to library

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Kevin Wolf
Am 04.09.2012 15:49, schrieb Paolo Bonzini: Il 04/09/2012 13:38, Eric Blake ha scritto: Since qemu does not support it now, yes, you can ignore it for now. But please make sure that you aren't hard-coding it into the API - that is, make sure that the API can someday grow to support larger

[Qemu-devel] [PATCH V8 5/8] hw/cirrus_vga.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_*. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/cirrus_vga.c | 50 ++ 1 files changed, 30 insertions(+), 20 deletions(-)

[Qemu-devel] [PATCH V8 3/8] smb: replace_register_ioport*

2012-09-04 Thread Julien Grall
This patch fix smb_ioport_* to be compliant with read/write memory callback. Moreover it replaces all register_ioport* which use theses functions by the new Memory API. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/acpi_piix4.c | 18 -- hw/pm_smbus.c |7

[Qemu-devel] [PATCH V8 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/acpi_piix4.c | 145 +++ 1 files changed, 113 insertions(+), 32

Re: [Qemu-devel] [PATCH V8 0/8] memory: unify ioport registration

2012-09-04 Thread Jan Kiszka
On 2012-09-04 09:28, Julien Grall wrote: This is the eighth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions doesn't allow to use Memory Listener on it. Modifications between V1 and V2: -

[Qemu-devel] [PATCH V8 8/8] hw/dma.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* be the new memory API functions. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/dma.c | 108 + 1 files changed, 72

Re: [Qemu-devel] xbzrle migration cache size advise for high memory changes workload ?

2012-09-04 Thread Orit Wasserman
On 09/03/2012 04:10 PM, Alexandre DERUMIER wrote: Hi, I'm trying to implement xbzrle live migration, But i'm having non finishing migration with high memory changes in guest. (simply playing a youtube video in the guest). At the end of the migration, the remaining memory to transfert goes

[Qemu-devel] [PATCH V8 0/8] memory: unify ioport registration

2012-09-04 Thread Julien Grall
This is the eighth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions doesn't allow to use Memory Listener on it. Modifications between V1 and V2: - Remove the use of get_system_io. Instead of use isa

Re: [Qemu-devel] [PATCH] block/curl: Fix wrong free statement

2012-09-04 Thread Kevin Wolf
Am 01.09.2012 11:06, schrieb Stefan Weil: Report from smatch: block/curl.c:546 curl_close(21) info: redundant null check on s-url calling free() The check was redundant, and free was also wrong because the memory was allocated using g_strdup. Signed-off-by: Stefan Weil s...@weilnetz.de

[Qemu-devel] [PATCH 2/2] Remove #ifdef QXL_COMMAND_FLAG_COMPAT_16BPP

2012-09-04 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com We require spice = 0.8 now, so this flag is always present. Signed-off-by: Soren Sandmann s...@redhat.com --- hw/qxl.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 572daa9..57e6536 100644 ---

[Qemu-devel] [PATCH 1/2] qxl: Add set_client_capabilities() interface to QXLInterface

2012-09-04 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com This new interface lets spice server inform the guest whether (a) a client is connected (b) what capabilities the client has There is a fixed number (464) of bits reserved for capabilities, and when the capabilities bits change, the

[Qemu-devel] [PATCH V8 6/8] hw/serial.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* with a MemoryRegion. It permits to use the new Memory stuff like listener. For more flexibility, the IO address space is passed as an argument. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/mips_mipssim.c |3 ++- hw/pc.h |2

Re: [Qemu-devel] [PATCH] target-arm: Fix potential buffer overflow

2012-09-04 Thread Peter Maydell
On 4 September 2012 06:35, Stefan Weil s...@weilnetz.de wrote: Report from smatch: target-arm/helper.c:651 arm946_prbs_read(6) error: buffer overflow 'env-cp15.c6_region' 8 = 8 target-arm/helper.c:661 arm946_prbs_write(6) error: buffer overflow 'env-cp15.c6_region' 8 = 8 c7_region is an

[Qemu-devel] [PATCH V8 7/8] hw/pc.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_* or isa_register_portio_list. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/pc.c | 58 +++--- 1 files changed, 43

Re: [Qemu-devel] [PATCH] Don't require encryption password for 'qemu-img info' command

2012-09-04 Thread Kevin Wolf
Am 31.08.2012 19:30, schrieb Eric Blake: On 08/31/2012 10:26 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The encryption password is only required if I/O is going to be performed on a disk image. The 'qemu-img info' command merely reports metadata, so it should

[Qemu-devel] [PATCH V8 2/8] hw/apm.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* by a MemorySection. It permits to use the new Memory stuff like listener. Moreover, the PCI is added as an argument for apm_init, so we can register IO inside the pci IO address space. Signed-off-by: Julien Grall julien.gr...@citrix.com ---

[Qemu-devel] [PATCH V8 1/8] isa: add isa_address_space_io

2012-09-04 Thread Julien Grall
This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/isa-bus.c |9 + hw/isa.h |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH] vdi: Fix warning from clang

2012-09-04 Thread Kevin Wolf
Am 17.08.2012 15:23, schrieb Stefan Weil: ccc-analyzer reports these warnings: block/vdi.c:704:13: warning: Dereference of null pointer bmap[i] = VDI_UNALLOCATED; ^ block/vdi.c:702:13: warning: Dereference of null pointer bmap[i] = i; ^

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 16:29, Maciej W. Rozycki ha scritto: So first of all, the *output* of the 8259A is always edge triggered, regardless of whether it's the master or one of the slaves (only one slave is used in the PC/AT architecture, but up to eight are supported; the PC/XT had none). I

Re: [Qemu-devel] [PATCH 1/2] qxl: Add set_client_capabilities() interface to QXLInterface

2012-09-04 Thread Gerd Hoffmann
Hi, +static void interface_set_client_capabilities(QXLInstance *sin, + uint8_t client_present, + uint8_t caps[58]) Please don't use tabs for intention in qemu patches. Fixed it up this time, added both

Re: [Qemu-devel] [PATCH 1/1] block: fix block tray status

2012-09-04 Thread Kevin Wolf
Am 09.08.2012 12:44, schrieb Pavel Hrdina: The tray status should change also if you eject empty block device. Signed-off-by: Pavel Hrdina phrd...@redhat.com Thanks, applied to block-next. Kevin

Re: [Qemu-devel] [PATCH 01/21] target-s390x: fix style

2012-09-04 Thread Richard Henderson
On 2012-09-03 12:10, Blue Swirl wrote: I missed that one. He's rewriting translate.c, while I'm mostly touching op_helper.c. I'd expect it would be simpler for Richard to rebase on my series, because they only change helper calls but don't otherwise touch code. His series rearranges the code

[Qemu-devel] [Bug 893956] Re: qemu-img bug with dynamic vhd

2012-09-04 Thread Serge Hallyn
Though that commit and the comments were about 127G images. HIs is only 27G. Also, 'qemu-img info' is also showing the error, which shows that this is not being done on vpc_create(). So I think this is a case of qemu-img actually failing to properly parse the FHD file. -- You received this

[Qemu-devel] [RFC v2] s390: virtual channel subsystem and new virtio transport.

2012-09-04 Thread Cornelia Huck
Hi, I have incorporated the feedback I received to my first RFC for virtio-ccw (http://marc.info/?l=kvmm=134435141402140w=2) and will post the updates shortly. Patches will again be sorted into kernel host and guest, qemu, and virtio spec. Feedback is still welcome. Cornelia

[Qemu-devel] [PATCH v2 3/5] s390: Add new channel I/O based virtio transport.

2012-09-04 Thread Cornelia Huck
Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that uses this virtio-ccw transport and make it the default machine for s390. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- Changes v1-v2: - update to virtio-ccw

[Qemu-devel] [PATCH v2 3/4] s390/kvm: Add a channel I/O based virtio transport driver.

2012-09-04 Thread Cornelia Huck
Add a driver for kvm guests that matches virtual ccw devices provided by the host as virtio bridge devices. These virtio-ccw devices use a special set of channel commands in order to perform virtio functions. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- Changes v1-v2: - adapt to

[Qemu-devel] [PATCH v2 2/5] s390: Virtual channel subsystem support.

2012-09-04 Thread Cornelia Huck
Provide a mechanism for qemu to provide fully virtual subchannels to the guest. In the KVM case, this relies on the kernel's css support. The !KVM case is not yet supported. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- Changes v1 - v2: - coding style - re-organization of hardware

[Qemu-devel] [PATCH v2 4/7] s390: Move css limits from drivers/s390/cio/ to include/asm/.

2012-09-04 Thread Cornelia Huck
There's no need to keep __MAX_SUBCHANNEL and __MAX_SSID private to the common I/O layer when __MAX_CSSID is usable by everybody. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- arch/s390/include/asm/cio.h | 2 ++ drivers/s390/cio/css.h | 3 --- 2 files changed, 2 insertions(+), 3

[Qemu-devel] [PATCH v2] virtio-spec: Add virtio-ccw spec.

2012-09-04 Thread Cornelia Huck
Add specifications for the new s390 specific virtio-ccw transport. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- Changes v1-v2: - support more than 32 feature bits - allow to allocate less than requested queue size - allow to transfer alignment --- virtio-spec.lyx | 534

[Qemu-devel] [RFC PATCH v2 0/5] qemu: s390: virtual css and virtio-ccw.

2012-09-04 Thread Cornelia Huck
Hi, here's the second version of virtual channel I/O and the new virtio-ccw transport. Changes to the first version include coding style fixes, changes in the organization of objects (not quite finished yet), adaptions to changes in the kernel interface and implementation of the improved

[Qemu-devel] [RFC PATCH v2] Update virtio spec for virtio-ccw.

2012-09-04 Thread Cornelia Huck
Hi, this is the second revision of the virtio-ccw spec. The interface has been improved to support more than 32 feature bits as well as allocating less that the requested queue size and specifying alignment. (Note: I folded the changes with git into my initial spec; I hope LyX can handle this

[Qemu-devel] [PATCH v2 1/7] s390/kvm: Support for I/O interrupts.

2012-09-04 Thread Cornelia Huck
Add support for handling I/O interrupts (standard, subchannel-related ones and rudimentary adapter interrupts). The subchannel-identifying parameters are encoded into the interrupt type. I/O interrupts are floating, so they can't be injected on a specific vcpu. Signed-off-by: Cornelia Huck

[Qemu-devel] [PATCH v2 3/7] s390/kvm: In-kernel handling of I/O instructions.

2012-09-04 Thread Cornelia Huck
Explicitely catch all channel I/O related instructions intercepts in the kernel and set condition code 3 for them. This paves the way for properly handling these instructions later on. Note: This is not architecture compliant (the previous code wasn't either) since setting cc 3 is not the

[Qemu-devel] [PATCH v2 5/5] [HACK] Handle multiple virtio aliases.

2012-09-04 Thread Cornelia Huck
This patch enables using both virtio-xxx-s390 and virtio-xxx-ccw by making the alias lookup code verify that a driver is actually registered. (Only included in order to allow testing of virtio-ccw; should be replaced by cleaning up the virtio bus model.) Not-signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Jan Kiszka
On 2012-09-04 16:42, Paolo Bonzini wrote: Il 04/09/2012 16:29, Maciej W. Rozycki ha scritto: So first of all, the *output* of the 8259A is always edge triggered, regardless of whether it's the master or one of the slaves (only one slave is used in the PC/AT architecture, but up to eight are

[Qemu-devel] [PATCH v2 1/4] s390/kvm: Handle hosts not supporting s390-virtio.

2012-09-04 Thread Cornelia Huck
Running under a kvm host does not necessarily imply the presence of a page mapped above the main memory with the virtio information; however, the code includes a hard coded access to that page. Instead, check for the presence of the page and exit gracefully before we hit an addressing exception

[Qemu-devel] [RFC PATCH v2 0/7] s390: virtual css host support.

2012-09-04 Thread Cornelia Huck
Hi, here's the second revision of the virtual channel subsystem support for s390. I changed the representation of the channel subsystem, introducing channel subsystem images, which brings it closer to the actual implementation. A new ioctl for adding a new channel subsystem image has also been

[Qemu-devel] [PATCH v2 6/7] s390/kvm: Base infrastructure for enabling capabilities.

2012-09-04 Thread Cornelia Huck
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- Documentation/virtual/kvm/api.txt | 2 +- arch/s390/kvm/kvm-s390.c | 26 ++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/virtual/kvm/api.txt

[Qemu-devel] [PATCH v2 4/4] s390/kvm: Split out early console code.

2012-09-04 Thread Cornelia Huck
This code is transport agnostic and can be used by both the legacy virtio code and virtio_ccw. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/s390/kvm/Makefile | 2 +- drivers/s390/kvm/early_printk.c | 42 +

[Qemu-devel] [RFC PATCH v2 0/4] s390: virtio-ccw guest kernel support.

2012-09-04 Thread Cornelia Huck
Hi, here's the second revision of the guest support for virtio-ccw. The first patch has gotten several changes and now handles checking for s390-virtio support much more nicely. The third patch has been adapted to the changed virtio-ccw interface. Cornelia Huck (4): s390/kvm: Handle hosts

[Qemu-devel] [PATCH v2 5/7] s390: Make some css-related structures usable by non-cio code.

2012-09-04 Thread Cornelia Huck
kvm will need to use some css-related structures (pmcw, schib, orb), so let's move the definitions from drivers/s390/cio/ to include/asm/. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- arch/s390/include/asm/orb.h | 69 +++

[Qemu-devel] [PATCH v2 2/7] s390/kvm: Add support for machine checks.

2012-09-04 Thread Cornelia Huck
Add support for injecting machine checks (only repressible conditions for now). This is a bit more involved than I/O interrupts, for these reasons: - Machine checks come in both floating and cpu varieties. - We don't have a bit for machine checks enabling, but have to use a roundabout approach

Re: [Qemu-devel] [PATCH V8 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Jan Kiszka
On 2012-09-04 09:28, Julien Grall wrote: This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/acpi_piix4.c | 145

[Qemu-devel] [PATCH v2 1/5] Update headers for upcoming s390 changes.

2012-09-04 Thread Cornelia Huck
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- Changes v1-v2: - update to latest kvm interface changes --- linux-headers/asm-generic/kvm_para.h | 5 +++ linux-headers/asm-x86/kvm.h | 1 + linux-headers/linux/kvm.h| 80 ++-- 3

Re: [Qemu-devel] [PATCH V8 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Julien Grall
On 09/04/2012 04:15 PM, Jan Kiszka wrote: On 2012-09-04 09:28, Julien Grall wrote: This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Gralljulien.gr...@citrix.com --- hw/acpi_piix4.c | 145

  1   2   >