[Qemu-devel] [Bug 1077838] Please test proposed package

2012-11-22 Thread Adam Conrad
Hello Robert, or anyone else affected, Accepted qemu-kvm into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/qemu-kvm/1.0+noroms- 0ubuntu14.5 in a few hours, and then in the -proposed repository. Please help us by testing this new package.

[Qemu-devel] [Bug 1077838] Please test proposed package

2012-11-22 Thread Adam Conrad
Hello Robert, or anyone else affected, Accepted qemu-kvm into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/qemu-kvm/1.2.0 +noroms-0ubuntu2.12.10.1 in a few hours, and then in the -proposed repository. Please help us by testing this new

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-22 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 03:27:48PM +0100, lementec fabien wrote: usage - PCIEFW devices are instanciated using the following QEMU options: -device \ pciefw,\ laddr=local_addr,\ lport=local_port,\ raddr=remote_addr,\ rport=remote_port Take a look at qemu_socket.h:socket_parse().

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-22 Thread Stefan Priebe - Profihost AG
Am 21.11.2012 23:32, schrieb Peter Maydell: On 21 November 2012 17:03, Stefan Weil s...@weilnetz.de wrote: Why do you use int64_t instead of off_t? If the value is related to file sizes, off_t would be a good choice. Looking at the librbd API (which is what the size and ret values come from),

Re: [Qemu-devel] [PATCH] inet_parse: fix ,to= parsing

2012-11-22 Thread Markus Armbruster
Stefano Stabellini stefano.stabell...@eu.citrix.com writes: Fix inet_parse to parse the ,to= command line option correctly. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com diff --git a/qemu-sockets.c b/qemu-sockets.c index cfed9c5..f8740dd 100644 --- a/qemu-sockets.c

Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X

2012-11-22 Thread Peter Maydell
On 22 November 2012 00:04, Andreas Färber andreas.faer...@web.de wrote: Am 22.11.2012 00:19, schrieb Peter Maydell: On 17 November 2012 13:10, Peter Maydell peter.mayd...@linaro.org wrote: On 17 November 2012 13:02, Andreas Färber andreas.faer...@web.de wrote: Am 16.11.2012 17:37, schrieb

Re: [Qemu-devel] [PATCH V3 for-1.3] Build system fix distclean error for pixman

2012-11-22 Thread Peter Maydell
On 22 November 2012 02:07, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Currently Makefile test if pixman have configure log, but the script directly return error if that file do not exist. This patch fix it. v2: print out the command. v3: resend as a stand alone fix patch, add reviewer.

Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X

2012-11-22 Thread Brad Smith
On Thu, Nov 22, 2012 at 08:33:17AM +, Peter Maydell wrote: On 22 November 2012 00:04, Andreas F??rber andreas.faer...@web.de wrote: Am 22.11.2012 00:19, schrieb Peter Maydell: On 17 November 2012 13:10, Peter Maydell peter.mayd...@linaro.org wrote: On 17 November 2012 13:02, Andreas

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-22 Thread Peter Maydell
On 22 November 2012 08:23, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 21.11.2012 23:32, schrieb Peter Maydell: Looking at the librbd API (which is what the size and ret values come from), it uses size_t and ssize_t for these. So I think probably ssize_t is the right type for

Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X

2012-11-22 Thread Peter Maydell
On 22 November 2012 08:38, Brad Smith b...@comstyle.com wrote: On Thu, Nov 22, 2012 at 08:33:17AM +, Peter Maydell wrote: On 22 November 2012 00:04, Andreas F??rber andreas.faer...@web.de wrote: But then again there's the question of why not doing it on Linux as well now that we seem to

Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X

2012-11-22 Thread Brad Smith
On Thu, Nov 22, 2012 at 08:41:19AM +, Peter Maydell wrote: On 22 November 2012 08:38, Brad Smith b...@comstyle.com wrote: On Thu, Nov 22, 2012 at 08:33:17AM +, Peter Maydell wrote: On 22 November 2012 00:04, Andreas F??rber andreas.faer...@web.de wrote: But then again there's the

Re: [Qemu-devel] [PATCH for 1.3 V3] Build system fix distclean error for pixman

2012-11-22 Thread Wenchao Xia
On 22 November 2012 02:07, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Currently Makefile test if pixman have configure log, but the script directly return error if that file do not exist. This patch fix it. v2: print out the command. v3: resend as a stand alone fix patch, add reviewer.

Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers

2012-11-22 Thread Paolo Bonzini
Il 21/11/2012 20:11, Stefan Weil ha scritto: Debian cross development is full of difficulties. Passing an extra compiler option like -mthread is only one of these difficulties. I updated http://wiki.qemu.org/Hosts/W32, so anybody who really wants to run cross compilations on Debian can get

[Qemu-devel] [Bug 156085] Re: Could not open /proc/bus/usb/devices

2012-11-22 Thread Bug Watch Updater
** Changed in: usbview (Debian) Status: New = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/156085 Title: Could not open /proc/bus/usb/devices Status in QEMU: Fix Released

[Qemu-devel] [PATCH] overflow of int ret: use ssize_t for ret

2012-11-22 Thread Stefan Priebe
When acb-cmd is WRITE or DISCARD block/rbd stores rcb-size into acb-ret Look here: if (acb-cmd == RBD_AIO_WRITE || acb-cmd == RBD_AIO_DISCARD) { if (r 0) { acb-ret = r; acb-error = 1; } else if (!acb-error) { acb-ret = rcb-size;

Re: [Qemu-devel] [PATCH 2/2] Documentation: Update image format information

2012-11-22 Thread Kevin Wolf
Am 22.11.2012 08:37, schrieb Stefan Hajnoczi: On Wed, Nov 21, 2012 at 04:22:07PM +0100, Kevin Wolf wrote: Am 21.11.2012 16:14, schrieb Stefan Hajnoczi: On Wed, Nov 21, 2012 at 02:23:57PM +0100, Kevin Wolf wrote: @item qed -Image format with support for backing files and compact image files

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-22 Thread Stefan Priebe - Profihost AG
Hello, i send a new patch using ssize_t. (Subject [PATCH] overflow of int ret: use ssize_t for ret) Stefan Am 22.11.2012 09:40, schrieb Peter Maydell: On 22 November 2012 08:23, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 21.11.2012 23:32, schrieb Peter Maydell: Looking

Re: [Qemu-devel] [PATCH v3] Add compare subcommand for qemu-img

2012-11-22 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 04:50:14AM -0500, Miroslav Rezanina wrote: diff --git a/qemu-img.c b/qemu-img.c index e29e01b..6294b11 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -101,7 +101,12 @@ static void help(void) '-a' applies a snapshot (revert disk to saved state)\n

Re: [Qemu-devel] [PATCH] Fix missing TRACE exception

2012-11-22 Thread Julio Guerra
2012/10/19 Julio Guerra gu...@julio.in: This patch fixes bug 1031698 : https://bugs.launchpad.net/qemu/+bug/1031698 If we look at the (truncated) translation of the conditional branch instruction in the test submitted in the bug post, the call to the exception helper is missing in the

Re: [Qemu-devel] [Bug 1081416] [NEW] Qemu 1.2.0 crashes when using tcp serial console and GRUB boots

2012-11-22 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 03:14:28AM -, Jérôme Poulin wrote: When booting OpenWRT Attitude Adjustement ( http://downloads.openwrt.org/attitude_adjustment/12.09-beta2/x86/generic/openwrt-x86-generic-combined-ext4.img.gz ) with this command line: qemu-system-x86_64 -serial tcp:127.0.0.1:

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Paolo Bonzini
Il 21/11/2012 19:32, Stefan Hajnoczi ha scritto: The iov_get_ptr() data returns a pointer to contiguous data within a vector. This allows the caller to manipulate data inside the vector without copying in/out using iov_from_buf()/iov_to_buf() when we know that data is contiguous within an

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-22 Thread Markus Armbruster
malc av1...@comtv.ru writes: On Tue, 20 Nov 2012, Paolo Bonzini wrote: Il 20/11/2012 10:59, malc ha scritto: [..snip..] FSF says And what it says about CC0 or whatnot is utterly irrelevent. Surely their lawyers are better at copyright law than malc. Surely they are masters of

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 10:34:13AM +0100, Paolo Bonzini wrote: Il 21/11/2012 19:32, Stefan Hajnoczi ha scritto: The iov_get_ptr() data returns a pointer to contiguous data within a vector. This allows the caller to manipulate data inside the vector without copying in/out using

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 10:45, Michael S. Tsirkin ha scritto: All this looks suspiciously like premature optimization to me. Do we have data to show avoiding header copy is a win? The code is a little simpler, because we know the footer is 1 byte only. Paolo The caller would have to handle the case

[Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-22 Thread Stefan Priebe
This one fixes a race which qemu had also in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. To archieve this it introduces a new status flag which uses -EINPROGRESS. Signed-off-by: Stefan Priebe

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-22 Thread Stefan Priebe - Profihost AG
Hello, i've send a new patch which hopefully cares about all your comments. [PATCH] rbd block driver fix race between aio completition and aio cancel Greets Stefan Am 21.11.2012 10:07, schrieb Stefan Hajnoczi: On Mon, Nov 19, 2012 at 09:39:45PM +0100, Stefan Priebe wrote: @@ -376,9 +376,7

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-22 Thread lementec fabien
Hi, Thanks for the feedback, I will modify the previous document to include the changes you mentionned. I reply here too. 2012/11/22 Stefan Hajnoczi stefa...@gmail.com: On Wed, Nov 21, 2012 at 03:27:48PM +0100, lementec fabien wrote: usage - PCIEFW devices are instanciated using the

Re: [Qemu-devel] [PATCH for 1.3 v2] block: Fix regression for MinGW (assertion caused by short string)

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 07:25:48AM +0100, Stefan Weil wrote: The local string tmp_filename is passed to function get_tmp_filename which expects a string with minimum size MAX_PATH for w32 hosts. MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short. Commit

Re: [Qemu-devel] [PATCH V3] Build system fix distclean error for pixman

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 10:07:46AM +0800, Wenchao Xia wrote: Currently Makefile test if pixman have configure log, but the script directly return error if that file do not exist. This patch fix it. v2: print out the command. v3: resend as a stand alone fix patch, add reviewer.

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 09:19, Stefan Hajnoczi ha scritto: usage - PCIEFW devices are instanciated using the following QEMU options: -device \ pciefw,\ laddr=local_addr,\ lport=local_port,\ raddr=remote_addr,\ rport=remote_port Take a look at qemu_socket.h:socket_parse(). It

Re: [Qemu-devel] Interrupt controller updates

2012-11-22 Thread Paolo Bonzini
Il 21/11/2012 02:07, Benjamin Herrenschmidt ha scritto: David (CC) want to make some progress with our in-kernel PIC. From memory, one of the outcomes of the BOF was that we need to move the existing enable in-kernel PIC from generic KVM init to machine init in order to be able to add an

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 10:52:27AM +0100, Paolo Bonzini wrote: Il 22/11/2012 10:45, Michael S. Tsirkin ha scritto: All this looks suspiciously like premature optimization to me. Do we have data to show avoiding header copy is a win? The code is a little simpler, because we know the footer

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-22 Thread Peter Maydell
If you can provide a simple straightforward reproduce case that would be useful. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with qemu-arm-static Status in QEMU: New

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 11:38, Michael S. Tsirkin ha scritto: The code is a little simpler, because we know the footer is 1 byte only. Yes but the APIs don't make sense in the generic case of 1 byte: users will have to code up two paths for when the buffer they want to access gets scattered across.

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 11:54:49AM +0100, Paolo Bonzini wrote: Il 22/11/2012 11:38, Michael S. Tsirkin ha scritto: The code is a little simpler, because we know the footer is 1 byte only. Yes but the APIs don't make sense in the generic case of 1 byte: users will have to code up two

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 10:01:00AM +0100, Dietmar Maurer wrote: +==Disadvantages== + +* we need to define a new archive format + +Note: Most existing archive formats are optimized to store small files +including file attributes. We simply do not need that for VM archives. Did you look at

Re: [Qemu-devel] [PATCH v4 00/14] Add Q35 base support

2012-11-22 Thread Gerd Hoffmann
On 11/14/12 21:53, Jason Baron wrote: These patches are intened to give us a base set of patches for Q35 upon which to build. The major change in this series is to add the memory controller hub, or 'mch' as proper member of the q35 host structure. This change refactors the Fails to build with

Re: [Qemu-devel] [PATCH 2/5] add basic backup support to block driver

2012-11-22 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 10:01:01AM +0100, Dietmar Maurer wrote: Two comments from skimming the code, not a full review. +/* #define DEBUG_BACKUP */ + +#ifdef DEBUG_BACKUP +#define DPRINTF(fmt, ...) \ +do { printf(backup: fmt, ## __VA_ARGS__); } while (0) +#else +#define DPRINTF(fmt,

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-22 Thread lementec fabien
Hi, I modified the protocol so that new message types can be added easily. It is necessary for control related messages, such as the hello one (I called it init). A type field has been added to the header. I did not include a is_reply (or is_request) field, and prefered having 2 distinct message

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-22 Thread Alexander Graf
On 22.11.2012, at 08:23, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 22, 2012 at 01:27:18PM +1100, David Gibson wrote: On Wed, Nov 21, 2012 at 05:27:37PM +0200, Michael S. Tsirkin wrote: On Wed, Nov 21, 2012 at 02:27:08PM +0100, Alexander Graf wrote: On 11/21/2012 02:21 PM, David

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
Did you look at the VMDK Stream-Optimized Compressed subformat? http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf? src=vmdk It is a stream of compressed grains (data). They are out-of-order and each grain comes with the virtual disk lba where the data should be visible to

[Qemu-devel] FYI: KVM Forum community team photo

2012-11-22 Thread Daniel P. Berrange
At the LinuxCon / KVM Forum last week, a bunch of QEMU/KVM community members were rounded up to pose for a team photo. Thanks to Jeff Cody who was the one with the camera. I've put the photo up here along with, what I hope is a correct, list of names against faces...

Re: [Qemu-devel] [PATCH 2/5] add basic backup support to block driver

2012-11-22 Thread Dietmar Maurer
Is there a 1:1 relationship between BackupInfo and BackupBlockJob? Then it would be nicer to move BlockupInfo fields into BackupBlockJob (which is empty right now No, a backup create several block jobs - one for each blockdev you want to backup. Those jobs run in parallel.

Re: [Qemu-devel] FYI: KVM Forum community team photo

2012-11-22 Thread Zhi Yong Wu
On Thu, Nov 22, 2012 at 6:40 PM, Daniel P. Berrange berra...@redhat.com wrote: At the LinuxCon / KVM Forum last week, a bunch of QEMU/KVM community members were rounded up to pose for a team photo. Thanks to Jeff Cody who was the one with the camera. I've put the photo up here along with, what

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-22 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 12:27:49PM +0100, Alexander Graf wrote: On 22.11.2012, at 08:23, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 22, 2012 at 01:27:18PM +1100, David Gibson wrote: On Wed, Nov 21, 2012 at 05:27:37PM +0200, Michael S. Tsirkin wrote: On Wed, Nov 21, 2012 at

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
Did you look at the VMDK Stream-Optimized Compressed subformat? http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf? src=vmdk Max file size 2TB?

Re: [Qemu-devel] [PATCH] ivshmem: use irqfd to interrupt among VMs

2012-11-22 Thread Jan Kiszka
On 2012-11-22 03:48, liu ping fan wrote: On Wed, Nov 21, 2012 at 8:43 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-11-21 07:02, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Using irqfd, so we can avoid switch between kernel and user when VMs interrupts each

Re: [Qemu-devel] FYI: KVM Forum community team photo

2012-11-22 Thread Daniel P. Berrange
On Thu, Nov 22, 2012 at 07:33:03PM +0800, Zhi Yong Wu wrote: On Thu, Nov 22, 2012 at 6:40 PM, Daniel P. Berrange berra...@redhat.com wrote: At the LinuxCon / KVM Forum last week, a bunch of QEMU/KVM community members were rounded up to pose for a team photo. Thanks to Jeff Cody who was the

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 10:34:13AM +0100, Paolo Bonzini wrote: Il 21/11/2012 19:32, Stefan Hajnoczi ha scritto: The iov_get_ptr() data returns a pointer to contiguous data within a vector. This allows the caller to manipulate data inside the vector without copying in/out using

Re: [Qemu-devel] [PATCH 2/2] Documentation: Update image format information

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 10:08:06AM +0100, Kevin Wolf wrote: Am 22.11.2012 08:37, schrieb Stefan Hajnoczi: On Wed, Nov 21, 2012 at 04:22:07PM +0100, Kevin Wolf wrote: Am 21.11.2012 16:14, schrieb Stefan Hajnoczi: On Wed, Nov 21, 2012 at 02:23:57PM +0100, Kevin Wolf wrote: @item qed

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
It is a stream of compressed grains (data). They are out-of-order and each grain comes with the virtual disk lba where the data should be visible to the guest. The stream also contains grain tables and grain directories. This metadata makes random read access to the file possible once you

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-22 Thread Markus Armbruster
Christian Borntraeger borntrae...@de.ibm.com writes: There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therefore, this patch introduces a new field default_block_type per QEMUMachine struct. The prior use_scsi field

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
Did you look at the VMDK Stream-Optimized Compressed subformat? http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf? src=vmdk And is that covered by any patents?

Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers

2012-11-22 Thread Jan Kiszka
On 2012-11-21 20:11, Stefan Weil wrote: Am 21.11.2012 15:38, schrieb Paolo Bonzini: Il 21/11/2012 15:33, malc ha scritto: Leaking leader is a bit bad, but it looks ok for 1.3. Hmm. A TLS destructor is apparently not available. Is there some on thread termination callback mechanism on Windows?

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-22 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 03:00:25PM +0800, Asias He wrote: On 11/21/2012 02:44 PM, Stefan Hajnoczi wrote: On Wed, Nov 21, 2012 at 7:42 AM, Asias He as...@redhat.com wrote: On 11/21/2012 01:39 PM, Asias He wrote: On 11/20/2012 08:25 PM, Stefan Hajnoczi wrote: On Tue, Nov 20, 2012 at 1:21

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 12:58, Stefan Hajnoczi ha scritto: Then we can pass the iovec[] array straight to the Linux AIO functions. Since I knew the inhdr is only 1 byte I decided against doing something like dynamically allocating/freeing a QEMUIOVector which could handle spanning iovecs. Long-term

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-22 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 01:22:22PM +0800, Asias He wrote: On 11/20/2012 08:21 PM, Stefan Hajnoczi wrote: On Tue, Nov 20, 2012 at 10:02 AM, Asias He as...@redhat.com wrote: Hello Stefan, On 11/15/2012 11:18 PM, Stefan Hajnoczi wrote: This series adds the -device

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 12:58:23PM +0100, Stefan Hajnoczi wrote: On Thu, Nov 22, 2012 at 10:34:13AM +0100, Paolo Bonzini wrote: Il 21/11/2012 19:32, Stefan Hajnoczi ha scritto: The iov_get_ptr() data returns a pointer to contiguous data within a vector. This allows the caller to

Re: [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument

2012-11-22 Thread Luiz Capitulino
On Wed, 21 Nov 2012 13:12:53 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2012-11-20 16:14, Markus Armbruster wrote: Cc'ing Marcelo Jan to speed up patch application. Bruce Rogers brog...@suse.com writes: The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and

Re: [Qemu-devel] [PATCH 03/14] pixman: windup in configure makefiles

2012-11-22 Thread Stefano Stabellini
I have just noticed that we haven't actually written anywhere what's the oldest version of pixman we support. Do you know which one it is? On Wed, 17 Oct 2012, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |9 + configure | 38

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 11:21:58AM +0100, Paolo Bonzini wrote: Il 22/11/2012 09:19, Stefan Hajnoczi ha scritto: usage - PCIEFW devices are instanciated using the following QEMU options: -device \ pciefw,\ laddr=local_addr,\ lport=local_port,\ raddr=remote_addr,\

[Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Dietmar Maurer
I use the following qmp commands (file cmds.txt) for testing: - cmds.txt start {execute:qmp_capabilities, arguments:{}} {execute:migrate, arguments:{ uri:exec:cat /dev/null}} {execute:query-migrate, arguments:{}} - cmds.txt end and the following command line to

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 11:26:21AM +, Dietmar Maurer wrote: Did you look at the VMDK Stream-Optimized Compressed subformat? http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf? src=vmdk It is a stream of compressed grains (data). They are out-of-order and each

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
-Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Donnerstag, 22. November 2012 13:45 To: Dietmar Maurer Cc: qemu-devel@nongnu.org; kw...@redhat.com Subject: Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1) On Thu, Nov 22, 2012 at

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-22 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 03:30:34PM +0100, Christian Borntraeger wrote: There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therefore, this patch introduces a new field default_block_type per QEMUMachine struct. The prior

Re: [Qemu-devel] [PATCH 03/14] pixman: windup in configure makefiles

2012-11-22 Thread Gerd Hoffmann
On 11/22/12 13:34, Stefano Stabellini wrote: I have just noticed that we haven't actually written anywhere what's the oldest version of pixman we support. Do you know which one it is? 0.18.4 is known good. cheers, Gerd

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-22 Thread Christian Borntraeger
On 22/11/12 13:02, Markus Armbruster wrote: Thanks for the review, Stefan already applied the patch, though. Is there anything that you really want to have a followup patch besides this one? There's just one caller that passes IF_DEFAULT. We could change it to pass machine-block_default_type

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Luiz Capitulino
On Thu, 22 Nov 2012 12:41:31 + Dietmar Maurer diet...@proxmox.com wrote: I use the following qmp commands (file cmds.txt) for testing: - cmds.txt start {execute:qmp_capabilities, arguments:{}} {execute:migrate, arguments:{ uri:exec:cat /dev/null}}

Re: [Qemu-devel] [PATCH v2 39/39] raw-win32: implement native asynchronous I/O

2012-11-22 Thread Jan Kiszka
On 2012-11-21 14:38, Jan Kiszka wrote: On 2012-11-21 14:33, Paolo Bonzini wrote: Il 21/11/2012 14:27, Jan Kiszka ha scritto: Are there any patches flying around that are supposed to resolve this? No. Is this with aio=native or aio=threads? aio=default - whatever that is on win32. That's

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-22 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Christian Borntraeger borntrae...@de.ibm.com writes: There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therefore, this patch introduces a new field default_block_type per

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Dietmar Maurer
The interesting thing is that it works perfectly without --enable-kvm. Can you please try the following patch? https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00174.html I am unable to apply that patch? patching file vl.c Hunk #1 FAILED at 3551. Hunk #2 succeeded at 3729 with

[Qemu-devel] [PATCH for-1.3] usb: tag usb host adapters as not hotpluggable.

2012-11-22 Thread Gerd Hoffmann
Hotplugging them simply doesn't work, so tag them accordingly to avoid users trying and then crashing qemu. For xhci there is nothing fundamental which prevents hotplug from working, we'll only need a exit() function which cleans up everything properly. That isn't for 1.3 though. For

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-11-22 Thread Christian Borntraeger
On 21/11/12 17:03, Paolo Bonzini wrote: Il 21/11/2012 10:15, Kevin Wolf ha scritto: +if ((bs-open_flags BDRV_O_NOCACHE)) { +bs-file-buffer_alignment = align; +} Any reason to restrict this to BDRV_O_NOCACHE? There have been patches to change the BDRV_O_NOCACHE flag from the

[Qemu-devel] drive_add 0 if=scsi crashes

2012-11-22 Thread Markus Armbruster
Watch this: (qemu) drive_add 0 if=scsi Segmentation fault (core dumped) Broken in commit 0d936928 qdev: Convert busses to QEMU Object Model. Before: (qemu) drive_add 0 if=scsi Device is not a SCSI adapter

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-22 Thread Markus Armbruster
Christian Borntraeger borntrae...@de.ibm.com writes: On 22/11/12 13:02, Markus Armbruster wrote: Thanks for the review, Stefan already applied the patch, though. Is there anything that you really want to have a followup patch besides this one? Really want is too strong, but improving the

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI - Bad ram pointer

2012-11-22 Thread Peter Lieven
On 19.11.2012 18:20, Stefan Hajnoczi wrote: On Thu, Nov 8, 2012 at 4:26 PM, Peter Lieven p...@dlhnet.de wrote: Has anyone any other idea what the cause could be or where to start? Hi Peter, I suggested posting the source tree you are building. Since you have applied patches yourself no one

[Qemu-devel] [PATCH] Clean up pci_drive_hot_add()'s use of BlockInterfaceType

2012-11-22 Thread Markus Armbruster
pci_drive_hot_add() parameter type has the wrong type: int instead of BlockInterfaceType. It's actually redundant, so we can just drop it. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/device-hotplug.c | 11 --- hw/pci-hotplug.c| 7 +++ sysemu.h| 3 +--

Re: [Qemu-devel] [PATCH] Clean up pci_drive_hot_add()'s use of BlockInterfaceType

2012-11-22 Thread Alexander Graf
On 22.11.2012, at 15:16, Markus Armbruster wrote: pci_drive_hot_add() parameter type has the wrong type: int instead of BlockInterfaceType. It's actually redundant, so we can just drop it. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/device-hotplug.c | 11 ---

[Qemu-devel] tap devices not receiving packets from a bridge

2012-11-22 Thread Peter Lieven
Hi, is anyone aware of a problem with the linux network bridge that in very rare circumstances stops a bridge from sending pakets to a tap device? My problem occurs in conjunction with vanilla qemu-kvm-1.2.0 and Ubuntu Kernel 3.2.0-34.53 which is based on Linux 3.2.33. I was not yet able to

[Qemu-devel] [RFC PATCH v2 0/3] Virtio-refactoring.

2012-11-22 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com Hi, I made the changes you suggest in the last RFC. There are still two issues with the command line : * When I use ./qemu* -device virtio-blk -device virtio-pci It is said that no virtio-bus are present. * The virtio-blk is

Re: [Qemu-devel] [PATCH] Clean up pci_drive_hot_add()'s use of BlockInterfaceType

2012-11-22 Thread Markus Armbruster
Alexander Graf ag...@suse.de writes: On 22.11.2012, at 15:16, Markus Armbruster wrote: pci_drive_hot_add() parameter type has the wrong type: int instead of BlockInterfaceType. It's actually redundant, so we can just drop it. Signed-off-by: Markus Armbruster arm...@redhat.com ---

[Qemu-devel] [RFC PATCH v2 3/3] virtio-blk : add the virtio-blk device.

2012-11-22 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This patch just add the virtio-blk device which can connect on a Virtio-Bus. The initialization fail if no free VirtioBus are present. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- hw/virtio-blk.c | 82

Re: [Qemu-devel] [PATCH] Reorder alarm timer setup again

2012-11-22 Thread Luiz Capitulino
On Thu, 01 Nov 2012 17:25:24 +0100 Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com ac4119c023 moved the alarm timer initialization to an earlier point but failed to consider that it depends on qemu_init_main_loop. Instead of moving the wrong things before

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Luiz Capitulino
On Thu, 22 Nov 2012 13:44:24 + Dietmar Maurer diet...@proxmox.com wrote: The interesting thing is that it works perfectly without --enable-kvm. Can you please try the following patch? https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00174.html I am unable to apply

Re: [Qemu-devel] [RFC PATCH v2 0/3] Virtio-refactoring.

2012-11-22 Thread Peter Maydell
On 22 November 2012 14:50, fred.kon...@greensocs.com wrote: There are still two issues with the command line : * When I use ./qemu* -device virtio-blk -device virtio-pci It is said that no virtio-bus are present. Does it work if you create the devices in the other order? *

[Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-22 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This patch create a new VirtioBus, which can be added to Virtio transports like virtio-pci, virtio-mmio,... One VirtIODevice can be connected to this device, like virtio-blk in the 3rd patch. The VirtioBus shares through a VirtioBusInfo structure

Re: [Qemu-devel] [RFC PATCH v2 0/3] Virtio-refactoring.

2012-11-22 Thread KONRAD Frédéric
Did you get the full patchset ? The 01 and 02 seems to be lost on the mailing list. :s. On 22/11/2012 16:08, Peter Maydell wrote: On 22 November 2012 14:50, fred.kon...@greensocs.com wrote: There are still two issues with the command line : * When I use ./qemu* -device virtio-blk

Re: [Qemu-devel] [PATCH v2 39/39] raw-win32: implement native asynchronous I/O

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 14:34, Jan Kiszka ha scritto: =0 0xf77c242e __kernel_vsyscall+0xe() in [vdso].so (0x0519df88) 1 0xf761f10b __libc_read+0x4a() in libpthread.so.0 (0x0519df88) 2 0x7bc78c98 in ntdll (+0x68c97) (0x0519df88) 3 0x7bc7b0a3 in ntdll (+0x6b0a2) (0x0519e1b8) 4 0x7bc7b195

[Qemu-devel] [RFC PATCH v2 2/3] virtio-pci : add a virtio-bus interface

2012-11-22 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This patch add a VirtioBus in the VirtIOPCIProxy structure. It creates a new device : virtio-pci which init the VirtioBus. Two callback are written : * void virtio_pci_init_cb(DeviceState *dev) to initialize the PCI interface after the

[Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-22 Thread Stefan Hajnoczi
This series adds the -device virtio-blk-pci,x-data-plane=on property that enables a high performance I/O codepath. A dedicated thread is used to process virtio-blk requests outside the global mutex and without going through the QEMU block layer. Khoa Huynh k...@us.ibm.com reported an increase

[Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-22 Thread Stefan Hajnoczi
The data plane thread needs to map guest physical addresses to host pointers. Normally this is done with cpu_physical_memory_map() but the function assumes the global mutex is held. The data plane thread does not touch the global mutex and therefore needs a thread-safe memory mapping mechanism.

[Qemu-devel] [PATCH v4 04/11] dataplane: add virtqueue vring code

2012-11-22 Thread Stefan Hajnoczi
The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are this time are not thread-safe. This patch introduces a virtqueue module based on the kernel's vhost vring code. The trick is that we map guest memory

Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 1:35 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 22, 2012 at 12:58:23PM +0100, Stefan Hajnoczi wrote: On Thu, Nov 22, 2012 at 10:34:13AM +0100, Paolo Bonzini wrote: Il 21/11/2012 19:32, Stefan Hajnoczi ha scritto: The iov_get_ptr() data returns a

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 2:22 PM, Christian Borntraeger borntrae...@de.ibm.com wrote: On 22/11/12 13:02, Markus Armbruster wrote: Thanks for the review, Stefan already applied the patch, though. Is there anything that you really want to have a followup patch besides this one? Follow-up

Re: [Qemu-devel] drive_add 0 if=scsi crashes

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 15:02, Markus Armbruster ha scritto: Watch this: (qemu) drive_add 0 if=scsi Segmentation fault (core dumped) Broken in commit 0d936928 qdev: Convert busses to QEMU Object Model. Before: (qemu) drive_add 0 if=scsi Device is not a SCSI adapter Seems more

[Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code

2012-11-22 Thread Stefan Hajnoczi
virtio-blk-data-plane is a subset implementation of virtio-blk. It only handles read, write, and flush requests. It does this using a dedicated thread that executes an epoll(2)-based event loop and processes I/O using Linux AIO. This approach performs very well but can be used for raw image

[Qemu-devel] [PATCH v4 05/11] dataplane: add event loop

2012-11-22 Thread Stefan Hajnoczi
Outside the safety of the global mutex we need to poll on file descriptors. I found epoll(2) is a convenient way to do that, although other options could replace this module in the future (such as an AioContext-based loop or glib's GMainLoop). One important feature of this small event loop

[Qemu-devel] [PATCH v4 01/11] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2012-11-22 Thread Stefan Hajnoczi
The raw_get_aio_fd() function allows virtio-blk-data-plane to get the file descriptor of a raw image file with Linux AIO enabled. This interface is really a layering violation that can be resolved once the block layer is able to run outside the global mutex - at that point virtio-blk-data-plane

[Qemu-devel] [PATCH v4 09/11] iov: add qemu_iovec_concat_iov()

2012-11-22 Thread Stefan Hajnoczi
The qemu_iovec_concat() function copies a subset of a QEMUIOVector. The new qemu_iovec_concat_iov() function does the same for a iov/cnt pair. It is easy to define qemu_iovec_concat() in terms of qemu_iovec_concat_iov(). The existing code is mostly unchanged, except for the assertion src-size =

[Qemu-devel] [PATCH v4 08/11] test-iov: add iov_discard() testcase

2012-11-22 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/test-iov.c | 129 +++ 1 file changed, 129 insertions(+) diff --git a/tests/test-iov.c b/tests/test-iov.c index cbe7a89..7997fb5 100644 --- a/tests/test-iov.c +++ b/tests/test-iov.c @@

  1   2   3   >