[Qemu-devel] [PATCH v4] Add compare subcommand for qemu-img

2012-11-27 Thread Miroslav Rezanina
This is second version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size, exceeding part of bigger disk has to be zeroed/unallocated to compare rest

[Qemu-devel] [PATCH 1.3] virtio-rng: do not use g_assert_cmpint

2012-11-27 Thread Paolo Bonzini
g_assert_cmpint is not available on glib 2.12, which is the minimum version required to build QEMU (we only require 2.16 to run tests, since that is the first version including GTester). Do not use it in hardware models, use a normal assertion instead. This fixes the buildbot failure for

Re: [Qemu-devel] [PATCH] scsi: Remove SCSI_BUS macro

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 06:37, Lei Li ha scritto: As step behind Paolo's fix for RHBZ#879657 and according to the current fix in Commit b5007bc (hmp: do not crash on invalid SCSI hotplug), the macro SCSI_BUS has already been replaced to object_dynamic_cast which has been improved when try to cast to

[Qemu-devel] [PATCH v2] s390: clear registers, psw and prefix at vcpu reset

2012-11-27 Thread Jens Freimann
When resetting vcpus on s390/kvm we have to clear registers, psw and prefix as described in the z/Architecture PoP, otherwise a reboot won't work. IPL PSW and prefix are set later on by the s390-ipl device reset code. Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com --- changes v1-v2: -

[Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for default_x86_64_fedora16. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.target | 2 ++ 1 file changed, 2

[Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for default_x86_64_fedora16. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.target | 2 ++ 1 file changed, 2

Re: [Qemu-devel] [PATCH 15/20] acpi: switch smbus to memory api

2012-11-27 Thread Gerd Hoffmann
On 11/26/12 16:18, Andreas Färber wrote: Am 23.11.2012 16:48, schrieb Gerd Hoffmann: diff --git a/hw/pm_smbus.c b/hw/pm_smbus.c index 5d6046d..ea1380c 100644 --- a/hw/pm_smbus.c +++ b/hw/pm_smbus.c [...] @@ -170,7 +170,16 @@ uint32_t smb_ioport_readb(void *opaque, uint32_t addr)

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-27 Thread Kevin Wolf
Am 27.11.2012 08:15, schrieb Dietmar Maurer: The only solution I came up with is to add before/after hooks in the block job. I agree with the criticism, but I think it's general enough and at the same time easy enough to implement. IMHO, the current implementation is quite simple and easy to

[Qemu-devel] [PATCH 1.3] tests: make threadpool cancellation test looser

2012-11-27 Thread Paolo Bonzini
The cancellation test is failing on the buildbots. While the failure merits a little more investigation to understand what is going on, the logs show that the failure is not impacting the coverage provided by the test. Hence, loosen a bit the assertions in a way that should let the test proceed

[Qemu-devel] [PATCH v2 06/18] apci: switch evt to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.c | 49 +++-- hw/acpi.h |6 -- hw/acpi_ich9.c | 18 +- hw/acpi_piix4.c | 18 +- hw/vt82c686.c | 18 +- 5 files

[Qemu-devel] [PATCH v2 17/18] q35: update lpc pci config space according to configured devices

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/ich9.h |1 + hw/lpc_ich9.c | 29 + hw/smbus_ich9.c | 12 3 files changed, 30 insertions(+), 12 deletions(-) diff --git a/hw/ich9.h b/hw/ich9.h index de49135..34e216f 100644 ---

Re: [Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2012-11-27 Thread Justin Shafer
Open GL Works with wglgears. ubuntu@hptp-u1210b1:~/.wine/drive_c$ wine ./wglgears.exe qemu: Unsupported syscall: 254 Unsupported ancillary data: 1/2 qemu: Unsupported syscall: 242 Unsupported ancillary data: 1/2 qemu: Unsupported syscall: 242 Unsupported ancillary data: 1/2 qemu: Unsupported

Re: [Qemu-devel] [PATCH V11 4/7] libqblock build system

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 04:07, Wenchao Xia ha scritto: Please move this file to patch 6. I had a big WTF wondering how this could work :) before seeing that you then modified it in patch 6. OK to move it, but have a little problem, if it is removed then this patch will fail in compile because

Re: [Qemu-devel] [PATCH V11 6/7] libqblock API implement

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 04:22, Wenchao Xia ha scritto: There is no need (yet) to do these three steps. Once we add an asynchronous I/O API, we can add an API to get an AioContext from a QBlockContext. This however requires support for multiple AioContexts, I think. So that's left for later. It

[Qemu-devel] [PATCH v2 13/18] acpi: fix piix4 smbus mapping

2012-11-27 Thread Gerd Hoffmann
Make write to the smbus base register and enable bit actually work. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 9e6c97e..b1d5bf3 100644 ---

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Wenchao Xia
Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for default_x86_64_fedora16. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.target | 2 ++ 1 file

[Qemu-devel] [PATCH v2 15/18] acpi: remove acpi_gpe_blk

2012-11-27 Thread Gerd Hoffmann
With gpe being switched to memory api this is no longer needed. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.c |7 --- hw/acpi.h |2 -- hw/acpi_ich9.c |1 - hw/acpi_piix4.c |1 - 4 files changed, 0 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH v2 11/18] acpi: cleanup ich9 memory region

2012-11-27 Thread Gerd Hoffmann
Nothing left to do, everything handled by subregions, we can zap the reaw/write handlers now. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_ich9.c | 125 +--- 1 files changed, 1 insertions(+), 124 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2] s390: clear registers, psw and prefix at vcpu reset

2012-11-27 Thread Alexander Graf
On 27.11.2012, at 09:33, Jens Freimann jf...@linux.vnet.ibm.com wrote: When resetting vcpus on s390/kvm we have to clear registers, psw and prefix as described in the z/Architecture PoP, otherwise a reboot won't work. IPL PSW and prefix are set later on by the s390-ipl device reset code.

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 10:27, Wenchao Xia ha scritto: In tcg case I think translate.o will influent performance obviously, how about adding an option fast-build to use -O1 for it by default. If you agree I will adding that after this patch upstream which fix build bot failure quickly. This is not

[Qemu-devel] [PATCH v2 05/18] apci: switch cnt to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.c | 38 ++ hw/acpi.h |5 +++-- hw/acpi_ich9.c |8 +--- hw/acpi_piix4.c |8 +--- hw/vt82c686.c |8 +--- 5 files changed, 36 insertions(+), 31 deletions(-)

[Qemu-devel] [PATCH v2 09/18] apci: switch ich9 gpe to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_ich9.c | 38 -- hw/acpi_ich9.h |1 + 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index 3b5bac6..5fc160a 100644 --- a/hw/acpi_ich9.c +++

[Qemu-devel] [PATCH v2 02/18] apci: switch ich9 to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_ich9.c | 44 +++- hw/acpi_ich9.h |1 + 2 files changed, 28 insertions(+), 17 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index 61034d3..bf361ec 100644 --- a/hw/acpi_ich9.c +++

[Qemu-devel] [PATCH v2 01/18] apci: switch piix4 to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c | 41 - 1 files changed, 24 insertions(+), 17 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 519269a..320e045 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@

[Qemu-devel] [PATCH v2 12/18] acpi: switch smbus to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c |5 ++--- hw/pm_smbus.c | 17 + hw/pm_smbus.h |3 +-- hw/smbus_ich9.c | 52 +++- hw/vt82c686.c |6 ++ 5 files changed, 33 insertions(+), 50

[Qemu-devel] [PATCH v2 04/18] apci: switch timer to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.c | 19 +-- hw/acpi.h |5 +++-- hw/acpi_ich9.c |5 + hw/acpi_piix4.c |5 + hw/vt82c686.c |6 +- 5 files changed, 23 insertions(+), 17 deletions(-) diff --git a/hw/acpi.c

[Qemu-devel] [PATCH v2 07/18] acpi: cleanup piix4 memory region

2012-11-27 Thread Gerd Hoffmann
Nothing left to do, everything handled by subregions, we can zap the reaw/write handlers now. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c | 41 + 1 files changed, 1 insertions(+), 40 deletions(-) diff --git a/hw/acpi_piix4.c

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-27 Thread Wenchao Xia
于 2012-11-21 17:01, Dietmar Maurer 写道: This series provides a way to efficiently backup VMs. * Backup to a single archive file * Backup contain all data to restore VM (full backup) * Do not depend on storage type or image format * Avoid use of temporary storage * store sparse images

[Qemu-devel] [PATCH v2 16/18] apci: switch piix4 pci hotplug to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c | 37 + 1 files changed, 29 insertions(+), 8 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index d2ba56e..263338a 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -42,6

[Qemu-devel] [PATCH v2 03/18] apci: switch vt82c686 to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vt82c686.c | 37 +++-- 1 files changed, 27 insertions(+), 10 deletions(-) diff --git a/hw/vt82c686.c b/hw/vt82c686.c index 5d7c00c..3fc6063 100644 --- a/hw/vt82c686.c +++ b/hw/vt82c686.c @@ -24,6 +24,7 @@

[Qemu-devel] [PATCH v2 10/18] apci: switch ich9 smi to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_ich9.c | 46 -- hw/acpi_ich9.h |1 + 2 files changed, 37 insertions(+), 10 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index 5fc160a..0ed17da 100644 --- a/hw/acpi_ich9.c +++

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-27 Thread Dietmar Maurer
The only solution I came up with is to add before/after hooks in the block job. I agree with the criticism, but I think it's general enough and at the same time easy enough to implement. Ok, here is another try - do you think that is better? Note: This code is not tested - I just want to

[Qemu-devel] [PATCH v2 00/18] acpi: switch to memory api

2012-11-27 Thread Gerd Hoffmann
Hi, While wading through the qemu acpi and seabios aml code I've figured the qemu acpi codebase is *way* too messy. So this patch series switches the apci code to the memory api. That alone cleans up quite a bit and makes the code in hw/acpi.c more self-contained. As bonus everything shows

[Qemu-devel] [PATCH v2 08/18] acpi: cleanup vt82c686 memory region

2012-11-27 Thread Gerd Hoffmann
Nothing left to do, everything handled by subregions, we can zap the reaw/write handlers now. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vt82c686.c | 61 + 1 files changed, 1 insertions(+), 60 deletions(-) diff --git

[Qemu-devel] [PATCH v2 18/18] acpi: drop debug port

2012-11-27 Thread Gerd Hoffmann
I'm pretty sure this isn't needed any more. I think this predates the switch to seabios, and the seabios DSDT table has a DBUG() aml macro which writes stuff to the seabios debug port (0x402). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c |9 - 1 files changed,

[Qemu-devel] [PATCH v2 14/18] apci: switch piix4 gpe to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index b1d5bf3..c1a58d3 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -57,6 +57,7 @@ struct

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-27 Thread Dietmar Maurer
Just want to confirm something to understand it better: you are backing up the block image not including VM memory state right? I am considering a way to do live Savevm including memory and device state, so wonder if you already had a solution for it. Yes, I have already code for that.

Re: [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack

2012-11-27 Thread Kevin Wolf
Am 12.11.2012 13:57, schrieb Stefan Hajnoczi: On Sat, Nov 10, 2012 at 10:47 PM, Peter Maydell peter.mayd...@linaro.org wrote: Use the POSIX-specified stack_t type as the argument to sigaltstack() rather than the legacy struct sigaltstack. This allows us to compile on MacOSX with

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Gerd Hoffmann
Hi, Note that there is probably one or two GCC options that can be fine-tuned to avoid the explosion instead of just -O1 vs. -O2. If you have an affected machine (F18) you can help by compiling translate.c with -O2 -ftime-report. I planned to do this today, but I first need to install a

[Qemu-devel] [PATCH] pixman: require 0.18.4 or newer

2012-11-27 Thread Gerd Hoffmann
When older versions are found the internal pixman version is prefered. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 780b19a..1a3458f 100755 --- a/configure +++ b/configure @@

Re: [Qemu-devel] [0/2] pseries: Rework PCI code for handling multiple PHBs

2012-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2012 at 05:07:31PM +1100, David Gibson wrote: Hi Michael, Alex, This patch represents a compromise I hope will be acceptable after the long thread discussing handling of multiple PCI host bridges on the pseries machine. Patch 1/1 is just a preliminary enforcing uniqueness

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-11-27 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 6:19 PM, Mike Lovell m...@dev-zero.net wrote: i think it does still make sense to implement it in QEMU. there isn't a problem with multiple processes using the same multicast address. the net_socket_mcast_create function in socket.c already sets the IP_MULTICAST_LOOP

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-27 Thread Amit Shah
On (Sun) 25 Nov 2012 [15:39:14], Alon Levy wrote: When migrating a host with with a spice agent running the mouse becomes non operational after the migration due to the agent state being inconsistent between the guest and the client if the client is using semi-seamless or switch host

[Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)

2012-11-27 Thread Luiz Capitulino
This series revamps qemu-ga error messages by: - Propagating errors down to functions that generate errors - Fixing UndefinedErrors - Getting rid of sprint() + error_set() - Other small fixes Only the POSIX port is covered in this series, win32 is left to another day. Luiz Capitulino (10):

[Qemu-devel] [PATCH 04/10] qemu-ga: qmp_guest_shutdown(): improve error reporting

2012-11-27 Thread Luiz Capitulino
Most errors are QERR_UNDEFINED_ERROR. Also, adds ga_wait_child() as a future commit will use it too. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 48 ++-- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check

2012-11-27 Thread Luiz Capitulino
fclose() returns EOF on error. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index a2216f2..c284083 100644 --- a/qga/commands-posix.c +++

[Qemu-devel] [PATCH 08/10] qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() + error_set()

2012-11-27 Thread Luiz Capitulino
Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 72ef8ba..c399f02 100644 ---

[Qemu-devel] [PATCH 10/10] qemu-ga: guest_suspend(): improve error reporting

2012-11-27 Thread Luiz Capitulino
Most errors are QERR_UNDEFINED_ERROR today. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 5a7e308..ce058b5 100644

Re: [Qemu-devel] [PATCH] usb: fail usbdevice_create() when there is no USB bus

2012-11-27 Thread Gerd Hoffmann
On 11/25/12 16:49, Stefan Hajnoczi wrote: Report an error instead of segfaulting when attaching a USB device to a machine with no USB busses: $ qemu-system-arm -machine vexpress-a9 \ -sd Fedora-17-armhfp-vexpress-mmcblk0.img \ -kernel vmlinuz-3.4.2-3.fc17.armv7hl \

[Qemu-devel] [PATCH 07/10] qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set()

2012-11-27 Thread Luiz Capitulino
Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 9325433..72ef8ba 100644 --- a/qga/commands-posix.c

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Peter Maydell
On 27 November 2012 08:34, Paolo Bonzini pbonz...@redhat.com wrote: Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for default_x86_64_fedora16. This is a well known bug in old

[Qemu-devel] [PATCH 01/10] qemu-ga: guest_file_handle_find(): take an Error argument

2012-11-27 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 726930a..a2216f2 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Gerd Hoffmann
On 11/27/12 14:24, Peter Maydell wrote: On 27 November 2012 08:34, Paolo Bonzini pbonz...@redhat.com wrote: Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Peter Maydell
On 27 November 2012 13:45, Gerd Hoffmann kra...@redhat.com wrote: On 11/27/12 14:24, Peter Maydell wrote: This is a well known bug in old gcc (ie fixed in 4.5, 4.6 and trunk a year ago). Use a newer gcc, or a 64 bit build system with a reasonable amount of RAM, or as a workaround apply some

[Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting

2012-11-27 Thread Luiz Capitulino
Use error_setg_errno() when possible with an improved error description. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Wei-Ren Chen
On Tue, Nov 27, 2012 at 02:45:07PM +0100, Gerd Hoffmann wrote: On 11/27/12 14:24, Peter Maydell wrote: On 27 November 2012 08:34, Paolo Bonzini pbonz...@redhat.com wrote: Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, compile it

[Qemu-devel] [PATCH 05/10] qemu-ga: build_fs_mount_list(): take an Error argument

2012-11-27 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index b3a3f26..59bb32d 100644 --- a/qga/commands-posix.c +++

[Qemu-devel] [PATCH 06/10] qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set()

2012-11-27 Thread Luiz Capitulino
Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 59bb32d..9325433 100644 --- a/qga/commands-posix.c

[Qemu-devel] [PATCH 09/10] qemu-ga: bios_supports_mode(): improve error reporting

2012-11-27 Thread Luiz Capitulino
Most errors are QERR_UNDEFINED_ERROR today. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 46 +++--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-27 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: On (Sun) 25 Nov 2012 [15:39:14], Alon Levy wrote: When migrating a host with with a spice agent running the mouse becomes non operational after the migration due to the agent state being inconsistent between the guest and the client if the client is

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 14:46, Peter Maydell ha scritto: On 27 November 2012 13:45, Gerd Hoffmann kra...@redhat.com wrote: On 11/27/12 14:24, Peter Maydell wrote: This is a well known bug in old gcc (ie fixed in 4.5, 4.6 and trunk a year ago). Use a newer gcc, or a 64 bit build system with a reasonable

Re: [Qemu-devel] KVM call agenda for 2012-11-27

2012-11-27 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda topics you are interested in. As there are no topic's call is cancelled. Have a nice day, Juan.

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-11-27 Thread Anthony Liguori
Stefan Hajnoczi stefa...@gmail.com writes: On Mon, Nov 26, 2012 at 6:19 PM, Mike Lovell m...@dev-zero.net wrote: i think it does still make sense to implement it in QEMU. there isn't a problem with multiple processes using the same multicast address. the net_socket_mcast_create function in

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-27 Thread Amit Shah
On (Tue) 27 Nov 2012 [15:10:06], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: Adding Gerd and Markus as I think they were involved in the discussion last time as well. Got a pointer to the old thread?

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 14:49, 陳韋任 (Wei-Ren Chen) ha scritto: It isn't that simple. It's Fedora 17 with gcc 4.7.2 which runs oom while compiling translate.c Even apply Peter's suggestion? Do all gcc 4.7.2 on various platform have the same problem, or it only happen on Fedora 17. All. It is

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Avi Kivity
On 11/27/2012 10:34 AM, Paolo Bonzini wrote: Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for default_x86_64_fedora16. Signed-off-by: Paolo Bonzini pbonz...@redhat.com

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 16:53, Avi Kivity ha scritto: This may change some string argument in CFLAGS, for example an argument to -I. How about: CFLAGS_opt = -O2 CFLAGS += $(CFLAGS_opt) ... %/translate.o: CFLAGS_opt = -O1 Not possible because CFLAGS comes from configure, but anyway what

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-27 Thread Corey Bryant
On 11/26/2012 04:48 PM, Paul Moore wrote: On Monday, November 26, 2012 03:41:00 PM Paul Moore wrote: On Monday, November 26, 2012 02:59:21 PM Corey Bryant wrote: On 11/26/2012 12:08 PM, Paul Moore wrote: On Monday, November 26, 2012 11:41:06 AM Corey Bryant wrote: On 11/21/2012 10:24 AM,

[Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Paolo Bonzini
Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for default_x86_64_fedora16. Anyway is a good thing to do because people will try to compile 1.3 with less than 2GB

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Michael S. Tsirkin
On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced a regression in virtio-net performance because it looks into the ring aggressively while we really only care about a single packet worth of buffers. To fix, add

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Alexander Graf
On 11/27/2012 05:21 PM, Paolo Bonzini wrote: Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for default_x86_64_fedora16. Anyway is a good thing to do because

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Andreas Färber
Am 27.11.2012 14:49, schrieb 陳韋任 (Wei-Ren Chen): On Tue, Nov 27, 2012 at 02:45:07PM +0100, Gerd Hoffmann wrote: On 11/27/12 14:24, Peter Maydell wrote: On 27 November 2012 08:34, Paolo Bonzini pbonz...@redhat.com wrote: Some versions of GCC require insane (2GB) amounts of memory to compile

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-27 Thread Paul Moore
On Tuesday, November 27, 2012 11:11:32 AM Corey Bryant wrote: Thanks for the additional details. They were very useful. I was able to reproduce this when I manually built spice release 0.10.1, but not with the Fedora 0.10.1 package. One difference I noticed is that the Fedora version wasn't

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Edivaldo de Araujo Pereira
Dear friends, Please excuse-me for not reporting earlier... I confirm that the patch by Michael really fixes the problem I've reported. The regression has gone away when I used it, so I think it is good to be applied. Thanks, Edivaldo de Araújo Pereira --- Em ter, 27/11/12, Michael S.

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 17:49, Markus Armbruster ha scritto: +%/translate.o: CFLAGS := $(patsubst -O2,-O1,$(CFLAGS)) + This may change some string argument in CFLAGS, for example an argument to -I. How about: CFLAGS_opt = -O2 CFLAGS += $(CFLAGS_opt) ... %/translate.o: CFLAGS_opt = -O1

Re: [Qemu-devel] [PATCH v2] s390: clear registers, psw and prefix at vcpu reset

2012-11-27 Thread Jens Freimann
On Tue, Nov 27, 2012 at 10:37:25AM +0100, Alexander Graf wrote: On 27.11.2012, at 09:33, Jens Freimann jf...@linux.vnet.ibm.com wrote: When resetting vcpus on s390/kvm we have to clear registers, psw and prefix as described in the z/Architecture PoP, otherwise a reboot won't work. IPL

Re: [Qemu-devel] [PATCH v2] s390: clear registers, psw and prefix at vcpu reset

2012-11-27 Thread Alexander Graf
On 11/27/2012 06:13 PM, Jens Freimann wrote: On Tue, Nov 27, 2012 at 10:37:25AM +0100, Alexander Graf wrote: On 27.11.2012, at 09:33, Jens Freimannjf...@linux.vnet.ibm.com wrote: When resetting vcpus on s390/kvm we have to clear registers, psw and prefix as described in the z/Architecture

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] Make default boot order machine specific

2012-11-27 Thread Avik Sil
On 11/23/2012 10:22 PM, Alexander Graf wrote: On 05.11.2012, at 12:34, Avik Sil wrote: On 10/26/2012 05:15 PM, Alexander Graf wrote: On 25.10.2012, at 22:57, Alexander Graf ag...@suse.de wrote: On 25.10.2012, at 22:50, Peter Maydell wrote: On 25 October 2012 21:18, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 17:24, Alexander Graf ha scritto: +# Workaround for http://gcc.gnu.org/PR55489. Happens with -fPIE/-fPIC +# and large functions that use global variables. The bug is in all +# releases of GCC, but it became particularly acute in 4.7.x. We +# should be able to delete this at

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 11/27/2012 10:34 AM, Paolo Bonzini wrote: Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for default_x86_64_fedora16. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Stefan Weil
Am 27.11.2012 17:30, schrieb Paolo Bonzini: Il 27/11/2012 17:24, Alexander Graf ha scritto: +# Workaround for http://gcc.gnu.org/PR55489. Happens with -fPIE/-fPIC +# and large functions that use global variables. The bug is in all +# releases of GCC, but it became particularly acute in 4.7.x.

Re: [Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-27 Thread Auld, Will
Gleb, This last change to emulator_set_msr() was wrong as you point out. I will change it back to what it was in V3 with the exception of fixing the bool that Marcelo pointed out. However, the change of: struct kvm_x86_ops {... int (*set_msr)(struct kvm_vcpu *vcpu, struct msr_data

Re: [Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-27 Thread Gleb Natapov
On Tue, Nov 27, 2012 at 06:19:21PM +, Auld, Will wrote: Gleb, This last change to emulator_set_msr() was wrong as you point out. I will change it back to what it was in V3 with the exception of fixing the bool that Marcelo pointed out. However, the change of: struct kvm_x86_ops

Re: [Qemu-devel] [PATCH] cocoa: Fix VBE function Set Display Start

2012-11-27 Thread Henry Harrington
On Tue, Nov 27, 2012 at 5:03 AM, Andreas Färber andreas.faer...@web.de wrote: Am 21.11.2012 20:08, schrieb Henry Harrington: Apart from the style issues above (you can use scripts/checkpatch.pl to verify) this looks okay. Unfortunately I am not getting pixman built on OSX so am still unable to

[Qemu-devel] [PATCH v2] cocoa: Fix VBE function Set Display Start

2012-11-27 Thread Henry Harrington
Register a dpy_gfx_setdata callback so that the Cocoa code is notified whenever the screen start address changes. Commit 1d3323d has a similar fix for the VNC UI. Signed-off-by: Henry Harrington henry.harring...@gmail.com --- ui/cocoa.m | 21 + 1 files changed, 21

Re: [Qemu-devel] [PATCHv3 2/5] seccomp: setting -sandbox on as deafult

2012-11-27 Thread Anthony Liguori
Eduardo Otubo ot...@linux.vnet.ibm.com writes: Now the seccomp filter will be set to on even if no argument -sandbox is given. v3: * Introduced seccomp_states enum and new functions named seccomp_set_state() and seccomp_get_state() (pbonz...@redhat.com). * Merged

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-27 Thread Anthony Liguori
Amit Shah amit.s...@redhat.com writes: On (Sun) 25 Nov 2012 [15:39:14], Alon Levy wrote: When migrating a host with with a spice agent running the mouse becomes non operational after the migration due to the agent state being inconsistent between the guest and the client if the client is

[Qemu-devel] [PATCH V5 0/2] Enable guest use of TSC_ADJUST functionality

2012-11-27 Thread Will Auld
With this version (V5) I have gone back the the V3 implementation of emulator_set_msr() but changing the bool to false. Will Auld (2): Add code to track call origin for msr assignment. Enabling IA32_TSC_ADJUST for KVM guest VM support arch/x86/include/asm/cpufeature.h | 1 +

[Qemu-devel] [PATCH V5 1/2] Add code to track call origin for msr assignment.

2012-11-27 Thread Will Auld
In order to track who initiated the call (host or guest) to modify an msr value I have changed function call parameters along the call path. The specific change is to add a struct pointer parameter that points to (index, data, caller) information rather than having this information passed as

Re: [Qemu-devel] [PATCHv3 2/5] seccomp: setting -sandbox on as deafult

2012-11-27 Thread Corey Bryant
On 11/27/2012 02:01 PM, Anthony Liguori wrote: Eduardo Otubo ot...@linux.vnet.ibm.com writes: Now the seccomp filter will be set to on even if no argument -sandbox is given. v3: * Introduced seccomp_states enum and new functions named seccomp_set_state() and seccomp_get_state()

[Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-27 Thread Will Auld
CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to a guest vcpu specific location to store the value of the emulated MSR while adding the value to the vmcs tsc_offset. In this way the IA32_TSC_ADJUST value will be

[Qemu-devel] [PATCH for-1.3] vfio-pci: Fix KVM disabled path

2012-11-27 Thread Alex Williamson
kvm_check_extension() explodes when KVM isn't enabled so we need to first test whether KVM is enabled. Use kvm_irqchip_in_kernel() for this since it matches the test we do before using this result. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/vfio_pci.c |3 ++- 1 file

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced a regression in virtio-net performance because it looks into the ring aggressively while we really only care about a

[Qemu-devel] [RFC PATCH v3 0/2] Introduce virtio-bus.

2012-11-27 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com As said on IRC, I send only VirtioBus as old implementation of VirtioPCI is not longer making sense after the changes on VirtioBus. As anthony said, the better way to do this refactoring is : * Introducing a virtio-bus which extends

[Qemu-devel] [RFC PATCH v3 2/2] qbus : add a maximum device.

2012-11-27 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com Only one device can be connected to virtio-bus. This patch add a field max_dev which is : * the maximum amount of devices connected on the bus ( when * max_dev!=0 ). * have no effect ( when max_dev=0 ). The function qbus_find_recursive

[Qemu-devel] [RFC PATCH v3 1/2] virtio-bus : Introduce virtio-bus

2012-11-27 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This patch create VirtioBus which is abstract, we can create virtio-x-bus which extends this virtio-bus. The virtio-x-bus need to implement all the methods from the VirtioBusClass. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com ---

[Qemu-devel] [PATCH] qapi: fix qapi_dealloc_type_size parameter type

2012-11-27 Thread Bruce Rogers
The second parameter to qapi_dealloc_type_size should be a uint64_t *, not a size_t *. This was causing our 32 bit x86 build to fail, since warnings are treated as errors. Signed-off-by: Bruce Rogers brog...@suse.com --- qapi/qapi-dealloc-visitor.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport*

2012-11-27 Thread Jason Baron
On Tue, Nov 27, 2012 at 01:10:16AM +0100, Andreas Färber wrote: Am 19.09.2012 13:50, schrieb Julien Grall: This patch replaces all register_ioport* by a MemorySection. It permits to use the new Memory stuff like listener. Moreover, the PCI is added as an argument for apm_init, so we

Re: [Qemu-devel] [PATCH] qapi: fix qapi_dealloc_type_size parameter type

2012-11-27 Thread mdroth
On Tue, Nov 27, 2012 at 01:11:25PM -0700, Bruce Rogers wrote: The second parameter to qapi_dealloc_type_size should be a uint64_t *, not a size_t *. This was causing our 32 bit x86 build to fail, since warnings are treated as errors. Signed-off-by: Bruce Rogers brog...@suse.com Doh, I

Re: [Qemu-devel] MIPS exception number limits?

2012-11-27 Thread Richard Henderson
On 11/26/2012 09:25 PM, Johnson, Eric wrote: So basically the SC and SCD instructions for user-mode QEMU are implemented with a dummy exception. Since it is not a real exception, it is not reported in the QEMU log file as an exception. I'm not certain that's a helpful distinction to make

  1   2   >