Re: [Qemu-devel] [PATCH v2 1/2] ivshmem: remove msix_write_config

2012-11-28 Thread liu ping fan
ping? On Sun, Nov 25, 2012 at 11:51 AM, Liu Ping Fan qemul...@gmail.com wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com This logic has been integrated into pci core, so remove it. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/ivshmem.c |1 - 1 files changed, 0

[Qemu-devel] [PATCH v3 1.3] build: compile translate.o with -fno-gcse option on GCC 4.6.x and 4.7.[012]

2012-11-28 Thread Paolo Bonzini
These versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for default_x86_64_fedora16. Anyway this is a good thing to do because people will try to compile 1.3 with less

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-28 Thread Janne Karhunen
Peter, I have qemu chrootable test case under which you could fire one command to hit the bug reliably. Only issue is, are you willing to take a peek at 100M extractable tarball? If not, I'll try to create a smaller one. -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Alon Levy
Instead of aborting immediately after at DEVICE_CLASS(obj) Signed-off-by: Alon Levy al...@redhat.com --- hw/qdev-monitor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 479eecd..3b70cdb 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c

[Qemu-devel] [PATCH V12 7/7] libqblock test example

2012-11-28 Thread Wenchao Xia
In this example, first it will create some qcow2 images, then try get information including backing file relationship, then it will do sync IO on the image. v11: Use only gtester option -k, to avoid silent fail for segment fault. Little change according to API. v12: Little change

[Qemu-devel] [PATCH V12 6/7] libqblock API implement

2012-11-28 Thread Wenchao Xia
This patch contains implemention for APIs. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockImage. It stands for an block image object. 3 QBlockStaticInfo. It contains static information such as location, backing file,

Re: [Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-28 Thread Peter Maydell
On 28 November 2012 08:42, Janne Karhunen 955...@bugs.launchpad.net wrote: Peter, I have qemu chrootable test case under which you could fire one command to hit the bug reliably. Only issue is, are you willing to take a peek at 100M extractable tarball? If not, I'll try to create a smaller

[Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration

2012-11-28 Thread Alon Levy
Adds a new char device backend callback to check connectedness, implemented for virtio console, and used by spice-char-dev in post migration. Is using NULL for DeviceState the intention for non device vmstates? It works fine in practice. Alon Levy (3): virtio-serial: add

[Qemu-devel] [PATCH V12 1/7] Build system clean tests directory clearly

2012-11-28 Thread Wenchao Xia
Currently root Makefile try clean tests/tcg, hard to extend. This patch added command make check-clean, which clean all generated files used in tests. With this command root Makefile do not care tests clean method any more, it simply calls the command to do it, so any more clean script could be

[Qemu-devel] [PATCH] xilinx_zynq: Add one variable to avoid overwriting QSPI bus

2012-11-28 Thread Liming Wang
commit 7b482bcf xilinx_zynq: added QSPI controller Adds one QSPI controller, which has two spi buses, one is for spi0, and another is for spi1. But when initializing the spi1 bus, dev has been overwrited by the ssi_create_slave_no_init() function, so that qdev_get_child_bus() returns NULL and the

[Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-11-28 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- libcacard/Makefile | 4 ++-- roms/openbios | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index c26aac6..25bc4a0 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -15,7

[Qemu-devel] [PATCH 2/2] libcacard: fix missing symbol in libcacard.so

2012-11-28 Thread Alon Levy
Before patch: $ make libcacard.la $ nm ./libcacard/.libs/libcacard.so.0.0.0 | grep U | \ egrep -v (g_)|(GLIBC)|(SECMOD)|(PK11)|(CERT)|(NSS)|(PORT)|(PR) U error_set Signed-off-by: Alon Levy al...@redhat.com --- libcacard/Makefile | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH V12 6/7] libqblock API implement

2012-11-28 Thread Paolo Bonzini
Almost there... Il 28/11/2012 09:55, Wenchao Xia ha scritto: +/* This file was only used in libqblock, codes are copied from main-loop.c, + iohandler.c, compatfd.c now, it may have different implemention in the future. +*/ No need for this comment. + +/* Signal fd support, original codes

Re: [Qemu-devel] [PATCH V12 7/7] libqblock test example

2012-11-28 Thread Paolo Bonzini
Il 28/11/2012 09:55, Wenchao Xia ha scritto: +ret = qb_image_new(context, qbi); +g_assert(ret == 0); +qb_image_ref(context, qbi); Remember, when changing qb_image_new, to remove these _ref calls. Paolo

[Qemu-devel] [PATCH V12 2/7] block export function path_has_protocol

2012-11-28 Thread Wenchao Xia
This function is needed in other module, so export it. There is already some patch on mail-list try export it, If that patch was applied, pls ignore this one. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block.c |2 +- block.h |2 ++ 2 files changed, 3 insertions(+), 1

Re: [Qemu-devel] [PATCH V12 4/7] libqblock build system

2012-11-28 Thread Paolo Bonzini
Ok, I'm pretty confident that v13 will be the last one. :) Il 28/11/2012 09:55, Wenchao Xia ha scritto: @@ -1119,6 +1124,8 @@ echo --with-coroutine=BACKEND coroutine backend. Supported options: echogthread, ucontext, sigaltstack, windows echo

[Qemu-devel] [PATCH 1/3] virtio-serial: add virtio_serial_guest_connected

2012-11-28 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/virtio-serial-bus.c | 9 + hw/virtio-serial.h | 5 + 2 files changed, 14 insertions(+) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index ccce1fa..9147497 100644 --- a/hw/virtio-serial-bus.c +++

Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-11-28 Thread Paolo Bonzini
Il 28/11/2012 10:16, Alon Levy ha scritto: diff --git a/roms/openbios b/roms/openbios index f095c85..d1d2787 16 --- a/roms/openbios +++ b/roms/openbios @@ -1 +1 @@ -Subproject commit f095c858136896d236931357b8d597f407286f71 +Subproject commit d1d2787f87167edf487a60e61b9168514d5a7434

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-28 Thread Wenchao Xia
于 2012-11-27 18:37, Dietmar Maurer 写道: Just want to confirm something to understand it better: you are backing up the block image not including VM memory state right? I am considering a way to do live Savevm including memory and device state, so wonder if you already had a solution for it.

[Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-28 Thread Alon Levy
The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only by the agent channel, which the server ignores. The net effect is that the mouse is

Re: [Qemu-devel] [PATCH 2/3] qemu-char: add qemu_chr_be_connected

2012-11-28 Thread Markus Armbruster
Alon Levy al...@redhat.com writes: This differs from qemu_chr_be_can_write in that it will return 1 as long as the backend is connected, including when the backend is connected but not available for receiving, as in the case of virtio-serial where the guest ring may be full. If no

[Qemu-devel] [PATCH 2/3] qemu-char: add qemu_chr_be_connected

2012-11-28 Thread Alon Levy
This differs from qemu_chr_be_can_write in that it will return 1 as long as the backend is connected, including when the backend is connected but not available for receiving, as in the case of virtio-serial where the guest ring may be full. If no implementation is provided the backend reports

[Qemu-devel] [PATCH] libcacard: build vscclient from root only

2012-11-28 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- libcacard/Makefile | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 7bce286..98c971d 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -1,3 +1,7 @@ +ifeq

[Qemu-devel] [PATCH V12 5/7] libqblock API design and type defines

2012-11-28 Thread Wenchao Xia
Public API design header files: libqblock.h, libqblock-error.h. Public type define header files: libqblock-types.h. Private internal used header files: libqblock-internal, libqblock-aio.h. For ABI some reserved bytes are used in structure defines. v11: Moved API design into this patch.

Re: [Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-28 Thread Markus Armbruster
Alon Levy al...@redhat.com writes: The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only by the agent channel, which the server ignores.

[Qemu-devel] [PATCH V12 4/7] libqblock build system

2012-11-28 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock.

[Qemu-devel] [PATCH V12 0/7] libqblock qemu block layer library

2012-11-28 Thread Wenchao Xia
These patches introduce libqblock API, make subdir-libqblock and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image.

Re: [Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-28 Thread Alon Levy
Alon Levy al...@redhat.com writes: The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only by the agent channel, which the

[Qemu-devel] [PATCH V12 3/7] stubs add function qemu_set_fd_handler

2012-11-28 Thread Wenchao Xia
This function is needed by libqblock linkage, so add it. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- stubs/set-fd-handler.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/stubs/set-fd-handler.c b/stubs/set-fd-handler.c index 4807b5d..7b4ca4f

Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-11-28 Thread Alon Levy
Il 28/11/2012 10:16, Alon Levy ha scritto: diff --git a/roms/openbios b/roms/openbios index f095c85..d1d2787 16 --- a/roms/openbios +++ b/roms/openbios @@ -1 +1 @@ -Subproject commit f095c858136896d236931357b8d597f407286f71 +Subproject commit

Re: [Qemu-devel] [PATCH] xilinx_zynq: Add one variable to avoid overwriting QSPI bus

2012-11-28 Thread Peter Crosthwaite
On Wed, Nov 28, 2012 at 7:14 PM, Liming Wang walimis...@gmail.com wrote: commit 7b482bcf xilinx_zynq: added QSPI controller Adds one QSPI controller, which has two spi buses, one is for spi0, and another is for spi1. But when initializing the spi1 bus, dev has been overwrited by the

Re: [Qemu-devel] [PATCH] libcacard: build vscclient from root only

2012-11-28 Thread Paolo Bonzini
Il 28/11/2012 10:26, Alon Levy ha scritto: Signed-off-by: Alon Levy al...@redhat.com --- libcacard/Makefile | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 7bce286..98c971d 100644 --- a/libcacard/Makefile +++

[Qemu-devel] [PATCH] nbd-server-add: Fix the default for 'writable'

2012-11-28 Thread Michal Privoznik
The documentation to this monitor command tells, that 'writable' argument is optional and defaults to false. However, the code sets true as the default. But since some applications may already been using this, it's safer to fix the code and not documentation which would break those applications.

Re: [Qemu-devel] [PATCH] nbd-server-add: Fix the default for 'writable'

2012-11-28 Thread Paolo Bonzini
Il 28/11/2012 11:46, Michal Privoznik ha scritto: The documentation to this monitor command tells, that 'writable' argument is optional and defaults to false. However, the code sets true as the default. But since some applications may already been using this, it's safer to fix the code and not

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-28 Thread Andreas Färber
Am 27.11.2012 17:21, schrieb Paolo Bonzini: Some versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for default_x86_64_fedora16. Anyway is a good thing to do because

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-28 Thread Dietmar Maurer
Does those code for VM memory and device state lively save/restore included in this patch serials? I quickly reviewed the patches but did not found a hook to save VM memory state? Hope you can enlight me your way, my thoughts is do live migration into qcow2 file, but your code seems not

Re: [Qemu-devel] [PATCH 1.3] event notifier: Fix setup for win32

2012-11-28 Thread Paolo Bonzini
Il 23/11/2012 08:08, Stefan Hajnoczi ha scritto: On Thu, Nov 22, 2012 at 08:56:11PM +0100, Jan Kiszka wrote: The event notifier state is only reset by test_and_clear. But we created the windows event object with auto-reset, which subtly swallowed events. Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Luiz Capitulino
On Wed, 28 Nov 2012 10:54:33 +0200 Alon Levy al...@redhat.com wrote: Instead of aborting immediately after at DEVICE_CLASS(obj) Signed-off-by: Alon Levy al...@redhat.com --- hw/qdev-monitor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c

Re: [Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-28 Thread Markus Armbruster
Alon Levy al...@redhat.com writes: Alon Levy al...@redhat.com writes: The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Markus Armbruster
Alon Levy al...@redhat.com writes: Instead of aborting immediately after at DEVICE_CLASS(obj) Reproducer?

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Paolo Bonzini
Il 28/11/2012 12:54, Luiz Capitulino ha scritto: On Wed, 28 Nov 2012 10:54:33 +0200 Alon Levy al...@redhat.com wrote: Instead of aborting immediately after at DEVICE_CLASS(obj) Signed-off-by: Alon Levy al...@redhat.com --- hw/qdev-monitor.c | 5 + 1 file changed, 5 insertions(+)

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Luiz Capitulino
On Wed, 28 Nov 2012 13:02:26 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 28/11/2012 12:54, Luiz Capitulino ha scritto: On Wed, 28 Nov 2012 10:54:33 +0200 Alon Levy al...@redhat.com wrote: Instead of aborting immediately after at DEVICE_CLASS(obj) Signed-off-by: Alon Levy

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Andreas Färber
Am 28.11.2012 12:54, schrieb Luiz Capitulino: On Wed, 28 Nov 2012 10:54:33 +0200 Alon Levy al...@redhat.com wrote: Instead of aborting immediately after at DEVICE_CLASS(obj) Signed-off-by: Alon Levy al...@redhat.com --- hw/qdev-monitor.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-28 Thread Alon Levy
Alon Levy al...@redhat.com writes: Alon Levy al...@redhat.com writes: The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Alon Levy
On Wed, 28 Nov 2012 10:54:33 +0200 Alon Levy al...@redhat.com wrote: Instead of aborting immediately after at DEVICE_CLASS(obj) Signed-off-by: Alon Levy al...@redhat.com --- hw/qdev-monitor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/qdev-monitor.c

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Alon Levy
Il 28/11/2012 12:54, Luiz Capitulino ha scritto: On Wed, 28 Nov 2012 10:54:33 +0200 Alon Levy al...@redhat.com wrote: Instead of aborting immediately after at DEVICE_CLASS(obj) Signed-off-by: Alon Levy al...@redhat.com --- hw/qdev-monitor.c | 5 + 1 file changed, 5

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Andreas Färber
Am 28.11.2012 13:14, schrieb Luiz Capitulino: On Wed, 28 Nov 2012 13:02:26 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 28/11/2012 12:54, Luiz Capitulino ha scritto: On Wed, 28 Nov 2012 10:54:33 +0200 Alon Levy al...@redhat.com wrote: Instead of aborting immediately after at

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device not-a-device-type

2012-11-28 Thread Luiz Capitulino
On Wed, 28 Nov 2012 13:19:36 +0100 Andreas Färber afaer...@suse.de wrote: Am 28.11.2012 13:14, schrieb Luiz Capitulino: On Wed, 28 Nov 2012 13:02:26 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 28/11/2012 12:54, Luiz Capitulino ha scritto: On Wed, 28 Nov 2012 10:54:33 +0200

Re: [Qemu-devel] [PATCH 05/17] target-i386: cpu_x86_init(): move error handling to end of function

2012-11-28 Thread Eduardo Habkost
On Wed, Nov 28, 2012 at 02:08:01PM +0800, li guang wrote: 在 2012-11-12一的 19:38 -0200,Eduardo Habkost写道: Doing error handling on a single place will make it easier to make sure memory is freed, and that error information is properly printed or returned to the caller. Signed-off-by:

[Qemu-devel] kvm: let's add HYPERV capabilities (was Re: [PATCH 01/20] hyper-v: introduce Hyper-V support infrastructure.)

2012-11-28 Thread Michael S. Tsirkin
On Fri, Jan 20, 2012 at 03:26:27PM -0200, Marcelo Tosatti wrote: From: Vadim Rozenfeld vroze...@redhat.com [Jan: fix build with CONFIG_USER_ONLY] Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- Makefile.target |2 + target-i386/cpuid.c | 14 +++

[Qemu-devel] [PATCH] qxl: reload memslots after migration, when qxl is in UNDEFINED mode

2012-11-28 Thread Yonit Halperin
The devram memslot stays active when qxl enters UNDEFINED mode (i.e, no primary surface). If migration has occurred while the device is in UNDEFINED stae, the memslots have to be reloaded at the destination. Fixes rhbz#874574 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- hw/qxl.c | 1 +

[Qemu-devel] [PULL 1.3 0/5] SCSI updates for 1.3-rc2

2012-11-28 Thread Paolo Bonzini
Anthony, The following changes since commit 03a36f17d7788e4a1e07b3341b18028aa0206845: virtio-rng: do not use g_assert_cmpint (2012-11-27 08:51:07 -0600) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to

[Qemu-devel] [PATCH 2/5] iscsi: fix deadlock during login

2012-11-28 Thread Paolo Bonzini
From: Peter Lieven p...@dlhnet.de If the connection is interrupted before the first login is successfully completed qemu-kvm is waiting forever in qemu_aio_wait(). This is fixed by performing an sync login to the target. If the connection breaks after the first successful login errors are

[Qemu-devel] [PATCH 1/5] iscsi: fix segfault in url parsing

2012-11-28 Thread Paolo Bonzini
From: Peter Lieven p...@dlhnet.de If an invalid URL is specified iscsi_get_error(iscsi) is called with iscsi == NULL. Signed-off-by: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/iscsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 5/5] virtio-scsi: Fix subtle (guest) endian bug

2012-11-28 Thread Paolo Bonzini
From: David Gibson da...@gibson.dropbear.id.au The virtio-scsi config space is, by specification, in guest endian (which is ill-defined, but there you go). In virtio_scsi_get_config() we set up all the fields in there, using stl_raw(). Which is a problem for the max_channel and max_target

[Qemu-devel] [PATCH 1/2] nbd: fix use of two uninitialized bytes when connecting to a named export

2012-11-28 Thread Paolo Bonzini
Reported-by: Michal Privoznik mprivoz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd.c b/nbd.c index 97a5914..01976e8 100644 --- a/nbd.c +++ b/nbd.c @@ -397,6 +397,7 @@ static int

[Qemu-devel] [PULL 1.3 0/2] NBD updates for 1.3-rc2

2012-11-28 Thread Paolo Bonzini
Anthony, The following changes since commit c8969eded252058e90e91f12f75f32aceae46ec9: nbd: fixes to read-only handling (2012-11-13 10:34:50 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes up to

[Qemu-devel] [PATCH 2/2] nbd-server-add: Fix the default for 'writable'

2012-11-28 Thread Paolo Bonzini
From: Michal Privoznik mpriv...@redhat.com The documentation to this monitor command tells, that 'writable' argument is optional and defaults to false. However, the code sets true as the default. But since some applications may already been using this, it's safer to fix the code and not

[Qemu-devel] [PATCH 4/5] virtio-scsi: Fix some endian bugs with virtio-scsi

2012-11-28 Thread Paolo Bonzini
From: David Gibson da...@gibson.dropbear.id.au The virtio-scsi specification does not specify the correct endianness for fields in the request structure. It's therefore best to assume that it is guest native endian since that's the (stupid and poorly defined) norm in virtio. However, the qemu

[Qemu-devel] [PATCH 3/5] iscsi: do not assume device is zero initialized

2012-11-28 Thread Paolo Bonzini
From: Peter Lieven p...@dlhnet.de Without any complex checks we can't assume that an iscsi target is initialized to zero. Signed-off-by: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/iscsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 01/10] qemu-ga: guest_file_handle_find(): take an Error argument

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:01:55AM -0200, Luiz Capitulino wrote: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:01:56AM -0200, Luiz Capitulino wrote: fclose() returns EOF on error. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH v7 1/7] qom: apply atomic on object's refcount

2012-11-28 Thread Richard Henderson
On 11/24/2012 06:02 PM, Liu Ping Fan wrote: -obj-ref--; /* parent always holds a reference to its children */ -if (obj-ref == 0) { +if (__sync_fetch_and_sub(obj-ref, 1) == 1) { if (__sync_sub_and_fetch(obj-ref, 1) == 0) r~

Re: [Qemu-devel] PCI device pass through support

2012-11-28 Thread Alex Williamson
On Wed, 2012-11-28 at 16:32 +, Krishna J wrote: Hi Alex, I am trying to pass through a PCI device to the guest to compare the MSI interrupt latency with normal device pass through and pass through using VFIO framework. I used the following script for dev in $(ls

[Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext)

2012-11-28 Thread Ying-Chun Liu
Just a note. We still have this issue when building unity on ARM. It crashed when running msgmerge. ** Also affects: qemu-linaro Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] PCI device pass through support

2012-11-28 Thread Krishna J
Hi Alex, I am trying to pass through a PCI device to the guest to compare the MSI interrupt latency with normal device pass through and pass through using VFIO framework. I used the following script for dev in $(ls /sys/bus/pci/devices/:06:00.0/iommu_group/devices); do     vendor=$(cat

Re: [Qemu-devel] [PATCH v3 1.3] build: compile translate.o with -fno-gcse option on GCC 4.6.x and 4.7.[012]

2012-11-28 Thread Andreas Färber
Am 28.11.2012 09:40, schrieb Paolo Bonzini: These versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for default_x86_64_fedora16. Anyway this is a good thing to do

Re: [Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:01:57AM -0200, Luiz Capitulino wrote: Use error_setg_errno() when possible with an improved error description. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 22 +- 1 file changed, 13 insertions(+), 9

[Qemu-devel] [PATCH] iscsi: add support for iSCSI NOPs

2012-11-28 Thread Peter Lieven
This patch will send NOP-Out PDUs every 5 seconds to the iSCSI target. If a consecutive number of NOP-In replies fail a reconnect is initiated. iSCSI NOPs help to ensure that the connection to the target is still operational. This should not, but in reality may be the case even if the TCP

[Qemu-devel] [PATCH] target-arm: use type_register() instead of type_register_static()

2012-11-28 Thread Eduardo Habkost
The type_register_static() interface is documented as: type_register_static: @info: The #TypeInfo of the new type. @info and all of the strings it points to should exist for the life time that the type is registered. But cpu_register() uses a stack variable for the 'info' argument, so

Re: [Qemu-devel] [PATCH 04/10] qemu-ga: qmp_guest_shutdown(): improve error reporting

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:01:58AM -0200, Luiz Capitulino wrote: Most errors are QERR_UNDEFINED_ERROR. Also, adds ga_wait_child() as a future commit will use it too. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH] target-arm: use type_register() instead of type_register_static()

2012-11-28 Thread Peter Maydell
On 28 November 2012 19:20, Eduardo Habkost ehabk...@redhat.com wrote: The type_register_static() interface is documented as: type_register_static: @info: The #TypeInfo of the new type. @info and all of the strings it points to should exist for the life time that the type is

Re: [Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting

2012-11-28 Thread Luiz Capitulino
On Wed, 28 Nov 2012 11:54:45 -0600 mdroth mdr...@linux.vnet.ibm.com wrote: On Tue, Nov 27, 2012 at 11:01:57AM -0200, Luiz Capitulino wrote: Use error_setg_errno() when possible with an improved error description. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com ---

Re: [Qemu-devel] [PATCH 05/10] qemu-ga: build_fs_mount_list(): take an Error argument

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:01:59AM -0200, Luiz Capitulino wrote: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qga/commands-posix.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c

Re: [Qemu-devel] [PATCH 06/10] qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set()

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:02:00AM -0200, Luiz Capitulino wrote: Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c | 10 +++--- 1 file changed, 3 insertions(+), 7

Re: [Qemu-devel] [PATCH 07/10] qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set()

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:02:01AM -0200, Luiz Capitulino wrote: Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c | 10 +++--- 1 file changed, 3 insertions(+), 7

Re: [Qemu-devel] [PATCH 08/10] qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() + error_set()

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:02:02AM -0200, Luiz Capitulino wrote: Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c | 29 - 1 file changed, 8

Re: [Qemu-devel] [PATCH 09/10] qemu-ga: bios_supports_mode(): improve error reporting

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:02:03AM -0200, Luiz Capitulino wrote: Most errors are QERR_UNDEFINED_ERROR today. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c | 46

Re: [Qemu-devel] [PATCH 10/10] qemu-ga: guest_suspend(): improve error reporting

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:02:04AM -0200, Luiz Capitulino wrote: Most errors are QERR_UNDEFINED_ERROR today. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c | 29 ++--- 1 file

Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)

2012-11-28 Thread mdroth
On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote: This series revamps qemu-ga error messages by: - Propagating errors down to functions that generate errors - Fixing UndefinedErrors - Getting rid of sprint() + error_set() - Other small fixes Hi Luiz, Patches look good

Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)

2012-11-28 Thread mdroth
On Wed, Nov 28, 2012 at 02:04:31PM -0600, mdroth wrote: On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote: This series revamps qemu-ga error messages by: - Propagating errors down to functions that generate errors - Fixing UndefinedErrors - Getting rid of sprint() +

Re: [Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting

2012-11-28 Thread Eric Blake
if (ferror(fh)) { +error_setg_errno(err, errno, failed to read file); slog(guest-file-read failed, handle: %ld, handle); -error_set(err, QERR_QGA_COMMAND_FAILED, fread() failed); } else { I'm not sure about relying on errno for FILE/f*()

Re: [Qemu-devel] [PATCH v3 1.3] build: compile translate.o with -fno-gcse option on GCC 4.6.x and 4.7.[012]

2012-11-28 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: These versions of GCC require insane (2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for default_x86_64_fedora16. Anyway this is a good thing to do

Re: [Qemu-devel] [PATCH] event notifier: Fix setup for win32

2012-11-28 Thread Anthony Liguori
Jan Kiszka jan.kis...@siemens.com writes: The event notifier state is only reset by test_and_clear. But we created the windows event object with auto-reset, which subtly swallowed events. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Applied. Thanks. Regards, Anthony Liguori ---

Re: [Qemu-devel] [PULL 1.3 0/2] NBD updates for 1.3-rc2

2012-11-28 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Anthony, The following changes since commit c8969eded252058e90e91f12f75f32aceae46ec9: nbd: fixes to read-only handling (2012-11-13 10:34:50 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to

Re: [Qemu-devel] [PULL 1.3 0/2] s390 1.3 patch queue 2012-11-26

2012-11-28 Thread Anthony Liguori
Alexander Graf ag...@suse.de writes: Hi Blue / Aurelien, This is my current patch queue for s390 with patches that should go in for 1.3. Please pull. Alex Pulled. Thanks. Regards, Anthony Liguori The following changes since commit cab1e8f3e37d8e883c270e3afd9c7c1c18332f0e:

Re: [Qemu-devel] [PULL 1.3 0/6] ppc 1.3 patch queue 2012-11-26

2012-11-28 Thread Anthony Liguori
Alexander Graf ag...@suse.de writes: Hi Blue / Aurelien, This is my patch queue for ppc with patches that should go into 1.3. Please pull. Pulled. Thanks. Regards, Anthony Liguori Alex The following changes since commit cab1e8f3e37d8e883c270e3afd9c7c1c18332f0e: Anthony Liguori

Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-28 Thread Auld, Will
Thanks Amos. From: Amos Kong [mailto:kongjian...@gmail.com] Sent: Tuesday, November 27, 2012 6:39 PM To: Auld, Will Cc: Marcelo Tosatti; k...@vger.kernel.org; Dugger, Donald D; Liu, Jinsong; Zhang, Xiantao; a...@redhat.com; qemu-devel; Gleb Subject: Re: [PATCH V5 2/2] Enabling IA32_TSC_ADJUST

Re: [Qemu-devel] [PULL 1.3 0/5] SCSI updates for 1.3-rc2

2012-11-28 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Anthony, The following changes since commit 03a36f17d7788e4a1e07b3341b18028aa0206845: virtio-rng: do not use g_assert_cmpint (2012-11-27 08:51:07 -0600) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-28 Thread Michael S. Tsirkin
On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote: On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced a regression in virtio-net performance because it looks into the ring aggressively while we

Re: [Qemu-devel] [PULL for-1.3] QOM CPUState patch queue 2012-11-26

2012-11-28 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Hello Anthony, As discussed, here's two bugfixes for x86 CPUs. Please pull for rc1. Regards, Andreas Cc: Eduardo Habkost ehabk...@redhat.com Cc: Igor Mammedov imamm...@redhat.com Cc: Aurélien Jarno aurel...@aurel32.net Pulled. Thanks. Regards,

Re: [Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting

2012-11-28 Thread mdroth
On Wed, Nov 28, 2012 at 04:26:29PM -0500, Eric Blake wrote: if (ferror(fh)) { +error_setg_errno(err, errno, failed to read file); slog(guest-file-read failed, handle: %ld, handle); -error_set(err, QERR_QGA_COMMAND_FAILED, fread() failed);

[Qemu-devel] [PATCH 1.3] ehci-sysbus: Attach DMA context.

2012-11-28 Thread Peter Crosthwaite
This was left as NULL on the initial merge due to debate on the mailing list on how to handle DMA contexts for sysbus devices. Patch 9e11908f12f92e31ea94dc2a4c962c836cba9f2a was later merged to fix OHCI. This is the, equivalent fix for sysbus EHCI. Signed-off-by: Peter Crosthwaite

Re: [Qemu-devel] [PATCH 1.3] ehci-sysbus: Attach DMA context.

2012-11-28 Thread walimis
On Thu, Nov 29, 2012 at 11:43:18AM +1000, Peter Crosthwaite wrote: This was left as NULL on the initial merge due to debate on the mailing list on how to handle DMA contexts for sysbus devices. Patch 9e11908f12f92e31ea94dc2a4c962c836cba9f2a was later merged to fix OHCI. This is the, equivalent

Re: [Qemu-devel] [PATCH 1.3] ehci-sysbus: Attach DMA context.

2012-11-28 Thread Peter Crosthwaite
On Thu, Nov 29, 2012 at 12:00 PM, walimis walimis...@gmail.com wrote: On Thu, Nov 29, 2012 at 11:43:18AM +1000, Peter Crosthwaite wrote: This was left as NULL on the initial merge due to debate on the mailing list on how to handle DMA contexts for sysbus devices. Patch

Re: [Qemu-devel] [PATCH] m25p80: Fix wrong jedec id for Numonyx n25q128

2012-11-28 Thread walimis
On Tue, Nov 20, 2012 at 02:32:33PM +1000, Peter Crosthwaite wrote: Hi Liming, On Mon, Nov 19, 2012 at 11:03 PM, Liming Wang walimis...@gmail.com wrote: The jedec id of n25q128 should be 0x20bb18, not 0x20ba18. Signed-off-by: Liming Wang walimis...@gmail.com --- hw/m25p80.c |2 +- 1

Re: [Qemu-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-11-28 Thread Xu, Dongxiao
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Tuesday, September 18, 2012 6:24 PM To: Xu, Dongxiao Cc: Stefano Stabellini; xen-de...@lists.xensource.com; Ian Jackson; qemu-devel@nongnu.org; Keir (Xen.org) Subject: RE: [PATCH 0/2]

[Qemu-devel] [PATCH 0/3] target-i386:define bit name of dr7

2012-11-28 Thread li guang
dr7 register's breakpoint fields didn't be well defined, instead, just represented by 0,1,2,4, that's pretty implicit, so, try to clarify them, and related changes are made also. target-i386/cpu.h | 15 + target-i386/helper.c | 52 +++-

[Qemu-devel] [PATCH 1/3] define name for some fields of dr7

2012-11-28 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- target-i386/cpu.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 90ef1ff..7f292e6 100644 --- a/target-i386/cpu.h +++ b/target-i386/cpu.h @@ -558,6 +558,19 @@

[Qemu-devel] [PATCH 3/3] target-i386:refactor check_hw_breakpoints function

2012-11-28 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- target-i386/helper.c | 28 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 9ca52a7..a506df0 100644 --- a/target-i386/helper.c +++

  1   2   >