Re: [Qemu-devel] [PATCH V17 1/6] docs: document for add-cow file format

2012-12-11 Thread Dong Xu Wang
On Mon, Dec 10, 2012 at 11:39 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.12.2012 07:51, schrieb Dong Xu Wang: Document for add-cow format, the usage and spec of add-cow are introduced. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- docs/specs/add-cow.txt | 154

Re: [Qemu-devel] [PATCH V17 6/6] qemu-iotests: add add-cow iotests support.

2012-12-11 Thread Dong Xu Wang
On Tue, Dec 11, 2012 at 1:15 AM, Kevin Wolf kw...@redhat.com wrote: Am 06.12.2012 07:51, schrieb Dong Xu Wang: This patch will use qemu-iotests to test add-cow file format. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- tests/qemu-iotests/017 |2 +-

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/19] openpic: add Shared MSI support

2012-12-11 Thread Alexander Graf
On 11.12.2012, at 01:36, Scott Wood scottw...@freescale.com wrote: On 12/08/2012 07:44:39 AM, Alexander Graf wrote: The OpenPIC allows MSI access through shared MSI registers. Implement them for the MPC8544 MPIC, so we can support MSIs. Signed-off-by: Alexander Graf ag...@suse.de ---

Re: [Qemu-devel] [PATCH V17 5/6] add-cow file format core code.

2012-12-11 Thread Dong Xu Wang
On Tue, Dec 11, 2012 at 1:54 AM, Kevin Wolf kw...@redhat.com wrote: Am 06.12.2012 07:51, schrieb Dong Xu Wang: add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. v16-v17: 1) Use stringify. v15-v16: 1) Judge if opts is null in

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/19] mpic: Unify numbering scheme

2012-12-11 Thread Alexander Graf
On 11.12.2012, at 00:34, Scott Wood scottw...@freescale.com wrote: On 12/08/2012 07:44:25 AM, Alexander Graf wrote: MPIC interrupt numbers in Linux (device tree) and in QEMU are different, because QEMU takes the sparseness of the IRQ number space into account. Remove that cleverness and

Re: [Qemu-devel] [Qemu-ppc] [PATCH 10/19] openpic: remove unused type variable

2012-12-11 Thread Alexander Graf
On 11.12.2012, at 00:42, Scott Wood scottw...@freescale.com wrote: On 12/08/2012 07:44:33 AM, Alexander Graf wrote: The openpic source irqs are carrying around a type indicator that is never accessed by anything. Remove it. Signed-off-by: Alexander Graf ag...@suse.de --- hw/openpic.c |

Re: [Qemu-devel] [PATCH 14/19] openpic: convert to qdev

2012-12-11 Thread Alexander Graf
On 11.12.2012, at 00:47, Scott Wood scottw...@freescale.com wrote: On 12/08/2012 07:44:37 AM, Alexander Graf wrote: This patch converts the OpenPIC device to qdev. Along the way it renames the openpic target to raven and the mpic target to mpc8544, to better reflect the actual models they

Re: [Qemu-devel] [PATCH V17 4/6] rename qcow2-cache.c to block-cache.c

2012-12-11 Thread Dong Xu Wang
On Tue, Dec 11, 2012 at 1:11 AM, Kevin Wolf kw...@redhat.com wrote: Am 06.12.2012 07:51, schrieb Dong Xu Wang: We will re-use qcow2-cache as block layer common cache code, so change its name and made some changes, define a struct named BlockTableType, pass BlockTableType and table size

Re: [Qemu-devel] Network isn't clean when qemu exits

2012-12-11 Thread Stefan Hajnoczi
On Tue, Dec 11, 2012 at 01:57:04PM +0800, Amos Kong wrote: In vl.c:main(), tap device would be created when net_init_clients() is called. device option is parsed after calling net_init_clients() by: # qemu_opts_foreach(qemu_find_opts(device), device_init_func, NULL, 1) Qemu will exit if

Re: [Qemu-devel] [PATCH qom-cpu 3/4] Really finally kill cpudef config section support

2012-12-11 Thread Wenchao Xia
于 2012-12-11 7:53, Eduardo Habkost 写道: On Tue, Dec 11, 2012 at 12:12:23AM +0100, Andreas Färber wrote: Am 10.12.2012 19:09, schrieb Eduardo Habkost: On Sun, Dec 09, 2012 at 08:45:52PM +0100, Andreas Färber wrote: Commit 511c68d3af626cb0a39034cb77e7ac64d3a26c0c (finally kill cpudef config

Re: [Qemu-devel] [PATCH V7 00/10] replace QEMUOptionParameter with QemuOpts parser

2012-12-11 Thread Stefan Hajnoczi
On Thu, Dec 06, 2012 at 02:47:17PM +0800, Dong Xu Wang wrote: Patch 1-3 are from Luiz, added Markus's comments, discussion could be found here: http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html Patch 3 was changed according Paolo's comments. Patch 4-5: because

Re: [Qemu-devel] [PATCH v6 00/12] virtio: virtio-blk data plane

2012-12-11 Thread Stefan Hajnoczi
This morning I found the following unstaged change in my working tree, it should have been part of [PATCH v6 10/12] virtio-blk: restore VirtIOBlkConf-config_wce flag: diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index c60b89a..32cc910 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -895,6

Re: [Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png produces garbled output

2012-12-11 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 03:54:58PM -, Tim Hardeck wrote: 47683d669f993308c2b84bed4ce64aafb5d7ced4 is the first bad commit commit 47683d669f993308c2b84bed4ce64aafb5d7ced4 Author: Gerd Hoffmann kra...@redhat.com Date: Thu Oct 11 12:04:33 2012 +0200 pixman/vnc: remove

Re: [Qemu-devel] [PATCH V17 4/6] rename qcow2-cache.c to block-cache.c

2012-12-11 Thread Kevin Wolf
Am 11.12.2012 09:25, schrieb Dong Xu Wang: On Tue, Dec 11, 2012 at 1:11 AM, Kevin Wolf kw...@redhat.com wrote: Am 06.12.2012 07:51, schrieb Dong Xu Wang: We will re-use qcow2-cache as block layer common cache code, so change its name and made some changes, define a struct named

Re: [Qemu-devel] [PATCH V17 5/6] add-cow file format core code.

2012-12-11 Thread Kevin Wolf
Am 11.12.2012 09:11, schrieb Dong Xu Wang: index bf5c57c..1a30462 100644 --- a/block/block-cache.c +++ b/block/block-cache.c @@ -112,6 +112,8 @@ static int block_cache_entry_flush(BlockDriverState *bs, BlockCache *c, int i) BLKDBG_EVENT(bs-file, BLKDBG_REFBLOCK_UPDATE_PART);

Re: [Qemu-devel] [RFC 0/4] virtio: stabilize migration format

2012-12-11 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 08:29:46AM -0600, Anthony Liguori wrote: This series replaces: qemu_put_buffer(f, (unsigned char*)req-elem, sizeof(req-elem)); With code that properly saves out each element of the structure using a well defined endian format. Migration is broken today from big

Re: [Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png produces garbled output

2012-12-11 Thread Gerd Hoffmann
On 12/11/12 09:57, Stefan Hajnoczi wrote: On Mon, Dec 10, 2012 at 03:54:58PM -, Tim Hardeck wrote: 47683d669f993308c2b84bed4ce64aafb5d7ced4 is the first bad commit commit 47683d669f993308c2b84bed4ce64aafb5d7ced4 Author: Gerd Hoffmann kra...@redhat.com Date: Thu Oct 11 12:04:33 2012

Re: [Qemu-devel] [PATCH v6] Add compare subcommand for qemu-img

2012-12-11 Thread Stefan Hajnoczi
On Thu, Dec 06, 2012 at 07:24:04AM -0500, Miroslav Rezanina wrote: This is second version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size,

Re: [Qemu-devel] What is the current state of the various usb implementations?

2012-12-11 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 11:38:21AM -0500, tom289...@safe-mail.net wrote: Hello, I sent this to qemu-discuss a week ago and got no responses, so I'm trying here. Looking at `qemu-kvm -device ?`, there seem to be multiple usb implementations: ich9-usb-uhci2 ich9-usb-uhci3

Re: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call

2012-12-11 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 12:56:22PM +0100, Fabien Chouteau wrote: An error has occurred if the return value is invalid_set_file_pointer and getlasterror doesn't return no_error. Signed-off-by: Fabien Chouteau chout...@adacore.com --- block/raw-win32.c | 17 ++--- 1 file

Re: [Qemu-devel] What is the current state of the various usb implementations?

2012-12-11 Thread Zhi Yong Wu
HI, Since the slides have been there, why would nobody like to export them on http://www.linux-kvm.org/page/KVM_Forum_2012? If so, we can download or review them. On Tue, Dec 11, 2012 at 5:03 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Dec 10, 2012 at 11:38:21AM -0500,

Re: [Qemu-devel] [PATCH 1/1] seabios: update to e8a76b0f225bba5ba9d63ab227e0a37b3beb1059

2012-12-11 Thread Alexandre DERUMIER
Thanks Gerd, This fix also my win2003 R2 SP2 x64 acpi bsod with hpet enabled Regards, Alexandre - Mail original - De: Gerd Hoffmann kra...@redhat.com À: qemu-devel@nongnu.org Cc: Gerd Hoffmann kra...@redhat.com, qemu-sta...@nongnu.org Envoyé: Mardi 11 Décembre 2012 08:34:12 Objet:

Re: [Qemu-devel] buildbot failure in qemu on virtfs_x86_64_debian_6_0

2012-12-11 Thread Stefan Hajnoczi
On Thu, Dec 06, 2012 at 08:19:24PM +0530, Aneesh Kumar K.V wrote: q...@buildbot.b1-systems.de writes: The Buildbot has detected a new failure on builder virtfs_x86_64_debian_6_0 while building qemu. Full details are available at:

Re: [Qemu-devel] [PATCH] net, hub: fix the indent in the comments

2012-12-11 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 09:43:18AM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Remove some redundant blanks in the comments of net_hub_id_for_client(). Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/hub.c |2 +- 1 files changed, 1

Re: [Qemu-devel] buildbot failure in qemu on virtfs_x86_64_debian_6_0

2012-12-11 Thread Daniel Gollub
On Tuesday, December 11, 2012 10:34:34 AM Stefan Hajnoczi wrote: On Thu, Dec 06, 2012 at 08:19:24PM +0530, Aneesh Kumar K.V wrote: q...@buildbot.b1-systems.de writes: The Buildbot has detected a new failure on builder virtfs_x86_64_debian_6_0 while building qemu. Full details are

Re: [Qemu-devel] [ [PATCH 1/2] cutils:change strtosz_suffix_unit function

2012-12-11 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 11:49:49AM +0800, liguang wrote: if value to be translated is larger than INT64_MAX, this function will not be convenient for caller to be aware of it, so change a little for this. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- cutils.c |5 +++-- 1 files

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-12-11 Thread Heinz Graalfs
Hi Kevin, I'm using the bdrv_pread() function during boot partition detection ... In detail: bdrv_pread() is called to read 32 bytes from a 2048 bytes formatted disk. This results in setting up a read of 512 bytes (1 sector multiplied by 512 current code in paio_submit()), which is wrong for a

Re: [Qemu-devel] [PATCH 1/2] pseries: Don't allow TCE (iommu) tables to be registered with duplicate LIOBNs

2012-12-11 Thread Alexander Graf
On 10.12.2012, at 14:00, Michael S. Tsirkin wrote: On Tue, Nov 27, 2012 at 05:07:32PM +1100, David Gibson wrote: The PAPR specification requires that every bus or device mediated by the IOMMU have a unique Logical IO Bus Number (LIOBN). This patch adds a check to enforce this, which will

Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

2012-12-11 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote: Thanks for addressing my review comments. @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque) void vnc_write(VncState *vs, const void *data, size_t len) { -buffer_reserve(vs-output, len); +

Re: [Qemu-devel] KVM call agenda for 2012-12-11

2012-12-11 Thread Kevin Wolf
Am 10.12.2012 14:59, schrieb Juan Quintela: Hi Please send in any agenda topics you are interested in. Can probably be answered on the list, but what is the status of libqos? Kevin

Re: [Qemu-devel] main-loop.c: About Select handling

2012-12-11 Thread Stefan Hajnoczi
On Thu, Dec 06, 2012 at 12:30:19AM +, Furukawa, Eiji wrote: The select() do not masked signal in os_host_main_loop_wait. For example, qemu-timer.c gives SIGALRM regularly. Even if a buffer of select is empty, What does a buffer of select is empty mean? I think that it is a problem

[Qemu-devel] [PATCH 3/6] target-i386: explicitly set vendor for each built-in cpudef

2012-12-11 Thread Igor Mammedov
it will help to get rid of setting default. Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 64b7637..1497980 100644 ---

[Qemu-devel] [PATCH 5/6] target-i386: move setting defaults out of cpu_x86_parse_featurestr()

2012-12-11 Thread Igor Mammedov
No functional change, needed for simplifying convertion to properties. Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 99fd3f3..e534254 100644

[Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png produces garbled output

2012-12-11 Thread Tim Hardeck
* make sure that qemu is compiled with --enable-vnc-png * git clone git://github.com/kanaka/noVNC * edit include/rfb.js at line 50 and comment out or remove all encodings above ['TIGHT_PNG',-260 ], * open vnc.html in Firefox or Chrome *apply either my patch to QEMU

Re: [Qemu-devel] [PATCH 4/8] s390: Add channel I/O instructions.

2012-12-11 Thread Alexander Graf
On 10.12.2012, at 10:18, Cornelia Huck wrote: On Mon, 10 Dec 2012 10:00:16 +0100 Alexander Graf ag...@suse.de wrote: On 07.12.2012, at 13:50, Cornelia Huck cornelia.h...@de.ibm.com wrote: Provide handlers for (most) channel I/O instructions. Signed-off-by: Cornelia Huck

[Qemu-devel] [PATCH 0/6] x86 CPU cleanup (wave 2)

2012-12-11 Thread Igor Mammedov
This series is a several cleanups, moved out from CPU properties series, since they do not really depend on CPU properties refactoring and could simplify CPU subclasses work as well. git tree for testing: https://github.com/imammedo/qemu/tree/x86_cpu_cleanup.wave2 Igor Mammedov (6):

Re: [Qemu-devel] [Bug 1087114] [NEW] assertion QLIST_EMPTY(bs-tracked_requests) failed

2012-12-11 Thread Stefan Hajnoczi
On Thu, Dec 06, 2012 at 04:02:57AM -, Brad Smith wrote: QEMU 1.3.0 on OpenBSD now crashes with an error as shown below and the command line params do not seem to matter. Please use git-bisect(1) to identify the commit that caused the regression. I was unable to hit this code path with

Re: [Qemu-devel] [PATCH 2/8] s390: Channel I/O basic defintions.

2012-12-11 Thread Alexander Graf
On 10.12.2012, at 11:18, Cornelia Huck wrote: On Mon, 10 Dec 2012 09:07:57 +0100 Alexander Graf ag...@suse.de wrote: On 07.12.2012, at 13:50, Cornelia Huck wrote: Basic channel I/O structures and helper function. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

Re: [Qemu-devel] [PATCH 3/8] s390: I/O interrupt and machine check injection.

2012-12-11 Thread Alexander Graf
On 10.12.2012, at 11:27, Cornelia Huck wrote: On Mon, 10 Dec 2012 09:20:57 +0100 Alexander Graf ag...@suse.de wrote: On 07.12.2012, at 13:50, Cornelia Huck wrote: I/O interrupts are queued per isc. Only crw pending machine checks are supported. Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-12-11 Thread Kevin Wolf
Am 11.12.2012 10:58, schrieb Heinz Graalfs: Hi Kevin, I'm using the bdrv_pread() function during boot partition detection ... In detail: bdrv_pread() is called to read 32 bytes from a 2048 bytes formatted disk. This results in setting up a read of 512 bytes (1 sector multiplied by 512

Re: [Qemu-devel] What is the current state of the various usb implementations?

2012-12-11 Thread Gerd Hoffmann
On 12/10/12 17:38, tom289...@safe-mail.net wrote: Hello, I sent this to qemu-discuss a week ago and got no responses, so I'm trying here. Looking at `qemu-kvm -device ?`, there seem to be multiple usb implementations: ich9-usb-uhci2 ich9-usb-uhci3 ich9-usb-uhci1 piix3-usb-uhci

Re: [Qemu-devel] [PATCH 1/3] s390: Fix empty kernel command line

2012-12-11 Thread Alexander Graf
On 07.12.2012, at 14:55, Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com Since commit 967c0da73a7b0da186baba6632301d83644a570c vl.c: Avoid segfault when started with no arguments the user can specify a kernel without a command line. Lets not overwrite the

Re: [Qemu-devel] [PATCH 2/3] s390: Move IPL code into a separate device

2012-12-11 Thread Alexander Graf
On 07.12.2012, at 14:55, Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW appropriately - enhance the boot

[Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time

2012-12-11 Thread Igor Mammedov
when CPU properties are implemented, ext2_features may change between object_new(CPU) and cpu_realize_fn(). Sanitizing ext2_features for AMD based CPU at realize() time will keep current behavior after CPU features are converted to properties. Signed-off-by: Igor Mammedov imamm...@redhat.com ---

[Qemu-devel] [PATCH 4/6] target-i386: setting default 'vendor' is obsolete, remove it

2012-12-11 Thread Igor Mammedov
since cpu_def config is not supported anymore and all remainig sources now always set x86_def_t.vendor[123] fields remove setting default vendor to simplify future refactoring. Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 13 - 1 files changed, 4

Re: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call

2012-12-11 Thread Kevin Wolf
Am 11.12.2012 10:21, schrieb Stefan Hajnoczi: On Mon, Dec 10, 2012 at 12:56:22PM +0100, Fabien Chouteau wrote: An error has occurred if the return value is invalid_set_file_pointer and getlasterror doesn't return no_error. Signed-off-by: Fabien Chouteau chout...@adacore.com ---

[Qemu-devel] [PATCH 1/6] target-i386: filter out not TCG features if running without kvm at realize time

2012-12-11 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 31 --- 1 files changed, 16 insertions(+), 15 deletions(-) diff --git a/target-i386/cpu.c

Re: [Qemu-devel] [PATCH 8/8] s390: Add new channel I/O based virtio transport.

2012-12-11 Thread Alexander Graf
On 07.12.2012, at 13:50, Cornelia Huck wrote: Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that uses this virtio-ccw transport and make it the default machine for s390. Signed-off-by: Cornelia Huck

[Qemu-devel] [PATCH 6/6] target-i386: move out CPU features initialization in separate func

2012-12-11 Thread Igor Mammedov
No functional change, a simple code movement to simplify following refactoring. Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: - rebased on top of i386: cpu: remove duplicate feature names http://www.mail-archive.com/qemu-devel@nongnu.org/msg129458.html v3: - rebased on top

Re: [Qemu-devel] [RFC/PATCH 0/2] ipl device followup

2012-12-11 Thread Alexander Graf
On 07.12.2012, at 16:14, Christian Borntraeger wrote: Alex, here is were the IPL device code would move into. Some rough edges are still there, but it can ipl almost anything that was zipled under LPAR/VM. Please try and check how nicely this can be done if we would map a firmware blob

Re: [Qemu-devel] [PATCH 1/3] s390: Fix empty kernel command line

2012-12-11 Thread Christian Borntraeger
On 11/12/12 11:34, Alexander Graf wrote: On 07.12.2012, at 14:55, Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com Since commit 967c0da73a7b0da186baba6632301d83644a570c vl.c: Avoid segfault when started with no arguments the user can specify a kernel without a

Re: [Qemu-devel] [PATCH 1/3] s390: Fix empty kernel command line

2012-12-11 Thread Alexander Graf
On 11.12.2012, at 12:15, Christian Borntraeger wrote: On 11/12/12 11:34, Alexander Graf wrote: On 07.12.2012, at 14:55, Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com Since commit 967c0da73a7b0da186baba6632301d83644a570c vl.c: Avoid segfault when started

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-11 Thread Jamie Lokier
Matthew Ogilvie wrote: 2. Just fix it immediately, and don't worry about migration. Squash the last few patches together. A single missed periodic timer tick that only happens when migrating between versions of qemu is probably not a significant concern. (Unless someone knows

[Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png produces garbled output

2012-12-11 Thread Tim Hardeck
** Attachment added: screenshot of the issue https://bugs.launchpad.net/qemu/+bug/1087974/+attachment/3457223/+files/tight-png-compression-issue.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 1/3] s390: Fix empty kernel command line

2012-12-11 Thread Christian Borntraeger
On 11/12/12 12:19, Alexander Graf wrote: On 11.12.2012, at 12:15, Christian Borntraeger wrote: On 11/12/12 11:34, Alexander Graf wrote: On 07.12.2012, at 14:55, Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com Since commit 967c0da73a7b0da186baba6632301d83644a570c

Re: [Qemu-devel] [RFC V3 01/24] qcow2: Add deduplication to the qcow2 specification.

2012-12-11 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 02:05:00PM +0100, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- docs/specs/qcow2.txt | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index

Re: [Qemu-devel] [RFC V3 01/24] qcow2: Add deduplication to the qcow2 specification.

2012-12-11 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 02:05:00PM +0100, Benoît Canet wrote: +== Deduplication table == + +The deduplication table contains 64 bits offsets to the level 2 deduplication +table clusters. +Each entry of these clusters contains a 32 bytes SHA256 hash followed by the +64 bits logical offset of

Re: [Qemu-devel] [RFC V3 02/24] qcow2: Add deduplication structures and fields.

2012-12-11 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 02:05:01PM +0100, Benoît Canet wrote: diff --git a/block/qcow2.h b/block/qcow2.h index b4eb654..e192001 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -58,6 +58,23 @@ #define DEFAULT_CLUSTER_SIZE 65536 +/* deduplication node */ +typedef struct { +

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread Luiz Capitulino
On Tue, 11 Dec 2012 05:12:29 + Dietmar Maurer diet...@proxmox.com wrote: Can't we enable stat queries by default (10s interval), I'm not sure I like this for two reasons. First, there will be cases where the user doesn't want this to be enabled. Second, we'll be forcing an interval on

Re: [Qemu-devel] [PATCH] target-arm: fix target CPUs on ARM GIC

2012-12-11 Thread Peter Maydell
On 10 December 2012 03:32, d...@ertl.jp wrote: Fix a bug on the ARM GIC model where interrupts are not set pending on the correct target CPUs when they are triggered by writes to the Interrupt Set Enable or Set Pending registers. Signed-off-by: Daniel Sangorrin d...@ertl.jp Reviewed-by:

Re: [Qemu-devel] [RFC V3 03/24] qcow2: Add qcow2_dedup_read_missing_and_concatenate

2012-12-11 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 02:05:02PM +0100, Benoît Canet wrote: +/** + * Read some data from the QCOW2 file + * + * @data: the buffer where the data must be stored + * @sector_num: the sector number to read in the QCOW2 file + * @nb_sectors: the number of sectors to read + * @ret:

Re: [Qemu-devel] [PATCH v2] exynos4210/mct: Avoid infinite loop on non incremental timers

2012-12-11 Thread Peter Maydell
On 3 December 2012 22:55, Jean-Christophe DUBOIS j...@tribudubois.net wrote: Check for a 0 distance value to avoid infinite loop when the expired FCR timer was not programed with auto-increment. With this change the behavior is coherent with the same type of code in the

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread Dietmar Maurer
Can't we enable stat queries by default (10s interval), I'm not sure I like this for two reasons. First, there will be cases where the user doesn't want this to be enabled. Second, we'll be forcing an interval on users. OK. and simply return all stats with one API call (query-ballon)?

Re: [Qemu-devel] [PATCH 8/8] s390: Add new channel I/O based virtio transport.

2012-12-11 Thread Christian Borntraeger
On 11/12/12 11:53, Alexander Graf wrote: On 07.12.2012, at 13:50, Cornelia Huck wrote: Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that uses this virtio-ccw transport and make it the default machine for s390.

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread Luiz Capitulino
On Tue, 11 Dec 2012 12:05:32 + Dietmar Maurer diet...@proxmox.com wrote: and simply return all stats with one API call (query-ballon)? We can't use query-balloon because this changes query-balloon from synchronous to asynchronous, and this is an incompatible change. Why don't we

Re: [Qemu-devel] [PATCH 3/8] s390: I/O interrupt and machine check injection.

2012-12-11 Thread Cornelia Huck
On Mon, 10 Dec 2012 18:26:28 -0600 Rob Landley r...@landley.net wrote: What do you actually use to run Linux under this target? There are some leads at http://virtuallyfun.superglobalmegacorp.com/?p=1206 which more or less leads to

Re: [Qemu-devel] [PATCH v6] Add compare subcommand for qemu-img

2012-12-11 Thread Kevin Wolf
Am 06.12.2012 13:24, schrieb Miroslav Rezanina: This is second version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size, exceeding part of bigger

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread Dietmar Maurer
Can't we enable stat queries by default (10s interval), I'm not sure I like this for two reasons. First, there will be cases where the user doesn't want this to be enabled. Second, we'll be forcing an interval on users. So when should we set the stats-polling-interval? I first thought I

[Qemu-devel] [PULL 0/2] migration queue

2012-12-11 Thread Juan Quintela
Hi Anthony, this fixes two errors on the migration code, could you pull? Thanks, Juan. The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 08:35:15 -0600) are available in the git repository

[Qemu-devel] [PATCH 2/2] migration: Fix madvise breakage if host and guest have different page sizes

2012-12-11 Thread Juan Quintela
From: David Gibson da...@gibson.dropbear.id.au madvise(DONTNEED) will throw away the contents of the whole page at the given address, even if the given length is less than the page size. One can argue about whether that's the correct behaviour, but that's what it's done for a long time in Linux

[Qemu-devel] [PATCH 1/2] Fix off-by-1 error in RAM migration code

2012-12-11 Thread Juan Quintela
From: David Gibson da...@gibson.dropbear.id.au The code for migrating (or savevm-ing) memory pages starts off by creating a dirty bitmap and filling it with 1s. Except, actually, because bit addresses are 0-based it fills every bit except bit 0 with 1s and puts an extra 1 beyond the end of the

[Qemu-devel] [PATCH 07/35] migration: make writes blocking

2012-12-11 Thread Juan Quintela
Move all the writes to the migration_thread, and make writings blocking. Notice that are still using the iothread for everything that we do. Signed-off-by: Juan Quintela quint...@redhat.com --- migration-exec.c | 1 - migration-fd.c | 1 - migration-tcp.c | 1 + migration-unix.c | 1 +

[Qemu-devel] [PATCH 15/35] migration-fd: remove duplicate include

2012-12-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration-fd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration-fd.c b/migration-fd.c index 487b17e..77aef6d 100644 --- a/migration-fd.c +++ b/migration-fd.c @@ -20,7 +20,6 @@ #include qemu-char.h #include qemu-file.h #include

[Qemu-devel] [PATCH 35/35] migration: print times for end phase

2012-12-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block.c | 6 ++ cpus.c | 17 + migration.c | 12 savevm.c| 13 + 4 files changed, 48 insertions(+) diff --git a/block.c b/block.c index c05875f..2fa0827 100644 --- a/block.c +++

[Qemu-devel] [PATCH 16/35] migration: move buffered_file.c code into migration.c

2012-12-11 Thread Juan Quintela
This only moves the code (also from buffered_file.h to migration.h). Fix whitespace until checkpatch is happy. Signed-off-by: Juan Quintela quint...@redhat.com --- Makefile.objs | 2 +- buffered_file.c | 259 buffered_file.h | 22

[Qemu-devel] [PATCH 23/35] migration: unfold rest of migrate_fd_put_ready() into thread

2012-12-11 Thread Juan Quintela
This will allow us finer control in next patches. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 95 ++--- 1 file changed, 41 insertions(+), 54 deletions(-) diff --git a/migration.c b/migration.c index 5c2f413..7a4a6f0

[Qemu-devel] [PATCH 28/35] migration: Only go to the iterate stage if there is anything to send

2012-12-11 Thread Juan Quintela
Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 7a4a6f0..216356d 100644 --- a/migration.c +++ b/migration.c @@ -709,7 +709,7 @@

[Qemu-devel] [PATCH 22/35] migration: move exit condition to migration thread

2012-12-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/migration.c b/migration.c index 031302b..5c2f413 100644 --- a/migration.c +++ b/migration.c @@ -676,12 +676,6 @@ static bool

[Qemu-devel] [PATCH 26/35] memory: introduce memory_region_test_and_clear_dirty

2012-12-11 Thread Juan Quintela
This function avoids having to do two calls, one to test the dirty bit, and other to reset it. Signed-off-by: Juan Quintela quint...@redhat.com --- memory.c | 16 memory.h | 16 2 files changed, 32 insertions(+) diff --git a/memory.c b/memory.c index

[Qemu-devel] [PATCH 21/35] migration: Add buffered_flush error handling

2012-12-11 Thread Juan Quintela
Now that we have error handling we can do proper handling of buffered_flush(). Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 336941b..031302b 100644 --- a/migration.c +++

Re: [Qemu-devel] [PATCH 2/8] s390: Channel I/O basic defintions.

2012-12-11 Thread Cornelia Huck
On Tue, 11 Dec 2012 11:27:05 +0100 Alexander Graf ag...@suse.de wrote: On 10.12.2012, at 11:18, Cornelia Huck wrote: On Mon, 10 Dec 2012 09:07:57 +0100 Alexander Graf ag...@suse.de wrote: On 07.12.2012, at 13:50, Cornelia Huck wrote: Basic channel I/O structures and helper

[Qemu-devel] [PATCH 30/35] ram: account the amount of transferred ram better

2012-12-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/arch_init.c b/arch_init.c index 6c12a7d..3e82588 100644 --- a/arch_init.c +++ b/arch_init.c @@ -265,16 +265,21 @@ uint64_t

Re: [Qemu-devel] [PATCH 4/8] s390: Add channel I/O instructions.

2012-12-11 Thread Cornelia Huck
On Tue, 11 Dec 2012 11:18:44 +0100 Alexander Graf ag...@suse.de wrote: On 10.12.2012, at 10:18, Cornelia Huck wrote: On Mon, 10 Dec 2012 10:00:16 +0100 Alexander Graf ag...@suse.de wrote: On 07.12.2012, at 13:50, Cornelia Huck cornelia.h...@de.ibm.com wrote: +/* Special

Re: [Qemu-devel] Network isn't clean when qemu exits

2012-12-11 Thread Michael S. Tsirkin
On Tue, Dec 11, 2012 at 09:38:43AM +0100, Stefan Hajnoczi wrote: On Tue, Dec 11, 2012 at 01:57:04PM +0800, Amos Kong wrote: In vl.c:main(), tap device would be created when net_init_clients() is called. device option is parsed after calling net_init_clients() by: #

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread Luiz Capitulino
On Tue, 11 Dec 2012 12:29:01 + Dietmar Maurer diet...@proxmox.com wrote: Can't we enable stat queries by default (10s interval), I'm not sure I like this for two reasons. First, there will be cases where the user doesn't want this to be enabled. Second, we'll be forcing an

Re: [Qemu-devel] [PATCH 8/8] s390: Add new channel I/O based virtio transport.

2012-12-11 Thread Cornelia Huck
On Tue, 11 Dec 2012 11:53:18 +0100 Alexander Graf ag...@suse.de wrote: On 07.12.2012, at 13:50, Cornelia Huck wrote: Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that uses this virtio-ccw transport and make it

Re: [Qemu-devel] [PATCH v6] Add compare subcommand for qemu-img

2012-12-11 Thread Miroslav Rezanina
Hi Kevin, thanks for review, comments inline. - Original Message - From: Kevin Wolf kw...@redhat.com To: Miroslav Rezanina mreza...@redhat.com Cc: qemu-devel@nongnu.org, Paolo Bonzini pbonz...@redhat.com, Stefan Hajnoczi stefa...@redhat.com Sent: Tuesday, December 11, 2012 1:27:45

[Qemu-devel] [PATCH 05/35] migration: make qemu_fopen_ops_buffered() return void

2012-12-11 Thread Juan Quintela
We want the file assignment to happen before the thread is created to avoid locking, so we just do it before creating the thread. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- buffered_file.c | 13 ++--- buffered_file.h | 2 +-

Re: [Qemu-devel] [RFC V3 06/24] qcow2: Add qcow2_dedup and related functions.

2012-12-11 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 02:05:05PM +0100, Benoît Canet wrote: +/* + * Compute the hash of a given cluster + * + * @data: a buffer containing the cluster data + * @ret: a HASH_LENGTH long dynamically allocated array containing the hash + */ +static uint8_t

[Qemu-devel] compile tcm_vhost kernel module as built-in

2012-12-11 Thread ching
Hi, is there any virtio-scsi developer here? I take a look at the tcm_vhost module of kernel 3.7 and want to compile it as built-in. However, CONFIG_TCM_VHOST only allows user to build as module. I wonder why this restriction exists? thx a lot. ching

Re: [Qemu-devel] [PATCH 1/2] target-i386: move CPU object creation to cpu.c

2012-12-11 Thread Eduardo Habkost
On Mon, Dec 10, 2012 at 10:30:42PM -0200, Eduardo Habkost wrote: As we will need to create the CPU object after splitting the CPU model string (because we're going to use different subclasses for each CPU model), move the CPU object creation to cpu_x86_register(), and at the same time rename

Re: [Qemu-devel] [PATCH 1/6] target-i386: filter out not TCG features if running without kvm at realize time

2012-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 11:11:01AM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Just to confirm that this submission still looks good to me: Reviewed-by: Eduardo

[Qemu-devel] [PATCH 04/35] buffered_file: Move from using a timer to use a thread

2012-12-11 Thread Juan Quintela
We still protect everything except the wait with the iothread lock. But we moved from a timer to a thread. Steps one by one. We also need to detect when we have finished with a variable complete. Signed-off-by: Juan Quintela quint...@redhat.com --- buffered_file.c | 58

Re: [Qemu-devel] [RFC V3 08/24] qcow2: Implement qcow2_compute_cluster_hash.

2012-12-11 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 02:05:07PM +0100, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- Makefile|3 +++ Makefile.target |2 +- block/qcow2-dedup.c | 10 -- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Makefile

Re: [Qemu-devel] [PATCH 4/6] target-i386: setting default 'vendor' is obsolete, remove it

2012-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 11:11:04AM +0100, Igor Mammedov wrote: since cpu_def config is not supported anymore and all remainig sources now always set x86_def_t.vendor[123] fields remove setting default vendor to simplify future refactoring. Signed-off-by: Igor Mammedov imamm...@redhat.com

Re: [Qemu-devel] [PATCH 5/6] target-i386: move setting defaults out of cpu_x86_parse_featurestr()

2012-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 11:11:05AM +0100, Igor Mammedov wrote: No functional change, needed for simplifying convertion to properties. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 12 +++- 1 files

[Qemu-devel] [PATCH 19/35] migration: move migration notifier

2012-12-11 Thread Juan Quintela
At this point, it is waranteed that state is ACTIVE. Old position didn't assured hat. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 371ff0c..913f3bc 100644 --- a/migration.c

Re: [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time

2012-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 11:11:02AM +0100, Igor Mammedov wrote: when CPU properties are implemented, ext2_features may change between object_new(CPU) and cpu_realize_fn(). Sanitizing ext2_features for AMD based CPU at realize() time will keep current behavior after CPU features are converted to

Re: [Qemu-devel] [PATCH 6/6] target-i386: move out CPU features initialization in separate func

2012-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 11:11:06AM +0100, Igor Mammedov wrote: No functional change, a simple code movement to simplify following refactoring. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- v2: - rebased on top of i386: cpu:

Re: [Qemu-devel] [PATCH 1/2] target-i386: move CPU object creation to cpu.c

2012-12-11 Thread Igor Mammedov
On Mon, 10 Dec 2012 22:30:42 -0200 Eduardo Habkost ehabk...@redhat.com wrote: As we will need to create the CPU object after splitting the CPU model string (because we're going to use different subclasses for each CPU model), move the CPU object creation to cpu_x86_register(), and at the same

  1   2   3   >