Re: [Qemu-devel] [PATCH] add fd limitations for avoiding a buffer overflow

2013-01-28 Thread Amos Kong
On Sun, Jan 27, 2013 at 01:41:57PM +0200, Michael S. Tsirkin wrote: On Fri, Jan 25, 2013 at 04:14:49PM +0800, Amos Kong wrote: FD_SET() and FD_CLR() are used to add and remove one descriptor from a set, the 'fd' should be less than FD_SETSIZE. Glibc will give a warning and crash the qemu

Re: [Qemu-devel] [ANNOUNCE] checkpatch and git-am bots

2013-01-28 Thread Andreas Färber
Am 21.01.2013 19:45, schrieb Anthony Liguori: I've published the code for patches although I've not announced it yet. I'm still making some CLI changes but hope to do a proper announcement in the next week or so. http://github.com/aliguori/patches.git If anyone wants to try it out, let me

Re: [Qemu-devel] hd-geo-test failing on OpenIndiana

2013-01-28 Thread Paolo Bonzini
Il 28/01/2013 08:53, Markus Armbruster ha scritto: Andreas Färber andreas.faer...@web.de writes: Hello Markus, On OpenIndiana 151a7 I am seeing assertion failures for ret == 0 in hd-geo-test.c:35:create_test_img(). It seems it is refusing to blow up the temporary file. Any suggestion what

Re: [Qemu-devel] hd-geo-test failing on OpenIndiana

2013-01-28 Thread Andreas Färber
Am 28.01.2013 08:53, schrieb Markus Armbruster: Andreas Färber andreas.faer...@web.de writes: Fine print on ftruncate(): If fildes refers to a regular file, the ftruncate() function shall cause the size of the file to be truncated to length. If the size of the file previously

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-28 Thread Gerd Hoffmann
Hi, This really is more of a distro problem than a QEMU one. If your distro doesn't package libfdt, chances are quite good it just sucks. Or just a little older. Packaging dtc + libfdt is a pretty recent thing, many not-that-recent distros don't have it. The libfdt installed on the rhel6

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 5/6] target-s390x: Mark as unmigratable

2013-01-28 Thread Alexander Graf
On 01/28/2013 01:13 AM, Andreas Färber wrote: CPU_SAVE_VERSION was undefined, so cpu_common VMState and cpu_{save,load}() were not registered. They were no-ops. Therefore there is no backwards compatibility to keep, so we can mark S390CPU as unmigratable at device level. Signed-off-by: Andreas

Re: [Qemu-devel] [PATCH v2 00/20] Add Faraday A36x SoC platform support

2013-01-28 Thread Kuo-Jung Su
2013/1/28 Andreas Färber afaer...@suse.de Am 25.01.2013 09:19, schrieb Kuo-Jung Su: From: Kuo-Jung Su dant...@faraday-tech.com These patches introduce Faraday A36x SoC platform support. Faraday provides ARMv4/ARMv5TE compatible solutions, and focus on ASIC design service. Here

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-28 Thread Paolo Bonzini
Il 28/01/2013 09:37, Gerd Hoffmann ha scritto: Hi, This really is more of a distro problem than a QEMU one. If your distro doesn't package libfdt, chances are quite good it just sucks. Or just a little older. Packaging dtc + libfdt is a pretty recent thing, many not-that-recent distros

Re: [Qemu-devel] [PATCH V15 0/9] libqblock qemu block layer library

2013-01-28 Thread Paolo Bonzini
Il 28/01/2013 03:13, Wenchao Xia ha scritto: Sorry for that, do you know how to enable these extra checks? I used default configuration by ./configure and did not check out this errors. Probably you need to upgrade to a newer version of GCC. Paolo

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-28 Thread Alexander Graf
On 01/27/2013 03:34 PM, Anthony Liguori wrote: Alexander Grafag...@suse.de writes: Am 26.01.2013 um 19:13 schrieb Peter Crosthwaitepeter.crosthwa...@xilinx.com: Hi All, On Sat, Jan 26, 2013 at 2:49 AM, Peter Maydellpeter.mayd...@linaro.org wrote: On 26 January 2013 10:11, Andreas

Re: [Qemu-devel] [PATCH for-1.4] block/raw-posix: Build fix for O_ASYNC

2013-01-28 Thread Stefan Hajnoczi
On Sat, Jan 26, 2013 at 02:38:45PM +0100, Andreas Färber wrote: Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image file reopen) broke the build on OpenIndiana. illumos has no O_ASYNC. Exclude it from flags to be compared and use I_SETSIG ioctl after newly opening file.

Re: [Qemu-devel] [PATCH] Add a disk format named iROW, supporting high-efficiency VM snapshot

2013-01-28 Thread Kevin Wolf
[ Fixed CC email addresses ] Am 26.01.2013 08:29, schrieb zhengjs@gmail.com: From: Jingsheng Zheng zhengjs@gmail.com iRow (imporved Redirect-on-Write) is a disk format supporting high-efficiency VM disk snapshot. iROW uses bitmap to reduce the amount of metadata, so that both the

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-28 Thread Peter Maydell
On 28 January 2013 08:58, Alexander Graf ag...@suse.de wrote: Peter, could you please cook up a patch to * build libfdt/dtc from a git submodule if it's not found in the system and * make libfdt mandatory for at least PPC ...with an in-tree submodule I don't see much value in the

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-28 Thread Alexander Graf
On 01/28/2013 10:28 AM, Peter Maydell wrote: On 28 January 2013 08:58, Alexander Grafag...@suse.de wrote: Peter, could you please cook up a patch to * build libfdt/dtc from a git submodule if it's not found in the system and * make libfdt mandatory for at least PPC ...with an in-tree

Re: [Qemu-devel] [PATCH for-1.4] block/raw-posix: Build fix for O_ASYNC

2013-01-28 Thread Paolo Bonzini
Il 26/01/2013 14:38, Andreas Färber ha scritto: Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image file reopen) broke the build on OpenIndiana. illumos has no O_ASYNC. Exclude it from flags to be compared and use I_SETSIG ioctl after newly opening file. Cf.

[Qemu-devel] [PATCH v2 0/3] AER-KVM: Error containment of VFIO devices assigned to KVM guests

2013-01-28 Thread Pandarathil, Vijaymohan R
Add support for error containment when a VFIO device assigned to a KVM guest encounters an error. This is for PCIe devices/drivers that support AER functionality. When the host OS is notified of an error in a device either through the firmware first approach or through an interrupt handled by the

[Qemu-devel] [PATCH v2 1/3] VFIO: Wrappers for getting/putting reference to vfio_device

2013-01-28 Thread Pandarathil, Vijaymohan R
- Added vfio_device_get_from_vdev(), vfio_device_put_vdev() as wrappers to get/put reference to vfio_device from struct device. - Added vfio_device_data() as a wrapper to get device_data from vfio_device. Signed-off-by: Vijay Mohan Pandarathil

[Qemu-devel] [PATCH v2 2/3] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-01-28 Thread Pandarathil, Vijaymohan R
- New VFIO_SET_IRQ ioctl option to pass the eventfd that is signalled when an error occurs in the vfio_pci_device - Register pci_error_handler for the vfio_pci driver - When the device encounters an error, the error handler registered by the

[Qemu-devel] [PATCH v2 3/3] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-01-28 Thread Pandarathil, Vijaymohan R
- Create eventfd per vfio device assigned to a guest and register an event handler - This fd is passed to the vfio_pci driver through the SET_IRQ ioctl - When the device encounters an error, the eventfd is signalled and the qemu eventfd handler gets

Re: [Qemu-devel] [PATCH] add fd limitations for avoiding a buffer overflow

2013-01-28 Thread Paolo Bonzini
Il 25/01/2013 15:30, Stefan Hajnoczi ha scritto: Anthony, Paolo: Is there an alternative to select(2)? I think this was discussed a bit during the glib event loop integration. The two requirements I can think of are: 1. Portable so that we don't have to write OS-specific versions (epoll,

Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.

2013-01-28 Thread Cornelia Huck
On Fri, 25 Jan 2013 20:28:31 +0100 Alexander Graf ag...@suse.de wrote: However, I do agree that this duplicates logic. Cornelia, mind to instead call our map helper in css_do_tpi? Well, ioinst_handle_tpi() looks like the better place to do this. Can you put this into the series, or should I

Re: [Qemu-devel] [PATCH] Add a disk format named iROW, supporting high-efficiency VM snapshot

2013-01-28 Thread Stefan Hajnoczi
On Sat, Jan 26, 2013 at 04:15:37PM +0800, zhengjs@gmail.com wrote: diff --git a/block/irow.h b/block/irow.h new file mode 100644 index 000..131b741 --- /dev/null +++ b/block/irow.h @@ -0,0 +1,135 @@ +/* IROW(Improved ROW)Disk Format + * */ +/* + * iRow (imporved

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-28 Thread Cornelia Huck
On Sat, 26 Jan 2013 14:17:36 + Blue Swirl blauwir...@gmail.com wrote: On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf ag...@suse.de wrote: Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Alex The following changes since commit

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-28 Thread Jay Foad
Checkpatch doesn't work well with the pattern #ifdef SOMETHING if (foo) { bar(); } else #endif { baz1(); baz2(); } Which is exactly the case for all three errors reported in this series. I know of no other good way to arrange this pattern.

Re: [Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t

2013-01-28 Thread Igor Mammedov
On Sat, 26 Jan 2013 16:26:07 +0100 Andreas Färber afaer...@suse.de wrote: Am 21.01.2013 15:06, schrieb Igor Mammedov: Move custom features parsing after built-in cpu_model defaults are set and set custom features directly on CPU instance. That allows to make clear distinction between

Re: [Qemu-devel] [PATCH qom-cpu 0/5 v2] x86 CPU cleanup, part 4

2013-01-28 Thread Igor Mammedov
On Sat, 26 Jan 2013 16:50:12 +0100 Andreas Färber afaer...@suse.de wrote: Am 21.01.2013 15:06, schrieb Igor Mammedov: Igor Mammedov (5): target-i386: print deprecated warning if xlevel 0x8000 target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

Re: [Qemu-devel] [PATCH 4/4] qemu/log.h: Fix missing includes

2013-01-28 Thread Igor Mammedov
On Sat, 26 Jan 2013 12:54:36 -0800 Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: qemu/log.h needs a few bits and pieces from qemu-common to compile. Fixes the case where qemu/log.h is the first files included. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com ---

Re: [Qemu-devel] Bug with qxl vga memory settings

2013-01-28 Thread Gerd Hoffmann
On 01/25/13 15:37, Fabio Fantoni wrote: Debugging qxl problem with xen I tested first qemu without xen and I found that qxl memory mapping problem is not only xen related. After some tests with qemu-only I found that -global qxl-vga.vram_size=N and -global qxl-vga.ram_size=N (where N is for

Re: [Qemu-devel] Bug with qxl vga memory settings

2013-01-28 Thread Gerd Hoffmann
After some tests with qemu-only I found that -global qxl-vga.vram_size=N and -global qxl-vga.ram_size=N (where N is for example 16384 or 65536) are bugged. qxl-0: ram/pri: 32 MB [region 0] qxl-0: vram/32: 0 MB [region 1] Yep. You'll get the minimum supported sizes due to the small

[Qemu-devel] KVM call agenda for 2013-01-29

2013-01-28 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

[Qemu-devel] [PATCH for-1.4 v2] target-i386: kvm: prevent buffer overflow if -cpu foo, [x]level is too big

2013-01-28 Thread Igor Mammedov
Stack corruption may occur if too big 'level' or 'xlevel' values passed on command line with KVM enabled, due to limited size of cpuid_data in kvm_arch_init_vcpu(). reproduces with: qemu -enable-kvm -cpu qemu64,level=4294967295 or qemu -enable-kvm -cpu qemu64,xlevel=4294967295 Check if there

Re: [Qemu-devel] [PATCH for-1.4 v2] target-i386: kvm: prevent buffer overflow if -cpu foo, [x]level is too big

2013-01-28 Thread Laszlo Ersek
On 01/28/13 12:49, Igor Mammedov wrote: Stack corruption may occur if too big 'level' or 'xlevel' values passed on command line with KVM enabled, due to limited size of cpuid_data in kvm_arch_init_vcpu(). reproduces with: qemu -enable-kvm -cpu qemu64,level=4294967295 or qemu -enable-kvm

[Qemu-devel] [PATCHv4 2/2] qemu-img: add json output option to the check command

2013-01-28 Thread Federico Simoncelli
This option --output=[human|json] makes qemu-img check output a human or JSON representation at the choice of the user. Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- qapi-schema.json | 46 +++ qemu-img-cmds.hx |4 +- qemu-img.c | 232

[Qemu-devel] [PATCHv4 1/2] qemu-img: find the image end offset during check

2013-01-28 Thread Federico Simoncelli
This patch adds the support for reporting the image end offset (in bytes). This is particularly useful after a conversion (or a rebase) where the destination is a block device in order to find the first unused byte at the end of the image. Signed-off-by: Federico Simoncelli fsimo...@redhat.com

Re: [Qemu-devel] [PATCH for-1.4] block/raw-posix: Build fix for O_ASYNC

2013-01-28 Thread Stefan Hajnoczi
On Mon, Jan 28, 2013 at 10:47:28AM +0100, Paolo Bonzini wrote: Il 26/01/2013 14:38, Andreas Färber ha scritto: Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image file reopen) broke the build on OpenIndiana. illumos has no O_ASYNC. Exclude it from flags to be compared

Re: [Qemu-devel] [PATCH for-1.4] block/raw-posix: Build fix for O_ASYNC

2013-01-28 Thread Andreas Färber
Am 28.01.2013 13:27, schrieb Stefan Hajnoczi: On Mon, Jan 28, 2013 at 10:47:28AM +0100, Paolo Bonzini wrote: Il 26/01/2013 14:38, Andreas Färber ha scritto: Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image file reopen) broke the build on OpenIndiana. illumos has no

Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2013-01-28 Thread Luiz Capitulino
On Sat, 26 Jan 2013 23:25:11 +0100 q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/509 Buildbot URL:

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-28 Thread Alexander Graf
On 01/28/2013 11:06 AM, Cornelia Huck wrote: On Sat, 26 Jan 2013 14:17:36 + Blue Swirlblauwir...@gmail.com wrote: On Fri, Jan 25, 2013 at 12:48 PM, Alexander Grafag...@suse.de wrote: Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Alex The following

Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.

2013-01-28 Thread Alexander Graf
On 01/28/2013 10:59 AM, Cornelia Huck wrote: On Fri, 25 Jan 2013 20:28:31 +0100 Alexander Grafag...@suse.de wrote: However, I do agree that this duplicates logic. Cornelia, mind to instead call our map helper in css_do_tpi? Well, ioinst_handle_tpi() looks like the better place to do this.

Re: [Qemu-devel] [PATCH v2 0/6] bdrv_open() error return fixes

2013-01-28 Thread Markus Armbruster
You addressed all my comments. Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-28 Thread Stefan Hajnoczi
On Fri, Jan 25, 2013 at 09:34:28AM +, Dietmar Maurer wrote: Note: The proposed backup patches (already sent to the list) make backups without creating internal/external snapshot. Consistency is guaranteed by using COW. I guess this can be implemented, or may already exist in

Re: [Qemu-devel] [PATCH v2 2/5] block: Use error code EMEDIUMTYPE for wrong format in some block drivers

2013-01-28 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Kevin, Stefan, maybe you can take patches 1, 3, 4 and 5 from this series, so I don't have to resend them. I'll split patch 2 in order to realize Markus' suggestion. Or you take it as it is, resulting in half-broken (instead of full broken) xxx_open

Re: [Qemu-devel] [PATCH v2] target-arm: add Faraday ARMv5TE processors support

2013-01-28 Thread Peter Maydell
On 25 January 2013 07:18, Kuo-Jung Su dant...@gmail.com wrote: +static const ARMCPRegInfo faraday_cp_reginfo[] = { +/* + * Auxiliary Control Register + * - Bit 4 STM aligned transfer for AXI + * - Bit 3 Cache allocation configuration enable + * - Bit 2 Static branch

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-28 Thread Paolo Bonzini
Il 21/01/2013 09:50, Michael S. Tsirkin ha scritto: Unfortunately, I've not been able to get back to the conversion requested by Paolo for a standalone vhost-scsi PCI device. It doesn't have to be a standalone device. A vhost=on frontend option is also OK I think. Paolo, any objections?

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-28 Thread Michael S. Tsirkin
On Mon, Jan 28, 2013 at 02:01:41PM +0100, Paolo Bonzini wrote: Il 21/01/2013 09:50, Michael S. Tsirkin ha scritto: Unfortunately, I've not been able to get back to the conversion requested by Paolo for a standalone vhost-scsi PCI device. It doesn't have to be a standalone device. A

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-28 Thread David Woodhouse
On Sun, 2013-01-27 at 18:53 -0600, Anthony Liguori wrote: Are you just trying to persist a single blob of a fixed maximum size? That would suffice. Why not just have a second flash device then? Mostly because flash devices don't actually *work* with KVM. Should I be looking at fixing *that*,

Re: [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanups

2013-01-28 Thread Stefan Hajnoczi
On Thu, Jan 24, 2013 at 05:04:29PM -0600, Jesse Larrew wrote: Reformat the option parsing code in main() and various supporting functions to conform to the QEMU coding style. Signed-off-by: Jesse Larrew jlar...@linux.vnet.ibm.com --- vl.c | 476

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-28 Thread Stefan Hajnoczi
On Fri, Jan 25, 2013 at 05:16:46PM +0800, Wenchao Xia wrote: 于 2013-1-24 17:47, Stefan Hajnoczi 写道: Case 3: * What does blank data mean? Besides that the use case makes sense. Will remove the words. * When discussing this use case in the past it was suggested that the

Re: [Qemu-devel] [ANNOUNCE] checkpatch and git-am bots

2013-01-28 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Am 21.01.2013 19:45, schrieb Anthony Liguori: I've published the code for patches although I've not announced it yet. I'm still making some CLI changes but hope to do a proper announcement in the next week or so.

Re: [Qemu-devel] [RFC qom-cpu v2 00/28] CPUState QOM realizefn support

2013-01-28 Thread Andreas Färber
Am 20.01.2013 08:22, schrieb Andreas Färber: Andreas Färber (28): cpu: Prepare QOM realizefn target-alpha: Update AlphaCPU to QOM realizefn target-arm: Update ARMCPU to QOM realizefn target-i386: Update X86CPU to QOM realizefn target-openrisc: Update OpenRISCCPU to QOM realizefn

[Qemu-devel] [RFC V7 02/13] quorum: Create BDRVQuorumState and BlkDriver and do init.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index ce094a1..0524b63 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include block/block_int.h

[Qemu-devel] [RFC V7 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 113 1 file changed, 113 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 0524b63..8fa79db 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -52,11

[Qemu-devel] [RFC V7 00/13] Quorum block filter

2013-01-28 Thread Benoît Canet
This patchset is rebased on top of cutils: unsigned int parsing functions by Eduardo Habkost. It must be applied on top of Pave the way for protocol snapshot creation This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total files.

[Qemu-devel] [RFC V7 10/13] quorum: Add quorum_co_flush().

2013-01-28 Thread Benoît Canet
Makes a vote to select error if any. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index ed97a76..ee6bc45 100644 --- a/block/quorum.c +++ b/block/quorum.c

[Qemu-devel] [RFC V7 13/13] quorum: Add quorum_open() and quorum_close().

2013-01-28 Thread Benoît Canet
Valid quorum resources look like quorum:threshold/total:path/to/image_1: ... :path/to/image_total ':' is used as a separator '\' is the escaping character for filename containing ':' '\' escape itself ',' must be escaped with ',' On the command line for quorum files img:test.raw, img2,raw and

Re: [Qemu-devel] [ANNOUNCE] checkpatch and git-am bots

2013-01-28 Thread Andreas Färber
Am 28.01.2013 14:20, schrieb Anthony Liguori: Andreas Färber afaer...@suse.de writes: Am 21.01.2013 19:45, schrieb Anthony Liguori: http://github.com/aliguori/patches.git If anyone wants to try it out, let me know, and I would be happy to answer questions/help you set it up. $ patches

Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2013-01-28 Thread Anthony Liguori
Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 26 Jan 2013 23:25:11 +0100 q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at:

Re: [Qemu-devel] [qemu-devel]The problem of QMP command getfd.

2013-01-28 Thread Stefan Hajnoczi
On Mon, Jan 28, 2013 at 03:27:01PM +0800, Li Zhang wrote: Hi all, I am trying to executing qmp command getfd according to qmp-commands.hx. { execute: getfd, arguments: { fdname: fd1 } } Every time, it returns the error. { error: { class: GenericError, desc: No

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-28 Thread Paolo Bonzini
Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not possible to switch one to the other at run time. Exactly the

Re: [Qemu-devel] KVM call agenda for 2013-01-29

2013-01-28 Thread Stefan Hajnoczi
On Mon, Jan 28, 2013 at 11:59:40AM +0100, Juan Quintela wrote: Please send in any agenda topics you are interested in. Replacing select(2) so that we will not hit the 1024 fd_set limit in the future. Stefan

Re: [Qemu-devel] KVM call agenda for 2013-01-29

2013-01-28 Thread Andreas Färber
Am 28.01.2013 11:59, schrieb Juan Quintela: Please send in any agenda topics you are interested in. Buildbot situation: * Trees are not being added/updated in a timely fashion * Insufficient build test coverage of trees (ppc, s390x, MinGW, BSD) http://buildbot.b1-systems.de/qemu/builders

Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2013-01-28 Thread Andreas Färber
Am 28.01.2013 14:28, schrieb Anthony Liguori: Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 26 Jan 2013 23:25:11 +0100 q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at:

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-28 Thread Michael S. Tsirkin
On Mon, Jan 28, 2013 at 02:29:23PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-28 Thread Paolo Bonzini
Il 28/01/2013 14:36, Michael S. Tsirkin ha scritto: On Mon, Jan 28, 2013 at 02:29:23PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-28 Thread Michael S. Tsirkin
On Mon, Jan 28, 2013 at 02:33:44PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:36, Michael S. Tsirkin ha scritto: On Mon, Jan 28, 2013 at 02:29:23PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration

[Qemu-devel] [RFC V7 08/13] quorum: Add quorum_invalidate_cache().

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 1f0954d..6254f95 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -517,6 +517,16 @@ static int64_t

Re: [Qemu-devel] [PATCH for-1.4 v2] target-i386: kvm: prevent buffer overflow if -cpu foo, [x]level is too big

2013-01-28 Thread Andreas Färber
Am 28.01.2013 12:49, schrieb Igor Mammedov: Stack corruption may occur if too big 'level' or 'xlevel' values passed on command line with KVM enabled, due to limited size of cpuid_data in kvm_arch_init_vcpu(). reproduces with: qemu -enable-kvm -cpu qemu64,level=4294967295 or qemu

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-28 Thread Dietmar Maurer
If you've been using it for 4 years then it was without dm-thin, which is a new snapshot mechanism that solves limitations of classic LVM snapshot volumes. So if you're referring to inefficient LVM snapshots then that should be solvable now. Are you sure this work on shared iSCSI devices

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-m68k: Use type_register() instead of type_register_static()

2013-01-28 Thread Andreas Färber
Am 27.01.2013 19:35, schrieb Andreas Färber: According to its documentation, type_register_static()'s TypeInfo argument should exist for the life type of the type. Therefore use type_register() when registering the list of CPU subtypes. No functional change with the current implementation.

Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-28 Thread Luiz Capitulino
On Fri, 25 Jan 2013 14:27:11 +0100 Michal Privoznik mpriv...@redhat.com wrote: Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. It's missing the s-o-b line. --- qmp-commands.hx | 2 +- 1 file changed,

Re: [Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-28 Thread Peter Maydell
Ping: Stefan, are you going to take this via -trivial as Gerd suggests? [patchwork url: http://patchwork.ozlabs.org/patch/214114/ ] thanks -- PMM On 21 January 2013 17:14, Gerd Hoffmann kra...@redhat.com wrote: On 01/21/13 15:19, Gerd Hoffmann wrote: Stefan: I've made the obvious change to

[Qemu-devel] [RFC V7 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/Makefile.objs |1 + block/quorum.c | 45 + 2 files changed, 46 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/Makefile.objs index

Re: [Qemu-devel] [PATCH qom-cpu for-1.4?] kvm: Pass CPUState to kvm_on_sigbus_vcpu()

2013-01-28 Thread Gleb Natapov
On Fri, Jan 25, 2013 at 04:55:29PM +0100, Andreas Färber wrote: Since commit 20d695a9254c1b086a456d3b79a3c311236643ba (kvm: Pass CPUState to kvm_arch_*) CPUArchState is no longer needed. Allows to change qemu_kvm_eat_signals() argument as well. Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH] target-arm: Fix TCG temp leaks for WI and UNDEF VFP sysreg writes

2013-01-28 Thread Peter Maydell
Blue -- I forgot to put this patch in a target-arm pullreq, and it's my only outstanding target-arm patch for 1.4. Do you want to just apply it directly or would you prefer me to put together a single-patch pullreq? [patchwork url: http://patchwork.ozlabs.org/patch/205269/ ] thanks -- PMM On 11

[Qemu-devel] [PATCH 2/4] block: make path_hash_protocol public.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c |2 +- include/block/block.h |1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index af22ee8..3bebc74 100644 --- a/block.c +++ b/block.c @@ -195,7 +195,7 @@ static void

[Qemu-devel] [RFC V7 06/13] quorum: Add quorum mechanism.

2013-01-28 Thread Benoît Canet
Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 303 +++- configure | 22 2 files changed, 324 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c

[Qemu-devel] [RFC V7 07/13] quorum: Add quorum_getlength().

2013-01-28 Thread Benoît Canet
Check that every bs file return the same length. If not return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 20 1 file changed, 20 insertions(+) diff --git a/block/quorum.c b/block/quorum.c

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] cpu: Unconditionalize CPUState fields

2013-01-28 Thread Paolo Bonzini
Il 25/01/2013 16:27, Andreas Färber ha scritto: Commits fc8c5b8c41ee5ba69d7a2be63b02a08c7b0b155b (Makefile.user: Define CONFIG_USER_ONLY for libuser/) and dd83b06ae61cfa2dc4381ab49f365bd0995fc930 (qom: Introduce CPU class) specifically prepared the qom/cpu.c file to be compiled differently for

[Qemu-devel] [RFC V7 05/13] quorum: Add quorum_aio_readv.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 8fa79db..ab3e5f3 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -73,15 +73,24

[Qemu-devel] [PATCH 3/4] blockdev: Allow snapshoting of protocols.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- blockdev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 0ce45c5..b1f388b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -800,7 +800,8 @@ void qmp_transaction(BlockdevActionList *dev_list,

Re: [Qemu-devel] KVM call agenda for 2013-01-29

2013-01-28 Thread Anthony Liguori
Juan Quintela quint...@redhat.com writes: Hi Please send in any agenda topics you are interested in. - Outstanding virtio work for 1.4 - Multiqueue virtio-net (Amos/Michael) - Refactorings (Fred/Peter) - virtio-ccw (Cornelia/Alex) We need to work out the ordering here and what's

[Qemu-devel] [PATCH 0/4] Pave the way for protocol snapshot creation

2013-01-28 Thread Benoît Canet
This patchset add the required block driver operation in order to allow protocols such as quorum to be able to create snapshots. Benoît Canet (4): block: Move external snapshot image creation in the block drivers. block: make path_hash_protocol public. blockdev: Allow snapshoting of

[Qemu-devel] [RFC V7 04/13] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/blkverify.c | 108 + include/qemu-common.h |2 + util/iov.c| 103 ++ 3 files changed, 107 insertions(+), 106 deletions(-)

Re: [Qemu-devel] [qemu-devel]The problem of QMP command getfd.

2013-01-28 Thread Li Zhang
On 2013年01月28日 21:28, Stefan Hajnoczi wrote: On Mon, Jan 28, 2013 at 03:27:01PM +0800, Li Zhang wrote: Hi all, I am trying to executing qmp command getfd according to qmp-commands.hx. { execute: getfd, arguments: { fdname: fd1 } } Every time, it returns the error. { error: {

[Qemu-devel] [RFC V7 12/13] quorum: Add quorum_snapshot_reopen.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 20 1 file changed, 20 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 0217593..d6fef58 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -797,6 +797,25 @@ free_new_s_exit:

[Qemu-devel] [PATCH 4/4] block: Move reopening of image after snapshot creation into the block drivers.

2013-01-28 Thread Benoît Canet
Protocols like quorum will be able to queue multiple reopens. Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 28 block/cow.c |1 + block/qcow.c |1 + block/qcow2.c |1 + block/qed.c

[Qemu-devel] [RFC V7 11/13] quorum: Add quorum_snapshot_img_create.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 188 1 file changed, 188 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index ee6bc45..0217593 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -611,6

[Qemu-devel] [PATCH 1/4] block: Move external snapshot image creation in the block drivers.

2013-01-28 Thread Benoît Canet
This patch will allow protocols to implements snapshots as the image creation is now delegated to the block driver. Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 42 ++ block/blkdebug.c |2 ++

[Qemu-devel] [RFC V7 09/13] quorum: Add quorum_co_is_allocated.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 53 + 1 file changed, 53 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 6254f95..ed97a76 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -135,6 +135,22

[Qemu-devel] QEMU buildbot maintenance state (was: Re: KVM call agenda for 2013-01-29)

2013-01-28 Thread Daniel Gollub
Hi Andreas, thanks for bringing this topic up. January was quite busy month for me so far I could only handle minor changes on the buildbot. I hesitate to make larger changes to avoid I break other stuff. So I just queued them up once I have more time (beginning in February or so) I bounced now

Re: [Qemu-devel] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread MORITA Kazutaka
At Mon, 28 Jan 2013 21:18:42 +0800, harryxiyou wrote: Hi Morita and other developers, I have programed HLFS(HDFS based Log-structured FileSystem) driver for Libvirt according to Morita's patch(commit 036ad5052b43fe9f0d197e89fd16715950408e1d) for Libvirt, which my patch is not for Libvirt

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-28 Thread Michael S. Tsirkin
On Thu, Jan 24, 2013 at 10:31:20AM +0100, Laszlo Ersek wrote: From http://mjg59.dreamwidth.org/3561.html: Traditional PCI config space access is achieved by writing a 32 bit value to io port 0xcf8 to identify the bus, device, function and config register. Port 0xcfc then contains the

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-28 Thread Kevin Wolf
Am 25.01.2013 18:23, schrieb Peter Maydell: On 25 January 2013 17:20, Laszlo Ersek ler...@redhat.com wrote: The subscript operator [] is used here in the type name of a compound literal which is probably not what the script intends to catch. 1945 # check for spacing round square brackets;

Re: [Qemu-devel] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 10:44 PM, MORITA Kazutaka morita.kazut...@gmail.com wrote: [...] I'm not familiar with HLFS at all. Sheepdog examples I explained to you in another mail may help you, but I cannot give you any other suggestions about HLFS. Thanks for your reminder, i have found this

Re: [Qemu-devel] QEMU buildbot maintenance state

2013-01-28 Thread Andreas Färber
Hi Daniel, Am 28.01.2013 15:29, schrieb Daniel Gollub: thanks for bringing this topic up. January was quite busy month for me so far I could only handle minor changes on the buildbot. I hesitate to make larger changes to avoid I break other stuff. So I just queued them up once I have more

Re: [Qemu-devel] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 11:06 PM, harryxiyou harryxi...@gmail.com wrote: On Mon, Jan 28, 2013 at 10:44 PM, MORITA Kazutaka morita.kazut...@gmail.com wrote: [...] I'm not familiar with HLFS at all. Sheepdog examples I explained to you in another mail may help you, but I cannot give you any

Re: [Qemu-devel] [PATCH qom-cpu for-1.4?] kvm: Pass CPUState to kvm_on_sigbus_vcpu()

2013-01-28 Thread Andreas Färber
Am 28.01.2013 14:50, schrieb Gleb Natapov: On Fri, Jan 25, 2013 at 04:55:29PM +0100, Andreas Färber wrote: Since commit 20d695a9254c1b086a456d3b79a3c311236643ba (kvm: Pass CPUState to kvm_arch_*) CPUArchState is no longer needed. Allows to change qemu_kvm_eat_signals() argument as well.

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] cpu: Unconditionalize CPUState fields

2013-01-28 Thread Andreas Färber
Am 28.01.2013 15:00, schrieb Paolo Bonzini: Il 25/01/2013 16:27, Andreas Färber ha scritto: Commits fc8c5b8c41ee5ba69d7a2be63b02a08c7b0b155b (Makefile.user: Define CONFIG_USER_ONLY for libuser/) and dd83b06ae61cfa2dc4381ab49f365bd0995fc930 (qom: Introduce CPU class) specifically prepared the

[Qemu-devel] Can KVM notify VM to execute some operations?

2013-01-28 Thread 独孤败
I know that the VM can use the VMCALL instruction to notify the KVM to do some operations. My question is that if the KVM want to notify the VM to execute some operations, which instrction should be use? Or is there any other method to realize this? -- Best Regards!

[Qemu-devel] Can KVM notify VM to execute some operations?

2013-01-28 Thread 独孤败
I know that the VM can use the VMCALL instruction to notify the KVM to do some operations. My question is that if the KVM want to notify the VM to execute some operations, which instrction should be use? Or is there any other method to realize this? -- Best Regards!

  1   2   3   >