Re: [Qemu-devel] [PULL 5/8] rdma: core rdma logic

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 06:49, Paolo Bonzini ha scritto: +remote_ram_blocks.num_blocks = remote_ram_blocks.remote_area; +remote_ram_blocks.block = (void *) (remote_ram_blocks.num_blocks + 1); You cannot do this, it doesn't guarantee that remote_ram_blocks.block is correctly aligned. Please

Re: [Qemu-devel] weird behaviour of numlock key

2013-04-16 Thread Gerd Hoffmann
On 04/15/13 17:43, Nikola Ciprich wrote: Hi Gerd, I'm using tigervnc, but the problem occurs also with xrdp vnc2rdp proxy.. Do things improve with a gtk-vnc based client? vinagre or remote-viewer (comes bundles with recent virt-viewer versions)? cheers, Gerd

[Qemu-devel] [PATCH] ARM Cortex A9 Global Timer

2013-04-16 Thread François Legal
Hello, I made up this patch to implement the Cortex A9 global timer in Qemu. My patch is based on the Qemu branch maintained by Xilinx for the Zynq. diff -urN qemu-master/hw/cpu/a9mpcore.c qemu-master.new/hw/cpu/a9mpcore.c --- qemu-master/hw/cpu/a9mpcore.c 2013-04-08 20:12:33.0

[Qemu-devel] [Bug 1169049] [NEW] do not stop on first gdb breakpoint with -enable-kvm

2013-04-16 Thread skovalev
Public bug reported: I run qemu like this: qemu-system-x86-64 -enable-kvm -hda path to file -s -S, and start gdb with commands like this: gdbtartget remote localhost:1234 gdbbreak *0x7c00 gdbc but gdb don't stop on it. I then could break execution manually and then breakpoints work.

[Qemu-devel] SoC Idea: Xbox target

2013-04-16 Thread Niel van der Westhuizen
Hey, So I've been lazily hacking away on https://github.com/espes/xqemu for the last few months. It's a target for the original Xbox in Qemu - it's kind of a neat fit, since the Xbox was mostly an nForce 420 PC. It'd be awesome to have helping out on this as a listed Summer of Code project idea.

[Qemu-devel] Qemu redirection option behave differently on Linux and Windows

2013-04-16 Thread Taimoor Mirza
Hi Everyone, I am trying to use QEMU's port forwarding option with my application and have observed following difference in behaviour on Windows and Linux: * If I relaunch QEMU with same host and guest port redirection values on Linux, it throws following error:qemu-system-arm: could not set up

Re: [Qemu-devel] USB2.0 disk format failure in windows guest

2013-04-16 Thread Alan Stern
On Sun, 14 Apr 2013, Gonglei (Arei) wrote: Hi Alan, We pass-throughed USB 2.0 disk to guest using usb-host (qemu option: -device usb-ehci,id=ehci -device usb-host,bus=ehci.0,hostbus=2,hostport=1) on KVM(on linux-3.8.3 or linux-3.0.13) and qemu 1.4.0 , Are you sure this disk was

Re: [Qemu-devel] weird behaviour of numlock key

2013-04-16 Thread Nikola Ciprich
Hi Gerd, Do things improve with a gtk-vnc based client? vinagre or remote-viewer (comes bundles with recent virt-viewer versions)? tried vinagre now, same result... nik cheers, Gerd -- - Ing. Nikola CIPRICH LinuxBox.cz, s.r.o. 28.rijna 168,

Re: [Qemu-devel] Support for VNC LED state extension proposal

2013-04-16 Thread Gerd Hoffmann
Hi, What is your vnc client? Does it support VNC_ENCODING_EXT_KEY_EVENT? It's uses gvnc as a protocol library and renders via fbdev. It reads keyboard events by putting /dev/tty into mediumraw mode and uses ext key events exclusively. It has no knowledge of the guest keymap. Neat.

Re: [Qemu-devel] [qemu-devel] Bug Report: VM crashed for some kinds of vCPU in nested virtualization

2013-04-16 Thread Jan Kiszka
On 2013-04-16 05:49, 李春奇 Arthur Chunqi Li wrote: I changed to the latest version of kvm kernel but the bug also occured. On the startup of L1 VM on the host, the host kern.log will output: Apr 16 11:28:22 Blade1-02 kernel: [ 4908.458090] kvm [2808]: vcpu0 unhandled rdmsr: 0x345 Apr 16

Re: [Qemu-devel] [PATCH] monitor: fix the wrong order of releasing keys

2013-04-16 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: (qemu) sendkey ctrl_r-scroll_lock-scroll_lock Executing this command could not let Windows guest panic, it caused by could not? the wrong order of releasing keys. This problem was introduced by commit e4c8f004c55d9da3eae3e14df740238bf805b5d6. The right

Re: [Qemu-devel] [BUG latest master] - qemu segfaults when issuing screendump cmd

2013-04-16 Thread Gerd Hoffmann
On 04/15/13 18:49, Lucas Meneghel Rodrigues wrote: Latest qemu.git master is failing big time to pass sanity checks: https://bugs.launchpad.net/qemu/+bug/1169254 We've had some issues with the test jobs, and finally managed to stabilize the grid, so we don't have results for the last

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-04-16 Thread Gerd Hoffmann
On 04/10/13 10:31, Jan Kiszka wrote: On 2013-04-03 13:50, Gerd Hoffmann wrote: Hi, No, it is not, and yes, this is where the inconsistency comes from. We read wred+wgreen+wblue directly from the surface whereas depth is cached in the vmware vga state struct. Patch attached. Not

Re: [Qemu-devel] [PATCH] Added cleanup for Win32 TAP interface

2013-04-16 Thread Pavel Dovgaluk
Hello! From: Stefan Weil [mailto:s...@weilnetz.de] Am 15.04.2013 17:55, schrieb Paolo Bonzini: Il 13/03/2013 13:23, Pavel Dovgaluk ha scritto: Added cleanup for Win32 TAP interface. Signed-off-by: Pavel Dovgalyukpavel.dovga...@gmail.com Stefan, did this slip? Paolo Yes, I had not

Re: [Qemu-devel] [PATCH] Added cleanup for Win32 TAP interface

2013-04-16 Thread Stefan Hajnoczi
On Mon, Apr 15, 2013 at 08:32:06PM +0200, Stefan Weil wrote: Am 15.04.2013 17:55, schrieb Paolo Bonzini: Il 13/03/2013 13:23, Pavel Dovgaluk ha scritto: Added cleanup for Win32 TAP interface. Signed-off-by: Pavel Dovgalyukpavel.dovga...@gmail.com Stefan, did this slip? Paolo Yes, I had

Re: [Qemu-devel] Qemu redirection option behave differently on Linux and Windows

2013-04-16 Thread Markus Armbruster
Taimoor Mirza mooni_mi...@hotmail.com writes: Hi Everyone, I am trying to use QEMU's port forwarding option with my application and have observed following difference in behaviour on Windows and Linux: * If I relaunch QEMU with same host and guest port redirection values on Linux, it throws

Re: [Qemu-devel] QTest with TCG?

2013-04-16 Thread Edgar E. Iglesias
On Tue, Apr 16, 2013 at 07:11:43AM +0200, Paolo Bonzini wrote: Il 15/04/2013 21:03, Anthony Liguori ha scritto: Edgar E. Iglesias edgar.igles...@gmail.com writes: Hi, I would like to use qtest for testing hw-models in combination with firmware. At the moment I'm using the

Re: [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion

2013-04-16 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 05:05:41PM +0800, liu ping fan wrote: On Fri, Apr 12, 2013 at 4:45 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Apr 12, 2013 at 12:48:12PM +0800, liu ping fan wrote: On Thu, Apr 11, 2013 at 6:20 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Apr

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-16 Thread Stefan Hajnoczi
On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: +static MacTableInfo *virtio_net_query_mactable(NetClientState *nc) +{ +VirtIONet *n = qemu_get_nic_opaque(nc); +MacTableInfo *info; +StringList *str_list = NULL; +StringList *entry; +char str[12]; +int i;

Re: [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 09:57, Stefan Hajnoczi ha scritto: So it sounds like unplug will not block and there is no guarantee the memory is actually unplugged when the monitor command completes. The memory region is only released when the last reference count holder lets go. This means that pending

Re: [Qemu-devel] [PATCH v5] sheepdog: add discard/trim support for sheepdog

2013-04-16 Thread Stefan Hajnoczi
On Tue, Apr 16, 2013 at 12:15:04AM +0800, Liu Yuan wrote: @@ -727,6 +730,20 @@ static void coroutine_fn aio_read_response(void *opaque) rsp.result = SD_RES_SUCCESS; } break; +case AIOCB_DISCARD_OBJ: +switch (rsp.result) { +case

Re: [Qemu-devel] [RFC PATCH v2 3/6] memory: add memory_region_to_address()

2013-04-16 Thread Peter Maydell
On 16 April 2013 00:19, Scott Wood scottw...@freescale.com wrote: This is useful for when a user of the memory region API needs to communicate the absolute bus address to something outside QEMU (in particular, KVM). Signed-off-by: Scott Wood scottw...@freescale.com --- TODO: Use add/del

Re: [Qemu-devel] SoC Idea: Xbox target

2013-04-16 Thread Stefan Hajnoczi
On Mon, Apr 15, 2013 at 6:38 PM, Niel van der Westhuizen nielg...@gmail.com wrote: So I've been lazily hacking away on https://github.com/espes/xqemu for the last few months. It's a target for the original Xbox in Qemu - it's kind of a neat fit, since the Xbox was mostly an nForce 420 PC. It'd

Re: [Qemu-devel] [PATCH 07/12] configure: fix TPM logic

2013-04-16 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: A non-native i386 or x86_64 emulator should not have TPM passthrough support, since the TPM is only present for those hosts. Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com Breaks the build for me:

Re: [Qemu-devel] [PATCH v6 00/16] Stream Patches

2013-04-16 Thread Edgar E. Iglesias
On Tue, Apr 16, 2013 at 10:18:08AM +1000, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Hi all. The Xilinx AXIEnet and DMA devices have two AXI stream connections (control and data), only one of which is currently modelled (data). AXI stream is

Re: [Qemu-devel] [PATCH v3 0/4] m25p80: Fix debug printfery

2013-04-16 Thread Edgar E. Iglesias
On Tue, Apr 16, 2013 at 10:32:14AM +1000, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Fix up the debug printfery m25p80 in various ways. 0 functional diff. changed from v2: Rebased against hw reorg Applied, thanks! Cheers, Edgar Peter

Re: [Qemu-devel] [PATCH 00/16 v4] target-i386: CPU hot-add with cpu-add QMP command

2013-04-16 Thread Jan Kiszka
On 2013-04-16 00:12, Igor Mammedov wrote: Implements alternative way for hot-adding CPU using cpu-add QMP command, wich could be useful until it would be possible to add CPUs via device_add. Didn't track the full story: What prevents currently a device_add approach? And that so effectively that

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Markus Armbruster
Gcc issue, perhaps Paolo [cc'ed] got an idea. Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/16/2013 08:48 AM, Alexey Kardashevskiy wrote: On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey

Re: [Qemu-devel] Fedora core 2 filesystem

2013-04-16 Thread Stefan Hajnoczi
On Mon, Apr 15, 2013 at 02:29:03PM +0100, Benito wrote: I have a question regarding qemu. Is it possible to take a working root filesystem ( old machine running Fedora core 2 ) and emulate it with qemu on a new PC running a modern Linux distribution ? If so , is it going to be a nightmare to

Re: [Qemu-devel] [PATCH 4/4] qemu-iotests: add 053 unaligned compressed image size test

2013-04-16 Thread Stefan Hajnoczi
On Mon, Apr 15, 2013 at 09:38:28AM -0600, Eric Blake wrote: On 04/15/2013 09:17 AM, Stefan Hajnoczi wrote: Test that qemu-img convert -c works when input image length is not a multiple of the cluster size. Previously an error message would be produced: qemu-img: error while

Re: [Qemu-devel] [PATCH 07/12] configure: fix TPM logic

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 10:28, Markus Armbruster ha scritto: Breaks the build for me: make: Entering directory `/work/armbru/qemu/bld-x86' make[1]: *** No rule to make target `../tpm/tpm_tis.o', needed by `qemu-system-x86_64'. make[1]: Target `all' not remade because of errors. make: ***

Re: [Qemu-devel] [PATCH v5] sheepdog: add discard/trim support for sheepdog

2013-04-16 Thread Kevin Wolf
Am 16.04.2013 um 10:18 hat Stefan Hajnoczi geschrieben: On Tue, Apr 16, 2013 at 12:15:04AM +0800, Liu Yuan wrote: @@ -727,6 +730,20 @@ static void coroutine_fn aio_read_response(void *opaque) rsp.result = SD_RES_SUCCESS; } break; +case

Re: [Qemu-devel] [qapi] Cannot use list of strings

2013-04-16 Thread Stefan Hajnoczi
On Mon, Apr 15, 2013 at 10:04:24PM +0200, Lluís Vilanova wrote: Tried using a list of strings as an argument to a command, but the generated code references the 'strList' type, which does not exist. Is a specialized version for ['str'] missing, or should I define my own type with a single

[Qemu-devel] [PATCH build-breakage] build: include config-{, all-}devices.mak after defining CONFIG_SOFTMMU and CONFIG_USER_ONLY

2013-04-16 Thread Paolo Bonzini
Moving the inclusions closer to Makefile, and before rules.mak, makes Makefile and Makefile.target more consistent with each other. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile| 12 ++-- Makefile.target | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH 4/4] qemu-iotests: add 053 unaligned compressed image size test

2013-04-16 Thread Kevin Wolf
Am 16.04.2013 um 10:36 hat Stefan Hajnoczi geschrieben: On Mon, Apr 15, 2013 at 09:38:28AM -0600, Eric Blake wrote: On 04/15/2013 09:17 AM, Stefan Hajnoczi wrote: Test that qemu-img convert -c works when input image length is not a multiple of the cluster size. Previously an error

Re: [Qemu-devel] [qapi] Cannot use list of strings

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 10:49, Stefan Hajnoczi ha scritto: Tried using a list of strings as an argument to a command, but the generated code references the 'strList' type, which does not exist. Is a specialized version for ['str'] missing, or should I define my own type with a single field

Re: [Qemu-devel] [PATCH 0/4] qemu-img: support compression regardless of cluster size

2013-04-16 Thread Kevin Wolf
Am 15.04.2013 um 17:17 hat Stefan Hajnoczi geschrieben: It was hard to find a short email subject line. Anyway, the problem is that qemu-img convert -c fails with the following error message if the input image length is not a multiple of the output cluster size: qemu-img: error while

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Markus Armbruster
Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April

Re: [Qemu-devel] [PATCH v5] sheepdog: add discard/trim support for sheepdog

2013-04-16 Thread Liu Yuan
On 04/16/2013 04:47 PM, Kevin Wolf wrote: Am 16.04.2013 um 10:18 hat Stefan Hajnoczi geschrieben: On Tue, Apr 16, 2013 at 12:15:04AM +0800, Liu Yuan wrote: @@ -727,6 +730,20 @@ static void coroutine_fn aio_read_response(void *opaque) rsp.result = SD_RES_SUCCESS;

[Qemu-devel] [PATCH v2 0/4] qemu-img: support compression regardless of cluster size

2013-04-16 Thread Stefan Hajnoczi
It was hard to find a short email subject line. Anyway, the problem is that qemu-img convert -c fails with the following error message if the input image length is not a multiple of the output cluster size: qemu-img: error while compressing sector 0: Input/output error Ilkka Tengvall

[Qemu-devel] [PATCH v2 1/4] qcow2: allow sub-cluster compressed write to last cluster

2013-04-16 Thread Stefan Hajnoczi
Compression in qcow2 requires image length to be a multiple of the cluster size. Lift this requirement by zero-padding the final cluster when necessary. The virtual disk size is still not cluster-aligned, so the guest cannot access the zero sectors. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 3/4] qemu-img: do not zero-pad the compressed write buffer

2013-04-16 Thread Stefan Hajnoczi
bdrv_write_compressed() does not allow requests that span the end of the device. Therefore it is useless to zero-pad the last cluster and thereby exceed the end of the device. Let image formats handle zero-padding the final compressed cluster, if necessary. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 4/4] qemu-iotests: add 053 unaligned compressed image size test

2013-04-16 Thread Stefan Hajnoczi
Test that qemu-img convert -c works when input image length is not a multiple of the cluster size. Previously an error message would be produced: qemu-img: error while compressing sector 0: Input/output error Now that qcow2 and qcow handle this case the test passes successfully.

[Qemu-devel] [PATCH v2 2/4] qcow: allow sub-cluster compressed write to last cluster

2013-04-16 Thread Stefan Hajnoczi
Compression in qcow requires image length to be a multiple of the cluster size. Lift this requirement by zero-padding the final cluster when necessary. The virtual disk size is still not cluster-aligned, so the guest cannot access the zero sectors. Note that this is almost identical to the

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-16 Thread Gerd Hoffmann
On 04/10/13 15:23, Paolo Bonzini wrote: After attaching the source, we have to remove the reference we hold to it, because we do not hold anymore a pointer to the source. If we do not do this, removing the source will not finalize it and will not drop the real I/O watch source. This

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 09:57, Markus Armbruster ha scritto: I think this is just beautiful. Fedora18, x86_64, NO cross compiler. gcc does not apply -Wredundant-decls to /usr/include/* but does it for all other headers and in the case of cross compilation I hit this case. '-Wsystem-headers' Print

Re: [Qemu-devel] SoC Idea: Xbox target

2013-04-16 Thread Stefan Hajnoczi
On Tue, Apr 16, 2013 at 11:03 AM, Niel van der Westhuizen nielg...@gmail.com wrote: On 16 April 2013 18:27, Stefan Hajnoczi stefa...@gmail.com wrote: What is the current status of the xbox target and what would a 12-week GSoC project accomplish? The scope of the project needs to be clearly

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 11:15, Gerd Hoffmann ha scritto: On 04/10/13 15:23, Paolo Bonzini wrote: After attaching the source, we have to remove the reference we hold to it, because we do not hold anymore a pointer to the source. If we do not do this, removing the source will not finalize it and will

[Qemu-devel] [PATCH 04/24] hw/vmware_vga.c: various vmware vga fixes.

2013-04-16 Thread Gerd Hoffmann
Hardcode depth to 32 bpp. It effectively was that way before because that is the default surface depth, this just makes it explicit in the code. Rename depth to new_depth to make it consistent with the new_width + new_height names. In theory we can make new_depth changeable (i.e. allow the

[Qemu-devel] [PATCH 11/24] console: displaystate init revamp

2013-04-16 Thread Gerd Hoffmann
We have only one DisplayState, so there is no need for the next linking, rip it. Also consolidate all displaystate initialization into init_displaystate(). This function is called by vl.c after creating the devices (and thus all QemuConsoles) and before initializing DisplayChangeListensers (aka

[Qemu-devel] [PATCH 03/24] hw/vmware_vga.c: add tracepoints for mmio reads+writes

2013-04-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/vmware_vga.c | 112 +-- trace-events|6 +++ 2 files changed, 86 insertions(+), 32 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index

[Qemu-devel] [PATCH 02/24] hw/vmware_vga.c: fix screen resize bug introduced after console revamp

2013-04-16 Thread Gerd Hoffmann
From: Igor Mitsyanko i.mitsya...@gmail.com In vmsvga display update function, a pointer to DisplaySurface must be acquired after a call to vmsvga_check_size since this function might replace current DisplaySurface with a new one. Signed-off-by: Igor Mitsyanko i.mitsya...@gmail.com Signed-off-by:

[Qemu-devel] [PATCH 05/24] pixman: add qemu_pixman_color()

2013-04-16 Thread Gerd Hoffmann
Helper function to map qemu colors (32bit integer + matching PixelFormat) into pixman_color_t. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/qemu-pixman.h |2 ++ ui/qemu-pixman.c | 11 +++ 2 files changed, 13 insertions(+) diff --git

[Qemu-devel] [PATCH 07/24] console: use pixman for fill+blit

2013-04-16 Thread Gerd Hoffmann
Zap homegrown pixel shuffeling code, use pixman calls instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 65 +- 1 file changed, 10 insertions(+), 55 deletions(-) diff --git a/ui/console.c b/ui/console.c index

[Qemu-devel] [PATCH 08/24] console: use pixman for font rendering

2013-04-16 Thread Gerd Hoffmann
Zap homegrown font rendering code, use pixman calls instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 110 ++ 1 file changed, 11 insertions(+), 99 deletions(-) diff --git a/ui/console.c b/ui/console.c index

[Qemu-devel] [PATCH 13/24] console: give each QemuConsole its own DisplaySurface

2013-04-16 Thread Gerd Hoffmann
Go away from the global DisplaySurface, give one to each QemuConsole instead. With this patch applied it is possible to call graphics_hw_* functions with qemu consoles which are not the current foreground console. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h |1 -

[Qemu-devel] [PATCH 01/24] exynos4210_fimd.c: fix display resize bug introduced after console revamp

2013-04-16 Thread Gerd Hoffmann
From: Igor Mitsyanko i.mitsya...@gmail.com In exynos4210 display update function, we were acquiring DisplaySurface pointer before calling screen resize function, not paying attention that resize procedure can replace current DisplaySurface with newly allocated one. Right thing to do is to

[Qemu-devel] [PATCH 20/24] xen: re-enable refresh interval reporting for xenfb

2013-04-16 Thread Gerd Hoffmann
xenfb informs the guest about the gui refresh interval so it can avoid pointless work. That logic was temporarely disabled for the DisplayState reorganization. Restore it now, with a proper interface for it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/xenfb.c | 56

[Qemu-devel] [PATCH 17/24] console: make DisplayState private to console.c

2013-04-16 Thread Gerd Hoffmann
With gui_* being moved to console.c nobody outside console.c needs access to DisplayState fields any more. Make the struct private. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h |8 ui/console.c |8 2 files changed, 8 insertions(+), 8

[Qemu-devel] [PATCH 12/24] console: rename vga_hw_*, add QemuConsole param

2013-04-16 Thread Gerd Hoffmann
Add QemuConsole parameter to vga_hw_*, so the interface allows to update non-active consoles (the actual code can't handle this yet, see next patch). Passing NULL is allowed and updates the active console, like the functions do today. While touching all vga_hw_* calls anyway rename that to the

[Qemu-devel] [PATCH 18/24] console: add GraphicHwOps

2013-04-16 Thread Gerd Hoffmann
Pass a single GraphicHwOps struct pointer to graphic_console_init, instead of a bunch of function pointers. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/arm/musicpal.c|8 ++-- hw/display/blizzard.c|9 ++--- hw/display/cirrus_vga.c |8 ++--

[Qemu-devel] [PATCH 15/24] console: zap g_width + g_height

2013-04-16 Thread Gerd Hoffmann
We have a surface per QemuConsole now, so there is no need to keep track of the QemuConsole size any more as we can query the surface size directly at any time. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 32 +--- 1 file changed, 9

[Qemu-devel] [PATCH 19/24] console: gui timer fixes

2013-04-16 Thread Gerd Hoffmann
Make gui update rate adaption code in gui_update() actually work. Sprinkle in a tracepoint so you can see the code at work. Remove the update rate adaption code in vnc and make vnc simply use the generic bits instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h |

[Qemu-devel] [PATCH 14/24] console: simplify screendump

2013-04-16 Thread Gerd Hoffmann
Screendumps are alot simpler as we can update non-active QemuConsoles now. So we only need to update the QemuConsole we want write out, then dump the DisplaySurface content into a ppm file. Done. No console switching needed. No special support code in the gfx card emulation needed. Zap it

[Qemu-devel] [PATCH 22/24] console: allow pinning displaychangelisteners to consoles

2013-04-16 Thread Gerd Hoffmann
DisplayChangeListener gets a new QemuConsole field, which can be set to non-NULL before registering. This will pin the QemuConsole, so that particular DisplayChangeListener will not follow console switches. spice+gtk (which don't support text console input anyway) are switched over to be pinned

[Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Kevin Wolf
$QEMU_PROG happens to be 'qemu' in my setup, so this sed command replaces a bit too much. Restrict it to the start of the line and to when it's followed by a colon, i.e. the form used by error messages. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/common.filter | 2 +- 1

Re: [Qemu-devel] [PATCH v2 0/4] qemu-img: support compression regardless of cluster size

2013-04-16 Thread Kevin Wolf
Am 16.04.2013 um 11:14 hat Stefan Hajnoczi geschrieben: It was hard to find a short email subject line. Anyway, the problem is that qemu-img convert -c fails with the following error message if the input image length is not a multiple of the output cluster size: qemu-img: error while

Re: [Qemu-devel] [PATCH v3 0/8] virtio-rng refactoring.

2013-04-16 Thread Amit Shah
On (Sun) 14 Apr 2013 [15:01:02], fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This is the last backend of the refactoring. Basically it creates virtio-rng-device which extends virtio-device. Then a virtio-rng-device can be connected on a virtio-bus.

[Qemu-devel] [PATCH 1/9] qxl: add 4k + 8k resolutions

2013-04-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl.c |4 1 file changed, 4 insertions(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 930b7cf..9d8ab58 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -116,6 +116,10 @@ static QXLMode qxl_modes[] = {

[Qemu-devel] [PULL 0/9] spice patch queue

2013-04-16 Thread Gerd Hoffmann
Hi, This is the spice patch queue, carrying flow control fixes, for spice chardevs and (with Amit's ack) virtio-serial. Also some new resolutions for qxl. please pull, Gerd The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0: virtio-balloon: fix dynamic

[Qemu-devel] [PATCH 2/9] qxl: add 2000x2000 and 2048x2048 video modes

2013-04-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 9d8ab58..1f7c8fe 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -109,7 +109,9 @@ static QXLMode qxl_modes[] = { /*

[Qemu-devel] [PATCH 3/9] spice: (32 bit only) fix surface cmd tracking destruction

2013-04-16 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com No change for 64 bit arches, but for 32 bit previously we zeroed half the surfaces cmd array, instead of all of it. Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl.c |2 +- 1 file changed, 1

[Qemu-devel] [PATCH 6/9] spice-qemu-char: Remove #ifdef-ed code for old spice-server compat

2013-04-16 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com We now require spice-server to be = 0.12.0 so this is no longer needed. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- spice-qemu-char.c | 27 +-- 1 file changed, 1

[Qemu-devel] [PATCH 5/9] virtio-console: Remove any pending watches on close

2013-04-16 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/char/virtio-console.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/hw/char/virtio-console.c

[Qemu-devel] [PATCH 24/24] qxl: register QemuConsole for secondary cards

2013-04-16 Thread Gerd Hoffmann
Hook secondary qxl cards properly into the qemu console subsystem. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index bbc6f56..437f8d0 100644 ---

[Qemu-devel] [PATCH 9/9] spice-qemu-char: vmc_write: Don't write more bytes then we're asked too

2013-04-16 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com This one took me eons to debug, but I've finally found it now, oh well. The usage of the MIN macro in this line: last_out = MIN(len, qemu_chr_be_can_write(scd-chr)); Causes qemu_chr_be_can_write to be called *twice*, since the MIN macro evaluates its

Re: [Qemu-devel] [PATCH 00/16 v4] target-i386: CPU hot-add with cpu-add QMP command

2013-04-16 Thread Igor Mammedov
On Tue, 16 Apr 2013 10:30:55 +0200 Jan Kiszka jan.kis...@siemens.com wrote: On 2013-04-16 00:12, Igor Mammedov wrote: Implements alternative way for hot-adding CPU using cpu-add QMP command, wich could be useful until it would be possible to add CPUs via device_add. Didn't track the full

[Qemu-devel] [PATCH 10/24] console: add trace events

2013-04-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- trace-events |3 +++ ui/console.c |4 2 files changed, 7 insertions(+) diff --git a/trace-events b/trace-events index b4d69d6..b08627b 100644 --- a/trace-events +++ b/trace-events @@ -962,6 +962,9 @@ dma_bdrv_cb(void *dbs, int ret)

[Qemu-devel] [PATCH 3/7] xhci: add xhci_cap_write

2013-04-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index c0dbc54..7f740d9 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -3079,8 +3079,15 @@ static void

[Qemu-devel] [PULL 0/7] usb patch queue

2013-04-16 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue. Big new feature is the libusb-based usb-host driver. There also is a usb-serial fix and a small collection of xhci bugfixes. please pull, Gerd The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0: virtio-balloon: fix dynamic

[Qemu-devel] [PATCH 5/7] xhci: use slotid as device address

2013-04-16 Thread Gerd Hoffmann
Is good enougth for unique device addresses and avoids the need for any state for device addressing. Makes live migration support easier. Also makes device-slot lookups trivial. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 25 +++-- 1 file

[Qemu-devel] [PATCH 4/7] xhci: fix portsc writes

2013-04-16 Thread Gerd Hoffmann
Check for port reset first and skip everything else then. Add sanity checks for PLS updates. Add PLC notification when entering PLS_U0 state. This gets host-initiated port resume going on win8. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 42

[Qemu-devel] [PATCH 1/7] usb-serial: Remove double call to qemu_chr_add_handlers( NULL )

2013-04-16 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com usb-serial has a qdev chardev property, and hw/qdev-properties-system.c already contains: static void release_chr(Object *obj, const char *name, void *opaque) { DeviceState *dev = DEVICE(obj); Property *prop = opaque; CharDriverState **ptr =

[Qemu-devel] [PATCH 7/7] use libusb for usb-host

2013-04-16 Thread Gerd Hoffmann
Reimplement usb-host on top of libusb. Reasons to do this: (1) Largely rewritten from scratch, nice opportunity to kill historical cruft. (2) Offload usbfs handling to libusb. (3) Have a single portable code base instead of bsd + linux variants. (4) Bring usb-host support to any platform

[Qemu-devel] [PATCH 6/7] xhci: fix address device

2013-04-16 Thread Gerd Hoffmann
Zero-initialize the set-address dummy USBPacket, also add buffer to avoid sanity checks triggering. https://bugzilla.redhat.com/show_bug.cgi?id=929019 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c |4 1 file changed, 4 insertions(+) diff --git

Re: [Qemu-devel] [qapi] Cannot use list of strings

2013-04-16 Thread Amos Kong
On Tue, Apr 16, 2013 at 10:54:56AM +0200, Paolo Bonzini wrote: Il 16/04/2013 10:49, Stefan Hajnoczi ha scritto: Tried using a list of strings as an argument to a command, but the generated code references the 'strList' type, which does not exist. Is a specialized version for

[Qemu-devel] [PATCH 8/9] spice-qemu-char: Remove intermediate buffer

2013-04-16 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com virtio-serial's buffer is valid when it calls us, and we don't access it otherwise: vmc_read is only called in response to wakeup, or else we set datalen=0 and throttle. Then vmc_read is called back, we return 0 (not accessing the buffer) and set the timer to

[Qemu-devel] [PATCH 2/7] xhci: remove leftover debug printf

2013-04-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index efd4b0d..c0dbc54 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -2526,7 +2526,6 @@ static void

[Qemu-devel] [PATCH 7/9] spice-qemu-char: Add watch support

2013-04-16 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- spice-qemu-char.c | 67 + 1 file changed, 63 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [qemu-devel] Bug Report: VM crashed for some kinds of vCPU in nested virtualization

2013-04-16 Thread 李春奇
I looked up Intel manual for VM instruction error. Error number 7 means VM entry with invalid control field(s), which means in process of VM switching some control fields are not properly configured. I wonder why some emulated CPUs (e.g.Nehalem) can run properly without nested VMCS MSR support?

[Qemu-devel] [PULL v4 00/24] console: console overhaul continued

2013-04-16 Thread Gerd Hoffmann
Hi, Next batch of console cleanup patches. What is in there? (1) qemu text consoles are rendered using pixman now. (2) Each QemuConsole has its own DisplaySurface now, so we can switch consoles without re-rendering the QemuConsole and update non-active consoles. (3) Based on

[Qemu-devel] [PATCH 1/1] rng random backend: check for -EAGAIN errors on read

2013-04-16 Thread Amit Shah
Not handling EAGAIN triggers the assert qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len != -1) Aborted (core dumped) This happens when starting a guest with '-device virtio-rng-pci', issuing a 'cat /dev/hwrng' in the guest, while also doing 'cat /dev/random' on the host.

Re: [Qemu-devel] [qemu-devel] Bug Report: VM crashed for some kinds of vCPU in nested virtualization

2013-04-16 Thread Jan Kiszka
On 2013-04-16 12:19, 李春奇 Arthur Chunqi Li wrote: I looked up Intel manual for VM instruction error. Error number 7 means VM entry with invalid control field(s), which means in process of VM switching some control fields are not properly configured. I wonder why some emulated CPUs

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: [...] This workaround does NOT work if pragmas used. #pragma GCC diagnostic error -Wredundant-decls re-enables warnings as errors. The solution is to use push/pop like this: diff --git a/coroutine-ucontext.c b/coroutine-ucontext.c index

Re: [Qemu-devel] [PATCH] ARM Cortex A9 Global Timer

2013-04-16 Thread Peter Maydell
On 15 April 2013 16:41, François Legal francois.le...@thom.fr.eu.org wrote: I made up this patch to implement the Cortex A9 global timer in Qemu. My patch is based on the Qemu branch maintained by Xilinx for the Zynq. Hi François; thanks for this patch. Some comments on the code below.

[Qemu-devel] [PATCH 21/24] console: add qemu_console_is_*

2013-04-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h |6 +++-- ui/console.c | 59 -- ui/curses.c |7 +++--- ui/sdl.c | 24 ++-- ui/vnc.c |6 ++--- 5 files

Re: [Qemu-devel] [qapi] Cannot use list of strings

2013-04-16 Thread Lluís Vilanova
Paolo Bonzini writes: Il 16/04/2013 10:49, Stefan Hajnoczi ha scritto: Tried using a list of strings as an argument to a command, but the generated code references the 'strList' type, which does not exist. Is a specialized version for ['str'] missing, or should I define my own

[Qemu-devel] [PATCH 4/9] virtio-console: Also throttle when less was written then requested

2013-04-16 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com This is necessary so that we get properly woken up to write the rest. This patch also changes the len argument to the have_data callback, to avoid doing an unsigned signed comparison. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Amit Shah

[Qemu-devel] [PATCH 09/24] console: switch color_table_rgb to pixman_color_t

2013-04-16 Thread Gerd Hoffmann
Now that all text console rendering uses pixman we can easily switch the color tables to use pixman_color_t directly. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/ui/console.c

[Qemu-devel] [PATCH 23/24] gtk: custom cursor support

2013-04-16 Thread Gerd Hoffmann
Makes gtk ui play nicely with qxl (and vmware_svga) as you can actually see your pointer now ;) Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 33 + 1 file changed, 33 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index e9ebbd3..d48529a 100644

  1   2   3   >