[Qemu-devel] [PATCH v4] net: introduce command to query rx-filter information

2013-05-23 Thread Amos Kong
We want to implement mac programming over macvtap through Libvirt. The related rx-filter information of the nic contains main mac, rx-mode items. This patch adds a QMP event to notify management of rx-filter change, and adds a monitor command for management to query rx-filter information. A flag

[Qemu-devel] [RFC/RFT PATCH v1 2/2] audio/intel-hda: QOM casting sweep

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style casting. Signed-off-by: Peter Crosthwaite --- hw/audio/intel-hda.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/

[Qemu-devel] [RFC/RFT PATCH v1 1/2] audio/intel-hda: Fix Inheritance hierachy

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite The ich6 and ich9 variants either need to inherit one from the other, or both from a common base class, otherwise its not possible to create a QOM cast macro for use by the shared implementation functions. Went for option B, with a common base class. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-23 Thread Jan Kiszka
On 2013-05-23 20:04, Peter Maydell wrote: > On 21 May 2013 11:57, Paolo Bonzini wrote: >> +bool address_space_valid(AddressSpace *as, hwaddr addr, int len, bool >> is_write) >> +{ >> +AddressSpaceDispatch *d = as->dispatch; >> +MemoryRegionSection *section; >> +int l; >> +hwaddr p

[Qemu-devel] [PATCH v3 5/5] xilinx_zynq: added devcfg to machine model

2013-05-23 Thread peter . crosthwaite
From: "Peter A. G. Crosthwaite" Signed-off-by: Peter A. G. Crosthwaite --- Changed since v1: Added manual parenting of devcfg node (evil but needed for early access to canonical path by devcfgs realize fn). hw/arm/xilinx_zynq.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/arm

[Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-23 Thread peter . crosthwaite
From: "Peter A. G. Crosthwaite" Minimal device model for devcfg module of Zynq. DMA capabilities and interrupt generation supported. Signed-off-by: Peter A. G. Crosthwaite --- Changed since v2: Some QOM styling updates. Re-implemented nw0 for lock register as pre_write Changed since v1: Rebased

[Qemu-devel] [PATCH v3 3/5] register: Add Memory API glue

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite Add memory io handlers that glue the register API to the memory API. Just translation functions at this stage. Although it does allow for devices to be created without all-in-one mmio r/w handlers. Signed-off-by: Peter Crosthwaite --- changed from v2: Added fast path to

[Qemu-devel] [PATCH v3 2/5] register: Add Register API

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite This API provides some encapsulation of registers and factors our some common functionality to common code. Bits of device state (usually MMIO registers), often have all sorts of access restrictions and semantics associated with them. This API allow you to define what thos

[Qemu-devel] qmp commands get rejected

2013-05-23 Thread Stefan Priebe
Hello list, since upgrading from qemu 1.4.1 to 1.5.0 i've problems with qmp commands. With Qemu 1.5 i've the following socket communication: '{"execute":"qmp_capabilities","id":"12125:1","arguments":{}}' '{"return": {}, "id": "12125:1"}' '{"execute":"qom-set","id":"12125:2","arguments":{"valu

[Qemu-devel] [PATCH v3 1/5] bitops: Add ONES macro

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite Little macro that just gives you N ones (justified to LSB). Signed-off-by: Peter Crosthwaite --- include/qemu/bitops.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index affcc96..da47fc8 100644 --- a/include/qemu/b

[Qemu-devel] [PATCH v3 0/5] Data Driven device registers & Zynq DEVCFG

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite Hi All. This is a new scheme i've come up with handling device registers in a data driven way. My motivation for this is to factor out a lot of the access checking that seems to be replicated in every device. See P2 commit message for further discussion. P1 is a trivial a

[Qemu-devel] [PATCH v6 12/12] curl: set s->url to NULL after free.

2013-05-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/curl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/curl.c b/block/curl.c index bce2e8a..50c7188 100644 --- a/block/curl.c +++ b/block/curl.c @@ -741,6 +741,7 @@ static void curl_close(BlockDriverState *bs) } g_free(s->url); +s->url

Re: [Qemu-devel] [PATCH v5 1/4] Add i.MX FEC Ethernet emulator

2013-05-23 Thread Peter Crosthwaite
Hi JC, All major comments addressed. Few minor suggestions. On Wed, May 8, 2013 at 6:28 PM, Jean-Christophe DUBOIS wrote: > This is based on the mcf_fec.c FEC implementation for ColdFire. > > * a generic phy was added (borrowed from lan9118). > * The buffer management is also modified as

[Qemu-devel] [PATCH v6 09/12] curl: add cache quota.

2013-05-23 Thread Fam Zheng
Introduce a cache quota: BDRVCURLState.cache_quota. When adding new CURLDataCache to BDRVCURLState, if number of existing CURLDataCache is larger than CURL_CACHE_QUOTA, try to release some first to limit the in memory cache size. A least used entry is selected for releasing. Signed-off-by: Fam Zh

[Qemu-devel] [PATCH v6 11/12] block/curl.c: Refuse to open the handle for writes.

2013-05-23 Thread Fam Zheng
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones Signed-off-by: Fam Zheng --- block/curl.c | 4 1 file changed, 4 insertions(+) diff --git a/block/curl.c b/block/curl.c index e067417..bce2e8a 100644 --- a/block/curl.c +++ b/block/curl.c @@ -454,6 +454,10 @@ static int curl_op

[Qemu-devel] [PATCH v6 07/12] curl: make use of CURLDataCache.

2013-05-23 Thread Fam Zheng
Make subsequecial changes to make use of introduced CURLDataCache. Moved acb struct from CURLState to BDRVCURLState, and changed to list. Signed-off-by: Fam Zheng --- block/curl.c | 170 --- 1 file changed, 92 insertions(+), 78 deletions(-)

[Qemu-devel] [PATCH v6 10/12] curl: introduce ssl_no_cert runtime option.

2013-05-23 Thread Fam Zheng
Added an option to let curl disable ssl certificate check. Signed-off-by: Fam Zheng --- block/curl.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 6e893d0..e067417 100644 --- a/block/curl.c +++ b/block/curl.c @@ -95,6 +95,8 @@

[Qemu-devel] [PATCH v6 06/12] curl: introduce CURLDataCache

2013-05-23 Thread Fam Zheng
Data buffer was contained by CURLState, they are allocated and freed together. This patch try to isolate them, by introducing a dedicated cache list to BDRVCURLState. The benifit is we can now release the CURLState (and associated sockets) while keep the fetched data for later use, and simplies the

[Qemu-devel] [PATCH v6 08/12] curl: use list to store CURLState

2013-05-23 Thread Fam Zheng
Make it consistent to other structures to use QLIST to store CURLState. It also simplifies initialization and releasing of data. Signed-off-by: Fam Zheng --- block/curl.c | 82 +++- 1 file changed, 37 insertions(+), 45 deletions(-) diff --

[Qemu-devel] [PATCH v6 05/12] curl: add timer to BDRVCURLState

2013-05-23 Thread Fam Zheng
libcurl uses timer to manage ongoing sockets, it needs us to supply timer. This patch introduce QEMUTimer to BDRVCURLState and handles timeouts as libcurl expects (curl_multi_timer_cb sets given timeout value on the timer and curl_timer_cb calls curl_multi_socket_action on triggered). Signed-off-b

[Qemu-devel] [PATCH v6 03/12] curl: change curl_multi_do to curl_fd_handler

2013-05-23 Thread Fam Zheng
The driver calls curl_multi_do to take action at several points, while it's also registered as socket fd handler. This patch removes internal call of curl_multi_do because they are not necessary when handler can be called by socket data update. Since curl_multi_do becomes a pure fd handler, the fu

[Qemu-devel] [PATCH v6 04/12] curl: fix curl_open

2013-05-23 Thread Fam Zheng
Change curl_size_cb to curl_header_cb, as what the function is really doing. Fix the registering, CURLOPT_WRITEFUNCTION is apparently wrong, should be CURLOPT_HEADERFUNCTION. Parsing size from header is not necessary as we're using curl_easy_getinfo(state->curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD

[Qemu-devel] [PATCH v6 02/12] curl: change magic number to sizeof

2013-05-23 Thread Fam Zheng
String field length is duplicated in two places. Make it a sizeof. Signed-off-by: Fam Zheng --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index a829fe7..a11002b 100644 --- a/block/curl.c +++ b/block/curl.c @@ -569,7 +569,7 @@ sta

[Qemu-devel] [PATCH v6 01/12] curl: introduce CURLSockInfo to BDRVCURLState.

2013-05-23 Thread Fam Zheng
We use socket provided by curl in the driver. Libcurl multi interface has option CURLMOPT_SOCKETFUNCTION for socket. Per man 3 curl_multi_setopt: ... CURLMOPT_SOCKETFUNCTION Pass a pointer to a function matching the curl_socket_callback prototype. The curl_multi_socket_action(3)

[Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-23 Thread Fam Zheng
CURL library API has changed, the current curl driver is not working with current libcurl. It may or may not have worked with old libcurl, but currently, when testing with apache http URL, it just hangs before fetching any data. The problem is because the mismatch of our code and how libcurl wants

Re: [Qemu-devel] [PATCH v5 2/4] Add i.MX I2C controller emulator

2013-05-23 Thread Peter Crosthwaite
Hi JC, All blocker comments are addressed from my reviews. Only a few minor suggestions below. On Wed, May 8, 2013 at 6:28 PM, Jean-Christophe DUBOIS wrote: > The slave mode is not implemented. This may be worth a LOG_UNIMP in there somewhere (on detection of selection or use in slave mode?) >

[Qemu-devel] [PATCH arm-devs v2 5/5] sd/sd.c: Fix "inquiry" ACMD41

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite QEMU models two (of the three) ACMD41 has two modes, "inquiry" and "first". The selection logic for which of the two is incorrect - it compares != 0 for the entire argument value rather than only bits 23:0 as per the spec. Fix. Signed-off-by: Peter Crosthwaite --- Change

[Qemu-devel] [PATCH arm-devs v2 4/5] sd/sdhci:ADMA: fix interrupt

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite The end of transfer check was occurring and potentially returning before the interrupt flag was checked. This means the interrupt will be missed if it occurs on the last packet. Fix by checking for the interrupt before checking for the end of transfer. Signed-off-by: Pete

[Qemu-devel] [PATCH arm-devs v2 3/5] sd/sdhci.c: Fix bdata_read DPRINT message

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite This message was printing out the data in decimal only, which is not very friendly to the debugging developer. Add hex variant in parenthesis to make it consistent with other similar messages in this module. Signed-off-by: Peter Crosthwaite Reviewed-by: Igor Mitsyanko R

[Qemu-devel] [PATCH arm-devs v2 2/5] sd/sdhci: Fix Buffer Write Ready interrupt

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite This interrupt is not risen after the last block is written to sd. It is mutually exclusive with the end of transfer conditions. Fix. Signed-off-by: Peter Crosthwaite Reviewed-by: Igor Mitsyanko --- hw/sd/sdhci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions

[Qemu-devel] [PATCH arm-devs v2 1/5] sd/sdhci.c: Only reset data_count on new commands

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite The data_count variable was being reset on every transfer, including DMA transfer resumptions. This is incorrect, it should only be set on a new command. Manifests as a bug when using ADMA and there is a timer delay between ADMA frames where the fifo is left in a non empt

[Qemu-devel] [PATCH arm-devs v2 0/5] SD and SDHCI Fixes

2013-05-23 Thread peter . crosthwaite
From: Peter Crosthwaite Fixes found in SD and SDHCI found doing some corner case testing. Changed from v1: Corrected ACMD41 patch. Moved ACMD41 patch to back of series. Peter Crosthwaite (5): sd/sdhci.c: Only reset data_count on new commands sd/sdhci: Fix Buffer Write Ready interrupt sd/

Re: [Qemu-devel] [PATCH v5 08/11] curl: use list to store CURLState

2013-05-23 Thread Fam Zheng
On Thu, 05/23 16:32, Stefan Hajnoczi wrote: > On Thu, May 23, 2013 at 11:38:06AM +0800, Fam Zheng wrote: > > @@ -660,9 +651,13 @@ static BlockDriverAIOCB > > *curl_aio_readv(BlockDriverState *bs, > > static void curl_close(BlockDriverState *bs) > > { > > BDRVCURLState *s = bs->opaque; > > -

Re: [Qemu-devel] [PATCH arm-devs v1 1/5] sd/sd.c: Fix "inquiry" ACMD41

2013-05-23 Thread Peter Crosthwaite
Hi Igor, On Thu, May 23, 2013 at 8:31 PM, Igor Mitsyanko wrote: > On 05/23/2013 03:42 AM, Peter Crosthwaite wrote: >> Hi Igor, >> >> On Wed, May 22, 2013 at 11:37 PM, Igor Mitsyanko >> wrote: >>> >>> On 05/21/2013 10:50 AM, peter.crosthwa...@xilinx.com wrote: >>> >>> From: Peter Crosthwaite >>

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Amos Kong
On Thu, May 23, 2013 at 01:23:40PM +0300, Michael S. Tsirkin wrote: > On Thu, May 23, 2013 at 05:08:00PM +0800, Amos Kong wrote: > > +info->broadcast_allowed = n->nobcast; > > +info->multicast_overflow = n->mac_table.multi_overflow; > > +info->unicast_overflow = n->mac_table.uni_overfl

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Amos Kong
On Thu, May 23, 2013 at 11:33:37AM -0400, Luiz Capitulino wrote: > On Thu, 23 May 2013 17:57:56 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote: > > > On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote: > > > >>> Please stress this is only for th

Re: [Qemu-devel] [Libguestfs] ANNOUNCE: libguestfs 1.22 has been released

2013-05-23 Thread Kashyap Chamarthy
On 05/23/2013 05:53 PM, Richard W.M. Jones wrote: > I'm pleased to announce the next stable release of libguestfs (1.22). Great work! == $ ./autogen.sh && make -j 7 && \ time make -k check LIBGUESTFS_DEBUG=1 \ LIBGUESTFS_TRACE=1 |& tee \ /var/tmp/make-check-libugestfs-24-may.log =

Re: [Qemu-devel] [PATCH v5 07/11] curl: make use of CURLDataCache.

2013-05-23 Thread Fam Zheng
On Thu, 05/23 16:23, Stefan Hajnoczi wrote: > On Thu, May 23, 2013 at 11:38:05AM +0800, Fam Zheng wrote: > > @@ -221,31 +215,35 @@ static void curl_complete_io(BDRVCURLState *bs, > > CURLAIOCB *acb, > > > > static size_t curl_read_cb(void *ptr, size_t size, size_t nmemb, void > > *opaque) > >

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Amos Kong
On Thu, May 23, 2013 at 12:03:25PM -0400, Luiz Capitulino wrote: > On Thu, 23 May 2013 17:08:00 +0800 > Amos Kong wrote: > > A flag is used to avoid events flooding, if user don't query > > rx-filter after receives one event, new events won't be sent > > to qmp monitor. > > +RxFilterInfoList *q

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Amos Kong
On Thu, May 23, 2013 at 06:14:19AM -0600, Eric Blake wrote: > On 05/23/2013 03:08 AM, Amos Kong wrote: > > +RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name, > > + Error **errp) > > +{ > > +NetClientState *nc; > > +RxFilterInfoList

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-23 Thread li guang
在 2013-05-23四的 15:41 +0300,Michael S. Tsirkin写道: > Juan is not available now, and Anthony asked for > agenda to be sent early. > So here comes: > > Agenda for the meeting Tue, May 28: > > - Generating acpi tables > > - Switching the call to a bi-weekly schedule > > Please, send any topic that y

Re: [Qemu-devel] use O_DIRECT to open disk images for IDE failed under xen-4.1.2 and qemu upstream

2013-05-23 Thread Gonglei (Arei)
Hi, > > On Thu, 23 May 2013, Gonglei (Arei) wrote: > > Hi, all > > > > I use O_DIRECT to open disk images for IDE, but I'm failed. After debug, I > > get > the below logs: > > [2013-05-22 23:25:46] ide: CMD=c8 > > [2013-05-22 23:25:46] bmdma: readb 0x00 : 0x08 > > [2013-05-22 23:25:46] bmdma: wr

Re: [Qemu-devel] [PATCH v5 06/11] curl: introduce CURLDataCache

2013-05-23 Thread Fam Zheng
On Thu, 05/23 16:09, Stefan Hajnoczi wrote: > On Thu, May 23, 2013 at 11:38:04AM +0800, Fam Zheng wrote: > > +typedef struct CURLDataCache { > > +char *data; > > +size_t base_pos; > > Must be int64_t. QEMU compiled on 32-bit hosts would only allow 4 GB > images with size_t! OK. > > > +

Re: [Qemu-devel] [PATCH v5 05/11] curl: add timer to BDRVCURLState

2013-05-23 Thread Fam Zheng
On Thu, 05/23 15:55, Stefan Hajnoczi wrote: > On Thu, May 23, 2013 at 11:38:03AM +0800, Fam Zheng wrote: > > diff --git a/block/curl.c b/block/curl.c > > index fc464ad..4fd5bb9 100644 > > --- a/block/curl.c > > +++ b/block/curl.c > > @@ -89,6 +89,7 @@ typedef struct BDRVCURLState { > > QLIST_H

Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

2013-05-23 Thread li guang
don't know if these changes are worth, but, anyhow it was discussed before, so, ping ... again. 在 2013-04-23二的 16:16 +0800,liguang写道: > remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF > as suggested by Richard Henderson > > Li Guang (12) >target-i386/helper: remove EAX macr

[Qemu-devel] [PATCH 2/4] debugcon: make debug message more readable

2013-05-23 Thread liguang
before change: Bdebugcon: write addr=0x val=0x6f odebugcon: write addr=0x val=0x6f odebugcon: write addr=0x val=0x74 tdebugcon: write addr=0x val=0x69 idebugcon: write addr=0x val=0x6e ndebugcon: write addr=0x val=0x67 gdebugcon: write addr=0x val=0x20 debugcon: write a

[Qemu-devel] [PATCH 3/4] debugcon: fix compiler warning when open DEBUG_DEBUGCON

2013-05-23 Thread liguang
compiler warnings: CChw/char/debugcon.o hw/char/debugcon.c: In function ‘debugcon_ioport_write’: hw/char/debugcon.c:58: warning: format ‘%02x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’ hw/char/debugcon.c: In function ‘debugcon_ioport_read’: hw/char/debugcon.c:70: warnin

[Qemu-devel] [PATCH 4/4] debugcon: use fprintf(stderr...) instead of printf

2013-05-23 Thread liguang
suggested by Andreas Färber Signed-off-by: liguang --- hw/char/debugcon.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c index 3b0637d..be20ede 100644 --- a/hw/char/debugcon.c +++ b/hw/char/debugcon.c @@ -55,7 +55,8 @@ static

[Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-23 Thread liguang
when enable DEBUG_DEBUGCON, there are some message printing bugs, so fix them. this patch-set based on previous 3 patches, http://comments.gmane.org/gmane.comp.emulators.qemu/212550 http://comments.gmane.org/gmane.comp.emulators.qemu/212551 http://comments.gmane.org/gmane.comp.emulators.qemu/21255

[Qemu-devel] [PATCH 1/4] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON

2013-05-23 Thread liguang
when use DEBUG_DEBUGCON, screen spits: debugcon: write addr=0x val=0x00 Rdebugcon: write addr=0x val=0x00 udebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=0x00 idebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=

Re: [Qemu-devel] [PATCH V2 5/5] block: dump to specified output for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-23 Thread Wenchao Xia
于 2013-5-24 9:48, Wenchao Xia 写道: 于 2013-5-23 23:31, Eric Blake 写道: On 05/23/2013 02:47 AM, Wenchao Xia wrote: Buffer is not used now so the string would not be truncated any more. They can be used by both qemu and qemu-img with correct parameter specified. Signed-off-by: Wenchao Xia --- bl

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-23 Thread li guang
在 2013-05-24五的 10:24 +0900,Isaku Yamahata写道: > On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: > > 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: > > > Why? > > > And it breaks pointer operation like > > > > the fact is I can't guess why gpe->sts is defined uint8_t > > but the real hardwa

Re: [Qemu-devel] [PATCH V2 5/5] block: dump to specified output for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-23 Thread Wenchao Xia
于 2013-5-23 23:31, Eric Blake 写道: On 05/23/2013 02:47 AM, Wenchao Xia wrote: Buffer is not used now so the string would not be truncated any more. They can be used by both qemu and qemu-img with correct parameter specified. Signed-off-by: Wenchao Xia --- block/qapi.c | 65

Re: [Qemu-devel] [PATCH V2 4/5] util: add new function message_printf()

2013-05-23 Thread Wenchao Xia
于 2013-5-23 23:05, Eric Blake 写道: On 05/23/2013 02:47 AM, Wenchao Xia wrote: This function takes an input parameter *output, which can be specified by caller as stderr, stdout or a monitor. error_vprintf() now calls message_vprintf(), which is a static function added in this patch. Signed-off-

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-23 Thread Isaku Yamahata
On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: > 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: > > Why? > > And it breaks pointer operation like > > the fact is I can't guess why gpe->sts is defined uint8_t > but the real hardware is 32-bit width. Which section of ACPI spec? > I expa

Re: [Qemu-devel] [PATCH] qemu-kvm: fix unmatched RAM alloction/free

2013-05-23 Thread Hao, Xudong
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, May 24, 2013 1:13 AM > To: Hao, Xudong > Cc: k...@vger.kernel.org; g...@redhat.com; qemu-devel@nongnu.org > Subject: Re: [PATCH] qemu-kvm: fix unmatched RAM alloction/free > > > mmap is used in qemu_vma

Re: [Qemu-devel] [PATCH 0/4] add ACPI Embedded Controller

2013-05-23 Thread li guang
Hi, Andreas, Paolo As you have commented on the raw RFC patch before, can you also give some comments on these? and all who are interested in this topic(ACPI EC), waiting for you comments Thanks a lot! 在 2013-05-22三的 11:46 +0800,liguang写道: > These patches try to add ACPI Embedded Controller (

Re: [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable

2013-05-23 Thread li guang
在 2013-05-23四的 15:06 +0200,Andreas Färber写道: > Am 23.05.2013 08:58, schrieb liguang: > > before change: > > Bdebugcon: write addr=0x val=0x6f > > odebugcon: write addr=0x val=0x6f > > odebugcon: write addr=0x val=0x74 > > tdebugcon: write addr=0x val=0x69 > > idebugcon: write addr=0

Re: [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON

2013-05-23 Thread li guang
在 2013-05-23四的 15:05 +0200,Andreas Färber写道: > Am 23.05.2013 08:58, schrieb liguang: > > when use DEBUG_DEBUGCON, screen spits: > > debugcon: write addr=0x val=0x00 > > Rdebugcon: write addr=0x val=0x00 > > udebugcon: write addr=0x val=0x00 > > ndebugcon: write addr=0x val=0x00 > >

Re: [Qemu-devel] [PATCH v2 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-05-23 Thread li guang
ping ... 在 2013-05-06一的 13:55 +0800,liguang写道: > for helper_{lsl, lar, verr, verw}, there are > common parts, so move them outside, and then > call this new helper-helper function. > > Signed-off-by: liguang > --- > v2: change misc_check_helper to privilege_check > --- > target-i386/seg_helper.

Re: [Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-05-23 Thread li guang
在 2013-05-23四的 10:24 +0100,Peter Maydell写道: > On 23 May 2013 09:35, li guang wrote: > > ping ... again. > > misc_check_helper is still a terrible function name. > Oh, sorry, I ping the obsolete one, I've sent a v2 for your comment: v2: change misc_check_helper to privilege_check http://lists.gn

Re: [Qemu-devel] qemu seabios issue with vhost-scsi

2013-05-23 Thread Asias He
On Thu, May 23, 2013 at 01:31:12PM -0400, Paolo Bonzini wrote: > > > - Messaggio originale - > > Da: "Stefan Hajnoczi" > > A: "Paolo Bonzini" > > Cc: "Badari Pulavarty" , "Asias He" , > > "Nicholas A. Bellinger" > > , "qemu-devel" , "Gleb > > Natapov" > > Inviato: Giovedì, 23 maggio

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-23 Thread Mark Trumpold
I had one question I forgot to ask.. Is it possible to switch from '--cache=writeback' functionality to '--cache=writethrough' (and visa versa) while qemu-nbd is connected to the '/dev/nbd' device? Thank you, Mark T. -Original Message- From: Mark Trumpold [mailto:ma...@netqa.com] Sent:

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Peter Maydell
On 23 May 2013 20:22, Paolo Bonzini wrote: > Il 23/05/2013 19:32, Peter Maydell ha scritto: >> On 21 May 2013 11:57, Paolo Bonzini wrote: >>> > It is not used anywhere. >> So does this get deleted just because it's not used, or because >> it gets in the way of patches later in the series. > > No,

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-23 Thread Mark Trumpold
I have a working configuration using the signal approach suggested by Stefan. 'qemu-nbd.c' is patched as follows: do { main_loop_wait(false); + if (sighup_reported) { + sighup_reported = false; + bdrv_drain_all(); + bdrv_flush_all(); } }

Re: [Qemu-devel] [PATCH 27/30] pci: use memory core for iommu support

2013-05-23 Thread Michael S. Tsirkin
On Tue, May 21, 2013 at 12:57:28PM +0200, Paolo Bonzini wrote: > From: Avi Kivity > > Use the new iommu support in the memory core for iommu support. The only > user, spapr, is also converted, but it still provides a DMAContext > interface until the non-PCI bits switch to AddressSpace. > > Cc:

[Qemu-devel] [Bug 660366] Re: "qemu-img convert -O qcow2 -o backing_file" makes huge images

2013-05-23 Thread Ildar
I guess the problem is solved already. qemu-img version 1.4.0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/660366 Title: "qemu-img convert -O qcow2 -o backing_file" makes huge images Status in QE

[Qemu-devel] [Bug 660366] Re: "qemu-img convert -O qcow2 -o backing_file" makes huge images

2013-05-23 Thread Ildar
** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/660366 Title: "qemu-img convert -O qcow2 -o backing_file" makes huge images Status in QEM

Re: [Qemu-devel] [PATCH 21/30] memory: Add iommu map/unmap notifiers

2013-05-23 Thread Paolo Bonzini
Il 23/05/2013 20:27, Peter Maydell ha scritto: > On 21 May 2013 11:57, Paolo Bonzini wrote: >> From: David Gibson >> >> This patch adds a NotifierList to MemoryRegions which represent IOMMUs >> allowing other parts of the code to register interest in mappings or >> unmappings from the IOMMU. All

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Paolo Bonzini
Il 23/05/2013 19:32, Peter Maydell ha scritto: > On 21 May 2013 11:57, Paolo Bonzini wrote: >> > It is not used anywhere. > So does this get deleted just because it's not used, or because > it gets in the way of patches later in the series. No, it doesn't get in the way, I just preferred to kill

Re: [Qemu-devel] segfault in aio_bh_poll async.c:80 WAS: Re: kvm process disappears

2013-05-23 Thread Stefan Priebe
Am 23.05.2013 12:09, schrieb Paolo Bonzini: Il 22/05/2013 14:24, Stefan Priebe - Profihost AG ha scritto: Am 22.05.2013 um 10:41 schrieb Paolo Bonzini : Il 22/05/2013 08:26, Stefan Priebe - Profihost AG ha scritto: Hi, as i can't reproduce no ;-( i just saw the kernel segfault message and us

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Anthony Liguori
Peter Maydell writes: > On 21 May 2013 11:57, Paolo Bonzini wrote: >> It is not used anywhere. > > So does this get deleted just because it's not used, or because > it gets in the way of patches later in the series. As far as I > can tell the st*_phys_notdirty() are for TCG to update page > tabl

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-23 Thread Anthony Liguori
Corey Bryant writes: > On 05/23/2013 02:03 PM, Anthony Liguori wrote: >> Corey Bryant writes: >> > One of the difficulties in virtualizing a TPM is that it doesn't support > SR-IOV. So the existing passthrough vTPM can only be used by one guest. > We're planning to provide a software emulat

Re: [Qemu-devel] [PATCH 00/30] Introduction of IOMMUs into the memory API

2013-05-23 Thread Peter Maydell
On 23 May 2013 18:25, Peter Maydell wrote: > I'll have a look at the remaining patches now. ...and done. I haven't reviewed the spapr specific stuff, on the assumption that somebody familiar with that h/w will do so. thanks -- PMM

Re: [Qemu-devel] [PATCH 30/30] memory: give name to every AddressSpace

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > From: Alexey Kardashevskiy > > The "info mtree" command in QEMU console prints only "memory" and "I/O" > address spaces while there are actually a lot more other AddressSpace > structs created by PCI and VIO devices. Those devices do not normally > hav

Re: [Qemu-devel] [RFC PATCH v3 05/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-05-23 Thread Tomoki Sekiyama
On 5/23/13 8:22 , "Stefan Hajnoczi" wrote: >On Tue, May 21, 2013 at 11:33:52AM -0400, Tomoki Sekiyama wrote: >> Implements a basic stub of software VSS provider. Currently, this >>modules >> only provides a relay function of events between qemu-guest-agent and >> Windows VSS when VSS finished fil

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-23 Thread Corey Bryant
On 05/23/2013 02:03 PM, Anthony Liguori wrote: Corey Bryant writes: This patch series provides VNVRAM persistent storage support that QEMU can use internally. The initial target user will be a software vTPM 1.2 backend that needs to store keys in VNVRAM and be able to reboot/migrate and ret

Re: [Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details

2013-05-23 Thread Corey Bryant
On 05/23/2013 01:59 PM, Eric Blake wrote: On 05/23/2013 11:44 AM, Corey Bryant wrote: Signed-off-by: Corey Bryant --- Might help to list a sample HMP or QMP usage in the commit message. +++ b/qapi-schema.json @@ -3619,3 +3619,50 @@ '*cpuid-input-ecx': 'int', 'c

Re: [Qemu-devel] [PATCH 29/30] dma: eliminate DMAContext

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > The DMAContext is a simple pointer to an AddressSpace that is now always > already available. Make everyone hold the address space directly, > and clean up the DMA API to use the AddressSpace directly. > > Signed-off-by: Paolo Bonzini Hey look, check

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 20:18:34 +0300 "Michael S. Tsirkin" wrote: > On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote: > > On Thu, 16 May 2013 18:17:23 +0300 > > "Michael S. Tsirkin" wrote: > > > > > > The > > > > existing throttling approach ensures that if the event includes latest

Re: [Qemu-devel] [PATCH 27/30] pci: use memory core for iommu support

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > From: Avi Kivity > > Use the new iommu support in the memory core for iommu support. The only > user, spapr, is also converted, but it still provides a DMAContext > interface until the non-PCI bits switch to AddressSpace. > > Cc: Michael S. Tsirkin >

Re: [Qemu-devel] [PATCH 21/30] memory: Add iommu map/unmap notifiers

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > From: David Gibson > > This patch adds a NotifierList to MemoryRegions which represent IOMMUs > allowing other parts of the code to register interest in mappings or > unmappings from the IOMMU. All IOMMU implementations will need to call > memory_regi

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier

2013-05-23 Thread Tomoki Sekiyama
On 5/23/13 8:12 , "Stefan Hajnoczi" wrote: >On Tue, May 21, 2013 at 11:33:41AM -0400, Tomoki Sekiyama wrote: >> Add C++ keywords to avoid errors in compiling with c++ compiler. >> This also renames class member of PciDeviceInfo to q_class. >> >> Signed-off-by: Tomoki Sekiyama >> --- >> hmp.c

Re: [Qemu-devel] [PATCH 26/30] dma: eliminate old-style IOMMU support

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > The translate function in the DMAContext is now always NULL. > Remove every reference to it. > > Signed-off-by: Paolo Bonzini More long lines. Otherwise Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PULL 12/12] monitor: allow to disable the default monitor

2013-05-23 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-options.hx | 1 + vl.c| 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index fb3961d..bf94862 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2528,6 +2528,7 @@ Redirect the monitor

[Qemu-devel] [PULL 04/12] qapi: enable generation of native list code

2013-05-23 Thread Luiz Capitulino
From: Michael Roth Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs qapi-types.c/qapi-visit.c Signed-off-by: Michael Roth Reviewed-by: Laszlo Ersek Reviewed-by: Amos Kong Signed-off-by: Luiz Capitulino --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[Qemu-devel] [PULL 11/12] ui/input.c: replace magic numbers with macros

2013-05-23 Thread Luiz Capitulino
From: Amos Kong It's clearer to use defined macros than magic numbers. Signed-off-by: Amos Kong Reviewed-by: Lei Li Signed-off-by: Luiz Capitulino --- ui/input.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ui/input.c b/ui/input.c index 8ca1a03..92c44ca 1

Re: [Qemu-devel] [PATCH 20/30] memory: iommu support

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > From: Avi Kivity > > Add a new memory region type that translates addresses it is given, > then forwards them to a target address space. This is similar to > an alias, except that the mapping is more flexible than a linear > translation and trucation,

[Qemu-devel] [PULL 05/12] json-parser: fix handling of large whole number values

2013-05-23 Thread Luiz Capitulino
From: Michael Roth Currently our JSON parser assumes that numbers lacking a fractional value are integers and attempts to store them as QInt/int64 values. This breaks in the case where the number overflows/underflows int64 values (which is still valid JSON) Fix this by detecting such cases and u

[Qemu-devel] [PULL 07/12] qapi: fix visitor serialization tests for numbers/doubles

2013-05-23 Thread Luiz Capitulino
From: Michael Roth We never actually stored the stringified double values into the strings before we did the comparisons. This left number/double values completely uncovered in test-visitor-serialization tests. Fixing this exposed a bug in our handling of large whole number values in QEMU's JSON

[Qemu-devel] [PULL 09/12] qapi: add native list coverage for QMP output visitor tests

2013-05-23 Thread Luiz Capitulino
From: Michael Roth This exercises schema-generated visitors for native list types and does some sanity checking on validity of serialized data. Signed-off-by: Michael Roth Reviewed-by: Laszlo Ersek Reviewed-by: Amos Kong Signed-off-by: Luiz Capitulino --- qapi-schema-test.json |

[Qemu-devel] [PULL 10/12] qapi: add native list coverage for QMP input visitor tests

2013-05-23 Thread Luiz Capitulino
From: Michael Roth This exercises schema-generated visitors for native list types and does some sanity checking on validity of deserialized data. Signed-off-by: Michael Roth Reviewed-by: Laszlo Ersek Reviewed-by: Amos Kong Signed-off-by: Luiz Capitulino --- tests/test-qmp-input-visitor.c |

[Qemu-devel] [PULL 03/12] qapi: qapi-visit.py, native list support

2013-05-23 Thread Luiz Capitulino
From: Michael Roth Teach visitor generators about native types so they can generate the appropriate visitor routines. Signed-off-by: Michael Roth Reviewed-by: Laszlo Ersek Reviewed-by: Amos Kong Signed-off-by: Luiz Capitulino --- scripts/qapi-visit.py | 34 +-

[Qemu-devel] [PULL 06/12] qapi: add QMP input test for large integers

2013-05-23 Thread Luiz Capitulino
From: Michael Roth Large integers previously got capped to LLONG_MAX/LLONG_MIN so we could store them as int64_t. This could lead to silent errors occuring. Now, we use a double to handle these cases. Add a test to confirm that QMPInputVisitor handles this as expected if we're expected an integ

[Qemu-devel] [PULL 08/12] qapi: add native list coverage for visitor serialization tests

2013-05-23 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Reviewed-by: Laszlo Ersek Reviewed-by: Amos Kong Signed-off-by: Luiz Capitulino --- tests/test-visitor-serialization.c | 451 +++-- 1 file changed, 433 insertions(+), 18 deletions(-) diff --git a/tests/test-visit

[Qemu-devel] [PULL 02/12] qapi: qapi-visit.py, fix list handling for union types

2013-05-23 Thread Luiz Capitulino
From: Michael Roth Currently we assume non-list types when generating visitor routines for union types. This is broken, since values like ['Type'] need to mapped to 'TypeList'. We already have a type_name() function to handle this that we use for generating struct visitors, so use that here as w

[Qemu-devel] [PULL 01/12] qapi: qapi-types.py, native list support

2013-05-23 Thread Luiz Capitulino
From: Michael Roth Teach type generators about native types so they can generate the appropriate linked list types. Signed-off-by: Michael Roth Reviewed-by: Laszlo Ersek Reviewed-by: Amos Kong Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py | 45

[Qemu-devel] [PULL 00/12] QMP queue

2013-05-23 Thread Luiz Capitulino
The changes (since 95de21a430f7bc4166a153b1f69b1425c8a99c7b) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Amos Kong (1): ui/input.c: replace magic numbers with macros Luiz Capitulino (1): monitor: allow to disable the default monitor Michae

Re: [Qemu-devel] [PATCH 19/30] memory: Introduce address_space_lookup_region

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > From: Jan Kiszka > > This introduces a wrapper for phys_page_find (before we complicate > address_space_translate with IOMMU translation). This function will > also encapsulate locking and reference counting when we introduce > BQL-free dispatching. >

Re: [Qemu-devel] [PATCH 18/30] memory: add return value to address_space_rw/read/write

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell -- PMM

  1   2   3   >