Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Alexey Kardashevskiy
On 05/27/2013 05:03 PM, Paolo Bonzini wrote: Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: This is only true when the rerror and werror options have the values ignore or report. See virtio-scsi for an example of how to save the requests using the save_request and load_request

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-31 Thread Xiao Guangrong
On 05/31/2013 12:50 AM, Jordan Justen wrote: On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 30 May 2013 18:03:04 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 30/05/2013 17:46, Luiz Capitulino ha scritto: The culprit is commit: commit

Re: [Qemu-devel] [PATCH 10/21] memory: make section size a 128-bit integer

2013-05-31 Thread Alexey Kardashevskiy
On 05/31/2013 07:16 AM, Paolo Bonzini wrote: So far, the size of all regions passed to listeners could fit in 64 bits, because artificial regions (containers and aliases) are eliminated by the memory core, leaving only device regions which have reasonable sizes An IOMMU however cannot be

Re: [Qemu-devel] [Qemu-stable] [QEMU PATCH v3] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path

2013-05-31 Thread Stefan Priebe - Profihost AG
Am 31.05.2013 00:51, schrieb Amos Kong: On Thu, May 30, 2013 at 10:30:21PM +0200, Stefan Priebe wrote: Am 30.05.2013 15:13, schrieb Amos Kong: On Thu, May 30, 2013 at 02:09:25PM +0200, Stefan Priebe - Profihost AG wrote: Am 29.05.2013 09:56, schrieb Amos Kong: Recent virtio refactoring in

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Thu, May 30, 2013 at 7:34 PM, Kevin O'Connor ke...@koconnor.net wrote: On Tue, May 28, 2013 at 07:53:09PM -0400, Kevin O'Connor wrote: There were discussions on potentially introducing a middle component to generate the tables. Coreboot was raised as a possibility, and David thought it

Re: [Qemu-devel] [PATCH 10/21] memory: make section size a 128-bit integer

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 08:56, Alexey Kardashevskiy ha scritto: On 05/31/2013 07:16 AM, Paolo Bonzini wrote: So far, the size of all regions passed to listeners could fit in 64 bits, because artificial regions (containers and aliases) are eliminated by the memory core, leaving only device regions which

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-31 Thread Jordan Justen
On Thu, May 30, 2013 at 11:51 PM, Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: On 05/31/2013 12:50 AM, Jordan Justen wrote: On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 30 May 2013 18:03:04 +0200 Paolo Bonzini pbonz...@redhat.com wrote:

Re: [Qemu-devel] [PATCH] [ARM] Fix rfe instruction

2013-05-31 Thread Peter Maydell
On 31 May 2013 05:50, Peter Chubb peter.ch...@nicta.com.au wrote: The rfe instruction has been broken since patch 5a839c0d54fac9db0516904db873a4fe01f50f4b because of a typo. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Oops. I thought I'd caught all those when I reread the patches

Re: [Qemu-devel] Unable to parse -device drivers containing commas?

2013-05-31 Thread Mark Cave-Ayland
On 30/05/13 13:07, Eric Blake wrote: Is there a way of escaping the commas on the command line so that it is possible to list properties for drivers named in this way? Commas are escaped by doubling them. Try ./qemu-system-sparc -device SUNW,,tcx,help That's the generic quoting we've used

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 12:14 AM, Jordan Justen jljus...@gmail.com wrote: On Thu, May 30, 2013 at 11:51 PM, Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: On 05/31/2013 12:50 AM, Jordan Justen wrote: On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino lcapitul...@redhat.com wrote: On

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Peter Stuge
Kevin O'Connor wrote: one possible way forward would be to split the current SeaBIOS rom into two roms: qvmloader and seabios. The qvmloader would do the qemu specific platform init (pci init, smm init, mtrr init, bios tables) and then load and run the regular seabios rom. qvmloader sounds a

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: On 05/27/2013 05:03 PM, Paolo Bonzini wrote: Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: This is only true when the rerror and werror options have the values ignore or report. See virtio-scsi for an example of how to save the

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 08:51, Xiao Guangrong ha scritto: On 05/31/2013 12:50 AM, Jordan Justen wrote: On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 30 May 2013 18:03:04 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 30/05/2013 17:46, Luiz Capitulino ha

Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

2013-05-31 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 31/05/2013 05:32, David Gibson ha scritto: Then again, although we certainly want to keep changes which require updates to libfdt_env.h rare, I'm not going to rule out extensions to libfdt which add new (minor) external dependencies, and

Re: [Qemu-devel] [PATCH 5/5] memory: able to pin guest node memory to host node manually

2013-05-31 Thread Wanlong Gao
On 05/31/2013 02:22 AM, Eduardo Habkost wrote: On Thu, May 30, 2013 at 05:57:21PM +0800, Wanlong Gao wrote: Use mbind to pin guest numa node memory to host nodes manually. If we are not able to pin memory to host node, we may meet the cross node memory access performance regression. With

[Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem

2013-05-31 Thread Xiao Guangrong
Luiz Capitulino reported that guest refused to boot and qemu complained with: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument It is caused by commit 235e8982ad that did double free for the memslot so that the second one raises the -EINVAL error Fix it by reset memory

Re: [Qemu-devel] [PATCH] ARM: Fix disable interrupt for M profile

2013-05-31 Thread Fabien Chouteau
On 05/30/2013 07:26 PM, Peter Maydell wrote: On 30 May 2013 17:22, Fabien Chouteau chout...@adacore.com wrote: I'm not sure this was expected or not, but it looks like the || should be a . Otherwise it's not possible to disable interrupt. Signed-off-by: Fabien Chouteau chout...@adacore.com

[Qemu-devel] [PATCH V2] ARM: Fix disable interrupt for M profile

2013-05-31 Thread Fabien Chouteau
Fix the condition according to the requirement in the comment above. Otherwise it's not possible to disable interrupt on M-profile. Signed-off-by: Fabien Chouteau chout...@adacore.com --- V2: The expression in the previous patch was wrong. cpu-exec.c |4 ++-- 1 file changed, 2

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Gerd Hoffmann
Hi, I guess -bios would load coreboot. Coreboot would siphon the data necessary for ACPI table building through the current (same) fw_cfg bottleneck, build the tables, Yes. load the boot firmware (SeaBIOS or OVMF or something else -- not sure how to configure that), The coreboot rom has

Re: [Qemu-devel] [PATCH] ARM: Fix disable interrupt for M profile

2013-05-31 Thread Peter Maydell
On 31 May 2013 10:04, Fabien Chouteau chout...@adacore.com wrote: On 05/30/2013 07:26 PM, Peter Maydell wrote: * why this patch fixes it (probably with reference to the architecture manual and to what QEMU means when it sets CPSR_I on M profile [hint: look at how we handle PRIMASK]) I

Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

2013-05-31 Thread Peter Maydell
On 31 May 2013 09:25, Paolo Bonzini pbonz...@redhat.com wrote: Please don't. Fedora is not going to use the bundled dtc because of a policy against bundling, and Fedora's dtc package doesn't include libfdt_env.h. It sounds like Fedora's dtc package is broken then -- are you going to fix it?

Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 11:44, Peter Maydell ha scritto: On 31 May 2013 09:25, Paolo Bonzini pbonz...@redhat.com wrote: Please don't. Fedora is not going to use the bundled dtc because of a policy against bundling, and Fedora's dtc package doesn't include libfdt_env.h. It sounds like Fedora's dtc

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Peter Stuge
Gerd Hoffmann wrote: and pass down the tables to the firmware (through a now unspecified interface -- perhaps the tables could even be installed at this point). As far I know coreboot can add more stuff such as acpi tables to cbfs at runtime and seabios able to access cbfs too and pull

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Gerd Hoffmann
On 05/31/13 10:13, Peter Stuge wrote: Kevin O'Connor wrote: one possible way forward would be to split the current SeaBIOS rom into two roms: qvmloader and seabios. The qvmloader would do the qemu specific platform init (pci init, smm init, mtrr init, bios tables) and then load and run the

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Benjamin Herrenschmidt
On Fri, 2013-05-31 at 15:58 +1000, Alexey Kardashevskiy wrote: And another question (sorry I am not very familiar with terminology but cc:Ben is :) ) - what happens with indirect requests if migration happened in the middle of handling such a request? virtio-scsi does not seem to handle this

[Qemu-devel] git tag for 1.4.2

2013-05-31 Thread Dietmar Maurer
Is there a git tag for 1.4.2?

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Alexey Kardashevskiy
On 05/31/2013 06:18 PM, Paolo Bonzini wrote: Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: On 05/27/2013 05:03 PM, Paolo Bonzini wrote: Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: This is only true when the rerror and werror options have the values ignore or report. See

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Alexey Kardashevskiy
On 05/31/2013 08:07 PM, Benjamin Herrenschmidt wrote: On Fri, 2013-05-31 at 15:58 +1000, Alexey Kardashevskiy wrote: And another question (sorry I am not very familiar with terminology but cc:Ben is :) ) - what happens with indirect requests if migration happened in the middle of handling

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 12:12, Alexey Kardashevskiy ha scritto: On 05/31/2013 06:18 PM, Paolo Bonzini wrote: Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: On 05/27/2013 05:03 PM, Paolo Bonzini wrote: Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: This is only true when the rerror and

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Alexey Kardashevskiy
On 05/31/2013 08:26 PM, Paolo Bonzini wrote: Il 31/05/2013 12:12, Alexey Kardashevskiy ha scritto: On 05/31/2013 06:18 PM, Paolo Bonzini wrote: Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: On 05/27/2013 05:03 PM, Paolo Bonzini wrote: Il 27/05/2013 08:48, Alexey Kardashevskiy ha

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 12:33, Alexey Kardashevskiy ha scritto: How do you trigger the situation when there are inactive requests which have to be migrated? You need to trigger an error. For example, you could use a sparse image on an almost-full partition and let dd fill your disk. Then migrate to

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 12:25, Alexey Kardashevskiy ha scritto: On 05/31/2013 08:07 PM, Benjamin Herrenschmidt wrote: On Fri, 2013-05-31 at 15:58 +1000, Alexey Kardashevskiy wrote: And another question (sorry I am not very familiar with terminology but cc:Ben is :) ) - what happens with indirect

Re: [Qemu-devel] [Qemu-stable] [QEMU PATCH v3] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path

2013-05-31 Thread Amos Kong
On Fri, May 31, 2013 at 08:57:00AM +0200, Stefan Priebe - Profihost AG wrote: Am 31.05.2013 00:51, schrieb Amos Kong: On Thu, May 30, 2013 at 10:30:21PM +0200, Stefan Priebe wrote: Am 30.05.2013 15:13, schrieb Amos Kong: On Thu, May 30, 2013 at 02:09:25PM +0200, Stefan Priebe - Profihost AG

Re: [Qemu-devel] [PATCH] xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)

2013-05-31 Thread Stefano Stabellini
On Thu, 30 May 2013, Stefano Stabellini wrote: On Thu, 30 May 2013, Andreas Färber wrote: Am 30.05.2013 15:20, schrieb Stefano Stabellini: We are currently setting the PCI hole to start at HVM_BELOW_4G_RAM_END, that is 0xf000. Start the PCI hole at 0xe000 instead, that is the

Re: [Qemu-devel] [PATCH v2 0/3] Xen related fixes

2013-05-31 Thread Stefano Stabellini
On Wed, 29 May 2013, Stefano Stabellini wrote: Hi all, I have few simple fixes for Xen for the development tree as well as QEMU 1.5 and older releases: - the first patch is just a cleanup (that is needed to simplify preprocessor dependencies); - the second patch avoids setting

[Qemu-devel] [PATCH scsi-next] vhost-scsi: fix cut-and-paste typo

2013-05-31 Thread Paolo Bonzini
The copied code comes from vhost_scsi_start. Spotted by Coverity. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/vhost-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index

Re: [Qemu-devel] [Qemu-stable] [QEMU PATCH v3] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path

2013-05-31 Thread Stefan Priebe - Profihost AG
Am 31.05.2013 13:02, schrieb Amos Kong: ... thanks for this great explanation. I've done what you sayd but it still does not work. Here is the output of the seabis debug log where you see the loop: http://pastebin.com/raw.php?i=e53rdW2b | found virtio-scsi at 0:5 | Searching bootorder

[Qemu-devel] NBD drives with literal IPv6 addresses or hostnames starting with a digit

2013-05-31 Thread Ján Tomko
Hello, since qemu's commit v1.4.0-736-gf17c90b [1]: nbd: Keep hostname and port separate * literal IPv6 addresses no longer work in nbd URIs, because getaddrinfo is called with the surrounding brackets: $ qemu-system-x86_64 -drive file=nbd://[::1]:1234/quack qemu-system-x86_64: -drive

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 09:09, Jordan Justen wrote: Why is updating the ACPI tables in seabios viewed as such a burden? Either qemu does it, or seabios... (And, OVMF too, but I don't think you guys are concerned with that. :) I am :) On the flip side, why is moving the ACPI tables to QEMU such an

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] qemu: fix out of tree cross compile

2013-05-31 Thread Michael Tokarev
29.05.2013 17:30, Alexey Kardashevskiy wrote: The symlink to asm platform linux headers is made in the build tree by the configure script but gcc is not told to look for them there. The patch fixes this. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] m25p80: Add Micron n25q032a

2013-05-31 Thread Michael Tokarev
29.05.2013 17:58, Ed Maste wrote: Based on the datasheet at http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf Thanks, applied to the trivial patches queue. /mjt

[Qemu-devel] [PATCH scsi-next] iscsi: simplify freeing of tasks

2013-05-31 Thread Paolo Bonzini
Always free them in the iscsi_aio_*_acb functions and remove the checks in their callers. Remove ifs when the task struct was previously dereferenced (spotted by Coverity). Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/iscsi.c | 35

[Qemu-devel] [PATCH] do not check pointers after dereferencing them

2013-05-31 Thread Paolo Bonzini
Two instances, both spotted by Coverity. In one, two blocks were swapped. In the other, the check is not needed anymore. Cc: qemu-sta...@nongnu.org Cc: qemu-triv...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- monitor.c | 2 +- savevm.c | 10 +- 2 files changed, 6

[Qemu-devel] [PATCH scsi-next] iscsi: reorganize iscsi_readcapacity_sync

2013-05-31 Thread Paolo Bonzini
Avoid the goto, and use the same retry logic for the 10- and 16- byte versions. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/iscsi.c | 94 +-- 1 file changed, 46 insertions(+), 48 deletions(-) diff

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Michael Tokarev
31.05.2013 13:39, Thomas Schwinge wrote: Signed-off-by: Thomas Schwinge tho...@codesourcery.com --- fpu/softfloat-specialize.h | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git fpu/softfloat-specialize.h fpu/softfloat-specialize.h index 518f694..83add1a

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread David Woodhouse
On Thu, 2013-05-30 at 09:20 -0700, Jordan Justen wrote: On Thu, May 30, 2013 at 5:19 AM, David Woodhouse dw...@infradead.org wrote: On Thu, 2013-05-30 at 13:13 +0200, Laszlo Ersek wrote: Where is CorebootPkg available from? https://github.com/pgeorgi/edk2/tree/coreboot-pkg Is the

Re: [Qemu-devel] [PATCH] xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 12:58, Stefano Stabellini ha scritto: On Thu, 30 May 2013, Stefano Stabellini wrote: On Thu, 30 May 2013, Andreas Färber wrote: Am 30.05.2013 15:20, schrieb Stefano Stabellini: We are currently setting the PCI hole to start at HVM_BELOW_4G_RAM_END, that is 0xf000. Start the

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread David Woodhouse
On Wed, 2013-05-29 at 21:12 -0400, Kevin O'Connor wrote: I remain doubtful that QOM has all the info needed to generate the BIOS tables. Does QOM describe how the 5th pci device uses global interrupt 11 when using global interrupts, legacy interrupt 5 when not using global interrupts, and

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 14:07, Michael Tokarev ha scritto: 31.05.2013 13:39, Thomas Schwinge wrote: Signed-off-by: Thomas Schwinge tho...@codesourcery.com --- fpu/softfloat-specialize.h | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git fpu/softfloat-specialize.h

Re: [Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 10:52, Xiao Guangrong ha scritto: Luiz Capitulino reported that guest refused to boot and qemu complained with: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument It is caused by commit 235e8982ad that did double free for the memslot so that the second

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-05-31 Thread Amos Kong
On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat implementation. This patch adds support of auto-repeat feature. The

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Peter Maydell
On 31 May 2013 13:07, Michael Tokarev m...@tls.msk.ru wrote: Hmm. And where's the simplification? Here's context diff for the same: *** fpu/softfloat-specialize.h.orig 2013-05-31 16:02:51.614710351 +0400 --- fpu/softfloat-specialize.h 2013-05-31 16:02:59.838820308 +0400 ***

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Eric Blake
On 05/28/2013 12:34 AM, Gerd Hoffmann wrote: Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

2013-05-31 Thread Peter Crosthwaite
Hi, On Fri, May 31, 2013 at 7:54 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 31/05/2013 11:44, Peter Maydell ha scritto: On 31 May 2013 09:25, Paolo Bonzini pbonz...@redhat.com wrote: Please don't. Fedora is not going to use the bundled dtc because of a policy against bundling, and

Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-31 Thread Laszlo Ersek
On 05/31/13 06:41, Jordan Justen wrote: On Thu, May 30, 2013 at 7:06 PM, Kevin O'Connor ke...@koconnor.net wrote: On Wed, May 29, 2013 at 01:27:24AM -0700, Jordan Justen wrote: The isapc machine with seabios currently requires the BIOS region to be read/write memory rather than read-only

Re: [Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem

2013-05-31 Thread Luiz Capitulino
On Fri, 31 May 2013 16:52:18 +0800 Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: Luiz Capitulino reported that guest refused to boot and qemu complained with: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument It is caused by commit 235e8982ad that did double

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Peter Krempa
On 05/31/13 14:36, Eric Blake wrote: On 05/28/2013 12:34 AM, Gerd Hoffmann wrote: Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty

Re: [Qemu-devel] [PATCH] do not check pointers after dereferencing them

2013-05-31 Thread Eric Blake
On 05/31/2013 06:00 AM, Paolo Bonzini wrote: Two instances, both spotted by Coverity. In one, two blocks were swapped. In the other, the check is not needed anymore. Cc: qemu-sta...@nongnu.org Cc: qemu-triv...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- monitor.c |

Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 04:06, Kevin O'Connor ha scritto: On Wed, May 29, 2013 at 01:27:24AM -0700, Jordan Justen wrote: The isapc machine with seabios currently requires the BIOS region to be read/write memory rather than read-only memory. KVM currently cannot support the BIOS as a ROM region,

Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 14:40, Laszlo Ersek ha scritto: I think we've been here before... - always resetting the PAM registers broke S3 resume: http://thread.gmane.org/gmane.comp.emulators.qemu/195931/focus=195932 http://thread.gmane.org/gmane.comp.emulators.qemu/195931/focus=196081 - there was a

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Kevin O'Connor ke...@koconnor.net writes: On Tue, May 28, 2013 at 07:53:09PM -0400, Kevin O'Connor wrote: There were discussions on potentially introducing a middle component to generate the tables. Coreboot was raised as a possibility, and David thought it would be okay to use coreboot for

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 10:13, Peter Stuge wrote: ACPI bytes are obviously a function of QEMU configuration. Precisely! When we evaluate that (mathematical-sense) function in boot firmware, we need to retrieve the function's arguments. Those arguments are bits of QEMU configuration, as you say, and fw_cfg

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread David Woodhouse
On Fri, 2013-05-31 at 07:58 -0500, Anthony Liguori wrote: What about a small change to the SeaBIOS build system to allow ACPI table generation to be done via a plugin. SeaBIOS already accepts ACPI tables from Coreboot or UEFI, and queries them to find things that it needs. This could be as

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Laszlo Ersek ler...@redhat.com writes: On 05/31/13 09:09, Jordan Justen wrote: Due to licensing differences I can't just port code from SeaBIOS to OVMF soapbox Fork OVMF, drop the fat module, and just add GPL code. It's an easily solvable problem. Rewriting BSD implementations of

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-05-31 Thread Wenchao Xia
于 2013-5-30 10:41, Wenchao Xia 写道: 于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Gerd Hoffmann
Hi, Without this patch the returned message for query-chardev is: { return: [ { filename: pty:/dev/pts/8, label: charserial0 }, { filename: unix:/var/lib/libvirt/qemu/qemu-git.monitor,server, label:

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Peter Krempa
On 05/31/13 15:21, Gerd Hoffmann wrote: Hi, Hi, Please double-check. Current master (87d23f78aa79b72da022afda358bbc8a8509ca70 to be exact) works just fine for me. libvirt works, including a serial line redirected to pty, and 'info chardev' looks sane too. sorry for the fuzz. :/

Re: [Qemu-devel] [PATCH qom-cpu v3 4/9] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:56 +0200 Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de Nitpick alarm on. --- include/qom/cpu.h | 10 ++ include/sysemu/memory_mapping.h | 1 - memory_mapping-stub.c | 6 --

Re: [Qemu-devel] [PATCH qom-cpu v3 6/9] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:58 +0200 Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 11 +++ include/sysemu/memory_mapping.h | 2 -- memory_mapping-stub.c | 6 -- memory_mapping.c

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread David Woodhouse
On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote: soapbox Fork OVMF, drop the fat module, and just add GPL code. It's an easily solvable problem. Heh. Actually it doesn't need to be a fork. It's modular, and the FAT driver is just a single module. Which is actually included in

Re: [Qemu-devel] [PATCH qom-cpu v3 9/9] memory_mapping: Change qemu_get_guest_memory_mapping() semantics

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:08:01 +0200 Andreas Färber afaer...@suse.de wrote: Previously it would search for the first CPU with paging enabled and retrieve memory mappings from this and any following CPUs or return an error if that fails. Instead walk all CPUs and if paging is enabled retrieve

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-05-31 Thread Luiz Capitulino
On Fri, 31 May 2013 21:04:10 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-5-30 10:41, Wenchao Xia 写道: 于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp

Re: [Qemu-devel] [PATCH qom-cpu v3 0/9] dump: Build cleanups redone

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:52 +0200 Andreas Färber afaer...@suse.de wrote: Hello, This series is an alternative to patches previously queued or posted, based on virgin master. As requested by Paolo, this replaces Kate's previous memory_mapping split and my follow-ups and instead goes

Re: [Qemu-devel] fixing qemu busy wait

2013-05-31 Thread Paolo Bonzini
Il 18/04/2013 20:47, Orr Dvory ha scritto: is this better? Yes -- but I don't remember if this was fixed elsewhere. Can you reproduce the problem in 1.5.0? If so, please send the patch according to the guidelines at http://wiki.qemu.org/Contribute/SubmitAPatch. Paolo diff -uprN

[Qemu-devel] [PULL 0/3] QMP queue

2013-05-31 Thread Luiz Capitulino
One qapi fix and two fixes that affect the dump-guest-memory QMP command. The changes (since 87d23f78aa79b72da022afda358bbc8a8509ca70) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Luiz Capitulino (1): target-i386: fix abort on bad

[Qemu-devel] [PULL 1/3] qapi: pad GenericList value fields to 64 bits

2013-05-31 Thread Luiz Capitulino
From: Michael Roth mdr...@linux.vnet.ibm.com With the introduction of native list types, we now have types such as int64List where the 'value' field is not a pointer, but the actual 64-bit value. On 32-bit architectures, this can lead to situations where 'next' field offset in GenericList does

[Qemu-devel] [PULL 2/3] target-i386: fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-31 Thread Luiz Capitulino
The code used to walk IA-32e page-tables, and possibly PAE page-tables, uses the bit mask ~0xfff to get the next PML4E/PDPTE/PDE/PTE address. However, as we use a uint64_t to store the resulting address, that mask gets expanded to 0xf000 which not only ends up selecting reserved bits

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 16:08, David Woodhouse wrote: On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote: soapbox Fork OVMF, drop the fat module, and just add GPL code. It's an easily solvable problem. Heh. Actually it doesn't need to be a fork. It's modular, and the FAT driver is just a

[Qemu-devel] [PULL 3/3] target-i386: Fix mask of pte index in memory mapping

2013-05-31 Thread Luiz Capitulino
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com Function walk_pte() needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Jesse Larrew

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Peter Maydell
On 31 May 2013 14:01, Thomas Schwinge tho...@codesourcery.com wrote: On Fri, 31 May 2013 13:34:12 +0100, Peter Maydell peter.mayd...@linaro.org wrote: That said, I think any new patches to fpu/ need to come with an explicit statement that they can be licensed under the softfloat-2a license

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Laszlo Ersek ler...@redhat.com writes: On 05/31/13 15:04, Anthony Liguori wrote: Laszlo Ersek ler...@redhat.com writes: On 05/31/13 09:09, Jordan Justen wrote: Due to licensing differences I can't just port code from SeaBIOS to OVMF soapbox :) Fork OVMF, drop the fat module, and

Re: [Qemu-devel] [PATCH] target-i386: Fix aflag logic for CODE64 and the 0x67 prefix

2013-05-31 Thread Richard Henderson
Ping. On 05/29/2013 12:30 PM, Richard Henderson wrote: The code reorganization in commit 4a6fd938 broke handling of PREFIX_ADR. While fixing this, tidy and comment the code so that it's more obvious what's going on in setting both aflag and dflag. The TARGET_X86_64 ifdef can be eliminated

Re: [Qemu-devel] [PATCH] target-i386: Fix aflag logic for CODE64 and the 0x67 prefix

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 17:03, Richard Henderson ha scritto: Ping. On 05/29/2013 12:30 PM, Richard Henderson wrote: The code reorganization in commit 4a6fd938 broke handling of PREFIX_ADR. While fixing this, tidy and comment the code so that it's more obvious what's going on in setting both aflag and

[Qemu-devel] [Bug 1186303] [NEW] virtual fat do not working in qemu 1.5.0

2013-05-31 Thread prochazka nicolas
Public bug reported: Guest : windows Seven / XP Qemu version : 1.5.0 cmd line : -drive file=fat:floppy:/mnt/vdisk/diskconf/TEST004/,if=none,id=drive-fdc0-0-0,readonly=on generated by libvirt : disk type='dir' device='floppy' driver name='qemu' type='fat'/ source

Re: [Qemu-devel] [Qemu-trivial] [PATCH] do not check pointers after dereferencing them

2013-05-31 Thread Michael Tokarev
31.05.2013 16:00, Paolo Bonzini wrote: Two instances, both spotted by Coverity. In one, two blocks were swapped. In the other, the check is not needed anymore. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
David Woodhouse dw...@infradead.org writes: On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote: soapbox Fork OVMF, drop the fat module, and just add GPL code. It's an easily solvable problem. Heh. Actually it doesn't need to be a fork. It's modular, and the FAT driver is just a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Thomas Schwinge
Hi! On Fri, 31 May 2013 13:34:12 +0100, Peter Maydell peter.mayd...@linaro.org wrote: On 31 May 2013 13:07, Michael Tokarev m...@tls.msk.ru wrote: Hmm. And where's the simplification? Here's context diff for the same: *** fpu/softfloat-specialize.h.orig 2013-05-31 16:02:51.614710351

[Qemu-devel] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Thomas Schwinge
Signed-off-by: Thomas Schwinge tho...@codesourcery.com --- fpu/softfloat-specialize.h | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git fpu/softfloat-specialize.h fpu/softfloat-specialize.h index 518f694..83add1a 100644 --- fpu/softfloat-specialize.h +++

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread David Woodhouse
On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: It's even more fundamental. OVMF as a whole (at least in it's usable form) is not Open Source. The FAT module is required to make EDK2 usable, and yes, that's not Open Source. So in a sense you're right. But we're talking here about

Re: [Qemu-devel] [PATCH] s390/ipl: Fix spurious errors in virtio

2013-05-31 Thread Andreas Färber
Am 23.05.2013 13:51, schrieb Christian Borntraeger: With the ccw ipl code sometimes an error message like virtio: trying to map MMIO memory or Guest moved used index from %u to %u appeared. Turns out that the ccw bios did not zero out the vring, which might cause stale values in avail-idx and

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 17:43, Anthony Liguori wrote: David Woodhouse dw...@infradead.org writes: On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote: soapbox Fork OVMF, drop the fat module, and just add GPL code. It's an easily solvable problem. Heh. Actually it doesn't need to be a fork.

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 16:38, Anthony Liguori wrote: It's either Open Source or it's not. It's currently not. I disagree with this binary representation of Open Source or Not. If it weren't (mostly) Open Source, how could we fork (most of) it as you're suggesting (from the soapbox :))? I have a hard

[Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

2013-05-31 Thread Jeff Cody
This is a git script that will iterate through every commit in a specified range, and perform a configure and make. The intention of this script is not to act as a check of code correctness, but to see if any commit breaks compilation of the tree. The idea is that prior to submitting a patch or

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 18:33, David Woodhouse wrote: On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: It's even more fundamental. OVMF as a whole (at least in it's usable form) is not Open Source. The FAT module is required to make EDK2 usable, and yes, that's not Open Source. So in a sense

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
David Woodhouse dw...@infradead.org writes: On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: It's even more fundamental. OVMF as a whole (at least in it's usable form) is not Open Source. The FAT module is required to make EDK2 usable, and yes, that's not Open Source. So in a

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Laszlo Ersek ler...@redhat.com writes: On 05/31/13 16:38, Anthony Liguori wrote: It's either Open Source or it's not. It's currently not. I disagree with this binary representation of Open Source or Not. If it weren't (mostly) Open Source, how could we fork (most of) it as you're

[Qemu-devel] [PATCH] libcacard/vscclient: fix leakage of socket on error paths

2013-05-31 Thread Alon Levy
Spotted by Coverity. Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vscclient.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ac23647..9fcc548 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c

Re: [Qemu-devel] [PATCH] libcacard/vscclient: fix leakage of socket on error paths

2013-05-31 Thread Alon Levy
Spotted by Coverity. Self NACK. I'll send a more complete patch, and use closesocket. Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vscclient.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 19:06, Anthony Liguori ha scritto: David Woodhouse dw...@infradead.org writes: On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: It's even more fundamental. OVMF as a whole (at least in it's usable form) is not Open Source. The FAT module is required to make EDK2

[Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend

2013-05-31 Thread Cole Robinson
'default_backend' isn't always set, but 'rng' is, so use that. $ ./x86_64-softmmu/qemu-system-x86_64 -object rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0 Segmentation fault (core dumped) Regressed with virtio refactoring in 59ccd20a9ac719cff82180429458728f03ec612f

  1   2   >