Re: [Qemu-devel] [PATCH] target-i386: cpu: fix potential buffer overrun in get_register_name_32()

2013-06-04 Thread li guang
Reviewed-by: liguang lig.f...@cn.fujitsu.com 在 2013-06-03一的 18:23 +0200,Igor Mammedov写道: spotted by Coverity, x86_reg_info_32[] is CPU_NB_REGS32 elements long, so accessing x86_reg_info_32[CPU_NB_REGS32] will be one element off array. Yes, it will. Signed-off-by: Igor Mammedov

Re: [Qemu-devel] QEMU aborts since kvm: support using KVM_MEM_READONLY flag for regions

2013-06-04 Thread Gleb Natapov
On Mon, Jun 03, 2013 at 03:20:48PM -0500, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 03/06/2013 19:49, Anthony Liguori ha scritto: Peter Wu lekenst...@gmail.com writes: Hi, With the current git source (f10acc8b38d65a66ffa0588a036489d7fa6a593e),

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Jordan Justen
Fixed in 651eb0f4? On Mon, Jun 3, 2013 at 8:47 PM, Dunrong Huang riegama...@gmail.com wrote: QEMU command: ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 debian-append.img git bisect tells that the following commit causes this bug: commit 235e8982ad393e5611cb892df54881c872eea9e1 Author:

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-06-04 Thread Amos Kong
On Fri, May 31, 2013 at 11:02:54AM +0800, Amos Kong wrote: On Fri, May 31, 2013 at 08:35:28AM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 04:54:41PM +0300, Michael S. Tsirkin wrote: On Tue, May 28, 2013 at 08:25:56AM -0400, Luiz Capitulino wrote: 2. Can you actually show the

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 05:47, Dunrong Huang ha scritto: QEMU command: ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 debian-append.img git bisect tells that the following commit causes this bug: commit 235e8982ad393e5611cb892df54881c872eea9e1 Author: Jordan Justen jordan.l.jus...@intel.com

Re: [Qemu-devel] fstrim and cache=none

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 03:02, Dusty Mabe ha scritto: On Mon, Jun 3, 2013 at 5:39 PM, Dusty Mabe dustym...@gmail.com wrote: It is possible that I was mistaken. Now when I switch back to cache=none I am still able to execute trim operations. I'll investigate a little more into my exact steps that I took

Re: [Qemu-devel] [PATCH 0/3] Remove legacy sysfw code

2013-06-04 Thread Paolo Bonzini
Il 03/06/2013 23:56, Jordan Justen ha scritto: You seem to have a much better handle than I do on machine migration and backward compatibility issues within QEMU. One difference we'll see from this series is that... With QEMU 1.2, an error would always be generated with:

Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc

2013-06-04 Thread Jesse Larrew
On 06/03/2013 10:20 AM, Andrew Jones wrote: Coverity complains about two overruns in process_tx_desc(). The complaints are false positives, but we might as well eliminate them. The problem is that hdr is defined as an unsigned int, but then used to offset an array of size 65536, and another of

Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc

2013-06-04 Thread Andrew Jones
- Original Message - On 06/03/2013 10:20 AM, Andrew Jones wrote: Coverity complains about two overruns in process_tx_desc(). The complaints are false positives, but we might as well eliminate them. The problem is that hdr is defined as an unsigned int, but then used to offset an

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-06-04 Thread Amos Kong
On Tue, Jun 04, 2013 at 02:43:11PM +0800, Amos Kong wrote: I did more tests in clear environment, and found that the guest hang/slow (no response from monitor) is caused by flooding events. I could not reproduce it with upstream qemu [1] If I set event_throttle to 1 ~ 1000, the problem

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Dunrong Huang
On Tue, Jun 4, 2013 at 2:41 PM, Jordan Justen jljus...@gmail.com wrote: Fixed in 651eb0f4? No, it still fails. On Mon, Jun 3, 2013 at 8:47 PM, Dunrong Huang riegama...@gmail.com wrote: QEMU command: ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 debian-append.img git bisect

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Dunrong Huang
On Tue, Jun 4, 2013 at 2:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 04/06/2013 05:47, Dunrong Huang ha scritto: QEMU command: ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 debian-append.img git bisect tells that the following commit causes this bug: commit

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-06-04 Thread Gerd Hoffmann
On 06/03/13 23:14, Anthony Liguori wrote: -g_object_unref(cursor); +gdk_cursor_unref(cursor); Reviewed-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Gleb Natapov
On Tue, Jun 04, 2013 at 03:47:47PM +0800, Dunrong Huang wrote: On Tue, Jun 4, 2013 at 2:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 04/06/2013 05:47, Dunrong Huang ha scritto: QEMU command: ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 debian-append.img git bisect

Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc

2013-06-04 Thread Luigi Rizzo
On Tue, Jun 4, 2013 at 9:34 AM, Andrew Jones drjo...@redhat.com wrote: - Original Message - On 06/03/2013 10:20 AM, Andrew Jones wrote: Coverity complains about two overruns in process_tx_desc(). The complaints are false positives, but we might as well eliminate them. The

[Qemu-devel] [PULL 2/9] dec.c - move to pci-bridge

2013-06-04 Thread Michael S. Tsirkin
Looks like dec.c is in pci-host by mistake. Moving it over to pci-bridge. Acked-by: Andreas Färber afaer...@suse.de Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci-bridge/Makefile.objs | 2 ++ hw/{pci-host = pci-bridge}/dec.c | 0 hw/{pci-host = pci-bridge}/dec.h | 0

[Qemu-devel] [PULL 0/9] pci: misc cleanups

2013-06-04 Thread Michael S. Tsirkin
The following changes since commit 87d23f78aa79b72da022afda358bbc8a8509ca70: virtio-pci: drop unused wmb macro (2013-05-29 08:16:21 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch changes up to

Re: [Qemu-devel] VFIO VGA test branches

2013-06-04 Thread Michael Nelson
Here is some more data for vfio-vga. I have tried NVIDIA (MSI) GT610 and ATI (MSI) 7850 cards separately in primary and secondary (to Cirrus) modes. The ATI can boot as primary in VGA mode, but installing Catalyst causes the VM to reboot repeatedly on bootup. The NVIDIA doesn't get past POST as

[Qemu-devel] [PULL 1/9] q35: set fw_name

2013-06-04 Thread Michael S. Tsirkin
PCI host bridges need to set fw_name to be discoverable by bios for boot device selection. In particular, seabios expects root device to be called /pci/@i0cf8, so let's set it up like that for Q35. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Amos Kong

[Qemu-devel] [PULL 7/9] fw_cfg: add API to find FW cfg object

2013-06-04 Thread Michael S. Tsirkin
Remove some code duplication by adding a function to look up the fw cfg file. This way, we don't need to duplicate same strings everywhere. Use by both fw cfg and pvpanic device. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/misc/pvpanic.c | 2 +- hw/nvram/fw_cfg.c |

[Qemu-devel] [PULL 3/9] firmware_abi: move to include/hw/nvram/

2013-06-04 Thread Michael S. Tsirkin
firmware_abi.h with structs for OpenBIOS landed in hw/sparc/ by mistake - move it to hw/nvram/ alongside fw_cfg.h. In addition to sparc it's included from ppc mac_nvram.c and will need to include it from prep.c in the future. Acked-by: Andreas Färber afaer...@suse.de Signed-off-by: Michael S.

[Qemu-devel] [PULL 9/9] pvpanic: use FWCfgState explicitly

2013-06-04 Thread Michael S. Tsirkin
Use the type-safe FWCfgState structure instead of the unsafe void *. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/misc/pvpanic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 159340f..910e44f 100644 ---

[Qemu-devel] [PULL 4/9] apic: rename apic specific bitopts

2013-06-04 Thread Michael S. Tsirkin
apic has its own version of bitops, with the difference that it works on u32 and not long. Add apic_ prefix to avoid namespace clashes. We should look into reusing standard bitops long-term, but that's not entirely trivial. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/intc/apic.c |

[Qemu-devel] [PULL 6/9] fw_cfg: move typedef to qemu/typedefs.h

2013-06-04 Thread Michael S. Tsirkin
Less header dependencies this way. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 1 - include/hw/nvram/fw_cfg.h | 2 +- include/qemu/typedefs.h | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h

[Qemu-devel] [PULL 5/9] refer to FWCfgState explicitly

2013-06-04 Thread Michael S. Tsirkin
From: Laszlo Ersek ler...@redhat.com Currently some places use pointer-to-void even though they mean pointer-to-FWCfgState. Clean them up. Signed-off-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL 8/9] fw_cfg: fw_cfg is a singleton

2013-06-04 Thread Michael S. Tsirkin
Make sure we only have a single instance ever: because if it isn't we can't find it so it's useless anyway. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/nvram/fw_cfg.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Dunrong Huang
On Tue, Jun 4, 2013 at 3:51 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Jun 04, 2013 at 03:47:47PM +0800, Dunrong Huang wrote: On Tue, Jun 4, 2013 at 2:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 04/06/2013 05:47, Dunrong Huang ha scritto: QEMU command:

Re: [Qemu-devel] gtk UI doesn't correctly byte swap 32-bit framebuffer on qemu-system-ppc little-endian host

2013-06-04 Thread Gerd Hoffmann
On 06/04/13 01:19, Anthony Liguori wrote: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk writes: Hi all, I've just been testing some more OpenBIOS images with the new gtk UI and found that if you specify a 32-bit depth framebuffer on qemu-system-ppc running on a little-endian host then

Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc

2013-06-04 Thread Peter Maydell
On 4 June 2013 08:34, Andrew Jones drjo...@redhat.com wrote: I could send a v2 that fixes the 1 error and 2 warnings found in the context of this patch, but why? It's out of the scope of the patch (although I did use cleanup in the summary...), and it would hardly make a dent in this file's

Re: [Qemu-devel] [PATCH] kvm: exclude ioeventfd from counting kvm_io_range limit

2013-06-04 Thread Gleb Natapov
On Sat, May 25, 2013 at 06:44:15AM +0800, Amos Kong wrote: We can easily reach the 1000 limit by start VM with a couple hundred I/O devices (multifunction=on). The hardcode limit already been adjusted 3 times (6 ~ 200 ~ 300 ~ 1000). In userspace, we already have maximum file descriptor to

[Qemu-devel] [PATCH v2] e1000: cleanup process_tx_desc

2013-06-04 Thread Andrew Jones
Coverity complains about two overruns in process_tx_desc(). The complaints are false positives, but we might as well eliminate them. The problem is that hdr is defined as an unsigned int, but then used to offset an array of size 65536, and another of size 256 bytes. hdr will actually never be

Re: [Qemu-devel] gtk UI doesn't correctly byte swap 32-bit framebuffer on qemu-system-ppc little-endian host

2013-06-04 Thread Mark Cave-Ayland
On 04/06/13 08:50, Gerd Hoffmann wrote: On 06/04/13 01:19, Anthony Liguori wrote: Mark Cave-Aylandmark.cave-ayl...@ilande.co.uk writes: Hi all, I've just been testing some more OpenBIOS images with the new gtk UI and found that if you specify a 32-bit depth framebuffer on qemu-system-ppc

Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc

2013-06-04 Thread Andrew Jones
- Original Message - On 4 June 2013 08:34, Andrew Jones drjo...@redhat.com wrote: I could send a v2 that fixes the 1 error and 2 warnings found in the context of this patch, but why? It's out of the scope of the patch (although I did use cleanup in the summary...), and it would

Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-04 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The variable is not written anymore. This cleans up after 9e1c2ec (which accidentally left variable pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and buries dead code from commit dafb82e (which looks like it got confused by

Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-04 Thread Markus Armbruster
Jordan Justen jljus...@gmail.com writes: On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini pbonz...@redhat.com wrote: The variable is not written anymore. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/pc_sysfw.c | 26 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 11:14, Markus Armbruster ha scritto: The variable is not written anymore. This cleans up after 9e1c2ec (which accidentally left variable pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and buries dead code from commit dafb82e (which looks like it got confused

[Qemu-devel] [PATCH v2 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-04 Thread Paolo Bonzini
The variable is not written anymore. This cleans up after 9e1c2ec (which accidentally left variable pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and buries dead code from commit dafb82e (which resurrected the pc_sysfw code for pc_sysfw_flash_vs_rom_bug_compatible by mistake).

[Qemu-devel] [PATCH v2 0/3] Remove legacy sysfw code

2013-06-04 Thread Paolo Bonzini
The sysfw code to choose between ROM and flash BIOS was a bad idea, because it triggered different behavior between TCG and KVM. We deleted the behavior in 1.5, but we left the code around because it was close to the release. Now it's time to delete it. v1-v2 only changes commit messages.

[Qemu-devel] [PATCH v2 2/3] pc_sysfw: remove the rom_only property

2013-06-04 Thread Paolo Bonzini
With the new semantics of pc_sysfw (no -pflash implies old-style ROM setup, -pflash implies new-style ROM setup), there is no need anymore for a compat property. Old machines simply will never use -pflash, and thus will always use old-style setup. Signed-off-by: Paolo Bonzini pbonz...@redhat.com

Re: [Qemu-devel] [PATCH] qemu-doc, help: update options/keys for GTK/SDL

2013-06-04 Thread Peter Wu
Thanks for your feedback, replies are inlined below. On Tuesday 04 June 2013 07:57:38 Michael Tokarev wrote: 03.06.2013 14:54, Peter Wu wrote: The GTK display type has been introduced in 1.5, replacing SDL as default. Some options only work with SDL and not GTK. This patch tries to address

[Qemu-devel] [PATCH v2 3/3] pc_sysfw: do not make it a device anymore

2013-06-04 Thread Paolo Bonzini
Move the code to hw/i386, the sole remaining property is available as !pci_enabled. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/block/Makefile.objs | 1 - hw/i386/Makefile.objs

Re: [Qemu-devel] [PATCH v3] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-04 Thread Hans de Goede
Hi, On 06/03/2013 10:25 PM, Michael Roth wrote: snip To fix these, let's just drop the BH. Since the initial reasoning for using it still applies to an extent, work around that by deferring the delivery of CHR_EVENT_OPENED until after the chardevs have been fully initialized, toward the end

Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c

2013-06-04 Thread Kevin Wolf
Am 29.05.2013 um 22:29 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf wrote: This is the implementation of all qemu-io commands that make sense to be called from the qemu monitor, i.e. everything except open, close and quit. Signed-off-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Kevin Wolf
Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: On Wed, 29 May 2013 10:13:42 +0200 Kevin Wolf kw...@redhat.com wrote: Am 28.05.2013 um 18:07 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf wrote: The QMP version is flagged with a __org.qemu.debug- prefix in

[Qemu-devel] [Bug 1187334] [NEW] crash on hot-unplug of vmxnet3

2013-06-04 Thread Paolo Bonzini
Public bug reported: Hot-unplug of a vmxnet3 device crashes as follows: (qemu) device_add id=ff,driver=vmxnet3 [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension. Task offloads will be emulated. (qemu) device_del ff (qemu) qemu-system-x86_64:

Re: [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function

2013-06-04 Thread Kevin Wolf
Am 29.05.2013 um 23:25 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf wrote: No reason to treat it different from other commands. Move it to qemu-io-cmds.c, adapt the coding style and register it like any other command. Signed-off-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Peter Lieven
On 03.06.2013 12:04, Alexey Kardashevskiy wrote: On 05/31/2013 12:38 AM, Peter Lieven wrote: Am 30.05.2013 um 15:41 schrieb Paolo Bonzini pbonz...@redhat.com: Il 30/05/2013 11:08, Peter Lieven ha scritto: Am 30.05.2013 10:18, schrieb Alexey Kardashevskiy: On 05/30/2013 05:49 PM, Paolo

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

2013-06-04 Thread Stefano Stabellini
On Mon, 3 Jun 2013, Anthony Liguori wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Mon, 3 Jun 2013, Anthony Liguori wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Mon, 3 Jun 2013, Anthony Liguori wrote: Stefano Stabellini

Re: [Qemu-devel] [PATCH v2] e1000: cleanup process_tx_desc

2013-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 10:49:48AM +0200, Andrew Jones wrote: Coverity complains about two overruns in process_tx_desc(). The complaints are false positives, but we might as well eliminate them. The problem is that hdr is defined as an unsigned int, but then used to offset an array of size

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

2013-06-04 Thread Stefano Stabellini
On Tue, 4 Jun 2013, Stefano Stabellini wrote: On Mon, 3 Jun 2013, Anthony Liguori wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Mon, 3 Jun 2013, Anthony Liguori wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Mon, 3 Jun 2013,

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

2013-06-04 Thread Peter Maydell
On 4 June 2013 11:59, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: http://wiki.qemu.org/Contribute/SubmitAPullRequest Thanks for the link. Even though maybe partial, having a document that explains the process is great (I wish there was one for Linux too). The page hints at

Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc

2013-06-04 Thread Michael S. Tsirkin
On Mon, Jun 03, 2013 at 05:20:38PM +0200, Andrew Jones wrote: Coverity complains about two overruns in process_tx_desc(). The complaints are false positives, but we might as well eliminate them. The problem is that hdr is defined as an unsigned int, but then used to offset an array of size

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 03:42:19PM +0800, Amos Kong wrote: On Tue, Jun 04, 2013 at 02:43:11PM +0800, Amos Kong wrote: I did more tests in clear environment, and found that the guest hang/slow (no response from monitor) is caused by flooding events. I could not reproduce it with

[Qemu-devel] [PATCH v2] linux-user: Allow getdents to be provided by getdents64

2013-06-04 Thread Peter Maydell
Newer architectures may only implement the getdents64 syscall, not getdents. Provide an implementation of getdents in terms of getdents64 so that we can run getdents-using targets on a getdents64-only host. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id:

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

2013-06-04 Thread Stefano Stabellini
On Tue, 4 Jun 2013, Peter Maydell wrote: On 4 June 2013 11:59, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: http://wiki.qemu.org/Contribute/SubmitAPullRequest Thanks for the link. Even though maybe partial, having a document that explains the process is great (I wish there

Re: [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-06-04 Thread Peter Crosthwaite
Hi Ed, On Wed, May 29, 2013 at 11:58 PM, Ed Maste ema...@freebsd.org wrote: Based on the datasheet at http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf Signed-off-by: Ed Maste ema...@freebsd.org --- hw/block/m25p80.c | 1 +

Re: [Qemu-devel] [PATCH v1 2/3] memory: as_update_topology_pass: Improve comments

2013-06-04 Thread Andreas Färber
Am 03.06.2013 07:32, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com These comments we're a little difficult to read. First one had While we're picky: were - Paolo can you fix up in your queue? Andreas incorrect parenthesis. The part about

[Qemu-devel] [PATCH 1/2] kvm: zero-initialize KVM_SET_GSI_ROUTING input

2013-06-04 Thread Michael S. Tsirkin
kvm_add_routing_entry makes an attempt to zero-initialize any new routing entry. However, it fails to initialize padding within the u field of the structure kvm_irq_routing_entry. Other functions like kvm_irqchip_update_msi_route also fail to initialize the padding field in kvm_irq_routing_entry.

[Qemu-devel] [PATCH 2/2] kvm: skip system call when msi route is unchanged

2013-06-04 Thread Michael S. Tsirkin
Some guests do a large number of mask/unmask calls which currently trigger expensive route update system calls. Detect that route in unchanged and skip the system call. Reported-by: Zhanghaoyu (A) haoyu.zh...@huawei.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- kvm-all.c | 4 1

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-06-04 Thread Andreas Färber
Am 03.06.2013 23:14, schrieb Anthony Liguori: It's not a GObject. Cc: Gerd Hoffman kra...@redhat.com Reported-by: Michael Tokarev m...@tls.msk.ru Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- v1 - v2 - Fix summary to agree with code (Peter) --- ui/gtk.c | 2 +- 1 file

Re: [Qemu-devel] fstrim and cache=none

2013-06-04 Thread Dusty Mabe
On Tue, Jun 4, 2013 at 2:53 AM, Paolo Bonzini pbonz...@redhat.com wrote: Please attach the QEMU command line too. I'll try to reproduce. The command line is below (sorry it's so large). A little context: sda is a raw disk image backed by a file, while sdb is backed by a thin logical volume in

[Qemu-devel] [PATCH v2 00/17] Memory/IOMMU patches part 4: region ownership

2013-06-04 Thread Paolo Bonzini
Now that the DMA APIs are unified, we move closer and closer to breaking memory access from the BQL dependency. This series adds an API to reference/unreference memory regions, which is not really needed only for BQL-less memory access: the big lock can already be dropped between

[Qemu-devel] [PATCH v2 01/17] memory: add getter/setter for owner

2013-06-04 Thread Paolo Bonzini
Whenever memory regions are accessed outside the BQL, they need to be preserved against hot-unplug. MemoryRegions actually do not have their own reference count; they piggyback on a QOM object, their owner. Add two functions to retrieve and specify the owner. The setter function will affect the

[Qemu-devel] [PATCH v2 05/17] pci: set owner for BARs

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pci/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 26851ac..776ad96 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -913,6 +913,8 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,

[Qemu-devel] [PATCH v2 04/17] exec: add a reference to the region returned by address_space_translate

2013-06-04 Thread Paolo Bonzini
Once address_space_translate will only be protected by RCU, the returned MemoryRegion can disappear as soon as the RCU read-side critical section ends. Avoid this by adding a reference to the region, and dropping it in the caller of address_space_translate. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v2 02/17] memory: add ref/unref

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/exec/memory.h | 30 ++ memory.c | 14 ++ 2 files changed, 44 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index e51f30f..bfcdf65 100644 ---

[Qemu-devel] [PATCH v2 13/17] vfio: add memory_region_set_owner calls

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/misc/vfio.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index a1f5803..3c0dc9f 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -1156,6 +1156,7 @@ static void

[Qemu-devel] [PATCH v2 11/17] vga: add memory_region_set_owner calls

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/display/cirrus_vga.c | 19 ++- hw/display/qxl.c| 6 -- hw/display/vga-isa-mm.c | 2 +- hw/display/vga-isa.c| 4 ++-- hw/display/vga-pci.c| 5 +++-- hw/display/vga.c| 19 ++-

[Qemu-devel] [PATCH v2 07/17] sysbus: set owner for MMIO regions

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/sysbus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index 6dbd1f8..e54f1fc 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -115,6 +115,8 @@ void sysbus_init_mmio(SysBusDevice *dev,

[Qemu-devel] [PATCH v2 12/17] pci-assign: add memory_region_set_owner calls

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/i386/kvm/pci-assign.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index ff85590..4b1c2d9 100644 --- a/hw/i386/kvm/pci-assign.c +++ b/hw/i386/kvm/pci-assign.c @@ -300,6

[Qemu-devel] [PATCH v2 14/17] exec: check MRU in qemu_ram_addr_from_host

2013-06-04 Thread Paolo Bonzini
This function is not used outside the iothread mutex, so it can use ram_list.mru_block. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- exec.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index bf287cb..9fd4c90 100644 --- a/exec.c +++

[Qemu-devel] [PATCH v2 16/17] memory: return MemoryRegion from qemu_ram_addr_from_host

2013-06-04 Thread Paolo Bonzini
It will be needed in the next patch. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cputlb.c | 2 +- exec.c| 33 - include/exec/cpu-common.h | 2 +- target-i386/kvm.c | 4 ++-- 4 files changed, 24

[Qemu-devel] [PATCH v2 17/17] memory: ref/unref memory across address_space_map/unmap

2013-06-04 Thread Paolo Bonzini
The iothread mutex might be released between map and unmap, so the mapped region might disappear. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- exec.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index db03507..5c37393 100644 ---

Re: [Qemu-devel] [PATCH] target-i386: cpu: fix potential buffer overrun in get_register_name_32()

2013-06-04 Thread Andreas Färber
Am 03.06.2013 18:23, schrieb Igor Mammedov: spotted by Coverity, x86_reg_info_32[] is CPU_NB_REGS32 elements long, so accessing x86_reg_info_32[CPU_NB_REGS32] will be one element off array. Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c |2 +- 1 files changed,

Re: [Qemu-devel] [snabb-devel:300] Re: snabbswitch integration with QEMU for userspace ethernet I/O

2013-06-04 Thread Luke Gorrie
Howdy, My brain is slowly catching up with all of the information shared in this thread. Here is my first attempt to tease out a way forward for Snabb Switch. The idea that excites me is to implement a complete PCI device in Snabb Switch and expose this to the guest at the basic PCI/MMIO/DMA

[Qemu-devel] [PATCH v2 08/17] acpi: add memory_region_set_owner calls

2013-06-04 Thread Paolo Bonzini
ACPI regions are added directly to the I/O address space, without going through BARs. Thus they need the owner to be set directly. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/acpi/ich9.c | 1 + hw/acpi/piix4.c | 5 + hw/isa/apm.c| 1 + 3 files changed, 7 insertions(+) diff

[Qemu-devel] [PATCH v2 10/17] isa/portio: allow setting an owner

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/isa/isa-bus.c | 2 ++ include/exec/ioport.h | 3 +++ ioport.c | 10 ++ 3 files changed, 15 insertions(+) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 7860b17..d263d0f 100644 --- a/hw/isa/isa-bus.c +++

[Qemu-devel] [PATCH 01/13] target-ppc kvm: save cr register

2013-06-04 Thread Alexey Kardashevskiy
This adds a missing code to save CR (condition register) via kvm_arch_put_registers(). kvm_arch_get_registers() already has it. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- target-ppc/kvm.c |5 + 1 file changed, 5 insertions(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c

[Qemu-devel] [PATCH 00/13 v2] pseries: savevm / migration support

2013-06-04 Thread Alexey Kardashevskiy
This series lived for a while in David's tree. However QEMU mutated quite a lot so some fixes were needed. I still have to learn how to force git not to overwrite the original commit author :-/ Is there any way to tell the original creator in the commit message so it could live in a git forever

[Qemu-devel] [PATCH 04/13] pseries: savevm support for XICS interrupt controller

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au From: David Gibson da...@gibson.dropbear.id.au This patch adds the necessary VMStateDescription information to support savevm/loadvm for the XICS interrupt controller used on the pseries machine. [aik: added ics_resend() on post_load]

[Qemu-devel] [PATCH v2 15/17] exec: move qemu_ram_addr_from_host_nofail to cputlb.c

2013-06-04 Thread Paolo Bonzini
It is only used there, and the _nofail and the standard versions of this function return different things. Limit confusion by removing the function from the public headers. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cputlb.c | 11 +++ exec.c

[Qemu-devel] [PATCH 02/13] savevm: Implement VMS_DIVIDE flag

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au The vmstate infrastructure includes a VMS_MULTIPY flag, and associated VMSTATE_VBUFFER_MULTIPLY helper macro. These can be used to save a variably sized buffer where the size in bytes of the buffer isn't directly accessible as a structure field, but

[Qemu-devel] [PATCH 12/13] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au Recent PowerKVM allows the kernel to intercept some RTAS calls from the guest directly. This is used to implement the more efficient in-kernel XICS for example. qemu is still responsible for assigning the RTAS token numbers however, and needs to

[Qemu-devel] [PATCH 05/13] pseries: savevm support for VIO devices

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au This patch adds helpers to allow PAPR VIO devices to save state common to all VIO devices during savevm. Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/ppc/spapr_vio.c |

[Qemu-devel] [PATCH 07/13] pseries: savevm support for PAPR TCE tables

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au This patch adds the necessary VMStateDescription information to save the state of PAPR TCE tables (that is, the PAPR specified IOMMU). Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru ---

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Peter Maydell
On 4 June 2013 13:13, Paolo Bonzini pbonz...@redhat.com wrote: This matches sysbus_pass_irq in cases where a device is a thin wrapper of another. MMIO regions will keep the subdevice as the owner. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/sysbus.c | 12

[Qemu-devel] [PATCH 08/13] pseries: rework PAPR virtual SCSI

2013-06-04 Thread Alexey Kardashevskiy
The patch reimplements handling of indirect requests in order to simplify upcoming live migration support. - all pointers (except SCSIRequest*) were replaces with integer indexes and offsets; - DMA'ed srp_direct_buf kept untouched (ie. BE format); - vscsi_fetch_desc() is added, now it is the only

Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-04 Thread Stefan Hajnoczi
On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote: reorder slirp config options. first check the dns-server-address, then check the first-dhcp-address. the original code was comparing the first-dhcp-address with the default dns-server-address, not the configured

[Qemu-devel] [PATCH 09/13] pseries: savevm support for PAPR virtual SCSI

2013-06-04 Thread Alexey Kardashevskiy
Author: David Gibson da...@gibson.dropbear.id.au This patch adds the necessary support for saving the state of the PAPR VIO virtual SCSI device. This also saves and restores active SCSI requests. [David Gibson: implemented vscsi device vmsd] Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Cc:

[Qemu-devel] [PATCH 11/13] pseries: savevm support for PCI host bridge

2013-06-04 Thread Alexey Kardashevskiy
Author: David Gibson da...@gibson.dropbear.id.au This adds the necessary support for saving the state of the PAPR virtual PCI host bridge (or host bridges). Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/ppc/spapr_pci.c

[Qemu-devel] [PATCH 13/13] pseries: savevm support with KVM

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au At present, the savevm / migration support for the pseries machine will not work when KVM is enabled. That's because KVM manages the guest's hash page table in the host kernel, so qemu has no visibility of it. This patch fixes this by using new

[Qemu-devel] [PATCH 10/13] pseries: savevm support for pseries machine

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au This adds the necessary pieces to implement savevm / migration for the pseries machine. The most complex part here is migrating the hash table - for the paravirtualized pseries machine the guest's hash page table is not stored within guest memory,

[Qemu-devel] [PATCH v2 09/17] misc: add memory_region_set_owner calls

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/char/serial-pci.c | 1 + hw/misc/pc-testdev.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c index 2138e35..6b6106b 100644 --- a/hw/char/serial-pci.c +++ b/hw/char/serial-pci.c @@

Re: [Qemu-devel] [libvirt] NBD drives with literal IPv6 addresses or hostnames starting with a digit

2013-06-04 Thread Ján Tomko
On 06/04/2013 02:19 PM, Stefan Hajnoczi wrote: CCing Kevin who authored v1.4.0-736-gf17c90b. Stefan I've already posted patches for both issues: http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg00227.html Jan

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 14:24, Peter Maydell ha scritto: On 4 June 2013 13:13, Paolo Bonzini pbonz...@redhat.com wrote: This matches sysbus_pass_irq in cases where a device is a thin wrapper of another. MMIO regions will keep the subdevice as the owner. Signed-off-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH 06/13] pseries: savevm support for PAPR VIO logical lan

2013-06-04 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au This patch adds the necessary VMStateDescription information to support savevm/loadvm for the spapr_llan (PAPR logical lan) device. Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru ---

Re: [Qemu-devel] [PATCH v1 2/3] memory: as_update_topology_pass: Improve comments

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 13:43, Andreas Färber ha scritto: Am 03.06.2013 07:32, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com These comments we're a little difficult to read. First one had While we're picky: were - Paolo can you fix up in your queue? Of

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Peter Maydell
On 4 June 2013 13:31, Paolo Bonzini pbonz...@redhat.com wrote: Il 04/06/2013 14:24, Peter Maydell ha scritto: On 4 June 2013 13:13, Paolo Bonzini pbonz...@redhat.com wrote: This is much less flexible than just using sysbus_mmio_get_region(), because it only lets you pass the whole set of MMIOs

Re: [Qemu-devel] NBD drives with literal IPv6 addresses or hostnames starting with a digit

2013-06-04 Thread Stefan Hajnoczi
On Fri, May 31, 2013 at 01:38:51PM +0200, Ján Tomko wrote: Hello, since qemu's commit v1.4.0-736-gf17c90b [1]: nbd: Keep hostname and port separate * literal IPv6 addresses no longer work in nbd URIs, because getaddrinfo is called with the surrounding brackets: $ qemu-system-x86_64

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Luiz Capitulino
On Tue, 4 Jun 2013 12:08:23 +0200 Kevin Wolf kw...@redhat.com wrote: Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: On Wed, 29 May 2013 10:13:42 +0200 Kevin Wolf kw...@redhat.com wrote: Am 28.05.2013 um 18:07 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf

  1   2   3   >