Re: [Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-12 Thread Michael Tokarev
13.06.2013 03:49, Brad Smith wrote: [] > It would be nice to get this in to fix the build with Solaris (that's > if there is nothing else I am not aware of which breaks the build there) and > to get this in the queue for 1.5 too. I'll test it on solaris 10 x86 tonight. Started downloading an ins

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Frederic Konrad
On 13/06/2013 08:46, Alexey Kardashevskiy wrote: On 06/13/2013 04:28 PM, Frederic Konrad wrote: On 12/06/2013 13:21, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Mich

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Alexey Kardashevskiy
On 06/13/2013 04:28 PM, Frederic Konrad wrote: > On 12/06/2013 13:21, Alexey Kardashevskiy wrote: >> On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: >>> On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: > On Wed, Jun 1

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-12 Thread Fam Zheng
On Thu, 06/13 14:07, Wenchao Xia wrote: > 于 2013-6-13 14:03, Wenchao Xia 写道: > >于 2013-6-7 15:18, Stefan Hajnoczi 写道: > >>On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: > >>>On Thu, 06/06 10:05, Stefan Hajnoczi wrote: > On Thu, Jun 06, 2013 at 11:56:18AM +0800, Fam Zheng wrote: > >>

Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

2013-06-12 Thread Julio Guerra
2013/6/7 Julio Guerra : >>> >>> However I can't judge whether all that code is right for e600 and >>> whether you may want to share some code with e500 / e5500 in some way? >>> CC'ing some Freescale folks. >> >> >> e600 is a very different core from e500/e5500. It is a 74xx derivative. >> The only

Re: [Qemu-devel] [PATCH] spapr: add yet another maintainer

2013-06-12 Thread David Gibson
On Thu, Jun 13, 2013 at 02:10:43AM +0200, Alexander Graf wrote: > > On 13.06.2013, at 02:08, Alexey Kardashevskiy wrote: > > > On 06/13/2013 12:33 AM, Alexander Graf wrote: > >> > >> On 12.06.2013, at 16:27, Alexey Kardashevskiy wrote: > >> > >>> Signed-off-by: Alexey Kardashevskiy > >>> --- >

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-12 Thread Alexey Kardashevskiy
Hi! I do not know how (yet) but this patch breaks qtest on x86 (I bisected it): make check-qtest V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick tests/fdc-test tests/ide-test tests/hd-geo-test tests/r

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Frederic Konrad
On 12/06/2013 13:21, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 08:15:17AM +0200, fred.kon...@greensocs.com wrote:

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-12 Thread Peter Lieven
On 13.06.2013 05:30, Wenchao Xia wrote: > 于 2013-6-10 18:14, Peter Lieven 写道: >> on incoming migration do not memset pages to zero if they already read as >> zero. >> this will allocate a new zero page and consume memory unnecessarily. even >> if we madvise a MADV_DONTNEED later this will only dea

[Qemu-devel] [RFC] sanitize memory on system reset

2013-06-12 Thread Peter Lieven
Hi, I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise dontneed them afterwards. This would avoid system reset attacks in case the attacker has only access to the console of a vServer but not on the physical host and it would shrink RSS size o

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-12 Thread Wenchao Xia
于 2013-6-13 14:03, Wenchao Xia 写道: 于 2013-6-7 15:18, Stefan Hajnoczi 写道: On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: On Thu, 06/06 10:05, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 11:56:18AM +0800, Fam Zheng wrote: On Thu, 05/30 14:34, Stefan Hajnoczi wrote: + +static int

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-12 Thread Wenchao Xia
于 2013-6-7 15:18, Stefan Hajnoczi 写道: On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: On Thu, 06/06 10:05, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 11:56:18AM +0800, Fam Zheng wrote: On Thu, 05/30 14:34, Stefan Hajnoczi wrote: + +static int coroutine_fn backup_before_write_no

Re: [Qemu-devel] [PATCH 06/11] snapshot: distinguish id and name in snapshot delete

2013-06-12 Thread Wenchao Xia
于 2013-6-11 17:25, Stefan Hajnoczi 写道: On Sat, Jun 08, 2013 at 02:58:02PM +0800, Wenchao Xia wrote: static int find_snapshot_by_id_or_name(BlockDriverState *bs, const char *name) I suggest renaming the argument to make it less confusing: const char *name_or_id will rename it. { -

Re: [Qemu-devel] [PATCH 05/11] snapshot: add paired functions for internal snapshot id and name

2013-06-12 Thread Wenchao Xia
于 2013-6-11 17:14, Stefan Hajnoczi 写道: On Sat, Jun 08, 2013 at 02:58:01PM +0800, Wenchao Xia wrote: +/* + * Every internal snapshot have an ID used by qemu block layer, this function + * check whether name used by user mess up with ID. An empty string is also + * invalid. + */ +bool snapshot_nam

[Qemu-devel] virsh live migration w/o shared storage fails with error as vm is not running

2013-06-12 Thread chandrashekar shastri
Hi All, We are testing the upstream KVM with : Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). kernel version : 3.9.0+ qemu version : QEMU emulator version 1.5.0 libvirt version : 1.0.5 virt-install : 0.600.3 I have followed the below steps to test the "Live migration w/o s

Re: [Qemu-devel] about atexit() (was: [PATCH 5/5] hostmem: init/finalize hostmem listener)

2013-06-12 Thread Amos Kong
On Mon, Apr 01, 2013 at 04:20:34PM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > Signed-off-by: Liu Ping Fan > --- > vl.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/vl.c b/vl.c > index 7643f16..46a25cf 100644 > --- a/vl.c > +++ b/vl.c > @@ -4157,6 +415

Re: [Qemu-devel] [PATCH 04/11] snapshot: new function bdrv_snapshot_find_by_id_and_name()

2013-06-12 Thread Wenchao Xia
于 2013-6-11 16:26, Stefan Hajnoczi 写道: On Sat, Jun 08, 2013 at 02:58:00PM +0800, Wenchao Xia wrote: +if (id && name) { +for (i = 0; i < nb_sns; i++) { +sn = &sn_tab[i]; +if (!strcmp(sn->id_str, id) && !strcmp(sn->name, name)) { +*sn_info = *sn;

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-12 Thread Wenchao Xia
于 2013-6-10 18:14, Peter Lieven 写道: > on incoming migration do not memset pages to zero if they already read as > zero. > this will allocate a new zero page and consume memory unnecessarily. even > if we madvise a MADV_DONTNEED later this will only deallocate the memory > asynchronously. > > Sign

[Qemu-devel] [PATCH v2] vmdk: refuse to open higher version than supported

2013-06-12 Thread Fam Zheng
Refuse to open higher version for safety. Although we try to be compatible with published VMDK spec, VMware has newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge what's changed in it. And it is very likely to have more new versions in the future, so it's not safe to open the

Re: [Qemu-devel] [PATCHv2 1/2] Revert "migration: do not sent zero pages in bulk stage"

2013-06-12 Thread Wenchao Xia
clear patch, I don't see any issue. Reviewed-by: Wenchao Xia > Not sending zero pages breaks migration if a page is zero > at the source but not at the destination. This can e.g. happen > if different BIOS versions are used at source and destination. > It has also been reported that migration on

Re: [Qemu-devel] [Qemu-ppc] broken incoming migration

2013-06-12 Thread Wenchao Xia
于 2013-6-13 4:10, Paolo Bonzini 写道: Il 12/06/2013 10:11, Benjamin Herrenschmidt ha scritto: On Wed, 2013-06-12 at 10:00 -0400, Paolo Bonzini wrote: The only bug we have is not a performance bug related to compression; it's that writing zero pages breaks overcommit. Let's fix that, and only tha

Re: [Qemu-devel] [PATCH] curl: refuse to open URL from HTTP server without range support

2013-06-12 Thread Fam Zheng
On Tue, 06/11 09:40, Stefan Hajnoczi wrote: > On Tue, Jun 11, 2013 at 11:15:15AM +0800, Fam Zheng wrote: > > On Mon, Jun 10, 2013 at 5:21 PM, Stefan Hajnoczi wrote: > > > On Sun, Jun 09, 2013 at 10:34:54AM +0800, Fam Zheng wrote: > > >> @@ -110,14 +111,14 @@ static int curl_sock_cb(CURL *curl, cur

Re: [Qemu-devel] [PATCH] vmdk: byteswap VMDK4Header.desc_offset field

2013-06-12 Thread Fam Zheng
On Mon, 06/10 16:32, Stefan Hajnoczi wrote: > On Mon, Jun 10, 2013 at 04:04:55PM +0200, Kevin Wolf wrote: > > Am 10.06.2013 um 11:07 hat Stefan Hajnoczi geschrieben: > > > Remember to byteswap VMDK4Header.desc_offset on big-endian machines. > > > > > > Cc: qemu-sta...@nongnu.org > > > Signed-off-b

Re: [Qemu-devel] [PATCH RFT 2/5] virtio: Convert VirtioDevice to QOM realize/unrealize

2013-06-12 Thread Peter Crosthwaite
Hi Andreas, On Wed, Jun 12, 2013 at 7:15 PM, Andreas Färber wrote: > Am 10.06.2013 04:08, schrieb Anthony Liguori: >> Peter Crosthwaite writes: >>> On Sat, Jun 8, 2013 at 7:55 PM, Andreas Färber wrote: Am 08.06.2013 04:22, schrieb Peter Crosthwaite: > On Sat, Jun 8, 2013 at 4:18 AM, An

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-12 Thread Wanlong Gao
On 06/11/2013 09:40 PM, Eduardo Habkost wrote: > On Tue, Jun 11, 2013 at 03:22:13PM +0800, Wanlong Gao wrote: >> On 06/05/2013 09:46 PM, Eduardo Habkost wrote: >>> On Wed, Jun 05, 2013 at 11:58:25AM +0800, Wanlong Gao wrote: Add monitor command mem-nodes to show the huge mapped memory nod

[Qemu-devel] [PULL 13/17] cpu: Change default for CPUClass::get_paging_enabled()

2013-06-12 Thread Andreas Färber
qemu_get_guest_memory_mapping() uses cpu_paging_enabled() to determine whether to use cpu_get_memory_mapping() to return mappings or whether to fall back to a simple identity map. Since by default CPUClass::get_memory_mapping() is not implemented, change the default to false to use the identity ma

[Qemu-devel] [PULL 15/17] memory_mapping: Improve qemu_get_guest_memory_mapping() error reporting

2013-06-12 Thread Andreas Färber
Pass any Error out into dump_init() and have it actually stop on errors. Whether it is unsupported on a certain CPU can be checked by looking for a NULL CPUClass::get_memory_mapping field. Reviewed-by: Luiz Capitulino [AF: Reverted changes to CPU loops] Signed-off-by: Andreas Färber --- dump.c

[Qemu-devel] [PULL 17/17] spapr_rtas: Abstract rtas_start_cpu() with qemu_get_cpu()

2013-06-12 Thread Andreas Färber
Instead of looping over all CPUArchState, use a helper to obtain the desired CPUState. Free the "cpu" variable for PowerPCCPU, to access its CPUPPCState. Signed-off-by: Andreas Färber --- hw/ppc/spapr_rtas.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a

[Qemu-devel] [PULL 08/17] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-06-12 Thread Andreas Färber
Relocate assignment of x86 get_arch_id to have all hooks in one place. Reviewed-by: Jens Freimann Reviewed-by: Luiz Capitulino Signed-off-by: Andreas Färber --- include/qom/cpu.h | 10 ++ include/sysemu/memory_mapping.h | 1 - memory_mapping-stub.c | 6 -

[Qemu-devel] [PULL 10/17] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-06-12 Thread Andreas Färber
Change error reporting from return value to Error argument. Reviewed-by: Jens Freimann Reviewed-by: Luiz Capitulino [AF: Fixed cpu_get_memory_mapping() documentation] Signed-off-by: Andreas Färber --- include/qom/cpu.h | 13 + include/sysemu/memory_mapping.h | 2

[Qemu-devel] [PULL 14/17] dump: Abstract dump_init() with cpu_synchronize_all_states()

2013-06-12 Thread Andreas Färber
Instead of calling cpu_synchronize_state() for each CPU, call the existing cpu_synchronize_all_states() helper. Reviewed-by: Luiz Capitulino Signed-off-by: Andreas Färber --- dump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index c0d3da5..87ca12c 1

[Qemu-devel] [PULL 09/17] memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h

2013-06-12 Thread Andreas Färber
This will avoid issues with hwaddr and ram_addr_t when including sysemu/memory_mapping.h for CONFIG_USER_ONLY, e.g., from qom/cpu.h. Signed-off-by: Andreas Färber --- include/qemu/typedefs.h | 2 ++ include/sysemu/memory_mapping.h | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(

[Qemu-devel] [PULL 11/17] memory_mapping: Drop qemu_get_memory_mapping() stub

2013-06-12 Thread Andreas Färber
dump.c:dump_init() never checked for the return code anyway. If paging is not enabled, it will fall back to an identity map. If paging is enabled and getting memory mapping list is not implemented, qemu_get_guest_memory_mapping() will return an error. Since the targets not implementing memory mapp

[Qemu-devel] [PULL 07/17] monitor: Simplify do_inject_mce() with qemu_get_cpu()

2013-06-12 Thread Andreas Färber
Avoids an open-coded CPU loop. Reviewed-by: liguang Reviewed-by: Luiz Capitulino Signed-off-by: Andreas Färber --- monitor.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 017411f..70ae8f5 100644 --- a/monitor.c +++ b/monitor.c @@

[Qemu-devel] [PULL 06/17] target-i386: cpu: Fix potential buffer overrun in get_register_name_32()

2013-06-12 Thread Andreas Färber
From: Igor Mammedov Spotted by Coverity, x86_reg_info_32[] is CPU_NB_REGS32 elements long, so accessing x86_reg_info_32[CPU_NB_REGS32] will be one element off array. Signed-off-by: Igor Mammedov Reviewed-by: liguang Reviewed by: Jesse Larrew Signed-off-by: Andreas Färber --- target-i386/cpu

[Qemu-devel] [PULL 05/17] target-i386: Set level=4 on Conroe/Penryn/Nehalem

2013-06-12 Thread Andreas Färber
From: Eduardo Habkost The CPUID level value on Conroe, Penryn, and Nehalem are too low. This causes at least one known problem: the -smp "threads" option doesn't work as expect if level is < 4, because thread count information is provided to the guest on CPUID[EAX=4,ECX=2].EAX Signed-off-by: Edu

[Qemu-devel] [PULL 16/17] spapr_rtas: Abstract rtas_query_cpu_stopped_state() with qemu_get_cpu()

2013-06-12 Thread Andreas Färber
Instead of looping over all CPUArchState, use a helper to obtain the desired CPUState directly. Saves a CPUPPCState variable and QOM cast. Signed-off-by: Andreas Färber --- hw/ppc/spapr_rtas.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/p

[Qemu-devel] [PULL 03/17] pc: Create pc-*-1.6 machine-types

2013-06-12 Thread Andreas Färber
From: Eduardo Habkost Some CPU model fixes are going to be included and they will require compatibility properties in the pc-*-1.5 machine-types. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/i386/pc_piix.c | 14 -- hw/i386/pc_q35.

[Qemu-devel] [PULL 00/17] QOM CPUState patch queue 2013-06-12

2013-06-12 Thread Andreas Färber
Hello, This is my current QOM CPU patch queue. Please pull. It includes: * guest-memory-dump refactoring to avoid configure changes for future targets, * CPU loop avoidance via qemu_get_cpu() to prepare for first_cpu refactoring, * cpu-add and x86 CPU bugfixes, * x86 CPU model fixes including pc-

[Qemu-devel] [PULL 12/17] dump: Drop qmp_dump_guest_memory() stub and build for all targets

2013-06-12 Thread Andreas Färber
qmp_dump_guest_memory() calls dump_init() and returns an Error when cpu_get_dump_info() returns an error, as done by the stub. So there is no need to have a stub for qmp_dump_guest_memory(). Enable the documentation of the always-present dump-guest-memory command. That way we can drop CONFIG_HAVE

[Qemu-devel] [PULL 02/17] pc: Fix crash when attempting to hotplug CPU with negative ID

2013-06-12 Thread Andreas Färber
From: Igor Mammedov QMP command "{ 'execute': 'cpu-add', 'arguments': { 'id': -1 }}" may cause QEMU SIGSEGV at: piix4_cpu_hotplug_req () ... g->sts[cpu_id / 8] |= (1 << (cpu_id % 8)); ... Since for PC in current implementation id should be in range [0...maxcpus) and maxcpus is alrea

[Qemu-devel] [PULL 04/17] target-i386: Update model values on Conroe/Penryn/Nehalem CPU models

2013-06-12 Thread Andreas Färber
From: Eduardo Habkost The CPUID model values on Conroe, Penryn, and Nehalem are too conservative and don't reflect the values found on real Conroe, Penryn, and Nehalem CPUs. This causes at least one known problems: Windows XP disables sysenter when (family == 6 && model <= 2), but Skype tries to

[Qemu-devel] [PULL 01/17] dump: Move stubs into libqemustub.a

2013-06-12 Thread Andreas Färber
This allows us to drop CONFIG_NO_CORE_DUMP with its indirect dependency on CONFIG_HAVE_CORE_DUMP. Acked-by: Paolo Bonzini Signed-off-by: Andreas Färber --- Makefile.target | 2 -- stubs/Makefile.objs | 1 + dump-stub.c => stubs/dump.c | 0 3 files changed, 1 insertion(+), 2

Re: [Qemu-devel] [PATCH qom-cpu 00/59] QOM CPUState, part 10: CPU loops

2013-06-12 Thread Andreas Färber
Am 09.06.2013 21:12, schrieb Andreas Färber: > Andreas Färber (59): [...] > spapr_rtas: Abstract rtas_query_cpu_stopped_state() with > qemu_get_cpu() > spapr_rtas: Abstract rtas_start_cpu() with qemu_get_cpu() Alex saw no problem with these and no further feedback from Alexey, so briefly t

Re: [Qemu-devel] [PATCH] spapr: add yet another maintainer

2013-06-12 Thread Alexander Graf
On 13.06.2013, at 02:08, Alexey Kardashevskiy wrote: > On 06/13/2013 12:33 AM, Alexander Graf wrote: >> >> On 12.06.2013, at 16:27, Alexey Kardashevskiy wrote: >> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> MAINTAINERS |1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/M

Re: [Qemu-devel] [PATCH] spapr: add yet another maintainer

2013-06-12 Thread Alexey Kardashevskiy
On 06/13/2013 12:33 AM, Alexander Graf wrote: > > On 12.06.2013, at 16:27, Alexey Kardashevskiy wrote: > >> Signed-off-by: Alexey Kardashevskiy >> --- >> MAINTAINERS |1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 13c0cc5..1e00bb1 100644 >> --- a/

Re: [Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-12 Thread Brad Smith
On 11/06/13 8:57 AM, Michael Tokarev wrote: 05.06.2013 19:25, Michael Tokarev wrote: In two places qemu uses openpty() which is very system-dependent, and in both places the pty is switched to raw mode as well. Make a wrapper function which does both steps, and move all the system-dependent comp

[Qemu-devel] [PATCH 23/26] xilinx_axidma: Do not set DMA .notify to NULL after notify

2013-06-12 Thread Michael Roth
From: Wendy Liang If a stream notify function is not ready, it may re-populate the notify call- back to indicate it should be re-polled later. This break in this usage, as immediately following the notify() call, .notify is set to NULL. reverse the ordering of the notify call and NULL assignment

[Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH

2013-06-12 Thread Michael Roth
From: Andreas Färber The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11 SP1 guest driver reports I/O errors and filesystems get corrupted or remounte

[Qemu-devel] [PATCH 11/26] update seabios to release 1.7.2.2

2013-06-12 Thread Michael Roth
From: Gerd Hoffmann git shortlog from 1.7.2.1 Asias He (2): virtio-scsi: Pack struct virtio_scsi_{req_cmd,resp_cmd} virtio-scsi: Set _DRIVER_OK flag before scsi target scanning Kevin O'Connor (1): Cache boot-fail-wait to avoid romfile access after POST. Signed-off-by: Gerd Ho

[Qemu-devel] [PATCH 25/26] target-i386: Fix aflag logic for CODE64 and the 0x67 prefix

2013-06-12 Thread Michael Roth
From: Richard Henderson The code reorganization in commit 4a6fd938 broke handling of PREFIX_ADR. While fixing this, tidy and comment the code so that it's more obvious what's going on in setting both aflag and dflag. The TARGET_X86_64 ifdef can be eliminated because CODE64 expands to the constan

[Qemu-devel] [PATCH 02/26] hw/9pfs: use O_NOFOLLOW for mapped readlink operation

2013-06-12 Thread Michael Roth
From: "Aneesh Kumar K.V" With mapped security models like mapped-xattr and mapped-file, we save the symlink target as file contents. Now if we ever expose a normal directory with mapped security model and find real symlinks in export path, never follow them and return proper error. Reviewed-by:

[Qemu-devel] [PATCH 04/26] qom/object: Don't poll cast cache for NULL objects

2013-06-12 Thread Michael Roth
From: Peter Crosthwaite object_dynamic_cast_assert used to be tolerant of NULL objects and not assert. It's clear from the implementation that this is the expected behavior. The preceding check of the cast cache dereferences obj however causing a segfault. Fix by conditionalizing the cast cache

[Qemu-devel] [PATCH 22/26] virtio-ccw: Fix unsetting of indicators.

2013-06-12 Thread Michael Roth
From: Cornelia Huck Interpretation of the ccws to register (configuration) indicators contained a thinko: We want to disallow reading from 0, but setting the indicator pointer to 0 is fine. Let's fix the handling for CCW_CMD_SET{,_CONF}_IND. Cc: qemu-sta...@nongnu.org Signed-off-by: Cornelia Hu

[Qemu-devel] [PATCH 26/26] q35: set fw_name

2013-06-12 Thread Michael Roth
From: "Michael S. Tsirkin" PCI host bridges need to set fw_name to be discoverable by bios for boot device selection. In particular, seabios expects root device to be called "/pci/@i0cf8", so let's set it up like that for Q35. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin Tested

[Qemu-devel] [PATCH 19/26] vmxnet3: fix NICState cleanup

2013-06-12 Thread Michael Roth
From: Stefan Hajnoczi Use qemu_del_nic() instead of qemu_del_net_client() to correctly free the entire NICState. Cc: qemu-sta...@nongnu.org Reported-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi (cherry picked from commit 3ffee3cd5fb29de2115bdcbde0a02f47ce69a24c) Signed-off-by: Michael Rot

[Qemu-devel] [PATCH 21/26] s390x/css: Fix concurrent sense.

2013-06-12 Thread Michael Roth
From: Cornelia Huck Fix an off-by-one error when indicating availablity of concurrent sense data. Cc: qemu-sta...@nongnu.org Signed-off-by: Cornelia Huck (cherry picked from commit 8312976e73fce9689ab831c1da565ec413680cff) Signed-off-by: Michael Roth --- hw/s390x/css.c |2 +- 1 file chan

[Qemu-devel] [PATCH 17/26] host-libusb: Correct test for USB packet state

2013-06-12 Thread Michael Roth
From: Ed Maste USB_RET_ASYNC is -6, so inflight was always false. Signed-off-by: Ed Maste Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann (cherry picked from commit 45ec267160307ce2ca7494d942589ba222b29479) Signed-off-by: Michael Roth --- hw/usb/host-libusb.c |2 +- 1 file chang

[Qemu-devel] [PATCH 18/26] Fix usage of USB_DEV_FLAG_IS_HOST flag.

2013-06-12 Thread Michael Roth
From: Michael Marineau USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a "Fitbit Base Station" USB dongle was triggering this assert. Signed-off-by: Michael Marineau Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann (cherry picked from commit 756335292f2b46775992c314cc70b

[Qemu-devel] [PATCH 01/26] hw/9pfs: Fix segfault with 9p2000.u

2013-06-12 Thread Michael Roth
From: "Aneesh Kumar K.V" When guest tries to chmod a block or char device file over 9pfs, the qemu process segfaults. With 9p2000.u protocol we use wstat to change mode bits and client don't send extension information for chmod. We need to check for size field to check whether extension info is p

[Qemu-devel] [PATCH 13/26] Remove OSS support for OpenBSD

2013-06-12 Thread Michael Roth
From: Brad Smith Remove the OSS support for OpenBSD. The OSS API has not been usable for quite some time. Signed-off-by: Brad Smith Reviewed-by: Laszlo Ersek Reviewed-by: Andreas Färber Signed-off-by: Blue Swirl (cherry picked from commit 4f6ab397b60615d2da77bff4f32666be9ac2e949) Signed-off

[Qemu-devel] [PATCH 20/26] ui/gtk.c: Fix *BSD build of Gtk+ UI

2013-06-12 Thread Michael Roth
From: Brad Smith Fix the build of the Gtk+ UI on *BSD systems. Signed-off-by: Brad Smith Reviewed-by: Laszlo Ersek Message-id: 20130521161324.ga29...@rox.home.comstyle.com Signed-off-by: Anthony Liguori (cherry picked from commit 17bf9735dd5a46d829cfb175703c6a2c254a9aa2) Signed-off-by: Micha

[Qemu-devel] [PATCH 10/26] Revert "roms: switch oldnoconfig to olddefconfig"

2013-06-12 Thread Michael Roth
From: Gerd Hoffmann This reverts commit a5519b42cfd6c00e9f8b31c5aad7682e7a9f1181. Breaks "make bios" in roms/ as the kconfig version in seabios doesn't support olddefconfig. Must have been be totally untested. Signed-off-by: Gerd Hoffmann (cherry picked from commit 19cd090e17b293b49eec59346df

[Qemu-devel] [PATCH 16/26] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path

2013-06-12 Thread Michael Roth
From: Amos Kong Recent virtio refactoring in QEMU made virtio-bus become the parent bus of scsi-bus, and virtio-bus doesn't have get_fw_dev_path implementation, typename will be added to fw_dev_path by default, the new fw_dev_path could not be identified by seabios. It causes that bootindex param

[Qemu-devel] [PATCH 24/26] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-12 Thread Michael Roth
When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, and it was issued as a bottom-half: 86e94dea5b740dad65446c857f6959eae43e0ba6 Which we basically used to print out a greeting/prompt for the monitor. AFAICT the only reason this was ever done in a BH was because in some cases we'd

[Qemu-devel] [PATCH 15/26] do not check pointers after dereferencing them

2013-06-12 Thread Michael Roth
From: Paolo Bonzini Two instances, both spotted by Coverity. In one, two blocks were swapped. In the other, the check is not needed anymore. Cc: qemu-sta...@nongnu.org Cc: qemu-triv...@nongnu.org Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev (cherry pic

[Qemu-devel] [PATCH 12/26] target-i386: fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-06-12 Thread Michael Roth
From: Luiz Capitulino The code used to walk IA-32e page-tables, and possibly PAE page-tables, uses the bit mask ~0xfff to get the next PML4E/PDPTE/PDE/PTE address. However, as we use a uint64_t to store the resulting address, that mask gets expanded to 0xf000 which not only ends up s

[Qemu-devel] [PATCH 14/26] xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)

2013-06-12 Thread Michael Roth
From: Stefano Stabellini We are currently setting the PCI hole to start at HVM_BELOW_4G_RAM_END, that is 0xf000. Start the PCI hole at 0xe000 instead, that is the same value used by pc_init1 and qemu-xen-traditional. Signed-off-by: Stefano Stabellini CC: qemu-sta...@nongnu.org (cherry p

[Qemu-devel] [PATCH 05/26] xen: simplify xen_enabled

2013-06-12 Thread Michael Roth
From: Stefano Stabellini No need for preprocessor conditionals in xen_enabled: xen_allowed is always defined. Signed-off-by: Stefano Stabellini CC: qemu-sta...@nongnu.org (cherry picked from commit 49fa9881b2358e390e9e9466ddde74e995927efa) Signed-off-by: Michael Roth --- include/hw/xen/xen.h

[Qemu-devel] [PATCH 07/26] xen_machine_pv: do not create a dummy CPU in machine->init

2013-06-12 Thread Michael Roth
From: Stefano Stabellini This fixes a regression introduced by: commit 62fc403f11523169eb4264de31279745f48e3ecc Author: Igor Mammedov Date: Mon Apr 29 18:54:13 2013 +0200 target-i386: Attach ICC bus to CPU on its creation X86CPU should have parent bus so it could provide bus for chi

[Qemu-devel] [PATCH 08/26] chardev: fix "info chardev" output

2013-06-12 Thread Michael Roth
From: Gerd Hoffmann Fill unset CharDriverState->filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd Hoffmann (cherry picked

[Qemu-devel] [PATCH 03/26] rtl8139: flush queued packets when RxBufPtr is written

2013-06-12 Thread Michael Roth
From: Stefan Hajnoczi Net queues support efficient "receive disable". For example, tap's file descriptor will not be polled while its peer has receive disabled. This saves CPU cycles for needlessly copying and then dropping packets which the peer cannot receive. rtl8139 is missing the qemu_flu

[Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

2013-06-12 Thread Michael Roth
Hi everyone, The following new patches are queued for QEMU stable v1.5.1: https://github.com/mdroth/qemu/commits/stable-1.5-staging The release is planned for 2013-06-26: http://wiki.qemu.org/Planning/1.5 Please respond here or CC qemu-sta...@nongnu.org on any patches you think should be inclu

[Qemu-devel] [PATCH 06/26] main_loop: do not set nonblocking if xen_enabled()

2013-06-12 Thread Michael Roth
From: Stefano Stabellini Signed-off-by: Stefano Stabellini CC: qemu-sta...@nongnu.org (cherry picked from commit a7d4207d378069a5bb3175a131e8fdedd39ef97d) Signed-off-by: Michael Roth --- vl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 59dc0b4..efb

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread mdroth
On Wed, Jun 12, 2013 at 04:17:53PM -0500, Anthony Liguori wrote: > mdroth writes: > > > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > >> When this VMSD was introduced it's version fields were set to > >> sizeof(I6300State), making them essentially random from build to build, > >

Re: [Qemu-devel] [PATCH] kvm/openpic: add kvm_irqchip_commit_routes

2013-06-12 Thread Alexander Graf
On 12.06.2013, at 23:25, Scott Wood wrote: > On 06/12/2013 04:23:09 PM, Alexander Graf wrote: >> On 12.06.2013, at 23:21, Scott Wood wrote: >> > The patch that added kvm_irqchip_commit_routes was originally >> > meant to come after the in-kernel mpic patch, and thus it updated >> > hw/intc/openpi

Re: [Qemu-devel] [PATCH] kvm/openpic: add kvm_irqchip_commit_routes

2013-06-12 Thread Scott Wood
On 06/12/2013 04:23:09 PM, Alexander Graf wrote: On 12.06.2013, at 23:21, Scott Wood wrote: > The patch that added kvm_irqchip_commit_routes was originally > meant to come after the in-kernel mpic patch, and thus it updated > hw/intc/openpic_kvm.c. However, it was applied before the in-kernel

Re: [Qemu-devel] [PATCH] kvm/openpic: add kvm_irqchip_commit_routes

2013-06-12 Thread Alexander Graf
On 12.06.2013, at 23:21, Scott Wood wrote: > The patch that added kvm_irqchip_commit_routes was originally > meant to come after the in-kernel mpic patch, and thus it updated > hw/intc/openpic_kvm.c. However, it was applied before the in-kernel > mpic patch (which creates hw/intc/openpic_kvm.c),

[Qemu-devel] [PATCH] kvm/openpic: add kvm_irqchip_commit_routes

2013-06-12 Thread Scott Wood
The patch that added kvm_irqchip_commit_routes was originally meant to come after the in-kernel mpic patch, and thus it updated hw/intc/openpic_kvm.c. However, it was applied before the in-kernel mpic patch (which creates hw/intc/openpic_kvm.c), and thus this hunk got lost. Signed-off-by: Scott W

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread Anthony Liguori
mdroth writes: > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: >> When this VMSD was introduced it's version fields were set to >> sizeof(I6300State), making them essentially random from build to build, >> version to version. >> >> To fix this, we lock in a high version id and lo

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread mdroth
On Wed, Jun 12, 2013 at 09:42:14PM +0100, Peter Maydell wrote: > On 12 June 2013 21:11, mdroth wrote: > > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > >> When this VMSD was introduced it's version fields were set to > >> sizeof(I6300State), making them essentially random from bu

Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-12 Thread Alexander Graf
On 12.06.2013, at 22:32, Scott Wood wrote: > Enables support for the in-kernel MPIC that thas been merged into the > KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex > Graf (along with some other improvements). > > Note from Alex regarding kvm_irqchip_create(): > > On x86,

Re: [Qemu-devel] [PATCH v3 1/9] KVM: Don't assume that mpstate exists with in-kernel PIC always

2013-06-12 Thread Alexander Graf
On 12.06.2013, at 22:16, Scott Wood wrote: > On 06/12/2013 08:04:55 AM, Alexander Graf wrote: >> On 01.05.2013, at 03:48, Scott Wood wrote: >> > From: Alexander Graf >> > >> > On PPC, we don't support MP state. So far it's not necessary and I'm >> > not convinced yet that we really need to suppo

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread Peter Maydell
On 12 June 2013 21:11, mdroth wrote: > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: >> When this VMSD was introduced it's version fields were set to >> sizeof(I6300State), making them essentially random from build to build, >> version to version. >> >> To fix this, we lock in a hi

Re: [Qemu-devel] [Qemu-ppc] [PATCH 8/9] kvm/openpic: in-kernel mpic support

2013-06-12 Thread Scott Wood
On 06/12/2013 08:01:06 AM, Alexander Graf wrote: On 01.05.2013, at 03:48, Scott Wood wrote: > +static void kvm_openpic_region_add(MemoryListener *listener, > + MemoryRegionSection *section) > +{ > +KVMOpenPICState *opp = container_of(listener, KVMOpenPICStat

Re: [Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend

2013-06-12 Thread mdroth
On Fri, May 31, 2013 at 02:12:48PM -0400, Cole Robinson wrote: > 'default_backend' isn't always set, but 'rng' is, so use that. > > $ ./x86_64-softmmu/qemu-system-x86_64 -object > rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0 > Segmentation fault (core dumped) > > Regre

[Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-12 Thread Scott Wood
Enables support for the in-kernel MPIC that thas been merged into the KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex Graf (along with some other improvements). Note from Alex regarding kvm_irqchip_create(): On x86, one would call kvm_irqchip_create() to initialize an in-

Re: [Qemu-devel] virtio-scsi and error handling

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 03:56, Stefan Hajnoczi ha scritto: > On Tue, Jun 11, 2013 at 01:41:38PM +0200, Hannes Reinecke wrote: >> I currently playing around with improving SCSI EH, optimizing >> command aborts and the like. >> >> And, supposing it to be a nice testbed, tried to make things work >> with virtio

Re: [Qemu-devel] [PATCH v3 1/9] KVM: Don't assume that mpstate exists with in-kernel PIC always

2013-06-12 Thread Scott Wood
On 06/12/2013 08:04:55 AM, Alexander Graf wrote: On 01.05.2013, at 03:48, Scott Wood wrote: > From: Alexander Graf > > On PPC, we don't support MP state. So far it's not necessary and I'm > not convinced yet that we really need to support it ever. > > However, the current idle logic in QEMU as

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 11:25, George Dunlap ha scritto: >>> If you have 4GB of RAM it will end at 0x14000 (or something like >>> that) and that's where the 64-bit window starts. Of course if you have >>> no RAM above the PCI hole, the 64-bit window will start at 0x1. >> So there's no provision

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread mdroth
On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to

Re: [Qemu-devel] [Qemu-ppc] broken incoming migration

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 10:11, Benjamin Herrenschmidt ha scritto: > On Wed, 2013-06-12 at 10:00 -0400, Paolo Bonzini wrote: >> The only bug we have is not a performance bug related to compression; >> it's that writing zero pages breaks overcommit. Let's fix that, and >> only that. > > Right, do we have a w

Re: [Qemu-devel] [0/10] Clean up PCI code to allow for multiple root buses (v2)

2013-06-12 Thread Michael S. Tsirkin
On Wed, Jun 12, 2013 at 05:18:46PM +1000, Alexey Kardashevskiy wrote: > On 06/06/2013 08:01 PM, Michael S. Tsirkin wrote: > > On Thu, Jun 06, 2013 at 06:48:44PM +1000, David Gibson wrote: > >> The current PCI subsystem has kind of half-hearted support for > >> multiple independent root buses - aka

[Qemu-devel] [PULL 09/13] tcg/aarch64: implement sign/zero extend operations

2013-06-12 Thread Peter Maydell
From: Claudio Fontana implement the optional sign/zero extend operations with the dedicated aarch64 instructions. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Message-id: 51ac9a58.40...@huawei.com Signed-off-by: Peter Maydell --- tcg/aarch64/tcg-target.c | 58 +

[Qemu-devel] [PULL 08/13] tcg/aarch64: implement byte swap operations

2013-06-12 Thread Peter Maydell
From: Claudio Fontana implement the optional byte swap operations with the dedicated aarch64 instructions. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Message-id: 51ac9a33.9050...@huawei.com Signed-off-by: Peter Maydell --- tcg/aarch64/tcg-target.c | 32 ++

[Qemu-devel] [PULL 06/13] tcg/aarch64: improve arith shifted regs operations

2013-06-12 Thread Peter Maydell
From: Claudio Fontana for arith operations, add SUBS, ANDS, ADDS and add a shift parameter so that all arith instructions can make use of shifted registers. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Message-id: 51ac998b.7070...@huawei.com Signed-off-by: Peter Maydell ---

[Qemu-devel] [PULL 11/13] tcg/aarch64: implement user mode qemu ld/st

2013-06-12 Thread Peter Maydell
From: Jani Kokkonen also put aarch64 in the list of archs that do not need an ldscript. Signed-off-by: Jani Kokkoken Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 51af40ee.1000...@huawei.com Signed-off-by: Peter Maydell --- configure

[Qemu-devel] [PULL 05/13] tcg/aarch64: implement new TCG target for aarch64

2013-06-12 Thread Peter Maydell
From: Claudio Fontana add preliminary support for TCG target aarch64. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 51a5c596.3090...@huawei.com Signed-off-by: Peter Maydell --- include/exec/exec-all.h |5 +- tcg/aarch64/tcg-target.

[Qemu-devel] [PULL 13/13] MAINTAINERS: add tcg/aarch64 maintainer

2013-06-12 Thread Peter Maydell
From: Claudio Fontana Signed-off-by: Claudio Fontana Message-id: 51aca0b2.80...@huawei.com Signed-off-by: Peter Maydell --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 13c0cc5..3412b07 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7

[Qemu-devel] [PULL 04/13] include/elf.h: add aarch64 ELF machine and relocs

2013-06-12 Thread Peter Maydell
From: Claudio Fontana we will use the 26bit relative relocs in the aarch64 tcg target. Reviewed-by: Peter Maydell Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Message-id: 51a5c52a.4080...@huawei.com Signed-off-by: Peter Maydell --- include/elf.h | 129 +

  1   2   >