Re: [Qemu-devel] [PATCH] QEMUBH: make AioContext's bh re-entrant

2013-06-15 Thread liu ping fan
On Sat, Jun 15, 2013 at 1:35 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/06/2013 22:55, Liu Ping Fan ha scritto: BH will be used outside big lock, so introduce lock to protect it. Note that the lock only affects the writer and bh's callback does not take this extra lock.

Re: [Qemu-devel] [PATCH v9 10/14] rdma: introduce capability x-rdma-pin-all

2013-06-15 Thread Eric Blake
On 06/14/2013 09:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. +++ b/qapi-schema.json @@ -608,10 +608,15 @@ # This feature

Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics

2013-06-15 Thread Eric Blake
On 06/14/2013 09:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com For very large virtual machines, pinning can take a long time. While this does not affect the migration's *actual* time itself, it is still important for the user to know what's going on and

Re: [Qemu-devel] [PATCH v9 04/14] rdma: export throughput w/ MigrationStats QMP

2013-06-15 Thread Eric Blake
On 06/14/2013 09:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com This exposes throughput (in megabits/sec) through QMP. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- hmp.c

[Qemu-devel] [PATCH trivial] qemu-options: trivial fix for -mon args help

2013-06-15 Thread Michael Tokarev
It is the (implied sub)option name which is optional, not the value of that (sub)option, make it so in the help output. (Introduced by commit 22a0e04b9bb) Cc: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- qemu-options.hx |4 ++-- 1 file changed, 2

Re: [Qemu-devel] [PATCH V2 08/12] qmp: add interface blockdev-snapshot-internal-sync

2013-06-15 Thread Eric Blake
On 06/14/2013 12:39 PM, Wenchao Xia wrote: This interface can generate snapshot name automatically if it is not specified, since it is a single opertion. s/opertion/operation/ Snapshot ID can't be specified in this interface. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH V2 09/12] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-15 Thread Eric Blake
On 06/14/2013 12:39 PM, Wenchao Xia wrote: Snapshot ID can't be specified in this interface. Why not? If it is possible to look up by id in isolation, then it should be possible to delete by id in isolation. Also, if it is possible to create a snapshot that has an id but no name (and I think

Re: [Qemu-devel] [PATCH V2 07/12] qmp: add internal snapshot support in qmp_transaction

2013-06-15 Thread Eric Blake
On 06/14/2013 12:39 PM, Wenchao Xia wrote: Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. The snapshot name should not mess up with snapshot ID, there is a check for it. Although

[Qemu-devel] [PATCH trivial] vl: always define no_frame

2013-06-15 Thread Michael Tokarev
Commit 047d4e151dd46 Unbreak -no-quit for GTK, validate SDL options broke build of qemu without sdl, by referencing `no_frame' variable which is defined inside #if SDL block. Fix that by defining that variable unconditionally. This is a better fix for the build issue introduced by that patch

[Qemu-devel] [PATCH trivial] vl: reformat SDL ifdeffery a bit

2013-06-15 Thread Michael Tokarev
This reformats #ifdef..#endif and case statement a bit, to make it a bit shorter and matching other cases like that (no code changes). Signed-off-by: Michael Tokarev m...@tls.msk.ru --- vl.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vl.c b/vl.c index

Re: [Qemu-devel] [PATCH trivial] vl: always define no_frame

2013-06-15 Thread Peter Wu
On Saturday 15 June 2013 14:42:03 Michael Tokarev wrote: Commit 047d4e151dd46 Unbreak -no-quit for GTK, validate SDL options broke build of qemu without sdl, by referencing `no_frame' variable which is defined inside #if SDL block. Fix that by defining that variable unconditionally. This

Re: [Qemu-devel] [PATCH trivial] vl: always define no_frame

2013-06-15 Thread Michael Tokarev
15.06.2013 14:51, Peter Wu wrote: On Saturday 15 June 2013 14:42:03 Michael Tokarev wrote: Commit 047d4e151dd46 Unbreak -no-quit for GTK, validate SDL options broke build of qemu without sdl, by referencing `no_frame' variable which is defined inside #if SDL block. Fix that by defining that

Re: [Qemu-devel] [PATCH] QEMUBH: make AioContext's bh re-entrant

2013-06-15 Thread Paolo Bonzini
Il 15/06/2013 04:43, liu ping fan ha scritto: On Sat, Jun 15, 2013 at 1:35 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/06/2013 22:55, Liu Ping Fan ha scritto: BH will be used outside big lock, so introduce lock to protect it. Note that the lock only affects the writer and bh's callback

[Qemu-devel] [PATCH] linux-user: fix signal number range check

2013-06-15 Thread Andreas Schwab
When translating between host and target signal numbers keep negative numbers unchanged, avoiding access beyond array bounds. Signed-off-by: Andreas Schwab sch...@linux-m68k.org --- linux-user/signal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/signal.c

[Qemu-devel] [PATCH] sun4m: add display width and height to the firmware configuration

2013-06-15 Thread Mark Cave-Ayland
Currently the graphics resolution for TCX is fixed at 1024x768, however other framebuffers are capable of supporting additional resolutions. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk --- hw/sparc/sun4m.c |4 1 file changed, 4 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] sun4m: add display width and height to the firmware configuration

2013-06-15 Thread Andreas Färber
Am 15.06.2013 15:55, schrieb Mark Cave-Ayland: Currently the graphics resolution for TCX is fixed at 1024x768, however other framebuffers are capable of supporting additional resolutions. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk Looks fine, Reviewed-by: Andreas Färber

Re: [Qemu-devel] [PATCH] linux-user: fix signal number range check

2013-06-15 Thread Peter Maydell
On 15 June 2013 13:33, Andreas Schwab sch...@linux-m68k.org wrote: When translating between host and target signal numbers keep negative numbers unchanged, avoiding access beyond array bounds. Signed-off-by: Andreas Schwab sch...@linux-m68k.org Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-15 Thread Eric Blake
On 06/08/2013 10:49 PM, Peter Wu wrote: When QEMU starts, it always changes the serial port parameters including baud rate. This confused my guest which thought it was outputting at 9600 baud while it was in fact changed to 115200. After this patch, I can use `-serial /dev/ttyS0,baud=9600`

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor command to enable/disable

2013-06-15 Thread Eric Blake
On 06/06/2013 04:37 PM, Gerd Hoffmann wrote: This patch adds a fbdev monitor command to enable/disable the fbdev display at runtime to both qmp and hmp. qmp: framebuffer-display enable=on|off scale=on|off device=/dev/fbn hmp: framebuffer-display on|off Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-15 Thread Peter Wu
On Saturday 15 June 2013 16:14:23 Eric Blake wrote: On 06/08/2013 10:49 PM, Peter Wu wrote: When QEMU starts, it always changes the serial port parameters including baud rate. This confused my guest which thought it was outputting at 9600 baud while it was in fact changed to 115200.

Re: [Qemu-devel] [PATCH 1/2] Revert migration: do not sent zero pages in bulk stage

2013-06-15 Thread Eric Blake
On 06/06/2013 03:26 PM, Peter Lieven wrote: @@ -514,8 +512,8 @@ ## { 'type': 'MigrationStats', 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' , - 'duplicate': 'int', 'skipped': 'int', 'normal': 'int', - 'normal-bytes': 'int', 'dirty-pages-rate'

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-15 Thread Eric Blake
On 06/15/2013 04:25 PM, Peter Wu wrote: On Saturday 15 June 2013 16:14:23 Eric Blake wrote: On 06/08/2013 10:49 PM, Peter Wu wrote: When QEMU starts, it always changes the serial port parameters including baud rate. This confused my guest which thought it was outputting at 9600 baud while it

Re: [Qemu-devel] [PATCH] QEMUBH: make AioContext's bh re-entrant

2013-06-15 Thread Paolo Bonzini
Il 15/06/2013 07:16, Paolo Bonzini ha scritto: ... I'm not sure that this works yet. I see two problems: ctx-walking_bh needs to be accessed atomic, and while you are doing the deletions somebody could come up and start a read. Havoc. Hmm, are you just trying to protect aio_bh_poll from

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-15 Thread Paolo Bonzini
Il 13/06/2013 21:16, Wanlong Gao ha scritto: On 06/14/2013 09:05 AM, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 13/06/2013 08:50, Eduardo Habkost ha scritto: I believe an interface based on guest physical memory addresses is more flexible (and even simpler!) than one

Re: [Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-06-15 Thread Paolo Bonzini
Il 14/06/2013 04:06, Markus Armbruster ha scritto: Here's another way to keep the KVM hooks regular: make my function pointers exec.c hooks instead of KVM hooks ;-P I can buy this one! Paolo

Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics

2013-06-15 Thread Paolo Bonzini
Il 15/06/2013 05:06, Eric Blake ha scritto: On 06/14/2013 09:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com For very large virtual machines, pinning can take a long time. While this does not affect the migration's *actual* time itself, it is still

Re: [Qemu-devel] [PATCH v2 00/12] QOM realize for ISA, part 2

2013-06-15 Thread Blue Swirl
On Fri, Jun 7, 2013 at 12:58 PM, Andreas Färber afaer...@suse.de wrote: Hello, Here is my next batch of QOM realize patches for ISA devices. For two new ISA devices QOM cast macros are introduced (gus, cs4231a); these two and the new pvpanic ISA device are now converted, too. Series is

Re: [Qemu-devel] [PATCH v4 00/12] target-i386: remove some macros

2013-06-15 Thread Blue Swirl
On Tue, May 28, 2013 at 8:19 AM, li guang lig.f...@cn.fujitsu.com wrote: remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF as suggested by Richard Henderson r...@twiddle.net Thanks, applied all. v4: fix alignment issue in patch 6. Li Guang (12) target-i386/helper:

Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e

2013-06-15 Thread Hervé Poussineau
mdroth a écrit : On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote: Ping. This should be IMO committed to stable, as it fixes a crash with qemu-system-ppc -M prep -cpu 603e Ping^2. Looking to pull this in for 1.5.1 Ping^3 Hervé Poussineau a écrit : IABR SPR is already

Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e

2013-06-15 Thread Hervé Poussineau
mdroth a écrit : On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote: Ping. This should be IMO committed to stable, as it fixes a crash with qemu-system-ppc -M prep -cpu 603e Ping^2. Looking to pull this in for 1.5.1 Ping^3 Hervé Hervé Poussineau a écrit : IABR SPR is

[Qemu-devel] qemu-1.5.0 gdb not working

2013-06-15 Thread Peter Cheung
qemu-1.5.0 gdb not working In mac OSX, compile by :./configure --cc=/opt/local/bin/gcc-mp-4.8 --enable-cocoa --target-list=x86_64-softmmu --audio-drv-list=coreaudio --prefix=/Users/peter/qemu --enable-debug --disable-werror --extra-cflags=-O2 --enable-vnc start qemu

Re: [Qemu-devel] qemu-1.5.0 gdb not working

2013-06-15 Thread Frederic Konrad
On 15/06/2013 20:37, Peter Cheung wrote: qemu-1.5.0 gdb not working In mac OSX, compile by : ./configure --cc=/opt/local/bin/gcc-mp-4.8 --enable-cocoa --target-list=x86_64-softmmu --audio-drv-list=coreaudio --prefix=/Users/peter/qemu --enable-debug --disable-werror --extra-cflags=-O2

Re: [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e

2013-06-15 Thread Andreas Färber
Am 11.05.2013 21:03, schrieb Hervé Poussineau: IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). Signed-off-by: Hervé Poussineau hpous...@reactos.org Confirmed, Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5,

[Qemu-devel] [Bug 1191326] [NEW] QNX 4 doesn't boot on qemu = 1.3

2013-06-15 Thread JQu
Public bug reported: I am using virtual machine with QNX4 operating system installed on it. I updated my qemu from version to newer and QNX4 doesn't start any more. All is ok on version 1.2 but when I try to use any newer version (1.3, 1.4, 1.5) QNX4 doesn't boot. I tried on windows and

Re: [Qemu-devel] RDMA: please pull and re-test freezing fixes

2013-06-15 Thread Chegu Vinod
On 6/14/2013 1:38 PM, Michael R. Hines wrote: Chegu, I sent a V9 to the mailing list: The version goes even further, by explicitly timing the pinning latency and pushing the value out to QMP so the user clearly knows which component of total migration time is consumed by pinning. If you're

Re: [Qemu-devel] [PATCH v9 00/14] rdma: migration support

2013-06-15 Thread Chegu Vinod
On 6/14/2013 1:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com Changes since v8: For very large virtual machines, pinning can take a long time. While this does not affect the migration's *actual* time itself, it is still important for the user

Re: [Qemu-devel] qemu-1.5.0 gdb not working

2013-06-15 Thread Peter Cheung
stepi is working. Date: Sat, 15 Jun 2013 20:56:57 +0200 From: fred.kon...@greensocs.com To: mcheun...@hotmail.com CC: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] qemu-1.5.0 gdb not working On 15/06/2013 20:37, Peter Cheung wrote: qemu-1.5.0

[Qemu-devel] [PATCH RFC 2/8] ui/input: Simplify kbd_mouse_event()

2013-06-15 Thread Andreas Färber
Now that the field names are bearable, there's no compelling reason to use local variables for the fields. Unify the four callback invokations through variables for the rotated coordinates instead. Signed-off-by: Andreas Färber afaer...@suse.de --- ui/input.c | 28 ++--

[Qemu-devel] [PATCH RFC 1/8] ui/input: Clean up QEMUPutMouseEntry struct

2013-06-15 Thread Andreas Färber
Shorten field names to not duplicate struct name. Signed-off-by: Andreas Färber afaer...@suse.de --- ui/input.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/ui/input.c b/ui/input.c index 92c44ca..badf6c3 100644 --- a/ui/input.c +++

[Qemu-devel] [PATCH RFC 0/8] monitor: Fix mouse_button and improve mouse_move commands

2013-06-15 Thread Andreas Färber
Hi everyone, Here's a new stab at fixing mouse_button HMP command with absolute coordinates, as seen with the following devices: usb-tablet, usb-wacom-tablet, ads7846 and depending on settings vmmouse and xenfb, as well as pre-qdev tsc2005, tsc2102, tsc2301 touchscreens. openQA [3] is a

[Qemu-devel] [PATCH RFC 4/8] ui/input: Introduce MouseOps for qemu_add_mouse_event_handler()

2013-06-15 Thread Andreas Färber
This allows to add callbacks to mouse event handlers without constantly touching all callers of qemu_add_mouse_event_handler() or qemu_add_mouse_event_handler() itself. Signed-off-by: Andreas Färber afaer...@suse.de --- backends/msmouse.c | 6 +- hw/char/escc.c | 6 +-

[Qemu-devel] [PATCH RFC 6/8] monitor: Eliminate global mouse buttons state for mouse_move

2013-06-15 Thread Andreas Färber
mouse_button command would save buttons state globally so that move_move command could reuse it for kbd_mouse_event(). Introduce kbd_mouse_move_event() to allow to use new MouseOps::get_buttons_state() to obtain buttons state from the respective mouse. This means that mouse_set will now affect

[Qemu-devel] [PATCH RFC 3/8] ui/input: Use bool for qemu_add_mouse_event_handler()

2013-06-15 Thread Andreas Färber
Change kbd_mouse_{is,has}_absolute() alongside. vmmouse uses uint8_t in its VMStateDescription, and Xen uses int in xend communication, so they cannot easily be changed. Signed-off-by: Andreas Färber afaer...@suse.de --- backends/msmouse.c | 3 ++- hw/char/escc.c | 2 +-

[Qemu-devel] [PATCH RFC 8/8] monitor: Fix mouse_button command for absolute coordinates

2013-06-15 Thread Andreas Färber
When using a virtual mouse device with absolute coordinates (tablet) the mouse_button command would raise a mouse event at coordinates (0,0,0), breaking openQA among others. Use a new kbd_mouse_button_event() to obtain the current position with the new MouseOps::get_position() callback when in

[Qemu-devel] [PATCH RFC 7/8] ui/input: Introduce MouseOps::get_position()

2013-06-15 Thread Andreas Färber
Traditionally mice have used relative coordinates, so that a mouse event at (0,0,0) would mean no change of position. However, with absolute coordinates those coordinates signify the top left corner. Since the VMState of mice is kept at device level, introduce a callback to retrieve the current

[Qemu-devel] [PATCH RFC 5/8] ui/input: Introduce MouseOps::get_buttons_state()

2013-06-15 Thread Andreas Färber
Extend msmouse CharDriverState and escc ChannelState to store it. Signed-off-by: Andreas Färber afaer...@suse.de --- backends/msmouse.c | 22 +++--- hw/char/escc.c | 11 +++ hw/display/ads7846.c | 8 hw/display/xenfb.c | 9 + hw/input/adb.c

Re: [Qemu-devel] [PATCH v9 10/14] rdma: introduce capability x-rdma-pin-all

2013-06-15 Thread Michael R. Hines
On 06/15/2013 05:05 AM, Eric Blake wrote: On 06/14/2013 09:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. +++ b/qapi-schema.json @@ -608,10

Re: [Qemu-devel] [PATCH v9 04/14] rdma: export throughput w/ MigrationStats QMP

2013-06-15 Thread Michael R. Hines
On 06/15/2013 05:09 AM, Eric Blake wrote: On 06/14/2013 09:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com This exposes throughput (in megabits/sec) through QMP. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines

Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics

2013-06-15 Thread Michael R. Hines
On 06/15/2013 05:06 AM, Eric Blake wrote: On 06/14/2013 09:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com For very large virtual machines, pinning can take a long time. While this does not affect the migration's *actual* time itself, it is still important

Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics

2013-06-15 Thread Michael R. Hines
On 06/15/2013 01:32 PM, Paolo Bonzini wrote: Il 15/06/2013 05:06, Eric Blake ha scritto: On 06/14/2013 09:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com For very large virtual machines, pinning can take a long time. While this does not affect the

Re: [Qemu-devel] [PATCH v9 00/14] rdma: migration support

2013-06-15 Thread Michael R. Hines
On 06/15/2013 06:51 PM, Chegu Vinod wrote: On 6/14/2013 1:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com Changes since v8: For very large virtual machines, pinning can take a long time. While this does not affect the migration's *actual* time

Re: [Qemu-devel] RDMA: please pull and re-test freezing fixes

2013-06-15 Thread Michael R. Hines
These are great results. Even the one that doesn't converge is good, because it shows that your patch for CPU throttling earlier on the mailing list is still very necessary. Thanks a lot, I will send out a V10 patch to everybody's results. - Michael Would you be interested in me posting them

[Qemu-devel] [Bug 1191457] [NEW] broken build without sdl

2013-06-15 Thread Sherpya
Public bug reported: vl.c fails to build if not using sdl since no_frame variable is only defined if CONFIG_SDL, while QEMU_OPTION_no_frame tries to set it without ifdef ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a