[Qemu-devel] [PATCH] qmp: add 'drive' to enum NewImageMode

2013-06-16 Thread Fam Zheng
Introduce a "drive" option to new image mode. With this mode, QMP command should (this patch only modified drive-backup to support it, and report invalid parameter error for drive-mirror) skip creating the image file or trying to open it, it should just reuse the existing BDS by looking for the nam

[Qemu-devel] [PATCH v2] configure: do not quote $PKG_CONFIG

2013-06-16 Thread Mike Frysinger
We should not quote the PKG_CONFIG setting as this deviates from the canonical upstream behavior that gets integrated with all other build systems, and deviates from how we treat all other toolchain variables that we get from the environment. Ultimately, the point is that it breaks passing custom

[Qemu-devel] [PATCH] qemu-log: wrap long text

2013-06-16 Thread Mike Frysinger
The existing help output is a bit hard to read due to the ad-hoc wrapping. This makes it a bit more programmatic (at least, it wraps it once, but that should be good enough for now). It's not terribly intelligent (just sticks a dash in the middle of the broken word) rather than splitting on whites

Re: [Qemu-devel] [PATCH] fix typo: apci -> acpi

2013-06-16 Thread Michael Tokarev
17.06.2013 06:08, Hu Tao wrote: > Michael, > > On Thu, Jun 13, 2013 at 01:05:10PM +0200, Andreas Färber wrote: >> Am 13.06.2013 12:51, schrieb Hu Tao: >>> Signed-off-by: Hu Tao >>> --- >>> hw/acpi/ich9.c | 4 ++-- >>> hw/acpi/piix4.c | 6 +++--- >>> 2 files changed, 5 insertions(+), 5 deletions

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-16 Thread Gerd Hoffmann
Hi, > Can I use current seabios with old qemu which does not provide > the separate ACPI tables? For example, does current bios contain > these tables too, so they're both separate and embedded? Yes. The i440fx acpi tables are compiled in and will be used as fallback in case qemu doesn't prov

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-16 Thread Gerd Hoffmann
Hi, > Why is QXL unable to do a synchronous screendump? Lazy rendering. By default spice-server doesn't render anything, it just sends over all drawing ops to the client who does the actual rendering for the user. qemu can kick spice-server and ask it to render stuff locally if needed. Happe

[Qemu-devel] [Bug 1191606] [NEW] qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-16 Thread Klaus Hochlehnert
Public bug reported: I just tested qemu (with kvm) with an iscsi disk using libiscsi. I tried to install Ubuntu 12.04 as guest and when it comes to the disk configuration during the installation qemu crashes without any notice. No log, no dump. In the log of the iscsi-target I found this: iscsi-

[Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-16 Thread Klaus Hochlehnert
** Description changed: - Hi, - I just tested qemu (with kvm) with an iscsi disk using libiscsi. I tried to install Ubuntu 12.04 as guest and when it comes to the disk configuration during the installation qemu crashes without any notice. No log, no dump. In the log of the iscsi-t

Re: [Qemu-devel] [PATCH 1/2] piix: use type-safe cast instead of directly access of parent dev

2013-06-16 Thread Hu Tao
Andreas, On Mon, Jun 17, 2013 at 09:56:47AM +0800, Hu Tao wrote: > On Fri, Jun 14, 2013 at 11:20:55AM +0200, Andreas Färber wrote: > > Hi, > > > > Am 14.06.2013 08:49, schrieb Hu Tao: > > > Signed-off-by: Hu Tao > > > --- > > > hw/pci-host/piix.c | 11 +++ > > > 1 file changed, 7 insert

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-16 Thread Fam Zheng
> +static void coroutine_fn backup_run(void *opaque) > +{ > +BackupBlockJob *job = opaque; > +BlockDriverState *bs = job->common.bs; > +BlockDriverState *target = job->target; > +BlockdevOnError on_target_error = job->on_target_error; > +NotifierWithReturn before_write = { > +

Re: [Qemu-devel] [PATCH V2 09/12] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-16 Thread Wenchao Xia
于 2013-6-15 17:55, Eric Blake 写道: On 06/14/2013 12:39 PM, Wenchao Xia wrote: Snapshot ID can't be specified in this interface. Why not? If it is possible to look up by id in isolation, then it should be possible to delete by id in isolation. Also, if it is possible to create a snapshot that

Re: [Qemu-devel] [PATCH V2 08/12] qmp: add interface blockdev-snapshot-internal-sync

2013-06-16 Thread Wenchao Xia
于 2013-6-15 17:51, Eric Blake 写道: On 06/14/2013 12:39 PM, Wenchao Xia wrote: This interface can generate snapshot name automatically if it is not specified, since it is a single opertion. s/opertion/operation/ Snapshot ID can't be specified in this interface. Signed-off-by: Wenchao Xia --

Re: [Qemu-devel] [PATCH V2 07/12] qmp: add internal snapshot support in qmp_transaction

2013-06-16 Thread Wenchao Xia
Will fix the grammar, thanks for checking. On 06/14/2013 12:39 PM, Wenchao Xia wrote: Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. The snapshot name should not mess up with snapsh

Re: [Qemu-devel] [PATCH] fix typo: apci -> acpi

2013-06-16 Thread Hu Tao
Michael, On Thu, Jun 13, 2013 at 01:05:10PM +0200, Andreas Färber wrote: > Am 13.06.2013 12:51, schrieb Hu Tao: > > Signed-off-by: Hu Tao > > --- > > hw/acpi/ich9.c | 4 ++-- > > hw/acpi/piix4.c | 6 +++--- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > Reviewed-by: Andreas Färber

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] piix: fix some printf errors when debug is enabled

2013-06-16 Thread Hu Tao
On Fri, Jun 14, 2013 at 02:27:38PM +0400, Michael Tokarev wrote: > 14.06.2013 11:11, Hu Tao wrote: > > And use PRIxxx macros if possible. > > Thanks, applied to the trivial patches queue, on top of the patch > by Hervé Poussineau which I mentioned before. > > /mjt Thanks!

Re: [Qemu-devel] [PATCH 1/2] piix: use type-safe cast instead of directly access of parent dev

2013-06-16 Thread Hu Tao
On Fri, Jun 14, 2013 at 11:20:55AM +0200, Andreas Färber wrote: > Hi, > > Am 14.06.2013 08:49, schrieb Hu Tao: > > Signed-off-by: Hu Tao > > --- > > hw/pci-host/piix.c | 11 +++ > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/hw/pci-host/piix.c b/hw/pci-host/pii

Re: [Qemu-devel] [PATCH] fix no-sdl builds

2013-06-16 Thread Mike Frysinger
On Sunday 16 June 2013 20:52:18 Andreas Färber wrote: > Am 17.06.2013 00:48, schrieb Mike Frysinger: > > The no_frame var is only defined when SDL support is enabled. > > > > Signed-off-by: Mike Frysinger > > There was already a different patch to the same effect on the list: > http://patchwork.

Re: [Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read)

2013-06-16 Thread Andreas Färber
Am 17.06.2013 02:43, schrieb Vladimir Senkov: > From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 > From: Vladimir Senkov mailto:han...@gmail.com>> > Date: Sun, 16 Jun 2013 20:30:52 -0400 > Subject: [PATCH] fixed a copy&paste error in serial.c > > Signed-off-by: Vladimir Senko

Re: [Qemu-devel] [PATCH] fix no-sdl builds

2013-06-16 Thread Andreas Färber
Hi, Am 17.06.2013 00:48, schrieb Mike Frysinger: > The no_frame var is only defined when SDL support is enabled. > > Signed-off-by: Mike Frysinger There was already a different patch to the same effect on the list: http://patchwork.ozlabs.org/patch/251621/ Any update on your Blackfin emulation

[Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read)

2013-06-16 Thread Vladimir Senkov
>From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 From: Vladimir Senkov Date: Sun, 16 Jun 2013 20:30:52 -0400 Subject: [PATCH] fixed a copy&paste error in serial.c Signed-off-by: Vladimir Senkov --- hw/char/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Qemu-devel] [PATCH] fix no-sdl builds

2013-06-16 Thread Mike Frysinger
The no_frame var is only defined when SDL support is enabled. Signed-off-by: Mike Frysinger --- vl.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 9f8fd6e..aaa14bb 100644 --- a/vl.c +++ b/vl.c @@ -3524,9 +3524,6 @@ int main(int argc, char **argv,

[Qemu-devel] [Bug 752476] Re: monitor command mouse_button 1 moves mouse

2013-06-16 Thread Andreas Färber
Here's my attempt of fixing it: http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg02506.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/752476 Title: monitor command mouse_button 1 move

[Qemu-devel] [PATCH 2/2] pvpanic: fix fwcfg for big endian hosts

2013-06-16 Thread Michael S. Tsirkin
Convert port number to little endian when exposing it in fw cfg. Signed-off-by: Michael S. Tsirkin --- hw/misc/pvpanic.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 9ed9897..151eefe 100644 --- a/hw/misc/pvpanic.c +++ b/hw

[Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-16 Thread Michael S. Tsirkin
Avoid use of static variables: PC systems initialize pvpanic device through pvpanic_init, so we can simply create the fw_cfg file at that point. Others don't use fw_cfg at all. This also makes it possible to assert if fw_cfg is not there rather than skipping the device silently. Signed-off-by: M

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-16 Thread Blue Swirl
On Sun, Jun 16, 2013 at 3:57 PM, Andreas Färber wrote: > Move it to qom/cpu.h. While renaming, perhaps a more descriptive name could be used instead of 'cpu_single_cpu', something like cpu_loop_current_cpu? > > Signed-off-by: Andreas Färber > --- > cpu-exec.c | 13 +++-- >

[Qemu-devel] [PATCH] pvpanic: initialization cleanup

2013-06-16 Thread Michael S. Tsirkin
Avoid use of static variables: PC systems initialize pvpanic device through pvpanic_init, so we can simply create the fw_cfg file at that point. This also makes it possible to assert if fw_cfg is not there rather than skipping the device silently. Signed-off-by: Michael S. Tsirkin --- hw/misc/pv

Re: [Qemu-devel] [PATCH qom-cpu v2 24/29] cpu: Drop qemu_for_each_cpu()

2013-06-16 Thread Andreas Färber
Am 16.06.2013 22:26, schrieb Michael S. Tsirkin: > On Sun, Jun 16, 2013 at 05:57:44PM +0200, Andreas Färber wrote: >> Revert commit d6b9e0d60cc511eca210834428bb74508cff3d33 (cpu: Add >> qemu_for_each_cpu()) and its usage in favor of open-coding CPU loops, >> now that they are based on CPUState. >>

Re: [Qemu-devel] [PATCH qom-cpu v2 24/29] cpu: Drop qemu_for_each_cpu()

2013-06-16 Thread Michael S. Tsirkin
On Sun, Jun 16, 2013 at 09:30:29PM +0100, Peter Maydell wrote: > On 16 June 2013 21:26, Michael S. Tsirkin wrote: > > On Sun, Jun 16, 2013 at 05:57:44PM +0200, Andreas Färber wrote: > >> Revert commit d6b9e0d60cc511eca210834428bb74508cff3d33 (cpu: Add > >> qemu_for_each_cpu()) and its usage in fav

Re: [Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa()

2013-06-16 Thread Michael S. Tsirkin
On Sun, Jun 16, 2013 at 06:41:24PM +0200, Andreas Färber wrote: > Am 11.06.2013 09:41, schrieb Markus Armbruster: > > Andreas Färber writes: > >> If having patch 57/59 larger is not a concern (which getting rid of > >> open-coded CPU loops tried to address), then I can just convert the > >> loops

Re: [Qemu-devel] [PATCH qom-cpu v2 24/29] cpu: Drop qemu_for_each_cpu()

2013-06-16 Thread Peter Maydell
On 16 June 2013 21:26, Michael S. Tsirkin wrote: > On Sun, Jun 16, 2013 at 05:57:44PM +0200, Andreas Färber wrote: >> Revert commit d6b9e0d60cc511eca210834428bb74508cff3d33 (cpu: Add >> qemu_for_each_cpu()) and its usage in favor of open-coding CPU loops, >> now that they are based on CPUState. >>

Re: [Qemu-devel] [PATCH qom-cpu v2 24/29] cpu: Drop qemu_for_each_cpu()

2013-06-16 Thread Michael S. Tsirkin
On Sun, Jun 16, 2013 at 05:57:44PM +0200, Andreas Färber wrote: > Revert commit d6b9e0d60cc511eca210834428bb74508cff3d33 (cpu: Add > qemu_for_each_cpu()) and its usage in favor of open-coding CPU loops, > now that they are based on CPUState. > > Suggested-by: Markus Armbruster > Signed-off-by: An

Re: [Qemu-devel] [PATCH v4 04/12] ARM: Add AArch64 translation stub

2013-06-16 Thread Peter Maydell
On 16 June 2013 21:06, Andreas Färber wrote: > My qom-cpu-10 series may help here, it turns cpu_dump_state() into a > simple helper function calling CPUClass::dump_state(). So a Cortex-A5x > class_init or TARGET_AARCH64 for the base class_init would simply assign > the 64-bit version of the callba

Re: [Qemu-devel] [PATCH v4 04/12] ARM: Add AArch64 translation stub

2013-06-16 Thread Andreas Färber
Am 20.05.2013 14:57, schrieb Peter Maydell: > On 14 May 2013 05:32, John Rigby wrote: >> @@ -10038,6 +10042,11 @@ void cpu_dump_state(CPUARMState *env, FILE *f, >> fprintf_function cpu_fprintf, >> int i; >> uint32_t psr; >> >> +if (is_a64(env)) { >> +cpu_dump_state_a64(env,

Re: [Qemu-devel] [PATCH ppc-next fixup] intc/openpic_kvm: Fix QOM and build issues

2013-06-16 Thread Andreas Färber
Am 16.06.2013 20:32, schrieb Andreas Färber: > Signed-off-by: Andreas Färber > --- > default-configs/ppcemb-softmmu.mak | 1 + > hw/intc/openpic_kvm.c | 50 > +++--- > hw/ppc/e500.c | 2 +- > include/hw/ppc/openpic.h |

[Qemu-devel] [PATCH ppc-next fixup v2] intc/openpic_kvm: Fix QOM and build issues

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- v1 -> v2: * Renamed busdev to parent_obj; * Fixed one remaining occurrence of FROM_SYSBUS(). default-configs/ppcemb-softmmu.mak | 1 + hw/intc/openpic_kvm.c | 54 +++--- hw/ppc/e500.c | 2 +-

Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-16 Thread Andreas Färber
Subject is misleading: it's intc/openpic_kvm, not kvm/openpic. Alex, please fix when squashing. Am 12.06.2013 22:32, schrieb Scott Wood: > Enables support for the in-kernel MPIC that thas been merged into the > KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex > Graf (along with

Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-16 Thread Andreas Färber
Am 15.06.2013 00:57, schrieb Scott Wood: > On 06/14/2013 09:59:18 AM, Andreas Färber wrote: >> Am 13.06.2013 19:32, schrieb Scott Wood: >> > On 06/13/2013 06:01:49 AM, Andreas Färber wrote: >> >> Am 12.06.2013 22:32, schrieb Scott Wood: >> >> > +typedef struct KVMOpenPICState { >> >> > +SysBusD

Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics

2013-06-16 Thread Chegu Vinod
On 6/14/2013 1:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" For very large virtual machines, pinning can take a long time. While this does not affect the migration's *actual* time itself, it is still important for the user to know what's going on and to know what component

[Qemu-devel] [PATCH ppc-next fixup] intc/openpic_kvm: Fix QOM and build issues

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- default-configs/ppcemb-softmmu.mak | 1 + hw/intc/openpic_kvm.c | 50 +++--- hw/ppc/e500.c | 2 +- include/hw/ppc/openpic.h | 1 + 4 files changed, 34 insertions(+), 20 deletions(-) d

Re: [Qemu-devel] [PATCH v2 0/8] memory: remove old_portio usage

2013-06-16 Thread Hervé Poussineau
Hervé Poussineau a écrit : These proposed patches aim at removing the .old_portio member of MemoryRegionOps structure, and replacing their usage by .read/.write handlers. Ping. That way, faked I/O address space can be removed from architectures which don't have it (MIPS, PowerPC...), and comm

Re: [Qemu-devel] [PATCH 0/3] ppc: QOM'ify mpc8544_guts device

2013-06-16 Thread Andreas Färber
Am 09.06.2013 22:47, schrieb Andreas Färber: > Hi Alex, > > Here's a mini-series cleaning up the mpc8544_guts device. > One user of SysBusDeviceClass::init less to worry about. ;) Ping! > Regards, > Andreas > > Cc: Alexander Graf > Cc: qemu-...@nongnu.org > > Andreas Färber (3): > mpc8544_g

Re: [Qemu-devel] [PATCH trivial] vl: always define no_frame

2013-06-16 Thread Andreas Färber
Am 15.06.2013 12:42, schrieb Michael Tokarev: > Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke > build of qemu without sdl, by referencing `no_frame' variable which is defined > inside #if SDL block. Fix that by defining that variable unconditionally. > > This is a be

[Qemu-devel] [PATCH qom-cpu v2 25/29] cpu: Move CPU_INTERRUPT_* to qom/cpu.h

2013-06-16 Thread Andreas Färber
Turn them into an enum. Un-poison them but make CPU_INTERRUPT_TGT_* only available to CONFIG_SOFTMMU and CONFIG_USER_ONLY, i.e., not to devices. Signed-off-by: Andreas Färber --- include/exec/cpu-all.h | 50 --- include/exec/poison.h | 13 in

Re: [Qemu-devel] [PATCH 1/7] migration: export MIG_STATE_xxx flags

2013-06-16 Thread Anthony Liguori
Lei Li writes: > Signed-off-by: Lei Li > --- > include/migration/migration.h |8 > migration.c |8 > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/migration/migration.h b/include/migration/migration.h > index e2acec6..8866c

Re: [Qemu-devel] [PATCH ppc-next] target-ppc: Drop redundant flags assignments from CPU families

2013-06-16 Thread Andreas Färber
Am 22.02.2013 18:35, schrieb Andreas Färber: > Previous code has #define POWERPC_INSNS2_ PPC_NONE in some > places for macrofied assignment to insns_flags2 field. > > PPC_NONE is defined as zero though and QOM classes are zero-initialized, > so drop any pcc->insns_flags2 = PPC_NONE; assignments. >

[Qemu-devel] [PATCH qom-cpu v2 18/29] cpu: Turn cpu_unassigned_access() into a CPUState hook

2013-06-16 Thread Andreas Färber
Use it for all targets, but be careful not to pass invalid CPUState. cpu_single_env can be NULL, e.g. on Xen. Signed-off-by: Andreas Färber --- cputlb.c | 15 +-- hw/alpha/typhoon.c| 14 ++ include/qom/cpu.h | 33 ++

Re: [Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa()

2013-06-16 Thread Andreas Färber
Am 11.06.2013 09:41, schrieb Markus Armbruster: > Andreas Färber writes: >> If having patch 57/59 larger is not a concern (which getting rid of >> open-coded CPU loops tried to address), then I can just convert the >> loops in place alongside first_cpu / next_cpu. >> Then still the question remain

[Qemu-devel] [PATCH qom-cpu v2 27/29] intc/arm_gic: Build arm_gic only once

2013-06-16 Thread Andreas Färber
Since cpu_single_cpu is CPUState it no longer needs CPUArchState. Signed-off-by: Andreas Färber --- hw/intc/Makefile.objs | 2 +- hw/intc/arm_gic.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/intc/Makefile.objs b/hw/intc/Makefile.objs index 9e92a0b..f75fb27 100644

Re: [Qemu-devel] [PATCH qom-cpu 25/59] cpu: Change qemu_init_vcpu() argument to CPUState

2013-06-16 Thread Andreas Färber
Am 16.06.2013 10:27, schrieb Andreas Färber: > 嗨, > > Am 11.06.2013 04:39, schrieb li guang: >> 在 2013-06-09日的 21:12 +0200,Andreas Färber写道: >>> This allows to move the call to CPUState's realizefn. >>> Therefore move the stub into libqemustub.a. >>> >>> Signed-off-by: Andreas Färber >> [...] >>

Re: [Qemu-devel] [PATCH 2/7] savevm: export qemu_save_device_state()

2013-06-16 Thread Anthony Liguori
Lei Li writes: > Signed-off-by: Lei Li > --- > include/sysemu/sysemu.h |1 + > savevm.c|2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 2fb71af..5b90027 100644 > --- a/include/sysemu/syse

[Qemu-devel] [PATCH qom-cpu v2 28/29] intc/openpic: Build openpic only once

2013-06-16 Thread Andreas Färber
Since cpu_single_cpu is CPUState it no longer depends on CPUPPCState. Move ppce500_set_mpic_proxy() to a new hw/ppc/ppc_e500.h because hw/ppc/ppc.h is too heavily using CPUPPCState and PowerPCCPU. Cc: Scott Wood Signed-off-by: Andreas Färber --- hw/intc/Makefile.objs | 2 +- hw/intc/openpi

Re: [Qemu-devel] [PATCH 0/7 RFC] Localhost live migration

2013-06-16 Thread Anthony Liguori
Lei Li writes: > Hi, > > This patch series tries to add localhost live migration support > to Qemu. It is just a draft version which is far from completing > and I am still working on, send it out to have your suggestions > and make sure it is the way should be headed. Your comments are > very ap

[Qemu-devel] [PATCH qom-cpu v2 26/29] intc/sh_intc: Build sh_intc only once

2013-06-16 Thread Andreas Färber
Since converting first_cpu to CPUState and making CPU_INTERRUPT_HARD available through qom/cpu.h, it no longer depends on CPUSH4State. This allows sharing across sh4 and sh4eb. Signed-off-by: Andreas Färber --- hw/intc/Makefile.objs | 2 +- hw/intc/sh_intc.c | 1 + include/hw/sh4/sh.h | 2

Re: [Qemu-devel] [PATCH 4/7] migration-local: implementation of outgoing part

2013-06-16 Thread Anthony Liguori
Lei Li writes: > Signed-off-by: Lei Li > --- > Makefile.objs |1 + > include/migration/migration.h | 15 + > migration-local.c | 116 > + > migration-unix.c | 13 + > qapi-schema.json

[Qemu-devel] [PATCH qom-cpu v2 24/29] cpu: Drop qemu_for_each_cpu()

2013-06-16 Thread Andreas Färber
Revert commit d6b9e0d60cc511eca210834428bb74508cff3d33 (cpu: Add qemu_for_each_cpu()) and its usage in favor of open-coding CPU loops, now that they are based on CPUState. Suggested-by: Markus Armbruster Signed-off-by: Andreas Färber --- cpus.c| 11 --- exec.c| 1

[Qemu-devel] [PATCH qom-cpu v2 29/29] timer/arm_mptimer: Build arm_mptimer only once

2013-06-16 Thread Andreas Färber
Since cpu_single_cpu is CPUState it no longer depends on CPUArchState. Signed-off-by: Andreas Färber --- hw/timer/Makefile.objs | 2 +- hw/timer/arm_mptimer.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/timer/Makefile.objs b/hw/timer/Makefile.objs index 32b5c1a..eca59

[Qemu-devel] [PATCH qom-cpu v2 20/29] kvm: Change kvm_remove_all_breakpoints() argument to CPUState

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c| 2 +- include/sysemu/kvm.h | 2 +- kvm-all.c| 5 ++--- kvm-stub.c | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3101a43..9e7f7a1 100644 --- a/gdbstub.c +++ b/gdbstub

Re: [Qemu-devel] [PATCH 3/7] arch_init: add ram_madvise_free()

2013-06-16 Thread Anthony Liguori
Lei Li writes: > Signed-off-by: Lei Li > --- > arch_init.c | 13 + > include/migration/migration.h |3 +++ > 2 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 872020e..fc66bd2 100644 > --- a/arch_init.c > +++

[Qemu-devel] [PATCH qom-cpu v2 22/29] linux-user: Change thread_env to CPUState

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- linux-user/elfload.c | 16 +--- linux-user/linuxload.c | 3 ++- linux-user/main.c | 10 +- linux-user/qemu.h | 2 +- linux-user/signal.c| 12 +++- linux-user/syscall.c | 6 +++--- 6 files changed, 27 insertions(+),

[Qemu-devel] [PATCH qom-cpu v2 12/29] gdbstub: Set gdb_set_stop_cpu() argument to CPUState

2013-06-16 Thread Andreas Färber
Use CPUState::env_ptr for now. Signed-off-by: Andreas Färber --- cpus.c | 2 +- gdbstub.c | 4 +++- include/exec/gdbstub.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index 47ab818..44ec34f 100644 --- a/cpus.c +++ b/cpus.c @

[Qemu-devel] [PATCH qom-cpu v2 23/29] bsd-user: Change thread_env to CPUState

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- bsd-user/elfload.c | 6 -- bsd-user/main.c| 6 +++--- bsd-user/qemu.h| 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 5e20510..93fd9e4 100644 --- a/bsd-user/elfload.c +++ b/bsd-user/e

[Qemu-devel] [PATCH qom-cpu v2 09/29] cpu: Turn cpu_dump_{state, statistics}() into CPUState hooks

2013-06-16 Thread Andreas Färber
Make cpustats monitor command available unconditionally. Signed-off-by: Andreas Färber --- bsd-user/main.c | 3 ++- cpus.c| 2 +- exec.c| 3 ++- include/exec/cpu-all.h| 10 -- include/qemu/log.h| 2 +-

[Qemu-devel] [PATCH qom-cpu v2 16/29] cpu: Change qemu_init_vcpu() argument to CPUState

2013-06-16 Thread Andreas Färber
This allows to move the call to CPUState's realizefn. Therefore move the stub into libqemustub.a. Signed-off-by: Andreas Färber --- cpus.c | 5 + include/qemu-common.h | 8 include/qom/cpu.h | 8 qom/cpu.c | 2 ++ stubs

[Qemu-devel] [PATCH qom-cpu v2 13/29] cpus: Change cpu_handle_guest_debug() argument to CPUState

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpus.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 44ec34f..1694455 100644 --- a/cpus.c +++ b/cpus.c @@ -459,10 +459,8 @@ static bool cpu_can_run(CPUState *cpu) return true; } -static void cpu_handle_g

[Qemu-devel] [PATCH qom-cpu v2 17/29] hwaddr: Make hwaddr type usable beyond softmmu

2013-06-16 Thread Andreas Färber
While not normally needed for *-user, it can safely be used there since always based on uint64_t, to avoid ifdeffery. To avoid accidental uses, move the guards from exec/hwaddr.h to its inclusion sites. No need for them in include/hw/. Prepares for hwaddr use in qom/cpu.h. Signed-off-by: Andrea

[Qemu-devel] [PATCH qom-cpu v2 15/29] cpus: Change qemu_dummy_start_vcpu() argument to CPUState

2013-06-16 Thread Andreas Färber
Pass it to qemu_dummy_cpu_thread_fn(). Use CPUState::env_ptr for cpu_single_env. Signed-off-by: Andreas Färber --- cpus.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index bad42a2..a9a7074 100644 --- a/cpus.c +++ b/cpus.c @@ -766,8 +766,7 @

[Qemu-devel] [PATCH qom-cpu v2 11/29] kvm: Change kvm_cpu_exec() argument to CPUState

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpus.c | 2 +- include/sysemu/kvm.h | 2 +- kvm-all.c| 3 +-- kvm-stub.c | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/cpus.c b/cpus.c index bbaf13c..47ab818 100644 --- a/cpus.c +++ b/cpus.c @@ -752,7

[Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-16 Thread Andreas Färber
Move it to qom/cpu.h. Signed-off-by: Andreas Färber --- cpu-exec.c | 13 +++-- cpus.c | 29 ++--- exec.c | 12 +++- hw/alpha/typhoon.c | 16 hw/arm/pxa2xx.c | 3 +-- hw/i386/kvmv

[Qemu-devel] [PATCH qom-cpu v2 08/29] cpus: Change qemu_kvm_init_cpu_signals() argument to CPUState

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpus.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index fca5e1f..a5b0e46 100644 --- a/cpus.c +++ b/cpus.c @@ -568,9 +568,8 @@ static void dummy_signal(int sig) { } -static void qemu_kvm_init_cpu_signals(CPUArchS

[Qemu-devel] [PATCH qom-cpu v2 10/29] kvm: Change kvm_handle_internal_error() argument to CPUState

2013-06-16 Thread Andreas Färber
Signed-off-by: Andreas Färber --- kvm-all.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 1cd4573..1675311 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1520,10 +1520,8 @@ static void kvm_handle_io(uint16_t port, void *data, int direction, int

[Qemu-devel] [PATCH qom-cpu v2 14/29] cpus: Change qemu_kvm_start_vcpu() argument to CPUState

2013-06-16 Thread Andreas Färber
Pass it on to qemu_kvm_cpu_thread_fn(). Signed-off-by: Andreas Färber --- cpus.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/cpus.c b/cpus.c index 1694455..bad42a2 100644 --- a/cpus.c +++ b/cpus.c @@ -727,14 +727,13 @@ static void qemu_kvm_wait_io_event(CPUS

[Qemu-devel] [PATCH qom-cpu v2 04/29] cpu: Change cpu_exit() argument to CPUState

2013-06-16 Thread Andreas Färber
It no longer depends on CPUArchState, so move it to qom/cpu.c. Signed-off-by: Andreas Färber --- cpus.c | 4 ++-- exec.c | 8 gdbstub.c | 2 +- hw/i386/pc.c| 2 +- hw/mips/mips_fulong2e.c | 2 +- hw/mips/mips_jazz.c | 2 +-

[Qemu-devel] [PATCH qom-cpu v2 07/29] kvm: Change kvm_set_signal_mask() argument to CPUState

2013-06-16 Thread Andreas Färber
CPUArchState is no longer needed. Signed-off-by: Andreas Färber --- cpus.c | 3 ++- include/sysemu/kvm.h | 2 +- kvm-all.c| 3 +-- kvm-stub.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index fe19962..fca5e1f 100644 -

[Qemu-devel] [PATCH qom-cpu v2 02/29] kvm: Change cpu_synchronize_state() argument to CPUState

2013-06-16 Thread Andreas Färber
Change Monitor::mon_cpu to CPUState as well. In cpu_synchronize_all_states() use qemu_for_each_cpu() now. Reviewed-by: liguang Signed-off-by: Andreas Färber --- cpus.c | 8 gdbstub.c | 8 hw/i386/kvm/apic.c | 2 +- hw/i386/kvmvapic.c |

[Qemu-devel] [PATCH qom-cpu v2 06/29] cpus: Change qemu_kvm_wait_io_event() argument to CPUState

2013-06-16 Thread Andreas Färber
It no longer uses CPUArchState. Signed-off-by: Andreas Färber --- cpus.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 17cc85b..fe19962 100644 --- a/cpus.c +++ b/cpus.c @@ -717,10 +717,8 @@ static void qemu_tcg_wait_io_event(void) } } -st

[Qemu-devel] [PATCH qom-cpu v2 05/29] cpus: Change cpu_thread_is_idle() argument to CPUState

2013-06-16 Thread Andreas Färber
It no longer needs CPUArchState. Signed-off-by: Andreas Färber --- cpus.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index ab0eb4f..17cc85b 100644 --- a/cpus.c +++ b/cpus.c @@ -62,10 +62,8 @@ static CPUArchState *next_cpu; -static bool cpu_th

[Qemu-devel] [PATCH qom-cpu v2 03/29] gdbstub: Simplify find_cpu()

2013-06-16 Thread Andreas Färber
Use qemu_get_cpu() and CPUState::env_ptr. Signed-off-by: Andreas Färber --- gdbstub.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index bbae06d..663549c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2071,17 +2071,13 @@ static void gdb_set_c

[Qemu-devel] [PATCH qom-cpu v2 00/29] QOM CPUState, part 10: CPU loops

2013-06-16 Thread Andreas Färber
Hello, This series changes cpu_single_env, first_cpu, next_cpu and thread_env to CPUState. qemu_init_vcpu() is converted to CPUState and moved away from targets. cpu_unassigned_access(), cpu_dump_state() and cpu_dump_statistics() are turned into CPUClass methods. exec/hwaddr.h is modified to al

[Qemu-devel] [PATCH qom-cpu v2 01/29] kvm: Change kvm_cpu_synchronize_state() argument to CPUState

2013-06-16 Thread Andreas Färber
It no longer relies on CPUArchState since 20d695a. Reviewed-by: liguang Signed-off-by: Andreas Färber --- hw/ppc/spapr_rtas.c | 2 +- include/sysemu/kvm.h | 4 ++-- kvm-all.c| 4 +--- kvm-stub.c | 2 +- target-i386/kvm.c| 10 +- 5 files changed, 10 inserti

[Qemu-devel] [PATCH 6/7] migration-local: add option to command line for -incoming-local

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li --- qemu-options.hx |9 + vl.c| 14 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index bf94862..bb1a88a 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2913,6 +2913,15 @@ STE

[Qemu-devel] [PATCH 7/7] hmp: add hmp_localhost_migration interface

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 17 + hmp.c | 13 + hmp.h |1 + 3 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..ed21970 100644 --- a/hmp-commands.hx +++ b/hmp-comma

[Qemu-devel] [PATCH 5/7] migration-local: implementation of incoming part

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li --- include/migration/migration.h |6 + migration-local.c | 39 ++ migration-unix.c | 47 + 3 files changed, 92 insertions(+), 0 deletions(-) diff --git a/include/mi

[Qemu-devel] [PATCH 4/7] migration-local: implementation of outgoing part

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li --- Makefile.objs |1 + include/migration/migration.h | 15 + migration-local.c | 116 + migration-unix.c | 13 + qapi-schema.json | 14 + qmp-commands.hx

[Qemu-devel] [PATCH 3/7] arch_init: add ram_madvise_free()

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li --- arch_init.c | 13 + include/migration/migration.h |3 +++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 872020e..fc66bd2 100644 --- a/arch_init.c +++ b/arch_init.c @@ -524,6 +524,19 @@

[Qemu-devel] [PATCH 0/7 RFC] Localhost live migration

2013-06-16 Thread Lei Li
Hi, This patch series tries to add localhost live migration support to Qemu. It is just a draft version which is far from completing and I am still working on, send it out to have your suggestions and make sure it is the way should be headed. Your comments are very appreciated! When doing localho

[Qemu-devel] [PATCH 1/7] migration: export MIG_STATE_xxx flags

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li --- include/migration/migration.h |8 migration.c |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index e2acec6..8866c3c 100644 --- a/include/migratio

[Qemu-devel] [PATCH 2/7] savevm: export qemu_save_device_state()

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li --- include/sysemu/sysemu.h |1 + savevm.c|2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 2fb71af..5b90027 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-16 Thread Kevin O'Connor
On Sun, Jun 16, 2013 at 02:07:39PM +0400, Michael Tokarev wrote: > 14.06.2013 03:47, Kevin O'Connor wrote: > > On Fri, Jun 14, 2013 at 12:32:22AM +0400, Michael Tokarev wrote: > >> 13.06.2013 11:51, Michael Tokarev wrote: > >>> In order to verify some build issues on solaris, I tried to install > >

[Qemu-devel] [PATCH] qemu-img: Add missing GCC_FMT_ATTR

2013-06-16 Thread Stefan Weil
Signed-off-by: Stefan Weil --- qemu-img.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index a2967ea..9c9254a 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -128,7 +128,7 @@ static void QEMU_NORETURN help(void) exit(1); } -static int qprintf(

[Qemu-devel] [PATCH] gtk: Fix compiler warning (GTK 3 deprecated function)

2013-06-16 Thread Stefan Weil
With GTK 3, the function gdk_cursor_unref is deprecated: qemu/ui/gtk.c: In function ‘gd_cursor_define’: qemu/ui/gtk.c:380:5: error: ‘gdk_cursor_unref’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkcursor.h:233): Use 'g_object_unref' instead [-Werror=deprecated-declarations] Fix the gc

[Qemu-devel] [PATCH] kvm: Fix potential resource leak (missing fclose)

2013-06-16 Thread Stefan Weil
This leak was detected by cppcheck. Signed-off-by: Stefan Weil --- hw/i386/kvm/pci-assign.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index ff85590..1fb7ad4 100644 --- a/hw/i386/kvm/pci-assign.c +++ b/hw/i386/kvm/pci-assign.c @@ -5

[Qemu-devel] [PATCH] savevm: Fix potential memory leak

2013-06-16 Thread Stefan Weil
The leak was reported by cppcheck. Fix it by moving the g_malloc0 after the argument validity check. Signed-off-by: Stefan Weil --- savevm.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index 2ce439f..b883714 100644 --- a/savevm.c +++ b/savevm.c @@

[Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

2013-06-16 Thread Liu Ping Fan
BH will be used outside big lock, so introduce lock to protect between the writers, ie, bh's adders and deleter. Note that the lock only affects the writers and bh's callback does not take this extra lock. Signed-off-by: Liu Ping Fan --- async.c | 21 + include/bl

[Qemu-devel] [PATCH v2 1/2] add a header file for atomic operations

2013-06-16 Thread Liu Ping Fan
From: Paolo Bonzini We're already using them in several places, but __sync builtins are just too ugly to type, and do not provide seqcst load/store operations. Signed-off-by: Paolo Bonzini --- docs/atomics.txt | 322 +++ hw/display/qxl.c

[Qemu-devel] [PATCH v2 0/2] make AioContext's bh re-entrant

2013-06-16 Thread Liu Ping Fan
When trying out of QBL, we badly require more fine defined barrier and atomic ops, so I repost Paolo's atomic patch which fetched github.com/bonzini/qemu.git rcu (thanks Paolo, with your urcu patches, things go more easily) v1->v2: more fine document introduce another wmb for qemu_bh_schedul

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-06-16 Thread David Gibson
On Fri, Jun 14, 2013 at 04:28:32PM +0200, Andreas Färber wrote: > Am 13.06.2013 15:49, schrieb Alexander Graf: > > On 17.05.2013, at 09:42, Andreas Färber wrote: > >> Am 17.05.2013 06:25, schrieb David Gibson: > >>> Currently, for qemu-system-ppc64, the default machine type is 'mac99'. > >>> Since

[Qemu-devel] [PATCH] hw/9pfs: Fix potential memory leak and avoid reuse of freed memory

2013-06-16 Thread Stefan Weil
The leak was reported by cppcheck. Function proxy_init also calls g_free for ctx->fs_root. Avoid reuse of this memory by setting ctx->fs_root to NULL. Signed-off-by: Stefan Weil --- Hi, I'm not sure whether ctx->fs_root should also be freed in the error case. Please feel free to modify my patc

Re: [Qemu-devel] [PATCH] sun4m: add display width and height to the firmware configuration

2013-06-16 Thread Mark Cave-Ayland
On 15/06/13 15:54, Andreas Färber wrote: Looks fine, Reviewed-by: Andreas Färber Does this require corresponding OpenBIOS patches or was that already prepared? (only see your cleanups and bug fixes there) Yes, I rolled up some code for this in the corresponding OpenBIOS patchset but forgot

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-16 Thread Michael Tokarev
14.06.2013 03:47, Kevin O'Connor wrote: > On Fri, Jun 14, 2013 at 12:32:22AM +0400, Michael Tokarev wrote: >> 13.06.2013 11:51, Michael Tokarev wrote: >>> Hello. >>> >>> In order to verify some build issues on solaris, I tried to install >>> sol10 x86 in a kvm vm. But unfortunately it does not wor

Re: [Qemu-devel] [PATCH] QEMUBH: make AioContext's bh re-entrant

2013-06-16 Thread liu ping fan
On Sat, Jun 15, 2013 at 7:16 PM, Paolo Bonzini wrote: > Il 15/06/2013 04:43, liu ping fan ha scritto: >> On Sat, Jun 15, 2013 at 1:35 PM, Paolo Bonzini wrote: >>> Il 13/06/2013 22:55, Liu Ping Fan ha scritto: BH will be used outside big lock, so introduce lock to protect it. Note that t

  1   2   >