Re: [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8

2013-07-09 Thread Alexey Kardashevskiy
On 07/09/2013 04:01 AM, Anthony Liguori wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: This series spent quite a lot of time waiting when David's PCI series reaches the upstream but it does not seem to happen soon so I rebased those on top of agraf/ppc-next rebased on top

[Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-09 Thread Qiao Nuohan
Hi, all The last version is here: http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg03866.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64. The message is here:

[Qemu-devel] [PATCH v5 6/9] dump: Add API to write dump_bitmap

2013-07-09 Thread Qiao Nuohan
functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format, which is used to indicate whether the corresponded page is existed in vmcore. Dump level 1 is chosen, so 1st and 2nd dump_bitmap are same. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe

[Qemu-devel] [PATCH v5 1/9] dump: Add argument to write_elfxx_notes

2013-07-09 Thread Qiao Nuohan
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to vmcore. Adding argument WriteCoreDumpFunction f makes it available to choose the way of writing elf notes when calling these two functions. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe

[Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages

2013-07-09 Thread Qiao Nuohan
functions are used to write page desc and page data to vmcore. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- configure | 50 + dump.c| 264 +

[Qemu-devel] [PATCH v5 3/9] dump: Add API to write vmcore

2013-07-09 Thread Qiao Nuohan
Function is used to write vmcore. If flag_flatten is specified, flatten format will be used. In flatten format, data is written block by block in vmcore. struct MakedumpfileDataHeader is used to indicate the offset and size of a data block. struct MakedumpfileDataHeader { int64_t offset;

[Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of flatten format

2013-07-09 Thread Qiao Nuohan
flatten format may be used when writing kdump-compressed format. To get more detailed information about flatten format of kdump-compressed format, please refer to the following URL: http://sourceforge.net/projects/makedumpfile/ The two functions here are used to write start flat header and end

[Qemu-devel] [PATCH v5 7/9] dump: Add APIs to operate DataCache

2013-07-09 Thread Qiao Nuohan
DataCache is used to store data temporarily, then the data will be written to vmcore. These functions will be called later when writing data of page to vmcore. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 52

[Qemu-devel] [PATCH v5 9/9] dump: Make kdump-compressed format available for 'dump-guest-memory'

2013-07-09 Thread Qiao Nuohan
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compression 2. 'kdump-zlib': kdump-compressed

[Qemu-devel] [PATCH v5 4/9] dump: Add API to write elf notes to buffer

2013-07-09 Thread Qiao Nuohan
the function can be used by write_elf32_notes/write_elf64_notes. If fd_write_vmcore is called by write_elf32_notes/write_elf64_notes, elf notes will be written to vmcore by fd_write_vmcore directly. Instead, buf_write_note will write elf notes to opaque-note_buf. And the elf notes stored in

Re: [Qemu-devel] [SeaBIOS] seabios 1.7.3 breaks booting windows 7?

2013-07-09 Thread Michael Tokarev
09.07.2013 03:18, Kevin O'Connor wrote: On Mon, Jul 08, 2013 at 05:23:40PM -0400, Cole Robinson wrote: On 07/07/2013 11:41 PM, Kevin O'Connor wrote: The 1.7.3 version of SeaBIOS has now been released. For more information on the release, please see: Just gave it a spin, breaks booting a

[Qemu-devel] [PATCH v5 5/9] dump: add API to write dump header

2013-07-09 Thread Qiao Nuohan
the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only elf notes here Signed-off-by: Qiao Nuohan

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-09 Thread Qiao Nuohan
On 07/09/2013 03:30 PM, Qiao Nuohan wrote: The last version is here: http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg03866.html Hi all, Still waiting for introspection... And comments about format will be very helpful. Thanks! -- Qiao Nuohan

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Michael Tokarev
Ping? 03.07.2013 20:29, Michael Tokarev wrote: From: Paolo Bonzini pbonz...@redhat.com With mon:stdio you can exit the VM by switching to the monitor and sending the quit command. It is then useful to pass Ctrl-C to the VM instead of exiting. This in turn lets us stop tying the default

Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

2013-07-09 Thread Laszlo Ersek
On 07/08/13 21:00, Luiz Capitulino wrote: On Mon, 8 Jul 2013 18:47:24 + Seiji Aguchi seiji.agu...@hds.com wrote: +DEF(msg, HAS_ARG, QEMU_OPTION_msg, +-msg timestamp[=on|off]\n +change the format of messages\n +on|off controls leading

Re: [Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest

2013-07-09 Thread Laszlo Ersek
On 07/08/13 20:30, Michael S. Tsirkin wrote: This patchset moves all generation of ACPI tables from guest BIOS to the hypervisor. Doesn't seem to apply on ab8bf290, can you pls rebase and repost? Thanks Laszlo

Re: [Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest

2013-07-09 Thread Michael S. Tsirkin
On Tue, Jul 09, 2013 at 09:53:50AM +0200, Laszlo Ersek wrote: On 07/08/13 20:30, Michael S. Tsirkin wrote: This patchset moves all generation of ACPI tables from guest BIOS to the hypervisor. Doesn't seem to apply on ab8bf290, This is on top of pci tree for_anthony tag, hopefully that

Re: [Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest

2013-07-09 Thread Laszlo Ersek
On 07/09/13 09:57, Michael S. Tsirkin wrote: On Tue, Jul 09, 2013 at 09:53:50AM +0200, Laszlo Ersek wrote: On 07/08/13 20:30, Michael S. Tsirkin wrote: This patchset moves all generation of ACPI tables from guest BIOS to the hypervisor. Doesn't seem to apply on ab8bf290, This is on top of

[Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Kevin Wolf
This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- To be applied on top of '[PATCH v3 0/3] qapi: Top-level type reference for command definitions' qapi-schema.json | 32 ++-- 1 file

Re: [Qemu-devel] [PATCH v3 0/3] qapi: Top-level type reference for command definitions

2013-07-09 Thread Kevin Wolf
Am 08.07.2013 um 19:37 hat Luiz Capitulino geschrieben: On Mon, 1 Jul 2013 16:31:49 +0200 Kevin Wolf kw...@redhat.com wrote: v2: - Updated documentation in patch 3 v3: - Refactored differently (introduced get_expr()) as suggested by Michael Kevin Wolf (3): qapi.py: Avoid

Re: [Qemu-devel] [PATCH 3/8] virtio: Add support for guest setting of queue size

2013-07-09 Thread Peter Maydell
On 8 July 2013 20:39, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: +void virtio_queue_set_num(VirtIODevice *vdev, int n, int num) +{ +vdev-vq[n].vring.num = num; +virtqueue_init(vdev-vq[n]); I think some level of checking is probably

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Andreas Färber
Am 09.07.2013 09:39, schrieb Michael Tokarev: Ping? Have you tested -semihosting? The xtensa test image on the Wiki uses -nographic, but semihosting content always seems to go to stdout without going through a chardev IIUC... Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg,

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Michael Tokarev
09.07.2013 12:42, Andreas Färber wrote: Am 09.07.2013 09:39, schrieb Michael Tokarev: Ping? Have you tested -semihosting? The xtensa test image on the Wiki uses -nographic, but semihosting content always seems to go to stdout without going through a chardev IIUC... Thanks for the info.

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-09 Thread Andreas Färber
Am 08.07.2013 23:06, schrieb Anthony Liguori: Alexander Graf ag...@suse.de writes: On 08.07.2013, at 22:08, Anthony Liguori wrote: I think we're trying to fit a square peg into a round hole. virtio-mmio is a virtio transport where each device has a dedicated set of system resources.

Re: [Qemu-devel] [PATCH 14/17] pseries: Support for in-kernel XICS interrupt controller

2013-07-09 Thread David Gibson
On Tue, Jul 09, 2013 at 01:21:27PM +1000, Alexey Kardashevskiy wrote: On 07/09/2013 04:50 AM, Anthony Liguori wrote: +#include hw/hw.h +#include trace.h +#include hw/ppc/spapr.h +#include hw/ppc/xics.h +#include kvm_ppc.h +#include qemu/config-file.h + +#include sys/ioctl.h +

Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables

2013-07-09 Thread David Gibson
On Mon, Jul 08, 2013 at 01:39:26PM -0500, Anthony Liguori wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: From: David Gibson da...@gibson.dropbear.id.au This patch adds the necessary VMStateDescription information to save the state of PAPR TCE tables (that is, the PAPR specified

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-09 Thread David Gibson
On Mon, Jul 08, 2013 at 01:31:59PM -0500, Anthony Liguori wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: From: David Gibson da...@gibson.dropbear.id.au [snip] void xics_common_cpu_setup(struct icp_state *icp, PowerPCCPU *cpu) { CPUState *cs = CPU(cpu); @@ -523,7 +578,11 @@

[Qemu-devel] [RFC PATCH 00/11] qapi changes in preparation for blockdev-add

2013-07-09 Thread Kevin Wolf
The goal of this series is to make QAPI ready to handle mostly unions in a less verbose way so that a future -blockdev command line option can be a direct mapping of the structure used by a blockdev-add QMP command. This series implements everything that I think is needed for this on the QAPI

[Qemu-devel] [RFC PATCH 01/11] qapi-types.py: Split off generate_struct_fields()

2013-07-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- scripts/qapi-types.py | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index ddcfed9..e1239e1 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py @@

[Qemu-devel] [RFC PATCH 02/11] qapi-types.py: Implement 'base' for unions

2013-07-09 Thread Kevin Wolf
The new 'base' key in a union definition refers to a struct type, which is inlined into the union definition and can represent fields common to all kinds. Signed-off-by: Kevin Wolf kw...@redhat.com --- scripts/qapi-types.py | 20 ++-- 1 file changed, 18 insertions(+), 2

[Qemu-devel] [RFC PATCH 09/11] Implement qdict_flatten()

2013-07-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- include/qapi/qmp/qdict.h | 1 + qobject/qdict.c | 47 +++ 2 files changed, 48 insertions(+) diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h index 685b2e3..b261570 100644 ---

[Qemu-devel] [RFC PATCH 05/11] qapi: Add visitor for implicit structs

2013-07-09 Thread Kevin Wolf
These can be used when an embedded struct is parsed and members not belonging to the struct may be present in the input (parsing flat namespect QMP union with discriminator) Signed-off-by: Kevin Wolf kw...@redhat.com --- include/qapi/visitor-impl.h | 4 include/qapi/visitor.h | 3 +++

[Qemu-devel] [RFC PATCH 08/11] qapi: Anonymous unions

2013-07-09 Thread Kevin Wolf
The discriminator for anonymous unions is the data type. This allows to have a union type that allows both of these: { 'file': 'my_existing_block_device_id' } { 'file': { 'filename': '/tmp/mydisk.qcow2', 'read-only': true } } Unions like this are specified in the schema with an empty

[Qemu-devel] [RFC PATCH 06/11] qapi: Flat unions with arbitrary discriminator

2013-07-09 Thread Kevin Wolf
Instead of the rather verbose syntax that distinguishes base and subclass fields... { type: file, read-only: true, data: { filename: test } } ...we can now have both in the same namespace, allowing a more direct mapping of the command line, and moving fields between the

[Qemu-devel] [RFC PATCH 10/11] block: Allow driver option on the top level

2013-07-09 Thread Kevin Wolf
This is traditionally -drive format=..., which is now translated into the new driver option. This gives us a more consistent way to select the driver of BlockDriverStates that can be used in QMP context, too. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c| 7 +++ blockdev.c | 20

[Qemu-devel] [RFC PATCH 07/11] qapi: Add consume argument to qmp_input_get_object()

2013-07-09 Thread Kevin Wolf
This allows to just look at the next element without actually consuming it. Signed-off-by: Kevin Wolf kw...@redhat.com --- qapi/qmp-input-visitor.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index

[Qemu-devel] [RFC PATCH 11/11] [WIP] block: Implement 'blockdev-add' QMP command

2013-07-09 Thread Kevin Wolf
This is just a quick hack to test things Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 32 qapi-schema.json | 29 + qmp-commands.hx | 6 ++ 3 files changed, 67 insertions(+) diff --git a/blockdev.c

[Qemu-devel] [RFC PATCH 03/11] qapi-visit.py: Split off generate_visit_struct_fields()

2013-07-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- scripts/qapi-visit.py | 62 --- 1 file changed, 34 insertions(+), 28 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 6cac05a..a337d80 100644 --- a/scripts/qapi-visit.py

[Qemu-devel] [RFC PATCH 04/11] qapi-visit.py: Implement 'base' for unions

2013-07-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- scripts/qapi-visit.py | 33 - 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index a337d80..3b2e693 100644 --- a/scripts/qapi-visit.py +++

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-09 Thread Stefano Stabellini
On Mon, 8 Jul 2013, Anthony Liguori wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Mon, 8 Jul 2013, Anthony Liguori wrote: Andreas Färber afaer...@suse.de writes: Right, it goes: 1) Acked-by: I haven't reviewed the code in detail but the general idea

Re: [Qemu-devel] [PATCH] exec.c: Pass correct pointer type to qemu_ram_ptr_length

2013-07-09 Thread Riku Voipio
On Mon, Jul 08, 2013 at 09:44:04AM +0100, Peter Maydell wrote: Commit e3127ae0 introduced a problem where we're passing a hwaddr* to qemu_ram_ptr_length() but it wants a ram_addr_t*; this will cause problems on 32 bit hosts and in any case provokes a clang warning on MacOSX: Bumped into this

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Max Filippov
On Tue, Jul 9, 2013 at 12:42 PM, Andreas Färber afaer...@suse.de wrote: Am 09.07.2013 09:39, schrieb Michael Tokarev: Ping? Have you tested -semihosting? The xtensa test image on the Wiki uses -nographic, but semihosting content always seems to go to stdout without going through a chardev

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Andreas Färber
Hi Max, Am 09.07.2013 13:00, schrieb Max Filippov: On Tue, Jul 9, 2013 at 12:42 PM, Andreas Färber afaer...@suse.de wrote: Am 09.07.2013 09:39, schrieb Michael Tokarev: Ping? Have you tested -semihosting? The xtensa test image on the Wiki uses -nographic, but semihosting content always

[Qemu-devel] [RFC PATCH v2] Adapter interrupts for virtio-ccw.

2013-07-09 Thread Cornelia Huck
Hi, here's again my proposal for adapter (thin) interrupt support for virtio-ccw devices, originally posted at http://marc.info/?l=linux-virtualizationm=137060143904927w=2 The document is unchanged, only rebased against current master. Cornelia Huck (1): virtio-ccw: Document adapter

[Qemu-devel] [RFC PATCH v2] virtio-ccw: Document adapter interrupts.

2013-07-09 Thread Cornelia Huck
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- virtio-spec.lyx | 147 +-- 1 file changed, 144 insertions(+), 3 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index c920155..4729766 100644 --- a/virtio-spec.lyx +++

[Qemu-devel] [RFC PATCH v2 0/2] KVM: s390: virtio-ccw adapter interrupts.

2013-07-09 Thread Cornelia Huck
Hi, next version of the guest exploitation of virtio-ccw adapter interrupts. Changes from the last version: - adapt to latest kvm-next - changed housekeeping for indicator locations: we now use cacheline-sized and aligned areas - minor tweaks Cornelia Huck (2): KVM: s390: virtio-ccw:

[Qemu-devel] [RFC PATCH v2] qemu: Adapter interrupts for virtio-ccw.

2013-07-09 Thread Cornelia Huck
Hi, here's the current implementation of virtio-ccw adapter interrupts in qemu. Code is unchanged, only rebased against current master. Cornelia Huck (1): s390/virtio-ccw: Adapter interrupt support. hw/s390x/css.c| 10 hw/s390x/css.h|2 ++

[Qemu-devel] [RFC PATCH v2] s390/virtio-ccw: Adapter interrupt support.

2013-07-09 Thread Cornelia Huck
Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts on guest request. When active, host-guest notifications will be handled via global_indicator - queue indicators instead of queue indicators + subchannel I/O interrupt. Indicators for virtqueues may be present at an offset.

[Qemu-devel] [RFC PATCH v2 2/2] KVM: s390: virtio-ccw adapter interrupt support.

2013-07-09 Thread Cornelia Huck
Implement the new CCW_CMD_SET_IND_ADAPTER command and try to enable adapter interrupts for every device on the first startup. If the host does not support adapter interrupts, fall back to normal I/O interrupts. virtio-ccw adapter interrupts use the same isc as normal I/O subchannels and share a

[Qemu-devel] [RFC PATCH v2 1/2] KVM: s390: virtio-ccw: Handle command rejects.

2013-07-09 Thread Cornelia Huck
A command reject for a ccw may happen if we run on a host not supporting a certain feature. We want to be able to handle this as special case of command failure, so let's split this off from the generic -EIO error code. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Eric Blake
On 07/09/2013 02:05 AM, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- To be applied on top of '[PATCH v3 0/3] qapi: Top-level type reference for command definitions'

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Fam Zheng
On Tue, 07/09 10:05, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- To be applied on top of '[PATCH v3 0/3] qapi: Top-level type reference for command definitions'

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Michael Tokarev
09.07.2013 12:42, Andreas Färber wrote: Am 09.07.2013 09:39, schrieb Michael Tokarev: Ping? Have you tested -semihosting? The xtensa test image on the Wiki uses -nographic, but semihosting content always seems to go to stdout without going through a chardev IIUC... Ok. I tried the xtensa

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Kevin Wolf
Am 09.07.2013 um 13:58 hat Fam Zheng geschrieben: On Tue, 07/09 10:05, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- To be applied on top of '[PATCH v3 0/3] qapi: Top-level

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Eric Blake
On 07/09/2013 05:58 AM, Fam Zheng wrote: On Tue, 07/09 10:05, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- +++ b/qapi-schema.json @@ -1791,42 +1791,14 @@ # The operation can be

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Eric Blake
On 07/09/2013 06:04 AM, Kevin Wolf wrote: and these still duplication of those comments for type declaration? No, the DriveBackup documentation doesn't describe what the command does or what it returns. You might argue that it should be there, but I think that's out of scope for this patch

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Kevin Wolf
Am 09.07.2013 um 14:09 hat Eric Blake geschrieben: On 07/09/2013 06:04 AM, Kevin Wolf wrote: and these still duplication of those comments for type declaration? No, the DriveBackup documentation doesn't describe what the command does or what it returns. You might argue that it should be

Re: [Qemu-devel] sending SEGV to qemu crashes host kernel in Fedora 19

2013-07-09 Thread Cole Robinson
On 07/08/2013 09:11 PM, Dave Airlie wrote: On Tue, Jul 9, 2013 at 10:35 AM, Dave Airlie airl...@gmail.com wrote: Hi, F19 kernel-3.9.8-300.fc19.x86_64 qemu-kvm-1.4.2-4.fc19.x86_64 If I start a complete F19 install in the guest and send the qemu process a SEGV signal, the host kernel starts

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Peter Maydell
On 9 July 2013 13:02, Michael Tokarev m...@tls.msk.ru wrote: 09.07.2013 12:42, Andreas Färber wrote: Am 09.07.2013 09:39, schrieb Michael Tokarev: Ping? Have you tested -semihosting? The xtensa test image on the Wiki uses -nographic, but semihosting content always seems to go to stdout

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Andreas Färber
Am 09.07.2013 14:37, schrieb Peter Maydell: On 9 July 2013 13:02, Michael Tokarev m...@tls.msk.ru wrote: 09.07.2013 12:42, Andreas Färber wrote: Am 09.07.2013 09:39, schrieb Michael Tokarev: Ping? Have you tested -semihosting? The xtensa test image on the Wiki uses -nographic, but

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Fam Zheng
On Tue, 07/09 06:07, Eric Blake wrote: On 07/09/2013 05:58 AM, Fam Zheng wrote: On Tue, 07/09 10:05, Kevin Wolf wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com --- +++ b/qapi-schema.json

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Peter Maydell
On 9 July 2013 13:40, Andreas Färber afaer...@suse.de wrote: The way I interpreted it (without having tested it yet) is that we would not be able to use Ctrl+C in -semihosting mode, no? At least that's how -display none is like today IIRC. I don't think anybody expects ctrl-C to interact with

[Qemu-devel] [PATCH] hw/arm/vexpress: Add alias for flash at address 0 on A15 board

2013-07-09 Thread Peter Maydell
The A15 Versatile Express board can remap a variety of things at address 0. We don't currently emulate the Serial Configuration Controller which is how the guest can control this remapping, but we can provide the initial default mapping of the first flash device into this space. In particular this

Re: [Qemu-devel] seabios 1.7.3 breaks booting windows 7?

2013-07-09 Thread Cole Robinson
On 07/08/2013 08:41 PM, Kevin O'Connor wrote: On Mon, Jul 08, 2013 at 08:18:42PM -0400, Cole Robinson wrote: On 07/08/2013 07:18 PM, Kevin O'Connor wrote: On Mon, Jul 08, 2013 at 05:23:40PM -0400, Cole Robinson wrote: On 07/07/2013 11:41 PM, Kevin O'Connor wrote: The 1.7.3 version of SeaBIOS

[Qemu-devel] [Bug 1197663] Re: qcow2 [virtio-scsi] devices when mapped to the guest shows as 0MB irrespective of the volume size

2013-07-09 Thread chandrashekar shastri
Thanks Stefanha. If we use the commad virsh attach-disk rhel64-64 /home/images/virtio- scsi11.img --persistent sdr --cache writethrough the qcow2 images will also gets added as raw which is by default. Hence we should use virsh attach-disk rhel64-64 /home/images/virtio-scsi11.img --persistent

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Michael Tokarev
09.07.2013 16:40, Andreas Färber wrote: The way I interpreted it (without having tested it yet) is that we would not be able to use Ctrl+C in -semihosting mode, no? At least that's how -display none is like today IIRC. With -display none qemu terminates when you hit Ctrl+C, with or without the

Re: [Qemu-devel] [RFC PATCH v2] s390/virtio-ccw: Adapter interrupt support.

2013-07-09 Thread Christian Borntraeger
On 09/07/13 13:34, Cornelia Huck wrote: Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts on guest request. When active, host-guest notifications will be handled via global_indicator - queue indicators instead of queue indicators + subchannel I/O interrupt. Indicators

Re: [Qemu-devel] KVM call agenda for 2013-07-09

2013-07-09 Thread Igor Mammedov
On Mon, 08 Jul 2013 02:42:32 +0200 Andreas Färber afaer...@suse.de wrote: Am 08.07.2013 01:10, schrieb Juan Quintela: Please, send any topic that you are interested in covering. Static qdev vs. dynamic QOM properties and -global (Igor's topic from two weeks ago that we couldn't cover any

Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments

2013-07-09 Thread Luiz Capitulino
On Tue, 9 Jul 2013 10:05:35 +0200 Kevin Wolf kw...@redhat.com wrote: This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf kw...@redhat.com Applied to the qmp branch, thanks. --- To be applied on top of '[PATCH v3 0/3] qapi:

Re: [Qemu-devel] [RFC PATCH v2] s390/virtio-ccw: Adapter interrupt support.

2013-07-09 Thread Cornelia Huck
On Tue, 09 Jul 2013 15:27:14 +0200 Christian Borntraeger borntrae...@de.ibm.com wrote: On 09/07/13 13:34, Cornelia Huck wrote: Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts on guest request. When active, host-guest notifications will be handled via

Re: [Qemu-devel] sending SEGV to qemu crashes host kernel in Fedora 19

2013-07-09 Thread Josh Boyer
On Mon, Jul 8, 2013 at 9:11 PM, Dave Airlie airl...@gmail.com wrote: On Tue, Jul 9, 2013 at 10:35 AM, Dave Airlie airl...@gmail.com wrote: Hi, F19 kernel-3.9.8-300.fc19.x86_64 qemu-kvm-1.4.2-4.fc19.x86_64 If I start a complete F19 install in the guest and send the qemu process a SEGV

[Qemu-devel] [Qeustion] NPIV support on guest

2013-07-09 Thread Ren Mingxin
Hi, It seems this is a old question, but I couldn't get a exact answer via historical mails: How to assign vhba to guest now? It'll be much appreciated if exact xml format/qemu commandcan be showed. And, it seems that persistent vhba hasn't been supported by libvirt, yes? Thanks, Ren

Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-07-09 Thread Wenchao Xia
You could pass cur_mon to readline_completion() in readline_handle_byte() to avoid all this, but it would be preferable to clarify the matter. This is also another benefit of having readline_completion() in a different patch, you can (and should!) clarify this point in the commit log along

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Peter Maydell
On 3 July 2013 17:29, Michael Tokarev m...@tls.msk.ru wrote: +When monitor is multiplexed to stdio this way, Ctrl+C will not terminate +QEMU anymore but will be passed to the guest instead. the monitor, in this way, any more. Otherwise Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

[Qemu-devel] [PATCH] Fix command example in qemu.sasl

2013-07-09 Thread Cole Robinson
sasldblistusers2 doesn't have a '-a' option Signed-off-by: Cole Robinson crobi...@redhat.com --- qemu.sasl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu.sasl b/qemu.sasl index cf19cf8..9dc8323 100644 --- a/qemu.sasl +++ b/qemu.sasl @@ -26,7 +26,7 @@ keytab:

Re: [Qemu-devel] [PATCH v3 2/2] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Peter Maydell
On 3 July 2013 17:29, Michael Tokarev m...@tls.msk.ru wrote: It looks like initially there was -nographic option to turn off display, now there's another option of the same sort, -display none. But code in other places of qemu checks for DT_NOGRAPHIC and does not work well with -display none.

Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-07-09 Thread Luiz Capitulino
On Tue, 09 Jul 2013 22:03:42 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: You could pass cur_mon to readline_completion() in readline_handle_byte() to avoid all this, but it would be preferable to clarify the matter. This is also another benefit of having readline_completion() in

Re: [Qemu-devel] [PATCH 04/17] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-09 Thread Anthony Liguori
Alexey Kardashevskiy a...@ozlabs.ru writes: On 07/09/2013 04:29 AM, Anthony Liguori wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: From: David Gibson da...@gibson.dropbear.id.au The savevm code for the powerpc cpu emulation is currently based around the old register_savevm() rather

[Qemu-devel] [PULL 00/15] tcg: remainder and tcg-arm updates

2013-07-09 Thread Richard Henderson
The following changes since commit dc11549ec213f85f6a024c7df68d349464cd1688: Merge remote-tracking branch 'mst/tags/for_anthony' into staging (2013-07-08 08:00:23 -0500) are available in the git repository at: git://github.com/rth7680/qemu.git tcg-next for you to fetch changes up to

[Qemu-devel] [PULL 07/15] tcg: Simplify logic using TCG_OPF_NOT_PRESENT

2013-07-09 Thread Richard Henderson
Expand the definition of not present to include should not be present. This means we can simplify the logic surrounding the generic tcg opcodes for which the host backend ought not be providing definitions. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson

[Qemu-devel] [PULL 03/15] tcg-arm: Don't implement rem

2013-07-09 Thread Richard Henderson
Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 14 -- tcg/arm/tcg-target.h | 3 +-- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index

[Qemu-devel] [PULL 02/15] tcg: Split rem requirement from div requirement

2013-07-09 Thread Richard Henderson
There are several hosts with only a div insn. Remainder is computed manually from the quotient and inputs. We can do this generically. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/aarch64/tcg-target.h | 2 ++

[Qemu-devel] [PULL 09/15] tcg-arm: Rename use_armv5_instructions to use_armvt5_instructions

2013-07-09 Thread Richard Henderson
As it really controls the availability of a thumb interworking instruction on armv5t. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PULL 06/15] tcg: Allow non-constant control macros

2013-07-09 Thread Richard Henderson
This allows TCG_TARGET_HAS_* to be a variable rather than a constant, which allows easier support for differing ISA levels for the host. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-opc.h | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PULL 08/15] tcg-arm: Make use of conditional availability of opcodes for divide

2013-07-09 Thread Richard Henderson
We can now detect and use divide instructions at runtime, rather than having to restrict their availability to compile-time. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 16 ++-- tcg/arm/tcg-target.h

[Qemu-devel] [PULL 05/15] tcg-ppc64: Don't implement rem

2013-07-09 Thread Richard Henderson
Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc64/tcg-target.c | 26 -- tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 2 insertions(+), 28 deletions(-) diff --git a/tcg/ppc64/tcg-target.c

[Qemu-devel] [PULL 12/15] tcg: Fix high_pc fields in .debug_info

2013-07-09 Thread Richard Henderson
I don't think the debugger actually looks at this for anything, using the correct .debug_frame contents, but might as well get it all correct. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg.c | 4 ++-- 1 file changed, 2

[Qemu-devel] [PULL 15/15] tcg-arm: Implement tcg_register_jit

2013-07-09 Thread Richard Henderson
Allows unwinding past the code_gen_buffer. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 76 +--- 1 file changed, 67 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PULL 04/15] tcg-ppc: Don't implement rem

2013-07-09 Thread Richard Henderson
Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc/tcg-target.c | 14 -- tcg/ppc/tcg-target.h | 2 +- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for -serial mon:stdio

2013-07-09 Thread Michael Tokarev
09.07.2013 18:04, Peter Maydell wrote: On 3 July 2013 17:29, Michael Tokarev m...@tls.msk.ru wrote: +When monitor is multiplexed to stdio this way, Ctrl+C will not terminate +QEMU anymore but will be passed to the guest instead. the monitor, in this way, any more. Grr. This is 3rd change

[Qemu-devel] [PULL 13/15] tcg: Move the CIE and FDE header definitions to common code

2013-07-09 Thread Richard Henderson
These will necessarily be the same layout for all hosts. This limits the amount of boilerplate required to implement jit debug for a host. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/hppa/tcg-target.c | 35

[Qemu-devel] [PULL 14/15] tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for frame size

2013-07-09 Thread Richard Henderson
We can check the condition at compile time, rather than run time. Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/i386/tcg-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c

Re: [Qemu-devel] [PATCH 0/6] qdev: handle global properties after all instance_init calls

2013-07-09 Thread Andreas Färber
Ping for KVM call discussion Am 03.10.2012 19:48, schrieb Eduardo Habkost: Summary: - Object properties are registered by the classes' instance_init() functions - qdev_prop_set_globals() needs all properties to be registered before being called. - Hence, qdev_prop_set_globals()

Re: [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8

2013-07-09 Thread Anthony Liguori
Alexey Kardashevskiy a...@ozlabs.ru writes: This series spent quite a lot of time waiting when David's PCI series reaches the upstream but it does not seem to happen soon so I rebased those on top of agraf/ppc-next rebased on top qemu.org/master. While this series applies and compiles, the

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-07-09 Thread Anthony Liguori
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Tue, 2013-07-09 at 13:40 +1000, Alexey Kardashevskiy wrote: No, why? It is a per CPU state of XICS controller, never exists apart from XICS. ICP is. ICS is ... different but can mostly be considered to be the XICS itself.

Re: [Qemu-devel] [PATCH 03/17] savevm: Implement VMS_DIVIDE flag

2013-07-09 Thread David Gibson
On Tue, Jul 09, 2013 at 09:06:21AM -0500, Anthony Liguori wrote: David Gibson da...@gibson.dropbear.id.au writes: On Mon, Jul 08, 2013 at 01:27:05PM -0500, Anthony Liguori wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: From: David Gibson da...@gibson.dropbear.id.au The

[Qemu-devel] [PULL 11/15] tcg-arm: Use AT_PLATFORM to detect the host ISA

2013-07-09 Thread Richard Henderson
With this we can generate armv7 insns even when the OS compiles for a lower common denominator. The macros are arranged so that when we do compile for a given ISA, all of the runtime checks for that ISA are optimized away. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by:

[Qemu-devel] [PULL 10/15] tcg-arm: Simplify logic in detecting the ARM ISA in use

2013-07-09 Thread Richard Henderson
GCC 4.8 defines a handy __ARM_ARCH symbol that we can use, which will make us nicely forward compatible with ARMv8 AArch32. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 62

[Qemu-devel] [PULL 01/15] tcg: Add myself to general TCG maintainership

2013-07-09 Thread Richard Henderson
Acked-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 780f480..93ad19d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -781,6 +781,7 @@ Tiny Code

Re: [Qemu-devel] [PATCH 04/17] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-09 Thread David Gibson
On Tue, Jul 09, 2013 at 09:08:01AM -0500, Anthony Liguori wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 07/09/2013 04:29 AM, Anthony Liguori wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: [snip] +#endif /* TARGET_PPC64 */ +.vmsd = vmstate_tlb6xx, +

  1   2   >