Re: [Qemu-devel] [RFC 3/3 v2] qdev: set globals on post_init() function

2013-07-10 Thread Igor Mammedov
On Wed, 10 Jul 2013 17:08:42 -0300 Eduardo Habkost wrote: > This way, properties registered in the instance_init() function of > children classes will be handled properly by qdev_prop_set_globals(), > too. > > Includes a new unit test for the new functionality. > > Signed-off-by: Eduardo Habkos

Re: [Qemu-devel] [PATCH 0/7] Fixes around -machine

2013-07-10 Thread Markus Armbruster
Anthony Liguori writes: > Applied. Thanks. Peter pointed out that my code doesn't work as advertized when !list->merge_list (never true in current usage). I'll try to address that on top when I get a breather I can spend on non-critical upstream work. Peter, do feel free to go ahead and chang

Re: [Qemu-devel] [RFC 2/3 v2] qom: introduce post_init() function

2013-07-10 Thread Igor Mammedov
On Wed, 10 Jul 2013 17:08:41 -0300 Eduardo Habkost wrote: > This will allow classes to specify a function to be called after all > instance_init() functions were called. > > This will be used by DeviceState to call qdev_prop_set_globals() at the > right moment. > > Signed-off-by: Eduardo Habkos

[Qemu-devel] [PATCH V5 6/8] hmp: add interface hmp_snapshot_blkdev_internal

2013-07-10 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- hmp-commands.hx | 19 +-- hmp.c | 10 ++ hmp.h |1 + 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index d1cdcfb..ec613e8 100644 --- a/hmp-commands.hx +++ b/hmp-c

[Qemu-devel] [PATCH V5 5/8] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-07-10 Thread Wenchao Xia
This interface use id and name as optional parameters, to handle the case that one image contain multiple snapshots with same name which may be '', but with different id. Adding parameter id is for historical compatiability reason, and that case is not possible in qemu's new interface for internal

[Qemu-devel] [PATCH V5 8/8] qemu-iotests: add 056 internal snapshot for block device test case

2013-07-10 Thread Wenchao Xia
Create in transaction and deletion in single command will be tested. Signed-off-by: Wenchao Xia --- tests/qemu-iotests/056 | 259 tests/qemu-iotests/056.out |5 + tests/qemu-iotests/group |1 + 3 files changed, 265 insertions(+), 0 dele

[Qemu-devel] [PATCH V5 7/8] hmp: add interface hmp_snapshot_delete_blkdev_internal

2013-07-10 Thread Wenchao Xia
It is hard to make both id and name optional in hmp console as qmp interface, so this interface require user to specify name. Signed-off-by: Wenchao Xia --- hmp-commands.hx | 18 ++ hmp.c | 12 hmp.h |1 + 3 files changed, 31 insertions(+)

[Qemu-devel] [PATCH V5 3/8] qmp: add internal snapshot support in qmp_transaction

2013-07-10 Thread Wenchao Xia
Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. Although qcow2 support storing multiple snapshots with same name but different ID, here it will fail when an snapshot with that name already

[Qemu-devel] [PATCH V5 4/8] qmp: add interface blockdev-snapshot-internal-sync

2013-07-10 Thread Wenchao Xia
Snapshot ID can't be specified in this interface. Signed-off-by: Wenchao Xia --- blockdev.c | 13 + qapi-schema.json | 20 qmp-commands.hx | 29 + 3 files changed, 62 insertions(+), 0 deletions(-) diff --git a/blockdev.c

[Qemu-devel] [PATCH V5 2/8] snapshot: distinguish id and name in snapshot delete

2013-07-10 Thread Wenchao Xia
Snapshot creation actually already distinguish id and name since it take a structured parameter *sn, but delete can't. Later an accurate delete is needed in qmp_transaction abort and blockdev-snapshot-delete-sync, so change its prototype. Also *errp is added to tip error, but return value is kepted

[Qemu-devel] [PATCH V5 1/8] snapshot: new function bdrv_snapshot_find_by_id_and_name()

2013-07-10 Thread Wenchao Xia
To make it clear about id and name in searching, add this API to distinguish them. Caller can choose to search by id or name, *errp will be set only for exception. Some code are modified based on Pavel's patch. Signed-off-by: Wenchao Xia Signed-off-by: Pavel Hrdina --- block/snapshot.c

[Qemu-devel] [PATCH V5 0/8] add internal snapshot support at block device level

2013-07-10 Thread Wenchao Xia
This series brings internal snapshot support at block devices level, now we have two three methods to do block snapshot lively: 1) backing chain, 2) internal one and 3) drive-back up approach. Comparation: Advantages:Disadvantages: 1)delta data, taken

Re: [Qemu-devel] [PATCH] linux-user: Use X86CPU property to retrieve CPUID family

2013-07-10 Thread Igor Mammedov
On Wed, 10 Jul 2013 18:26:17 +0200 Andreas Färber wrote: > Avoids duplicating the calculation. > > Signed-off-by: Andreas Färber > --- > Have this lying around for a while already, apparently not sent out yet. > > linux-user/cpu-uname.c | 10 ++ > 1 file changed, 6 insertions(+), 4 d

Re: [Qemu-devel] [PATCH v5 10/14] pc: Add dimm paravirt SRAT info

2013-07-10 Thread Igor Mammedov
On Wed, 10 Jul 2013 13:10:03 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 26, 2013 at 05:13:33PM +0800, Hu Tao wrote: > > The numa_fw_cfg paravirt interface is extended to include SRAT information > > for > > all hotplug-able dimms. There are 3 words for each hotplug-able memory slot, > > den

Re: [Qemu-devel] qemu aborts with temp_save: Assertion `s->temps[temp].val_type == 2 || s->temps[temp].fixed_reg' failed

2013-07-10 Thread Max Filippov
On Thu, Jul 11, 2013 at 6:35 AM, Max Filippov wrote: > Hi Peter, > > I suddenly found qemu built with debug enabled aborting with an assertion on > one of xtensa tests: > > qemu-system-xtensa -M sim -cpu dc232b -nographic -semihosting -kernel > ./test_sr.tst > QEMU 1.4.50 monitor - type 'help'

[Qemu-devel] [PATCH V6 03/13] monitor: avoid use of global *cur_mon in block_completion_it()

2013-07-10 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- monitor.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 181d5b0..68f281e 100644 --- a/monitor.c +++ b/monitor.c @@ -4078,14 +4078,21 @@ static void file_completion(Monitor *mon, const char *in

[Qemu-devel] [PATCH V6 08/13] monitor: refine parse_cmdline()

2013-07-10 Thread Wenchao Xia
Since this function will be used by help_cmd() later, so improve it to make it more generic and easier to use. free_cmdline_args() is added to as paired function to free the result. Signed-off-by: Wenchao Xia --- monitor.c | 52 ++-- 1 files chan

[Qemu-devel] [PATCH V6 13/13] monitor: improve auto complete of "help" for single command in sub group

2013-07-10 Thread Wenchao Xia
Now special case "help *" in auto completion can work with sub commands, such as "help info u*". Signed-off-by: Wenchao Xia --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 52fb8c7..68041e6 100644 --- a/monitor.c +++ b/monito

[Qemu-devel] [PATCH V6 12/13] monitor: allow "help" show message for single command in sub group

2013-07-10 Thread Wenchao Xia
A new parameter type 'S' is introduced to allow user input any string. "help info block" works normal now. Signed-off-by: Wenchao Xia --- hmp-commands.hx |2 +- monitor.c | 27 +++ 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/hmp-commands.hx

[Qemu-devel] [PATCH V6 11/13] monitor: support sub command in auto completion

2013-07-10 Thread Wenchao Xia
This patch allow auto completion work normal for sub command case, "info block [DEVICE]" can auto complete now, by re-enter the completion function. In original code "info" is treated as a special case, now it is treated as a sub command group, global variable info_cmds is not used any more. "help

[Qemu-devel] [PATCH V6 06/13] monitor: avoid direct use of global variable *mon_cmds

2013-07-10 Thread Wenchao Xia
New member *cmd_table is added in structure Monitor to avoid direct usage of *mon_cmds. Now monitor have an associated command table, when global variable *info_cmds is also discarded, structure Monitor would gain full control about how to deal with user input. Signed-off-by: Wenchao Xia --- mon

[Qemu-devel] [PATCH V6 09/13] monitor: support sub command in help

2013-07-10 Thread Wenchao Xia
The old code in help_cmd() use global 'info_cmds' and treat it as a special case. Actually 'info_cmds' is an sub command group of 'mon_cmds', in order to avoid direct use of it, help_cmd() need to change its work mechanism to support sub command and not treat it as a special case any more. To supp

[Qemu-devel] [PATCH V6 04/13] monitor: avoid use of global *cur_mon in monitor_find_completion()

2013-07-10 Thread Wenchao Xia
Parameter *mon is added, and local variable *mon added in previous patch is removed. The caller readline_completion(), pass rs->mon as value, which should be initialized in readline_init() called by monitor_init(). Signed-off-by: Wenchao Xia --- include/monitor/readline.h |3 ++- monitor.c

[Qemu-devel] [PATCH V6 07/13] monitor: code move for parse_cmdline()

2013-07-10 Thread Wenchao Xia
help_cmd() need this function later, so move it. get_str() is called by parse_cmdline() so it is moved also. Some code style error reported by check script, is also fixed. Signed-off-by: Wenchao Xia --- monitor.c | 191 +++-- 1 files chang

[Qemu-devel] [PATCH V6 10/13] monitor: refine monitor_find_completion()

2013-07-10 Thread Wenchao Xia
In order to support sub command in auto completion, an reentrant function is needed, so monitor_find_completion() is splitted into two parts. The first part does parsing of user input which need to be done only once, the second part does the auto completion job according to the parsing result, whic

[Qemu-devel] [PATCH V6 00/13] monitor: support sub command group in auto completion and help

2013-07-10 Thread Wenchao Xia
This series make auto completion and help functions works normal for sub command, by using reentrant functions. In order to do that, global variables are not directly used in those functions any more. With this series, cmd_table is a member of structure Monitor so it is possible to create a monitor

[Qemu-devel] [PATCH V6 01/13] monitor: avoid use of global *cur_mon in cmd_completion()

2013-07-10 Thread Wenchao Xia
A new local variable *mon is added in monitor_find_completion() to make compile pass, which will be removed later in convertion patch for monitor_find_completion(). Signed-off-by: Wenchao Xia --- monitor.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/monit

[Qemu-devel] [PATCH V6 05/13] monitor: avoid use of global *cur_mon in readline_completion()

2013-07-10 Thread Wenchao Xia
Now all completion functions do not use *cur_mon any more, instead they use rs->mon. In short, structure ReadLineState decide where the complete action would be taken now. Tested with the case that qemu have two telnet monitors, auto completion function works normal. Take a better look at monitor

[Qemu-devel] [PATCH V6 02/13] monitor: avoid use of global *cur_mon in file_completion()

2013-07-10 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- monitor.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 7398d00..181d5b0 100644 --- a/monitor.c +++ b/monitor.c @@ -4022,7 +4022,7 @@ static void cmd_completion(Monitor *mon, const char *name, const char

[Qemu-devel] qemu aborts with temp_save: Assertion `s->temps[temp].val_type == 2 || s->temps[temp].fixed_reg' failed

2013-07-10 Thread Max Filippov
Hi Peter, I suddenly found qemu built with debug enabled aborting with an assertion on one of xtensa tests: qemu-system-xtensa -M sim -cpu dc232b -nographic -semihosting -kernel ./test_sr.tst QEMU 1.4.50 monitor - type 'help' for more information (qemu) QEMU 1.4.50 monitor - type 'help' for mo

[Qemu-devel] [PATCH qom-next v2 5/5] i8254: Use parent class for realize

2013-07-10 Thread peter . crosthwaite
From: Peter Crosthwaite [KVM]PITClass is only needed for parent-class realize function access. Just use parent classes for realize access and remove [KVM]PITClass completely. Signed-off-by: Peter Crosthwaite --- hw/i386/kvm/i8254.c | 18 +++--- hw/timer/i8254.c| 17 +++

[Qemu-devel] [PATCH qom-next v2 4/5] target-microblaze: Use parent class for reset + realize

2013-07-10 Thread peter . crosthwaite
From: Peter Crosthwaite MicroblazeCPUClass is only needed for parent-class abstract function access. Just use parent classes for reset and realize access and remove MicroblazeCPUClass completely. Signed-off-by: Peter Crosthwaite --- target-microblaze/cpu-qom.h | 20 targe

[Qemu-devel] [PATCH qom-next v2 2/5] qom/object: Add object_class_get_parent_by_name

2013-07-10 Thread peter . crosthwaite
From: Peter Crosthwaite Function for looking up a class by name then getting its parent. Signed-off-by: Peter Crosthwaite --- include/qom/object.h | 9 + qom/object.c | 5 + 2 files changed, 14 insertions(+) diff --git a/include/qom/object.h b/include/qom/object.h index 2

[Qemu-devel] [PATCH qom-next v2 3/5] target-arm: Use parent classes for reset + realize

2013-07-10 Thread peter . crosthwaite
From: Peter Crosthwaite ARMCPUClass is only needed for parent-class abstract function access. Just use parent classes for reset and realize access and remove ARMCPUClass completely. Signed-off-by: Peter Crosthwaite --- target-arm/cpu-qom.h | 20 target-arm/cpu.c | 16

[Qemu-devel] [PATCH qom-next v2 1/5] target-arm/cpu.c: delete un-needed instance/class sizes

2013-07-10 Thread peter . crosthwaite
From: Peter Crosthwaite QOM automatically inherits class and instance size from the parent class. No need to redefine as the same value as the parent. CC: qemu-triv...@nongnu.org Signed-off-by: Peter Crosthwaite --- target-arm/cpu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target

[Qemu-devel] [PATCH qom-next v2 0/5] QOM Super class access

2013-07-10 Thread peter . crosthwaite
From: Peter Crosthwaite This series enables QOM super class access and demostrates some usages. Replaces the save->override->call via FooClass technique, to reduce some of the boiler plate in recently fully QOMified devices. Applied the change to ARM CPU, MB CPU and some of Andreas's recently QO

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Programmingkid
On Jul 10, 2013, at 7:28 PM, Anthony Liguori wrote: > Programmingkid writes: > >> On Jul 10, 2013, at 4:17 PM, Scott Wood wrote: >> >>> Keyboards don't generally speak ASCII (or Unicode). They produce keycodes, >>> which are generally translated into some sort of event by the host's input >

[Qemu-devel] guest xp vm can not recognize vcpu

2013-07-10 Thread yue-kvm
hi, all in guest xp vm , device management shows a help sign on cpu device, it has two vcpu, only one is recognized(NODE has two physical cpu). qemu is build by myself from souce code, qemu-1.5.0, centos 6.4 a picture is attached . ---libvirt-- 2 hvm

Re: [Qemu-devel] gdbstub broken in master

2013-07-10 Thread Max Filippov
On Wed, Jul 10, 2013 at 1:47 AM, Andreas Färber wrote: > Hi Max, > > Am 09.07.2013 01:37, schrieb Max Filippov: >> commit c52a6b67c1d7c6fc9fb2e3ba988d7b978e1487d3 >> Author: Andreas Färber >> Date: Fri May 17 17:49:10 2013 +0200 >> >> gdbstub: Simplify find_cpu() >> >> Use qemu_get_cpu(

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Anthony Liguori
Alexander Graf writes: > Am 10.07.2013 um 21:54 schrieb Programmingkid : > >> qemu-system-ppc -keyboard-layout-file ./keyboard-layout.txt > > That's exactly what -k does today already, no? No. What we send to the guest is a scancode. This literally corresponds to "row 4, column 5". With a go

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Anthony Liguori
Programmingkid writes: > On Jul 10, 2013, at 4:17 PM, Scott Wood wrote: > >> Keyboards don't generally speak ASCII (or Unicode). They produce keycodes, >> which are generally translated into some sort of event by the host's input >> layer (e.g. the X server). It's up to the guest software to

Re: [Qemu-devel] QEMU support for a.out format executables in user mode emulation

2013-07-10 Thread Peter Maydell
On 10 July 2013 22:05, Graney, Kevin wrote: > I know the QEMU system emulation of SPARC supports booting a.out > format kernels, but is there currently support for this format > in user mode emulation? Not currently. > If I have an a.out format binary is there an easy way to get > qemu-sparc to

[Qemu-devel] [PATCH v6 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-07-10 Thread Tomoki Sekiyama
To enable VSS support in qemu-ga for Windows, header files included in VSS SDK are required. The VSS support is enabled by the configure option like below: ./configure --with-vss-sdk="/path/to/VSS SDK" If the path is omitted, it tries to search the headers from default paths and VSS support is e

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Alexander Graf
Am 10.07.2013 um 21:54 schrieb Programmingkid : > > On Jul 10, 2013, at 3:03 PM, Scott Wood wrote: > >> On 07/09/2013 10:36:37 PM, Programmingkid wrote: >>> On Jul 9, 2013, at 1:32 PM, Scott Wood wrote: On 07/04/2013 09:58:04 AM, Programmingkid wrote: > On Jul 4, 2013, at 10:51 AM, St

[Qemu-devel] [PATCH v6 01/10] configure: Support configuring C++ compiler

2013-07-10 Thread Tomoki Sekiyama
Add configuration for C++ compiler in configure and Makefiles. The C++ compiler is choosed as following: - ${CXX}, if it is specified. - ${cross_prefix}g++, if ${cross_prefix} is specified. - Otherwise, c++ is used. Currently, usage of C++ language is only for access to Windows VSS using COM+ s

[Qemu-devel] [PATCH v6 02/10] Add c++ keywords to QAPI helper script

2013-07-10 Thread Tomoki Sekiyama
Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek --- hmp.c |2 +- hw/pci/pci.c|2 +- scripts/qapi.py | 12 +++- 3 files changed, 1

[Qemu-devel] [PATCH v6 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-07-10 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Scott Wood
On 07/10/2013 03:55:46 PM, Programmingkid wrote: On Jul 10, 2013, at 4:17 PM, Scott Wood wrote: > On 07/10/2013 02:54:19 PM, Programmingkid wrote: >> On Jul 10, 2013, at 3:03 PM, Scott Wood wrote: >> > Maybe the user doesn't mind -- but maybe they do mind and would rather swap the two than en

[Qemu-devel] [PATCH v6 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-10 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama --- qga/main.c | 10 +- qga/vss-win32.c | 25

[Qemu-devel] [PATCH v6 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

2013-07-10 Thread Tomoki Sekiyama
Adds VSS provider and requester as a qga-vss.dll, which is loaded by Windows VSS service as well as by qemu-ga. "provider.cpp" implements a basic stub of a software VSS provider. Currently, this module only relays a frozen event from VSS service to the agent, and thaw event from the agent to VSS s

[Qemu-devel] [PATCH v6 06/10] error: Add error_set_win32 and error_setg_win32

2013-07-10 Thread Tomoki Sekiyama
These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama --- include/qapi/error.h | 13 + util/error.c | 35 +++

[Qemu-devel] QEMU support for a.out format executables in user mode emulation

2013-07-10 Thread Graney, Kevin
Hi all, I know the QEMU system emulation of SPARC supports booting a.out format kernels, but is there currently support for this format in user mode emulation? If I have an a.out format binary is there an easy way to get qemu-sparc to load it or will I have to patch the loader to basically add

[Qemu-devel] [PATCH v6 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

2013-07-10 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 60 seconds (timeout of pre-commit phase of VSS). Signed-off-by: Tomoki Sekiyama Reviewed-by: Paolo Bonzini Reviewed-by: Laszlo Ersek --- QMP/qem

[Qemu-devel] [PATCH v6 03/10] checkpatch.pl: Check .cpp files

2013-07-10 Thread Tomoki Sekiyama
Enable checkpatch.pl to apply the same checks as C source files for C++ files with .cpp extensions. It also adds some exceptions for C++ sources to suppress errors for: - <> used in C++ template arguments (e.g. template ) - :: used to represent namespaces (e.g. SomeClass::method()) - : used

[Qemu-devel] [PATCH v6 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler

2013-07-10 Thread Tomoki Sekiyama
Support guest-fsfreeze-freeze and guest-fsfreeze-thaw commands for Windows guests. When fsfreeze command is issued, it calls the VSS requester to freeze filesystems and applications. On thaw command, it again tells the VSS requester to thaw them. This also adds calling of initialize functions for

[Qemu-devel] [PATCH v6 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-10 Thread Tomoki Sekiyama
Hi, This is v6 of patch series to add fsfreeze for Windows qemu-guest-agent. changes from v5: - Move VSS requester code into the DLL -- Merge patch v5 06/11(add provider) and patch v5 08/11(add requester) (-> patch v6 07/10) -- Rename qga-provider.dll to qga-vss.dll -- Rearrange f

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Programmingkid
On Jul 10, 2013, at 4:17 PM, Scott Wood wrote: > On 07/10/2013 02:54:19 PM, Programmingkid wrote: >> On Jul 10, 2013, at 3:03 PM, Scott Wood wrote: >> > On 07/09/2013 10:36:37 PM, Programmingkid wrote: >> >> On Jul 9, 2013, at 1:32 PM, Scott Wood wrote: >> >> > On 07/04/2013 09:58:04 AM, Programm

Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-07-10 Thread Peter Lieven
Am 10.07.2013 16:58, schrieb Kevin Wolf: > Am 10.07.2013 um 16:49 hat Peter Lieven geschrieben: >> Am 10.07.2013 16:28, schrieb Kevin Wolf: >>> Am 10.07.2013 um 16:04 hat Peter Lieven geschrieben: Am 10.07.2013 13:33, schrieb Kevin Wolf: > Am 27.06.2013 um 15:11 hat Peter Lieven geschriebe

Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist

2013-07-10 Thread Paul Moore
On Wednesday, July 10, 2013 10:02:55 PM Andreas Färber wrote: > Am 10.07.2013 16:31, schrieb Paul Moore: > > On Wednesday, May 29, 2013 04:30:01 PM Paul Moore wrote: > >> In order to enable the asynchronous I/O functionality when using the > >> seccomp sandbox we need to add the associated syscalls

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Scott Wood
On 07/10/2013 02:54:19 PM, Programmingkid wrote: On Jul 10, 2013, at 3:03 PM, Scott Wood wrote: > On 07/09/2013 10:36:37 PM, Programmingkid wrote: >> On Jul 9, 2013, at 1:32 PM, Scott Wood wrote: >> > On 07/04/2013 09:58:04 AM, Programmingkid wrote: >> >> On Jul 4, 2013, at 10:51 AM, Stefan Haj

[Qemu-devel] [RFC 3/3 v2] qdev: set globals on post_init() function

2013-07-10 Thread Eduardo Habkost
This way, properties registered in the instance_init() function of children classes will be handled properly by qdev_prop_set_globals(), too. Includes a new unit test for the new functionality. Signed-off-by: Eduardo Habkost --- hw/core/qdev.c | 10 +- tests/test-qdev-global

[Qemu-devel] [RFC 1/3 v2] tests: unit tests for qdev global-properties handling

2013-07-10 Thread Eduardo Habkost
This tests the qdev global-properties handling code. Signed-off-by: Eduardo Habkost --- tests/.gitignore | 1 + tests/Makefile | 7 +++ tests/test-qdev-global-props.c | 109 + 3 files changed, 117 insertions(+) create mod

[Qemu-devel] [RFC 2/3 v2] qom: introduce post_init() function

2013-07-10 Thread Eduardo Habkost
This will allow classes to specify a function to be called after all instance_init() functions were called. This will be used by DeviceState to call qdev_prop_set_globals() at the right moment. Signed-off-by: Eduardo Habkost --- include/qom/object.h | 3 +++ qom/object.c | 14 +

[Qemu-devel] [RFC 0/3 v2] qdev: handle global properties after all instance_init calls

2013-07-10 Thread Eduardo Habkost
Updated version of the series sent in October 2012. References: http://article.gmane.org/gmane.comp.emulators.qemu/173753 (old discussion) http://article.gmane.org/gmane.comp.emulators.qemu/173782 (previous version of this series) http://article.gmane.org/gmane.comp.emulators.kvm.dev

Re: [Qemu-devel] [PATCH v3 1/2] trap signals for "-serial mon:stdio"

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist

2013-07-10 Thread Andreas Färber
Am 10.07.2013 16:31, schrieb Paul Moore: > On Wednesday, May 29, 2013 04:30:01 PM Paul Moore wrote: >> In order to enable the asynchronous I/O functionality when using the >> seccomp sandbox we need to add the associated syscalls to the >> whitelist. >> >> Signed-off-by: Paul Moore >> --- >> qemu

Re: [Qemu-devel] [PATCH V16 7/7] remove QEMUOptionParameter related functions and struct

2013-07-10 Thread Eric Blake
On 06/18/2013 03:31 AM, Dong Xu Wang wrote: > Signed-off-by: Dong Xu Wang > --- > include/qemu/option.h | 39 --- > util/qemu-option.c| 285 > -- > 2 files changed, 324 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat

Re: [Qemu-devel] [PATCH V16 6/7] query-command-line-options outputs def_value_str

2013-07-10 Thread Eric Blake
On 06/18/2013 03:31 AM, Dong Xu Wang wrote: > QMP command query-command-line-options shows details information of > parameters, since added def_value_str, also output it in the QMP > command. > > Signed-off-by: Dong Xu Wang > --- > qapi-schema.json | 5 - > qmp-commands.hx| 2 ++ > uti

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Programmingkid
On Jul 10, 2013, at 3:03 PM, Scott Wood wrote: > On 07/09/2013 10:36:37 PM, Programmingkid wrote: >> On Jul 9, 2013, at 1:32 PM, Scott Wood wrote: >> > On 07/04/2013 09:58:04 AM, Programmingkid wrote: >> >> On Jul 4, 2013, at 10:51 AM, Stefan Hajnoczi wrote: >> >> > On Thu, Jul 4, 2013 at 4:45 PM

Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOpts parser

2013-07-10 Thread Eric Blake
On 07/09/2013 02:41 PM, Eric Blake wrote: > On 07/04/2013 06:52 AM, Stefan Hajnoczi wrote: >> On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote: >>> These patches will replace QEMUOptionParameter with QemuOpts. Change logs >>> please go to each patch's commit message. >>> >>> Dong Xu Wan

Re: [Qemu-devel] [PATCH V16 5/7] Use QemuOpts support in block layer

2013-07-10 Thread Eric Blake
On 06/18/2013 03:31 AM, Dong Xu Wang wrote: > This patch uses QemuOpts related functions in block layer, add > a member bdrv_create_opts to BlockDriver struct, it returns > a QemuOptsList pointer, which includes the image format's create > options. > > +++ b/block/cow.c Concluding my review...

Re: [Qemu-devel] [PATCH] exec: Remove unused global variable phys_ram_fd

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v1 1/1] qom: Fix class cast of NULL classes

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/7] Fixes around -machine

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] [PATCH] Extend support of SMBUS(module pm_smbus.c) HST_STS register.

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] q35 chipset: Extend support of SMBUS(module pm_smbus.c) HST_STS register v2.

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] linux-user fixes

2013-07-10 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/1] hw/9pfs: Fix memory leak in error path

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-10 Thread Scott Wood
On 07/09/2013 10:36:37 PM, Programmingkid wrote: On Jul 9, 2013, at 1:32 PM, Scott Wood wrote: > On 07/04/2013 09:58:04 AM, Programmingkid wrote: >> On Jul 4, 2013, at 10:51 AM, Stefan Hajnoczi wrote: >> > On Thu, Jul 4, 2013 at 4:45 PM, Alexander Graf wrote: >> >> >> >> On 04.07.2013, at 1

Re: [Qemu-devel] [PATCH V16 4/7] Create some QemuOpts functons

2013-07-10 Thread Eric Blake
On 06/18/2013 03:31 AM, Dong Xu Wang wrote: > These functions will be used in next commit. > > qemu_opt_get_(*)_del functions are used to make sure we > have the same behaviors as before: in block layer, after > parsing a parameter value, parameter list will delete it > to avoid parsing it twice.

Re: [Qemu-devel] [PATCH RFC qom-cpu] linux-user: Avoid conditional cpu_reset()

2013-07-10 Thread Eduardo Habkost
On Wed, Jul 10, 2013 at 07:51:32PM +0100, Peter Maydell wrote: > On 10 July 2013 19:43, Eduardo Habkost wrote: > > On Wed, Jul 10, 2013 at 06:30:38PM +0200, Andreas Färber wrote: > >> Some CPUs reset as part of cpu_init(), some others were reset > >> afterwards, some not at all. While some targets

Re: [Qemu-devel] [PATCH RFC qom-cpu] linux-user: Avoid conditional cpu_reset()

2013-07-10 Thread Eduardo Habkost
On Wed, Jul 10, 2013 at 06:30:38PM +0200, Andreas Färber wrote: > Some CPUs reset as part of cpu_init(), some others were reset > afterwards, some not at all. While some targets didn't implement a > cpu_[state_]reset() function, QOM cpu_reset() is always available. > There's nothing wrong with rese

Re: [Qemu-devel] [PATCH RFC qom-cpu] linux-user: Avoid conditional cpu_reset()

2013-07-10 Thread Peter Maydell
On 10 July 2013 19:43, Eduardo Habkost wrote: > On Wed, Jul 10, 2013 at 06:30:38PM +0200, Andreas Färber wrote: >> Some CPUs reset as part of cpu_init(), some others were reset >> afterwards, some not at all. While some targets didn't implement a >> cpu_[state_]reset() function, QOM cpu_reset() is

[Qemu-devel] [PULL 4/6] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

2013-07-10 Thread Luiz Capitulino
From: Kevin Wolf We don't have to duplicate the definition any more now that we may refer to a type instead. Signed-off-by: Kevin Wolf Reviewed-by: Michael Roth Signed-off-by: Luiz Capitulino --- qapi-schema.json | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --g

[Qemu-devel] [PULL 3/6] qapi.py: Allow top-level type reference for command definitions

2013-07-10 Thread Luiz Capitulino
From: Kevin Wolf If 'data' for a command definition isn't a dict, but a string, it is taken as a (struct) type name and the fields of this struct are directly used as parameters. This is useful for transactionable commands that can use the same type definition for both the transaction action and

Re: [Qemu-devel] [PATCH V16 5/7] Use QemuOpts support in block layer

2013-07-10 Thread Eric Blake
On 06/18/2013 03:31 AM, Dong Xu Wang wrote: > This patch uses QemuOpts related functions in block layer, add > a member bdrv_create_opts to BlockDriver struct, it returns > a QemuOptsList pointer, which includes the image format's create > options. > > And create options's primary consumer is bloc

[Qemu-devel] [PULL 6/6] add timestamp to error_report()

2013-07-10 Thread Luiz Capitulino
From: Seiji Aguchi [Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand the problem by comparing what the customer reports with message logs of the customer's system. In this case, we often need to know when the problem happens. But

[Qemu-devel] [PULL 5/6] qapi-schema: Use existing type for drive-backup arguments

2013-07-10 Thread Luiz Capitulino
From: Kevin Wolf This removes duplicated definitions and documentation by reusing the existing data type. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qapi-schema.json | 32 ++-- 1 file changed, 2 insertions(+), 30 deletions

[Qemu-devel] [PULL 1/6] qemu-char: Fix ringbuf option size

2013-07-10 Thread Luiz Capitulino
From: Markus Armbruster Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER" assertion. Broken in commit 1da48c65. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qemu-char.c | 2 +- 1 file changed, 1 inse

[Qemu-devel] [PULL 0/6] QMP queue

2013-07-10 Thread Luiz Capitulino
The following changes since commit 51455c59ddc370612f6e070d8eb0e594aaa7ef24: Merge remote-tracking branch 'afaerber/tags/qom-cpu-for-anthony' into staging (2013-07-10 10:54:16 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch

[Qemu-devel] [PULL 2/6] qapi.py: Avoid code duplication

2013-07-10 Thread Luiz Capitulino
From: Kevin Wolf The code that interprets the read JSON expression and appends types to the respective global variables was duplicated. We can avoid that by splitting off the part that reads from the file. Signed-off-by: Kevin Wolf Reviewed-by: Michael Roth Signed-off-by: Luiz Capitulino ---

Re: [Qemu-devel] [PATCH 1/2] Add be16_to_cpupu function

2013-07-10 Thread Peter Maydell
On 10 July 2013 18:10, Fabien Chouteau wrote: > --- a/include/qemu/bswap.h > +++ b/include/qemu/bswap.h > @@ -432,6 +432,11 @@ static inline uint32_t le32_to_cpupu(const uint32_t *p) > return ldl_le_p(p); > } > > +static inline uint16_t be16_to_cpupu(const uint16_t *p) > +{ > +return ldu

Re: [Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file chain

2013-07-10 Thread Eric Blake
On 07/10/2013 05:42 AM, Kevin Wolf wrote: >> Thanks for the series. I made a few comments on each patch. You hashed >> windows full path to get the "inode", but case sensitively, would that >> work with the same files of different case? > > I seem to remember that Windows can be made case-sensitiv

[Qemu-devel] [PATCH 1/2] Add be16_to_cpupu function

2013-07-10 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- include/qemu/bswap.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index 14a5f65..628f41f 100644 --- a/include/qemu/bswap.h +++ b/include/qemu/bswap.h @@ -432,6 +432,11 @@ static inline uint32_t le32_to_

[Qemu-devel] [PATCH 0/2] Enhanced Three Speed Ethernet Controller (eTSEC)

2013-07-10 Thread Fabien Chouteau
I know it will be difficult to get this patch in the mainstream version, but Alex already told me that some people here may have interest in eTSEC so I thought I could just send it so everyone can have a look. It has been tested with vxWorks and vxWorks only. I have no idea if it will work with l

Re: [Qemu-devel] [PATCH] block: Don't parse protocol from file.filename

2013-07-10 Thread Eric Blake
On 07/10/2013 07:51 AM, Kevin Wolf wrote: > One of the major reasons for doing something new for -blockdev and > blockdev-add was that the old block layer code parses filenames instead > of just taking them literally. So we should really leave it untouched > when it's passing using the new interfac

Re: [Qemu-devel] [PULL] virtio-ccw build fix

2013-07-10 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] MAINTAINERS: fix bad F: patterns

2013-07-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

  1   2   3   >