Re: [Qemu-devel] [PATCH V4 3/4] Add backing drive while performing backup.

2013-07-17 Thread Fam Zheng
On Wed, 07/17 13:04, Ian Main wrote: > This patch adds the original source drive as a backing drive to our target > image so that the target image will appear complete during backup. This > is especially useful for SYNC_MODE_NONE as it allows export via NBD to > have a complete point-in-time snaps

Re: [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements

2013-07-17 Thread Stefan Hajnoczi
On Thu, Jul 11, 2013 at 02:16:17PM +0200, Peter Lieven wrote: > this series adds logical block provisioning functions to the iscsi layer. > it also is the first step to the change of migration to coroutines in > block/iscsi. > > the changes to qemu-img and block migration have been split and will

Re: [Qemu-devel] [PATCH v8 0/3] Throttle-down guest to help with live migration convergence

2013-07-17 Thread Peter Lieven
Hi all, is it possible that not v8 of this patch got merged? Without checking line-by-line I see at least that this here +# @auto-converge: If enabled, QEMU will automatically throttle down the guest +# to speed up convergence of RAM migration. (since 1.6) +# is missing in qapi-schema.

Re: [Qemu-devel] [PATCHv3] block-migration: efficiently encode zero blocks

2013-07-17 Thread Peter Lieven
On 18.07.2013 07:03, Stefan Hajnoczi wrote: On Mon, Jul 15, 2013 at 12:55:05PM +0200, Peter Lieven wrote: @@ -114,16 +115,29 @@ static void blk_mig_unlock(void) static void blk_send(QEMUFile *f, BlkMigBlock * blk) { int len; +uint64_t flags = BLK_MIG_FLAG_DEVICE_BLOCK; + +if (m

Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target

2013-07-17 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:57:37PM +0800, Fam Zheng wrote: > s->qcow and s->qcow_filename are allocated but not freed on error. Fix the > possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of > bdrv_create() and also the one of enable_write_target(). > > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd

2013-07-17 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 10:03:51PM +0800, Wenchao Xia wrote: > This series allow user to read internal snapshot's contents without qemu-img > convert. Another purpose is that, when qemu is online and have taken an > internal snapshot, let user invoke qemu-nbd to do any thing on it except > write.

Re: [Qemu-devel] [PATCH V3 6/7] block: Add backing file loop check in qcow2_change_backing_file()

2013-07-17 Thread Fam Zheng
On Mon, 07/15 05:42, Xu Wang wrote: > Add backing file loop check before execute change backing file for > qcow2 format. > > Signed-off-by: Xu Wang > --- > block/qcow2.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 0eceefe..01bd7d5 100644

Re: [Qemu-devel] [PATCH V3 5/7] block: Add infinite loop check in drive_init()

2013-07-17 Thread Fam Zheng
On Mon, 07/15 05:42, Xu Wang wrote: > Backing file should be checked if there is a loop in it during image > boot. Becase if there is loop qemu would no response for a long time > and segment fault occured. So this patch would check backing file > chain if there is loop in it before open image. >

Re: [Qemu-devel] [PATCH V3 2/7] block: Add WIN32 platform support for backing_file_loop_check()

2013-07-17 Thread Fam Zheng
On Mon, 07/15 05:42, Xu Wang wrote: > Method of get_inode is different between Linux and WIN32 plateform. > This patch added inode caculate method on Windows plateform so that > backing file check could work on Windows plateform. > > Signed-off-by: Xu Wang > --- > block.c | 109 > ++

Re: [Qemu-devel] [PATCH V3 1/7] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-07-17 Thread Fam Zheng
On Mon, 07/15 05:42, Xu Wang wrote: > If there is a loop exists in the backing file chain, many problems > could be caused by it, such as no response and segment fault during > system boot. Hence stopping backing file loop appear is very necessary. > This patch refine and export loop checking funct

Re: [Qemu-devel] [PATCH v6] QEMUBH: make AioContext's bh re-entrant

2013-07-17 Thread Stefan Hajnoczi
On Tue, Jul 16, 2013 at 12:28:58PM +0800, Liu Ping Fan wrote: > BH will be used outside big lock, so introduce lock to protect > between the writers, ie, bh's adders and deleter. The lock only > affects the writers and bh's callback does not take this extra lock. > Note that for the same AioContext

Re: [Qemu-devel] [PATCHv3] block-migration: efficiently encode zero blocks

2013-07-17 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 12:55:05PM +0200, Peter Lieven wrote: > @@ -114,16 +115,29 @@ static void blk_mig_unlock(void) > static void blk_send(QEMUFile *f, BlkMigBlock * blk) > { > int len; > +uint64_t flags = BLK_MIG_FLAG_DEVICE_BLOCK; > + > +if (migrate_zero_blocks() && buffer_is_ze

Re: [Qemu-devel] [PATCH V3 0/7] Redefine and export backing file loop check

2013-07-17 Thread Fam Zheng
On Mon, 07/15 05:42, Xu Wang wrote: > If there is loop exists in the backing file chain, many problems > could be caused by it, such as no response and segment fault during > system boot. Hence stopping backing file loop appear is very necessary. > These patches refine and export loop checking func

Re: [Qemu-devel] [PATCH v2 01/11] block: replace in_use with refcnt_soft and refcnt_hard

2013-07-17 Thread Fam Zheng
On Wed, 07/17 14:26, Paolo Bonzini wrote: > Il 17/07/2013 11:42, Fam Zheng ha scritto: > > Introduce refcnt_soft (soft reference) and refcnt_hard (hard reference) > > to BlockDriverState, since in_use mechanism cannot provide proper > > management of lifecycle when a BDS is referenced in multiple p

[Qemu-devel] Introducing Virgil - 3D virtual GPU for qemu

2013-07-17 Thread Dave Airlie
Hey Mesa + qemu lists, since I suppose these communities would be most interested in this and might not all read my blog or G+ stream, "Virgil is a research project I've been working on at Red Hat for a few months now and I think is ready for at least announcing upstream and seeing if there is an

Re: [Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup'

2013-07-17 Thread Fam Zheng
On Wed, 07/17 06:44, Eric Blake wrote: > On 07/17/2013 03:42 AM, Fam Zheng wrote: > > Similar to drive-backup, but this command uses a device id as target > > instead of creating/opening an image file. > > > > Signed-off-by: Fam Zheng > > --- > > blockdev.c | 71 > > ++

Re: [Qemu-devel] [PATCH 0/3] qemu-timer: make QEMUTimer functions thread-safe

2013-07-17 Thread Stefan Hajnoczi
On Fri, Jul 05, 2013 at 02:39:43PM +0200, Stefan Hajnoczi wrote: > This series makes the following functions thread-safe: > > qemu_mod_timer_ns() > qemu_mod_timer() > qemu_del_timer() > qemu_timer_pending() > > The following were already thread-safe: > > qemu_free_timer() > qemu_new_

Re: [Qemu-devel] [PATCH 00/17] Add qemu-img subcommand to dump file metadata

2013-07-17 Thread Stefan Hajnoczi
On Tue, Jul 16, 2013 at 08:49:13AM +0200, Peter Lieven wrote: > On 16.07.2013 05:41, Stefan Hajnoczi wrote: > >On Wed, Jul 03, 2013 at 04:34:14PM +0200, Paolo Bonzini wrote: > >>This series adds a subcommand to "map" that can dump file metadata. > >>Metadata that is dumped includes: > >> > >>- whet

[Qemu-devel] [PULL 5/5] trace-events: Fix up source file comments

2013-07-17 Thread Stefan Hajnoczi
From: Markus Armbruster They're all wrong since (at least) Paolo's big source tree reorganization. Need to shuffle some event declarations around to keep them under the correct source file comment. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- trace-events | 162 +++

[Qemu-devel] [PULL 4/5] trace-events: Drop unused events

2013-07-17 Thread Stefan Hajnoczi
From: Markus Armbruster Dropped event Unused since mirror_cow 884fea4 paio_complete 47e6b25 paio_cancel 47e6b25 usb_ehci_data 0ce668b megasas_qf_dequeue

[Qemu-devel] [PULL 3/5] milkymist-minimac2: Fix minimac2_read/_write tracepoints

2013-07-17 Thread Stefan Hajnoczi
From: Markus Armbruster Broken in milkymist-minimac.c from the start (commit 0742454), faithfully moved to milkymist-minimac2.c (commit 57aa265). Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- hw/net/milkymist-minimac2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[Qemu-devel] [PULL 1/5] cleanup-trace-events.pl: New

2013-07-17 Thread Stefan Hajnoczi
From: Markus Armbruster Simple script to drop unused events and fix up source file comments. The next few commits put it to use. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- scripts/cleanup-trace-events.pl | 51 + 1 file changed,

[Qemu-devel] [PULL 0/5] Tracing patches

2013-07-17 Thread Stefan Hajnoczi
The following changes since commit 6453a3a69488196f26d12654c6b148446abdf3d6: Merge remote-tracking branch 'quintela/migration.next' into staging (2013-07-15 14:49:16 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git tracing for you to fetch changes up to 3b

[Qemu-devel] [PULL 2/5] slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints

2013-07-17 Thread Stefan Hajnoczi
From: Markus Armbruster Broken since they got added in commit 97bf485. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- hw/misc/slavio_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/slavio_misc.c b/hw/misc/slavio_misc.c index d274fb4..00d

Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd

2013-07-17 Thread Wenchao Xia
于 2013-7-17 23:21, Kevin Wolf 写道: Am 17.07.2013 um 16:23 hat Eric Blake geschrieben: On 07/17/2013 08:03 AM, Wenchao Xia wrote: This series allow user to read internal snapshot's contents without qemu-img convert. Another purpose is that, when qemu is online and have taken an internal snapshot,

Re: [Qemu-devel] [PATCH V6 08/13] monitor: refine parse_cmdline()

2013-07-17 Thread Wenchao Xia
于 2013-7-18 3:39, Luiz Capitulino 写道: On Thu, 11 Jul 2013 11:13:44 +0800 Wenchao Xia wrote: Since this function will be used by help_cmd() later, so improve it to make it more generic and easier to use. free_cmdline_args() is added to as paired function to free the result. Signed-off-by: Wenc

Re: [Qemu-devel] [PATCH V6 05/13] monitor: avoid use of global *cur_mon in readline_completion()

2013-07-17 Thread Wenchao Xia
于 2013-7-18 3:34, Luiz Capitulino 写道: On Thu, 11 Jul 2013 11:13:41 +0800 Wenchao Xia wrote: Now all completion functions do not use *cur_mon any more, instead they use rs->mon. In short, structure ReadLineState decide where the complete action would be taken now. Tested with the case that qem

Re: [Qemu-devel] How does the shell/os know to use qemu to launch a program?

2013-07-17 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 02:41:24PM -0700, Corbin Champion wrote: > I have used qemu for some time. I am curious how the shell or os detects > that qemu is needed to run a program? > > The reason for this is as follows: > I am on a system, but am not root. The system does not have qemu installed

Re: [Qemu-devel] [Bug 1186303] [NEW] virtual fat do not working in qemu 1.5.0

2013-07-17 Thread Stefan Hajnoczi
On Fri, May 31, 2013 at 03:26:47PM -, prochazka nicolas wrote: > Public bug reported: > > Guest : windows Seven / XP > Qemu version : 1.5.0 > cmd line : > -drive > file=fat:floppy:/mnt/vdisk/diskconf/TEST004/,if=none,id=drive-fdc0-0-0,readonly=on > > generated by libvirt : > > >

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-17 Thread Ed Maste
On 8 July 2013 11:15, Ed Maste wrote: > > Ok, as soon as I can get a password (after the buildbot disk space > issues are sorted out) I'll contribute a FreeBSD 9 amd64 builder. It seems the disk space / inode issue is resolved; is there anything further still in the way of adding a FreeBSD builde

[Qemu-devel] [PULL 1/2] vfio-pci: VGA quirk update

2013-07-17 Thread Alex Williamson
Turns out all the suspicions for AMD devices were correct, everywhere we read a BAR address that the address matches the config space offset, there's full access to PCI config space. Attempt to generalize some helpers to allow quirks to easily be added for mirrors and windows. Also fill in complet

[Qemu-devel] [PULL 0/2] VFIO for qemu-1.6

2013-07-17 Thread Alex Williamson
Hi Anthony, The following changes since commit c3cb8e77804313e1be99b5f28a34a346736707a5: ioport: remove LITTLE_ENDIAN mark for portio (2013-07-12 14:37:47 -0500) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-for-qemu-1.6 for you to fetch changes

[Qemu-devel] [PULL 2/2] vfio: QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-07-17 Thread Alex Williamson
From: Vijay Mohan Pandarathil Add support for error containment when a VFIO device assigned to a KVM guest encounters an error. This is for PCIe devices/drivers that support AER functionality. When the host OS is notified of an error in a device either through the firmware first approach or throu

[Qemu-devel] How does the shell/os know to use qemu to launch a program?

2013-07-17 Thread Corbin Champion
I have used qemu for some time. I am curious how the shell or os detects that qemu is needed to run a program? The reason for this is as follows: I am on a system, but am not root. The system does not have qemu installed by root, and it will not be, but I have downloaded it myself. I can run pr

Re: [Qemu-devel] [PATCH] fix guest physical bits to match host, to go beyond 1TB guests

2013-07-17 Thread Eduardo Habkost
On Wed, Jul 17, 2013 at 06:19:28PM +0300, Gleb Natapov wrote: > On Tue, Jul 16, 2013 at 04:42:38PM -0300, Eduardo Habkost wrote: > > On Tue, Jul 16, 2013 at 09:24:30PM +0200, Paolo Bonzini wrote: > > > Il 16/07/2013 20:11, Eduardo Habkost ha scritto: > > > > For physical bit size, what about extend

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-17 Thread Scott Wood
On 07/17/2013 05:17:06 AM, Fabien Chouteau wrote: On 07/16/2013 07:50 PM, Scott Wood wrote: > On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: >> On 07/16/2013 04:06 AM, Scott Wood wrote: >> > On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: >> >> +if (*size == etsec->rx_padding) { >> >> +

Re: [Qemu-devel] QEMU Memory subsystem

2013-07-17 Thread Yaohui
Hi Basim, Have you solved the problem yet? I am very curious about the result. Best Wishes, Yaohui Hu

[Qemu-devel] [Bug 1202289] [NEW] Windows 2008/7 Guest to Guest Very slow 10-20Mbit/s

2013-07-17 Thread Mike Nielsen
Public bug reported: I'm not sure if I'm submitting this to the proper place or not, if not, please direct me accordingly. At this point I'm starting to get desperate, I'll take any options or suggestions that spring to mind: Anyway, the problem exists on multiple hosts of various quality. Fro

[Qemu-devel] [PULL 1/2] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-17 Thread Luiz Capitulino
In qmp-marshal.c the dealloc visitor calls use the same errp pointer of the input visitor calls. This means that if any of the input visitor calls fails, then the dealloc visitor will return early, before freeing the object's memory. Here's an example, consider this code: int qmp_marshal_input_bl

[Qemu-devel] [PULL 2/2] qmp: update send-key document

2013-07-17 Thread Luiz Capitulino
From: Amos Kong commit 9f328977 changes qmp_send_key() to accept key codes in hex, but the document wasn't updated. The items of keys list is union now, not enum. Signed-off-by: Amos Kong Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qmp-commands.hx | 7 +-- 1 file changed,

[Qemu-devel] [PULL 0/2] QMP queue

2013-07-17 Thread Luiz Capitulino
The following changes since commit 6453a3a69488196f26d12654c6b148446abdf3d6: Merge remote-tracking branch 'quintela/migration.next' into staging (2013-07-15 14:49:16 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-17 Thread Luiz Capitulino
On Tue, 16 Jul 2013 18:37:42 +0800 Amos Kong wrote: > Introduces new monitor command to query QMP schema information, > the return data is a dynamical and nested dict/list, it contains > the useful metadata to help management to check feature support, > QMP commands detail, etc. > > I added a do

Re: [Qemu-devel] [PATCH 4/7] smbios: Make multiple -smbios type= accumulate sanely

2013-07-17 Thread Markus Armbruster
Eric Blake writes: > On 07/17/2013 11:16 AM, Markus Armbruster wrote: >> Currently, -smbios type=T,NAME=VAL,... adds one field (T,NAME) with >> value VAL to fw_cfg for each unique NAME. If NAME occurs multiple >> times, the last one's VAL is used (before the QemuOpts conversion, the >> first one

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 19:48, Peter Lieven ha scritto: > > Am 17.07.2013 um 19:04 schrieb Paolo Bonzini : > >> Il 17/07/2013 19:02, Peter Lieven ha scritto: >>> For Disks we always use read/write16 so i think we Should also use >>> writesame16. Or not? >> >> Yes. >> >> Remember you can still use UNMAP if

Re: [Qemu-devel] Possibility of unaligned DMA accesses via the QEMU DMA API?

2013-07-17 Thread Mark Cave-Ayland
On 17/07/13 14:35, Kevin Wolf wrote: Okay, so I've had a quick look at that DMA controller, and it seems that for a complete emulation, there's no way around using a bounce buffer (and calling directly into the block layer instead of using dma-helpers.c) for the general case. You can have a fas

Re: [Qemu-devel] [PATCH v2 1/2] qapi: change qapi to convert schema json

2013-07-17 Thread Luiz Capitulino
On Tue, 16 Jul 2013 18:37:41 +0800 Amos Kong wrote: > QMP schema is defined in a json file, it will be parsed by > qapi scripts and generate C files. > > We want to return the schema information to management, > this patch converts the json file to a string table in a > C head file, then we can

Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw

2013-07-17 Thread Richard Henderson
On 07/17/2013 12:56 PM, Paolo Bonzini wrote: > It is: > > cpu_outb > -> address_space_write > -> address_space_rw > -> io_mem_write > -> memory_region_dispatch_write > -> access_with_adjusted_size > > memory_access_size is just returning a length that makes sense when > passed to io_mem_write and

[Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-17 Thread Ian Main
qcow2 supports backing files so it makes sense to default to qcow2 for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE breaks tests but that could be fixed if we wanted it. Signed-off-by: Ian Main --- blockd

[Qemu-devel] [PATCH V4 0/4] Implement sync modes for drive-backup.

2013-07-17 Thread Ian Main
This patch adds sync modes on top of the work that Stefan Hajnoczi has done. These patches apply on kevin/block with '[PATCH] block: add drive_backup HMP command' also applied. Hopefully all is in order as this is my first QEMU patch. Many thanks to Stephan and Fam Zheng for their help. V2:

[Qemu-devel] [PATCH V4 1/4] Implement sync modes for drive-backup.

2013-07-17 Thread Ian Main
This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive. TOP copies change

[Qemu-devel] [PATCH V4 3/4] Add backing drive while performing backup.

2013-07-17 Thread Ian Main
This patch adds the original source drive as a backing drive to our target image so that the target image will appear complete during backup. This is especially useful for SYNC_MODE_NONE as it allows export via NBD to have a complete point-in-time snapshot available for export. Signed-off-by: Ian

[Qemu-devel] [PATCH V4 2/4] Add tests for sync modes 'TOP' and 'NONE'

2013-07-17 Thread Ian Main
This patch adds tests for sync modes top and none. Signed-off-by: Ian Main --- tests/qemu-iotests/055| 67 --- tests/qemu-iotests/055.out| 4 +-- tests/qemu-iotests/group | 2 +- tests/qemu-iotests/iotests.py | 5 4 files changed,

Re: [Qemu-devel] [PATCH] qmp: update send-key document

2013-07-17 Thread Luiz Capitulino
On Tue, 16 Jul 2013 19:52:14 +0800 Amos Kong wrote: > commit 9f328977 changes qmp_send_key() to accept key codes in hex, > but the document wasn't updated. The items of keys list is union > now, not enum. > > Signed-off-by: Amos Kong Applied to the qmp branch, thanks. > --- > qmp-commands.hx

Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 21:28, Richard Henderson ha scritto: > On 07/17/2013 11:57 AM, Paolo Bonzini wrote: >> I'm still not sure what the bug is (so what the FIXME comment would >> be)... except of course that there may be bug in access_with_adjusted_size. > > The code here in exec.c is not using access_wi

Re: [Qemu-devel] [PATCH V6 08/13] monitor: refine parse_cmdline()

2013-07-17 Thread Luiz Capitulino
On Thu, 11 Jul 2013 11:13:44 +0800 Wenchao Xia wrote: > Since this function will be used by help_cmd() later, so improve > it to make it more generic and easier to use. free_cmdline_args() > is added to as paired function to free the result. > > Signed-off-by: Wenchao Xia > --- > monitor.c |

Re: [Qemu-devel] [PATCH V6 05/13] monitor: avoid use of global *cur_mon in readline_completion()

2013-07-17 Thread Luiz Capitulino
On Thu, 11 Jul 2013 11:13:41 +0800 Wenchao Xia wrote: > Now all completion functions do not use *cur_mon any more, instead > they use rs->mon. In short, structure ReadLineState decide where > the complete action would be taken now. > > Tested with the case that qemu have two telnet monitors, aut

Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw

2013-07-17 Thread Richard Henderson
On 07/17/2013 11:57 AM, Paolo Bonzini wrote: > I'm still not sure what the bug is (so what the FIXME comment would > be)... except of course that there may be bug in access_with_adjusted_size. The code here in exec.c is not using access_with_adjusted_size. Unfortunately, access_with_adjusted_size

Re: [Qemu-devel] [PATCH 7/7] smbios: Set system manufacturer, product & version by default

2013-07-17 Thread Eric Blake
On 07/17/2013 11:16 AM, Markus Armbruster wrote: > Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, > no version. Best SeaBIOS can do, but we can provide better defaults: > manufacturer QEMU, product & version taken from QEMUMachine desc and > name. > > Take care to do this

Re: [Qemu-devel] [PATCH 6/7] vl: Set current_machine early

2013-07-17 Thread Eric Blake
On 07/17/2013 11:16 AM, Markus Armbruster wrote: > I'd like to access QEMUMachine from a QEMUMachine init() method, which > is currently not possible. Instead of passing it as an argument, I > simply set current_machine earlier. > > Signed-off-by: Markus Armbruster > --- > vl.c | 3 +-- > 1 fil

Re: [Qemu-devel] [PATCH 5/7] smbios: Factor out smbios_maybe_add_str()

2013-07-17 Thread Eric Blake
On 07/17/2013 11:16 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/i386/smbios.c | 61 > +++- > 1 file changed, 25 insertions(+), 36 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-91

Re: [Qemu-devel] [PATCH 4/7] smbios: Make multiple -smbios type= accumulate sanely

2013-07-17 Thread Eric Blake
On 07/17/2013 11:16 AM, Markus Armbruster wrote: > Currently, -smbios type=T,NAME=VAL,... adds one field (T,NAME) with > value VAL to fw_cfg for each unique NAME. If NAME occurs multiple > times, the last one's VAL is used (before the QemuOpts conversion, the > first one was used). > > Multiple -

Re: [Qemu-devel] [PATCH 3/7] smbios: Improve diagnostics for conflicting entries

2013-07-17 Thread Eric Blake
On 07/17/2013 11:16 AM, Markus Armbruster wrote: > We allow either tables or fields for the same type. Makes sense, > because SeaBIOS uses fields only when no tables are present. > > We do this by searching the SMBIOS blob for a previously added table > or field. Error messages look like this: >

Re: [Qemu-devel] [PATCH 2/7] smbios: Convert to QemuOpts

2013-07-17 Thread Eric Blake
On 07/17/2013 11:16 AM, Markus Armbruster wrote: > So that it can be set in config file for -readconfig. > > This tightens parsing of -smbios, and makes it more consistent with > other options: unknown parameters are rejected, numbers with trailing > junk are rejected, when a parameter is given mu

Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 20:26, Richard Henderson ha scritto: > On 07/17/2013 10:32 AM, Paolo Bonzini wrote: >> My patch works. > > You patch doesn't crash for this device, which isn't quite the same thing. > > But it's certainly no worse than we had before my patch, so I'll not object so > long as a fixme

Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw

2013-07-17 Thread Anthony Liguori
Paolo Bonzini writes: > Il 17/07/2013 17:50, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 17/07/2013 11:50, Markus Armbruster ha scritto: Richard Henderson writes: > Honor the implementation maximum access size, and at least check > the minimum access size.

Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw

2013-07-17 Thread Richard Henderson
On 07/17/2013 10:32 AM, Paolo Bonzini wrote: > My patch works. You patch doesn't crash for this device, which isn't quite the same thing. But it's certainly no worse than we had before my patch, so I'll not object so long as a fixme sort of comment is installed too. r~

Re: [Qemu-devel] [PATCH 1/7] smbios: Normalize smbios_entry_add()'s error handling to exit(1)

2013-07-17 Thread Eric Blake
On 07/17/2013 11:16 AM, Markus Armbruster wrote: > It exits on all error conditions but one, where it returns -1. > Normalize, and return void. > > Signed-off-by: Markus Armbruster > --- > arch_init.c | 4 +--- > hw/i386/smbios.c | 10 +- > include/hw/i386/smbios.h

Re: [Qemu-devel] [PATCH v2 13/17] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO

2013-07-17 Thread Peter Lieven
We should change this when bdi->discard_zeroes is available. Peter Am 16.07.2013 um 18:29 schrieb Paolo Bonzini : > Alternatively, this could use a "discard zeroes data" flag returned > by bdrv_get_info. > > Signed-off-by: Paolo Bonzini > --- > block.c | 8 +++- > 1 file changed, 7 insertio

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 17.07.2013 um 19:04 schrieb Paolo Bonzini : > Il 17/07/2013 19:02, Peter Lieven ha scritto: >> For Disks we always use read/write16 so i think we Should also use >> writesame16. Or not? > > Yes. > > Remember you can still use UNMAP if LBPRZ=0. I can always use it if writesame is not availa

Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 17:50, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 17/07/2013 11:50, Markus Armbruster ha scritto: >>> Richard Henderson writes: >>> Honor the implementation maximum access size, and at least check the minimum access size. Reviewed-by: Paolo Bonz

Re: [Qemu-devel] [PATCH] linux-user: Handle microMIPS encoding when processing trap exceptions

2013-07-17 Thread Peter Maydell
On 17 July 2013 17:50, Kwok Cheung Yeung wrote: > Decode trap instructions during the handling of a EXCP_TRAP according to > the current ISA mode. > > Signed-off-by: Kwok Cheung Yeung > --- > linux-user/main.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/linux-use

[Qemu-devel] [PATCH 4/7] smbios: Make multiple -smbios type= accumulate sanely

2013-07-17 Thread Markus Armbruster
Currently, -smbios type=T,NAME=VAL,... adds one field (T,NAME) with value VAL to fw_cfg for each unique NAME. If NAME occurs multiple times, the last one's VAL is used (before the QemuOpts conversion, the first one was used). Multiple -smbios can add multiple fields with the same (T, NAME). SeaBI

[Qemu-devel] [PATCH 2/7] smbios: Convert to QemuOpts

2013-07-17 Thread Markus Armbruster
So that it can be set in config file for -readconfig. This tightens parsing of -smbios, and makes it more consistent with other options: unknown parameters are rejected, numbers with trailing junk are rejected, when a parameter is given multiple times, last rather than first wins, ... Signed-off-

[Qemu-devel] [PATCH 7/7] smbios: Set system manufacturer, product & version by default

2013-07-17 Thread Markus Armbruster
Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, no version. Best SeaBIOS can do, but we can provide better defaults: manufacturer QEMU, product & version taken from QEMUMachine desc and name. Take care to do this only for new machine types, of course. Signed-off-by: Markus

[Qemu-devel] [PATCH 5/7] smbios: Factor out smbios_maybe_add_str()

2013-07-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/i386/smbios.c | 61 +++- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index fb1b27b..a2eb9bf 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 17.07.2013 um 17:12 schrieb Kevin Wolf : > Am 17.07.2013 um 16:53 hat Paolo Bonzini geschrieben: >> Il 17/07/2013 16:46, Peter Lieven ha scritto: >>> >>> Am 17.07.2013 um 16:26 schrieb Paolo Bonzini : >>> Il 17/07/2013 16:18, Peter Lieven ha scritto: > That would be ok if the p

[Qemu-devel] [PATCH 1/7] smbios: Normalize smbios_entry_add()'s error handling to exit(1)

2013-07-17 Thread Markus Armbruster
It exits on all error conditions but one, where it returns -1. Normalize, and return void. Signed-off-by: Markus Armbruster --- arch_init.c | 4 +--- hw/i386/smbios.c | 10 +- include/hw/i386/smbios.h | 2 +- 3 files changed, 7 insertions(+), 9 deletions(-) diff -

[Qemu-devel] [PATCH 3/7] smbios: Improve diagnostics for conflicting entries

2013-07-17 Thread Markus Armbruster
We allow either tables or fields for the same type. Makes sense, because SeaBIOS uses fields only when no tables are present. We do this by searching the SMBIOS blob for a previously added table or field. Error messages look like this: qemu-system-x86_64: -smbios type=1,serial=42: SMBIOS ty

[Qemu-devel] [PATCH 0/7] smbios cleanup & nicer defaults for type 1

2013-07-17 Thread Markus Armbruster
This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. Markus Armbruster (7): smbios: Normalize smbios_entry_add()'s error handling to exit(

[Qemu-devel] [PATCH 6/7] vl: Set current_machine early

2013-07-17 Thread Markus Armbruster
I'd like to access QEMUMachine from a QEMUMachine init() method, which is currently not possible. Instead of passing it as an argument, I simply set current_machine earlier. Signed-off-by: Markus Armbruster --- vl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vl.c b/vl

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread ronnie sahlberg
On Wed, Jul 17, 2013 at 10:02 AM, Peter Lieven wrote: > For Disks we always use read/write16 so i think we Should also use > writesame16. Or not? Sounds good. > > Von meinem iPhone gesendet > > Am 17.07.2013 um 18:31 schrieb ronnie sahlberg : > >> On Wed, Jul 17, 2013 at 9:27 AM, Paolo Bonzini

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 19:02, Peter Lieven ha scritto: > For Disks we always use read/write16 so i think we Should also use > writesame16. Or not? Yes. Remember you can still use UNMAP if LBPRZ=0. Paolo > Von meinem iPhone gesendet > > Am 17.07.2013 um 18:31 schrieb ronnie sahlberg : > >> On Wed, Jul

Re: [Qemu-devel] [PATCH v3 0/2] Support ramdisks with U-Boot header

2013-07-17 Thread Sören Brinkmann
ping? any comments? Thanks, Sören On Mon, Jul 08, 2013 at 03:40:00PM -0700, Soren Brinkmann wrote: > Sorry, for the delay, but I finally found some time for a follow up. I assume > the asymmety between loading kernels and loading the ramdisk is the blocker > for > this series and

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
For Disks we always use read/write16 so i think we Should also use writesame16. Or not? Von meinem iPhone gesendet Am 17.07.2013 um 18:31 schrieb ronnie sahlberg : > On Wed, Jul 17, 2013 at 9:27 AM, Paolo Bonzini wrote: >> Il 17/07/2013 17:54, ronnie sahlberg ha scritto: >>> I think it is reas

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 17.07.2013 um 16:53 schrieb Paolo Bonzini : > Il 17/07/2013 16:46, Peter Lieven ha scritto: >> >> Am 17.07.2013 um 16:26 schrieb Paolo Bonzini : >> >>> Il 17/07/2013 16:18, Peter Lieven ha scritto: That would be ok if the patches are merged first. Otherwise I could ask Ke

[Qemu-devel] [PATCH] linux-user: Handle microMIPS encoding when processing trap exceptions

2013-07-17 Thread Kwok Cheung Yeung
Decode trap instructions during the handling of a EXCP_TRAP according to the current ISA mode. Signed-off-by: Kwok Cheung Yeung --- linux-user/main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index 7f15d3d..c417e26 100644 --- a/

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread ronnie sahlberg
On Wed, Jul 17, 2013 at 9:27 AM, Paolo Bonzini wrote: > Il 17/07/2013 17:54, ronnie sahlberg ha scritto: >> I think it is reasonable to assume that IF LBPRZ==1 and IF it is an >> "optimal unmap request" then the blocks will become unmapped and they >> will read back as 0. > > Yes, but it is not re

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 17:54, ronnie sahlberg ha scritto: > I think it is reasonable to assume that IF LBPRZ==1 and IF it is an > "optimal unmap request" then the blocks will become unmapped and they > will read back as 0. Yes, but it is not reasonable to assume that bdrv_discard will only receive "optimal

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-17 Thread Alex Bligh
Paolo, --On 17 July 2013 10:11:07 +0200 Paolo Bonzini wrote: The steps to achieving this: 1. Drop alarm timers from qemu-timer.c and calculate g_poll() timeout instead for the main loop. 2. Introduce a per-AioContext aio_ctx_clock that can be used with qemu_new_timer() to create a QEMU

Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 17:45, Laszlo Ersek ha scritto: >> Yes, though I guess Wanlong could do this by himself. A more >> interesting prototype is "how to add code to OptsVisitor that parses >> intervals when it sees ['int']", and this where you can help the most. > > Do you want each element of the range

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread ronnie sahlberg
On Wed, Jul 17, 2013 at 3:25 AM, Kevin Wolf wrote: > Am 17.07.2013 um 11:58 hat Paolo Bonzini geschrieben: >> Il 17/07/2013 10:46, Kevin Wolf ha scritto: >> > Am 15.07.2013 um 12:49 hat Peter Lieven geschrieben: >> >> if a destination has has_zero_init = 0, but it supports >> >> discard zeroes use

Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw

2013-07-17 Thread Anthony Liguori
Paolo Bonzini writes: > Il 17/07/2013 11:50, Markus Armbruster ha scritto: >> Richard Henderson writes: >> >>> Honor the implementation maximum access size, and at least check >>> the minimum access size. >>> >>> Reviewed-by: Paolo Bonzini >>> Signed-off-by: Richard Henderson >> >> Fails for

Re: [Qemu-devel] [PATCH v2 repost 8/9] i386: generate pc guest info

2013-07-17 Thread Laszlo Ersek
On 07/10/13 15:51, Michael S. Tsirkin wrote: > This fills in guest info table with misc > information of interest to the guest. > Will be used by ACPI table generation code. > > Signed-off-by: Michael S. Tsirkin > --- > hw/acpi/ich9.c | 7 ++- > hw/acpi/piix4.c| 44 +

Re: [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements

2013-07-17 Thread Paolo Bonzini
Il 11/07/2013 14:16, Peter Lieven ha scritto: > this series adds logical block provisioning functions to the iscsi layer. > it also is the first step to the change of migration to coroutines in > block/iscsi. > > the changes to qemu-img and block migration have been split and will > follow in sepa

[Qemu-devel] [PULL 5/5] iscsi: factor out sector conversions

2013-07-17 Thread Paolo Bonzini
From: Peter Lieven Reviewed-by: Kevin Wolf Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 1294fdf..5f28c6a 100644 --- a/block/iscsi.c +++ b/block/iscs

Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-07-17 Thread Laszlo Ersek
On 07/17/13 17:26, Paolo Bonzini wrote: > Il 17/07/2013 17:24, Laszlo Ersek ha scritto: >> On 07/17/13 16:44, Paolo Bonzini wrote: >>> Il 17/07/2013 16:33, Laszlo Ersek ha scritto: opts-visitor can handle lists of simple scalar types. Ie. it can do -numa node,nodeid=3,cpus=3-4,cpu

Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options

2013-07-17 Thread Kevin Wolf
Am 17.07.2013 um 16:16 hat Paolo Bonzini geschrieben: > Il 17/07/2013 15:48, Kevin Wolf ha scritto: > >> I understand this is the right thing to do long term, but pre-opening of > >> the target is not really needed for fleecing. > > > > So for how much longer should we plan to procrastinate? (I kn

Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 17:24, Laszlo Ersek ha scritto: > On 07/17/13 16:44, Paolo Bonzini wrote: >> Il 17/07/2013 16:33, Laszlo Ersek ha scritto: >>> opts-visitor can handle lists of simple scalar types. Ie. it can do >>> -numa node,nodeid=3,cpus=3-4,cpus=9-10. It can't save the parsing of >>> i

Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 17:09, Kevin Wolf ha scritto: > Am 17.07.2013 um 16:16 hat Paolo Bonzini geschrieben: >> Il 17/07/2013 15:48, Kevin Wolf ha scritto: I understand this is the right thing to do long term, but pre-opening of the target is not really needed for fleecing. >>> >>> So for how much

Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-07-17 Thread Laszlo Ersek
On 07/17/13 16:44, Paolo Bonzini wrote: > Il 17/07/2013 16:33, Laszlo Ersek ha scritto: >> opts-visitor can handle lists of simple scalar types. Ie. it can do >> -numa node,nodeid=3,cpus=3-4,cpus=9-10. It can't save the parsing of >> intervals (eg. 3-4). Saving the parsing of

  1   2   3   >