[Qemu-devel] [PATCH] vmdk: Fix vmdk_parse_extents

2013-10-11 Thread Fam Zheng
An extra 'p++' after while loop when *p == '\n' will move p to unknown data position, risking parsing junk data or memory access violation. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH] Spelling fixes

2013-10-11 Thread Stefan Weil
Am 11.10.2013 03:34, schrieb Peter Maydell: On 11 October 2013 04:11, Stefan Weil s...@weilnetz.de wrote: Am 08.07.2013 17:14, schrieb Corentin Chary: The comments (and most of the code) are from libvncserver (and, earlier, from THE 'ZYWRLE' VNC CODEC SOURCE CODE. as described in the

Re: [Qemu-devel] [PATCH RFC 5/9] ich9: Document why cannot_instantiate_with_device_add_yet

2013-10-11 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 10/10/2013 18:01, Paolo Bonzini ha scritto: Il 10/10/2013 16:42, arm...@redhat.com ha scritto: From: Markus Armbruster arm...@redhat.com An ICH9 southbridge contains several PCI devices, some of them with multiple functions. We model each

Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message

2013-10-11 Thread Markus Armbruster
Cole Robinson crobi...@redhat.com writes: Using multiple calls to error_report here means every line is prefaced with the (potentially long) pci-assign command line arguments. Use a single error_report to preserve the intended formatting. The orthodox way to do this is to use error_report()

Re: [Qemu-devel] [RFC] map 64-bit PCI devices after all possible RAM

2013-10-11 Thread Gerd Hoffmann
Hi, Ok, then would etc/pcimem64-start be suitable or maybe you have a suggestion? Looks good to me. cheers, Gerd

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-11 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Am 10.10.2013 11:39, schrieb Stefan Hajnoczi: qemu.org is held by a third-party and no core community contributor has access to the DNS configuration. This leaves the website exposed to outages due to DNS issues or IP address changes. For example, if the

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

2013-10-11 Thread Gerd Hoffmann
On Do, 2013-10-10 at 21:17 +0200, Sebastian Herbszt wrote: Andreas Färber wrote: Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to be falling through the cracks... Andreas Is this patch still required? I was under the impression that no patch is needed for Win 8

Re: [Qemu-devel] [PATCH 1/2] Mostly revert qemu-help: Sort devices by logical functionality

2013-10-11 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: On Thu, 2013-10-10 at 15:00 +0200, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com This reverts most of commit 3d1237fb2ab4edb926c717767bb5e31d6053a7c5. The commit claims to sort the output of -device help by functionality

[Qemu-devel] [PATCH] qemu-iotests: move blank lines of output in case 059

2013-10-11 Thread Fam Zheng
Move the blank line to above the test step banner, so it looks clearer in blocks. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/059 | 8 tests/qemu-iotests/059.out | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/059

Re: [Qemu-devel] Qemu Boot failure with /dev/ram0

2013-10-11 Thread Philipp Hahn
Hello, On Monday 16 September 2013 07:40:08 Saptarshi Sen wrote: I want to use a ram disk as a block device for my kernel.( i am measuring file io on ram ) I am trying to boot a kernel from using /dev/ram0. However I am getting No root Device found qemu-system-x86_64 -m 8G -hda

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-10-11 Thread Peter Lieven
On 08.10.2013 14:39, Kevin Wolf wrote: Am 08.10.2013 um 14:35 hat Paolo Bonzini geschrieben: Il 08/10/2013 14:33, Kevin Wolf ha scritto: this converts read, write and flush functions from aio to coroutines. I'm not sure it's already the time for this... Cancellation sucks in QEMU, and this

[Qemu-devel] [PATCH v2 1/2] qcow2: Undo leaked allocations in co_writev

2013-10-11 Thread Max Reitz
If the write request spans more than one L2 table, qcow2_alloc_cluster_offset cannot handle the required allocations atomically. This results in leaks if it allocated new clusters in any but the last L2 table touched and an error occurs in qcow2_co_writev before having established the L2 link.

[Qemu-devel] [PATCH v2 0/2] qcow2: Undo leaked allocations in co_writev

2013-10-11 Thread Max Reitz
If a write request on a qcow2 image spans more than one L2 table, qcow2_alloc_cluster_offset cannot allocate the required clusters in a single operation. This results in leaks, if a subsequent (atomic) allocation in that function fails, because qcow2_co_writev does not undo unused cluster

[Qemu-devel] [PATCH v2 2/2] qemu-iotests: Extend test 026

2013-10-11 Thread Max Reitz
Extend test case 026 by an aio_write fail test, which should not result in any leaked clusters. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/026 | 31 +++ tests/qemu-iotests/026.out | 8

Re: [Qemu-devel] [PATCH v2 0/2] vmdk: convert error reporting

2013-10-11 Thread Fam Zheng
On Thu, 10/10 20:38, Fam Zheng wrote: The first patch converts fprintf(stderr,... to error_setg with errp, and fixes style of error message texts. The second patch checks the compatibility of zeroed_grain flag and flat type and reports error if both are true. v2: [01] More conversion of

[Qemu-devel] [PATCH v3 0/2] vmdk: convert error reporting

2013-10-11 Thread Fam Zheng
The first patch converts fprintf(stderr,... to error_setg with errp, and fixes style of error message texts. The second patch checks the compatibility of zeroed_grain flag and flat type and reports error if both are true. v3: Update qemu-iotests. v2: [01] More conversion of error messages, also

[Qemu-devel] [PATCH v3 1/2] vmdk: convert error code to use errp

2013-10-11 Thread Fam Zheng
Convert fprintf(stderr,... and standardize error messages: Remove a few local_error's and use errp. Remove VMDK: or Vmdk: prefixes in error message and fix to upper case. Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 116 -

[Qemu-devel] [PATCH v3 2/2] vmdk: refuse enabling zeroed grain with flat images

2013-10-11 Thread Fam Zheng
This is a header flag and we needs sparse for the header. Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 4 tests/qemu-iotests/059 | 4 tests/qemu-iotests/059.out | 4 3 files changed, 12 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index

[Qemu-devel] [PATCH] vmdk: Only read cid from image file when opening

2013-10-11 Thread Fam Zheng
Previously cid of parent is parsed from image file for every IO request. We already have L1/L2 cache and don't have assumption that parent image can be updated behind us, so remove this to get more efficiency. The parent CID is checked them when opening backing file. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-11 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 07:42:30PM +0200, Stefan Weil wrote: Am 10.10.2013 11:39, schrieb Stefan Hajnoczi: qemu.org is held by a third-party and no core community contributor has access to the DNS configuration. This leaves the website exposed to outages due to DNS issues or IP address

[Qemu-devel] [PATCH] block/iscsi: remove .bdrv_has_zero_init

2013-10-11 Thread Peter Lieven
since commit 3ac21627 the default value changed to 0. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |7 --- 1 file changed, 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index a2a961e..a660a1c 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1447,11 +1447,6 @@

Re: [Qemu-devel] [PATCH V5 1/6] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-10-11 Thread Xu Wang
于 2013/8/3 6:09, Eric Blake 写道: On 08/02/2013 03:02 AM, Xu Wang wrote: From: Xu Wangcngesa...@gmail.com If there is a loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear

[Qemu-devel] [PATCH v2 1/2] qapi: Add optional field 'compressed' to ImageInfo

2013-10-11 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- qapi-schema.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index a1a81a4..b187fdb 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -256,6 +256,8 @@ # # @encrypted: #optional true

[Qemu-devel] [PATCH v2 0/2] vmdk: Implement bdrv_get_specific_info

2013-10-11 Thread Fam Zheng
This is based on [PATCH v3 0/2] vmdk: convert error reporting. The new information looks like: image: /tmp/foo.vmdk file format: vmdk virtual size: 100G (107374182400 bytes) disk size: 4.0K Format specific information: cid: 0 create_type: twoGbMaxExtentFlat

[Qemu-devel] [PATCH v2 2/2] vmdk: implment bdrv_get_specific_info

2013-10-11 Thread Fam Zheng
Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 57 +- qapi-schema.json | 24 ++- tests/qemu-iotests/059 | 2 +-

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-11 Thread Paolo Bonzini
Il 11/10/2013 04:59, liu ping fan ha scritto: On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote: Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto: Are you sure? This is not done for any other compat

[Qemu-devel] [PATCH] block/iscsi: updated copyright

2013-10-11 Thread Peter Lieven
added myself to reflect recent work on the iscsi block driver. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/iscsi.c b/block/iscsi.c index a660a1c..ee8cdd3 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2,6 +2,7 @@ *

Re: [Qemu-devel] PPC: Timer issues with git master

2013-10-11 Thread Paolo Bonzini
Il 11/10/2013 00:27, Mark Cave-Ayland ha scritto: I've just upgraded my git repository from around the 1.6 release timeframe to git master and I'm seeing some strange timing issues running through my OpenBIOS test suite which weren't there before my git update. The two most noticeable

Re: [Qemu-devel] [PATCH 2/2] aio: add aio_context_acquire() and aio_context_release()

2013-10-11 Thread Wenchao Xia
Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH 1/2] rfifolock: add recursive FIFO lock

2013-10-11 Thread Wenchao Xia
Logic looks fine to me, only a minor comments. QemuMutex does not guarantee fairness and cannot be acquired recursively: Fairness means each locker gets a turn and the scheduler cannot cause starvation. Recursive locking is useful for composition, it allows a sequence of locking

Re: [Qemu-devel] kvm binary is deprecated

2013-10-11 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 02:00:39PM +0300, Alexander Binun wrote: Stefan , great thanks! We are setting up the scene for experiments... Unfortunately, we ran into yet one trouble. The configuration: Ubuntu 13.04, internal KVM, Qemu 1.4.0. VMs are created using virt-manager. When we try to

[Qemu-devel] [PATCH] configure: create fsdev/ directory

2013-10-11 Thread Michael Tokarev
In some cases when building with parallelism (make -jN), build fails because the directory where output files are supposed to be does not exist. In particular, when make decides to build virtfs-proxy-helper.1 before other files in fsdev/, build will fail with the following error: perl -Ww --

Re: [Qemu-devel] [PATCH 2/5] block/raw-posix: Employ error parameter

2013-10-11 Thread Kevin Wolf
Am 10.10.2013 um 15:44 hat Max Reitz geschrieben: Make use of the error parameter in the opening and creating functions in block/raw-posix.c. Signed-off-by: Max Reitz mre...@redhat.com --- block/raw-posix.c | 60 --- 1 file changed, 48

Re: [Qemu-devel] [PATCH 1/2] qcow2: Undo leaked allocations in co_writev

2013-10-11 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 02:26:25PM +0200, Kevin Wolf wrote: Am 10.10.2013 um 10:52 hat Max Reitz geschrieben: If the write request spans more than one L2 table, qcow2_alloc_cluster_offset cannot handle the required allocations atomically. This results in leaks if it allocated new clusters

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-11 Thread liu ping fan
On Fri, Oct 11, 2013 at 4:38 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 11/10/2013 04:59, liu ping fan ha scritto: On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote: Il 10/10/2013 11:41, Michael S.

Re: [Qemu-devel] [PATCH 2/4] vring: factor common code for error exits

2013-10-11 Thread Paolo Bonzini
Il 10/10/2013 22:53, Richard Henderson ha scritto: On 10/10/2013 08:07 AM, Paolo Bonzini wrote: return head; + +out: +assert(ret 0); +if (ret == -EFAULT) { +vring-broken = true; +} +return ret; If this is only the error path, can we call the label

[Qemu-devel] [PATCH v2 2/5] block/raw-posix: Employ error parameter

2013-10-11 Thread Max Reitz
Make use of the error parameter in the opening and creating functions in block/raw-posix.c. Signed-off-by: Max Reitz mre...@redhat.com --- v2: - fixed call to raw_open_common() from the FreeBSD cdrom_open() --- block/raw-posix.c | 69 --- 1

Re: [Qemu-devel] [PATCH 0/5] block: Employ error parameter

2013-10-11 Thread Kevin Wolf
Am 10.10.2013 um 15:43 hat Max Reitz geschrieben: The series block: Error parameter for opening/creating images introduced exactly that. However, right now, this parameter is in fact only used by qcow2. This series adds support to some additional block drivers for which it was basically

Re: [Qemu-devel] [PATCH] qemu-iotests: move blank lines of output in case 059

2013-10-11 Thread Kevin Wolf
Am 11.10.2013 um 08:59 hat Fam Zheng geschrieben: Move the blank line to above the test step banner, so it looks clearer in blocks. Signed-off-by: Fam Zheng f...@redhat.com Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] QEMU/CPC project: an experience report

2013-10-11 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 11:14:22PM +0100, Gabriel Kerneis wrote: We were so excited about our QEMU/CPC GSoC project that we have decided to write a 12-page article to share our experience: QEMU/CPC: static analysis and CPS conversion for safe, portable, and efficient

[Qemu-devel] [PATCH v3 2/5] block/raw-posix: Employ error parameter

2013-10-11 Thread Max Reitz
Make use of the error parameter in the opening and creating functions in block/raw-posix.c. Signed-off-by: Max Reitz mre...@redhat.com --- v3: - fixed possible errno trashing by error_setg_errno by storing its value before calling that function v2: - fixed call to raw_open_common() from the

Re: [Qemu-devel] [PATCH V2 0/2] build: trivial patches for test*

2013-10-11 Thread Wenchao Xia
于 2013/9/26 8:42, Wenchao Xia 写道: v2: Address Michael's comments: 01: better commit message to tip what it is doing. Wenchao Xia (2): 1 tests: build the helper program by default 2 build: add command check-clean Makefile |1 - tests/Makefile | 16 ++-- 2

[Qemu-devel] [PATCH] hw/gpio/max7310.c : add output register property and update the outputports level when necessary

2013-10-11 Thread Zhou Yuan
From: Zhouy zhouyuan.f...@cn.fujitsu.com To: qemu-devel@nongnu.org Date: Fri, 11 Oct 2013 15:54:47 -0400 Subject: [PATCH 1/1] add output register property and update the outputports level when necessary Signed-off-by: Zhouy zhouyuan.f...@cn.fujitsu.com --- qemu-master/hw/gpio/max7310.c | 33

Re: [Qemu-devel] [PATCH] block/iscsi: remove .bdrv_has_zero_init

2013-10-11 Thread Kevin Wolf
Am 11.10.2013 um 09:59 hat Peter Lieven geschrieben: since commit 3ac21627 the default value changed to 0. Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v3 2/5] block/raw-posix: Employ error parameter

2013-10-11 Thread Kevin Wolf
Am 11.10.2013 um 11:37 hat Max Reitz geschrieben: Make use of the error parameter in the opening and creating functions in block/raw-posix.c. Signed-off-by: Max Reitz mre...@redhat.com --- v3: - fixed possible errno trashing by error_setg_errno by storing its value before calling that

[Qemu-devel] Networking in QEMU

2013-10-11 Thread Ayaz Akram
I have to emulate netwotking drivers for a particular mips board in qemu. I have gone through MALTA mips machine and its emulation in qemu, but I have not been able to find any good documentation to find out what should be starting point? Any help in this regard would be highly appreciated...

Re: [Qemu-devel] [PATCH v3 0/2] vmdk: convert error reporting

2013-10-11 Thread Kevin Wolf
Am 11.10.2013 um 09:43 hat Fam Zheng geschrieben: The first patch converts fprintf(stderr,... to error_setg with errp, and fixes style of error message texts. The second patch checks the compatibility of zeroed_grain flag and flat type and reports error if both are true. v3: Update

[Qemu-devel] [PATCH] map 64-bit PCI BARs at location provided by emulator

2013-10-11 Thread Igor Mammedov
Currently 64-bit PCI BARs are unconditionally mapped by BIOS right over 4G + RamSizeOver4G location, which doesn't allow to reserve extra space before 64-bit PCI window. For memory hotplug an extra RAM space might be reserved after present 64-bit RAM end and BIOS should map 64-bit PCI BARs after

Re: [Qemu-devel] Networking in QEMU

2013-10-11 Thread Antony Pavlov
On Fri, 11 Oct 2013 03:01:48 -0700 Ayaz Akram aaq...@gmail.com wrote: I have to emulate netwotking drivers for a particular mips board in qemu. I have gone through MALTA mips machine and its emulation in qemu, but I have not been able to find any good documentation to find out what should be

[Qemu-devel] [PATCH V4 3/5] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2013-10-11 Thread Wenchao Xia
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/058 | 102 tests/qemu-iotests/058.out | 32 ++ tests/qemu-iotests/check |1 + tests/qemu-iotests/group |1 + 4 files changed, 136 insertions(+),

[Qemu-devel] [PATCH V4 0/5] export internal snapshot by qemu-nbd

2013-10-11 Thread Wenchao Xia
This series allow user to read internal snapshot's contents without qemu-img convert. V2: Address Stefan's comments: 02: add 'fall through' comments in the case statement. 03: add doc about the difference of internal snapshot and backing chain snapshot, which is used in previous

[Qemu-devel] [PATCH V4 1/5] snapshot: distinguish id and name in load_tmp

2013-10-11 Thread Wenchao Xia
Since later this function will be used so improve it. The only caller of it now is qemu-img, and it is not impacted by introduce function bdrv_snapshot_load_tmp_by_id_or_name() that call bdrv_snapshot_load_tmp() twice to keep old search logic. bdrv_snapshot_load_tmp_by_id_or_name() return int to

[Qemu-devel] [PATCH V4 2/5] qemu-nbd: support internal snapshot export

2013-10-11 Thread Wenchao Xia
Now it is possible to directly export an internal snapshot, which can be used to probe the snapshot's contents without qemu-img convert. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/snapshot.c | 18 + include/block/snapshot.h |8 +++

[Qemu-devel] [PATCH V4 4/5] qemu-img: add -l for snapshot in convert

2013-10-11 Thread Wenchao Xia
Now qemu-img convert have similar options as qemu-nbd for internal snapshot. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- qemu-img-cmds.hx |2 +- qemu-img.c | 45 - qemu-img.texi| 12 3 files changed, 45

[Qemu-devel] [PATCH V4 5/5] qemu-iotests: add test for snapshot in qemu-img convert

2013-10-11 Thread Wenchao Xia
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/058 | 19 ++- tests/qemu-iotests/058.out | 12 2 files changed, 30 insertions(+), 1 deletions(-) diff --git a/tests/qemu-iotests/058 b/tests/qemu-iotests/058 index 5b821cf..d4987ae

[Qemu-devel] [PATCH] PPC: fix PCI configuration space MemoryRegions for grackle/uninorth

2013-10-11 Thread Mark Cave-Ayland
OpenBIOS prior to SVN r1225 had a horrible bug when accessing PCI configuration space for PPC Mac architectures - instead of writing the PCI configuration data value to the data register address, it would instead write it to the data register address plus the PCI configuration address. For this

Re: [Qemu-devel] [PATCH 2/5] block/raw-posix: Employ error parameter

2013-10-11 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 10.10.2013 um 15:44 hat Max Reitz geschrieben: Make use of the error parameter in the opening and creating functions in block/raw-posix.c. Signed-off-by: Max Reitz mre...@redhat.com --- block/raw-posix.c | 60

[Qemu-devel] [PATCH -V5] target-ppc: Fix page table lookup with kvm enabled

2013-10-11 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error when trying to read the guest address (gdb) x/10 do_fork 0xc0098660 do_fork:

Re: [Qemu-devel] [RfC PATCH] e820: pass high memory too.

2013-10-11 Thread Igor Mammedov
On Thu, 10 Oct 2013 14:54:29 +0200 Gerd Hoffmann kra...@redhat.com wrote: We have a fw_cfg entry to pass e820 entries from qemu to the firmware. Today it's used to pass reservations only. This patch makes qemu pass entries for RAM too. This allows to pass RAM sizes larger than 1TB to the

Re: [Qemu-devel] [PATCH] vmdk: Fix vmdk_parse_extents

2013-10-11 Thread Kevin Wolf
Am 11.10.2013 um 08:04 hat Fam Zheng geschrieben: An extra 'p++' after while loop when *p == '\n' will move p to unknown data position, risking parsing junk data or memory access violation. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 7 +--

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-11 Thread Paolo Bonzini
Il 11/10/2013 11:18, liu ping fan ha scritto: On Fri, Oct 11, 2013 at 4:38 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 11/10/2013 04:59, liu ping fan ha scritto: On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo

Re: [Qemu-devel] [PATCH] vmdk: Fix vmdk_parse_extents

2013-10-11 Thread Fam Zheng
On Fri, 10/11 13:23, Kevin Wolf wrote: Am 11.10.2013 um 08:04 hat Fam Zheng geschrieben: An extra 'p++' after while loop when *p == '\n' will move p to unknown data position, risking parsing junk data or memory access violation. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH v2 0/2] vmdk: Implement bdrv_get_specific_info

2013-10-11 Thread Kevin Wolf
Am 11.10.2013 um 10:31 hat Fam Zheng geschrieben: This is based on [PATCH v3 0/2] vmdk: convert error reporting. I have that series in the block branch now, but it still doesn't apply. Can you rebase? Kevin

Re: [Qemu-devel] QEMU/CPC project: an experience report

2013-10-11 Thread Gabriel Kerneis
Hi Pierre, On Fri, Oct 11, 2013 at 01:34:02PM +0200, Pierre Tardy wrote: Do I summarized too much if I say that this is about automatically translating thread based code to event driven code? This is exactly what CPC is about. If you want more details on the translation itself, you might be

[Qemu-devel] [PATCH v2] vmdk: Fix vmdk_parse_extents

2013-10-11 Thread Fam Zheng
An extra 'p++' after while loop when *p == '\n' will move p to unknown data position, risking parsing junk data or memory access violation. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 2/2] vmdk: implment bdrv_get_specific_info

2013-10-11 Thread Eric Blake
On 10/11/2013 02:31 AM, Fam Zheng wrote: Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com --- + +*spec_info-vmdk = (ImageInfoSpecificVmdk) { +.create_type = g_strdup(s-create_type), +.cid = s-cid, +}; +

Re: [Qemu-devel] [PATCH v2] vmdk: Fix vmdk_parse_extents

2013-10-11 Thread Kevin Wolf
Am 11.10.2013 um 13:48 hat Fam Zheng geschrieben: An extra 'p++' after while loop when *p == '\n' will move p to unknown data position, risking parsing junk data or memory access violation. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng f...@redhat.com Thanks, applied to the block

[Qemu-devel] [PATCH 0/2] qcow2/iotests: Add test for inactive L2 overlap

2013-10-11 Thread Max Reitz
With the ability to adjust the metadata overlap checks performed through the command line, we can now add a test for checks not performed by the default cached mode, i.e. those regarding inactive L2 tables. In order to be able to use qemu-io for this test, however, it must first be extended to

[Qemu-devel] [PATCH 1/2] qemu-io: Let open pass options to block driver

2013-10-11 Thread Max Reitz
Add an option to the open command to specify runtime options for the block driver used. Signed-off-by: Max Reitz mre...@redhat.com --- qemu-io.c | 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index

[Qemu-devel] [PATCH 2/2] qemu-iotests: Add test for inactive L2 overlap

2013-10-11 Thread Max Reitz
Extend 060 by a test which creates a corrupted image with an active L2 entry pointing to an inactive L2 table and writes to the corresponding guest offset. Also, use overlap-check=all for all tests in 060. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/060 | 47

Re: [Qemu-devel] [PATCH v2 2/2] vmdk: implment bdrv_get_specific_info

2013-10-11 Thread Fam Zheng
On Fri, 10/11 05:52, Eric Blake wrote: On 10/11/2013 02:31 AM, Fam Zheng wrote: Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com --- + +*spec_info-vmdk = (ImageInfoSpecificVmdk) { +.create_type =

[Qemu-devel] [PATCH v3 0/2] vmdk: Implement bdrv_get_specific_info

2013-10-11 Thread Fam Zheng
The new information looks like: image: /tmp/foo.vmdk file format: vmdk virtual size: 100G (107374182400 bytes) disk size: 4.0K Format specific information: cid: 0 create_type: twoGbMaxExtentFlat parent cid: 0 extents: [0]:

[Qemu-devel] [PATCH v3 2/2] vmdk: Implment bdrv_get_specific_info

2013-10-11 Thread Fam Zheng
Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 57 +- qapi-schema.json | 24 ++- tests/qemu-iotests/059 | 2 +-

Re: [Qemu-devel] [PATCH v3 0/2] vmdk: Implement bdrv_get_specific_info

2013-10-11 Thread Eric Blake
On 10/11/2013 06:08 AM, Fam Zheng wrote: The new information looks like: image: /tmp/foo.vmdk file format: vmdk virtual size: 100G (107374182400 bytes) disk size: 4.0K Format specific information: cid: 0 create_type: twoGbMaxExtentFlat parent

Re: [Qemu-devel] [PATCH 0/2] qcow2/iotests: Add test for inactive L2 overlap

2013-10-11 Thread Kevin Wolf
Am 11.10.2013 um 14:02 hat Max Reitz geschrieben: With the ability to adjust the metadata overlap checks performed through the command line, we can now add a test for checks not performed by the default cached mode, i.e. those regarding inactive L2 tables. In order to be able to use qemu-io

[Qemu-devel] [PATCH v3 1/2] qapi: Add optional field 'compressed' to ImageInfo

2013-10-11 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- qapi-schema.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 60f3fd1..add97e2 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -256,6 +256,8 @@ # # @encrypted: #optional true

Re: [Qemu-devel] [RfC PATCH] e820: pass high memory too.

2013-10-11 Thread Gerd Hoffmann
On Fr, 2013-10-11 at 13:20 +0200, Igor Mammedov wrote: On Thu, 10 Oct 2013 14:54:29 +0200 Gerd Hoffmann kra...@redhat.com wrote: We have a fw_cfg entry to pass e820 entries from qemu to the firmware. Today it's used to pass reservations only. This patch makes qemu pass entries for RAM

Re: [Qemu-devel] [PATCH v2 2/2] vmdk: implment bdrv_get_specific_info

2013-10-11 Thread Max Reitz
On 2013-10-11 14:07, Fam Zheng wrote: On Fri, 10/11 05:52, Eric Blake wrote: On 10/11/2013 02:31 AM, Fam Zheng wrote: Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com --- + +*spec_info-vmdk = (ImageInfoSpecificVmdk) { +

[Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open

2013-10-11 Thread Max Reitz
On one occasion, hdev_open() returned -1 in case of an unknown error instead of a proper -errno value. Adjust this to match the behavior of raw_open() (in raw-win32), which is to return -EINVAL in this case. Also, change the call to error_setg*() to match the one in raw_open() as well.

[Qemu-devel] [PATCH] target-ppc: Fix htab_mask calculation

2013-10-11 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Correctly update the htab_mask using the return value of KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 on GET_SREGS for HV. So don't update htab_mask if sdr1 is found to be zero. Fix the pte index calculation to be same as that found

Re: [Qemu-devel] [PATCH] map 64-bit PCI BARs at location provided by emulator

2013-10-11 Thread Gerd Hoffmann
On Fr, 2013-10-11 at 12:19 +0200, Igor Mammedov wrote: Currently 64-bit PCI BARs are unconditionally mapped by BIOS right over 4G + RamSizeOver4G location, which doesn't allow to reserve extra space before 64-bit PCI window. For memory hotplug an extra RAM space might be reserved after present

Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open

2013-10-11 Thread Eric Blake
On 10/11/2013 06:30 AM, Max Reitz wrote: On one occasion, hdev_open() returned -1 in case of an unknown error instead of a proper -errno value. Adjust this to match the behavior of raw_open() (in raw-win32), which is to return -EINVAL in this case. Also, change the call to error_setg*() to

Re: [Qemu-devel] [PATCH] target-ppc: Fix htab_mask calculation

2013-10-11 Thread Aneesh Kumar K.V
Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com writes: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Correctly update the htab_mask using the return value of KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 on GET_SREGS for HV. So don't update htab_mask if sdr1 is found to

[Qemu-devel] [PATCH v2] Use qemu-project.org domain name

2013-10-11 Thread Stefan Hajnoczi
qemu.org is held by a third-party and no core community contributor has access to the DNS configuration. This leaves the website exposed to outages due to DNS issues or IP address changes. For example, if the web server IP address needs to change we cannot guarantee qemu.org will point to it!

[Qemu-devel] [v2 00/13] Stage 2 VSX Support

2013-10-11 Thread Tom Musta
This patch series continues adding support for the PowerPC Vector Scalar Extension (VSX). Patches are relative to the Stage 1 delivery (see http://lists.nongnu.org/archive/html/qemu-ppc/2013-09/msg00231.html). This series adds the following: a) all remaining load and store instructions

[Qemu-devel] [v2 01/13] Abandon GEN_VSX_* macros

2013-10-11 Thread Tom Musta
This patch eliminates the GEN_VSX_LXVNX/GEN_VSX_STXVNX macros which did not provide significant value above the general GEN_HANDLER_E macro. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [v2 02/13] Add lxsdx

2013-10-11 Thread Tom Musta
This patch adds the Load VSX Scalar Doubleowrd Indexed (lxsdx) instruction. The lower 8 bytes of the target register are undefined; this implementation leaves those bytes unaltered. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 16 1 files changed,

[Qemu-devel] [v2 03/13] Add lxvdsx

2013-10-11 Thread Tom Musta
This patch adds the Load VSX Vector Doubleword Splat Indexed (lxvdsx) instruction. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c

[Qemu-devel] [v2 04/13] Add lxvw4x

2013-10-11 Thread Tom Musta
This patch adds the Load VSX Vector Word*4 Indexed (lxvw4x) instruction. V2: changed to use deposit_i64 per Richard Henderson's review. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-)

[Qemu-devel] [v2 05/13] Add stxsdx

2013-10-11 Thread Tom Musta
This patch adds the Store VSX Scalar Doubleword Indexed (stxsdx) instruction. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index

[Qemu-devel] [v2 06/13] Add stxvw4x

2013-10-11 Thread Tom Musta
This patch adds the Store VSX Vector Word*4 Indexed (stxvw4x) instruction. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c

[Qemu-devel] [v2 07/13] Add VSX Scalar Move Instructions

2013-10-11 Thread Tom Musta
This patch adds the VSX scalar move instructions: - xsabsdp (Scalar Absolute Value Double-Precision) - xsnabspd (Scalar Negative Absolute Value Double-Precision) - xsnegdp (Scalar Negate Double-Precision) - xscpsgndp (Scalar Copy Sign Double-Precision) A common generator macro

[Qemu-devel] [v2 08/13] Add VSX Vector Move Instructions

2013-10-11 Thread Tom Musta
This patch adds the vector move instructions: - xvabsdp - Vector Absolute Value Double-Precision - xvnabsdp - Vector Negative Absolute Value Double-Precision - xvnegdp - Vector Negate Double-Precision - xvcpsgndp - Vector Copy Sign Double-Precision - xvabssp - Vector Absolute Value

[Qemu-devel] [v2 09/13] Add Power7 VSX Logical Instructions

2013-10-11 Thread Tom Musta
This patch adds the VSX logical instructions that are defined by the Version 2.06 Power ISA (aka Power7): - xxland - xxlandc - xxlor - xxlxor - xxlnor Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 29 + 1 files changed, 29

[Qemu-devel] [v2 10/13] Add xxmrgh/xxmrgl

2013-10-11 Thread Tom Musta
This patch adds the VSX Merge High Word and VSX Merge Low Word instructions. V2: Now implemented using deposit (per Richard Henderson's comment) Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 41 + 1 files changed, 41

[Qemu-devel] [v2 11/13] Add xxsel

2013-10-11 Thread Tom Musta
This patch adds the VSX Select (xxsel) instruction. The xxsel instruction has four VSR operands. Thus the xC instruction decoder is added. The xxsel instruction is massively overloaded in the opcode table since only bits 26 and 27 are opcode bits. This overloading is done in matrix fashion

[Qemu-devel] [PATCH] linux-user: pass correct parameter to do_shmctl()

2013-10-11 Thread Petar Jovanovic
From: Petar Jovanovic petar.jovano...@imgtec.com Fix shmctl issue by passing correct parameter buf to do_shmctl(). Signed-off-by: Petar Jovanovic petar.jovano...@imgtec.com --- linux-user/syscall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c

[Qemu-devel] [v2 12/13] Add xxspltw

2013-10-11 Thread Tom Musta
This patch adds the VSX Splat Word (xxsplatw) instruction. This is the first instruction to use the UIM immediate field and consequently a decoder is also added. V2: reworked implementation per Richard Henderson's comments. Signed-off-by: Tom Musta tommu...@gmail.com ---

[Qemu-devel] [v2 13/13] Add xxsldwi

2013-10-11 Thread Tom Musta
This patch adds the VSX Shift Left Double by Word Immediate (xxsldwi) instruction. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 62 1 files changed, 62 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-11 Thread Chris J Arges
I have verified this on my local machine using virt-manager's save memory, savevm/loadvm via the qemu monitor , and migrate via qemu monitor. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of qemu- devel-ml,

  1   2   3   >