[Qemu-devel] [PATCH] block: simplify bdrv_drop_intermediate

2013-10-12 Thread Fam Zheng
There is only one failure point: bdrv_change_backing_file in this function, so we can drop the qlist and try to change the backing file before deleting anything. This way bdrv_drop_intermediate is simplified while keeping the operation transactional. A bonus is dropping an active BDS is supported

[Qemu-devel] [PATCH] mirror: drop local_err in mirror_compelte

2013-10-12 Thread Fam Zheng
There is errp passed in, so no need for local_err and error_propagate. Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 7b95acf..f2e9558 100644 --- a/block/mirror.c +++

[Qemu-devel] QEMU GSoC featured on Google Open Source Blog

2013-10-12 Thread Stefan Hajnoczi
Stephanie Taylor at the Google Open Source Blog has helped us publish a post that features two projects from this year's Google Summer of Code: http://google-opensource.blogspot.de/2013/10/google-summer-of-code-veteran-orgs-qemu.html Mike and Osier contributed summaries of the QEMU Integrated

Re: [Qemu-devel] [PATCH] configure: create fsdev/ directory

2013-10-12 Thread Alex Bennée
m...@tls.msk.ru writes: In some cases when building with parallelism (make -jN), build fails because the directory where output files are supposed to be does not exist. In particular, when make decides to build virtfs-proxy-helper.1 before other files in fsdev/, build will fail with the

[Qemu-devel] [Bug 1174654] Re: qemu-system-x86_64 takes 100% CPU after host machine resumed from suspend to ram

2013-10-12 Thread tobias
Hi, I am also encountering the bug of high cpu usage for a windows guest after suspend resume of my ubuntu host. Problem was in 13.04 but it's also still there in 13.10. The windows guest has virtio / spice enabled. Linux guests do not get the high cpu usage. Are there any more logs required

Re: [Qemu-devel] kvm binary is deprecated

2013-10-12 Thread Alexander Binun
Hello Stefan, The qemu used by me is the one installed using apt-get install qemu. The executable is in /usr/bin. The KVM driver is the one supplied with Ubuntu 13.04. The version of qemu is 1.4.0 (after running qemu --version I get the message --- QEMU emulator version 1.4.0 (Debian

Re: [Qemu-devel] [PATCH] configure: create fsdev/ directory

2013-10-12 Thread Paolo Bonzini
Il 11/10/2013 11:05, Michael Tokarev ha scritto: In some cases when building with parallelism (make -jN), build fails because the directory where output files are supposed to be does not exist. In particular, when make decides to build virtfs-proxy-helper.1 before other files in fsdev/,

Re: [Qemu-devel] [PATCH] block: simplify bdrv_drop_intermediate

2013-10-12 Thread Jeff Cody
On Sat, Oct 12, 2013 at 02:05:45PM +0800, Fam Zheng wrote: There is only one failure point: bdrv_change_backing_file in this function, so we can drop the qlist and try to change the backing file before deleting anything. This way bdrv_drop_intermediate is simplified while keeping the

Re: [Qemu-devel] [PATCH] configure: create fsdev/ directory

2013-10-12 Thread Michael Tokarev
12.10.2013 20:28, Paolo Bonzini wrote: Il 11/10/2013 11:05, Michael Tokarev ha scritto: [] --- a/configure +++ b/configure @@ -3576,6 +3576,7 @@ if test $softmmu = yes ; then if test $cap = yes test $linux = yes test $attr = yes ; then virtfs=yes tools=$tools

[Qemu-devel] [PULL 01/17] tcg: Use TCGMemOp for TCGLabelQemuLdst.opc

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-be-ldst.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg-be-ldst.h b/tcg/tcg-be-ldst.h index 2826d29..284db0c 100644 --- a/tcg/tcg-be-ldst.h +++ b/tcg/tcg-be-ldst.h @@ -25,7 +25,7 @@ typedef struct

[Qemu-devel] [PULL 00/17] tcg ldst conversions

2013-10-12 Thread Richard Henderson
All of these patches have been posted over the month of September. This pull includes conversions of 4 of the tcg backends to the new ldst opcodes. There are 2 more backends that I have also converted, ia64 and sparc, but at present I'm not able to re-test those so I've left them out. I also

[Qemu-devel] [PULL 05/17] tcg-i386: Support new ldst opcodes

2013-10-12 Thread Richard Henderson
No support for helpers with non-default endianness yet, but good enough to test the opcodes. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/i386/tcg-target.c | 139 ++ tcg/i386/tcg-target.h | 2 +- 2 files changed, 51 insertions(+), 90

[Qemu-devel] [PULL 02/17] tcg-i386: Use TCGMemOp within qemu_ldst routines

2013-10-12 Thread Richard Henderson
Step one in the transition, with constants passed down from tcg_out_op. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/i386/tcg-target.c | 123 -- 1 file changed, 59 insertions(+), 64 deletions(-) diff --git a/tcg/i386/tcg-target.c

[Qemu-devel] [PULL 04/17] tcg-i386: Remove cb output restriction from qemu_st8 for i386

2013-10-12 Thread Richard Henderson
Once we form a combined qemu_st_i32 opcode, we won't be able to have separate constraints based on size. This one is fairly easy to work around, since eax is available as a scratch register. When storing variable data, this tends to merely exchange one mov for another. E.g. -: mov

[Qemu-devel] [PULL 13/17] tcg-ppc: Convert to le/be ldst helpers

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc/tcg-target.c | 57 ++-- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index c1b0908..dadc108 100644 ---

[Qemu-devel] [PULL 07/17] tcg-arm: Convert to le/be ldst helpers

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 50 +- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 980d030..4692859 100644 --- a/tcg/arm/tcg-target.c

[Qemu-devel] [PULL 10/17] tcg-arm: Improve GUEST_BASE qemu_ld/st

2013-10-12 Thread Richard Henderson
If we pull the code to emit the actual load/store into a subroutine, we can share the reg+reg addressing mode code between softmmu and usermode. This lets us load GUEST_BASE into a temporary register rather than attempting to add it piece-wise to the address. Which lets us use movw+movt for

[Qemu-devel] [PULL 06/17] tcg-arm: Use TCGMemOp within qemu_ldst routines

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 125 +-- 1 file changed, 61 insertions(+), 64 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index c0e1466..980d030 100644 ---

[Qemu-devel] [PULL 12/17] tcg-ppc64: Use TCGMemOp within qemu_ldst routines

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc64/tcg-target.c | 84 +++--- 1 file changed, 45 insertions(+), 39 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 12c1f61..499805f 100644 ---

[Qemu-devel] [PULL 09/17] tcg-arm: Convert to new ldst opcodes

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 107 ++- tcg/arm/tcg-target.h | 2 +- 2 files changed, 38 insertions(+), 71 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index e7d6bf0..c3fd2b0

[Qemu-devel] [PULL 17/17] target-alpha: Convert to new ldst opcodes

2013-10-12 Thread Richard Henderson
Or, partially. The fundamental primitives for the port are gen_load_mem and gen_store_mem, which take a callback to emit the memory operation. For that, we continue to use the original inline functions that forward to the new ops, rather than replicate the same thing privately. That said, all

[Qemu-devel] [PULL 11/17] tcg-ppc: Use TCGMemOp within qemu_ldst routines

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc/tcg-target.c | 104 --- 1 file changed, 48 insertions(+), 56 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index 68778c2..c1b0908 100644 ---

[Qemu-devel] [PULL 08/17] tcg-arm: Tidy variable naming convention in qemu_ld/st

2013-10-12 Thread Richard Henderson
s/addr_reg2/addrhi/ s/addr_reg/addrlo/ s/data_reg2/datahi/ s/data_reg/datalo/ Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 230 +-- 1 file changed, 115 insertions(+), 115 deletions(-) diff --git

[Qemu-devel] [PULL 14/17] tcg-ppc64: Convert to le/be ldst helpers

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc64/tcg-target.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 499805f..be29139 100644 --- a/tcg/ppc64/tcg-target.c +++

[Qemu-devel] [PULL 15/17] tcg-ppc: Support new ldst opcodes

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc/tcg-target.c | 97 +--- tcg/ppc/tcg-target.h | 2 +- 2 files changed, 33 insertions(+), 66 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index dadc108..dc2c2df

[Qemu-devel] [PULL 16/17] tcg-ppc64: Support new ldst opcodes

2013-10-12 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc64/tcg-target.c | 77 +++--- tcg/ppc64/tcg-target.h | 2 +- 2 files changed, 17 insertions(+), 62 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index

[Qemu-devel] [PULL 03/17] tcg-i386: Tidy softmmu routines

2013-10-12 Thread Richard Henderson
Pass two TCGReg to tcg_out_tlb_load, rather than idx+args. Move ldst_optimization routines just below tcg_out_tlb_load to avoid the need for forward declarations. Use TCGReg enum in preference to int where apprpriate. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/i386/tcg-target.c