On 10/10/2013 02:50 PM, Alexey Kardashevskiy wrote:
> On 10/09/2013 06:47 PM, Paolo Bonzini wrote:
>> Il 09/10/2013 09:15, Alexey Kardashevskiy ha scritto:
>>> Sorry for my ignorance (I never ever touched this part of qemu) but how can
>>> you possibly avoid block.c while doing savevm? The qcow2 dr
Il 16/10/2013 07:04, Alexey Kardashevskiy ha scritto:
> Hi!
>
> Normally on sPAPR platform the IBMVSCSI host bus adapter is used which is
> SCSI. So when we want some image to appear as a DVD to the guest
> (particularly SLOF - our firmware), we use "-device scsi-cd". Or QEMU
> extracts this autom
http://lists.xen.org/archives/html/xen-devel/2013-09/msg03113.html
As said above, In Xen platform, after using upstream qemu, all pci devices can
be unpluged in the windows guest.
In this situation, the windows guest may occur blue screen when VM' user click
the icon of pass-through Graphics card
On Wed, 10/16 11:26, Fam Zheng wrote:
> This series implements feature of shared object building as described in:
>
> http://wiki.qemu.org/Features/Modules
>
> The main idea behind modules is to isolate dependencies on third party
> libraries from qemu executables, such as libglusterfs or librbd,
Hi!
Normally on sPAPR platform the IBMVSCSI host bus adapter is used which is
SCSI. So when we want some image to appear as a DVD to the guest
(particularly SLOF - our firmware), we use "-device scsi-cd". Or QEMU
extracts this automatically from the "media=cdrom" property of "-drive"
(correct?). A
The backtrace of VCPU in "hangup" state is:
(gdb) bt
#0 0x7f9ba661bc67 in ioctl () from /lib64/libc.so.6
#1 0x0069631d in kvm_vcpu_ioctl (cpu=0x169f880, type=44672) at
/home/qemu-kvm-1.5.1/kvm-all.c:1735
#2 0x00695bc6 in kvm_cpu_exec (env=0x169f990) at
/home/qemu-kvm-1.5.1/
Install all the modules to ${MODDIR}.
Signed-off-by: Fam Zheng
---
Makefile | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Makefile b/Makefile
index f940080..3d7cf5a 100644
--- a/Makefile
+++ b/Makefile
@@ -364,6 +364,12 @@ install-datadir install-localstatedir
ifneq ($(TOOLS),)
Signed-off-by: Fam Zheng
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index 8e1b73f..ac679ea 100644
--- a/.gitignore
+++ b/.gitignore
@@ -63,6 +63,9 @@ fsdev/virtfs-proxy-helper.pod
*.cp
*.dvi
*.exe
+*.dll
+*.so
+*.mo
*.fn
*.ky
*.log
--
1.8.
Adds extract-libs in LINK to expand any "per object libs", the syntax to define
such a libs options is like:
foo.o-libs := $(CURL_LIBS)
in block/Makefile.objs.
Similarly,
foo.o-cflags := $(FOO_CFLAGS)
is also supported.
"foo.o" must be listed a nested var (e.g. common-obj-y) t
This patch adds loading, stamp checking and initialization of modules.
The init function of dynamic module is no longer directly called as
__attribute__((constructor)) in static linked version, it is called
only after passed the checking of presense of stamp symbol:
qemu_stamp_$(date +%s$$$RA
Makefile.target includes rule.mak and unnested common-obj-y, then prefix
them with '../', this will ignore object specific QEMU_CFLAGS in subdir
Makefile.objs:
$(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS)
Because $(obj) here is './block', instead of '../block'. This doesn't
hurt compiling bec
The converted block drivers are:
curl
iscsi
rbd
ssh
glusterfs
together with object specific flags and libs change of:
qcow
linux-aio
No longer adds flags and libs for them to global variables, instead
create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, whi
Add necessary rules and flags for shared object generation.
$(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does
for $(block-obj-y). The new rules introduced here are:
0) For all %.so compiling:
QEMU_CFLAGS += -fPIC
1) %.o in $(common-obj-m) is compiled to %.o, then linked
From: Peter Maydell
Delete an unnecessary dependency for cocoa.o; we already have
a general rule that tells Make that we can build a .o file
from a .m source using an ObjC compiler, so this specific
rule is unnecessary. Further, it is using the dubious construct
"$(SRC_PATH)/$(obj)" to get at the
This series implements feature of shared object building as described in:
http://wiki.qemu.org/Features/Modules
The main idea behind modules is to isolate dependencies on third party
libraries from qemu executables, such as libglusterfs or librbd, so that the
end users can install core qemu packa
On Tue, Oct 15, 2013 at 3:47 PM, Alexey Kardashevskiy wrote:
> On 10/16/2013 02:03 AM, Alexander Graf wrote:
>> On 10/15/2013 10:50 AM, Alexey Kardashevskiy wrote:
>>> Old kernels (< 3.1) handle hvcX devices different in different parts.
>>> Sometime the kernel assumes that the hvc device numbers
On 10/16/2013 02:03 AM, Alexander Graf wrote:
> On 10/15/2013 10:50 AM, Alexey Kardashevskiy wrote:
>> Old kernels (< 3.1) handle hvcX devices different in different parts.
>> Sometime the kernel assumes that the hvc device numbers start from zero
>> and if there is just one hvc, then it is hvc0.
On 10/07/2013 03:47 AM, Michael Mueller wrote:
> A second reason for using 2k of memory here is to fully represent the
> facilities as defined
> in the s390x architecture. The SIE state needs it and I want to represent it
> identically in user
> space and KVM. Otherwise I would need a specific in
On 15 October 2013 21:19, Mark Cave-Ayland
wrote:
> +/* FCode ROM */
> +memory_region_init_ram(&s->rom, NULL, "cg3.prom", FCODE_MAX_ROM_SIZE);
> +vmstate_register_ram_global(&s->rom);
> +memory_region_set_readonly(&s->rom, true);
> +sysbus_init_mmio(dev, &s->rom);
> +
> +fc
The CG3 framebuffer is a simple 8-bit framebuffer for use with operating
systems such as early Solaris that do not have drivers for TCX.
Signed-off-by: Mark Cave-Ayland
CC: Blue Swirl
CC: Bob Breuer
CC: Artyom Tarasenko
---
Makefile |2 +-
default-configs/sparc-so
In order to allow the user to choose the framebuffer for sparc-softmmu, add
-vga tcx and -vga cg3 options to the QEMU command line. If no option is
specified, the default TCX framebuffer is used.
Signed-off-by: Mark Cave-Ayland
CC: Blue Swirl
CC: Bob Breuer
CC: Artyom Tarasenko
---
hw/sparc/s
This patchset follows on from the previous "Add FCode ROM for TCX framebuffer"
patch and provides QEMU with an implementation of the Sun CG3 8-bit
framebuffer. It is based upon Bob Breuer's original work which has been
rebased onto git master, and is now capable of running with an OpenBIOS CG3
FCo
On Tue, Oct 15, 2013 at 09:27:33AM -0700, Anthony Liguori wrote:
> Paolo Bonzini writes:
>
> > Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto:
> >> On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote:
> >>> Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto:
> -VMSTATE_
On Tue, Oct 15, 2013 at 06:42:25PM +0200, Paolo Bonzini wrote:
> Il 15/10/2013 18:06, Michael S. Tsirkin ha scritto:
> >> > It's not datapath if you're using ioeventfd, is it?
> > Well not everyone uses dataplane/vhost.
>
> ioeventfd does not require dataplane/vhost. Anyway for 1.8 I do want to
>
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio-rng.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index 314e393..18cbfac 10064
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/net/virtio-net.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 22dbd05..0911096 100644
--- a/
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio-balloon.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 9504877..d
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/char/virtio-serial-bus.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index 703f026
This fixes a crash in hot-unplug of virtio-pci devices behind a PCIe
switch. The crash happens because the ioeventfd is still set whent the
child is destroyed (destruction happens in postorder). Then the proxy
tries to unset to ioeventfd, but the virtqueue structure that holds the
EventNotifier h
The vdev field is complicated to synchronize. Just access the
BusState's list of children.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio-pci.c | 110 +
hw/virtio/virtio-pci.h | 1 -
2 files changed, 65 insertions(+
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/scsi/vhost-scsi.c| 11 +--
hw/scsi/virtio-scsi.c | 15 +++
include/hw/virtio/virtio-scsi.h | 2 +-
3 files changed, 13 insertions(+)
The vdev field is complicated to synchronize. Just access the
BusState's list of children.
Cc: qemu-sta...@nongnu.org
Reviewed-by: Cornelia Huck
Signed-off-by: Paolo Bonzini
---
hw/s390x/virtio-ccw.c | 80 ---
hw/s390x/virtio-ccw.h | 1 -
2 file
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/block/virtio-blk.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 49a23c3..aa37cc9 100644
-
This series fixes hot-unplug of virtio devices, which can crash due to
dangling pointer accesses.
The current implementation supports guest-initiated hot-unplug via the
virtio_bus_destroy_device function, but not hot-unplugging the virtio
device by virtue of unplugging its parent container device.
Right now we have these pairs:
- virtio_bus_plug_device/virtio_bus_destroy_device. The first
takes a VirtIODevice, the second takes a VirtioBusState
- device_plugged/device_unplug callbacks in the VirtioBusClass
(here it's just the naming that is inconsistent)
- virtio_bus_destroy_device is
The vdev field is complicated to synchronize. Just access the
BusState's list of children.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio-bus.c | 65 +-
hw/virtio/virtio-mmio.c| 9 +++---
hw/virtio/virtio-pci
Similar to the PCI bug that prompted these patches, virtio-ccw will
segfault after the reworking of hotplug/hot-unplug. Prepare for
this by moving virtio_ccw_stop_ioeventfd to before the freeing
of the proxy device.
A better place for this could be the device_unplugged callback
for the virtio-ccw
Il 15/10/2013 18:06, Michael S. Tsirkin ha scritto:
>> > It's not datapath if you're using ioeventfd, is it?
> Well not everyone uses dataplane/vhost.
ioeventfd does not require dataplane/vhost. Anyway for 1.8 I do want to
get rid of BusChild altogether, just not now.
Paolo
> It's the same for
Set the expected values for POWER7, POWER7+, POWER8 and POWER5+.
Note that POWER5+ and POWER7+ are intentionally lacking the '+', so the
lack of a POWER7P family constitutes no problem.
Signed-off-by: Andreas Färber
---
target-ppc/translate_init.c | 3 +++
1 file changed, 3 insertions(+)
diff -
Hello Alexey and Alex,
This series cleans up the fdt CPU nodes for -M pseries as attempted by Prerna.
v3 uses DeviceClass::fw_name for name storage exclusively, with
"PowerPC,UNKNOWN"
as fallback.
Regards,
Andreas
v2 -> v3:
* Drop any type-based model name mangling and default to PowerPC,UNKNO
Instead of relying on cpu_model, obtain the device tree node label
per CPU. Use DeviceClass::fw_name as source.
Whenever DeviceClass::fw_name is unknown, default to "PowerPC,UNKNOWN".
As a consequence, spapr_fixup_cpu_dt() can operate on each CPU's fw_name,
obsoleting sPAPREnvironment::cpu_model,
Paolo Bonzini writes:
> Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto:
>> On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote:
>>> Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto:
-VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status,
-
On Tue, 16 Jul 2013 00:26:14 +0200
Igor Mammedov wrote:
...
> +X86CPU_FEAT("feat-kvmclock",0, FEAT_KVM),
> +X86CPU_FEAT("feat-kvm-nopiodelay", 1, FEAT_KVM),
> +X86CPU_FEAT("feat-kvm-mmu", 2, FEAT_KVM),
> +X86CPU_FEAT("feat-kvmclock2", 3, FEAT_KVM),
> +X8
Am 15.10.2013 um 17:53 hat Stefan Weil geschrieben:
> Am 11.10.2013 17:05, schrieb Kevin Wolf:
> > IF_NONE allows read-only, which makes forbidding it in this place
> > for other types pretty much pointless.
> >
> > Instead, make sure that all devices for which the check would have
> > errored out
Running this gives me:
UST events:
-
None
Before or after running qemu. What is the mechanism lttng expects to
find out all these events?
Either the user should belong the group "tracing", or launch the
lttng-sessiond daemon (lttng-sessiond -d).
+
+Create tracing session:
On Tue, Oct 15, 2013 at 05:53:39PM +0200, Paolo Bonzini wrote:
> Il 15/10/2013 17:40, Michael S. Tsirkin ha scritto:
> > On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote:
> >> > @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy
> >> > *proxy)
> >> > static void
Am 15.10.2013 17:59, schrieb Kevin Wolf:
> Am 15.10.2013 um 17:53 hat Stefan Weil geschrieben:
>> Am 11.10.2013 17:05, schrieb Kevin Wolf:
>>> IF_NONE allows read-only, which makes forbidding it in this place
>>> for other types pretty much pointless.
>>>
>>> Instead, make sure that all devices for
Il 15/10/2013 17:19, Cornelia Huck ha scritto:
>
>> > The vdev field is complicated to synchronize. Just access the
>> > BusState's list of children.
>> >
>> > Cc: qemu-sta...@nongnu.org
>> > Signed-off-by: Paolo Bonzini
>> > ---
>> > hw/s390x/virtio-ccw.c | 80
>> > ++
Il 11/10/2013 03:16, Fam Zheng ha scritto:
> This series implements feature of shared object building as described in:
>
> http://wiki.qemu.org/Features/Modules
>
> The main idea behind modules is to isolate dependencies on third party
> libraries from qemu executables, such as libglusterfs or li
Am 11.10.2013 17:05, schrieb Kevin Wolf:
> IF_NONE allows read-only, which makes forbidding it in this place
> for other types pretty much pointless.
>
> Instead, make sure that all devices for which the check would have
> errored out check in their init function that they don't get a read-only
> B
Il 15/10/2013 17:40, Michael S. Tsirkin ha scritto:
> On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote:
>> > @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy
>> > *proxy)
>> > static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val)
>> > {
>
On Tue, Oct 15, 2013 at 03:42:34PM +0100, Peter Maydell wrote:
> The documentation of how overlapping memory regions behave and how
> the priority system works was rather brief, and confusion about
> priorities seems to be quite common for developers trying to understand
> how the memory region sys
On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote:
> @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy
> *proxy)
> static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val)
> {
> VirtIOPCIProxy *proxy = opaque;
> -VirtIODevice *vdev =
'etc/pcimem64-minimum-address' will allow QEMU to communicate to BIOS
where PCI memory address space mapping starts in high memory.
Allowing BIOS start mapping 64-bit PCI BARs at address where QEMU
placed this mapping vs. hardcoded value right after highmem RAM.
That will allow QEMU to reserve ex
On Tue, Oct 15, 2013 at 05:51:28PM +0300, Michael S. Tsirkin wrote:
> On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote:
> > Please put together a summary of the testing this series has gone
> > through. I still think there should be automated testing as part of
> > this but if the m
The vdev field is complicated to synchronize. Just access the
BusState's list of children.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio-pci.c | 110 +
hw/virtio/virtio-pci.h | 1 -
2 files changed, 65 insertions(+
On Tue, 15 Oct 2013 16:52:44 +0200
Paolo Bonzini wrote:
> The vdev field is complicated to synchronize. Just access the
> BusState's list of children.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Paolo Bonzini
> ---
> hw/s390x/virtio-ccw.c | 80
> --
On Tue, 15 Oct 2013 17:51:28 +0300
"Michael S. Tsirkin" wrote:
> On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote:
> > Please put together a summary of the testing this series has gone
> > through. I still think there should be automated testing as part of
> > this but if the manu
This fixes a crash in hot-unplug of virtio-pci devices behind a PCIe
switch. The crash happens because the ioeventfd is still set whent the
child is destroyed (destruction happens in postorder). Then the proxy
tries to unset to ioeventfd, but the virtqueue structure that holds the
EventNotifier h
On Thu, Oct 10, 2013 at 11:15 AM, Stefan Hajnoczi wrote:
> On Fri, Oct 04, 2013 at 07:30:45AM -0700, Mark Trumpold wrote:
>>
>>
>> On 9/26/13 10:18 PM, "Stefan Hajnoczi" wrote:
>>
>> >
>> >Try the qemu-nbd --persistent option. That should prevent it from
>> >shutting down when nbd-client is disc
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio-balloon.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 9504877..d
On 15 Oct 2013, at 16:00, Peter Maydell wrote:
> On 15 October 2013 15:58, Tom Sutcliffe wrote:
>> Thumbs up from me testing on Arndale. My only issue is that virt and
>> vexpress-a15 add virtio-mmio devices in the opposite order to each other,
>> for the same set of -device command line argu
On Tue, Oct 15, 2013 at 05:09:36PM +0200, Paolo Bonzini wrote:
> Il 15/10/2013 17:07, Michael S. Tsirkin ha scritto:
> > > Because the same version can have multiple formats depending on a datum
> > > that is not part of the migration stream.
> >
> > I see. Will it be OK if I'll update the version
Il 15/10/2013 17:07, Michael S. Tsirkin ha scritto:
> > Because the same version can have multiple formats depending on a datum
> > that is not part of the migration stream.
>
> I see. Will it be OK if I'll update the version?
The version is constant, you cannot change it depending on which PCI
f
On 15 October 2013 15:52, Eric Blake wrote:
> On 10/15/2013 08:42 AM, Peter Maydell wrote:
>> +It is valid to add subregions to a region which is not a pure container
>> +(that is, to an MMIO, RAM or ROM region). This means that the region
>> +will act like a container, except that any addresses w
On 15 October 2013 15:58, Tom Sutcliffe wrote:
> Thumbs up from me testing on Arndale. My only issue is that virt and
> vexpress-a15 add virtio-mmio devices in the opposite order to each other, for
> the same set of -device command line arguments. It would avoid future
> headaches if we could h
On 10/15/2013 10:50 AM, Alexey Kardashevskiy wrote:
Old kernels (< 3.1) handle hvcX devices different in different parts.
Sometime the kernel assumes that the hvc device numbers start from zero
and if there is just one hvc, then it is hvc0.
However kernel's add_preferred_console() uses the very
This adds support for the VSEL floating point selection instruction
which was added in ARMv8.
Signed-off-by: Will Newton
---
target-arm/translate.c | 130 -
1 file changed, 129 insertions(+), 1 deletion(-)
Changes in v5:
- Break out VSEL decode
Floating point is an extension to the instruction set rather than
a coprocessor, so call it directly from the ARM and Thumb decode
functions.
Signed-off-by: Will Newton
---
target-arm/translate.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
Changes in v5
On Tue, Oct 15, 2013 at 7:41 AM, Kevin Wolf wrote:
> Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben:
>> Am 15.10.2013 15:21, schrieb Markus Armbruster:
>> > Andreas,
>> >
>> > To go beyond RFC with this series, I need to explain why the IDE
>> > controller functions of southbridges piix3-id
On Tue, Oct 15, 2013 at 04:54:24PM +0200, Paolo Bonzini wrote:
> Il 15/10/2013 16:54, Michael S. Tsirkin ha scritto:
> > > > Seemed cleaner not to.
> > >
> > > It certainly would be if we had a self-descriptive migration stream
> > > format.
> > >
> > > However, what we have is "send bytes, pars
On Tue, 15 Oct 2013 16:52:42 +0200
Paolo Bonzini wrote:
> Similar to the PCI bug that prompted these patches, virtio-ccw will
> segfault after the reworking of hotplug/hot-unplug. Prepare for
> this by moving virtio_ccw_stop_ioeventfd to before the freeing
> of the proxy device.
>
> A better pl
On 10/15/13 16:11, Eric Blake wrote:
> On 10/15/2013 07:10 AM, Laszlo Ersek wrote:
>> Also sort the test-* entries in the latter.
>>
>> Signed-off-by: Laszlo Ersek
>> ---
>> .gitignore | 9 -
>> tests/.gitignore | 11 +--
>> 2 files changed, 9 insertions(+), 11 deletions(-)
On 10/15/2013 08:52 AM, Eric Blake wrote:
> On 10/15/2013 08:42 AM, Peter Maydell wrote:
>> The documentation of how overlapping memory regions behave and how
>> the priority system works was rather brief, and confusion about
>> priorities seems to be quite common for developers trying to understan
Il 15/10/2013 16:54, Michael S. Tsirkin ha scritto:
> > > Seemed cleaner not to.
> >
> > It certainly would be if we had a self-descriptive migration stream format.
> >
> > However, what we have is "send bytes, parse them on the destination,
> > hope the format matches". Hence, anything that mak
Il 15/10/2013 16:47, Peter Maydell ha scritto:
> Ping^2!
>
> thanks
> -- PMM
I have placed this in a branch together with Fam's module patches and
will send a pull request tomorrow or Thursday (aka as soon as I get the
occasion to test Fam's patches).
Paolo
Right now we have these pairs:
- virtio_bus_plug_device/virtio_bus_destroy_device. The first
takes a VirtIODevice, the second takes a VirtioBusState
- device_plugged/device_unplug callbacks in the VirtioBusClass
(here it's just the naming that is inconsistent)
- virtio_bus_destroy_device is
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/block/virtio-blk.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 49a23c3..aa37cc9 100644
-
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio-rng.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index 314e393..18cbfac 10064
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/scsi/vhost-scsi.c| 11 +--
hw/scsi/virtio-scsi.c | 15 +++
include/hw/virtio/virtio-scsi.h | 2 +-
3 files changed, 13 insertions(+)
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/net/virtio-net.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 22dbd05..0911096 100644
--- a/
The vdev field is complicated to synchronize. Just access the
BusState's list of children.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/s390x/virtio-ccw.c | 80 ---
hw/s390x/virtio-ccw.h | 1 -
2 files changed, 44 insertions(+),
Similar to the PCI bug that prompted these patches, virtio-ccw will
segfault after the reworking of hotplug/hot-unplug. Prepare for
this by moving virtio_ccw_stop_ioeventfd to before the freeing
of the proxy device.
A better place for this could be the device_unplugged callback
for the virtio-ccw
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/char/virtio-serial-bus.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index 703f026
The vdev field is complicated to synchronize. Just access the
BusState's list of children.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio-bus.c | 63 +-
hw/virtio/virtio-mmio.c| 9 +++---
hw/virtio/virtio-pci
Am 15.10.2013 16:41, schrieb Kevin Wolf:
> having two IDE controllers using the same I/O ports won't work,
> obviously. So if you would allow -device or device-add for them, you'd
> need options to configure the ports at least.
Or a new can_only_be_instantiated_once flag. :)
Or proper error handli
This series fixes hot-unplug of virtio devices, which can crash due to
dangling pointer accesses.
The current implementation supports guest-initiated hot-unplug via the
virtio_bus_destroy_device function, but not hot-unplugging the virtio
device by virtue of unplugging its parent container device.
On 10/15/2013 08:42 AM, Peter Maydell wrote:
> The documentation of how overlapping memory regions behave and how
> the priority system works was rather brief, and confusion about
> priorities seems to be quite common for developers trying to understand
> how the memory region system works, so expa
On Tue, Oct 15, 2013 at 04:50:24PM +0200, Paolo Bonzini wrote:
> Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto:
> > On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote:
> >> Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto:
> >>> -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2
Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto:
> On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote:
>> Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto:
>>> -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status,
>>> - struct pci_status),
>
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote:
> Please put together a summary of the testing this series has gone
> through. I still think there should be automated testing as part of
> this but if the manual testing is sufficiently thorough I'll
> reconsider for 1.7.
>
> Regar
Ping^2!
thanks
-- PMM
On 27 September 2013 04:02, Peter Maydell wrote:
> Ping!
>
> thanks
> -- PMM
>
> On 14 September 2013 02:25, Peter Maydell wrote:
>> This is based on a set of patches by Ákos Kovács which were
>> lurking at the beginning of his KConfig patchset but which
>> I think make a
The documentation of how overlapping memory regions behave and how
the priority system works was rather brief, and confusion about
priorities seems to be quite common for developers trying to understand
how the memory region system works, so expand and clarify it.
This includes a worked example wit
Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben:
> Am 15.10.2013 15:21, schrieb Markus Armbruster:
> > Andreas,
> >
> > To go beyond RFC with this series, I need to explain why the IDE
> > controller functions of southbridges piix3-ide, piix3-ide-xen, piix4-ide
> > and via-ide cannot_instant
On Sun, Aug 25, 2013 at 03:59:28PM +0100, Peter Maydell wrote:
> The bswap.h header includes a set of "legacy unaligned functions"
> that (since commit c732a52d3 at the beginning of this year) are
> just wrappers for underlying {ld,st} functions. The legacy
> functions aren't used in many places, s
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote:
> I cannot reasonable revert a series like this before we cut GA.
It's very simple actually.
Here's a patch to disable it all.
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 63ae2ae..1a5a70c 100644
--- a/hw/i386/pc_piix.c
On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote:
> Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto:
> > -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status,
> > - struct pci_status),
> > +VMSTATE_STRUCT_TEST(pci0_status, PIIX4PMSta
Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto:
> -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status,
> - struct pci_status),
> +VMSTATE_STRUCT_TEST(pci0_status, PIIX4PMState,
> +vmstate_test_no_use_acpi_pci_hotplug
On 15 October 2013 15:25, Alex Bennée wrote:
> peter.mayd...@linaro.org writes:
>> This sounds like the code was written based on the kernel, not
>> on the board docs, which is wrong, so I think it could use
>> rephrasing. There's no need to mention previous behaviour either
>> IMHO -- people who
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote:
> On Tue, Oct 15, 2013 at 7:20 AM, Michael S. Tsirkin wrote:
> > On Tue, Oct 15, 2013 at 06:51:30AM -0700, Anthony Liguori wrote:
> >> On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin
> >> wrote:
> >> > On Mon, Oct 14, 2013 at
1 - 100 of 196 matches
Mail list logo
