Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-09 Thread Greg Kurz
On Tue, 10 Dec 2013 13:43:05 +1100 Alexey Kardashevskiy wrote: > On 12/10/2013 03:33 AM, Greg Kurz wrote: > > In the past, IO space could not be mapped into the memory address space > > so we introduced a workaround for that. Nowadays it does not look > > necessary so we can remove the workaround

[Qemu-devel] [PATCH v3 3/5] spapr-vio: fix firmware names

2013-12-09 Thread Alexey Kardashevskiy
This changes VIO bridge fw name from spapr-vio-bridge to vdevice and vscsi/veth node names from QEMU object names to VIO specific device tree names. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_vio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_

Re: [Qemu-devel] [PATCH v2] hw/i386/pc_sysfw: support two flash drives

2013-12-09 Thread Markus Armbruster
Laszlo Ersek writes: > On 12/03/13 18:23, Markus Armbruster wrote: > >> Reviewed-by: Markus Armbruster > > My horse for a commit, please? Your horse, two months, and four more rebases.

Re: [Qemu-devel] [PATCH v2] Fix QEMU build on OpenBSD on x86 archs

2013-12-09 Thread Brad Smith
On 10/12/13 2:07 AM, Stefan Weil wrote: Am 10.12.2013 02:26, schrieb Brad Smith: This resolves the build issue with building the ROMs on OpenBSD on x86 archs. As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the whole OS/packages and so forth. The ROMs need to have PIE disa

[Qemu-devel] [PATCH v3 2/5] spapr-llan: add to boot device list

2013-12-09 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- hw/net/spapr_llan.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c index 1bd6f50..229de00 100644 --- a/hw/net/spapr_llan.c +++ b/hw/net/spapr_llan.c @@ -29,6 +29,7 @@ #include "hw/qdev.h" #include "hw/ppc/

[Qemu-devel] [PATCH v3 0/5] spapr: add bootindex support

2013-12-09 Thread Alexey Kardashevskiy
This is yet another try of bootindex support on sPAPR. This time a QOM interface thing is used. Please, comment. Thanks. Alexey Kardashevskiy (5): boot: extend get_boot_devices_list() to ignore suffixes spapr-llan: add to boot device list spapr-vio: fix firmware names qdev: introduce get_

[Qemu-devel] [PATCH v3 1/5] boot: extend get_boot_devices_list() to ignore suffixes

2013-12-09 Thread Alexey Kardashevskiy
As suffixes do not make sense for sPAPR's device tree and there is no way to filter them out on the BusState::get_fw_dev_path level, let's add an ability for the external caller to specify whether to apply suffixes or not. Signed-off-by: Alexey Kardashevskiy --- hw/nvram/fw_cfg.c | 2 +- i

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-09 Thread Alexey Kardashevskiy
On 12/04/2013 01:00 AM, Paolo Bonzini wrote: > Il 03/12/2013 14:44, Andreas Färber ha scritto: You can check "if (current_machine && current_machine->get_fw_dev_path)", and move current_machine from vl.c to hw/qdev/core.c. >> Please don't encourage moving random stuff into "core

[Qemu-devel] [PATCH v3 5/5] spapr: define interface to fix device pathname

2013-12-09 Thread Alexey Kardashevskiy
This defines an object with the interface to fix firmware pathnames for devices which have @bootindex property. This fixes SCSI disks device node names (which are wildcard nodes in the device-tree). This fixes PHB name from "pci" to "pci@" where is a BUID as there is no bus on top of sPA

[Qemu-devel] [PATCH v3 4/5] qdev: introduce get_fw_dev_path() callback

2013-12-09 Thread Alexey Kardashevskiy
QEMU supports firmware names for all devices in the QEMU tree but some architectures expect some parts of firmware path names in different format. This introduces a firmware-pathname-change interface definition. If some machines needs to redefine the firmware path format, it has to add a child obj

Re: [Qemu-devel] [PATCH 04/28] vl: convert -m to QemuOpts

2013-12-09 Thread Paolo Bonzini
Il 27/11/2013 01:27, Igor Mammedov ha scritto: > Adds option to -m > "mem" - startup memory amount > > For compatibility with legacy CLI if suffix-less number is passed, > it assumes amount in Mb. > > Otherwise user is free to use suffixed number using suffixes b,k/K,M,G > > Signed-off-by: Igor

Re: [Qemu-devel] [PATCH v2] Fix QEMU build on OpenBSD on x86 archs

2013-12-09 Thread Stefan Weil
Am 10.12.2013 02:26, schrieb Brad Smith: > This resolves the build issue with building the ROMs on OpenBSD on x86 archs. > As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the > whole OS/packages and so forth. The ROMs need to have PIE disabled. This > is my initial attempt at

[Qemu-devel] [PATCH] block: Fix relative backing file path checking

2013-12-09 Thread Xu Wang
This patch is made for Bug #1257334 (diffuse handling of image creation from another path). The cause of it is user could create image even though the backing file doesn't exist. Becase backing file checking in the bdrv_img_create() is from the user's current path instead of relative path to the im

[Qemu-devel] [PATCH] target-arm: fix TTBCR write masking

2013-12-09 Thread Sergey Fedorov
Current implementation is not accurate according to ARMv7-AR reference manual. See "B4.1.153 TTBCR, Translation Table Base Control Register, VMSA | TTBCR format when using the Long-descriptor translation table format". When LPAE feature is supported, EAE, bit[31] selects translation descriptor form

Re: [Qemu-devel] [PATCH qom v1 1/1] qom/object.c: Split out object and class caches.

2013-12-09 Thread Peter Crosthwaite
Hi On Wed, Dec 4, 2013 at 1:40 AM, Paolo Bonzini wrote: > Il 28/11/2013 05:27, Peter Crosthwaite ha scritto: >> The object-cast and class-cast caches cannot be shared because class >> caching is conditional on the target type not being an interface and >> object caching is unconditional. Leads to

Re: [Qemu-devel] [RFC] sdl2 + virtio-gpu repost

2013-12-09 Thread Stefan Weil
Am 10.12.2013 05:05, schrieb Dave Airlie: > Hi, > > This is a repost of the latest SDL2 UI layer along with virtio-gpu, > > I've merged the SDL2 base and multi-head patches into one, and I've split > out the display notifiers stuff and the sdl2 demo hack. > > The virtio-gpu/vga wrapping is still un

Re: [Qemu-devel] gtk cursor patches

2013-12-09 Thread Stefan Weil
Am 10.12.2013 02:04, schrieb Dave Airlie: > These were just fallout fixes from exploring gtk multi-head with virtio-gpu, > > hopefully they are useful to people before then, not sure if the > warping/absolute interaction is defined or not. > > Dave. Please check both patches using scripts/checkpa

Re: [Qemu-devel] [PATCH] qemu_opts_parse(): always check return value

2013-12-09 Thread Laszlo Ersek
On 11/28/13 19:32, Markus Armbruster wrote: > Laszlo Ersek writes: > >> qemu_opts_parse() can always return NULL, even if the QemuOptsList.desc in >> question would be trivial to satisfy (eg. because it's empty). For >> example: >> >> qemu_opts_parse() >> opts_parse() >> qemu_opts_create()

Re: [Qemu-devel] [RFC] sdl2 + virtio-gpu repost

2013-12-09 Thread Dave Airlie
On Tue, Dec 10, 2013 at 2:05 PM, Dave Airlie wrote: > Hi, > > This is a repost of the latest SDL2 UI layer along with virtio-gpu, > > I've merged the SDL2 base and multi-head patches into one, and I've split > out the display notifiers stuff and the sdl2 demo hack. > > The virtio-gpu/vga wrapping

Re: [Qemu-devel] [PATCH v2] piix: fix 32bit pci hole

2013-12-09 Thread Laszlo Ersek
On 11/27/13 13:40, Laszlo Ersek wrote: > On 11/27/13 12:57, Gerd Hoffmann wrote: >> Make the 32bit pci hole start at end of ram, so all possible address >> space is covered. Of course the firmware can use less than that. >> Leaving space unused is no problem, mapping pci bars outside the >> hole c

[Qemu-devel] [PATCH] virtio-gpu: use glib alloc/free routines

2013-12-09 Thread Dave Airlie
From: Dave Airlie Oh I forgot to fix these up previously. Signed-off-by: Dave Airlie --- hw/display/virtio-gpu.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 7bf2fbb..28dcd1e 100644 --- a/hw/display/v

Re: [Qemu-devel] [PATCH v2] hw/i386/pc_sysfw: support two flash drives

2013-12-09 Thread Laszlo Ersek
On 12/03/13 18:23, Markus Armbruster wrote: > Reviewed-by: Markus Armbruster My horse for a commit, please? Thanks Laszlo

[Qemu-devel] [PATCH 8/8] HACK: just to make things start easier with libvirt

2013-12-09 Thread Dave Airlie
From: Dave Airlie --- hw/display/vga-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index b3a45c8..e4bea17 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c @@ -146,6 +146,7 @@ static int pci_std_vga_initfn(PCIDe

[Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-12-09 Thread Dave Airlie
From: Dave Airlie This is a virtio-vga device built on top of the virtio-gpu device. Signed-off-by: Dave Airlie --- Makefile | 2 +- default-configs/x86_64-softmmu.mak | 1 + hw/display/Makefile.objs | 1 + hw/display/virtio-vga.c| 156

[Qemu-devel] [PATCH 4/8] sdl2: add UI to toggle head 1 on/off

2013-12-09 Thread Dave Airlie
From: Dave Airlie This just adds ctrl-alt-n to toggle head 1 on/off for testing and demo purposes. Signed-off-by: Dave Airlie --- ui/sdl2.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index dd8cd2b..c52dcd9 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -522,6 +

[Qemu-devel] [PATCH 3/8] sdl2: add display notify change support

2013-12-09 Thread Dave Airlie
From: Dave Airlie this adds support for the callbacks from the console layer, when the gpu changes the layouts. Signed-off-by: Dave Airlie --- ui/sdl2.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 2eb3e9c..dd8cd2b 100644 --- a/ui/sdl2.c +++ b/ui/

[Qemu-devel] [PATCH 2/8] console: add state notifiers for ui<->display

2013-12-09 Thread Dave Airlie
From: Dave Airlie These are to be used for the UI to signal the video display, and vice-versa about changes in the state of a console, like size and offsets in relation to other consoles for input handling. Signed-off-by: Dave Airlie --- include/ui/console.h | 8 +++- ui/console.c

[Qemu-devel] [PATCH 6/8] virtio-gpu: v0.2 of the virtio based GPU code.

2013-12-09 Thread Dave Airlie
From: Dave Airlie This is the basic virtio-gpu which is multi-head capable, ARGB cursor support, unaccelerated. Some more info is in docs/specs/virtio-gpu.txt. changes since v0.1: add reset handling fix display info response fix cursor generation issues drop 3d stuff that snuck in Signed-off-

[Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v2.0)

2013-12-09 Thread Dave Airlie
From: Dave Airlie I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. The biggest changes were in the input handling, where SDL2 has done a major overhaul, and I've had to include a generated translation file to get from SDL2 codes back to qemu compatible ones. I'm stil

[Qemu-devel] [PATCH 5/8] console: add ability to wrap a console.

2013-12-09 Thread Dave Airlie
From: Dave Airlie In order to implement virtio-vga on top of virtio-gpu we need to be able to wrap the first console virtio-gpu registers from inside virtio-vga which initialises after virtio-gpu. With this interface virtio-vga can store the virtio-gpu interfaces, and call them from its own ones.

[Qemu-devel] [RFC] sdl2 + virtio-gpu repost

2013-12-09 Thread Dave Airlie
Hi, This is a repost of the latest SDL2 UI layer along with virtio-gpu, I've merged the SDL2 base and multi-head patches into one, and I've split out the display notifiers stuff and the sdl2 demo hack. The virtio-gpu/vga wrapping is still unresolved, I've failed to find a cleaner way yet, hopefu

Re: [Qemu-devel] [RFC PATCH 04/19] block: rename buffer_alignment to guest_block_size

2013-12-09 Thread Wenchao Xia
Cool to have a separation of emulator/block concepts. Reviewed-by: Wenchao Xia

Re: [Qemu-devel] [PATCH] seccomp: "-sandbox on" won't kill Qemu when option not built in

2013-12-09 Thread Corey Bryant
On 12/09/2013 12:51 PM, Eduardo Otubo wrote: On 12/09/2013 03:33 PM, Daniel P. Berrange wrote: On Mon, Dec 09, 2013 at 03:20:52PM -0200, Eduardo Otubo wrote: This option was requested by virt-test team so they can run tests with Qemu and "-sandbox on" set without breaking whole test if host

Re: [Qemu-devel] [RFC PATCH 03/19] block: Don't use guest sector size for qemu_blockalign()

2013-12-09 Thread Wenchao Xia
于 2013/12/7 1:22, Kevin Wolf 写道: > bs->buffer_alignment is set by the device emulation and contains the > logical block size of the guest device. This isn't something that the > block layer should know, and even less something to use for determining > the right alignment of buffers to be used for t

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-09 Thread Alexey Kardashevskiy
On 12/10/2013 03:33 AM, Greg Kurz wrote: > In the past, IO space could not be mapped into the memory address space > so we introduced a workaround for that. Nowadays it does not look > necessary so we can remove the workaround and make sPAPR PCI > configuration simplier. > > This workaround has al

Re: [Qemu-devel] save compiled qemu traces.

2013-12-09 Thread Xin Tong
tb_find_fast and tb_find_slow are finding the translated blocks based on guest physical address. I am thinking about finding tbs by content, e.g. using a hash signature. this can be used to potentially save translations. Xin On Mon, Dec 9, 2013 at 7:32 AM, Peter Maydell wrote: > On 9 December 2

Re: [Qemu-devel] [PATCH for-1.7] spapr: tie spapr-nvram to -pflash

2013-12-09 Thread Alexander Graf
On 09.12.2013, at 21:42, Paolo Bonzini wrote: > Il 09/12/2013 20:25, Alexander Graf ha scritto: >> >> >>> Am 22.11.2013 um 10:27 schrieb Paolo Bonzini : >>> >>> spapr-nvram's drive property is currently connected to a non-existent >>> "-machine nvram=" option. Instead, tie it to -pflash like

[Qemu-devel] [PATCH v2] Fix QEMU build on OpenBSD on x86 archs

2013-12-09 Thread Brad Smith
This resolves the build issue with building the ROMs on OpenBSD on x86 archs. As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the whole OS/packages and so forth. The ROMs need to have PIE disabled. This is my initial attempt at trying to get somehting upstream so that QEMU bo

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: ppc64 target's virtio can be either endian.

2013-12-09 Thread Alexander Graf
On 09.12.2013, at 20:44, Benjamin Herrenschmidt wrote: > On Mon, 2013-12-09 at 16:33 +0100, Alexander Graf wrote: >> >> Also can't virtio_get_byteswap pass in the CPU pointer of the CPU >> that's calling in this moment? I'm not sure how racy it is to >> synchronize the first cpu while we're no

[Qemu-devel] gtk cursor patches

2013-12-09 Thread Dave Airlie
These were just fallout fixes from exploring gtk multi-head with virtio-gpu, hopefully they are useful to people before then, not sure if the warping/absolute interaction is defined or not. Dave.

[Qemu-devel] [PATCH 1/2] gtk: don't warp point in absolute mode

2013-12-09 Thread Dave Airlie
From: Dave Airlie This makes gtk act the same way as the current sdl backend, which doesn't do the warp in this case. If your guest GPU has hw pointer this leads you get endless loops where the warp causes motion causes input events, causes the guest to move the cursor causes warp. Signed-off-b

[Qemu-devel] [PATCH 2/2] gtk: respect cursor visibility

2013-12-09 Thread Dave Airlie
From: Dave Airlie If the guest asks for no cursor, switch gtk to using the null cursor. Signed-off-by: Dave Airlie --- ui/gtk.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 2abf289..f60e66f 100644 --- a/ui/gtk.c +++ b/

Re: [Qemu-devel] [PATCH v2 0/9] target-s390 tcg improvements

2013-12-09 Thread Richard Henderson
On 10/01/2013 10:17 AM, Richard Henderson wrote: > Changes v1-v2: > * Squashed patches 1, 2, 4. The feedback from patch 1 called for a > re-ordering of the patch set to better deal with STFL, but I could > not find an ordering that worked well. I think this is probably > just as cle

Re: [Qemu-devel] [PATCH 07/18] target-ppc: Add ISA 2.06 stbcx. and sthcx. Instructions

2013-12-09 Thread Richard Henderson
On 12/09/2013 07:47 AM, Tom Musta wrote: > -static void gen_conditional_store (DisasContext *ctx, TCGv EA, > +static void gen_conditional_store(DisasContext *ctx, TCGv EA, > int reg, int size) If you're going to make random changes to the formatting, fix it all

Re: [Qemu-devel] [PATCH 06/18] target-ppc: Add ISA2.06 lbarx, lharx Instructions

2013-12-09 Thread Richard Henderson
On 12/09/2013 07:47 AM, Tom Musta wrote: > +LARX(lharx, 1, ld16u); 2 r~

Re: [Qemu-devel] [PATCH 05/18] target-ppc: Add ISA 2.06 divwe[u][o] Instructions

2013-12-09 Thread Richard Henderson
On 12/09/2013 07:47 AM, Tom Musta wrote: > +/* does the result fit in 32 bits? */ > \ > +tcg_gen_brcondi_i64(TCG_COND_LT, cpu_gpr[rD(ctx->opcode)], > INT32_MIN, \ > +lbl_ov); > \

[Qemu-devel] [PATCH 6/6] Add new vhost-user netdev backend

2013-12-09 Thread Antonios Motakis
Add a new QEMU netdev backend that is intended to invoke vhost_net with the vhost-user backend. Also decouple virtio-net from the tap backend. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c | 66 ++--- hw/net/virtio-net.c

[Qemu-devel] [PATCH 5/6] Add vhost-user calls implementation

2013-12-09 Thread Antonios Motakis
Each ioctl request of vhost-kernel has a vhost-user message equivalent, which is sent it over the control socket. The general approach is to copy the data from the supplied argument pointer to a designated field in the message. If a file descriptor is to be passed it should be placed also in the f

[Qemu-devel] [PATCH 3/6] Add vhost-user skeleton

2013-12-09 Thread Antonios Motakis
Add empty vhost_call, init and cleanup for the vhost-user backend. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c| 55 ++- hw/virtio/vhost-backend.c | 37 +- include/hw/vi

[Qemu-devel] [PATCHv2 0/6] Vhost and vhost-net support for userspace based backends

2013-12-09 Thread Antonios Motakis
In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving traffic from a guest inside QEMU/KVM which runs an unmodified virtio-

[Qemu-devel] [PATCH 4/6] Add domain socket communication for vhost-user backend

2013-12-09 Thread Antonios Motakis
Add structures for passing vhost-user messages over a unix domain socket. This is the equivalent of the existing vhost-kernel ioctls. Connect to the named unix domain socket. The system call sendmsg is used for communication. To be able to pass file descriptors between processes - we use SCM_RIGHT

[Qemu-devel] [PATCH 2/6] Decouple vhost from kernel interface

2013-12-09 Thread Antonios Motakis
We introduce the concept of vhost-backend, which can be either vhost-kernel or vhost-user. The existing vhost interface to the kernel is abstracted behind the vhost-kernel backend. We replace all direct ioctls to the kernel with a vhost_call to the backend. vhost dev->control is referenced only in

[Qemu-devel] [PATCH 1/6] Add -mem-share option

2013-12-09 Thread Antonios Motakis
This option complements -mem-path. It implies -mem-prealloc. If specified, the guest RAM is allocated as a shared memory object. If both -mem-path and -mem-share are provided, the memory is allocated from the HugeTLBFS supplied path, and then mmapped with MAP_SHARED. Signed-off-by: Antonios Motaki

Re: [Qemu-devel] [PATCH 03/18] target-ppc: Add ISA2.06 divdeu[o] Instructions

2013-12-09 Thread Richard Henderson
On 12/09/2013 07:47 AM, Tom Musta wrote: > This patch adds the Divide Doubleword Extended Unsigned > instructions. This instruction requires dividing a 128-bit > value by a 64 bit value. Since 128 bit integer division is > not supported in TCG, a helper is used, providing a > repeated difference

Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-09 Thread Richard Henderson
On 12/09/2013 07:46 AM, Tom Musta wrote: > +for (i = 0; i < 8; i++) { > +int index = (rs & (0xFFul) << (i*8)) >> (i*8); This is a silly expression. Better as int index = (rs >> (i * 8)) & 0xff; > +ra |= (1<

[Qemu-devel] [PATCH] Add bios-256k.bin to BLOBS on Makefile

2013-12-09 Thread Eduardo Habkost
The default machine-type (pc-i440fx-2.0) now requires bios-256k.bin, but "make install" isn't installing it, so qemu-system-x86_64 won't run out of the box. Add it to BLOBS so it gets installed. Signed-off-by: Eduardo Habkost --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Qemu-devel] [PATCH v2] target-arm: Use new qemu_ld/st opcodes

2013-12-09 Thread Richard Henderson
Retain the existing gen_aa32_* inlines, to aid compilation for A64. Cc: Peter Maydell Signed-off-by: Richard Henderson --- Changes v1-v2: * Fixed mistakenly deleted temp_free in gen_aa32_ld. r~ target-arm/translate.c | 56 ++ 1 file changed

[Qemu-devel] [PULL 17/30] virtio-net: QOM realize preparations

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Rename variable qdev -> dev since that's what realize's argument is called by convention. Avoid duplicate VIRTIO_DEVICE() cast. Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/net/virtio-net.c | 18 -- 1 file changed, 8 insertions(+), 10

[Qemu-devel] [PULL 13/30] virtio-blk-dataplane: Improve error reporting

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Return an Error so that it can be propagated later. Tested-by: Stefan Hajnoczi Acked-by: Stefan Hajnoczi [AF: Rebased] Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 30 -- hw/block/dataplane/

[Qemu-devel] [PULL 19/30] virtio-rng: QOM realize preparations

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Rename qdev -> dev because that's what realize's argument is called by convention. No need to keep more "qdev" around than necessary. Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-rng.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use "hotplug-device" interface.

2013-12-09 Thread Paolo Bonzini
Il 09/12/2013 22:15, Igor Mammedov ha scritto: >> > Check is idempotent, and can be called before realize makes any change >> > (it could also be called after the device is added to >> > /machine/unattached, it's not a big difference). >> > >> > Plug is called after realize. > PCIE case: "check" b

[Qemu-devel] [PULL 12/30] virtio-pci: add device_unplugged callback

2013-12-09 Thread Paolo Bonzini
This fixes a crash in hot-unplug of virtio-pci devices behind a PCIe switch. The crash happens because the ioeventfd is still set whent the child is destroyed (destruction happens in postorder). Then the proxy tries to unset to ioeventfd, but the virtqueue structure that holds the EventNotifier h

[Qemu-devel] [PULL 18/30] virtio-balloon: QOM realize preparations

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Rename qdev -> dev since that's what realize's argument is called by convention. No need to keep more "qdev" around than necessary. Avoid duplicate VIRTIO_DEVICE() cast. Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-balloon.c | 12 ++

[Qemu-devel] [PULL 03/30] virtio-ccw: remove vdev field

2013-12-09 Thread Paolo Bonzini
The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Reviewed-by: Cornelia Huck Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/s390x/virtio-ccw.c | 80 --- hw/s390x/

Re: [Qemu-devel] [PATCH 9/9] target-arm: A64: implement SVC, BRK

2013-12-09 Thread Peter Maydell
On 9 December 2013 21:58, Richard Henderson wrote: > On 12/09/2013 10:12 AM, Peter Maydell wrote: >> +case 0: >> +/* SVC, HVC, SMC; since we don't support the Virtualization >> + * or TrustZone extensions these all UNDEF except SVC. >> + */ >> +if (op2_ll != 1)

Re: [Qemu-devel] [SeaBIOS] [BUG] Windows 7 fails to start with new vgabios binaries

2013-12-09 Thread Kevin O'Connor
On Mon, Dec 09, 2013 at 10:57:25AM -0500, Kevin O'Connor wrote: > On Mon, Dec 09, 2013 at 02:20:59PM +0100, Gerd Hoffmann wrote: > > On Mo, 2013-12-09 at 14:18 +0200, Gal Hammer wrote: > > > A Windows 7 (32-bit) VM running with QXL device fails to start with the > > > new updated vgabios binaries

[Qemu-devel] [PULL 05/30] virtio-bus: cleanup plug/unplug interface

2013-12-09 Thread Paolo Bonzini
Right now we have these pairs: - virtio_bus_plug_device/virtio_bus_destroy_device. The first takes a VirtIODevice, the second takes a VirtioBusState - device_plugged/device_unplug callbacks in the VirtioBusClass (here it's just the naming that is inconsistent) - virtio_bus_destroy_device is

[Qemu-devel] [PULL 29/30] virtio: Complete converting VirtioDevice to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Drop VirtioDeviceClass::init. Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 3 +-- hw/virtio/virtio.c | 6 -- include/hw/virtio/virtio.h | 5 +++-- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/hw

[Qemu-devel] [PULL 15/30] virtio-blk: QOM realize preparations

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Rename variable qdev -> dev since that's what realize's argument is called by convention. Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/block/virtio-blk.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/block/virtio-blk.c

Re: [Qemu-devel] [PATCH 9/9] target-arm: A64: implement SVC, BRK

2013-12-09 Thread Richard Henderson
On 12/09/2013 10:12 AM, Peter Maydell wrote: > +case 0: > +/* SVC, HVC, SMC; since we don't support the Virtualization > + * or TrustZone extensions these all UNDEF except SVC. > + */ > +if (op2_ll != 1) { > +unallocated_encoding(s); > +br

[Qemu-devel] [PULL 11/30] virtio-rng: switch exit callback to VirtioDeviceClass

2013-12-09 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy, and avoids leaking bus_name which is freed by virtio_device_exit. Cc: qemu-sta...@nongnu.org Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-rng.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(

[Qemu-devel] [PULL 01/30] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug

2013-12-09 Thread Paolo Bonzini
Similar to the PCI bug that prompted these patches, virtio-ccw will segfault after the reworking of hotplug/hot-unplug. Prepare for this by moving virtio_ccw_stop_ioeventfd to before the freeing of the proxy device. A better place for this could be the device_unplugged callback for the virtio-ccw

Re: [Qemu-devel] [PATCH 8/9] target-arm: A64: add support for 3 src data proc insns

2013-12-09 Thread Richard Henderson
On 12/09/2013 10:12 AM, Peter Maydell wrote: > +if (is_high) { > +/* SMULH and UMULH go via helpers for the 64x64->128 multiply */ > +if (is_signed) { > +gen_helper_smulh(cpu_reg(s, rd), cpu_reg(s, rn), cpu_reg(s, rm)); > +} else { > +gen_helper_u

Re: [Qemu-devel] [PATCH 7/9] target-arm: A64: add support for move wide instructions

2013-12-09 Thread Richard Henderson
On 12/09/2013 10:12 AM, Peter Maydell wrote: > From: Alex Bennée > > This patch adds emulation for the mov wide instructions > (MOVN, MOVZ, MOVK). > > Signed-off-by: Alex Bennée > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 51 > +

[Qemu-devel] [PULL 22/30] virtio-9p: Convert to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/9pfs/virtio-9p-device.c | 41 - 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index ea21655..

Re: [Qemu-devel] [PULL 2/3] qemu: mempath: prefault pages manually (v4)

2013-12-09 Thread Marcelo Tosatti
On Mon, Dec 09, 2013 at 08:05:15PM +0100, Stefan Weil wrote: > Hi, > > this patch was recently committed to git master. > > It now causes problems with gcc-4.7 -Werror=clobbered. See more comments > below. > > Am 06.12.2013 16:54, schrieb Paolo Bonzini: > > From: Marcelo Tosatti > > > > v4: s/f

Re: [Qemu-devel] [PATCH 6/9] target-arm: A64: add support for add, addi, sub, subi

2013-12-09 Thread Richard Henderson
On 12/09/2013 10:12 AM, Peter Maydell wrote: > +tcg_rn = read_cpu_reg_sp(s, rn, sf); > +tcg_gen_mov_i64(tcg_rn, cpu_reg_sp(s, rn)); Duplicate copy from the register. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use "hotplug-device" interface.

2013-12-09 Thread Igor Mammedov
On Mon, 09 Dec 2013 18:18:42 +0100 Paolo Bonzini wrote: > Il 09/12/2013 17:48, Igor Mammedov ha scritto: > >> > > >> > We could have separate check/plug methods. Only check can fail, it must > >> > be idempotent, and it can be invoked while the device is still > >> > unrealized. > > Reasons I'

[Qemu-devel] [PULL 09/30] virtio-scsi: switch exit callback to VirtioDeviceClass

2013-12-09 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy, and avoids leaking bus_name which is freed by virtio_device_exit. Cc: qemu-sta...@nongnu.org Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/scsi/vhost-scsi.c| 11 +-- hw/scsi/virtio-scsi.c | 1

Re: [Qemu-devel] [PATCH 4/9] target-arm: A64: add support for ld/st with reg offset

2013-12-09 Thread Richard Henderson
On 12/09/2013 10:12 AM, Peter Maydell wrote: > From: Alex Bennée > > This adds support for the load/store forms using a register offset. > > Signed-off-by: Alex Bennée > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 141 > - > 1

Re: [Qemu-devel] [PATCH 3/9] target-arm: A64: add support for ld/st unsigned imm

2013-12-09 Thread Richard Henderson
On 12/09/2013 10:12 AM, Peter Maydell wrote: > From: Alex Bennée > > This adds support for the forms of ld/st with a 12 bit > unsigned immediate offset. > > Signed-off-by: Alex Bennée > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 95 > +++

[Qemu-devel] [PULL 28/30] virtio-scsi: Convert to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/scsi/vhost-scsi.c| 33 + hw/scsi/virtio-scsi.c | 32 +++- include/hw/virtio/virtio-scsi.h | 2 +- 3 files changed, 33 insert

[Qemu-devel] [PULL 26/30] virtio-balloon: Convert to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-balloon.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index e6f6b4b..755e188 100644 --- a/hw/virtio/v

[Qemu-devel] [PULL 30/30] virtio: Convert exit to unrealize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/block/virtio-blk.c | 10 ++ hw/char/virtio-serial-bus.c | 9 + hw/net/virtio-net.c | 9 + hw/scsi/vhost-scsi.c| 11 ++- hw/scsi/virtio-

[Qemu-devel] [PULL 25/30] virtio-net: Convert to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/net/virtio-net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a669f83..d9e4b8a 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/vir

[Qemu-devel] [PULL 27/30] virtio-rng: Convert to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-rng.c | 24 +++- include/hw/virtio/virtio-rng.h | 2 ++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-r

[Qemu-devel] [PULL 24/30] virtio-serial: Convert to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/char/virtio-serial-bus.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 313a5d8..df96117 100644 --- a/hw/

[Qemu-devel] [PULL 21/30] virtio: Start converting VirtioDevice to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Temporarily allow either VirtioDeviceClass::init or VirtioDeviceClass::realize. Introduce VirtioDeviceClass::unrealize for symmetry. Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 42 +++---

[Qemu-devel] [PULL 23/30] virtio-blk: Convert to QOM realize

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/block/virtio-blk.c | 24 tests/qdev-monitor-test.c | 4 +--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index

[Qemu-devel] [PULL 20/30] virtio-scsi: QOM realize preparations

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Rename qdev -> dev since that's what realize's argument is called by convention. No need to keep more "qdev" around than necessary. Avoid duplicate VIRTIO_DEVICE() cast. Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 14 +++

[Qemu-devel] [PULL 16/30] virtio-serial: QOM realize preparations

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/char/virtio-serial-bus.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index a7ede90..313a5d8 100644 --- a/hw/char

[Qemu-devel] [PULL 10/30] virtio-balloon: switch exit callback to VirtioDeviceClass

2013-12-09 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy, and avoids leaking bus_name which is freed by virtio_device_exit. Cc: qemu-sta...@nongnu.org Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-balloon.c | 10 -- 1 file changed, 4 insertions(+), 6 deleti

[Qemu-devel] [PULL 14/30] virtio-9p: QOM realize preparations

2013-12-09 Thread Paolo Bonzini
From: Andreas Färber Avoid unnecessary VIRTIO_DEVICE(). Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- hw/9pfs/virtio-9p-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index f0ffbe8..ea21655

[Qemu-devel] [PULL 08/30] virtio-net: switch exit callback to VirtioDeviceClass

2013-12-09 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy, and avoids leaking bus_name which is freed by virtio_device_exit. Cc: qemu-sta...@nongnu.org Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/net/virtio-net.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-)

[Qemu-devel] [PULL 07/30] virtio-serial: switch exit callback to VirtioDeviceClass

2013-12-09 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy, and avoids leaking bus_name which is freed by virtio_device_exit. Cc: qemu-sta...@nongnu.org Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/char/virtio-serial-bus.c | 10 -- 1 file changed, 4 insertions(+), 6 delet

[Qemu-devel] [PULL 06/30] virtio-blk: switch exit callback to VirtioDeviceClass

2013-12-09 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy, and avoids leaking bus_name which is freed by virtio_device_exit. Cc: qemu-sta...@nongnu.org Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/block/virtio-blk.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-

[Qemu-devel] [PULL 02/30] virtio-bus: remove vdev field

2013-12-09 Thread Paolo Bonzini
The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-bus.c | 65 +- hw/virtio/virtio-mmio.c| 9 +

[Qemu-devel] [PULL 04/30] virtio-pci: remove vdev field

2013-12-09 Thread Paolo Bonzini
The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Acked-by: Andreas Faerber Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-pci.c | 110 + hw/virtio/virtio-pci.h | 1 - 2 fil

[Qemu-devel] [PULL 00/30] virtio conversion to realize and hotplug/unplug fixes

2013-12-09 Thread Paolo Bonzini
Anthony, the following changes since commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e: Open 2.0 development tree (2013-11-27 14:02:45 -0800) are available in the git repository at: git://github.com/bonzini/qemu.git virtio for you to fetch changes up to 306ec6c3cece7004429c79c1ac93d49919f1f1

Re: [Qemu-devel] [PATCH for-1.7] spapr: tie spapr-nvram to -pflash

2013-12-09 Thread Paolo Bonzini
Il 09/12/2013 20:25, Alexander Graf ha scritto: > > >> Am 22.11.2013 um 10:27 schrieb Paolo Bonzini : >> >> spapr-nvram's drive property is currently connected to a non-existent >> "-machine nvram=" option. Instead, tie it to -pflash like >> other non-volatile RAM devices. This provides the fol

  1   2   3   >