On Fri, Dec 20, 2013 at 11:10:30AM +0100, Stefan Hajnoczi wrote:
On Thu, Dec 19, 2013 at 10:27:37AM +0800, Hu Tao wrote:
diff --git a/block.c b/block.c
index 64e7d22..b901587 100644
--- a/block.c
+++ b/block.c
@@ -3216,6 +3216,19 @@ bool
On Mon, Dec 23, 2013 at 10:17:15PM +, Peter Maydell wrote:
FWIW mainline's handling of this insn doesn't have this bug.
OT: Is there a clear explanation of the various aarch64 trees?
I noticed that upstream qemu has some files like target-arm/
translate-a64.c, but it didn't (and still
On Tue, Dec 24, 2013 at 02:09:07PM +1100, Alexey Kardashevskiy wrote:
On 12/24/2013 03:24 AM, Michael S. Tsirkin wrote:
On Mon, Dec 23, 2013 at 02:01:13AM +1100, Alexey Kardashevskiy wrote:
On 12/23/2013 01:46 AM, Alexey Kardashevskiy wrote:
On 12/22/2013 09:56 PM, Michael S. Tsirkin wrote:
On Tue, Dec 17, 2013 at 12:33 PM, Amos Kong ak...@redhat.com wrote:
In my test host, When I use the egd-socket, it is very slow.
So I use a quick souce /dev/urandom, we ignore the egd protocol
here, it might be wrong.
Can you suggest a way to test this the right way?
It seems we should
On 24 December 2013 08:45, Richard W.M. Jones rjo...@redhat.com wrote:
On Mon, Dec 23, 2013 at 10:17:15PM +, Peter Maydell wrote:
FWIW mainline's handling of this insn doesn't have this bug.
OT: Is there a clear explanation of the various aarch64 trees?
I noticed that upstream qemu has
These two patches for the Cocoa UI:
http://patchwork.ozlabs.org/patch/304879/
http://patchwork.ozlabs.org/patch/304878/
fix issue (2) so Cocoa now also displays a plain black window for this
guest, like the SDL frontend does on Linux.
--
You received this bug notification because you are a
Il 24/12/2013 01:18, Andreas Färber ha scritto:
Thanks, I have squashed it, but I would appreciate if someone more
familiar with interfaces could take a quick look at my commit message
before I send a PULL tomorrow. Should I drop Reported-by during squash?
Am 24.12.2013 07:49, schrieb Alexey Kardashevskiy:
On 12/20/2013 10:43 PM, Alexey Kardashevskiy wrote:
On 12/20/2013 10:29 PM, Andreas Färber wrote:
Am 19.12.2013 12:38, schrieb Alexey Kardashevskiy:
What I wonder about is what is going to happen to the rest of what I
posted? Should I wait
Am 24.12.2013 12:17, schrieb Paolo Bonzini:
Il 24/12/2013 01:18, Andreas Färber ha scritto:
Thanks, I have squashed it, but I would appreciate if someone more
familiar with interfaces could take a quick look at my commit message
before I send a PULL tomorrow. Should I drop Reported-by during
Am 24.12.2013 03:52, schrieb Chen Fan:
On Tue, 2013-12-24 at 03:38 +0100, Andreas Färber wrote:
Replace growing numbers of inline x86_env_get_cpu() with x86_cpu variable.
Signed-off-by: Andreas Färber afaer...@suse.de
---
cpu-exec.c | 14 ++
1 file changed, 10 insertions(+), 4
The ui/cocoa.m file has just three lines with hardcoded tabs; fix them.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
I'm generally fairly conservative about fix indent patches,
but three lines seems sufficiently minimal to be worth just
zapping. Happy to drop this if people disagree.
Am 24.12.2013 12:54, schrieb Peter Maydell:
The ui/cocoa.m file has just three lines with hardcoded tabs; fix them.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
I'm generally fairly conservative about fix indent patches,
but three lines seems sufficiently minimal to be worth
On 24 December 2013 12:00, Stefan Weil s...@weilnetz.de wrote:
Am 24.12.2013 12:54, schrieb Peter Maydell:
The ui/cocoa.m file has just three lines with hardcoded tabs; fix them.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
I'm generally fairly conservative about fix indent
From: Richard Henderson r...@twiddle.net
Don't duplicate the array length computation in the memset()
when plain sizeof() can produce the correct results.
Signed-off-by: Richard Henderson r...@twiddle.net
Reviewed-by: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Andreas Färber
Hello Anthony,
This is my current QOM CPU patch queue. Please pull.
Happy holidays,
Andreas
Cc: Anthony Liguori anth...@codemonkey.ws
Cc: Aurélien Jarno aurel...@aurel32.net
Cc: Igor Mammedov imamm...@redhat.com
Cc: Chen Fan chen.fan.f...@cn.fujitsu.com
Cc: Richard Henderson r...@twiddle.net
From: Igor Mammedov imamm...@redhat.com
* Additionally convert check_cpuid enforce_cpuid to bool and make them
members of X86CPU
* Make 'enforce' feature independent from 'check'
Signed-off-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
Replace growing numbers of inline x86_env_get_cpu() with x86_cpu variable.
Reviewed-by: Chen Fan chen@cn.fujitsu.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
cpu-exec.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index
From: Richard Henderson r...@twiddle.net
The size of tlb_table is 4k on a 64-bit host. For overwriting
memory at this size, cacheline tricks can help.
Signed-off-by: Richard Henderson r...@twiddle.net
Reviewed-by: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Andreas Färber
From: Chen Fan chen.fan.f...@cn.fujitsu.com
This motion is preparing for refactoring vCPU APIC subsequently.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
cpu-exec.c| 2 +-
cpus.c| 5 ++---
From: Igor Mammedov imamm...@redhat.com
Signed-off-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-i386/cpu.c | 45 -
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/target-i386/cpu.c
From: Igor Mammedov imamm...@redhat.com
Features check, enforce, hv_relaxed and hv_vapic are treated as boolean
set to 'on' when passed from command line, so it's not necessary to
handle each of them separately. Collapse them to one catch-all branch
which will treat any feature in format 'foo' as
From: Igor Mammedov imamm...@redhat.com
Signed-off-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-i386/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index e20b0c8..0e00a8a 100644
From: Igor Mammedov imamm...@redhat.com
Signed-off-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-i386/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 0e00a8a..7d5b58c 100644
From: Igor Mammedov imamm...@redhat.com
Features family, model, stepping, level, hv_spinlocks are treated similarly
when passed from command line, so it's not necessary to handle each of them
individually. Collapse them to one catch-all branch which will treat
any not explicitly handled feature
Am 23.12.2013 17:08, schrieb Peter Maydell:
On 8 December 2013 22:59, Peter Maydell peter.mayd...@linaro.org wrote:
This patchset is a collection of minor Cocoa UI patches:
* the 'pass command key through when mousegrabbed' patch I sent
earlier (included here for convenience since the
On 12/17/2013 05:25 PM, Juan Quintela wrote:
Move index and size fields from int to long. We need that for
migration. long is 64 bits on sane architectures, and 32bits should
be enough on all the 32bits architectures.
Signed-off-by: Juan Quintela quint...@redhat.com
---
On 23/12/13 20:02, Andreas Färber wrote:
So the issue is actually that the OHW binary is really messed up.
And me, Hervé and Mark have been working on getting OpenBIOS working for
PReP in its place.
It may be worth adding that when Hervé's latest patches are applied to
OpenBIOS SVN trunk
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
Use the bit number for SR constants instead of using a bit mask. This
make possible to also use the constants for shifts.
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
---
target-sh4/cpu.c |3 +-
target-sh4/cpu.h | 30
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
+static inline target_ulong cpu_read_sr(CPUSH4State *env)
+{
+return (env-sr ~(1u SR_T)) | (env-sr_t SR_T);
+}
+
+static inline void cpu_write_sr(CPUSH4State *env, target_ulong sr)
+{
+env-sr_t = sr (1u SR_T);
+env-sr = sr
On 12/24/2013 08:40 PM, Michael S. Tsirkin wrote:
On Tue, Dec 24, 2013 at 02:09:07PM +1100, Alexey Kardashevskiy wrote:
On 12/24/2013 03:24 AM, Michael S. Tsirkin wrote:
On Mon, Dec 23, 2013 at 02:01:13AM +1100, Alexey Kardashevskiy wrote:
On 12/23/2013 01:46 AM, Alexey Kardashevskiy wrote:
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
+t2 = tcg_temp_new();
+tcg_gen_add2_i32(t1, t2, REG(B11_8), t0, REG(B7_4), t0);
+tcg_gen_add2_i32(REG(B11_8), cpu_sr_t, t1, t2, cpu_sr_t, t0);
FWIW, one can avoid an extra temporary by consuming cpu_sr_t in the
Hi Vasiliy,
On Mon, Dec 23, 2013 at 01:58:12PM +0400, Vasiliy Tolstov wrote:
Hi all. I need to write some qemu block driver (like sheepdog or ceph).
Where i can find some docs/tips/tutorials what functions i need to implement?
Thank you.
I haven't taken the time to look at it yet, but there
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
---
target-sh4/translate.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson r...@twiddle.net
r~
On 23/12/13 21:00, Peter Bartoli wrote:
I currently have patches for a CG3 framebuffer pending that will enable
you to boot Solaris into graphics mode, which I hope will be applied soon.
That is AWESOME news. Really, I'm hoping to just have a text-based
console like on my SS5 with the old
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
+TCGv t0 = tcg_const_i32(0);
+tcg_gen_add2_i32(REG(B11_8), cpu_sr_t,
+ REG(B7_4), t0, cpu_sr_t, t0);
+tcg_gen_sub2_i32(REG(B11_8), cpu_sr_t,
+ t0, t0,
On 23/12/13 23:50, Peter Maydell wrote:
The 32-bit SPARC emulator's TCX emulation seems to work with
OpenBIOS, but doesn't work with a SparcStation ROM on Cocoa
This is actually two separate issues.
(1) This SS-5 ROM doesn't boot on QEMU. You can see this if
you try it on a Linux host : the
On 12/17/2013 05:37 PM, Alexey Kardashevskiy wrote:
On 12/04/2013 04:34 PM, Alexey Kardashevskiy wrote:
On 11/16/2013 03:58 AM, Alexey Kardashevskiy wrote:
On 16.11.2013 0:15, Alexander Graf wrote:
Am 15.11.2013 um 00:12 schrieb Alexey Kardashevskiy a...@ozlabs.ru:
At the moment only a
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
static void gen_read_sr(TCGv dst)
{
-tcg_gen_andi_i32(dst, cpu_sr, ~(1u SR_T));
-tcg_gen_or_i32(dst, dst, cpu_sr_t);
+TCGv t0 = tcg_temp_new();
+tcg_gen_andi_i32(dst, cpu_sr,
+ ~((1u SR_Q) | (1u SR_M) |
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
---
target-sh4/translate.c |1 -
1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson r...@twiddle.net
r~
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
---
target-sh4/translate.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
Reviewed-by: Richard Henderson r...@twiddle.net
r~
On 24 December 2013 13:03, Andreas Färber andreas.faer...@web.de wrote:
Am 23.12.2013 17:08, schrieb Peter Maydell:
On 8 December 2013 22:59, Peter Maydell peter.mayd...@linaro.org wrote:
This patchset is a collection of minor Cocoa UI patches:
* the 'pass command key through when
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
Now that setcondi is used instead of branches, temp_local are not needed
anymore.
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
---
target-sh4/translate.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
Reviewed-by:
Juan Quintela quint...@redhat.com wrote:
D Hi
First of all, poll told to move the call earlier.
9:00 EST (15:00 CET or 6:00 Pacific)
Are we having a call on the 24th? Do we have any topics? Are enough
people not on vacation?
I guess that christmas win, and no call.
Have a happy
On 12/18/2013 12:48 PM, Tom Musta wrote:
This patch adds a flag for base instruction additions to Power ISA
2.06B. The flag will be used to identify/select basic Book I and
Book II instructions that were newly added in that revision of the
architecture. The flag will not be used for VSX or
On 12/18/2013 12:48 PM, Tom Musta wrote:
+DEF_HELPER_3(bpermd, i64, env, i64, i64)
Should be DEF_HELPER_FLAGS_2(bpermd, TCG_CALL_NO_RWG_SE, i64, i64, i64)
+uint64_t helper_bpermd(CPUPPCState *env, uint64_t rs, uint64_t rb)
+{
+int i;
+uint64_t ra = 0;
+
+for (i = 0; i 8; i++)
On 12/18/2013 12:48 PM, Tom Musta wrote:
This patch adds the Divide Doubleword Extended Unsigned
instructions. This instruction requires dividing a 128-bit
value by a 64 bit value. Since 128 bit integer division is
not supported in TCG, a helper is used, providing a
repeated difference
On 12/18/2013 12:48 PM, Tom Musta wrote:
+*plow = result;
+*phigh = dividend % divisor;
+return (result INT64_MAX) | (result INT64_MIN);
Probably better as
return result != *plow;
Otherwise,
Reviewed-by: Richard Henderson r...@twiddle.net
r~
On 12/18/2013 12:48 PM, Tom Musta wrote:
+tcg_gen_div_i64(cpu_gpr[rD(ctx-opcode)], ra, rb);
\
+tmp0 = tcg_temp_local_new();
\
+/* does the result fit in 32 bits? */
\
+
On 12/18/2013 12:48 PM, Tom Musta wrote:
This patch adds the byte and halfword variations of the Load and
Reserve instructions. Since there is much commonality among
all forms of Load and Reserve, a common macro is provided and the
existing implementations of lwarx and ldarx are
On 12/23/2013 12:10 PM, Alexander Graf wrote:
On 23.12.2013, at 19:08, Andreas Färber afaer...@suse.de wrote:
Am 20.12.2013 02:00, schrieb Alexander Graf:
Alex, we now have those meaningless-without-context commit messages in
qemu.git history. I'm pretty sure I asked the contributor
On 12/18/2013 12:49 PM, Tom Musta wrote:
This patch adds the byte and halfword variants of the Store Conditional
instructions. A common macro is introduced and the existing implementations
of stwcx. and stdcx. are re-implemented using this macro.
V2: Re-implemented gen_conditional_store()
On 12/18/2013 12:49 PM, Tom Musta wrote:
This patch adds the four floating point to integer conversion instructions
introduced by Power ISA V2.06:
- Floating Convert to Integer Word Unsigned (fctiwu)
- Floating Convert to Integer Word Unsigned with Round Toward
Zero (fctiwuz)
-
On Wed, Dec 25, 2013 at 01:15:29AM +1100, Alexey Kardashevskiy wrote:
On 12/24/2013 08:40 PM, Michael S. Tsirkin wrote:
On Tue, Dec 24, 2013 at 02:09:07PM +1100, Alexey Kardashevskiy wrote:
On 12/24/2013 03:24 AM, Michael S. Tsirkin wrote:
On Mon, Dec 23, 2013 at 02:01:13AM +1100, Alexey
On 12/18/2013 12:49 PM, Tom Musta wrote:
+#define FPU_FCFI(op, cvtr, is_single) \
+uint64_t helper_##op(CPUPPCState *env, uint64_t arg) \
+{ \
+CPU_DoubleU farg; \
+
On 12/18/2013 12:49 PM, Tom Musta wrote:
The fri* series of instructions was introduced prior to ISA 2.06 and
is supported on Power7 and Power8 hardware. However, the instruction
is still considered illegal in the P7 and P8 QEMU emulation models.
This patch enables these instructions for the
f976b09ea2493fd41c98aaf6512908db0bae:
PPC: Fix compilation with TCG debug (2013-12-22 19:15:55 +0100)
are available in the git repository at:
git://github.com/juanquintela/qemu.git tags/migration/20131224
for you to fetch changes up to bc864a4f0ce79a8f4c09bc479a81c5f919ee48f6:
ram: align
On 12/18/2013 12:49 PM, Tom Musta wrote:
+env-crf[bf] = 0x8 | (fg_flag ? 4 : 0) | (fe_flag ? 2 : 0);
+}
You should return that value instead of assigning it. Then you need neither
the env nor bf arguments, and the whole function can be TCG_CALL_NO_RWG_SE.
+static void
On 12/18/2013 12:49 PM, Tom Musta wrote:
+static void gen_ftsqrt(DisasContext *ctx)
+{
+TCGv_i32 bf;
+if (unlikely(!ctx-fpu_enabled)) {
+gen_exception(ctx, POWERPC_EXCP_FPU);
+return;
+}
+/* NIP cannot be restored if the memory exception comes from an helper
On 12/18/2013 12:49 PM, Tom Musta wrote:
The frsqrtes instruction was introduced prior to ISA 2.06 and is
support on both the Power7 and Power8 processors. However, this
instruction is handled as illegal in the current QEMU emulation
machines. This patch enables the existing implemention of
On 12/18/2013 12:49 PM, Tom Musta wrote:
This patch adds the Load Floating Point as Integer Word and
Zero Indexed (lfiwzx) instruction which was introduced in
Power ISA 2.06.
Signed-off-by: Tom Musta tommu...@gmail.com
---
target-ppc/translate.c | 15 +++
1 files changed,
On 12/18/2013 12:19 PM, Tom Musta wrote:
+if (unlikely(tp##_is_any_nan(xa.fld[i]) ||
\
+ tp##_is_any_nan(xb.fld[i]))) {
\
+if (tp##_is_signaling_nan(xa.fld[i])) {
\
+
From: Markus Armbruster arm...@redhat.com
Many PCI host bridges consist of a sysbus device and a PCI device.
You need both for the thing to work. Arguably, these bridges should
be modelled as a single, composite devices instead of pairs of
seemingly independent devices you can only use together,
Hello Anthony,
This is my QOM (devices) patch queue. Please pull.
Happy holidays,
Andreas
P.S. I reproducibly get a signal message:
TEST: tests/acpi-test... (pid=6364)
/i386/acpi/tcg:
main-loop: WARNING: I/O thread spun for 1000
From: Markus Armbruster arm...@redhat.com
device_add plugs devices into suitable bus. For real buses, that
actually connects the device. For sysbus, the connections need to be
made separately, and device_add can't do that. The device would be
left unconnected, and could not possibly work.
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
qom/cpu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qom/cpu.c
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/intc/apic_common.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
From: Markus Armbruster arm...@redhat.com
A VT82C686B southbridge has multiple functions. We model each
function as a separate qdev. One of them need some special wiring set
up in mips_fulong2e_init() to work: the ISA bridge at 05.0.
The IDE controller at 05.1 (via-ide) has always had
From: Markus Armbruster arm...@redhat.com
Drop it when there's no obvious reason why device_add could not work.
Else keep and document why.
* isa-fdc: drop
* i8042: drop, even though its I/O base is hardcoded (because you
could conceivably still add one to a board that has none), and even
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The object-cast and class-cast caches cannot be shared because class
caching is conditional on the target type not being an interface and
object caching is unconditional. Leads to a bug when a class cast
to an interface follows an object cast
From: Hervé Poussineau hpous...@reactos.org
We should not modify the type hash table while it is being iterated on.
Assert that it does not happen.
Signed-off-by: Hervé Poussineau hpous...@reactos.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Alexey Kardashevskiy
From: Markus Armbruster arm...@redhat.com
An ICH9 southbridge contains several PCI devices, some of them with
multiple functions. We model each function as a separate qdev. Two
of them need some special wiring set up in pc_q35_init() to work: the
LPC controller at 00:1f.0, and the SMBus
From: Igor Mammedov imamm...@redhat.com
Add basic regression testing for QOM Interface usage.
Test checks casting to interface type/class for following cases:
- interface implementation in leaf class
- interface implementation in intermediate (parent) class
Signed-off-by: Igor Mammedov
From: Markus Armbruster arm...@redhat.com
A PIIX3/PIIX4 southbridge has multiple functions. We model each
function as a separate qdev. Two of them need some special wiring set
up in pc_init1() or mips_malta_init() to work: the ISA bridge at 01.0,
and the SMBus controller at 01.3.
The IDE
From: Markus Armbruster arm...@redhat.com
Such devices have always been unavailable and omitted from the list of
available devices shown by device_add help. Until commit 18b6dad
silently broke the former, setting up nasty traps for unwary users,
like this one:
$ qemu-system-x86_64
From: Stefan Hajnoczi stefa...@redhat.com
Same reasoning as commit 02a5c4c97422b40034f31265e0f139f7846172a8
(qdev: Drop misleading qdev_free() function). The qbus_free()
function removes the child from the namespace and decrements the
reference count. It does not, however, guarantee to free the
From: Markus Armbruster arm...@redhat.com
In an ideal world, machines can be built by wiring devices together
with configuration, not code. Unfortunately, that's not the world we
live in right now. We still have quite a few devices that need to be
wired up by code. If you try to device_add
From: xiaoqiang zhao zxq_yx_...@163.com
For consistency, QOM'ify APIC's parent bus.
Signed-off-by: xiaoqiang zhao zxq_yx_...@163.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/cpu/icc_bus.c | 14 ++
hw/intc/apic_common.c| 13 +++--
From: xiaoqiang zhao zxq_yx_...@163.com
Some cleanups:
* ioapic_common.c: Rename 'register_types' to 'ioapic_common_register_types'
* Replace inline 'DEVICE(s)' with local 'DeviceState *dev' variable
Signed-off-by: xiaoqiang zhao zxq_yx_...@163.com
Signed-off-by: Andreas Färber afaer...@suse.de
From: Markus Armbruster arm...@redhat.com
Pointer properties can be set only by code, not by device_add. A
device with a pointer property can work with device_add only when the
property may remain null.
This is the case for property interrupt_vector of device
etraxfs,pic. Add a comment there.
From: xiaoqiang zhao zxq_yx_...@163.com
Convert 'init' function to QOM's 'realize' for apic, kvm/apic and
xen/xen_apic.
Signed-off-by: xiaoqiang zhao zxq_yx_...@163.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/i386/kvm/apic.c | 6 --
hw/intc/apic.c
From: Markus Armbruster arm...@redhat.com
In an ideal world, machines can be built by wiring devices together
with configuration, not code. Unfortunately, that's not the world we
live in right now. We still have quite a few devices that need to be
wired up by code. If you try to device_add
From: Paolo Bonzini pbonz...@redhat.com
There should be no need to look up nor enumerate the interface types,
whose classes are really just vtables. Just create the types and
add them to the interface list of the parent type.
Interfaces not registering their type anymore means that accessing
From: Markus Armbruster arm...@redhat.com
Ask users of DEFINE_PROP_PTR() to set
cannot_instantiate_with_device_add_yet, or explain why it's not
needed.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
include/hw/qdev-properties.h | 17
Hello Anthony,
This is my fixed QOM (devices) patch queue. Please pull.
Happy holidays,
Andreas
P.S. I reproducibly get a signal message:
TEST: tests/acpi-test... (pid=6364)
/i386/acpi/tcg:
main-loop: WARNING: I/O thread spun for 1000
From: Markus Armbruster arm...@redhat.com
Watch this:
$ upstream-qemu -nodefaults -S -display none -monitor stdio
QEMU 1.7.50 monitor - type 'help' for more information
(qemu) device_add rng-egd
/work/armbru/qemu/qdev-monitor.c:491:qdev_device_add: Object 0x2089b00 is
not an
Am 24.12.2013 17:56, schrieb Andreas Färber:
Hello Anthony,
This is my QOM (devices) patch queue. Please pull.
Happy holidays,
Andreas
P.S. I reproducibly get a signal message:
TEST: tests/acpi-test... (pid=6364)
/i386/acpi/tcg:
From: xiaoqiang zhao zxq_yx_...@163.com
Convert 'init' function to QOM's 'realize' for ioapic and kvm-ioapic.
Change variable 'ioapic_no' from static to global. Then we can drop
the 'instance_no' function argument.
Signed-off-by: xiaoqiang zhao zxq_yx_...@163.com
Signed-off-by: Andreas Färber
From: Markus Armbruster arm...@redhat.com
Pointer properties can be set only by code, not by device_add. A
device with a pointer property can work with device_add only when the
property may remain null.
This is the case for property interrupt_vector of device
etraxfs,pic. Add a comment there.
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/intc/apic_common.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
From: xiaoqiang zhao zxq_yx_...@163.com
Do some cleanup, including:
1. Remove DO_UPCAST() for APICCommonState
2. Change DeviceState pointers from 'd' to 'dev', better to understand
3. Rename 'register_types' to specifically 'apic_common_register_types'
Signed-off-by: xiaoqiang zhao
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The object-cast and class-cast caches cannot be shared because class
caching is conditional on the target type not being an interface and
object caching is unconditional. Leads to a bug when a class cast
to an interface follows an object cast
From: Stefan Hajnoczi stefa...@redhat.com
Same reasoning as commit 02a5c4c97422b40034f31265e0f139f7846172a8
(qdev: Drop misleading qdev_free() function). The qbus_free()
function removes the child from the namespace and decrements the
reference count. It does not, however, guarantee to free the
From: Hervé Poussineau hpous...@reactos.org
We should not modify the type hash table while it is being iterated on.
Assert that it does not happen.
Signed-off-by: Hervé Poussineau hpous...@reactos.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Alexey Kardashevskiy
From: Markus Armbruster arm...@redhat.com
device_add plugs devices into suitable bus. For real buses, that
actually connects the device. For sysbus, the connections need to be
made separately, and device_add can't do that. The device would be
left unconnected, and could not possibly work.
From: Markus Armbruster arm...@redhat.com
A VT82C686B southbridge has multiple functions. We model each
function as a separate qdev. One of them need some special wiring set
up in mips_fulong2e_init() to work: the ISA bridge at 05.0.
The IDE controller at 05.1 (via-ide) has always had
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
qom/cpu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qom/cpu.c
From: Markus Armbruster arm...@redhat.com
Once upon a time, the error message was:
qemu: -device nonexistant: Device nonexistant not found. Try -device '?'
for a list.
But progress marches on, and conversion to QError (commit 0204276)
changed it into:
Invalid parameter 'driver'
From: Paolo Bonzini pbonz...@redhat.com
There should be no need to look up nor enumerate the interface types,
whose classes are really just vtables. Just create the types and
add them to the interface list of the parent type.
Interfaces not registering their type anymore means that accessing
From: Markus Armbruster arm...@redhat.com
Ask users of DEFINE_PROP_PTR() to set
cannot_instantiate_with_device_add_yet, or explain why it's not
needed.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
include/hw/qdev-properties.h | 17
From: Markus Armbruster arm...@redhat.com
Drop it when there's no obvious reason why device_add could not work.
Else keep and document why.
* isa-fdc: drop
* i8042: drop, even though its I/O base is hardcoded (because you
could conceivably still add one to a board that has none), and even
1 - 100 of 119 matches
Mail list logo
