[Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list

Cc: Laszlo Ersek Signed-off-by: Hu Tao --- qapi/string-input-visitor.c | 160 -- tests/test-string-input-visitor.c | 22 ++ 2 files changed, 176 insertions(+), 6 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c in

[Qemu-devel] [PATCH v18 06/14] qapi: add SIZE type parser to string_input_visitor

From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- qapi/string-input-visitor.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index 8f1bc41..a152f5d 100644 -

[Qemu-devel] [PATCH v18 03/14] NUMA: Add numa_info structure to contain numa nodes info

From: Wanlong Gao Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Reviewed-by: Eduardo Habkost Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --

[Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

Thus makes user control how to allocate memory for ram backend. Signed-off-by: Hu Tao --- backends/hostmem-ram.c | 158 include/sysemu/sysemu.h | 2 + 2 files changed, 160 insertions(+) diff --git a/backends/hostmem-ram.c b/backends/hostmem-ra

[Qemu-devel] [PATCH v18 01/14] NUMA: move numa related code to new file numa.c

From: Wanlong Gao Signed-off-by: Wanlong Gao Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- Makefile.target | 2 +- cpus.c | 14 include/sysemu/cpus.h | 1 - include/sysemu/sysemu.h | 3 + numa.c | 183 +++

[Qemu-devel] [PATCH v18 00/14] Add support for binding guest numa nodes to host numa nodes

The major change from v17 is the patchset is now based on memory backend. Example command line: ./x86_64-softmmu/qemu-system-x86_64 -hda /path/to/image.img -smp 2 \ -object memory-ram,size=512M,host-nodes=1,policy=membind,id=ram-node0 \ -numa node,nodeid=0,cpus=0,memdev=ram-node0 \ -objec

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

On Tue, 2014-02-18 at 13:11 -0800, Nicholas A. Bellinger wrote: > On Tue, 2014-02-18 at 13:00 -0800, Nicholas A. Bellinger wrote: > > On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote: > > > > > > > > > > > > Hi Yan, > > > > > > > > > > > > So recently I've been doing some KVM gues

Re: [Qemu-devel] [PATCH] qom: add object_property_is_set

On Tue, 2014-02-18 at 18:49 +0100, Andreas Färber wrote: > Am 18.02.2014 18:26, schrieb Paolo Bonzini: > > Il 18/02/2014 18:11, Marcel Apfelbaum ha scritto: > >> It is used to replace qemu_opt_get_bool that provides a > >> parameter for a default value. In this case we need to > >> differentiate "n

Re: [Qemu-devel] [PATCH] qom: add object_property_is_set

On Tue, 2014-02-18 at 18:26 +0100, Paolo Bonzini wrote: > Il 18/02/2014 18:11, Marcel Apfelbaum ha scritto: > > It is used to replace qemu_opt_get_bool that provides a > > parameter for a default value. In this case we need to > > differentiate "no value" from "false." > > But what would the gette

[Qemu-devel] How interrupts are handled in QEMU?

How interrupts are handled in QEMU?

[Qemu-devel] [PATCH] gtk: Support GTK without VTE

GTK without VTE is needed for hosts which don't support VTE (for example all variants of MinGW), but it can also be reasonable for other hosts. Signed-off-by: Stefan Weil --- configure | 54 +- ui/gtk.c | 17 - 2 files chan

Re: [Qemu-devel] How to add a new virtual hardware like interrupt unit in QEMU?

Am 19.02.2014 06:23, schrieb atlas khan: > How to add a new virtual hardware like interrupt unit in QEMU? > Have a look at the code in directory hw/intc. Maybe those examples help. Regards, Stefan W.

[Qemu-devel] How to add a new virtual hardware like interrupt unit in QEMU?

How to add a new virtual hardware like interrupt unit in QEMU?

Re: [Qemu-devel] [PATCH 2/2] bswap: Modify prototypes of st[wl]_{le, be}_p (avoid type conversions)

Am 19.02.2014 06:11, schrieb Stefan Weil: > The function use uint16_t or uint32_t values, so show this in the function The functions ... > prototypes. Non-optimizing compilers will avoid unnecessary type > conversions when generating calls of these inline function. ... inline functions. Maybe t

[Qemu-devel] [PATCH 2/2] bswap: Modify prototypes of st[wl]_{le, be}_p (avoid type conversions)

The function use uint16_t or uint32_t values, so show this in the function prototypes. Non-optimizing compilers will avoid unnecessary type conversions when generating calls of these inline function. stq_le_p, stq_be_p already use similar prototypes. Signed-off-by: Stefan Weil --- include/qemu/

[Qemu-devel] [PATCH 0/2] bswap: Clean prototypes of st* functions

These modifications avoid type conversions for non optimized code. ld* function prototypes will follow later. [PATCH 1/2] bswap: Modify prototype of stb_p (avoid type [PATCH 2/2] bswap: Modify prototypes of st[wl]_{le,be}_p (avoid type

[Qemu-devel] [PATCH 1/2] bswap: Modify prototype of stb_p (avoid type conversions)

The function uses an uint8_t value, so show this in the function prototype. Non-optimizing compilers will avoid unnecessary type conversions from (u)int8_t to int and back to uint8_t when generating calls of this inline function. stw_p, stl_p and stq_p already use similar prototypes. Signed-off-b

Re: [Qemu-devel] [RFC PATCH v2 08/12] mc: core logic

On 02/19/2014 10:53 AM, Li Guang wrote: Michael R. Hines wrote: On 02/19/2014 09:07 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This implements the core logic, all described in the first patch (docs/mc.txt). Signed-off-by: Michael R. Hines --- migrati

Re: [Qemu-devel] Buildbot failure: MinGW

Hi Gerd, hi Stefan, we now need a C++ compiler on the buildbots. Currently, it's missing for MinGW: /bin/sh: i686-pc-mingw32-g++: command not found Cheers Stefan

Re: [Qemu-devel] [RFC PATCH v1 0/3] provenance: save migration stats after completion to destination

On 02/19/2014 10:40 AM, Eric Blake wrote: On 02/18/2014 07:30 PM, Michael R. Hines wrote: qemu 2.0 -> 2.0: pass the smaller struct from source, expect the smaller struct on dest, no problem qemu 2.0 -> 2.1: pass the smaller struct from source, dest notices the optional field is missing and cope

Re: [Qemu-devel] [PATCH] object: Report type in error when not user creatable.

cced: Igor On Tue, Feb 18, 2014 at 11:42:36PM +0100, Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles > --- > qmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qmp.c b/qmp.c > index d0d98e7..f556a04 100644 > --- a/qmp.c > +++ b/qmp.c > @@ -556,8 +556,8 @@

Re: [Qemu-devel] Broken build slaves

On 16/02/14 8:00 PM, Brad Smith wrote: What's up with the broken build slaves? What changed over a week ago that has resulted in a bunch of them failing to work at all? Whomever fixed the issue that was tripping up the build slaves, thanks. -- This message has been scanned for viruses and dang

Re: [Qemu-devel] [RFC PATCH v2 08/12] mc: core logic

Michael R. Hines wrote: On 02/19/2014 09:07 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This implements the core logic, all described in the first patch (docs/mc.txt). Signed-off-by: Michael R. Hines --- migration-checkpoint.c | 1565 +

Re: [Qemu-devel] [RFC PATCH v1 0/3] provenance: save migration stats after completion to destination

On 02/18/2014 07:30 PM, Michael R. Hines wrote: >> qemu 2.0 -> 2.0: pass the smaller struct from source, expect the smaller >> struct on dest, no problem >> qemu 2.0 -> 2.1: pass the smaller struct from source, dest notices the >> optional field is missing and copes with no problem >> qemu 2.1 ->

Re: [Qemu-devel] [RFC PATCH v1 0/3] provenance: save migration stats after completion to destination

On 02/18/2014 09:40 PM, Eric Blake wrote: On 02/17/2014 10:53 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This series allows us to send the contents of the entire MigrationInfo structure to the destination once the migration is over. This is very useful for analyzing the re

Re: [Qemu-devel] [RFC PATCH v2 08/12] mc: core logic

On 02/19/2014 09:07 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This implements the core logic, all described in the first patch (docs/mc.txt). Signed-off-by: Michael R. Hines --- migration-checkpoint.c | 1565 ++

Re: [Qemu-devel] [RFC PATCH v2 06/12] mc: introduce state machine changes for MC

On 02/19/2014 09:00 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This patch sets up the initial changes to the migration state machine and prototypes to be used by the checkpointing code to interact with the state machine so that we can later handle failur

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

Beniamino Galvani wrote: On Tue, Feb 18, 2014 at 11:49:51AM +0800, Li Guang wrote: Beniamino Galvani wrote: According to this mail thread [1], writing to pending register seems to have no effect on actual pending status of interrupts. This means that the only way to clear a pending in

Re: [Qemu-devel] [PATCH 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

Beniamino Galvani wrote: On Tue, Feb 18, 2014 at 12:17:04PM +0800, Li Guang wrote: Beniamino Galvani wrote: The model was generating interrupts for all enabled timers after the expiration of one of them. Avoid this by passing to the timer callback function a structure containing the i

Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage

On 02/18/2014 06:32 PM, Dr. David Alan Gilbert wrote: * mrhi...@linux.vnet.ibm.com (mrhi...@linux.vnet.ibm.com) wrote: From: "Michael R. Hines" We also later export these statistics over QMP for better monitoring of micro-checkpointing as the workload changes. @@ -548,9 +568,11 @@ static i

Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing

On 02/18/2014 08:45 PM, Dr. David Alan Gilbert wrote: +The Micro-Checkpointing Process +Basic Algorithm +Micro-Checkpoints (MC) work against the existing live migration path in QEMU, and can effectively be understood as a "live migration that never ends". As such, iteration rounds happen at the

Re: [Qemu-devel] [RFC PATCH v2 00/12] mc: fault tolerante through micro-checkpointing

On 02/18/2014 05:28 PM, Li Guang wrote: Hi, Michael this patch-set will break normal build(without --enable-mc): migration.c: In function ‘migrate_rdma_pin_all’: migration.c:564: error: ‘MIGRATION_CAPABILITY_X_RDMA_PIN_ALL’ undeclared (first use in this function) migration.c:564: error: for

Re: [Qemu-devel] [RFC PATCH v2 08/12] mc: core logic

Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This implements the core logic, all described in the first patch (docs/mc.txt). Signed-off-by: Michael R. Hines --- migration-checkpoint.c | 1565 1 file changed, 1565 insertions(+

Re: [Qemu-devel] [RFC PATCH v2 06/12] mc: introduce state machine changes for MC

Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This patch sets up the initial changes to the migration state machine and prototypes to be used by the checkpointing code to interact with the state machine so that we can later handle failure and recovery scenarios. Signed-off-by:

Re: [Qemu-devel] KVM call minutes for 2014-02-18

On 18 February 2014 15:05, Juan Quintela wrote: > * Maintenance? > - How is being handling patches for the stable release? > CC: stable@ for stable maintance. > - add documentation about what/how to send patches for stable release > - Regressions deserve a backport almost always? > - There is n

Re: [Qemu-devel] [PATCH 4/7] allwinner-a10-pit: use level triggered interrupts

On Tue, Feb 18, 2014 at 11:51:42AM +0800, Li Guang wrote: > Beniamino Galvani wrote: > >Converts the interrupt generation logic to the use of level triggered > >interrupts. > > any real difference, or block something? This is a consequence of the change to the implementation of pending register o

Re: [Qemu-devel] [PATCH 00/28] target-ppc: Altivec 2.07

On 2/18/2014 12:52 PM, Richard W.M. Jones wrote: > Hi Tom, > > I would love to test your latest non-upstream qemu patches, because > the better emulation of VSX may enable me to get libguestfs working on > ppc64p7. > > Do you have a public git tree anywhere which contains something > testable? T

Re: [Qemu-devel] [PATCH 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

On Tue, Feb 18, 2014 at 12:17:04PM +0800, Li Guang wrote: > Beniamino Galvani wrote: > >The model was generating interrupts for all enabled timers after the > >expiration of one of them. Avoid this by passing to the timer callback > >function a structure containing the index of the expired timer. >

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

On Tue, Feb 18, 2014 at 11:49:51AM +0800, Li Guang wrote: > Beniamino Galvani wrote: > >According to this mail thread [1], writing to pending register seems > >to have no effect on actual pending status of interrupts. This means > >that the only way to clear a pending interrupt is to clear the > >i

Re: [Qemu-devel] [PATCH 1/7] allwinner-a10-pic: set vector address when an interrupt is pending

On Tue, Feb 18, 2014 at 11:27:11AM +0800, Li Guang wrote: > Hi, > > Beniamino Galvani wrote: > >This patch implements proper updating of the vector register which > >should hold, according to the A10 user manual, the vector address for > >the interrupt currently active on the CPU IRQ input. > > >

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

Am 18.02.2014 15:48, schrieb Alexander Graf: > On 02/18/2014 01:38 PM, Greg Kurz wrote: >> From: Rusty Russell >> >> virtio data structures are defined as "target endian", which assumes >> that's a fixed value. In fact, that actually means it's >> platform-specific. >> >> The OASIS virtio 1.0 spe

[Qemu-devel] [PATCH] object: Report type in error when not user creatable.

Signed-off-by: Hani Benhabiles --- qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index d0d98e7..f556a04 100644 --- a/qmp.c +++ b/qmp.c @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict, } if (!object

Re: [Qemu-devel] KVM call minutes for 2014-02-18

On 02/18/14 16:05, Juan Quintela wrote: > * Maintenance? > - How is being handling patches for the stable release? > CC: stable@ for stable maintance. According to , 2014-02-24 is the planned date for the 1.7.1 freeze (ie. in six days). I checked

Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources

On 02/18/14 17:36, Igor Mammedov wrote: > On Mon, 17 Feb 2014 09:32:35 +0100 > Gerd Hoffmann wrote: > >> On So, 2014-02-16 at 17:53 +0200, Michael S. Tsirkin wrote: >>> On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote: Since introduction of PCIHP, it became problematic to p

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

On 02/18/14 22:08, Laszlo Ersek wrote: > On 02/18/14 20:17, Gabriel L. Somlo wrote: >> On Tue, Feb 18, 2014 at 11:21:33AM +0100, Gerd Hoffmann wrote: > >> Using Fedora 20 live, I collected the SMBIOS table from the guest >> using "dmidecode --dump-bin", with the unpatched SeaBIOS >> (dmidecode_pc.

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

On 02/18/14 20:17, Gabriel L. Somlo wrote: > On Tue, Feb 18, 2014 at 11:21:33AM +0100, Gerd Hoffmann wrote: > Using Fedora 20 live, I collected the SMBIOS table from the guest > using "dmidecode --dump-bin", with the unpatched SeaBIOS > (dmidecode_pc.bin), SeaBIOS with my patch applied (dmidecode_

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

On Tue, 2014-02-18 at 13:00 -0800, Nicholas A. Bellinger wrote: > On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote: > > > > > > > > Hi Yan, > > > > > > > > > > So recently I've been doing some KVM guest performance comparisons > > > > > between the scsi-mq prototype using virtio-s

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote: > > > > Hi Yan, > > > > > > > > So recently I've been doing some KVM guest performance comparisons > > > > between the scsi-mq prototype using virtio-scsi + vhost-scsi, and > > > > Windows Server 2012 with vioscsi.sys (virtio-win-0

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Push zero'd pages into the XBZRLE cache > > A page that was cached by XBZRLE, zero'd and then XBZRLE'd again > > was being compared against a stale cache value >

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

On Tue, Feb 18, 2014 at 02:17:29PM -0500, Gabriel L. Somlo wrote: > Sending a patch against QEMU would have definitely been my first > choice, by a wide margin :) But after studying the hw/i386/smbios.c > source file in QEMU for a while, I walked away with the impression > that all it really tries

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

Am 18.02.2014 13:38, schrieb Greg Kurz: > diff --git a/include/hw/virtio/virtio-access.h > b/include/hw/virtio/virtio-access.h > new file mode 100644 > index 000..2e22a47 > --- /dev/null > +++ b/include/hw/virtio/virtio-access.h > @@ -0,0 +1,132 @@ > +/* > + * Virtio Accessor Support: In case

Re: [Qemu-devel] [PATCH V18 11/12] quorum: Add quorum_open() and quorum_close().

On Tue, Feb 18, 2014 at 06:48:27PM +0100, Benoît Canet wrote: > The Tuesday 18 Feb 2014 à 17:37:08 (+), Leandro Dorileo wrote : > > On Tue, Feb 18, 2014 at 01:11:26PM +0100, Beno??t Canet wrote: > > > From: Beno??t Canet > > > > > > Example of command line: > > > > > > -drive if=virtio,drive

Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: Fix NVIC assertion failure

On 18 February 2014 09:55, Peter Maydell wrote: > Commit 40d225009ef accidentally changed the behaviour of > gic_acknowledge_irq() for the NVIC. The NVIC doesn't have SGIs, > so this meant we hit an assertion: > gic_acknowledge_irq: Assertion `s->sgi_pending[irq][cpu] != 0' failed. > > Return NV

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

On Tue, Feb 18, 2014 at 11:21:33AM +0100, Gerd Hoffmann wrote: > > Unfortunately, if we change the smbios in SeaBIOS, it will show up on > > all machine types that use the new version of SeaBIOS. We've had > > issues with this type of change before as various OSes react > > differently to the chan

Re: [Qemu-devel] [PATCH 0/8] virtio endian-ambivalent target fixes (rebased)

Am 18.02.2014 13:38, schrieb Greg Kurz: > On Fri, 14 Feb 2014 12:59:49 +0100 > Andreas Färber wrote: > >> Hi, >> >> [...] >> >> It might've helped if Rusty had actually used our >> scripts/get_maintainer.pl script to CC people. While Anthony seems to >> have reviewed some patches (usually Reviewe

Re: [Qemu-devel] [PATCH 00/28] target-ppc: Altivec 2.07

Hi Tom, I would love to test your latest non-upstream qemu patches, because the better emulation of VSX may enable me to get libguestfs working on ppc64p7. Do you have a public git tree anywhere which contains something testable? The published patches no longer cleanly apply to qemu.git. Rich.

Re: [Qemu-devel] [PATCH] qdev: set DeviceClass.hotpluggable default in class_init()

Am 18.02.2014 17:56, schrieb Igor Mammedov: > Move setting DeviceClass.hotpluggable default from > class_base_init() to device's own class_init(). > > Reported-by: Andreas Färber > Signed-off-by: Igor Mammedov Thanks, applied to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next A

Re: [Qemu-devel] [PATCH V18 11/12] quorum: Add quorum_open() and quorum_close().

On 18.02.2014 13:11, Benoît Canet wrote: From: Benoît Canet Example of command line: -drive if=virtio,driver=quorum,\ children.0.file.filename=1.raw,\ children.0.node-name=1.raw,\ children.0.driver=raw,\ children.1.file.filename=2.raw,\ children.1.node-name=2.raw,\ children.1.driver=raw,\ chil

Re: [Qemu-devel] [PATCH V18 09/12] quorum: Add quorum_co_flush().

On 18.02.2014 13:11, Benoît Canet wrote: From: Benoît Canet Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 28 1 file changed, 28 insertions(+) The same thing as for patch 3 (unchanged from v17): Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

On 18/02/14 4:45 AM, Peter Maydell wrote: On 18 February 2014 00:36, Brad Smith wrote: Just one issue... just curious why my last name is missing from the commit? Ah, we've run into a bug in patchwork. I downloaded your patch: http://patchwork.ozlabs.org/patch/299656/ but patchwork reconst

Re: [Qemu-devel] [PATCH V18 06/12] quorum: Add quorum mechanism.

On 18.02.2014 13:11, Benoît Canet wrote: From: Benoît Canet This patchset enables the core of the quorum mechanism. The num_children reads are compared to get the majority version and if this version exists more than threshold times the guest won't see the error at all. If a block is corrupted

[Qemu-devel] [PATCH v4 7/8] block: Reuse success path from bdrv_open()

The fail and success paths of bdrv_file_open() may be further shortened by reusing code already existent in bdrv_open(). This includes bdrv_file_open() not taking the reference to options which allows the removal of QDECREF(options) in that function. Signed-off-by: Max Reitz Reviewed-by: Kevin Wo

Re: [Qemu-devel] [PATCH] kvm: fix kvm_set_migration_log() behavior

Le 18/02/2014 17:16, Paolo Bonzini a écrit : > This patch is not correct, because it introduces another one: if dirty > logging was enabled on the memory region (kvm_dirty_pages_log_change), > it will be disabled after migration. Yes you're right that was my initial goal, I didn't distinguish the

[Qemu-devel] [PATCH] hw/intc/arm_gic: Fix NVIC assertion failure

Commit 40d225009ef accidentally changed the behaviour of gic_acknowledge_irq() for the NVIC. The NVIC doesn't have SGIs, so this meant we hit an assertion: gic_acknowledge_irq: Assertion `s->sgi_pending[irq][cpu] != 0' failed. Return NVIC acknowledge-irq to its previous behaviour, like 11MPCore.

Re: [Qemu-devel] [PATCH V18 03/12] quorum: Add quorum_aio_writev and its dependencies.

On 18.02.2014 13:11, Benoît Canet wrote: From: Benoît Canet Writes are mirrored num_children times on num_children devices. Signed-off-by: Benoit Canet --- block/quorum.c | 103 + 1 file changed, 103 insertions(+) Since you apparent

Re: [Qemu-devel] [PATCH] qom: add object_property_is_set

Am 18.02.2014 18:26, schrieb Paolo Bonzini: > Il 18/02/2014 18:11, Marcel Apfelbaum ha scritto: >> It is used to replace qemu_opt_get_bool that provides a >> parameter for a default value. In this case we need to >> differentiate "no value" from "false." > > But what would the getter return in tha

Re: [Qemu-devel] [PATCH V18 11/12] quorum: Add quorum_open() and quorum_close().

On 18.02.2014 18:37, Leandro Dorileo wrote: On Tue, Feb 18, 2014 at 01:11:26PM +0100, Beno??t Canet wrote: From: Beno??t Canet Example of command line: -drive if=virtio,driver=quorum,\ children.0.file.filename=1.raw,\ children.0.node-name=1.raw,\ children.0.driver=raw,\ children.1.file.filena

Re: [Qemu-devel] [PATCH V18 11/12] quorum: Add quorum_open() and quorum_close().

The Tuesday 18 Feb 2014 à 17:37:08 (+), Leandro Dorileo wrote : > On Tue, Feb 18, 2014 at 01:11:26PM +0100, Beno??t Canet wrote: > > From: Beno??t Canet > > > > Example of command line: > > > > -drive if=virtio,driver=quorum,\ > > children.0.file.filename=1.raw,\ > > children.0.node-name=1.r

[Qemu-devel] [PATCH v4 1/8] block: Change BDS parameter of bdrv_open() to **

Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not NULL, that existing BDS will be reused (in the same way as bdrv_open() already did). Signed-off-

[Qemu-devel] [PATCH v4 4/8] block: Reuse reference handling from bdrv_open()

Remove the reference parameter and the related handling code from bdrv_file_open(), since it exists in bdrv_open() now as well. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Kevin Wolf --- block.c | 32 +++- 1 file changed, 7 insertions(+), 25 dele

[Qemu-devel] [PATCH v4 5/8] block: Remove bdrv_new() from bdrv_file_open()

Change bdrv_file_open() to take a simple pointer to an already existing BDS instead of an indirect one. The BDS will be created in bdrv_open() if necessary. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Kevin Wolf --- block.c | 24 +--- 1 file changed, 13

Re: [Qemu-devel] [PATCH V18 11/12] quorum: Add quorum_open() and quorum_close().

On Tue, Feb 18, 2014 at 01:11:26PM +0100, Beno??t Canet wrote: > From: Beno??t Canet > > Example of command line: > > -drive if=virtio,driver=quorum,\ > children.0.file.filename=1.raw,\ > children.0.node-name=1.raw,\ > children.0.driver=raw,\ > children.1.file.filename=2.raw,\ > children.1.node-

[Qemu-devel] [PATCH v4 6/8] block: Handle bs->options in bdrv_open() only

The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit similarities, thus it is possible to reuse the one from bdrv_open() and shorten the one in bdrv_file_open() accordingly. Also, setting bs->options in bdrv_file_open() is not necessary if it is already done in bdrv_open(). Signed

[Qemu-devel] [PATCH v4 8/8] block: Remove bdrv_open_image()'s force_raw option

This option is now unnecessary since specifying BDRV_O_PROTOCOL as flag will do exactly the same. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Kevin Wolf --- block.c | 27 --- block/blkdebug.c | 2 +- block/blkverify.c | 4 ++-

[Qemu-devel] [PATCH v4 3/8] block: Make bdrv_file_open() static

Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the call to bdrv_file_open(). Additionally, make bdrv_file_open() static and therefore bdrv_open() the only way to call it. Consequently, all existing calls to bdrv_file_open() have to be adjusted to use bdrv_open() with the BDRV_

[Qemu-devel] [PATCH v4 2/8] block: Add reference parameter to bdrv_open()

Allow bdrv_open() to handle references to existing block devices just as bdrv_file_open() is already capable of. Signed-off-by: Max Reitz --- block.c | 44 +--- block/qcow2.c | 4 ++-- block/vmdk.c | 3 ++- block/vvfat.c

[Qemu-devel] [PATCH v4 0/8] block: Integrate bdrv_file_open() into bdrv_open()

bdrv_file_open() is now nearly a subset of bdrv_open(), except for the fact that bdrv_file_open() is for protocols and bdrv_open() for block drivers. It is possible to use bdrv_file_open() with a block driver, but in that case that block driver must be explicitly specified. Due to these great simi

Re: [Qemu-devel] [PATCH] qom: add object_property_is_set

Il 18/02/2014 18:11, Marcel Apfelbaum ha scritto: It is used to replace qemu_opt_get_bool that provides a parameter for a default value. In this case we need to differentiate "no value" from "false." But what would the getter return in that case? If possible, it's better to initialize to the

Re: [Qemu-devel] [PATCH 1/1] linux-user: AArch64: Fix exclusive store of the zero register

j...@jannau.net writes: > Signed-off-by: Janne Grunau > --- > linux-user/main.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index cabc9e1..9192977 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -953,7 +9

Re: [Qemu-devel] [PATCH] qom: add object_property_is_set

On Tue, 2014-02-18 at 17:51 +0100, Paolo Bonzini wrote: > Il 18/02/2014 17:46, Marcel Apfelbaum ha scritto: > > Sometimes is not enough to get property's value, > > but it is needed to know if the value was actually set. > > > > This is especially useful when querying bool properties > > and having

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

On Tue, 18 Feb 2014, Paolo Bonzini wrote: > Il 18/02/2014 15:25, Stefano Stabellini ha scritto: > > On Tue, 18 Feb 2014, Paolo Bonzini wrote: > > > Il 18/02/2014 13:45, Stefano Stabellini ha scritto: > > > > Disk unplug: hw/ide/piix.c:pci_piix3_xen_ide_unplug (see the beginning > > > > of the email

[Qemu-devel] [PATCH] qdev: set DeviceClass.hotpluggable default in class_init()

Move setting DeviceClass.hotpluggable default from class_base_init() to device's own class_init(). Reported-by: Andreas Färber Signed-off-by: Igor Mammedov --- hw/core/qdev.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c

Re: [Qemu-devel] [PATCH v2] qemu_file: use fwrite() correctly

Juan Quintela writes: > fwrite() returns the number of items written. But when there is one > error, it can return a short write. > > In the particular bug that I was tracking, I did a migration to a > read-only filesystem. And it was able to finish the migration > correctly. fwrite() never re

Re: [Qemu-devel] [PULL 13/20] qdev: add "hotpluggable" property to Device

On Tue, 18 Feb 2014 17:35:16 +0100 Andreas Färber wrote: > Am 10.02.2014 17:48, schrieb Michael S. Tsirkin: > > From: Igor Mammedov > > > > Currently it's possible to make PCIDevice not hotpluggable > > by using no_hotplug field of PCIDeviceClass. However it > > limits this only to PCI devices

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Push zero'd pages into the XBZRLE cache > A page that was cached by XBZRLE, zero'd and then XBZRLE'd again > was being compared against a stale cache value > > Don't use 'qemu_put_buffer_async' to put pages from th

Re: [Qemu-devel] [PATCH] qom: add object_property_is_set

Il 18/02/2014 17:46, Marcel Apfelbaum ha scritto: Sometimes is not enough to get property's value, but it is needed to know if the value was actually set. This is especially useful when querying bool properties and having different defaults on different scenarios. I think this needs to go toge

Re: [Qemu-devel] [PATCH 1/1] linux-user: AArch64: Fix exclusive store of the zero register

On 18 February 2014 16:46, Janne Grunau wrote: > Signed-off-by: Janne Grunau > --- > linux-user/main.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources

On Mon, 17 Feb 2014 09:29:20 +0100 Gerd Hoffmann wrote: > On Fr, 2014-02-07 at 13:51 +0100, Igor Mammedov wrote: > > Since introduction of PCIHP, it became problematic to > > punch hole in PCI0._CRS statically since PCI hotplug > > region size became runtime changeable. > > > > So replace static

[Qemu-devel] [PATCH 1/1] linux-user: AArch64: Fix exclusive store of the zero register

Signed-off-by: Janne Grunau --- linux-user/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index cabc9e1..9192977 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -953,7 +953,8 @@ static int do_strex_a64(CPUARMState *

[Qemu-devel] [PATCH] qom: add object_property_is_set

Sometimes is not enough to get property's value, but it is needed to know if the value was actually set. This is especially useful when querying bool properties and having different defaults on different scenarios. Signed-off-by: Marcel Apfelbaum --- include/qom/object.h | 11 +++ qom/o

Re: [Qemu-devel] [PATCH v2 0/3] qtest: avoid pidfile and QEMU process leaks

Stefan Hajnoczi writes: > v2: > * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo] > * Use sigemptyset() to avoid assumption about signal mask [Markus] > * if (fd != -1) close(fd) is no longer necessary [Markus] > > This series prevents the following qtest issues: > > 1.

Re: [Qemu-devel] [PATCH] hw/arm/vexpress: Set reset-cbar property for CPUs

On 13 February 2014 14:26, Peter Maydell wrote: > +static void init_cpus(const char *cpu_model, const char *privdev, > + hwaddr periphbase, qemu_irq *pic) > +{ > +ObjectClass *cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, cpu_model); > +DeviceState *dev; > +SysBusDevice

Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources

On Mon, 17 Feb 2014 09:32:35 +0100 Gerd Hoffmann wrote: > On So, 2014-02-16 at 17:53 +0200, Michael S. Tsirkin wrote: > > On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote: > > > Since introduction of PCIHP, it became problematic to > > > punch hole in PCI0._CRS statically since PCI h

Re: [Qemu-devel] [PULL 13/20] qdev: add "hotpluggable" property to Device

Am 10.02.2014 17:48, schrieb Michael S. Tsirkin: > From: Igor Mammedov > > Currently it's possible to make PCIDevice not hotpluggable > by using no_hotplug field of PCIDeviceClass. However it > limits this only to PCI devices and prevents from > generalizing hotplug code. > > So add similar fiel

Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources

On Tue, 18 Feb 2014 13:33:17 +0200 "Michael S. Tsirkin" wrote: > On Tue, Feb 18, 2014 at 12:10:27PM +0100, Igor Mammedov wrote: > > On Mon, 17 Feb 2014 13:02:18 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Feb 17, 2014 at 11:33:23AM +0100, Igor Mammedov wrote: > > > > On Sun, 16 Feb

Re: [Qemu-devel] [PATCH v4] qdev: Keep global allocation counter per bus

Am 06.02.2014 16:08, schrieb Markus Armbruster: > From: Alexander Graf > > When we have 2 separate qdev devices that both create a qbus of the > same type without specifying a bus name or device name, we end up > with two buses of the same name, such as ide.0 on the Mac machines: > > dev: maci

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

On 02/18/2014 05:17 PM, Cornelia Huck wrote: On Tue, 18 Feb 2014 17:02:18 +0100 Alexander Graf wrote: Am 18.02.2014 um 16:45 schrieb Cornelia Huck : On Tue, 18 Feb 2014 16:12:08 +0100 Cornelia Huck wrote: On Tue, 18 Feb 2014 17:03:27 +0200 "Michael S. Tsirkin" wrote: On Tue, Feb 18, 2

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

On Tue, 18 Feb 2014 17:02:18 +0100 Alexander Graf wrote: > > > > Am 18.02.2014 um 16:45 schrieb Cornelia Huck : > > > > On Tue, 18 Feb 2014 16:12:08 +0100 > > Cornelia Huck wrote: > > > >> On Tue, 18 Feb 2014 17:03:27 +0200 > >> "Michael S. Tsirkin" wrote: > >> > On Tue, Feb 18, 2014

Re: [Qemu-devel] [PATCH] kvm: fix kvm_set_migration_log() behavior

Il 18/02/2014 13:33, Vincent KHERBACHE ha scritto: diff --git a/kvm-all.c b/kvm-all.c index 2ca9143..f104f87 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -355,7 +355,7 @@ static int kvm_set_migration_log(int enable) { KVMState *s = kvm_state; KVMSlot *mem; -int i, err; +int i, err

Re: [Qemu-devel] [PATCH v3] qemu_file: use fwrite() correctly

On 02/18/2014 08:56 AM, Juan Quintela wrote: > fwrite() returns the number of items written. But when there is one > error, it can return a short write. > > In the particular bug that I was tracking, I did a migration to a > read-only filesystem. And it was able to finish the migration > correct

  1   2   3   >