[Qemu-devel] [PATCH v18 10/14] numa: add -numa node, memdev= option

2014-02-19 Thread Hu Tao
From: Paolo Bonzini pbonz...@redhat.com This option provides the infrastructure for binding guest NUMA nodes to host NUMA nodes. For example: -object memory-ram,size=1024M,policy=membind,host-nodes=0,id=ram-node0 \ -numa node,nodeid=0,cpus=0,memdev=ram-node0 \ -object

[Qemu-devel] [PATCH v18 04/14] NUMA: convert -numa option to use OptsVisitor

2014-02-19 Thread Hu Tao
From: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- include/sysemu/sysemu.h | 3 +- numa.c | 148

[Qemu-devel] [PATCH v18 09/14] numa: introduce memory_region_allocate_system_memory

2014-02-19 Thread Hu Tao
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/i386/pc.c| 4 +--- include/sysemu/sysemu.h | 5 + numa.c | 10 ++ 3 files changed, 16 insertions(+), 3

[Qemu-devel] [PATCH v18 02/14] NUMA: check if the total numa memory size is equal to ram_size

2014-02-19 Thread Hu Tao
From: Wanlong Gao gaowanl...@cn.fujitsu.com If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI talb, then the guest will ignore the wrong ACPI table and recognize all memory to one node. It's buggy, we should check it

[Qemu-devel] [PATCH v18 08/14] pc: pass QEMUMachineInitArgs to pc_memory_init

2014-02-19 Thread Hu Tao
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/i386/pc.c | 11 +-- hw/i386/pc_piix.c| 8 +++- hw/i386/pc_q35.c | 4 +--- include/hw/i386/pc.h | 7 +++ 4 files changed,

[Qemu-devel] [PATCH v18 07/14] add memdev backend infrastructure

2014-02-19 Thread Hu Tao
Provides framework for splitting host RAM allocation/ policies into a separate backend that could be used by devices. Initially only legacy RAM backend is provided, which uses memory_region_init_ram() allocator and compatible with every CLI option that affects memory_region_init_ram().

[Qemu-devel] [PATCH v18 05/14] NUMA: expand MAX_NODES from 64 to 128

2014-02-19 Thread Hu Tao
From: Wanlong Gao gaowanl...@cn.fujitsu.com libnuma choosed 128 for MAX_NODES, so we follow libnuma here. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- include/sysemu/sysemu.h | 2 +- 1 file

[Qemu-devel] [PATCH v18 12/14] qapi: add HostMemPolicy enum type

2014-02-19 Thread Hu Tao
From: Wanlong Gao gaowanl...@cn.fujitsu.com This new enum type will be used to set host memory policy of backend host memory. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qapi-schema.json | 20 1 file changed, 20

[Qemu-devel] [PATCH v18 14/14] amp: add query-memdev

2014-02-19 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- backends/hostmem-ram.c | 71 -- qapi-schema.json | 31 ++ qmp-commands.hx| 30 + 3 files changed, 124 insertions(+), 8 deletions(-) diff --git

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-02-19 Thread Vadim Rozenfeld
On Tue, 2014-02-18 at 13:00 -0800, Nicholas A. Bellinger wrote: On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote: SNIP Hi Yan, So recently I've been doing some KVM guest performance comparisons between the scsi-mq prototype using virtio-scsi + vhost-scsi,

Re: [Qemu-devel] [PATCH v18 14/14] amp: add query-memdev

2014-02-19 Thread Hu Tao
... +static void func(gpointer data, gpointer user_data) maybe a better name. +{ +HostMemoryBackendRam *backend = data; +MemdevList **list = user_data; +MemdevList *m; +uint16List **node; +unsigned long value; + +m = g_malloc0(sizeof(*m)); +m-value =

Re: [Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list

2014-02-19 Thread Hu Tao
On Wed, Feb 19, 2014 at 03:54:02PM +0800, Hu Tao wrote: Cc: Laszlo Ersek ler...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qapi/string-input-visitor.c | 160 -- tests/test-string-input-visitor.c | 22 ++ 2 files changed, 176

Re: [Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list

2014-02-19 Thread Paolo Bonzini
Il 19/02/2014 09:17, Hu Tao ha scritto: Two problems: 1. the code is mostly copied from OptsVisitor. maybe we can share the code? I think it's not a huge problem. Maybe OptsVisitor could be made to use a StringInputVisitor internally. 2. int list is not implemented in string outout

Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources

2014-02-19 Thread Igor Mammedov
On Tue, 18 Feb 2014 23:04:13 +0100 Laszlo Ersek ler...@redhat.com wrote: On 02/18/14 17:36, Igor Mammedov wrote: On Mon, 17 Feb 2014 09:32:35 +0100 Gerd Hoffmann kra...@redhat.com wrote: On So, 2014-02-16 at 17:53 +0200, Michael S. Tsirkin wrote: On Fri, Feb 07, 2014 at 01:51:27PM

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-19 Thread Paolo Bonzini
19/02/2014 08:54, Hu Tao ha scritto: Thus makes user control how to allocate memory for ram backend. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- backends/hostmem-ram.c | 158 include/sysemu/sysemu.h | 2 + 2 files changed, 160

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-19 Thread Michael S. Tsirkin
On Tue, Feb 18, 2014 at 05:10:00PM +, Stefano Stabellini wrote: On Tue, 18 Feb 2014, Paolo Bonzini wrote: Il 18/02/2014 15:25, Stefano Stabellini ha scritto: On Tue, 18 Feb 2014, Paolo Bonzini wrote: Il 18/02/2014 13:45, Stefano Stabellini ha scritto: Disk unplug:

[Qemu-devel] [PATCHv3 2/2] sun4m: Add Sun CG3 framebuffer initialisation function

2014-02-19 Thread Mark Cave-Ayland
In order to allow the user to choose the framebuffer for sparc-softmmu, add -vga tcx and -vga cg3 options to the QEMU command line. If no option is specified, the default TCX framebuffer is used. Since proprietary FCode ROMs use a resolution of 1152x900, slightly relax the validation rules to

[Qemu-devel] [PATCHv3 0/2] sun4m: Implement Sun CG3 framebuffer for QEMU

2014-02-19 Thread Mark Cave-Ayland
This patchset provides QEMU with an implementation of the Sun CG3 8-bit framebuffer. It is based upon Bob Breuer's original work which has been rebased onto git master, and is now capable of running with an OpenBIOS CG3 FCode ROM instead of requiring copies of proprietary Sun ROMs. The

[Qemu-devel] [PATCHv3 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-19 Thread Mark Cave-Ayland
The CG3 framebuffer is a simple 8-bit framebuffer for use with operating systems such as early Solaris that do not have drivers for TCX. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk CC: Blue Swirl blauwir...@gmail.com CC: Anthony Liguori aligu...@amazon.com CC: Peter Maydell

Re: [Qemu-devel] [PATCH v18 12/14] qapi: add HostMemPolicy enum type

2014-02-19 Thread Paolo Bonzini
Il 19/02/2014 08:54, Hu Tao ha scritto: From: Wanlong Gao gaowanl...@cn.fujitsu.com This new enum type will be used to set host memory policy of backend host memory. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qapi-schema.json | 20

Re: [Qemu-devel] [PATCH v18 14/14] amp: add query-memdev

2014-02-19 Thread Paolo Bonzini
Il 19/02/2014 08:54, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- backends/hostmem-ram.c | 71 -- qapi-schema.json | 31 ++ qmp-commands.hx| 30 + 3 files changed, 124

Re: [Qemu-devel] [PATCH] object: Report type in error when not user creatable.

2014-02-19 Thread Paolo Bonzini
Il 18/02/2014 23:42, Hani Benhabiles ha scritto: Signed-off-by: Hani Benhabiles h...@linux.com --- qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index d0d98e7..f556a04 100644 --- a/qmp.c +++ b/qmp.c @@ -556,8 +556,8 @@ void object_add(const char

Re: [Qemu-devel] [PATCH v18 07/14] add memdev backend infrastructure

2014-02-19 Thread Igor Mammedov
On Wed, 19 Feb 2014 15:53:58 +0800 Hu Tao hu...@cn.fujitsu.com wrote: Provides framework for splitting host RAM allocation/ policies into a separate backend that could be used by devices. Initially only legacy RAM backend is provided, which uses memory_region_init_ram() allocator and

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-19 Thread Michael S. Tsirkin
On Wed, Feb 19, 2014 at 11:08:25AM +0200, Michael S. Tsirkin wrote: On Tue, Feb 18, 2014 at 05:10:00PM +, Stefano Stabellini wrote: On Tue, 18 Feb 2014, Paolo Bonzini wrote: Il 18/02/2014 15:25, Stefano Stabellini ha scritto: On Tue, 18 Feb 2014, Paolo Bonzini wrote: Il

Re: [Qemu-devel] [PATCH v18 03/14] NUMA: Add numa_info structure to contain numa nodes info

2014-02-19 Thread Igor Mammedov
On Wed, 19 Feb 2014 15:53:54 +0800 Hu Tao hu...@cn.fujitsu.com wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. this is old version that breaks spar build

Re: [Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-19 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 02:43:53PM +0100, Paolo Bonzini wrote: Before: $ ./qemu-io-old qemu-io-old open -r -o file.driver=iscsi,file.filename=foo Failed to parse URL : foo qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument After: $

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-19 Thread Igor Mammedov
On Wed, 19 Feb 2014 10:03:13 +0100 Paolo Bonzini pbonz...@redhat.com wrote: 19/02/2014 08:54, Hu Tao ha scritto: Thus makes user control how to allocate memory for ram backend. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- backends/hostmem-ram.c | 158

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-19 Thread Gerd Hoffmann
Hi, In my opinion, generating the entire smbios table in QEMU and using the romfile_loader mechanism (see seabios src/fw/romfile_loader.c) would be the preferred solution. I understand that this is more than you signed up for. Yes, this is where we should end up long-term. For the time

Re: [Qemu-devel] [PATCH v4 0/8] block: Integrate bdrv_file_open() into bdrv_open()

2014-02-19 Thread Kevin Wolf
Am 18.02.2014 um 18:33 hat Max Reitz geschrieben: bdrv_file_open() is now nearly a subset of bdrv_open(), except for the fact that bdrv_file_open() is for protocols and bdrv_open() for block drivers. It is possible to use bdrv_file_open() with a block driver, but in that case that block driver

Re: [Qemu-devel] [PATCH v18 06/14] qapi: add SIZE type parser to string_input_visitor

2014-02-19 Thread Igor Mammedov
On Wed, 19 Feb 2014 15:53:57 +0800 Hu Tao hu...@cn.fujitsu.com wrote: From: Igor Mammedov imamm...@redhat.com Signed-off-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com replace it with a better patch from

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-19 Thread Gerd Hoffmann
Hi, However, when I compare unmodified SMBIOS against what I get when supplying the patched binary table via command line, I get this: As Laszlo already sayed: one table per file. If seabios finds a table provided by qemu it used it, otherwise it (possibly) generates its own. So we

Re: [Qemu-devel] Buildbot failure: MinGW

2014-02-19 Thread Gerd Hoffmann
On Mi, 2014-02-19 at 05:27 +0100, Stefan Weil wrote: Hi Gerd, hi Stefan, we now need a C++ compiler on the buildbots. Currently, it's missing for MinGW: /bin/sh: i686-pc-mingw32-g++: command not found Installed. cheers, Gerd

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2014-02-19 Thread Greg Kurz
On Tue, 18 Feb 2014 20:25:15 +0100 Andreas Färber afaer...@suse.de wrote: Am 18.02.2014 13:38, schrieb Greg Kurz: diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h new file mode 100644 index 000..2e22a47 --- /dev/null +++

[Qemu-devel] Question

2014-02-19 Thread atlas khan
I am working on project in which we have add support of a board in QEMU. We have to add some virtual devices in QEMU. The question which I want to ask that what should I do to add virtual device. And after adding that device in \hw in which file I have to make changes so that program access that

Re: [Qemu-devel] [PATCH] trace-events: Fix typo in offset

2014-02-19 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 10:03:17AM +0100, Kevin Wolf wrote: s/offet/offset/ Signed-off-by: Kevin Wolf kw...@redhat.com --- trace-events | 8 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing

Re: [Qemu-devel] [PATCH 0/2] bswap: Clean prototypes of st* functions

2014-02-19 Thread Laszlo Ersek
On 02/19/14 06:11, Stefan Weil wrote: These modifications avoid type conversions for non optimized code. ld* function prototypes will follow later. [PATCH 1/2] bswap: Modify prototype of stb_p (avoid type [PATCH 2/2] bswap: Modify prototypes of st[wl]_{le,be}_p (avoid type It probably

Re: [Qemu-devel] [PULL 00/15] tcg updates

2014-02-19 Thread Kevin Wolf
Am 18.02.2014 um 02:15 hat Richard Henderson geschrieben: Contains two patch sets, recently reviewed. Plus two other unrelated patches that probably weren't going to get in via any other tree. It doesn't seem to contain my target-i386 I/O bitmap fix. Should I send a separate pull request for

Re: [Qemu-devel] [PULL 00/15] tcg updates

2014-02-19 Thread Kevin Wolf
Am 19.02.2014 um 11:21 hat Kevin Wolf geschrieben: Am 18.02.2014 um 02:15 hat Richard Henderson geschrieben: Contains two patch sets, recently reviewed. Plus two other unrelated patches that probably weren't going to get in via any other tree. It doesn't seem to contain my target-i386

[Qemu-devel] [PATCH] XBZRLE: Fix qemu crash when resize the xbzrle cache during migration

2014-02-19 Thread Gonglei (Arei)
It is likely to crash qemu when resize the xbzrle cache during migration. Because the xbzrle cache will be modified by migration thread and resize thread. Test scene step one: set the size of xbzrle cache 1GB. step two: migrate vm which dirty memory continuously. step three: set the size of

[Qemu-devel] [PATCH 4/6] linux-user: Fix error handling in lock_iovec()

2014-02-19 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org In lock_iovec() if lock_user() failed we were doing an unlock_user but not a free(vec), which is the wrong way round. We were also assuming that free() and unlock_user() don't touch errno, which is not guaranteed. Fix both these problems.

[Qemu-devel] [PATCH 6/6] linux-user: Fix error handling in target_to_host_semarray()

2014-02-19 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Fix two issues in error handling in target_to_host_semarray(): * don't leak the host_array buffer if lock_user fails * return an error if malloc() fails v2: added missing * -Riku Voipio Signed-off-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH 3/6] linux-user/signal.c: Don't pass sigaction uninitialised sa_flags

2014-02-19 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org When forcing a fatal signal, we weren't initialising the sa_flags field in the struct sigaction we used to reset the signal handler to SIG_DFL. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@linaro.org ---

[Qemu-devel] [PATCH 5/6] linux-user: Implement BLKPG ioctl

2014-02-19 Thread riku . voipio
From: Andreas Färber afaer...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/ioctls.h| 1 + linux-user/syscall.c | 1 + linux-user/syscall_defs.h | 1 +

[Qemu-devel] [PATCH 1/6] linux-user: sync syscall numbers upto 3.13

2014-02-19 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org All others updated except unicore, which doesn't look right to begin with. Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/alpha/syscall_nr.h | 7 +++ linux-user/arm/syscall_nr.h| 6 ++ linux-user/cris/syscall_nr.h

[Qemu-devel] [PATCH 2/6] linux-user/elfload.c: Avoid calling g_free() on uninitialized data

2014-02-19 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Avoid calling g_free() on unintialized data in the error-handling paths in elf_core_dump() by splitting the initialization of the elf_note_info struct out of fill_note_info() so that it's always valid to call free_note_info() whether we got to the

[Qemu-devel] [PULL 0/6] linux-user updates

2014-02-19 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8dbb: Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +) are available in the git repository at: git://git.linaro.org/people/riku.voipio/qemu.git

[Qemu-devel] [PATCH] qxl: add sanity check

2014-02-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 1471cc0..2a559eb 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1429,7 +1429,7 @@ static int

Re: [Qemu-devel] [PATCH v18 10/14] numa: add -numa node, memdev= option

2014-02-19 Thread Igor Mammedov
On Wed, 19 Feb 2014 15:54:01 +0800 Hu Tao hu...@cn.fujitsu.com wrote: From: Paolo Bonzini pbonz...@redhat.com This option provides the infrastructure for binding guest NUMA nodes to host NUMA nodes. For example: -object memory-ram,size=1024M,policy=membind,host-nodes=0,id=ram-node0 \

Re: [Qemu-devel] [PATCH] XBZRLE: Fix qemu crash when resize the xbzrle cache during migration

2014-02-19 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: Hi Arei, It is likely to crash qemu when resize the xbzrle cache during migration. Because the xbzrle cache will be modified by migration thread and resize thread. Thanks - we was just thinking about this last night after we hit it. I was

Re: [Qemu-devel] [PATCH v18 12/14] qapi: add HostMemPolicy enum type

2014-02-19 Thread Igor Mammedov
On Wed, 19 Feb 2014 15:54:03 +0800 Hu Tao hu...@cn.fujitsu.com wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com This new enum type will be used to set host memory policy of backend host memory. perhaps squashing it into the next path would be better. Signed-off-by: Wanlong Gao

Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing

2014-02-19 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 02/18/2014 08:45 PM, Dr. David Alan Gilbert wrote: +The Micro-Checkpointing Process +Basic Algorithm +Micro-Checkpoints (MC) work against the existing live migration path in QEMU, and can effectively be understood as a live migration

Re: [Qemu-devel] [PATCH] qxl: add sanity check

2014-02-19 Thread Laszlo Ersek
On 02/19/14 11:40, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 1471cc0..2a559eb 100644 --- a/hw/display/qxl.c +++

Re: [Qemu-devel] Buildbot failure: MinGW

2014-02-19 Thread Peter Maydell
On 19 February 2014 04:27, Stefan Weil s...@weilnetz.de wrote: Hi Gerd, hi Stefan, we now need a C++ compiler on the buildbots. Currently, it's missing for MinGW: /bin/sh: i686-pc-mingw32-g++: command not found Don't we successfully fall back to don't build C++ things if configure doesn't

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-19 Thread Stefano Stabellini
On Wed, 19 Feb 2014, Michael S. Tsirkin wrote: On Wed, Feb 19, 2014 at 11:08:25AM +0200, Michael S. Tsirkin wrote: On Tue, Feb 18, 2014 at 05:10:00PM +, Stefano Stabellini wrote: On Tue, 18 Feb 2014, Paolo Bonzini wrote: Il 18/02/2014 15:25, Stefano Stabellini ha scritto: On

Re: [Qemu-devel] [PATCH v18 10/14] numa: add -numa node, memdev= option

2014-02-19 Thread Paolo Bonzini
Il 19/02/2014 10:50, Igor Mammedov ha scritto: +numa_info[nodenr].node_mem = object_property_get_int(o, size, NULL); +numa_info[nodenr].node_memdev = MEMORY_BACKEND(o); if you make numa_info QOM object node_memdev link property, then above hunk could be replaced with just

Re: [Qemu-devel] Buildbot failure: MinGW

2014-02-19 Thread Thomas Huth
On Wed, 19 Feb 2014 11:53:09 + Peter Maydell peter.mayd...@linaro.org wrote: On 19 February 2014 04:27, Stefan Weil s...@weilnetz.de wrote: Hi Gerd, hi Stefan, we now need a C++ compiler on the buildbots. Currently, it's missing for MinGW: /bin/sh: i686-pc-mingw32-g++: command

Re: [Qemu-devel] [Qemu-ppc] qemu for aix

2014-02-19 Thread Andreas Färber
Hello, Am 18.02.2014 06:00, schrieb sh.hu...@venusource.com: hello guys is somebody install qemu on AIX? is qemu can install on AIX? It's supposed to install, but I don't personally have an AIX installation to test whether there are any issues. Have you tried? Regards, Andreas P.S.

Re: [Qemu-devel] [PATCHv3 0/2] sun4m: Implement Sun CG3 framebuffer for QEMU

2014-02-19 Thread Andreas Färber
Am 19.02.2014 10:05, schrieb Mark Cave-Ayland: This patchset provides QEMU with an implementation of the Sun CG3 8-bit framebuffer. It is based upon Bob Breuer's original work which has been rebased onto git master, and is now capable of running with an OpenBIOS CG3 FCode ROM instead of

Re: [Qemu-devel] Buildbot failure: MinGW

2014-02-19 Thread Peter Maydell
On 19 February 2014 12:18, Thomas Huth th...@linux.vnet.ibm.com wrote: I recently had a similar problem compiling QEMU on a freshly installed system, where I only had a normal C compiler, but no C++ installed yet. In rules.mak, you can find these lines: # If we have a CXX we might have some

Re: [Qemu-devel] [PATCHv3 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-19 Thread Leandro Dorileo
Hi Mark, On Wed, Feb 19, 2014 at 09:05:19AM +, Mark Cave-Ayland wrote: The CG3 framebuffer is a simple 8-bit framebuffer for use with operating systems such as early Solaris that do not have drivers for TCX. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk CC: Blue Swirl

Re: [Qemu-devel] [PATCH 4/4] trace: [tracetool] Minimize the amount of per-backend code

2014-02-19 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 08:36:41PM +0100, Lluís Vilanova wrote: Backends now only contain the essential backend-specific code, and most of the work is moved to frontend code. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- scripts/simpletrace.py|6 --

[Qemu-devel] [PATCH v14 00/14] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-02-19 Thread Fam Zheng
This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of drive-backup, and export it through built in NBD server. The steps are as below: 1. (SHELL)

[Qemu-devel] [PATCH v14 04/14] block: Move op_blocker check from block_job_create to its caller

2014-02-19 Thread Fam Zheng
It makes no sense to check for any blocker on bs, we are here only because of the mechanical conversion from in_use to op_blockers. Remove it now, and let the callers check specific operation types. Backup and mirror already have it, add checker to stream and commit. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v14 01/14] block: Add BlockOpType enum

2014-02-19 Thread Fam Zheng
This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng f...@redhat.com --- include/block/block.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 780f48b..8820735 100644

[Qemu-devel] [PATCH v14 10/14] qmp: Add command 'blockdev-backup'

2014-02-19 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case with introduction

[Qemu-devel] [PATCH v14 02/14] block: Introduce op_blockers to BlockDriverState

2014-02-19 Thread Fam Zheng
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS as currently blocked for a certain type of operation with reason errors stored in the list. The rule of usage is: * BDS user

[Qemu-devel] [PATCH v14 06/14] block: Add backing_blocker in BlockDriverState

2014-02-19 Thread Fam Zheng
This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState-backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at least the backing blocker of its child, so the assertion is not

[Qemu-devel] [PATCH v14 05/14] block: Add bdrv_set_backing_hd()

2014-02-19 Thread Fam Zheng
This is the common but non-trivial steps to assign or change the backing_hd of BDS. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 34 +++--- include/block/block.h | 1 + 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/block.c

[Qemu-devel] [PATCH v14 09/14] stream: Use bdrv_drop_intermediate and drop close_unused_images

2014-02-19 Thread Fam Zheng
This reuses the new bdrv_drop_intermediate. Signed-off-by: Fam Zheng f...@redhat.com --- block/stream.c | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/block/stream.c b/block/stream.c index dd0b4ac..9cdcf0e 100644 --- a/block/stream.c +++

[Qemu-devel] [PATCH v14 03/14] block: Replace in_use with operation blocker

2014-02-19 Thread Fam Zheng
This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). The specific types are used, e.g. in place of

Re: [Qemu-devel] [PATCH 0/4] Tracetool cleanup

2014-02-19 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 08:36:19PM +0100, Lluís Vilanova wrote: Minimizes the amount of backend code, making it simpler to add new/different backends. Also performs other cleanups all around. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- Lluís Vilanova (4): trace:

[Qemu-devel] [PATCH v14 07/14] block: Parse backing option to reference existing BDS

2014-02-19 Thread Fam Zheng
Now it's safe to allow reference for backing_hd in the interface. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 95d8c1f..a2bf24c 100644 --- a/block.c +++ b/block.c @@

[Qemu-devel] [PATCH v14 11/14] block: Allow backup on referenced named BlockDriverState

2014-02-19 Thread Fam Zheng
Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng f...@redhat.com

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: Michael, On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: As reported in http://article.gmane.org/gmane.comp.emulators.qemu/253987 Mac OSX actually requires describing all occupied slots in ACPI - even

Re: [Qemu-devel] [PULL 00/15] tcg updates

2014-02-19 Thread Richard Henderson
On 02/19/2014 04:21 AM, Kevin Wolf wrote: Am 18.02.2014 um 02:15 hat Richard Henderson geschrieben: Contains two patch sets, recently reviewed. Plus two other unrelated patches that probably weren't going to get in via any other tree. It doesn't seem to contain my target-i386 I/O bitmap

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Peter Maydell
On 17 February 2014 16:44, Michael S. Tsirkin m...@redhat.com wrote: Peter, if not too late, pls don't pull until we figure it out. If you want a pull request to not be applied you need to follow up to the 00/nn cover letter for the pull request to say so. Otherwise I am likely to either miss

[Qemu-devel] [PATCH v14 08/14] block: Support dropping active in bdrv_drop_intermediate

2014-02-19 Thread Fam Zheng
Dropping intermediate could be useful both for commit and stream, and BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs to work with op blockers. Signed-off-by: Fam Zheng f...@redhat.com --- block.c| 146 +

[Qemu-devel] [PATCH v14 13/14] qemu-iotests: Test blockdev-backup in 055

2014-02-19 Thread Fam Zheng
This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/055 | 275 ++--- tests/qemu-iotests/055.out |

[Qemu-devel] [PATCH v14 12/14] block: Add blockdev-backup to transaction

2014-02-19 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- blockdev.c | 48 qapi-schema.json | 1 + 2 files changed, 49 insertions(+) diff --git a/blockdev.c b/blockdev.c index 890cfea..81446f5 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1405,6 +1405,49

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Michael S. Tsirkin
On Wed, Feb 19, 2014 at 01:52:20PM +, Peter Maydell wrote: On 17 February 2014 16:44, Michael S. Tsirkin m...@redhat.com wrote: Peter, if not too late, pls don't pull until we figure it out. If you want a pull request to not be applied you need to follow up to the 00/nn cover letter for

[Qemu-devel] [PATCH v14 14/14] qemu-iotests: Image fleecing test case 081

2014-02-19 Thread Fam Zheng
This tests the workflow of creating a lightweight point-in-time snapshot with blockdev-backup command and export it with built-in NBD server. It's tested that after the snapshot it created, writing to the original device doesn't change data that can be read from target with NBD. Signed-off-by:

Re: [Qemu-devel] [PULL 0/5] acpi,pc,pci,virtio,memory bug fixes

2014-02-19 Thread Peter Maydell
On 17 February 2014 14:25, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit 417c45ab2f847c0a47b1232f611aa886df6a97d5: ACPI: Remove commented-out code from HPET._CRS (2014-02-10 11:09:33 +0200) are available in the git repository at:

Re: [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages

2014-02-19 Thread Kevin Wolf
Am 17.02.2014 um 14:43 hat Paolo Bonzini geschrieben: Most of the block drivers are not using the Error** argument to bdrv_open, and instead just printing errors to stderr. This series improves that, and as a consequence it also avoids abuse of errno numbers. The only hurdle (caught by

[Qemu-devel] [PULL 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-19 Thread Stefan Hajnoczi
The QEMU process stays running if the test case fails. This patch fixes the leak by installing a SIGABRT signal handler which invokes qtest_end(). Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Markus Armbruster arm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PULL 0/3] qtest: avoid pidfile and QEMU process leaks

2014-02-19 Thread Stefan Hajnoczi
Reviewed by Paolo and Markus. Here is the pull request. v2: * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo] * Use sigemptyset() to avoid assumption about signal mask [Markus] * if (fd != -1) close(fd) is no longer necessary [Markus] This series prevents the

[Qemu-devel] [PULL 1/3] qtest: drop unused child_pid field

2014-02-19 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Markus Armbruster arm...@redhat.com --- tests/libqtest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index c9a4f89..2876ce4 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -43,7

[Qemu-devel] [PULL 2/3] qtest: make QEMU our direct child process

2014-02-19 Thread Stefan Hajnoczi
qtest_init() cannot use exec*p() to launch QEMU since the exec*p() functions take an argument array while qtest_init() takes char *extra_args. Therefore we execute /bin/sh -c command-line and let the shell parse the argument string. This left /bin/sh as our child process and our child's child

[Qemu-devel] [PATCH 1/3] target-i386: Make kvm_default_features an array

2014-02-19 Thread Eduardo Habkost
We will later make the KVM-specific code affect other feature words, too. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 5a530b5..ee9dff1

[Qemu-devel] [PATCH 2/3] target-i386: Introduce x86_cpu_compat_disable_kvm_features()

2014-02-19 Thread Eduardo Habkost
Instead of the feature-specific disable_kvm_pv_eoi() function, create a more general function that can be used to disable other feature bits in machine-type compat code. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- hw/i386/pc_piix.c | 6 +++--- target-i386/cpu.c | 4 ++--

[Qemu-devel] [PATCH 0/3] Enable x2apic by default on KVM

2014-02-19 Thread Eduardo Habkost
This is the approach I believe was agreed upon during the last QEMU developers conf call (sorry I didn't join, the meeting timezone change confused me). Some may notice that representing this new behavior using solely default values on CPU properties may be a little difficult. Making it possible

[Qemu-devel] [PATCH 3/3] target-i386: Enable x2apic by default on KVM

2014-02-19 Thread Eduardo Habkost
When on KVM mode, enable x2apic by default on all CPU models. Normally we try to keep the CPU model definitions as close as the real CPUs as possible, but x2apic can be emulated by KVM without host CPU support for x2apic, and it improves performance by reducing APIC access overhead. x2apic

[Qemu-devel] [PATCH 2/7] qemu-img convert: Detect options specified more than once

2014-02-19 Thread Kevin Wolf
Instead of ignoring all option values but the last one, error out if an option is set multiple times. Again, the only exception is a -o help option, which may be added to any valid qemu-img convert command and ignores all other options. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c

[Qemu-devel] [PATCH 4/7] qemu-img: Detect options specified more than once

2014-02-19 Thread Kevin Wolf
Instead of ignoring all option values but the last one, error out if an option is set multiple times. These are the simpler subcommands without -o, so the patch becomes a bit easier and we can fix the remaining subcommands in a single patch. Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 0/7] qemu-img: Fix handling of multiply specified options

2014-02-19 Thread Kevin Wolf
If you specify the same option more than once (e.g. -o cluster_size=4k -o lazy_refcounts=on), qemu-img silently ignores all but the last one. This series fixes it to either consider all options or to give an error message. Boolean option can still be given more than once as they aren't

[Qemu-devel] [PATCH 7/7] qemu-img amend: Support multiple -o options

2014-02-19 Thread Kevin Wolf
Multiple -o options has the same meaning as having a single option with all settings in the order of their respective -o options. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c

[Qemu-devel] [PATCH 1/7] qemu-img create: Detect options specified more than once

2014-02-19 Thread Kevin Wolf
If you specified multiple -o options for qemu-img create, it would silently ignore all but the last one. Similarly, for other options the last occurence wins (which is at least a bit less surprising). Error out instead. The only exception is a -o help option, which may be added to any valid

[Qemu-devel] [PATCH 6/7] qemu-img convert: Support multiple -o options

2014-02-19 Thread Kevin Wolf
Multiple -o options has the same meaning as having a single option with all settings in the order of their respective -o options. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff

[Qemu-devel] [PATCH 3/7] qemu-img amend: Detect options specified more than once

2014-02-19 Thread Kevin Wolf
Instead of ignoring all option values but the last one, error out if an option is set multiple times. Again, the only exception is a -o help option, which may be added to any valid qemu-img amend command and ignores all other options. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c |

[Qemu-devel] [PATCH 5/7] qemu-img create: Support multiple -o options

2014-02-19 Thread Kevin Wolf
Multiple -o options has the same meaning as having a single option with all settings in the order of their respective -o options. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/qemu-img.c

Re: [Qemu-devel] [PATCH 0/4] Tracetool cleanup

2014-02-19 Thread Lluís Vilanova
Stefan Hajnoczi writes: On Mon, Feb 17, 2014 at 08:36:19PM +0100, Lluís Vilanova wrote: Minimizes the amount of backend code, making it simpler to add new/different backends. Also performs other cleanups all around. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- Lluís Vilanova

  1   2   >