Re: [Qemu-devel] [PATCH] qmp: object-add: Validate class before creating object

2014-04-15 Thread Markus Armbruster
Eduardo Habkost writes: > Currently it is very easy to crash QEMU by issuing an object-add command > using an abstract class or a class that doesn't support > TYPE_USER_CREATABLE as parameter. > > Example: with the following QMP command: > > (QEMU) object-add qom-type=cpu id=foo > > QEMU abor

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-15 Thread Markus Armbruster
Peter Crosthwaite writes: > On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: >> Am 15.04.2014 04:21, schrieb Peter Crosthwaite: >>> So clients can set the top level id string. >>> >>> Signed-off-by: Peter Crosthwaite >> >> Anthony had nack'ed Paolo's attempt to generalize the qdev id to Q

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Gerd Hoffmann
Hi, > Add "void smbios_get_tables()" as a separate function to generate the > entry point and aggregate smbios table, and then: > >if "machine_type < 2.1" then > > insert smbios_get_table() into fw_cfg (compat mode) > >else > > insert smbios_get_tables() blob + entry poin

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Markus Armbruster
"Kevin O'Connor" writes: > On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: >> Leave the old interface code basically as-is. type0 and type1 >> individual fields are passed like they are passed today. We don't >> change to to pass full tables, and we don't extend that to new table

Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration

2014-04-15 Thread Gerd Hoffmann
On Di, 2014-04-15 at 19:33 -0400, Ján Veselý wrote: > Hi, > > I found some more time to work on this. However, I'm not sure I > understand the purpose of compat property: > I noticed that the only place it's set is in PC_COMPAT_1_3 (is this > what you meant by older devices?), Older machine types

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Markus Armbruster
Alexander Graf writes: >> Am 15.04.2014 um 18:56 schrieb Markus Armbruster : >> >> Alexander Graf writes: >> On 04/15/2014 04:00 PM, Markus Armbruster wrote: Juan Quintela writes: > Juan Quintela wrote: >> Hi >> >> Please, send any topic that you are interest

[Qemu-devel] [RFC PATCH] qapi: Allow setting default values for optional parameters

2014-04-15 Thread Fam Zheng
In command definition, 'default' is now parsed as a dict of default values. Only optional parameters will have effect in generated code. 'str' and 'int' are supported, both need single quote in the schema. In generated code, 'str' will be converted to g_strdup'ed pointer, 'int' will be identically

[Qemu-devel] [Bug 1257352] Re: kvm hangs occasionally when switching out of the qemu console

2014-04-15 Thread Serge Hallyn
I've been trying to reproduce with current trusty, but on amd64, with no success. Which guest were you using? Can you reproduce it just booting a desktop iso with SDL graphics, i.e. kvm -cdrom ubuntu-13.10-desktop-$arch.iso -m 512 ? (Will test on i386. If that succeeds then I can bisect.) --

[Qemu-devel] qemu builds on arm hosts

2014-04-15 Thread New B
Hey folks, Are qemu builds supported for aarch64 arm hosts? I hit these errors: 1- a pragma #error induced error in tcg/aarch64/tcg-target.c stating that "USE_DIRECT_JUMP required for aarch64”, line 1105. 2- a link failure: Undefined symbols for architecture x86_64: "_print_insn_i386", refe

Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue'

2014-04-15 Thread liang ding
我怎样才能退订此邮件列表 How can I unsubscribe from this mailing list 2014-04-15 19:05 GMT+08:00 Chen Gang : > > > On 04/15/2014 04:50 PM, Markus Armbruster wrote: > > Chen Gang writes: > > > >> Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not > >> need additional useless 'continue'.

[Qemu-devel] 答复: report a suspect bug about arm gic

2014-04-15 Thread zhuxiaodong
I don't doubt about the algorithm of level interrupts. The problem may come from the level value tested by GIC_TEST_LEVEL(irq, cm). It is set in gic_set_irq_generic(): > 115 static void gic_set_irq_generic(GICState *s, int irq, int level, > 116 int cm, int target) >

Re: [Qemu-devel] QEMU 2.0 RC with Spice

2014-04-15 Thread Rick Vernam
On Tuesday 15 April 2014 19:25:22 Rick Vernam wrote: > Looks like it's in Spice: > > [New Thread 0x7ffe5dffb700 (LWP 28129)] > main_channel_handle_parsed: agent start > main_channel_handle_parsed: agent start > [Thread 0x7fff5a7fc700 (LWP 28072) exited] > > Program received signal SIGSEGV, Segmen

Re: [Qemu-devel] [PATCH v4 1/6] block-commit: Expose granularity

2014-04-15 Thread Fam Zheng
On Sat, 04/12 20:57, Max Reitz wrote: > Allow QMP users to manipulate the granularity used in the block-commit > command. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > block/commit.c| 16 +--- > block/mirror.c| 4 ++-- > blockdev.c

[Qemu-devel] [PATCH] scsi-disk: Improve error messager if can't get version number

2014-04-15 Thread Fam Zheng
More often it is that bdrv_ioctl fails due to not supported by driver or whatever reason, in this case we should be specific, because "interface too old" is very confusing. Signed-off-by: Fam Zheng --- hw/scsi/scsi-disk.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] qemu-ga: How to static compilation qemu-ga.exe for windows on fedora 18

2014-04-15 Thread Gonglei (Arei)
Hi, I'm using qemu-ga.exe in windows server 2008 R2 64. I want to use it without libraries such as iconv.dll, libglib-2.0-0.dll, libintl-8.dll and libssp-0.dll So I use static compilation on fedora 18. build qemu-1.7.0: # for Windows using MinGW on linux (Fedora 18) ./configure --enable-gues

[Qemu-devel] [PATCH] qdev: fix crash by validating the object type

2014-04-15 Thread Amos Kong
QEMU crashed when I try to list device parameters, the driver name is actually the available bus name. # qemu -device virtio-pci-bus,? # qemu -device virtio-bus,? # qemu -device virtio-serial-bus,? qdev-monitor.c:212:qdev_device_help: Object 0x7fd932f50620 is not an instance of type device A

Re: [Qemu-devel] [PATCH v4 2/6] blockjob: Introduce block_job_complete_sync()

2014-04-15 Thread Fam Zheng
On Sat, 04/12 20:57, Max Reitz wrote: > Implement block_job_complete_sync() by doing the exact same thing as > block_job_cancel_sync() does, only with calling block_job_complete() > instead of block_job_cancel(). > > Signed-off-by: Max Reitz > --- > blockjob.c | 24

[Qemu-devel] [PATCH v3] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap

2014-04-15 Thread Fam Zheng
bdrv_getlength could fail, check the return value before using it. Return NULL and set errno if it fails. Callers are updated to handle the error case. Signed-off-by: Fam Zheng --- v3: Fix errno (Max) Signed-off-by: Fam Zheng --- block-migration.c | 30 ++ bloc

Re: [Qemu-devel] [PATCH v2] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap

2014-04-15 Thread Fam Zheng
On Wed, 04/16 09:16, Fam Zheng wrote: > On Tue, 04/15 16:07, Max Reitz wrote: > > On 15.04.2014 05:15, Fam Zheng wrote: > > >bdrv_getlength could fail, check the return value before using it. > > > > > >Signed-off-by: Fam Zheng > > > > > >--- > > >v2: Make use of error_setg_errno and -errno. (Kevi

Re: [Qemu-devel] [PATCH v2] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap

2014-04-15 Thread Fam Zheng
On Tue, 04/15 16:07, Max Reitz wrote: > On 15.04.2014 05:15, Fam Zheng wrote: > >bdrv_getlength could fail, check the return value before using it. > > > >Signed-off-by: Fam Zheng > > > >--- > >v2: Make use of error_setg_errno and -errno. (Kevin) > > > >Signed-off-by: Fam Zheng > >--- > > block-

[Qemu-devel] [Bug 1307656] Re: qemu segfault when starting virt-manager

2014-04-15 Thread Pieter Hollants
Yep, confirm it's fixed in rc3. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307656 Title: qemu segfault when starting virt-manager Status in QEMU: Fix Committed Bug description: libvirtd 1

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Kevin O'Connor
On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: > Leave the old interface code basically as-is. type0 and type1 > individual fields are passed like they are passed today. We don't > change to to pass full tables, and we don't extend that to new table > types. Continue to provide t

Re: [Qemu-devel] QEMU 2.0 RC with Spice

2014-04-15 Thread Rick Vernam
Looks like it's in Spice: [New Thread 0x7ffe5dffb700 (LWP 28129)] main_channel_handle_parsed: agent start main_channel_handle_parsed: agent start [Thread 0x7fff5a7fc700 (LWP 28072) exited] Program received signal SIGSEGV, Segmentation fault. 0x72152ee5 in ?? () from /usr/lib64/libspice-se

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-04-15 Thread Damjan Marion
just to clarify, i was pinning my test code inside the guest with "taskset -c 1". There was no pinning on the host side. Also, i see the same issue with -smp 2. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

Re: [Qemu-devel] [Xen-devel] [PATCH 1/2] xen: fix usage of ENODATA

2014-04-15 Thread Andrew Cooper
On 15/04/14 17:28, Roger Pau Monné wrote: > On 15/04/14 18:15, Anthony PERARD wrote: >> On Tue, Apr 15, 2014 at 10:33:08AM +0200, Roger Pau Monne wrote: >>> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the >>> hypervisor are translated to ENOENT. >>> >>> Also, the error code is r

[Qemu-devel] [PATCH trivial v2 2/2] vl: Eliminate a superfluous local variable

2014-04-15 Thread Chen Gang
CODING_STYLE frowns upon mixing declarations and statements. main() has such a declaration. Clean up by eliminating the variable. Signed-off-by: Chen Gang --- vl.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/vl.c b/vl.c index 377f962..d381443 100644

[Qemu-devel] [PATCH trivial v2 1/2] vl: Remove useless 'continue'

2014-04-15 Thread Chen Gang
"This if else has no code between it and the end of the enclosing while loop. This makes this continue redundant." Signed-off-by: Chen Gang --- vl.c |1 - 1 file changed, 1 deletion(-) diff --git a/vl.c b/vl.c index 9975e5a..7505002 100644 --- a/vl.c +++ b/vl.c @@ -3034,7 +3034,6 @@ int mai

[Qemu-devel] [PATCH trivial v2 0/2] vl: simplify code for main()

2014-04-15 Thread Chen Gang
In "vl.c", at least, we can simplify the code below, so can let readers read professional C code (especially for new readers, which often start reading code at main function). - Remove useless 'continue' in main(). - Eliminate a superfluous local variable in main(). Signed-off-by: Chen Gang -

Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration

2014-04-15 Thread Ján Veselý
Hi, I found some more time to work on this. However, I'm not sure I understand the purpose of compat property: I noticed that the only place it's set is in PC_COMPAT_1_3 (is this what you meant by older devices?), I guess same setting for FS mouse and kbd should be added there as well. The switch

Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()

2014-04-15 Thread Chen Gang
On 04/15/2014 10:51 PM, Markus Armbruster wrote: > Chen Gang writes: > >> On 04/15/2014 04:49 PM, Markus Armbruster wrote: >>> In future submissions, please send the patches in-reply-to the cover >>> letter, not chained together in-reply-to the previous part. Check out >>> git-send-email --no-ch

[Qemu-devel] Are Qemu builds supported for arm host?

2014-04-15 Thread New B
Hi, I keep getting this error: "must include QEMU headers” emitted from tcg/tcg-op.h. I have no idea how come this is happening. BTW, the same setup I have (build env + 1.7.1-stable qemu sources) to successfully build a functional qemu-system-arm for x86-64 host. Any info/pointers are

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-15 Thread Peter Crosthwaite
On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: > Am 15.04.2014 04:21, schrieb Peter Crosthwaite: >> So clients can set the top level id string. >> >> Signed-off-by: Peter Crosthwaite > > Anthony had nack'ed Paolo's attempt to generalize the qdev id to QOM, so > I'm not sure if we should r

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Alexander Graf
> Am 15.04.2014 um 18:56 schrieb Markus Armbruster : > > Alexander Graf writes: > >>> On 04/15/2014 04:00 PM, Markus Armbruster wrote: >>> Juan Quintela writes: >>> Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > Thank

Re: [Qemu-devel] [PATCH] qmp: object-add: Validate class before creating object

2014-04-15 Thread Matthew Rosato
On 04/15/2014 04:01 PM, Eduardo Habkost wrote: > Currently it is very easy to crash QEMU by issuing an object-add command > using an abstract class or a class that doesn't support > TYPE_USER_CREATABLE as parameter. > > Example: with the following QMP command: > > (QEMU) object-add qom-type=c

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-04-15 Thread Serge Hallyn
Reproduced just as easily with qemu.org git HEAD. Again, this appears to only be a case when using -smp 4 while locking to 1 cpu with cpuset. ** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PATCH] qmp: object-add: Validate class before creating object

2014-04-15 Thread Eduardo Habkost
Currently it is very easy to crash QEMU by issuing an object-add command using an abstract class or a class that doesn't support TYPE_USER_CREATABLE as parameter. Example: with the following QMP command: (QEMU) object-add qom-type=cpu id=foo QEMU aborts at: ERROR:qom/object.c:335:object

Re: [Qemu-devel] [PATCH v6] spapr_hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-04-15 Thread Mike Day
On Tue, Apr 8, 2014 at 2:28 AM, Alexander Graf wrote: > On 22.03.14 14:03, Alexey Kardashevskiy wrote: >> >> This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from >> the H_SET_MODE, for POWER8 (PowerISA 2.07) only. >> >> Signed-off-by: Alexey Kardashevskiy >> Reviewed-by: Mike Day > >

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-04-15 Thread Marcin Gibuła
W dniu 2014-04-15 20:53, Dr. David Alan Gilbert pisze: * Marcus (shadow...@gmail.com) wrote: I can answer some of the questions. It's been 3 months or so since I looked into it. I ended up disabling kvmclock from the qemu command line and moving on. I saw it with CentOS 6.5 and Ubuntu 12.04 gues

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-04-15 Thread Cole Robinson
On 04/15/2014 02:53 PM, Dr. David Alan Gilbert wrote: > * Marcus (shadow...@gmail.com) wrote: > >> As mentioned by others, the mode of reproduction is to launch the vm, >> wait about an hour, and then try to migrate it >> >> Here's are example qemu command lines (as generated from libvirt with

[Qemu-devel] [Bug 1270397] Re: Systemd segfaults after live migration

2014-04-15 Thread Dr. David Alan Gilbert
Hi Mateusz, How are you migrating? If you are using the compress/xbzrle option, try turning it off and see if that helps, there are some corruption fixes for xbzrle in 2.0.0. Dave -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] target-arm: implement WFE/YIELD as a yield for AArch64

2014-04-15 Thread Peter Maydell
On 15 April 2014 20:00, Rob Herring wrote: > From: Rob Herring > > Like was done for AArch32 for WFE, implement both WFE and YIELD as a > yield operation. This speeds up multi-core system emulation. > > Signed-off-by: Rob Herring Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH] target-arm: implement WFE/YIELD as a yield for AArch64

2014-04-15 Thread Rob Herring
From: Rob Herring Like was done for AArch32 for WFE, implement both WFE and YIELD as a yield operation. This speeds up multi-core system emulation. Signed-off-by: Rob Herring --- target-arm/translate-a64.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-arm/translate-a64.c b/t

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-04-15 Thread Dr. David Alan Gilbert
* Marcus (shadow...@gmail.com) wrote: > I can answer some of the questions. It's been 3 months or so since I > looked into it. I ended up disabling kvmclock from the qemu command > line and moving on. I saw it with CentOS 6.5 and Ubuntu 12.04 guests. > Sending the guest to the BIOS CLI or PXE would

Re: [Qemu-devel] [PATCH v4 4/4] ssi: pl022: Convert to use FIFO

2014-04-15 Thread Beniamino Galvani
On Mon, Apr 14, 2014 at 08:20:06PM -0700, Peter Crosthwaite wrote: > Use the FIFO API to factor out the ring buffer implementation code. > Cleans up the somewhat verbose VMS description as well (version bump > required). > > Signed-off-by: Peter Crosthwaite > --- > > hw/ssi/pl022.c | 101 > +++

Re: [Qemu-devel] [PATCH target-arm v1 1/1] net: cadence_gem: Make phy respond to broadcast

2014-04-15 Thread Peter Maydell
On 4 April 2014 07:55, Peter Crosthwaite wrote: > Phys must respond to address 0 by specification. Implement. > > Signed-off-by: Nathan Rossi > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v1 0/3] Zynq SLCR Rewrite and Update

2014-04-15 Thread Peter Maydell
On 3 April 2014 06:37, Peter Crosthwaite wrote: > Hi Peter, > > Iv'e finally gotten around to looking at SLCR and its coverity issues. > Ended up doing a rewrite of the whole thing to action (P1). > > Some styling updates to go with it as well (P2-3). Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v4 3/4] ssi: pl022: Send debug info to stderr

2014-04-15 Thread Beniamino Galvani
On Mon, Apr 14, 2014 at 08:19:31PM -0700, Peter Crosthwaite wrote: > To disentangle it from the monitor. > > Signed-off-by: Peter Crosthwaite > --- > > hw/ssi/pl022.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ssi/pl022.c b/hw/ssi/pl022.c > index fd479ef..84bf8

Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-04-15 Thread Beniamino Galvani
On Mon, Apr 14, 2014 at 08:18:56PM -0700, Peter Crosthwaite wrote: > Add support for 16, 32 and 64 bit width FIFOs. The push and pop > functions are replicated to accept all four different integer types. > The element width of the FIFO is set at creation time. > > The backing storage for all eleme

[Qemu-devel] [PATCH] target-ppc: Eliminate Magic Number MSR Masks

2014-04-15 Thread Tom Musta
Use MSR mnemonics from cpu.h instead of magic numbers for the CPUPPCState.msr_mask initialization. There is one bit in the 401x2 (and subsequent) model that I could not find any documentation for. It is open coded at little endian bit position 20: pcc->msr_mask = (1ull << 20) |

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-04-15 Thread Marcus
I can answer some of the questions. It's been 3 months or so since I looked into it. I ended up disabling kvmclock from the qemu command line and moving on. I saw it with CentOS 6.5 and Ubuntu 12.04 guests. Sending the guest to the BIOS CLI or PXE would not reproduce the issue. I didn't attempt an

Re: [Qemu-devel] [PATCH v4 1/4] util/fifo: Generalise naming scheme

2014-04-15 Thread Beniamino Galvani
On Mon, Apr 14, 2014 at 08:18:20PM -0700, Peter Crosthwaite wrote: > Generalise the names of the FIFO API to not include the "8". > > The exception is the push/pop functions for which we: > > s/fifo8_pop/fifo_pop8 > s/fifo8_push/fifo_push8 > > This prepares support for generalising FIFO support

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Markus Armbruster
Alexander Graf writes: > On 04/15/2014 04:00 PM, Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Thanks, Juan. >>> As there are no topics, no call. >> Did we have a call anyway?

Re: [Qemu-devel] [PATCH 1/2] xen: fix usage of ENODATA

2014-04-15 Thread Roger Pau Monné
On 15/04/14 18:15, Anthony PERARD wrote: > On Tue, Apr 15, 2014 at 10:33:08AM +0200, Roger Pau Monne wrote: >> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the >> hypervisor are translated to ENOENT. >> >> Also, the error code is returned in errno if the call returns -1, so >> co

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Peter Maydell
Some fuller comments below on the parts of the call which I had opinions on. On 15 April 2014 15:55, Alexander Graf wrote: > > 2) -device for non-PCI devices > > There are 2 reasons we want to create "platform" devices using -device on > the command line. One is that Xilinx is trying to create a

Re: [Qemu-devel] [PATCH 1/2] xen: fix usage of ENODATA

2014-04-15 Thread Anthony PERARD
On Tue, Apr 15, 2014 at 10:33:08AM +0200, Roger Pau Monne wrote: > ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the > hypervisor are translated to ENOENT. > > Also, the error code is returned in errno if the call returns -1, so > compare the error code with the value in errno in

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-15 Thread Andreas Färber
Am 15.04.2014 04:21, schrieb Peter Crosthwaite: > So clients can set the top level id string. > > Signed-off-by: Peter Crosthwaite Anthony had nack'ed Paolo's attempt to generalize the qdev id to QOM, so I'm not sure if we should really do this even if just on device level. The id= is used to co

Re: [Qemu-devel] [PATCH] Add remove_boot_device_path() function for hot-unplug device

2014-04-15 Thread lijun
On 04/15/2014 12:18 AM, Markus Armbruster wrote: lijun writes: Hi Markus, Really appreciate your review first. I almost a new participant. And I read other's patches very little. So maybe this patch is duplicate to one of Marcel's patch. But I really do not know. And I really don't copying

Re: [Qemu-devel] [PATCH] Add remove_boot_device_path() function for hot-unplug device

2014-04-15 Thread lijun
On 04/15/2014 02:04 AM, Andreas Färber wrote: Am 13.04.2014 15:24, schrieb Jun Li: Add remove_boot_device_path() function to remove bootindex when hot-unplug a device. This patch fixed virtio-blk/virtio-net/scsi-disk/scsi-generic device. So it has fixed bug1086603, ref: https://bugzilla.redhat.

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread 陈梁
Hi Do we have any plan to support migration by multi net card? Thanks ChenLiang > > Hi > > Please, send any topic that you are interested in covering. > > Thanks, Juan. > > Call details: > > 15:00 CEST > 13:00 UTC > 09:00 EDT > > Every two weeks > > If you need phone number details, conta

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init.c: remove duplicate function

2014-04-15 Thread 陈梁
> On 04/15/14 01:55, Michael R. Hines wrote: >> On 04/14/2014 05:19 PM, Laszlo Ersek wrote: >>> On 04/14/14 04:27, Amos Kong wrote: We already have a function buffer_is_zero() in util/cutils.c Signed-off-by: Amos Kong --- arch_init.c | 9 ++--- 1 file changed,

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-04-15 Thread Igor Mammedov
On Tue, 15 Apr 2014 14:37:01 +0800 Hu Tao wrote: > On Mon, Apr 14, 2014 at 06:44:42PM +0200, Igor Mammedov wrote: > > On Mon, 14 Apr 2014 15:25:01 +0800 > > Hu Tao wrote: > > > > > On Fri, Apr 04, 2014 at 03:36:58PM +0200, Igor Mammedov wrote: > > > > Needed for Windows to use hotplugged memory

Re: [Qemu-devel] [PATCH] vexpress: Add support for the -bios flag to provide firmware

2014-04-15 Thread Peter Maydell
On 28 March 2014 17:57, Grant Likely wrote: > Right now to run firmware inside the QEMU VExpress model requires > padding out the firmware image to the size of the virtual flash and > passing it in via the -pflash argument. If the firmware image is passed > without padding, then QEMU will fail. A

Re: [Qemu-devel] [PATCH] vexpress: Add support for the -bios flag to provide firmware

2014-04-15 Thread Peter Maydell
On 28 March 2014 17:57, Grant Likely wrote: > Right now to run firmware inside the QEMU VExpress model requires > padding out the firmware image to the size of the virtual flash and > passing it in via the -pflash argument. If the firmware image is passed > without padding, then QEMU will fail. Al

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Eric Auger
On 04/15/2014 04:55 PM, Alexander Graf wrote: > On 04/15/2014 04:00 PM, Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Thanks, Juan. >>> As there are no topics, no call. >> Did w

Re: [Qemu-devel] [PATCH target-arm v1 1/1] arm: translate.c: Fix smlald Instruction

2014-04-15 Thread Peter Maydell
On 4 April 2014 03:19, Peter Crosthwaite wrote: > The smlald (and probably smlsld) instruction was doing incorrect sign > extensions of the operands amongst 64bit result calculation. The > instruction psuedo-code is: > > operand2 = if m_swap then ROR(R[m],16) else R[m]; > product1 = SInt(R[n]<15

[Qemu-devel] [PATCH] do_interrupt64 shouldn't be called when GIF is not set.

2014-04-15 Thread Himanshu Chauhan
I am not very sure about the place(s) we would need this. But I think this is required. Please advise. When having SVM enabled, the do_interrupt64 shouldn't be called unless GIF is set otherwise this causes random behaviour especially bad TR in case guest is running. Signed-off-by: Himanshu Chauh

Re: [Qemu-devel] [PATCH v1 1/1] vl.c: Allow sysbus devices to be attached via commandline

2014-04-15 Thread Andreas Färber
Hi, Am 26.03.2014 01:47, schrieb Alistair Francis: > This patch introduces a new command line argument that allows > sysbus devices to be attached via the command line. > > This allows devices to be added after the machine init but > before anything is booted > > The new argument is -sysbusdev >

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Alexander Graf
On 04/15/2014 04:00 PM, Markus Armbruster wrote: Juan Quintela writes: Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Thanks, Juan. As there are no topics, no call. Did we have a call anyway? IRC log looks like we did... Yes, we did. Whoever attend

Re: [Qemu-devel] segfault while booting from saved snapshot

2014-04-15 Thread Shehbaz Jaffer
Thankyou for your reply. I do not face the error using qemu.1.7.1 version. 1 quick question: I want to create a qcow2 image file after my VM has completed booting; i.e., when I boot from this new snapshot, I should directly get to my VMs login prompt. How can i create such a qcow2 snapshot? I tr

Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()

2014-04-15 Thread Markus Armbruster
Chen Gang writes: > On 04/15/2014 04:49 PM, Markus Armbruster wrote: >> In future submissions, please send the patches in-reply-to the cover >> letter, not chained together in-reply-to the previous part. Check out >> git-send-email --no-chain-reply-to. >> > > OK, thanks. But excuse me, I use th

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-15 Thread Peter Maydell
On 15 April 2014 14:22, Greg Kurz wrote: > On Tue, 15 Apr 2014 13:35:03 +0200 > Alexander Graf wrote: >> That would defeat the purpose - the reason to have the helper inlined is >> to remove the conditional branch for x86. >> > > Sure but on the other hand, Peter does not like the idea of moving

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Markus Armbruster
Juan Quintela writes: > Juan Quintela wrote: >> Hi >> >> Please, send any topic that you are interested in covering. >> >> Thanks, Juan. > > As there are no topics, no call. Did we have a call anyway? IRC log looks like we did...

Re: [Qemu-devel] QEMU 2.0 RC with Spice

2014-04-15 Thread Dr. David Alan Gilbert
* Rick Vernam (rtver...@hobi.com) wrote: > I have been trying out the 2.0 RCs, and I've noticed that when I use spice > qemu aborts when I reboot the VM. This occurs on Win XP guest, Win 7 > (64-bit) > guest and Win 8 (64-bit) guest. > Is this something that anybody else experiences? > I don't

Re: [Qemu-devel] [PATCH v2] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap

2014-04-15 Thread Max Reitz
On 15.04.2014 05:15, Fam Zheng wrote: bdrv_getlength could fail, check the return value before using it. Signed-off-by: Fam Zheng --- v2: Make use of error_setg_errno and -errno. (Kevin) Signed-off-by: Fam Zheng --- block-migration.c | 28 block.c

Re: [Qemu-devel] [PATCH] block: prefer protocol_name over format_name in bdrv_iterate_format

2014-04-15 Thread Kevin Wolf
Am 15.04.2014 um 15:28 hat Jeff Cody geschrieben: > Some block drivers have multiple BlockDriver instances with identical > format_name fields (e.g. gluster, nbd). In those cases, the > protocol_name is usually the more unique identifier (e.g. gluster+tcp). > > Both qemu-img and qemu will use bdr

Re: [Qemu-devel] [PATCH] block: prefer protocol_name over format_name in bdrv_iterate_format

2014-04-15 Thread Max Reitz
On 15.04.2014 15:28, Jeff Cody wrote: Some block drivers have multiple BlockDriver instances with identical format_name fields (e.g. gluster, nbd). In those cases, the protocol_name is usually the more unique identifier (e.g. gluster+tcp). Both qemu-img and qemu will use bdrv_iterate_format() t

Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()

2014-04-15 Thread Chen Gang
On 04/15/2014 04:49 PM, Markus Armbruster wrote: > Chen Gang writes: > >> In "vl.c", at least, we can simplify the code below, so can let readers >> read professional C code (especially for new readers, which often start >> reading code at main function). >> >> - remove useless 'continue' in mai

[Qemu-devel] QEMU 2.0 RC with Spice

2014-04-15 Thread Rick Vernam
I have been trying out the 2.0 RCs, and I've noticed that when I use spice qemu aborts when I reboot the VM. This occurs on Win XP guest, Win 7 (64-bit) guest and Win 8 (64-bit) guest. Is this something that anybody else experiences? I don't care to divert anybody's energy if this a spice thing

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Gabriel L. Somlo
On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: > So, how about this plan: > > Leave the old interface code basically as-is. type0 and type1 > individual fields are passed like they are passed today. We don't > change to to pass full tables, and we don't extend that to new table >

Re: [Qemu-devel] [Xen-devel] [PATCH 1/2] xen: fix usage of ENODATA

2014-04-15 Thread Egger, Christoph
On 15.04.14 10:33, Roger Pau Monne wrote: > ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the > hypervisor are translated to ENOENT. > > Also, the error code is returned in errno if the call returns -1, so > compare the error code with the value in errno instead of the value > re

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2014-04-15 Thread Bryan Quigley
QEMU 1.7 was released, Quantal has 10ish days left of support, and Raring is EOL ** Changed in: qemu Status: Fix Committed => Fix Released ** Changed in: qemu-kvm (Ubuntu Quantal) Status: Triaged => Invalid ** Changed in: qemu-kvm (Ubuntu Raring) Status: Triaged => Invalid

[Qemu-devel] [Bug 1257352] Re: kvm hangs occasionally when switching out of the qemu console

2014-04-15 Thread James Hunt
Sorry - ignore that. However, problem persists on a separate fully- updated amd64 trusty system running kvm version 2.0.0~rc1+dfsg-0ubuntu3. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1257352 Titl

[Qemu-devel] [PATCH] block: prefer protocol_name over format_name in bdrv_iterate_format

2014-04-15 Thread Jeff Cody
Some block drivers have multiple BlockDriver instances with identical format_name fields (e.g. gluster, nbd). In those cases, the protocol_name is usually the more unique identifier (e.g. gluster+tcp). Both qemu-img and qemu will use bdrv_iterate_format() to list the supported formats when a help

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > Thanks, Juan. As there are no topics, no call.

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-15 Thread Greg Kurz
On Tue, 15 Apr 2014 13:35:03 +0200 Alexander Graf wrote: > On 04/15/2014 10:40 AM, Greg Kurz wrote: > > On Mon, 14 Apr 2014 15:08:23 +0200 > > Alexander Graf wrote: > > > >> On 14.04.14 14:55, Michael S. Tsirkin wrote: > >>> On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: >

[Qemu-devel] Replacing display contents on paused VMs causes only a short flicker

2014-04-15 Thread Erik Rull
Hi all, I try to replace the display content of a paused VM (to show the operator that it is actually paused and not usable), but it causes only a short flicker on the display instead of staying permanent. By routing an HMP based command to console.c I want to replace the display contents. I star

Re: [Qemu-devel] KVM call agenfda for 2014-04-01

2014-04-15 Thread Andreas Färber
Am 10.04.2014 17:52, schrieb Peter Maydell: > On 10 April 2014 16:49, Alexander Graf wrote: >> For the next call, I would propose to revive the "platform bus" >> (aka: how to create non-PCI devices with -device) discussions >> to make sure we're all on the same page. > > I rather suspect we are n

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-15 Thread Alexander Graf
On 04/14/2014 07:37 PM, Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. As mentioned in the last email I still have the sysbus -device topic on the list. If Alexey shows up I would also like to discuss the IOMMU bus patch and why we need a bus solely for l

[Qemu-devel] [Bug 1287195] Re: validate_guest_space incorrectly enabled on AArch64

2014-04-15 Thread Peter Maydell
Fix will be in 2.0. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1287195 Title: validate_guest_space incorrectly enabled on AArch6

Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block

2014-04-15 Thread Chen Gang
On 04/15/2014 08:29 PM, Peter Crosthwaite wrote: > On Tue, Apr 8, 2014 at 10:05 PM, Chen Gang wrote: >> For C code, it does not recommend to define a local variable in the >> middle of code block without "{...}". The original author may want to >> zero members not mentioned in structure assignment

Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block

2014-04-15 Thread Peter Crosthwaite
On Tue, Apr 8, 2014 at 10:05 PM, Chen Gang wrote: > For C code, it does not recommend to define a local variable in the > middle of code block without "{...}". The original author may want to > zero members not mentioned in structure assignment. > > So recommend to use structure initializing block

[Qemu-devel] [Bug 1263747] Re: Arm64 fails to run a binary which runs OK on real hardware

2014-04-15 Thread Peter Maydell
The (re)implementation of this instruction for mainline never had this bug. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1263747 Title: Ar

Re: [Qemu-devel] Global overview

2014-04-15 Thread Kevin Grandemange
Thanks a lot, that's exactly what I was searching for. 2014-04-15 12:26 GMT+02:00 Laszlo Ersek : > On 04/15/14 11:58, Dr. David Alan Gilbert wrote: > > * Kevin Grandemange (grandemange.ke...@gmail.com) wrote: > >> Hi, > >> > >> I was wondering if a document describing how the differents parts of

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-15 Thread Alexander Graf
On 04/15/2014 10:40 AM, Greg Kurz wrote: On Mon, 14 Apr 2014 15:08:23 +0200 Alexander Graf wrote: On 14.04.14 14:55, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +020

Re: [Qemu-devel] report a suspect bug about arm gic

2014-04-15 Thread Peter Maydell
On 15 April 2014 02:33, zhuxiaodong wrote: > I am a user of qemu. I found that in qemu2.0.0-rc0 the gic model was > updated. However, it seems loss ability to bind irqs to any specified core > when the board includes multiple cortex-a9 cores. The problematic codes > maybe locate at hw/intc

Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block

2014-04-15 Thread Chen Gang
On 04/15/2014 04:56 PM, Markus Armbruster wrote: > Chen Gang writes: > >> For C code, it does not recommend to define a local variable in the >> middle of code block without "{...}". The original author may want to >> zero members not mentioned in structure assignment. >> >> So recommend to use

Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue'

2014-04-15 Thread Chen Gang
On 04/15/2014 04:50 PM, Markus Armbruster wrote: > Chen Gang writes: > >> Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not >> need additional useless 'continue'. >> >> Signed-off-by: Chen Gang >> --- >> vl.c |1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/

Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res'

2014-04-15 Thread Chen Gang
On 04/15/2014 04:43 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> On Tue, Apr 8, 2014 at 10:02 PM, Chen Gang wrote: >>> In function, if no additional resources to free before quit, commonly, >>> need not use additional local variable 'res' to notice about it. So >>> remove it to

[Qemu-devel] guest crash due to missing clock interrupt

2014-04-15 Thread Damjan Marion
Originally I reported this issue to ubuntu folks, and it is documented on the launchpad[1] but would like to bring this into attention also on this list. Basically seems that on some occasions clock interrupts are not happening for longer periods of time causing that some VMs are crashing (i.e

Re: [Qemu-devel] '.' IDs and certain names breaks -global and -set

2014-04-15 Thread Peter Crosthwaite
On Tue, Apr 15, 2014 at 1:38 AM, Andreas Färber wrote: > Am 14.04.2014 09:13, schrieb Markus Armbruster: >> Alistair Francis writes: >> >>> On Wed, Apr 9, 2014 at 9:58 PM, Peter Crosthwaite >>> wrote: On Wed, Apr 9, 2014 at 7:56 PM, Markus Armbruster wrote: > We have a number of

  1   2   >