Re: [Qemu-devel] [net, v1, 1/4] net: cadence_gem: Fix Tx descriptor update

2014-05-23 Thread Michael Tokarev
24.05.2014 10:38, Michael Tokarev wrote: > [...] > if (tx_desc_get_last(desc)) { > +unsigneddesc_first[2]; > + > /* Modify the 1st descriptor of this packet to be owned by > * the processor. > */ > cpu_physical_memory_re

Re: [Qemu-devel] [net, v1, 1/4] net: cadence_gem: Fix Tx descriptor update

2014-05-23 Thread Michael Tokarev
[...] if (tx_desc_get_last(desc)) { +unsigneddesc_first[2]; + /* Modify the 1st descriptor of this packet to be owned by * the processor. */ cpu_physical_memory_read(s->tx_desc_addr, -

Re: [Qemu-devel] target-sparc has inverse cwp logic for SAVE/RESTORE?

2014-05-23 Thread Blue Swirl
On Mon, May 19, 2014 at 1:56 PM, Mark Cave-Ayland wrote: > On 18/05/14 17:06, Olivier Danet wrote: > >> The problem may be related to the fact that the 32bits SPARCv8 and 64bits >> SPARCv9 work in opposite directions ! >> >> SparcV9 standard, page 360/399 : >> The SPARC-V9 CWP register is incremen

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] block: replace fprintf(stderr, ...) with error_report()

2014-05-23 Thread Michael Tokarev
24.05.2014 10:01, Le Tan пишет: > I will fix the whitespace issues and resend this series with a new > version later. Please note, once again: I applied (with fixups) other 3 your patches, so there's no need to resend those 3. This one, besides a whitespace problem, needs an ACK from block subsys

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] block: replace fprintf(stderr, ...) with error_report()

2014-05-23 Thread Le Tan
I will fix the whitespace issues and resend this series with a new version later. Thanks very much! ;) Le 2014-05-24 4:27 GMT+08:00 Michael Tokarev : > 21.05.2014 04:10, Le Tan wrote: >> Replace fprintf(stderr,...) with error_report() in files block/*, block.c, >> block-migration.c and blockdev.c

Re: [Qemu-devel] [PATCH 1/4] arch_init: replace fprintf(stderr, ...) with error_report() in arch_init.c

2014-05-23 Thread Michael Tokarev
24.05.2014 09:41, Le Tan wrote: > There is a newer version of patch to fix this problem. I forgot to add > the version number when I sent the new patch. Add this comment just to > indicate that this patch should be dropped. :) I've already applied your v2 to the trivial tree, and I told you just t

Re: [Qemu-devel] [PATCH 3/4] block: replace fprintf(stderr, ...) with error_report() in block/

2014-05-23 Thread Le Tan
There is a newer version of patch to fix this problem. I forgot to add the version number when I sent the new patch. Add this comment just to indicate that this patch should be dropped. :) 2014-05-10 21:18 GMT+08:00 Peter Crosthwaite : > On Sat, May 10, 2014 at 9:55 AM, Le Tan wrote: >> Replace f

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2014-05-23 Thread xiando
Used QEMU this morning, noticed mce error in log, searched, found this. * model name: Intel(R) Core(TM) i3-4130 CPU @ 3.40GHz (it's a Haswell) * kernel 3.14.4-gentoo * app-emulation/qemu-1.6.1 * qemu-system-i386 -enable-kvm andsoon * [73468.545378] mce: [Hardware Error]: Machine check events log

[Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits

2014-05-23 Thread Andrew Oates
Without the mask, control bits are passed on in the keycode, generating incorrect PS/2 sequences when SHIFT, ALT, etc are held down. Signed-off-by: Andrew Oates --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index b044790..de85f7

Re: [Qemu-devel] [PATCH 1/4] arch_init: replace fprintf(stderr, ...) with error_report() in arch_init.c

2014-05-23 Thread Le Tan
There is a newer version of patch to fix this problem. I forgot to add the version number when I sent the new patch. Add this comment just to indicate that this patch should be dropped. :) 2014-05-10 7:55 GMT+08:00 Le Tan : > Replace fprintf(stderr,...) with error_report() in the file > arch_init.

Re: [Qemu-devel] [PATCH v6 5/7] vfio: Introduce VFIO address spaces

2014-05-23 Thread Alexey Kardashevskiy
On 05/24/2014 07:15 AM, Alexander Graf wrote: > > On 23.05.14 18:16, Alexey Kardashevskiy wrote: >> On 05/23/2014 10:05 PM, Alexander Graf wrote: >>> On 23.05.14 14:03, Alexey Kardashevskiy wrote: On 05/23/2014 09:28 PM, Alexander Graf wrote: > On 23.05.14 06:59, Alexey Kardashevskiy wrot

Re: [Qemu-devel] [PATCH net v1 0/4] Cadence GEM patches

2014-05-23 Thread Peter Crosthwaite
Ping^2! I'll try trivial queue too :) Regards, Peter On Wed, May 14, 2014 at 11:17 PM, Peter Crosthwaite wrote: > Ping! > > On Wed, May 7, 2014 at 9:15 AM, Peter Crosthwaite > wrote: >> >> Hi Stefan, Peter, >> >> Found a bug in the Cadence GEM. Fixed in P1. Have some follow us trivials >> as w

Re: [Qemu-devel] qemu 2.0, deadlock in block-commit

2014-05-23 Thread Marcin Gibuła
W dniu 2014-05-23 15:14, Marcin Gibuła pisze: bdrv_requests_pending(), called by bdrv_requests_pending_all(), is the function that determines for each of the disks in your VM if it still has requests in flight that need to be completed. This function must have returned true even though there is n

Re: [Qemu-devel] [libvirt] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 15:35, Markus Armbruster ha scritto: Luiz Capitulino writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti wrote: Then the guest triggers an RTC update, so qemu sends an event, but the event is lost. Then libvirtd starts again, and doesn't realize the event is lost. Yes

Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/4] bsd-user: replace fprintf(stderr, ...) with error_report()

2014-05-23 Thread Michael Tokarev
10.05.2014 03:55, Le Tan wrote: > Replace fprintf(stderr,...) with error_report() in files bsd-user/*. > The trailing "\n"s of the @fmt argument have been removed > because @fmt of error_report() should not contain newline. I'd fix two issues in there: ... > default: > pc =

Re: [Qemu-devel] [PATCH v6 5/7] vfio: Introduce VFIO address spaces

2014-05-23 Thread Alexander Graf
On 23.05.14 18:16, Alexey Kardashevskiy wrote: On 05/23/2014 10:05 PM, Alexander Graf wrote: On 23.05.14 14:03, Alexey Kardashevskiy wrote: On 05/23/2014 09:28 PM, Alexander Graf wrote: On 23.05.14 06:59, Alexey Kardashevskiy wrote: From: David Gibson The only model so far supported for VF

Re: [Qemu-devel] [PATCH] w32: Fix regression caused by new g_poll implementation

2014-05-23 Thread Stefan Weil
Am 23.05.2014 12:36, schrieb Peter Maydell: > On 17 May 2014 09:34, Stefan Weil wrote: >> Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a >> performance degradation caused by bad handling of small timeouts >> in the original implementation of g_poll. >> >> Since that commit, hard di

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] audio: replace fprintf(stderr, ...) with error_report() in audio

2014-05-23 Thread Michael Tokarev
10.05.2014 03:55, Le Tan wrote: > Replace fprintf(stderr,...) with error_report() in files audio/*. > The trailing "\n"s of the @fmt argument have been removed > because @fmt of error_report() should not contain newline. Please always check your patches using ./scripts/checkpatch.pl. I've applied

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-23 Thread Gabriel L. Somlo
On Fri, May 23, 2014 at 12:00:12PM +0300, Michael S. Tsirkin wrote: > > 1. There's a fairly complex setup (create a boot disk, start the > > guest, loop around waiting for the bios to finish booting, watch > > when your disk-based boot loader runs, etc.) before starting to > > examine the guest mem

Re: [Qemu-devel] [Qemu-trivial] [PATCH] libcacard: remove useless initializers

2014-05-23 Thread Michael Tokarev
So, should we apply this or not? It's been waiting for quite some time, and during this time we've found a very good example of why it should be applied (I think anyway). Thanks, /mjt 12.05.2014 13:20, Markus Armbruster wrote: > Michael Tokarev writes: > >> 11.05.2014 11:58, Alon Levy wrote:

[Qemu-devel] [PATCH] libcacard: fix wrong array expansion logic

2014-05-23 Thread Michael Tokarev
The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options() has a weird bug in variable usage around expanding opts->vreader array. There's a helper variable, vreaderOpt, which is first needlessly initialized to NULL, next, conditionally, only we have to expand opts->vreader, receives arr

Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups

2014-05-23 Thread Michael Tokarev
23.05.2014 22:20, Michael Tokarev wrote: > 23.05.2014 15:24, Markus Armbruster wrote: >> Makes Coverity happy with libcacard/ (for now). >> >> v2: >> - Fix g_new() vs. g_renew() mistake in PATCH 5 [Michael Tokarev] >> - Trivially rebased > >> Markus Armbruster (7): >> libcacard/vscclient: Bury s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix 'name' option to work with -readconfig

2014-05-23 Thread Michael Tokarev
06.05.2014 15:15, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The 'name' option silently failed when used in config files > ( http://lists.gnu.org/archive/html/qemu-devel/2014-04/msg00378.html ) > > Signed-off-by: Dr. David Alan Gilbert > Reported-by: William Dauchy

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: Put tempfiles in a subdir of the build directory

2014-05-23 Thread Michael Tokarev
23.05.2014 20:07, Peter Maydell wrote: > When libtool support was added to configure, the new temporary files > were left out of the list of files cleaned up on exit; this results > in a lot of stale .lo files being left around in /tmp. Worse, libtool > creates a /tmp/.libs directory which we can't

Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma-helpers: avoid calling dma_bdrv_unmap() twice

2014-05-23 Thread Michael Tokarev
23.05.2014 07:44, Jules Wang wrote: > Calling dma_bdrv_unmap() twice is not necessary and may cause > potential problems if some code changes. > > Signed-off-by: Jules Wang > --- > dma-helpers.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dma-helpers.c b/dma-h

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] block: replace fprintf(stderr, ...) with error_report()

2014-05-23 Thread Michael Tokarev
21.05.2014 04:10, Le Tan wrote: > Replace fprintf(stderr,...) with error_report() in files block/*, block.c, > block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument > have been removed because @fmt of error_report() should not contain newline. > > Signed-off-by: Le Tan > --- >

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] arch_init: replace fprintf(stderr, ...) with error_report()

2014-05-23 Thread Michael Tokarev
21.05.2014 04:10, Le Tan wrote: > Replace fprintf(stderr,...) with error_report() in the file > arch_init.c. The trailing "\n"s of the @fmt argument have been removed > because @fmt of error_report() should not contain newline. Applied to -trivial queue. Thank you for the work! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci: move dereferencing of root only after verifying valid root pointer.

2014-05-23 Thread Michael Tokarev
22.05.2014 15:33, Saravanakumar wrote: > Move dereferencing of root only after verifying valid root pointer. Applied to -trivial, after removing duplicate commit comment. Thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] jazz_led: Add missing break in switch case

2014-05-23 Thread Michael Tokarev
Applied to -trivial queue, thank you! /mjt

Re: [Qemu-devel] [PATCH 2/2] tcg/optimize: Remember garbage high bits for 32-bit ops

2014-05-23 Thread Richard Henderson
On 05/23/2014 12:46 PM, Paolo Bonzini wrote: >> @@ -166,11 +166,18 @@ static void tcg_opt_gen_mov(TCGContext *s, int >> op_index, TCGArg *gen_args, >> TCGOpcode old_op, TCGArg dst, TCGArg src) >> { >> TCGOpcode new_op = op_to_mov(old_op); >> +tcg_target_ulong

Re: [Qemu-devel] [PATCH 2/2] tcg/optimize: Remember garbage high bits for 32-bit ops

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 20:57, Richard Henderson ha scritto: For a 64-bit host, the high bits of a register after a 32-bit operation are undefined. Adjust the temps mask for all 32-bit ops to reflect that. Signed-off-by: Richard Henderson --- tcg/optimize.c | 33 ++--- 1 fil

Re: [Qemu-devel] [PATCH 00/24] tcg mips updates

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 21:15, Richard Henderson ha scritto: Ping? I reviewed most of it, will try to finish it in the weekend. r~ On 05/14/2014 12:17 AM, Richard Henderson wrote: Obviously the most important part here is the ldst updates, but there are all sorts of opportunities for improvement in t

Re: [Qemu-devel] [PATCH 00/24] tcg mips updates

2014-05-23 Thread Richard Henderson
Ping? r~ On 05/14/2014 12:17 AM, Richard Henderson wrote: > Obviously the most important part here is the ldst updates, > but there are all sorts of opportunities for improvement in > this backend. > > > r~ > > > Richard Henderson (24): > tcg-mips: Layout executable and code_gen_buffer >

[Qemu-devel] [PATCH 0/2] tcg/optimize fix for known-zero bits

2014-05-23 Thread Richard Henderson
A bug reported by Hartmut Penner visible on s390 host and ppc64 guest: IN: 0x001ff378: lwz r3,436(r7) 0x001ff37c: lis r0,-17874 0x001ff380: ori r0,r0,35747 0x001ff384: mulhwu r4,r3,r0 0x001ff388: rlwinm r5,r4,29,3,31 0x001ff38c: r

[Qemu-devel] [PATCH 1/2] tcg/optimize: Move updating of gen_opc_buf into tcg_opt_gen_mov*

2014-05-23 Thread Richard Henderson
No functional change, just reduce a bit of redundancy. Signed-off-by: Richard Henderson --- tcg/optimize.c | 117 +++-- 1 file changed, 56 insertions(+), 61 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3a504a1..83e1387 10064

[Qemu-devel] [PATCH 2/2] tcg/optimize: Remember garbage high bits for 32-bit ops

2014-05-23 Thread Richard Henderson
For a 64-bit host, the high bits of a register after a 32-bit operation are undefined. Adjust the temps mask for all 32-bit ops to reflect that. Signed-off-by: Richard Henderson --- tcg/optimize.c | 33 ++--- 1 file changed, 26 insertions(+), 7 deletions(-) diff --g

Re: [Qemu-devel] [libvirt] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for

2014-05-23 Thread Laine Stump
On 05/23/2014 05:54 PM, Eric Blake wrote: > On 05/23/2014 04:19 AM, Laine Stump wrote: >> On 05/23/2014 12:17 PM, Laine Stump wrote: >>> *However*, this discussion forced me to investigate some of the basic >>> assumptions that I'd been making when coming in to fix this bug. In >>> particular, my a

Re: [Qemu-devel] [libvirt] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for

2014-05-23 Thread Eric Blake
On 05/23/2014 08:54 AM, Eric Blake wrote: > For this to work, a > persistent guest definition needs to record the offset that was in use > at the time the guest powered off, and the next time qemu is started, > pass _that_ offset as the command-line offset against UTC. In libvirt's > case, we i

Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups

2014-05-23 Thread Michael Tokarev
23.05.2014 15:24, Markus Armbruster wrote: > Makes Coverity happy with libcacard/ (for now). > > v2: > - Fix g_new() vs. g_renew() mistake in PATCH 5 [Michael Tokarev] > - Trivially rebased > Markus Armbruster (7): > libcacard/vscclient: Bury some dead code > libcacard: Plug memory leaks arou

Re: [Qemu-devel] [PATCH v2 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null

2014-05-23 Thread Michael Tokarev
23.05.2014 22:16, Michael Tokarev пишет: > 23.05.2014 22:09, Michael Tokarev wrote: >> 23.05.2014 15:24, Markus Armbruster wrote: >>> It's not locally obvious, and Coverity can't see it either. >>> >>> Signed-off-by: Markus Armbruster >>> Reviewed-by: Alon Levy >>> --- >>> libcacard/vcard_emul_n

Re: [Qemu-devel] [PATCH v2 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null

2014-05-23 Thread Michael Tokarev
23.05.2014 22:09, Michael Tokarev wrote: > 23.05.2014 15:24, Markus Armbruster wrote: >> It's not locally obvious, and Coverity can't see it either. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Alon Levy >> --- >> libcacard/vcard_emul_nss.c | 1 + >> 1 file changed, 1 insertion(+) >> >

Re: [Qemu-devel] [PATCH v2 6/8] cpu: make CPU_INTERRUPT_RESET available on all targets

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 19:59, Peter Maydell ha scritto: On 2 May 2014 15:33, Paolo Bonzini wrote: On the x86, some devices need access to the CPU reset pin (INIT#). Provide a generic service to do this, using one of the internal cpu_interrupt targets. Generalize the PPC-specific code for CPU_INTERRUPT_

Re: [Qemu-devel] [PATCH v2 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null

2014-05-23 Thread Michael Tokarev
23.05.2014 15:24, Markus Armbruster пишет: > It's not locally obvious, and Coverity can't see it either. > > Signed-off-by: Markus Armbruster > Reviewed-by: Alon Levy > --- > libcacard/vcard_emul_nss.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libcacard/vcard_emul_nss.c b/libcac

[Qemu-devel] [PULL] tci: Fix tcg_out_call

2014-05-23 Thread Richard Henderson
Broken since dddbb2e1e3f8137d7e3f1faf9758c66cca0c94ea. Do all the rest of the things that tcg_out_op did before and after the big switch statement. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-

[Qemu-devel] [PULL] tci point fix

2014-05-23 Thread Richard Henderson
My fault; sorry about the breakage. r~ The following changes since commit 5118dc5975e6aa2e823961e15b162919f94721cc: Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-5' into staging (2014-05-22 17:05:36 +0100) are available in the git repository at: git://github.com/rth7680/

Re: [Qemu-devel] [PATCH v2 6/8] cpu: make CPU_INTERRUPT_RESET available on all targets

2014-05-23 Thread Peter Maydell
On 2 May 2014 15:33, Paolo Bonzini wrote: > On the x86, some devices need access to the CPU reset pin (INIT#). > Provide a generic service to do this, using one of the internal > cpu_interrupt targets. Generalize the PPC-specific code for > CPU_INTERRUPT_RESET to other targets. > > Since PPC does

Re: [Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 18:21, Peter Maydell ha scritto: On 23 May 2014 15:33, Paolo Bonzini wrote: Il 23/05/2014 13:50, Peter Maydell ha scritto: On 23 May 2014 12:23, Andreas Färber wrote: Am 23.05.2014 13:13, schrieb Peter Maydell: Ping? I believe I remarked that in the example typedef struct Fo

Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-05-23 Thread Fabio Fantoni
Il 23/05/2014 18:07, Stefano Stabellini ha scritto: Choose pc-i440fx-1.6 instead of pc for HVM guests, so that we know for sure what is the machine that we are emulating. Use pc-i440fx-1.6 regardless of the xen_platform_pci option. Add the xen-platform device if requested. Choose slot 2 for the

[Qemu-devel] [PULL 08/33] block: Replace in_use with operation blocker

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). The specific types are used, e.g

Re: [Qemu-devel] [libvirt] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for

2014-05-23 Thread Marcelo Tosatti
On Fri, May 23, 2014 at 08:54:54AM -0600, Eric Blake wrote: > On 05/23/2014 04:19 AM, Laine Stump wrote: > > On 05/23/2014 12:17 PM, Laine Stump wrote: > >> *However*, this discussion forced me to investigate some of the basic > >> assumptions that I'd been making when coming in to fix this bug. In

[Qemu-devel] [PULL 15/33] blockdev: Don't use qerror_report_err() in drive_init()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster qerror_report_err() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. drive_init() is not meant to be used by QMP commands. It uses both qerror_report_err() and error_report(). Convert the former to the l

[Qemu-devel] [PULL 14/33] docs: Define refcount_bits value

2014-05-23 Thread Stefan Hajnoczi
From: Maria Kustova The 'refcount_bits' term used in the description of refcount block entry is not defined in the specification. The definition is added in the 'refcount_order' section where refcount_bits was used as 'width in bits'. Signed-off-by: Maria Kustova Reviewed-by: Eric Blake Signed

Re: [Qemu-devel] qemu 2.0, deadlock in block-commit

2014-05-23 Thread Marcin Gibuła
If you see a pending request on a RADOS block device (rbd) then it would be good to dig deeper into QEMU's block/rbd.c driver to see why it's not completing that request. Are you using qcow2 on top of rbd? Hi, I've already recreated this without rbd and with stock qemu 2.0. -- mg

Re: [Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-23 Thread Peter Maydell
On 23 May 2014 15:33, Paolo Bonzini wrote: > Il 23/05/2014 13:50, Peter Maydell ha scritto: >> On 23 May 2014 12:23, Andreas Färber wrote: >>> Am 23.05.2014 13:13, schrieb Peter Maydell: Ping? >>> >>> I believe I remarked that in the example >>> typedef struct Foo { >>> would be more in line

[Qemu-devel] [PULL 17/33] qemu-nbd: Don't use qerror_report()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Replace by error_report(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- qemu-nbd.c | 6 ++

Re: [Qemu-devel] [PATCH v6 5/7] vfio: Introduce VFIO address spaces

2014-05-23 Thread Alexey Kardashevskiy
On 05/23/2014 10:05 PM, Alexander Graf wrote: > > On 23.05.14 14:03, Alexey Kardashevskiy wrote: >> On 05/23/2014 09:28 PM, Alexander Graf wrote: >>> On 23.05.14 06:59, Alexey Kardashevskiy wrote: From: David Gibson The only model so far supported for VFIO passthrough devices is th

[Qemu-devel] [PATCH] block/raw-posix.c: Avoid nonstandard LONG_LONG_MAX

2014-05-23 Thread Peter Maydell
In the MacOSX specific code in raw-posix.c we use the define LONG_LONG_MAX. This is actually a non-standard pre-C99 define; switch to using the standard LLONG_MAX instead. This apparently fixes a compilation failure with certain compiler/OS versions (though it is unclear which). Reported-by: Pete

[Qemu-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-05-23 Thread Stefano Stabellini
Choose pc-i440fx-1.6 instead of pc for HVM guests, so that we know for sure what is the machine that we are emulating. Use pc-i440fx-1.6 regardless of the xen_platform_pci option. Add the xen-platform device if requested. Choose slot 2 for the xen-platform device for compatibility with current ins

[Qemu-devel] [PATCH v2] configure: Put tempfiles in a subdir of the build directory

2014-05-23 Thread Peter Maydell
When libtool support was added to configure, the new temporary files were left out of the list of files cleaned up on exit; this results in a lot of stale .lo files being left around in /tmp. Worse, libtool creates a /tmp/.libs directory which we can't easily clean up. Put all our temporary files

[Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open

2014-05-23 Thread Roger Pau Monne
The current behaviour of tap_open for BSD systems differ greatly from it's Linux counterpart. Since FreeBSD supports interface renaming and tap device cloning by opening /dev/tap, implement a FreeBSD specific version of tap_open that behaves like it's Linux counterpart. This is specially important

[Qemu-devel] [PATCH v2 0/3] qemu-freebsd: fixes for running Xen guests

2014-05-23 Thread Roger Pau Monne
This three patches allow FreeBSD Xen Dom0 to use Qemu (i.e., launch HVM guests). First patch fixes the usage of ENODATA, which doesn't exist on FreeBSD and is replaced with ENOENT instead. The second patch is more controversial probably, since it introduces a FreeBSD specific version of tap_open

[Qemu-devel] [PATCH v2 1/3] xen: fix usage of ENODATA

2014-05-23 Thread Roger Pau Monne
ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the hypervisor are translated to ENOENT. Also, the error code is returned in errno if the call returns -1, so compare the error code with the value in errno instead of the value returned by the function. Signed-off-by: Roger Pau Monn

[Qemu-devel] [PATCH v2 3/3] serial: poll the serial console with G_IO_HUP

2014-05-23 Thread Roger Pau Monne
On FreeBSD polling a master pty while the other end is not connected with G_IO_OUT only results in an endless wait. This is different from the Linux behaviour, that returns immediately. In order to demonstrate this, I have the following example code: http://xenbits.xen.org/people/royger/test_poll.

[Qemu-devel] [PULL 22/33] block/ssh: Propagate errors through connect_to_ssh()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 18186ba..26078c4 100

[Qemu-devel] [PULL 32/33] block/sheepdog: Fix silent sd_open(), sd_create() failures

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Open and create methods must set an error when they fail. Cc: MORITA Kazutaka Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block/sheepdog.c b/bloc

[Qemu-devel] [PULL 28/33] block/sheepdog: Propagate errors through sd_prealloc()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Cc: MORITA Kazutaka Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index b932d68

[Qemu-devel] [PULL 29/33] block/sheepdog: Propagate errors through do_sd_create()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Cc: MORITA Kazutaka Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog

[Qemu-devel] [PULL 16/33] blockdev: Don't use qerror_report() in do_drive_del()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. do_drive_del() is an HMP command that won't be converted to QMP (we'll create a new QMP command instead). It uses both qerror_report() and

[Qemu-devel] [PULL 21/33] block/ssh: Propagate errors through authenticate()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 1df1946..18186ba 100644 --- a/bl

[Qemu-devel] [PULL 26/33] block/sheepdog: Propagate errors through connect_to_sdog()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Cc: MORITA Kazutaka Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 77 1 file changed, 55 insertions(+), 22 deletions(-) diff --git a/block/sheepd

[Qemu-devel] [PULL 27/33] block/sheepdog: Propagate errors through get_sheep_fd()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Cc: MORITA Kazutaka Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index ff0aa89..

[Qemu-devel] [PULL 30/33] block/sheepdog: Propagate errors through find_vdi_name()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Cc: MORITA Kazutaka Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index d01cc88

[Qemu-devel] [PULL 23/33] block/ssh: Propagate errors to open and create methods

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Completes the conversion to Error started in commit 015a103^..d5124c0. Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 47 ++- 1 file changed, 22 insertions(+

[Qemu-devel] [PULL 12/33] block: Add backing_blocker in BlockDriverState

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState->backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at least the backing blocker of its child, so th

[Qemu-devel] [PULL 25/33] block/vvfat: Propagate errors through init_directories()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Completes the conversion of the open method to Error started in commit 015a103. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/vvfat.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 26/31] pc: migrate piix4 & ich9 MemHotplugState

2014-05-23 Thread Igor Mammedov
On Fri, 23 May 2014 19:11:49 +0400 Andrey Korolyov wrote: > On Wed, May 21, 2014 at 3:29 PM, Igor Mammedov wrote: > > Adds an optional subsection that allows to migrate current > > state of acpi_memory_hotplug of ACPI PM device. > > > > Signed-off-by: Igor Mammedov > > --- > > v2: > > * use s

[Qemu-devel] [PULL 24/33] block/vvfat: Propagate errors through enable_write_target()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Continues the conversion of the open method to Error started in commit 015a103. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/vvfat.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --

[Qemu-devel] [PULL 19/33] block/ssh: Drop superfluous libssh2_session_last_errno() calls

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster libssh2_session_last_error() already returns the error code. Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/block/ssh.c b/bloc

[Qemu-devel] [PULL 20/33] block/ssh: Propagate errors through check_host_key()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 68 - 1 file changed, 49 insertions(+), 19 deletions(-) diff --git a/block/ssh.c b/block/ssh.c

[Qemu-devel] [PULL 33/33] block/sheepdog: Don't use qerror_report()

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Replace by error_report(). Cc: MORITA Kazutaka Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi -

[Qemu-devel] [PULL 11/33] block: Use bdrv_set_backing_hd everywhere

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng We need to handle the coming backing_blocker properly, so don't open code the assignment, instead, call bdrv_set_backing_hd to change backing_hd. Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block.c| 6 ++ block/stream.c | 4 +

[Qemu-devel] [PULL 31/33] block/sheepdog: Propagate errors to open and create methods

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Completes the conversion to Error started in commit 015a103^..d5124c0, except for a few bugs fixed in the next commit. Cc: MORITA Kazutaka Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 40 --

[Qemu-devel] [PULL 10/33] block: Add bdrv_set_backing_hd()

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng This is the common but non-trivial steps to assign or change the backing_hd of BDS. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block.c | 36 +++- include/block/

[Qemu-devel] [PULL 13/33] block: Drop redundant bdrv_refresh_limits

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng The above bdrv_set_backing_hd already does this. Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block.c b/block.c index aa9b5ab..a517d72 100644 --- a/block.c +++ b/block.c @@ -11

[Qemu-devel] [PULL 05/33] iotests: Use _img_info in test 089

2014-05-23 Thread Stefan Hajnoczi
From: Max Reitz Currently, test 089 uses $QEMU_IMG info manually in order to obtain the according output. However, the iotests should generally use _img_info as this filters out more irrelevant information such as the host image size or format specific information. Therefore, test 089 should use

[Qemu-devel] [PULL 09/33] block: Move op_blocker check from block_job_create to its caller

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng It makes no sense to check for "any" blocker on bs, we are here only because of the mechanical conversion from in_use to op_blockers. Remove it now, and let the callers check specific operation types. Backup and mirror already have it, add checker to stream and commit. Signed-off

[Qemu-devel] [PULL 18/33] block/rbd: Propagate errors to open and create methods

2014-05-23 Thread Stefan Hajnoczi
From: Markus Armbruster Completes the conversion to Error started in commit 015a103^..d5124c0. Cc: Josh Durgin Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/rbd.c | 71 + 1 file c

[Qemu-devel] [PULL 02/33] QemuOpt: add unit tests

2014-05-23 Thread Stefan Hajnoczi
From: Leandro Dorileo Cover basic aspects and API usage for QemuOpt. The current implementation covers the API's planned to be changed by Chunyan Liu in his QEMUOptionParameter replacement/cleanup job. Other APIs should be covered in future improvements. Signed-off-by: Leandro Dorileo Signed-o

[Qemu-devel] [PULL 07/33] block: Introduce op_blockers to BlockDriverState

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS as currently blocked for a certain type of operation with reason errors stored in the list. The rule of usage

[Qemu-devel] [PULL 04/33] aio: Fix use-after-free in cancellation path

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng The current flow of canceling a thread from THREAD_ACTIVE state is: 1) Caller wants to cancel a request, so it calls thread_pool_cancel. 2) thread_pool_cancel waits on the conditional variable elem->check_cancel. 3) The worker thread changes state to THREAD_DONE once

[Qemu-devel] [PULL 01/33] qemu-iotests: Handle cache mode option in 091

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng We should allow testing this on tmpfs. Any cache setting in iotests should try to obey $CACHEMODE. The cache mode is still "none" by default but overridable Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/091 | 6 -- 1 file changed, 4 insert

[Qemu-devel] [PULL 03/33] qcow2: Fix memory leak in COW error path

2014-05-23 Thread Stefan Hajnoczi
From: Kevin Wolf This triggers if bs->drv becomes NULL in a concurrent request. This is currently only the case when corruption prevention kicks in (i.e. at most once per image, and after that it produces I/O errors). Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/qcow2-cl

[Qemu-devel] [PULL 06/33] block: Add BlockOpType enum

2014-05-23 Thread Stefan Hajnoczi
From: Fam Zheng This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng Reviewed-by: Benoit Canet Reviewed-by: Jeff Cody Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- include/block/block.h | 19 +++ 1 file cha

[Qemu-devel] [PULL 00/33] Block patches

2014-05-23 Thread Stefan Hajnoczi
The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-22 19:04:49 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to

Re: [Qemu-devel] [PATCH v4 00/21] target-arm: Preparations for A64 EL2 and 3

2014-05-23 Thread Peter Maydell
On 23 May 2014 13:54, Peter Maydell wrote: > On 23 May 2014 01:41, Edgar E. Iglesias wrote: >> From: "Edgar E. Iglesias" >> >> Hi, >> >> I've been doing some work on modeling parts of EL2 and 3 + some of >> the system-wide virtualization features for ARMv8. A lot is missing >> but I've got a ser

Re: [Qemu-devel] [PATCH v2 00/19] block: Purge qerror_report()

2014-05-23 Thread Stefan Hajnoczi
On Fri, May 16, 2014 at 11:00:07AM +0200, Markus Armbruster wrote: > qerror_report() is a transitional interface to help with converting > existing HMP commands to QMP. It should not be used elsewhere. This > series purges it from the block subsystem. > > It is based on Fam's "[PATCH v19 00/16]

[Qemu-devel] [PATCH 5/5] target-arm: Use a 1:1 mapping between EL and MMU index

2014-05-23 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Message-id: 1400805738-11889-7-git-send-email-edgar.igles...@gmail.com --- target-arm/cpu.h | 8 target-arm/translate.h | 6 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/target-arm/cpu.h b/target-

[Qemu-devel] [PATCH 0/5] mmu index cleanup/fixes

2014-05-23 Thread Peter Maydell
Hi; these patches are intended to replace patches 4, 5 and 6 in Edgar's v4 "target-arm: Preparations for A64 EL2 and 3" series. They fix some bugs I noticed when I was testing that series: * missing changes for SRS * changes not bisectable due to earlier patch making assumptions about mmu inde

[Qemu-devel] [PATCH 3/5] target-arm/translate.c: Use get_mem_index() for SRS memory accesses

2014-05-23 Thread Peter Maydell
The SRS instruction was using a hardcoded 0 for the memory accesses. This happens to be OK since the SRS instruction is UNPREDICTABLE in User and System modes, but is awkward if we want to rearrange the MMU index uses. Switch to using get_mem_index() like all the other accesses. Signed-off-by: Pet

[Qemu-devel] [PATCH 2/5] target-arm/translate.c: Clean up mmu index handling for ldrt/strt

2014-05-23 Thread Peter Maydell
Clean up the mmu index handling for ldrt/strt insns: instead of a flag 'user' indicating whether to treat the store as user mode or not, use 'memidx' to indicate the correct memory index to use. Signed-off-by: Peter Maydell --- target-arm/translate.c | 29 + 1 file ch

  1   2   3   >