Re: [Qemu-devel] qemu does not support PAPR

2014-06-05 Thread sonia verma
Hi Paolo I'm running this on ubuntu with powerpc arch with kernel 3.8.13-rt9-QorIQ-SDK-V1.4. Thanks On Thu, Jun 5, 2014 at 11:21 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 05/06/2014 06:50, sonia verma ha scritto: Hi I'm trying to run libguestfs-test-tool which in turn is using

Re: [Qemu-devel] [PATCH v7 1/4] spapr_iommu: Make in-kernel TCE table optional

2014-06-05 Thread Alexey Kardashevskiy
On 06/05/2014 03:49 PM, Alexey Kardashevskiy wrote: POWER KVM supports an KVM_CAP_SPAPR_TCE capability which allows allocating TCE tables in the host kernel memory and handle H_PUT_TCE requests targeted to specific LIOBN (logical bus number) right in the host without switching to QEMU. At the

Re: [Qemu-devel] [PATCH 2/2] virtio-blk-test.c: add hotplug subtest

2014-06-05 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Thu, Jun 05, 2014 at 01:12:46PM +0800, Amos Kong wrote: On Wed, Jun 04, 2014 at 05:35:06PM +0200, Stefan Hajnoczi wrote: On Tue, May 27, 2014 at 03:14:41PM +0800, Amos Kong wrote: This patch adds a new subtest, it hotplugs 29 * 8 = 232 virtio-blk

[Qemu-devel] [PATCH v8 3/4] VFIO: Introduce helper vfio_pci_container_ioctl()

2014-06-05 Thread Gavin Shan
The patch introduces helper function vfio_pci_container_ioctl() to pass ioctl commands to the specified VFIO container that is identified by IOMMU group id. On sPAPR platform, each container only has one IOMMU group. Signed-off-by: Gavin Shan gws...@linux.vnet.ibm.com --- hw/misc/vfio.c

[Qemu-devel] [PATCH v8 4/4] sPAPR: Implement sPAPRPHBClass::eeh_handler

2014-06-05 Thread Gavin Shan
The patch implements sPAPRPHBClass::eeh_handler so that the EEH RTAS requests can be routed to VFIO for further handling. Signed-off-by: Gavin Shan gws...@linux.vnet.ibm.com --- hw/ppc/spapr_pci_vfio.c | 54 + 1 file changed, 54 insertions(+) diff

[Qemu-devel] [PATCH v8 2/4] headers: Update kernel header

2014-06-05 Thread Gavin Shan
This updates kernel header (vfio.h) for EEH support on VFIO PCI devices. Signed-off-by: Gavin Shan gws...@linux.vnet.ibm.com --- linux-headers/linux/vfio.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/linux-headers/linux/vfio.h

[Qemu-devel] [PATCH v8 0/4] EEH Support for VFIO PCI Device

2014-06-05 Thread Gavin Shan
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support. Also, it is based on top of Alexey's VFIO-for-sPAPR git repository. QEMU: git://github.com/aik/qemu.git (branch: vfio) Kernel: git://github.com/aik/linux.git (branch:

[Qemu-devel] [PATCH v8 1/4] sPAPR: Implement EEH RTAS calls

2014-06-05 Thread Gavin Shan
The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callback sPAPRPHBClass::eeh_handler, which is going to be used this way: 1. RTAS calls are received in spapr_pci.c, sanity check is

Re: [Qemu-devel] active block commit bug?

2014-06-05 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix that bug (not that your normal guest will ever have a 0-length backing file, but this was what I was

Re: [Qemu-devel] [PATCH v2 2/4] qtest: introduce qmp_exec_hmp_cmd()

2014-06-05 Thread Gonglei (Arei)
-Original Message- From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On Behalf Of Amos Kong Sent: Thursday, June 05, 2014 1:45 PM To: qemu-devel@nongnu.org Cc: stefa...@gmail.com; afaer...@suse.de;

Re: [Qemu-devel] qemu does not support PAPR

2014-06-05 Thread Paolo Bonzini
Il 05/06/2014 08:09, sonia verma ha scritto: Hi Paolo I'm running this on ubuntu with powerpc arch with kernel 3.8.13-rt9-QorIQ-SDK-V1.4. I'll note that this is a fairly old kernel for PowerPC KVM. However, the problem looks like libguestfs supporting only server PowerPC (also known as

Re: [Qemu-devel] qemu does not support PAPR

2014-06-05 Thread sonia verma
So what can be the solution for this? On Thu, Jun 5, 2014 at 1:13 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 05/06/2014 08:09, sonia verma ha scritto: Hi Paolo I'm running this on ubuntu with powerpc arch with kernel 3.8.13-rt9-QorIQ-SDK-V1.4. I'll note that this is a fairly old

Re: [Qemu-devel] [PATCHv3 RESEND] block: introduce BDRV_O_SEQUENTIAL

2014-06-05 Thread Stefan Hajnoczi
On Wed, Jun 04, 2014 at 05:31:48PM +0200, Peter Lieven wrote: Am 04.06.2014 17:12, schrieb Stefan Hajnoczi: On Fri, May 30, 2014 at 11:40:37PM +0200, Peter Lieven wrote: this patch introduces a new flag to indicate that we are going to sequentially read from a file and do not plan to

Re: [Qemu-devel] [Qemu-ppc] qemu does not support PAPR

2014-06-05 Thread Alexander Graf
Am 05.06.2014 um 09:45 schrieb sonia verma soniaverma9...@gmail.com: So what can be the solution for this? Please don't top post. You're running on QorIQ which is a Freescale chip. The pseries target only works on IBM PPC chips. The target you're looking for is ppce500: $

Re: [Qemu-devel] 答复: Expansion Ratio Issue

2014-06-05 Thread Alex Bennée
Chaos Shu writes: Hi I'm running SPEC CPU2006 on three kinds of situation, native aarch64 binary and emulator x86_64 system running SPEC CPU2006 and linux user mode level running x86_64 SPEC CPU2006 binary. To find where the performance lose, translator ? or execution of instruction

Re: [Qemu-devel] [PATCHv3 RESEND] block: introduce BDRV_O_SEQUENTIAL

2014-06-05 Thread Peter Lieven
On 05.06.2014 09:53, Stefan Hajnoczi wrote: On Wed, Jun 04, 2014 at 05:31:48PM +0200, Peter Lieven wrote: Am 04.06.2014 17:12, schrieb Stefan Hajnoczi: On Fri, May 30, 2014 at 11:40:37PM +0200, Peter Lieven wrote: this patch introduces a new flag to indicate that we are going to sequentially

Re: [Qemu-devel] [PATCHv3 RESEND] block: introduce BDRV_O_SEQUENTIAL

2014-06-05 Thread Kevin Wolf
Am 05.06.2014 um 10:09 hat Peter Lieven geschrieben: On 05.06.2014 09:53, Stefan Hajnoczi wrote: On Wed, Jun 04, 2014 at 05:31:48PM +0200, Peter Lieven wrote: Am 04.06.2014 17:12, schrieb Stefan Hajnoczi: On Fri, May 30, 2014 at 11:40:37PM +0200, Peter Lieven wrote: this patch introduces a

Re: [Qemu-devel] [RFC 3/5] nbd: Use aio_set_fd_handler2()

2014-06-05 Thread Stefan Hajnoczi
On Wed, Jun 04, 2014 at 08:02:06PM +0200, Paolo Bonzini wrote: Il 04/06/2014 14:37, Stefan Hajnoczi ha scritto: Why is this design cleaner? Because NBD code doesn't have to worry about fd handlers. It uses straightforward coroutine send/recv for socket I/O inside nbd_read_req() and

Re: [Qemu-devel] active block commit bug?

2014-06-05 Thread Kevin Wolf
Am 05.06.2014 um 09:06 hat Markus Armbruster geschrieben: Eric Blake ebl...@redhat.com writes: On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix that bug (not that your normal guest

[Qemu-devel] [PATCH v4 0/5] This series adds iotest case for IO throttling.

2014-06-05 Thread Fam Zheng
There is a change in qemu-io sub-commands aio_read and aio_write, which makes the aio requests accounted and the statistics reflected in blockstats. Note that IO throttling implementation allows overcommiting of requests, so the actual IO happened in a time unit may be a bit larger than given

[Qemu-devel] [PATCH v4 1/5] qemu-io: Account IO by aio_read and aio_write

2014-06-05 Thread Fam Zheng
This will enable accounting of aio requests issued from qemu-io aio read/write commands. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- qemu-io-cmds.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index

[Qemu-devel] [PATCH v4 2/5] qtest: Add scripts/qtest/qtest.py

2014-06-05 Thread Fam Zheng
This removes the dummy scripts/qtest and adds scripts/qtest/qtest.py as a python library for qtest protocol. This is a skeleton with a basic cmd method to execute a command, reading and parsing of qtest output will be added later on demand. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by:

[Qemu-devel] [PATCH v4 3/5] qemu-iotests: Add VM method qtest() to iotests.py

2014-06-05 Thread Fam Zheng
This will allow test case to run command in qtest protocol. It's write-only for now. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- tests/qemu-iotests/iotests.py | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [RFC] image-fuzzer: Trivial test runner

2014-06-05 Thread M.Kustova
On Wed, Jun 4, 2014 at 6:26 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sat, May 31, 2014 at 01:56:46PM +0400, Maria Kustova wrote: Please add a --format qcow2 (or maybe --image-generator) option using __import__() to load the image generator module. That way people can drop in new

[Qemu-devel] [PATCH v4 5/5] qemu-iotests: Add 093 for IO throttling

2014-06-05 Thread Fam Zheng
This case utilizes qemu-io command aio_{read,write} -a -q to verify the effectiveness of IO throttling options. The -a option will cause qemu-io requests to be accounted. It's implemented by driving the vm timer from qtest protocol, so the throttling timers are signaled with determinied time

[Qemu-devel] [PATCH v4 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp

2014-06-05 Thread Fam Zheng
QMP command block_set_io_throttle expects underscores in parameters instead of dashes: {iops,bps}_{rd,wr,max}. Add optional argument conv_keys (defaults to True, backward compatible), it will be used in IO throttling test case. Reviewed-by: Benoit Canet ben...@irqsave.net Signed-off-by: Fam

Re: [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when necessary

2014-06-05 Thread Michael Tokarev
04.06.2014 18:00, ronnie sahlberg wrote: That would mean you get to use the 10 version of the cdb even for very large devices (as long as the IO is for blocks at the beginning of the device) and thus provide partial avoidance of this issue for those large devices. That may make some bugs

Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code

2014-06-05 Thread Fam Zheng
On Thu, 06/05 06:09, Paolo Bonzini wrote: Il 05/06/2014 05:50, Fam Zheng ha scritto: Can you try moving the req allocation and assignments inside process_request instead? Then you can fill in req-out directly without the struct assignment. The owners of req are do_rdwr_cmd and

[Qemu-devel] [PATCH v28 06/33] QemuOpts: move qemu_opt_del ahead for later calling

2014-06-05 Thread Chunyan Liu
In later patch, qemu_opt_get_del functions will be added, they will first get the option value, then call qemu_opt_del to remove the option from opt list. To prepare for that purpose, move qemu_opt_del ahead first. Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Leandro Dorileo

[Qemu-devel] [PATCH v28 05/33] QemuOpts: change opt-name|str from (const char *) to (char *)

2014-06-05 Thread Chunyan Liu
qemu_opt_del() already assumes that all QemuOpt instances contain malloc'd name and value; but it had to cast away const because opts_start_struct() was doing its own thing and using static storage instead. By using the correct type and malloced strings everywhere, the usage of this struct

[Qemu-devel] [PATCH v28 03/33] QemuOpts: add def_value_str to QemuOptDesc

2014-06-05 Thread Chunyan Liu
Add def_value_str (default value) to QemuOptDesc, to replace function of the default value in QEMUOptionParameter. Improve qemu_opts_get_* functions: if find opt, return opt-str; otherwise, if desc-def_value_str is set, return desc-def_value_str; otherwise, return input defval. Improve

Re: [Qemu-devel] active block commit bug?

2014-06-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 05.06.2014 um 09:06 hat Markus Armbruster geschrieben: Eric Blake ebl...@redhat.com writes: On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix

[Qemu-devel] [PATCH v28 16/33] iscsi.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/iscsi.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/block/iscsi.c

[Qemu-devel] [PATCH v28 04/33] qapi: output def_value_str when query command line options

2014-06-05 Thread Chunyan Liu
Change qapi interfaces to output the newly added def_value_str when querying command line options. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Leandro Dorileo l...@dorileo.org Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com

[Qemu-devel] [PATCH v28 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work

2014-06-05 Thread Chunyan Liu
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter (get and delete). Several drivers are coded to parse a known subset of options, then remove them from the list before handing all remaining options to

[Qemu-devel] [PATCH v28 01/33] QemuOpts: move find_desc_by_name ahead for later calling

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Chunyan Liu cy...@suse.com --- util/qemu-option.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/util/qemu-option.c b/util/qemu-option.c

[Qemu-devel] [PATCH v28 18/33] qcow.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/qcow.c | 72 ++-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git

[Qemu-devel] [PATCH v28 09/33] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts

2014-06-05 Thread Chunyan Liu
Add two temp conversion functions between QEMUOptionParameter to QemuOpts, so that next patch can use it. It will simplify later patch for easier review. And will be finally removed after all backend drivers switch to QemuOpts. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric

[Qemu-devel] [PATCH v28 10/33] QemuOpts: add qemu_opts_append to replace append_option_parameters

2014-06-05 Thread Chunyan Liu
For later merge .create_opts of drv and proto_drv in qemu-img commands. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Leandro Dorileo l...@dorileo.org Signed-off-by: Chunyan Liu cy...@suse.com --- include/qemu/option.h | 5

[Qemu-devel] [PATCH v28 11/33] QemuOpts: check NULL input for qemu_opts_del

2014-06-05 Thread Chunyan Liu
To simplify later using of qemu_opts_del, accept NULL input. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Leandro Dorileo l...@dorileo.org Signed-off-by: Chunyan Liu cy...@suse.com --- util/qemu-option.c | 4 1 file changed, 4

[Qemu-devel] [PATCH v28 17/33] nfs.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/nfs.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 539bd95..20a90e2 100644 ---

[Qemu-devel] [PATCH v28 15/33] gluster.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/gluster.c | 81 ++--- 1 file changed, 42

[Qemu-devel] [PATCH v28 26/33] sheepdog.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/sheepdog.c | 111 --- 1 file changed, 56 insertions(+), 55 deletions(-) diff --git

[Qemu-devel] [PATCH v28 20/33] qcow2.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- Changes: * same as v27 * changes to v26: split v26 qcow2.c patch into two, move qemu_opt_find to a separate patch. block/qcow2.c | 261

[Qemu-devel] [PATCH v28 12/33] change block layer to support both QemuOpts and QEMUOptionParamter

2014-06-05 Thread Chunyan Liu
Change block layer to support both QemuOpts and QEMUOptionParameter. After this patch, it will change backend drivers one by one. At the end, QEMUOptionParameter will be removed and only QemuOpts is kept. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu

[Qemu-devel] [PATCH v28 13/33] vvfat.c: handle cross_driver's create_options and create_opts

2014-06-05 Thread Chunyan Liu
vvfat shares create options of qcow driver. To avoid vvfat breaking when qcow driver changes from QEMUOptionParameter to QemuOpts, let it able to handle both cases. Signed-off-by: Chunyan Liu cy...@suse.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/vvfat.c | 24 +---

[Qemu-devel] [PATCH v28 28/33] vdi.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/vdi.c | 73 + 1 file changed, 35 insertions(+), 38 deletions(-) diff --git

[Qemu-devel] [PATCH v28 21/33] qed.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead of 64 * 1024; because: according to existing create_options, cluster size has default value = QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be stringized and set to .def_value_str. That is,

[Qemu-devel] [PATCH v28 25/33] rbd.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/rbd.c | 63 + 1 file changed, 30 insertions(+), 33 deletions(-) diff --git

[Qemu-devel] [PATCH v28 14/33] cow.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/cow.c | 54 ++ 1 file changed, 26

[Qemu-devel] [PATCH v28 29/33] vhdx.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/vhdx.c | 99 +--- block/vhdx.h | 1 + 2 files changed, 48 insertions(+), 52

[Qemu-devel] [PATCH v28 19/33] QemuOpts: export qemu_opt_find

2014-06-05 Thread Chunyan Liu
Export qemu_opt_find for qcow2 driver using it. After replacing QEMUOptionParameter with QemuOpts, qcow2 driver will use qemu_opt_find to judge if an option is explicitly set, to replace the usage of .assigned in QEMUOptionParameter. Signed-off-by: Chunyan Liu cy...@suse.com --- Changes: * same

[Qemu-devel] [PATCH v28 27/33] ssh.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/ssh.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index

[Qemu-devel] [PATCH v28 31/33] vpc.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/vpc.c | 62 + 1 file changed, 34 insertions(+), 28 deletions(-) diff --git

[Qemu-devel] [PATCH v28 23/33] raw-win32.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/raw-win32.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/block/raw-win32.c

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

2014-06-05 Thread Peter Lieven
On 30.05.2014 11:05, Paolo Bonzini wrote: Il 30/05/2014 11:04, Peter Lieven ha scritto: Am 30.05.2014 07:50, schrieb Paolo Bonzini: Il 29/05/2014 22:25, Peter Lieven ha scritto: Am 29.05.2014 21:17, schrieb Paolo Bonzini: Il 29/05/2014 20:41, Peter Lieven ha scritto: static inline unsigned

[Qemu-devel] [PATCH v28 32/33] cleanup QEMUOptionParameter

2014-06-05 Thread Chunyan Liu
Now that all backend drivers are using QemuOpts, remove all QEMUOptionParameter related codes. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block.c | 93 ++ block/cow.c | 4 +- block/gluster.c

Re: [Qemu-devel] [PATCH v2 2/4] qtest: introduce qmp_exec_hmp_cmd()

2014-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 01:45:16PM +0800, Amos Kong wrote: Signed-off-by: Amos Kong ak...@redhat.com --- tests/libqtest.c | 16 tests/libqtest.h | 8 2 files changed, 24 insertions(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 71468ac..ceb1734

[Qemu-devel] [PATCH v28 30/33] vmdk.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/vmdk.c | 123 ++- 1 file changed, 63 insertions(+), 60 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 3/4] virtio-blk-test.c: add hotplug subtest

2014-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 01:45:17PM +0800, Amos Kong wrote: This patch adds a new subtest, it hotplugs 29 * 8 = 232 virtio-blk devices to guest, and try to hot-unplug them. Note: the hot-unplug can't work without cooperation of guest OS. Signed-off-by: Amos Kong ak...@redhat.com ---

Re: [Qemu-devel] [PATCH v2 4/4] qtest: use qmp_exec_hmp_cmd() in blockdev-test

2014-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 01:45:18PM +0800, Amos Kong wrote: Signed-off-by: Amos Kong ak...@redhat.com --- tests/blockdev-test.c | 23 ++- 1 file changed, 2 insertions(+), 21 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PATCH] linux-user: Tell guest about big host page sizes

2014-06-05 Thread Alexander Graf
We tell the guest its page size via AUX vectors. The guest process then uses this page size as information on which boundaries it can mmap() things. However, if the host has a bigger page size granularity than the guest, it can not fulfill these mmap() requests - which falls apart when MAP_FIXED

[Qemu-devel] [PATCH v28 02/33] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters

2014-06-05 Thread Chunyan Liu
Currently this function is not used anywhere. In later patches, it will replace print_option_parameters. To avoid print info changes, change qemu_opts_print from fprintf stderr to printf, and remove last printf. Signed-off-by: Chunyan Liu cy...@suse.com Reviewed-by: Eric Blake ebl...@redhat.com

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

2014-06-05 Thread Paolo Bonzini
Il 05/06/2014 11:29, Peter Lieven ha scritto: It might be that we need a LIBS+= -lm to the Makefile in the root directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd. cat $TMPC EOF #include math.h int main(void) { return isnan(sin(0.0)); } EOF if compile_prog ; then :

Re: [Qemu-devel] [PATCH v4 1/4] cpus: Define callback for QEMU nmi command

2014-06-05 Thread Peter Maydell
On 5 June 2014 00:36, Alexey Kardashevskiy a...@ozlabs.ru wrote: I'd rather remove return value at all, my mistake, I cannot see how NMI handler can possibly fail - noone can mask it after all :) If callback exists, I just call it and that's it. If it does not exist, it is unsupported and

Re: [Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing.

2014-06-05 Thread Hani Benhabiles
On Thu, Jun 05, 2014 at 03:55:40AM +0200, Paolo Bonzini wrote: Il 05/06/2014 00:33, Hani Benhabiles ha scritto: IIUC, what this does is ensure that the other side gets a FIN before it gets a RST. Is this correct? Yes. Without shutdown(), this could be reproduced (unreliably) on

[Qemu-devel] [PATCH v2] target-arm: Prepare cpreg writefns/readfns for EL3/SecExt

2014-06-05 Thread Fabian Aggeler
This patch changes some readfns/writefns to use raw_write and raw_read functions, which use the fieldoffset specified in ARMCPRegInfo instead of directly accessing the field. This will simplify patches for EL3 Security Extensions. Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com

Re: [Qemu-devel] [RFC 3/5] nbd: Use aio_set_fd_handler2()

2014-06-05 Thread Paolo Bonzini
Il 05/06/2014 10:12, Stefan Hajnoczi ha scritto: On Wed, Jun 04, 2014 at 08:02:06PM +0200, Paolo Bonzini wrote: Il 04/06/2014 14:37, Stefan Hajnoczi ha scritto: Why is this design cleaner? Because NBD code doesn't have to worry about fd handlers. It uses straightforward coroutine send/recv

Re: [Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface

2014-06-05 Thread Igor Mammedov
On Fri, 30 May 2014 09:44:20 -0600 Eric Blake ebl...@redhat.com wrote: On 05/30/2014 09:39 AM, Igor Mammedov wrote: +# @source_event: Arg0 - An Integer containing the source event +# +# @status_code: Arg1 – An Integer containing the status code +{ 'type': 'ACPIOSTInfo', + 'data'

[Qemu-devel] [PATCH v28 08/33] QemuOpts: add qemu_opts_print_help to replace print_option_help

2014-06-05 Thread Chunyan Liu
print_option_help takes QEMUOptionParameter as parameter, add qemu_opts_print_help to take QemuOptsList as parameter for later replace work. Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Leandro Dorileo l...@dorileo.org Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

2014-06-05 Thread Peter Lieven
On 05.06.2014 11:44, Paolo Bonzini wrote: Il 05/06/2014 11:29, Peter Lieven ha scritto: It might be that we need a LIBS+= -lm to the Makefile in the root directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd. cat $TMPC EOF #include math.h int main(void) { return

[Qemu-devel] [PATCH v28 00/33] replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
This patch series is to replace QEMUOptionParameter with QemuOpts, so that only one Qemu Option structure is kept in QEMU code. --- Changes to v27: * rebase to git master (code has been updated in this part since v27 sent so rebase to make the patch series work.) All patches are also

Re: [Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing.

2014-06-05 Thread Paolo Bonzini
Il 05/06/2014 11:58, Hani Benhabiles ha scritto: On Thu, Jun 05, 2014 at 03:55:40AM +0200, Paolo Bonzini wrote: Il 05/06/2014 00:33, Hani Benhabiles ha scritto: IIUC, what this does is ensure that the other side gets a FIN before it gets a RST. Is this correct? Yes. Without shutdown(), this

Re: [Qemu-devel] [PATCH] scsi-disk.c: Fix compilation with -DDEBUG_SCSI

2014-06-05 Thread Paolo Bonzini
Il 05/06/2014 07:33, Paul Janzen ha scritto: In scsi-disk.c, if you #define DEBUG_SCSI=1, you get: hw/scsi/scsi-disk.c: In function 'scsi_disk_emulate_command': hw/scsi/scsi-disk.c:2018: error: 'SCSIRequest' has no member named 'buf' Change the debugging statement to match the actual value

[Qemu-devel] [PATCH v28 22/33] raw-posix.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/raw-posix.c | 59 +-- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git

[Qemu-devel] [PATCH v2] target-arm: implement PD0/PD1 bits for TTBCR

2014-06-05 Thread Fabian Aggeler
Corrected handling of writes to TTBCR for ARMv8 (previously UNK/SBZP bits are not RES0) and ARMv7 (new bits PD0/PD1 for CPUs with Security Extensions). Bits PD0/PD1 are now respected in get_phys_addr_v6/v5() and get_level1_table_address. Signed-off-by: Fabian Aggeler aggel...@ethz.ch --- v1 -

[Qemu-devel] [PATCH v28 24/33] raw_bsd.c: replace QEMUOptionParameter with QemuOpts

2014-06-05 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/raw_bsd.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c

[Qemu-devel] [PATCH v28 33/33] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList

2014-06-05 Thread Chunyan Liu
Now only qemu_opts_append uses 'allocated' to indicate free memory. For this function only, we can also let result list's (const char *) members point to input list's members, only if the input list has longer lifetime than result list. In current code, that is true. So, we can remove the

Re: [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when necessary

2014-06-05 Thread Peter Lieven
On 05.06.2014 11:12, Michael Tokarev wrote: 04.06.2014 18:00, ronnie sahlberg wrote: That would mean you get to use the 10 version of the cdb even for very large devices (as long as the IO is for blocks at the beginning of the device) and thus provide partial avoidance of this issue for those

Re: [Qemu-devel] [patch 2/3] add object_property_add_alias

2014-06-05 Thread Paolo Bonzini
Il 04/06/2014 19:52, mtosa...@redhat.com ha scritto: Allowing addition of a link without keeping pointer-to-pointer. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- include/qom/object.h | 13 + qom/object.c | 73 +-- 2

Re: [Qemu-devel] [PATCH 1/3] mirror: Go through ready - complete process for 0 len image

2014-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 11:42:34AM +0800, Fam Zheng wrote: diff --git a/block/mirror.c b/block/mirror.c index 94c8661..2bef5f3 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -324,9 +324,18 @@ static void coroutine_fn mirror_run(void *opaque) } s-common.len =

Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image active commit

2014-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 11:42:35AM +0800, Fam Zheng wrote: @@ -48,8 +49,11 @@ class ImageCommitTestCase(iotests.QMPTestCase): self.assert_qmp(event, 'data/device', 'drive0') self.assert_qmp(event, 'data/offset', self.image_len)

[Qemu-devel] [RFC PATCH 0/2] qom: custom link properties

2014-06-05 Thread Paolo Bonzini
Both Marcelo's rtc patches and Peter's MemoryRegion patches showed the interest in having link properties with a custom representation and/or a different way to store the property. Such properties would still be links for the outside world, but the internal implementation in QEMU would be

[Qemu-devel] [PATCH 2/2] qom: add object_property_add_alias

2014-06-05 Thread Paolo Bonzini
Similar to object_property_add_link, alias properties provide an alternative, non-canonical path to an object. In fact, external observers cannot distinguish alias properties from other links. Aliases differ from links in that they are immutable and typically managed by the target of the alias

[Qemu-devel] [PATCH 1/2] qom: add a generic mechanism to resolve paths

2014-06-05 Thread Paolo Bonzini
It may be desirable to have custom link properties that do more than just store an object. Even the addition of a check function is not enough if setting the link has side effects or if a non-standard reference counting is preferrable. Avoid the assumption that the opaque field of a link is a

Re: [Qemu-devel] [PATCH 1/3] mirror: Go through ready - complete process for 0 len image

2014-06-05 Thread Paolo Bonzini
Il 05/06/2014 13:17, Stefan Hajnoczi ha scritto: On Thu, Jun 05, 2014 at 11:42:34AM +0800, Fam Zheng wrote: diff --git a/block/mirror.c b/block/mirror.c index 94c8661..2bef5f3 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -324,9 +324,18 @@ static void coroutine_fn mirror_run(void *opaque)

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test 0-length image for mirror

2014-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 11:42:36AM +0800, Fam Zheng wrote: +class TestSingleDriveZeroLength(TestSingleDrive): +def setUp(self): +TestSingleDrive.image_len = 0 +return TestSingleDrive.setUp(self) This is buggy since it assigns to TestSingleDrive.image_len. It modifies the

[Qemu-devel] [PATCH v2 0/5] Extract QAPI block commands

2014-06-05 Thread Benoît Canet
in v2: squash commits [Stefan] Get rid of dependency on quorum maintainance series [Stefan] Add proper GPL V2 license in headers [Eric] Benoît Canet (5): qapi: Extract qapi/common.json definitions qapi: create two block related json modules qapi: Extract

[Qemu-devel] [PATCH v2 5/5] qapi: Set QAPI descriptions files under the GPL V2 license

2014-06-05 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- qapi-schema.json | 4 qapi/block-core.json | 4 qapi/block.json | 4 qapi/common.json | 4 4 files changed, 16 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 14b498b..870d3f6 100644 ---

[Qemu-devel] [PATCH v2 1/5] qapi: Extract qapi/common.json definitions

2014-06-05 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- qapi-schema.json | 87 ++ qapi/common.json | 89 2 files changed, 91 insertions(+), 85 deletions(-) create mode 100644 qapi/common.json

[Qemu-devel] [PATCH v2 4/5] qapi: Extract qapi/block.json definitions

2014-06-05 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- qapi-schema.json | 159 --- qapi/block.json | 159 +++ 2 files changed, 159 insertions(+), 159 deletions(-) diff --git a/qapi-schema.json

[Qemu-devel] [PATCH v2 2/5] qapi: create two block related json modules

2014-06-05 Thread Benoît Canet
qapi/block-core.json contains block definitions unrelated to emulation. qapi/block.json is a superset of the previous and contains definitions related to emulation. The purpose of these extractions is to be able to hook qapi/block-core.json generated code on qemu-nbd. Signed-off-by: Benoit

Re: [Qemu-devel] [PATCH V2 4/4] hw/machine: qemu machine opts as properties to QemuMachineState

2014-06-05 Thread Marcel Apfelbaum
On Mon, 2014-06-02 at 12:21 -0300, Eduardo Habkost wrote: On Sun, Jun 01, 2014 at 11:21:49AM +0300, Marcel Apfelbaum wrote: On Fri, 2014-05-30 at 16:25 -0300, Eduardo Habkost wrote: On Mon, May 26, 2014 at 03:40:58PM +0300, Marcel Apfelbaum wrote: [...] +static void

Re: [Qemu-devel] [PATCH v4 10/10] block: add QAPI command to allow live backing file change

2014-06-05 Thread Benoît Canet
The Wednesday 04 Jun 2014 à 09:51:12 (-0400), Jeff Cody wrote : This allows a user to make a live change to the backing file recorded in an open image. The image file to modify can be specified 2 ways: 1) image filename 2) image node-name Note: this does not cause the backing file

Re: [Qemu-devel] [PATCH v8 1/4] sPAPR: Implement EEH RTAS calls

2014-06-05 Thread Alexander Graf
On 05.06.14 08:53, Gavin Shan wrote: The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callback sPAPRPHBClass::eeh_handler, which is going to be used this way: 1. RTAS calls are

Re: [Qemu-devel] [PATCH v8 3/4] VFIO: Introduce helper vfio_pci_container_ioctl()

2014-06-05 Thread Alexander Graf
On 05.06.14 08:53, Gavin Shan wrote: The patch introduces helper function vfio_pci_container_ioctl() to pass ioctl commands to the specified VFIO container that is identified by IOMMU group id. On sPAPR platform, each container only has one IOMMU group. Signed-off-by: Gavin Shan

Re: [Qemu-devel] [PATCH v8 0/4] EEH Support for VFIO PCI Device

2014-06-05 Thread Alexander Graf
On 05.06.14 08:53, Gavin Shan wrote: The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support. Also, it is based on top of Alexey's VFIO-for-sPAPR git repository. QEMU: git://github.com/aik/qemu.git (branch: vfio) Kernel:

[Qemu-devel] [PATCH 3/3] virtio-blk: Treat read/write beyond end as invalid

2014-06-05 Thread Markus Armbruster
The block layer fails such reads and writes just fine. However, they then get treated like valid operations that fail: the error action gets executed. Unwanted; reporting the error to the guest is the only sensible action. Reject them before passing them to the block layer. This bypasses the

[Qemu-devel] [PATCH 2/3] virtio-blk: Bypass error action and I/O accounting on invalid r/w

2014-06-05 Thread Markus Armbruster
When a device model's I/O operation fails, we execute the error action. This lets layers above QEMU implement thin provisioning, or attempt to correct errors before they reach the guest. But when the I/O operation fails because its invalid, reporting the error to the guest is the only sensible

[Qemu-devel] [PATCH 0/3] virtio-blk: Suppress error action on r/w beyond end

2014-06-05 Thread Markus Armbruster
When a device model's I/O operation fails, we execute the error action. This lets layers above QEMU implement thin provisioning, or attempt to correct errors before they reach the guest. But when the I/O operation fails because its invalid, reporting the error to the guest is the only sensible

  1   2   3   4   5   >