When I check it the latest master branch, the issue is already resolved.
It is resolved by commit 5942a19040fed313b316ab7b6e3d2d8e7b1625bb (28,
June).
I'm sorry and thank you for your help.
> On Thu, Jun 26, 2014 at 12:48:14PM +0900, SeokYeon Hwang wrote:
> > > On Wed, 2014-06-25 at 15:03 +0300, M
On 6/27/2014 10:02 PM, yue wrote:
hi ,all
i now know there are 2 ways to implement io throttling,
one is cgroup, but it is only targeted at block device.
another is qemu itself.
cgroups are done at the host (Linux only) kernel level. So anything that
doesn't go through the host block layer (
hi ,all
i now know there are 2 ways to implement io throttling,
one is cgroup, but it is only targeted at block device.
another is qemu itself.
i want to know the theory how qemu itself do io throttling? and in that case if
it depends on the type of back storage(nfs,file,rbd, other posix fs)?
it b
On Sat, Jun 28, 2014 at 10:29 AM, Stalley, Sean wrote:
> Hello All,
>
>
>
> I am working on building a hardware model for QEMU. This model needs a
> couple memory regions for MMIO.
>
> The thing is, I don’t particularly care what the physical address of the
> memory region is (so long as it doesn’
On 06/28/2014 10:00 AM, Alexey Kardashevskiy wrote:
> On 06/28/2014 02:14 AM, Alexander Graf wrote:
>>
>> On 27.06.14 17:54, Alexey Kardashevskiy wrote:
>>> At the moment POWER7+ and POWER7 CPUs are different incompatible
>>> families in QOM. The same is valid for POWER8E and POWER8 CPUs.
>>> Howev
Hello All,
I am working on building a hardware model for QEMU. This model needs a couple
memory regions for MMIO.
The thing is, I don't particularly care what the physical address of the memory
region is (so long as it doesn't overlap with any other memory region).
I was wondering if QEMU is ab
On 06/28/2014 02:14 AM, Alexander Graf wrote:
>
> On 27.06.14 17:54, Alexey Kardashevskiy wrote:
>> At the moment POWER7+ and POWER7 CPUs are different incompatible
>> families in QOM. The same is valid for POWER8E and POWER8 CPUs.
>> However, these couples are architecturally equal and there is n
Hi Paolo,
Thanks. I found a function called bdrv_invalidate_cache() in qcow2.c. After
migration, it will be called to invalidate the cache of the block device?
On Fri, Jun 27, 2014 at 5:49 PM, Paolo Bonzini wrote:
> Il 27/06/2014 21:41, Xiongzi Ge ha scritto:
>
>
>> When I studied the code, I
On 07.06.2014 20:51, Max Reitz wrote:
qemu-img should use QMP commands whenever possible in order to ensure
feature completeness of both online and offline image operations. For
the "commit" command, this is relatively easy, so implement it first
(in the hope that indeed others will follow).
As
Il 27/06/2014 20:01, Ming Lei ha scritto:
I just implemented plug&unplug based batching, and it is working now.
But throughout still has no obvious improvement.
Looks loading in IOthread is a bit low, so I am wondering if there is
block point caused by Qemu QEMU block layer.
What does perf say
Il 27/06/2014 21:41, Xiongzi Ge ha scritto:
When I studied the code, I found in migration.c,
bdrv_clear_incoming_migration_all();
the cache of the bdrv devices will be deleted.
Is this the one for the functions to be called after migration?
Does the bdrv device need to be reopen or load state
While at it, add some more tests to the quick group (those that run with
-nocache in under three seconds on my HDD).
Signed-off-by: Max Reitz
---
tests/qemu-iotests/group | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/tests/qemu-iotes
From: Fam Zheng
There should be a BLOCK_JOB_READY event with active commit, regardless
of image length. Let's test the 0 length image case, and make sure it
goes through the ready->complete process.
Signed-off-by: Fam Zheng
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
tests/qemu-iot
From: Wenchao Xia
This patch improve docs and uses c_type(argentry, is_param=True)
in script.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
Signed-off-by: Luiz Capitulino
---
docs/qapi-code-gen.txt | 8
scripts/qapi-event.py | 5 ++---
scripts
Now that qemu-iotests-quick.sh supports tests using the qemu binary, we
are free to add such tests to the quick group.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/group | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/qemu-iotests/group b/tests
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Luiz Capitulino
---
docs/qmp/qmp-events.txt | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
index 22fea58..44be891 100644
--- a/docs/qmp/q
From: Laszlo Ersek
In addition to the on-line reporting added in the previous patch, allow
libvirt to query frontend state independently of events.
Libvirt's path to identify the guest agent channel it cares about differs
between the event added in the previous patch and the QMP response field
a
From: Peter Lieven
upcoming libnfs will feature internal readahead support.
Add a knob to pass the optional readahead value as a URL
parameter.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/nfs.c | 4
1 file changed, 4 insertions(+)
diff --git
From: Fam Zheng
This will make converging with dataplane code easier.
Add virtio_blk_free_request to handle the freeing of request internal
fields.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/virtio-blk.c | 85 +++
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block.c | 88 +
1 file changed, 45 insertions(+), 43 deletions(-)
diff --git a/block.c b/block.c
index 0da39e6..0d97fde 100644
--- a/block.c
+++ b/block.c
@@ -1005,19 +1005,62 @
From: Fam Zheng
For later reusing by dataplane code.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/virtio-blk.c | 11 ---
include/hw/virtio/virtio-blk.h | 11 +++
2 files changed, 11 insertions(+), 11 deletions(-)
diff
From: Fam Zheng
out_sg is checked by iov_to_buf below, so it can be dropped.
Add assert and iov_discard_back around in_sg, as the in_sg is handled in
dataplane code.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/virtio-blk.c | 21 ++
From: Fam Zheng
Field "inhdr" is added temporarily for a more mechanical change, and
will be dropped in the next commit.
Signed-off-by: Fam Zheng
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/dataplane/virtio-blk.c | 34 +++---
From: Fam Zheng
This will unset busy flag and put coroutine to sleep, can be used to
wait for QMP complete/cancel.
Signed-off-by: Fam Zheng
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
blockjob.c | 14 ++
include/block/blockjob.h | 8
2 files chan
My previous series "iotests: Allow out-of-tree run" broke
qemu-iotests-quick.sh. Fixing it means simplifying it and allowing more
tests to be added to the quick group, which is what this series does. It
also adds some unaffected tests to the quick group because I can't see a
reason why not to.
Thi
As of the "iotests: Allow out-of-tree run" series, the qemu-iotests may
(and should) be run directly in the build tree and will then guess the
binary paths themselves. Therefore, qemu-iotests-quick.sh does not need
to (and should not) enter the source path anymore; also, it does not
need to specify
From: Benoît Canet
drive-mirror will bdrv_swap the new BDS named node-name with the one
pointed by replaces when the mirroring is finished.
Signed-off-by: Benoit Canet
Signed-off-by: Kevin Wolf
---
block.c | 25
block/mirror.c| 60 +++
This avoid breaking tests on RHEL6 where gnutls is too old for quorum to be
built by default.
Signed-off-by: Benoit Canet
---
tests/qemu-iotests/041 | 49 +++--
1 file changed, 47 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/041 b/tes
From: Benoît Canet
On read operations when this parameter is set and some replicas are corrupted
while quorum can be reached quorum will proceed to rewrite the correct version
of the data to fix the corrupted replicas.
This will shine with SSD where the FTL will remap the same block at another
p
From: Michal Privoznik
When running a libvirt test suite I've noticed the qemu-img is
crashing occasionally. Tracing the problem down led me to the
following valgrind output:
qemu.git $ valgrind -q ./qemu-img create -f qed
-obacking_file=/dev/null,backing_fmt=raw qed
==14881== Invalid write of
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
Signed-off-by: Luiz Capitulino
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index c658613..2286d0a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -26,6 +26,7 @@
/qapi-generated
/q
From: Fam Zheng
All behavior and invariant should hold for images with 0 length, so
add a class to repeat all the tests in TestSingleDrive.
Hide two unapplicable test methods that would fail with 0 image length
because it's also used as cluster size.
Signed-off-by: Fam Zheng
Signed-off-by: Kev
From: Jeff Cody
If 'base' is smaller than the overlay image being committed into it,
then the base image will be grown in commit_run via bdrv_truncate().
This tests to make sure that this works, and the bdrv_truncate() is
not blocked when it shouldn't be.
Signed-off-by: Jeff Cody
Reviewed-by:
From: Jeff Cody
If we check for the RESIZE blocker in bdrv_truncate(), that means a
commit will fail if the overlay layer is larger than the base, due to
the backing blocker.
This is a regression in behavior from 2.0; currently, commit will try to
grow the size of the base image to match the ove
Am 27.06.2014 um 22:17 hat Benoît Canet geschrieben:
> This avoid breaking tests on RHEL6 where gnutls is too old for quorum to be
> built by default.
>
> Signed-off-by: Benoit Canet
Tested-by: Kevin Wolf
It doesn't do much any more, we can move the code to bdrv_open() now.
Signed-off-by: Kevin Wolf
Reviewed-by: Benoit Canet
Reviewed-by: Eric Blake
---
block.c | 51 +++
1 file changed, 11 insertions(+), 40 deletions(-)
diff --git a/block.c b/bloc
This moves the bdrv_open_file() call a bit down so that it can use the
bdrv_open() code that selects the right block driver.
The code between the old and the new call site is either common code
(the error message for an unknown driver has been unified now) or
doesn't run with cleared BDRV_O_PROTOC
This recursion was introduced in commit 505d7583 in order to allow
nesting image formats. It only ever takes effect when the user
explicitly specifies a driver name and that driver isn't suitable for
the protocol level.
We can check this earlier in bdrv_open() and if the explicitly
requested drive
From: Fam Zheng
The virtio code currently assumes that the outhdr is in its own iovec.
This is not guaranteed by the spec, so we should relax this assumption.
Convert the VirtIOBlockReq.out field to structrue so that we can use
iov_to_buf and then discard the header from the beginning of iovec.
From: Fam Zheng
VirtIOBlockReq is allocated in process_request, and freed in command
functions.
Signed-off-by: Fam Zheng
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/dataplane/virtio-blk.c | 102 +---
1 fi
From: Stefan Hajnoczi
This function is only called from block/qapi.c. There is no need to
keep it public.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
Tested-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/qapi.c | 2 +-
include/block/
From: Fam Zheng
When mirroring or active committing a zero length image, BLOCK_JOB_READY
is not reported now, instead the job completes because we short circuit
the mirror job loop.
This is inconsistent with non-zero length images, and only confuses
management software.
Let's do the same thing
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
Signed-off-by: Luiz Capitulino
---
Makefile | 2 +-
qapi-schema.json | 5 +++--
qapi-event.json => qapi/event.json | 0
3 files changed, 4 insertions(+), 3 deletions(-)
rename qap
The only semantic change is that bs->open_flags gets BDRV_O_PROTOCOL set
now. This isn't useful, but it doesn't hurt either. The code that was
previously skipped by 'goto done' is automatically disabled because
protocol drivers don't support backing files (and if they did, this
would probably be a
From: Fam Zheng
This drops request handling code from dataplane, and uses code from
hw/block/virtio-blk.c.
It starts to use multiwrite as non-dataplane does.
Dataplane sets VirtIOBlock.complete_request to vring version, and calls
into non-dataplane's process handling. In complete_request_early,
From: Fam Zheng
The old name is misleading in its new usage, so rename it.
Signed-off-by: Fam Zheng
Tested-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/dataplane/virtio-blk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/
From: Chen Gang
When failure occurs, 'ret' need be set, or may return 0 to indicate
success. Previously, an error was set in errp, but 0 was returned
anyway. So let bdrv_append_temp_snapshot() return an error code and
use that for the bdrv_open() return value.
Also, error_propagate() need be cal
From: Wenchao Xia
This patch improves docs and address small issues in event
callers.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
Signed-off-by: Luiz Capitulino
---
hw/watchdog/watchdog.c | 2 +-
include/block/blockjob.h | 2 +-
monitor.c| 2 +-
qapi-schema.json
From: Markus Armbruster
Commit 5a2d2cb screwed up the the value of members device and action,
breaking tests/qemu-iotests/041.
Signed-off-by: Markus Armbruster
Tested-By: Benoit Canet
Reviewed-by: Kevin Wolf
Reviewed-by: Luiz Capitulino
Signed-off-by: Kevin Wolf
---
blockjob.c |
From: Max Reitz
iotest 083 filters out debug messages from nbd, which are prefixed (and
recognized) by __FILE__. However, the current filter (/^nbd\.c…/) is
valid for in-tree builds only, as out-of-tree builds will have a path
before that filename (e.g. "/tmp/qemu/nbd.c"). Fix this by adding .*
b
This avoid breaking tests on RHEL6 where gnutls is too old for quorum to be
built by default.
Signed-off-by: Benoit Canet
---
tests/qemu-iotests/041 | 13 +
1 file changed, 13 insertions(+)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 0815e19..c5267c0 100755
--
Since we parse backing.* options to add a backing file from the command
line when the driver didn't assign one, it has been possible to have a
backing file for e.g. raw images (it just was never accessed).
This is obvious nonsense and should be rejected.
Signed-off-by: Kevin Wolf
Reviewed-by: Er
From: Fam Zheng
In current virtio spec, inhdr is a single byte, and is unlikely to
change for both functionality and compatibility considerations.
Non-dataplane uses .in, and we are on the way to converge them. So
let's unify it to get cleaner code.
Remove .inhdr and use .in.
Signed-off-by: Fam
From: Laszlo Ersek
Libvirt wants to know about the guest-side connection state of some
virtio-serial ports (in particular the one(s) assigned to guest agent(s)).
Report such states with a new monitor event.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376
Signed-off-by: Laszlo Ersek
Re
Hello,
When I studied the code, I found in migration.c,
bdrv_clear_incoming_migration_all();
the cache of the bdrv devices will be deleted.
Is this the one for the functions to be called after migration?
Does the bdrv device need to be reopen or load state in block.c?
I would like to find this
The conversion of events to the QAPI, resulted in the removal of the
docs/qmp/qmp-events.txt file. This was done to avoid having duplicated
information between qmp-events.txt and qapi-event.json.
However, qmp-events.txt contains examples and we're still not sure
how to proper install QAPI docs in
The following changes since commit d4cba13bdf251baeedb36b87c1e9f6766773e380:
tcg/ppc: Fix failure in tcg_out_mem_long (2014-06-27 13:23:41 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
for you to fetch changes up to a22d8e47f7efb15a96162b92b
bs->options now contains the modified version of the options.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/block.c b/block.c
index 757d139..0da39e6 100644
--- a/block.c
+++ b/block.c
From: Markus Armbruster
Commit bcada37 dropped the (up to now undocumented) members type, len,
offset, speed, breaking tests/qemu-iotests/040 and 041.
Restore and document them. This fixes 040, and partially fixes 041.
Signed-off-by: Markus Armbruster
Tested-By: Benoit Canet
Signed-off-by: K
The idea of bdrv_fill_options() is to convert every parameter for
opening images, in particular the filename and flags, to entries in the
options QDict.
This patch starts with moving the filename parsing and driver probing
part from bdrv_file_open() to the new function.
Signed-off-by: Kevin Wolf
On 06/27/2014 12:37 AM, Nikunj A Dadhania wrote:
> PAPR compliant guest calls this in absence of kdump. This finally
> reaches the guest and can be handled according to the policies set by
> higher level tools(like taking dump) for further analysis by tools like
> crash.
>
> Linux kernel calls thi
The Friday 27 Jun 2014 à 20:37:34 (+0200), Kevin Wolf wrote :
> Am 27.06.2014 um 18:25 hat Benoît Canet geschrieben:
> > in v2:
> > Fixed 041.out [Benoît]
> > Tested 041 on top of markus [PATCH 2.1 0/2] Fix two recent event
> > regressions
> >
> > in v1:
> > no blank line
From: Max Reitz
Instead of invoking Python scripts directly via ./, use $PYTHON to
obtain the correct Python interpreter command.
Signed-off-by: Max Reitz
Reviewed-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/031 | 8
tests/qemu-iotests/036 | 6 +++---
tests/
From: Max Reitz
As out-of-tree builds are preferred for qemu, running the qemu-iotests
in that out-of-tree build should be supported as well. To do so, a
symbolic link has to be created pointing to the check script in the
source directory. That script will check whether it has been run through
a
From: Fam Zheng
virtio_blk_req_complete will call VirtIOBlock.complete_request() to push
data and notify guest. No functional change.
Later, this will allow dataplane to provide it's own (vring_) version.
Signed-off-by: Fam Zheng
Tested-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-o
From: Max Reitz
Test 065 specified python2 to be used in its Shebang; this might not
work on systems without a python2 symlink and furthermore it is now
counter-productive, as the check script compares the Shebang to
"#!/usr/bin/env python" and only uses the Python interpreter selected by
configu
From: Stefan Hajnoczi
Make query-blockstats safe for dataplane by acquiring the
BlockDriverState's AioContext. This ensures that the dataplane IOThread
and the main loop's monitor code do not race.
Note the assumption that acquiring the drive's BDS AioContext also
protects ->file and ->backing_
On 06/27/2014 04:23 AM, Stefan Hajnoczi wrote:
> This document explains how IOThreads and the main loop are related,
> especially how to write code that can run in an IOThread. Currently
> only virtio-blk-data-plane uses these techniques. The next obvious
> target is virtio-scsi; there has also b
From: Max Reitz
Source common.env in the iotests' check script.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/check | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 69f328b..992b91e 100755
--- a/tes
From: Benoît Canet
The to-replace-node-name is designed to allow repairing a broken Quorum file.
This patch introduces a new class TestRepairQuorum testing that the feature
works.
Some further work will be done on QEMU to improve the robustness of the tests.
Signed-off-by: Benoit Canet
Reviewed
From: Fam Zheng
Since it's set but not used.
Signed-off-by: Fam Zheng
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/dataplane/virtio-blk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/datapla
From: Peter Lieven
this patch fixes the incorrect usage of strncmp and
adds simple error checking by means of parse_uint_full
instead of atoi for the supplied URL parameters.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/nfs.c | 18 --
From: Max Reitz
In order to allow out-of-tree iotests, create a symlink for the check
script in the build tree.
While doing so, also write configured options relevant to the iotests to
common.env in the build tree; currently, this is the command to invoke
Python 2.
Signed-off-by: Max Reitz
Sig
From: Fam Zheng
The BH must be called in the AioContext of bs. Currently it is only the
main loop, but with coming changes, it could also be a dataplane
IOThread.
Signed-off-by: Fam Zheng
Tested-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/virtio-blk
From: Fam Zheng
The block layer will handle the unaligned request.
Signed-off-by: Fam Zheng
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/dataplane/virtio-blk.c | 25 -
1 file changed, 25 deletions(-)
diff --git a/hw/
From: Fam Zheng
So that dataplane can use virtio_blk_handle_request and
virtio_submit_multiwrite.
Signed-off-by: Fam Zheng
Tested-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/block/virtio-blk.c | 10 ++
include/hw/virtio/virtio-blk.h | 9
From: Benoît Canet
This new argument can be used to specify the node-name of the new mirrored BDS.
Signed-off-by: Benoit Canet
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
blockdev.c | 11 +--
hmp.c| 1 +
qapi/block-core.json | 4
qmp-commands
The "driver" entry in the options QDict is now only missing if we're
opening an image with format probing.
We also catch cases now where both the drv argument and a "driver"
option is specified, e.g. by specifying -drive format=qcow2,driver=raw
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
The following changes since commit 2b5b7ae917e8db48431631b1c5d909fa46c223a6:
Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-06-24'
into staging (2014-06-24 17:14:57 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for yo
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Fri, Jun 27, 2014 at 03:42:10PM +0100, Dr. David Alan Gilbert wrote:
> > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > On Fri, Jun 27, 2014 at 09:34:38AM +0100, Dr. David Alan Gilbert (git)
> > > wrote:
> > > > From: "Dr. David Alan Gilbert"
From: "Dr. David Alan Gilbert"
Commit 'virtio: validate config_len on load' restricted config_len
loaded from the wire to match the config_len that the device had.
Unfortunately, there are cases where this isn't true, the one
we found it on was the wce addition in virtio-blk.
Allow mismatched c
Am 27.06.2014 um 18:25 hat Benoît Canet geschrieben:
> in v2:
> Fixed 041.out [Benoît]
> Tested 041 on top of markus [PATCH 2.1 0/2] Fix two recent event
> regressions
>
> in v1:
> no blank line before EOF [Kevin]
> Add call to bdrv_is_first_non_filter in check_to_
On Fri, 27 Jun 2014 18:28:47 +0200
Kevin Wolf wrote:
> Am 27.06.2014 um 15:47 hat Markus Armbruster geschrieben:
> > Commit bcada37 dropped the (undocumented) members type, len, offset,
> > speed, breaking tests/qemu-iotests/040 and 041.
> >
> > Restore them. This fixes 040, and partially fixes
Am 27.06.2014 um 19:24 hat Markus Armbruster geschrieben:
> This series plus Paolo's "[PATCH for 2.1] qdev: correctly send
> DEVICE_DELETED for recursively-deleted devices" makes qemu-iotests
> check -qcow2 again pass for me.
>
> Kevin, Luiz, you decide how to best route these three patches. Note
On Fri, 2014-06-27 at 13:51 -0400, Paolo Bonzini wrote:
> - Messaggio originale -
> > Da: "Alex Williamson"
> > A: "Paolo Bonzini"
> > Cc: qemu-devel@nongnu.org, qemu-triv...@nongnu.org
> > Inviato: Venerdì, 27 giugno 2014 18:34:59
> > Oggetto: Re: [PATCH for 2.1] vfio: use correct runsta
This series plus Paolo's "[PATCH for 2.1] qdev: correctly send
DEVICE_DELETED for recursively-deleted devices" makes qemu-iotests
check -qcow2 again pass for me.
Kevin, Luiz, you decide how to best route these three patches. Note
that PATCH 3 depends on Luiz's "[PATCH] qmp: add qmp-events.txt bac
Signed-off-by: Markus Armbruster
---
docs/qmp/qmp-events.txt | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
index 22fea58..44be891 100644
--- a/docs/qmp/qmp-events.txt
+++ b/docs/qmp/qmp-events.txt
@@ -157,12 +15
Am 23.06.2014 um 17:28 hat Chen Gang geschrieben:
> When failure occurs, 'ret' need be set, or may return 0 to indicate success.
> And error_propagate() also need be called only one time within a function.
>
> It is abnormal to prevent bdrv_append_temp_snapshot() return value but still
> set errp
Commit 5a2d2cb screwed up the the value of members device and action,
breaking tests/qemu-iotests/041.
Signed-off-by: Markus Armbruster
Tested-By: Benoit Canet
Reviewed-by: Kevin Wolf
Reviewed-by: Luiz Capitulino
---
blockjob.c | 2 +-
qapi/block-core.json | 2 +-
2 files changed, 2
On Wed, 25 Jun 2014 15:15:35 +0200
Paolo Bonzini wrote:
> Il 25/06/2014 15:13, Luiz Capitulino ha scritto:
> > On Tue, 24 Jun 2014 16:33:56 -0700
> > Wenchao Xia wrote:
> >
> >> From: Paolo Bonzini
> >>
> >> On old GLib, the test needs a g_thread_init call.
> >>
> >> Reported-by: Wenchao Xia
>
Commit bcada37 dropped the (up to now undocumented) members type, len,
offset, speed, breaking tests/qemu-iotests/040 and 041.
Restore and document them. This fixes 040, and partially fixes 041.
Signed-off-by: Markus Armbruster
Tested-By: Benoit Canet
---
blockjob.c | 6 +-
qap
On Fri, 27 Jun 2014 15:47:20 +0200
Markus Armbruster wrote:
> This series plus Paolo's "[PATCH for 2.1] qdev: correctly send
> DEVICE_DELETED for recursively-deleted devices" makes qemu-iotests
> check -qcow2 again pass for me.
>
> Luiz offered to take it through his tree.
Kevin is going to tak
On Fri, 27 Jun 2014 19:24:15 +0200
Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
I've cherry picked this one as this file only exists in qmp tree.
> ---
> docs/qmp/qmp-events.txt | 12 ++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/docs/qmp/qmp
Am 24.05.2014 um 23:24 hat Max Reitz geschrieben:
> This series enables qemu-iotests to be run in a build tree outside of
> the source tree. It also makes the tests use the command for invoking
> the Python interpreter specified through configure instead of always
> using "/usr/bin/env python".
Th
On Fri, Jun 27, 2014 at 8:01 PM, Stefan Hajnoczi wrote:
> On Thu, Jun 26, 2014 at 11:14:16PM +0800, Ming Lei wrote:
>> Hi Stefan,
>>
>> I found VM block I/O thoughput is decreased by more than 40%
>> on my laptop, and looks much worsen in my server environment,
>> and it is caused by your commit 5
- Messaggio originale -
> Da: "Alex Williamson"
> A: "Paolo Bonzini"
> Cc: qemu-devel@nongnu.org, qemu-triv...@nongnu.org
> Inviato: Venerdì, 27 giugno 2014 18:34:59
> Oggetto: Re: [PATCH for 2.1] vfio: use correct runstate
>
> On Fri, 2014-06-27 at 16:32 +0200, Paolo Bonzini wrote:
> >
> >>> +
> >>> +static void kvm_e500_handle_debug(CPUState *cs, int handle) {
> >>> +PowerPCCPU *cpu = POWERPC_CPU(cs);
> >>> +CPUPPCState *env = &cpu->env;
> >>> +
> >>> +env->spr[SPR_BOOKE_DBSR] = 0;
> >> How would KVM ever know that DBSR is now 0?
> > Yes, guest will not come to know
Kevin Wolf writes:
> Am 27.06.2014 um 15:47 hat Markus Armbruster geschrieben:
>> Commit bcada37 dropped the (undocumented) members type, len, offset,
>> speed, breaking tests/qemu-iotests/040 and 041.
>>
>> Restore them. This fixes 040, and partially fixes 041.
>>
>> Signed-off-by: Markus Arm
On 06/27/2014 01:30 PM, Alexander Graf wrote:
>
> On 27.06.14 11:29, Eric Auger wrote:
>> On 06/04/2014 02:28 PM, Alexander Graf wrote:
>>> For e500 our approach to supporting platform devices is to create a
>>> simple
>>> bus from the guest's point of view within which we map platform devices
>>>
On 27.06.14 18:33, Reza Jelveh wrote:
On 27/06/14 18:19, Alexander Graf wrote:
>I do agree that this should have been in the patch description. Reza,
>could you please repost this with a proper patch description and as a
>checkpatch.pl compliant patch? Also please CC me on the next iteration:).
1 - 100 of 329 matches
Mail list logo
