Re: [Qemu-devel] [PATCH] oslib-posix: Fix new compiler error with -Wclobbered

2014-07-07 Thread Paolo Bonzini
Il 07/07/2014 21:29, Stefan Weil ha scritto: Am 24.06.2014 23:03, schrieb Paolo Bonzini: Il 24/06/2014 22:52, Stefan Weil ha scritto: Newer versions of gcc report a warning (or an error with -Werror) when compiler option -Wclobbered (or -Wextra) is active: util/oslib-posix.c:372:12: error: va

Re: [Qemu-devel] [PATCH 14/15] target-tricore: Add instructions of SLR, SSRO and SRO opcode format

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > Add instructions of SLR, SSRO and SRO opcode format. All of my previous comments re memory accesses apply. r~

Re: [Qemu-devel] [RFC PATCH 00/11] Adding FreeBSD's Capsicum security framework (part 1)

2014-07-07 Thread Alexei Starovoitov
On Mon, Jul 7, 2014 at 5:20 AM, Paolo Bonzini wrote: > Il 07/07/2014 12:29, David Drysdale ha scritto: > >>> I think that's more easily done by opening the file as O_RDONLY/O_WRONLY >>> /O_RDWR. You could do it by running the file descriptor's seccomp-bpf >>> program once per iocb with synthesiz

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-07 Thread Richard Henderson
On 07/07/2014 09:20 PM, Al Viro wrote: > and I'm reasonably sure that this is what they did internally. You are > proposing to do 4 cases in all their messy glory in qemu itself... Yes. Primarily because we *have* to do so for the linux-user case. > And that's not even going into generating the

[Qemu-devel] [PATCH v4] spapr: add uuid/host details to device tree

2014-07-07 Thread Nikunj A Dadhania
Useful for identifying the guest/host uniquely within the guest. Adding following properties to the guest root node. vm,uuid - uuid of the guest host-model - Host model number host-serial - Host machine serial number hypervisor type - Tells its "kvm" Signed-off-by: Nikunj A Dadhania --- v4: mak

Re: [Qemu-devel] [PATCH 10/15] target-tricore: Add instructions of SB opcode format

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c > index b9fbfad..5267fd0 100644 > --- a/target-tricore/op_helper.c > +++ b/target-tricore/op_helper.c > @@ -56,6 +56,198 @@ target_ulong helper_shac(CPUTRICOREState *env, > targ

Re: [Qemu-devel] [PATCH 11/15] target-tricore: Add instructions of SBC and SBRN opcode format

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > +/* SBRN-format jumps */ > +case OPC1_16_SBRN_JZ_T: > +temp = tcg_temp_new(); > +tcg_gen_andi_tl(temp, cpu_gpr_d[15], 0x1u << constant); > +gen_branch_condi(ctx, TCG_COND_NE, temp, 0x1 << constant, offset); > +t

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-07 Thread Al Viro
On Mon, Jul 07, 2014 at 09:20:28AM -0700, Richard Henderson wrote: > > How is that different from other cases where we have an exception raised > > by an fp operation? > > In all other cases we know we're going to send SIGFPE. That's either through > a > non /S insn which the kernel wouldn't tou

[Qemu-devel] [Bug 1338277] Re: Ubuntu 14.04 + QEmu 2.0 + KSM = 1, makes Windows 2008 R2 guests to crash (BSOD)

2014-07-07 Thread Matthew Anderson
Hi Thiago, Your issue probably isn't related to the one I reported [1322441]. My issue was with automatic NUMA balancing. You could certainly try disabling numa balancing ( echo 0 > /proc/sys/kernel/numa_balancing ) and enabling KSM again to see if the fault occurs and if the crash is resolved it

[Qemu-devel] [PATCH for 2.1 V2] qemu-img info: show nocow info

2014-07-07 Thread Chunyan Liu
Add nocow info in 'qemu-img info' output to show whether the file currently has NOCOW flag set or not. Signed-off-by: Chunyan Liu --- Changes: - add documentation of "nocow" in qapi/block-core.json. block/qapi.c | 25 + qapi/block-core.json | 5 - 2 files

[Qemu-devel] [PATCH] vl.c: Keep maxram_size and ram_size consistent unless specified otherwise

2014-07-07 Thread Bruce Rogers
When using a memory size less than the default amount with older pc machine types, a failure occurs because of the way maxram_size and ram_size get initialized. Keep maxram_size and ram_size the same, except when maxmem is specified on the command line. Signed-off-by: Bruce Rogers --- vl.c | 2 +

Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running

2014-07-07 Thread Gonglei (Arei)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, July 07, 2014 9:08 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; ag...@suse.de; > stefa...@redhat.com; ak...@redhat.com; a...@ozlabs.ru; > alex.william...@redhat.com; arm...@red

Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running

2014-07-07 Thread Gonglei (Arei)
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, July 07, 2014 10:40 PM > To: Gonglei (Arei); Michael S. Tsirkin > Cc: qemu-devel@nongnu.org; afaer...@suse.de; ag...@suse.de; > stefa...@redhat.com; ak...@redhat.com; a...@ozlabs.ru; > alex.william...@redha

[Qemu-devel] [Bug 1338277] Re: QEmu 2.0 makes Windows 2008 guests to crash (BSOD)

2014-07-07 Thread Thiago Martins
Guys! I can confirm that, after disabling KSM, all "guest problems" disappeared!! All Windows 2008 R2 guests are now very stable under QEmu 2.0 but, KSM is disabled. * Windows 2008 R2 guests running for about 6 hours without any crash * Workaround - disabling KSM: --- root@hyper-kvm-1:~# cat

Re: [Qemu-devel] Dalvik execution on Android Emulator (QEMU)

2014-07-07 Thread Brian Jackson
On Monday, July 7, 2014 5:56:10 PM CDT, Anderson Sartor wrote: Hi all, I'm counting how many basic blocks are executed by a given application on the Android Emulator, so I modified QEMU to do this. However, I came across with the following: for 2 environment situations: (1) - only the emulator ru

[Qemu-devel] Dalvik execution on Android Emulator (QEMU)

2014-07-07 Thread Anderson Sartor
Hi all, I'm counting how many basic blocks are executed by a given application on the Android Emulator, so I modified QEMU to do this. However, I came across with the following: for 2 environment situations: (1) - only the emulator running in the host computer, (2) - the emulator + other processes

Re: [Qemu-devel] virtualize sparc developer workstation?

2014-07-07 Thread Mark Cave-Ayland
On 07/07/14 07:43, Markus Armbruster wrote: Cc'ing the SPARC maintainer. I'm not the official maintainer, but I've done some work on this and so can probably answer your question. dennis luehring writes: i want to virtualize (under a linux x86 host) my noisy sparc workstation with the h

[Qemu-devel] [Bug 1338591] Re: Cursor jumps on shape change with vmware vga

2014-07-07 Thread Ruslan
After some experimenting it starts to seem that this is a special case of a more general problem with HW accelerated cursor. This particular bug can be reproduced without any edit field — it's enough to try moving the classical cursor (i.e. HW accelerated as set in 1. in bug description) over some

Re: [Qemu-devel] [libvirt] Where to get precompiled qga-vss.dll from ?

2014-07-07 Thread Eric Blake
On 07/07/2014 02:32 AM, Puneet Bakshi wrote: > Hi, > > I want to work with "guest-fsfreeze-*" commands in Windows 2008 guest VM. > Host is CentOS 6.4. > > Windows 2008 is running QEMU VSS provider. When "guest-fsfreeze-*" commands > are invoked from host, response received is "This is not support

Re: [Qemu-devel] Any one notice my patch about Support vhd type VHD_DIFFERENCING

2014-07-07 Thread Brian Jackson
On Sunday, July 6, 2014 9:09:47 AM CDT, ssdxiao wrote: I have commited a patch about how to read and write type VHD_DIFFERENCING? Is any one interesting? There are a few docs about submitting patches to the project. I would read them and then try again. You may not have gotten the patch to the

Re: [Qemu-devel] [PATCH 16/46] Add migration-capability boolean for postcopy-ram.

2014-07-07 Thread Eric Blake
On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 1 + > migration.c | 9 + > qapi-schema.json | 6 +- > 3 files changed, 15 in

Re: [Qemu-devel] [PULL for-2.1 0/3] PReP patch queue 2014-07-07

2014-07-07 Thread Peter Maydell
On 7 July 2014 15:52, Andreas Färber wrote: > Hello Peter, > > Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: Alexander Graf > Cc: Hervé Poussineau > > The following changes since commit

[Qemu-devel] [PATCH 22/28] libqos: Fixes a small memory leak.

2014-07-07 Thread John Snow
Allow users the chance to clean up the QPCIBusPC structure by adding a small cleanup routine. Helps clear up small memory leaks during setup/teardown, to allow for cleaner debug output messages. Signed-off-by: John Snow --- tests/libqos/pci-pc.c | 7 +++ tests/libqos/pci-pc.h | 1 + 2 files

Re: [Qemu-devel] [PATCH 06/15] target-tricore: Add instructions of SRC opcode format

2014-07-07 Thread Max Filippov
Hi Bastian, On Mon, Jul 7, 2014 at 10:13 PM, Bastian Koppelmann wrote: > Add instructions of SRC opcode format. > Add helper for sh arithmetic carry. > Add micro-op generator functions for conditional add/sub/mov and sh. > > Signed-off-by: Bastian Koppelmann > --- > target-tricore/helper.h|

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > QEMU_ARCH_MOXIE = 0x8000, > +QEMU_ARCH_TRICORE = 0x16000, Hexidecimal, not decimal doubling. This file is a mess, I agree. A separate patch to standardize the existing numbers to hex would be appreciated. r~

Re: [Qemu-devel] [PULL 00/12] pc,vhost,virtio fixes, test

2014-07-07 Thread Peter Maydell
On 7 July 2014 13:39, Michael S. Tsirkin wrote: > I will merge only high priority fixes from here on. High priority means > regression fixes or fixes in a new feature if there is no workaround. > > The following changes since commit 9d9de254c2b81b68cd48f2324cc753a570a4cdd8: > > MAINTAINERS: secc

[Qemu-devel] [PATCH] qga: Add missing 'static' attribute

2014-07-07 Thread Stefan Weil
This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil --- qga/commands-posix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 34ddba0..8e6272c 100644 --- a/qga/commands-posix.c +++ b/qga/c

Re: [Qemu-devel] [PATCH 09/15] target-tricore: Add instructions of SRRS and SLRO opcode format.

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > +/* Functions for load/save to/from memory */ > +#define OP_MEM_INDIRECT(insn) \ > +static inline void gen_indirect_##insn(DisasContext *ctx, TCGv r1, TCGv r2, \ > +

Re: [Qemu-devel] [PATCH 07/15] target-tricore: Add instructions of SRR opcode format

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > Add instructions of SRR opcode format. > Add micro-op generator function for ssov. > > Signed-off-by: Bastian Koppelmann > --- > target-tricore/translate.c | 140 > - > 1 file changed, 139 insertions

[Qemu-devel] [PATCH 14/28] ahci: remove duplicate PORT_IRQ_* constants

2014-07-07 Thread John Snow
From: Paolo Bonzini These are defined twice, just use one set consistently. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 6 +++--- hw/ide/ahci.h | 21 - 2 files changed, 3 insertions(+), 24 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahc

Re: [Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress report

2014-07-07 Thread Eric Blake
On 07/05/2014 11:47 AM, Max Reitz wrote: > Instead of taking the total length of the block device as the block > job's length, use the number of dirty sectors. The progress is now the > number of sectors mirrored to the target block device. Note that this > may result in the job's length increasing

Re: [Qemu-devel] [PATCH 05/15] target-tricore: Add masks and opcodes for decoding

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > +/* This creates a mask with bits start .. end set to 1 and applies it to op > */ > +#define MASK_BITS(op, start, end) (op & (((1 << (end-start+1)) - 1) << > start)) This is extract32(op, (start), (end) - (start)) << (start) Do you ever use th

[Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors

2014-07-07 Thread John Snow
From: Paolo Bonzini This will provide a hook for sending the result of the command via the FIS receive area. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/core.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index b

Re: [Qemu-devel] [PATCH 16/46] Add migration-capability boolean for postcopy-ram.

2014-07-07 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > include/migration/migration.h | 1 + > > migration.c | 9 + > > qapi-schem

Re: [Qemu-devel] [PATCH 08/15] target-tricore: Add instructions of SSR opcode format

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > +case OPC1_16_SSR_ST_B: > +r1 = MASK_OP_SSR_S1(ctx->opcode); > +r2 = MASK_OP_SSR_S2(ctx->opcode); > +temp = tcg_temp_new(); > +tcg_gen_andi_tl(temp, cpu_gpr_d[r1], 0xff); > +tcg_gen_qemu_st8(temp, cpu_gp

[Qemu-devel] [PATCH 18/28] q35: Enable the ioapic device to be seen by qtest.

2014-07-07 Thread John Snow
Currently, the ioapic device can not be found in a qtest environment when requesting "irq_interrupt_in ioapic" via the qtest socket. By mirroring how the ioapic is added in i44ofx (hw/i440/pc_piix.c), as a child of "q35," the device is able to be seen by qtest. Signed-off-by: John Snow --- hw/i

[Qemu-devel] [PATCH 20/28] libqos: Correct memory leak

2014-07-07 Thread John Snow
Fix a small memory leak inside of libqos, in the pc_alloc_init routine. Signed-off-by: John Snow --- tests/libqos/malloc-pc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c index db1496c..63af60a 100644 --- a/tests/libqos/malloc-pc.c ++

[Qemu-devel] [PATCH 03/28] ide-test: add test for werror=stop

2014-07-07 Thread John Snow
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- tests/ide-test.c | 74 1 file changed, 74 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 4a0d97f..03af481 100644 --- a/tests/ide-test.c

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > + > +/* GPR Register */ > +target_ulong gpr_a[16]; > +target_ulong gpr_d[16]; > +}; > + > +typedef struct tricore_def_t tricore_def_t; > + > +typedef struct CPUTRICOREState CPUTRICOREState; > +struct CPUTRICOREState { > +TCState ac

[Qemu-devel] [PATCH 05/28] ide: simplify reset callbacks

2014-07-07 Thread John Snow
From: Paolo Bonzini Drop the unused return value and make the callback optional. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 6 -- hw/ide/core.c | 5 +++-- hw/ide/internal.h | 3 ++- hw/ide/macio.c| 1 - hw/ide/pci.c | 4 +--- 5 files changed

[Qemu-devel] [PATCH v2] hw/timer: Move extern declaration from .c to .h file

2014-07-07 Thread Stefan Weil
This fixes a warning from smatch (static code analyser). Fix also the comment with the renamed source file name. Signed-off-by: Stefan Weil --- v2: Moved extern declaration to better location, fixed comment. hw/timer/tusb6010.c |3 --- include/hw/usb.h|7 ++- 2 files changed,

[Qemu-devel] [PATCH 01/28] blkdebug: report errors on flush too

2014-07-07 Thread John Snow
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- block/blkdebug.c | 20 1 file changed, 20 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index f51407d..1586ed9 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -522,6 +52

Re: [Qemu-devel] [PATCH 06/15] target-tricore: Add instructions of SRC opcode format

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > +target_ulong helper_shac(CPUTRICOREState *env, target_ulong r1, > +target_ulong r2) Align the r2 argument properly. > +shift_count = 0 - const6; > +cond = r1 & 0x8000; > +if (cond != 0) { > +

[Qemu-devel] [PATCH 10/28] ide: remove wrong setting of BM_STATUS_INT

2014-07-07 Thread John Snow
From: Paolo Bonzini Similar to the case removed in commit 69c38b8 (ide/core: Remove explicit setting of BM_STATUS_INT, 2011-05-19), the only remaining use of add_status(..., BM_STATUS_INT) is for short PRDs. The flag should not be raised in this case. Signed-off-by: Paolo Bonzini Signed-off-by

[Qemu-devel] [PATCH 25/28] ahci: add test_pci_enable to ahci-test.

2014-07-07 Thread John Snow
This adds a test wherein we engage the PCI AHCI device and ensure that the memory region for the HBA functionality is now accessible. Under Q35 environments, additional PCI configuration is performed to ensure that the HBA functionality will become usable. Signed-off-by: John Snow --- tests/ahc

[Qemu-devel] [PATCH 00/28] ahci refactoring to support ahci-test suite

2014-07-07 Thread John Snow
This patch series introduces a number of small fixes and tweaks to help support an AHCI test suite that in the future I hope to expand to a fuller regression suite to help guide the development of the AHCI device support under, in particular, the Q35 machine type in QEMU. Paolo Bonzini has contrib

Re: [Qemu-devel] [PATCH] oslib-posix: Fix new compiler error with -Wclobbered

2014-07-07 Thread Stefan Weil
Am 24.06.2014 23:03, schrieb Paolo Bonzini: > Il 24/06/2014 22:52, Stefan Weil ha scritto: >> Newer versions of gcc report a warning (or an error with -Werror) when >> compiler option -Wclobbered (or -Wextra) is active: >> >> util/oslib-posix.c:372:12: error: >> variable ‘hpagesize’ might be clobb

[Qemu-devel] [PATCH 19/28] qtest: Adding qtest_memset and qmemset.

2014-07-07 Thread John Snow
Currently, libqtest allows for memread and memwrite, but does not offer a simple way to zero out regions of memory. This patch adds a simple function to do so. Signed-off-by: John Snow --- tests/libqtest.c | 12 tests/libqtest.h | 24 2 files changed, 36 ins

[Qemu-devel] [PATCH 07/28] ide: simplify async_cmd_done callbacks

2014-07-07 Thread John Snow
From: Paolo Bonzini Drop the unused return value. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 4 +--- hw/ide/internal.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 679357f..e494503 100644 --- a/hw

[Qemu-devel] [PATCH 06/28] ide: simplify set_inactive callbacks

2014-07-07 Thread John Snow
From: Paolo Bonzini Drop the unused return value and make the callback optional. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 6 -- hw/ide/core.c | 5 +++-- hw/ide/internal.h | 2 +- hw/ide/macio.c| 1 - hw/ide/pci.c | 4 +--- 5 files changed,

[Qemu-devel] [PATCH 17/28] ahci: construct PIO Setup FIS for PIO commands

2014-07-07 Thread John Snow
From: Paolo Bonzini PIO commands should put a PIO Setup FIS in the receive area when data transfer ends. Currently QEMU does not do this and only places the D2H FIS at the end of the operation. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 55 +

Re: [Qemu-devel] [RFC PATCH v1 4/5] VMState test: set the frequency of the vmstate testing process

2014-07-07 Thread Eric Blake
On 07/07/2014 11:18 AM, Sanidhya Kashyap wrote: > This patch introduces the mechanism to update the sleep interval - sinterval. > > Signed-off-by: Sanidhya Kashyap > --- > hmp-commands.hx | 15 +++ > hmp.c| 14 ++ > hmp.h| 1 + > qapi-schema.json

Re: [Qemu-devel] [PATCH 22/46] Migration parameters: Add qmp/hmp commands for setting/viewing

2014-07-07 Thread Eric Blake
On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add somewhere for the various migration parameters to be set with > one command; > > As suggested in the thread: > http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00243.html That's a bit old

[Qemu-devel] [PATCH] virtio: Move extern declaration to header file

2014-07-07 Thread Stefan Weil
This fixes a warning from smatch (static code analyser). Signed-off-by: Stefan Weil --- hw/virtio/vhost-backend.c |2 -- include/hw/virtio/vhost-backend.h |2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c i

[Qemu-devel] [PATCH] hw/usb: Add missing 'static' attribute

2014-07-07 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/usb/hcd-ohci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index cace945..13afdf5 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2021,7 +2021,7 @@ static const VMStateDescription vmstate

[Qemu-devel] [PATCH 13/28] ide: move retry constants out of BM_STATUS_* namespace

2014-07-07 Thread John Snow
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/core.c | 20 ++-- hw/ide/internal.h | 12 ++-- hw/ide/pci.c | 14 +++--- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c

[Qemu-devel] [Bug 1338277] Re: QEmu 2.0 makes Windows 2008 guests to crash (BSOD)

2014-07-07 Thread Thiago Martins
** Summary changed: - QEmu makes Windows 2008 guests to crash (BSOD) + QEmu 2.0 makes Windows 2008 guests to crash (BSOD) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1338277 Title: QEmu 2.0 make

Re: [Qemu-devel] [PATCH] hw/timer: Move extern declaration from .c to .h file

2014-07-07 Thread Peter Maydell
On 7 July 2014 20:22, Stefan Weil wrote: > This fixes a warning from smatch (static code analyser). > > Signed-off-by: Stefan Weil > --- > hw/timer/tusb6010.c |3 --- > include/hw/usb.h|4 > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/timer/tusb6010.c b/

[Qemu-devel] [PATCH] migration: Add missing 'static' attribute

2014-07-07 Thread Stefan Weil
Signed-off-by: Stefan Weil --- block-migration.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block-migration.c b/block-migration.c index 25a0388..73cdd07 100644 --- a/block-migration.c +++ b/block-migration.c @@ -861,7 +861,7 @@ static bool block_is_active(void *opaque)

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-07 Thread Peter Maydell
On 7 July 2014 19:13, Bastian Koppelmann wrote: > Add TriCore target stubs, QOM cpu and basic machine. > > Signed-off-by: Bastian Koppelmann > --- > arch_init.c | 2 + > configure | 13 ++ > cpu-exec.c | 11 +- > cpus

[Qemu-devel] [PATCH 16/28] ide: make all commands go through cmd_done

2014-07-07 Thread John Snow
From: Paolo Bonzini AHCI has code to fill in the D2H FIS trigger the IRQ all over the place. Centralize this in a single cmd_done callback by generalizing the existing async_cmd_done callback. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 16 +++- h

[Qemu-devel] [PATCH] hw/timer: Move extern declaration from .c to .h file

2014-07-07 Thread Stefan Weil
This fixes a warning from smatch (static code analyser). Signed-off-by: Stefan Weil --- hw/timer/tusb6010.c |3 --- include/hw/usb.h|4 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c index a281567..4e8f053 100644 --- a/hw

Re: [Qemu-devel] [PATCH v9 13/14] iotests: Add test for qcow2's bdrv_make_empty

2014-07-07 Thread Eric Blake
On 07/05/2014 11:47 AM, Max Reitz wrote: > Add a test for qcow2's fast bdrv_make_empty implementation on images > without internal snapshots. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/098 | 75 > ++ > tests/qemu-iotests/098.out | 26

[Qemu-devel] [PATCH 23/28] ahci: Adding basic functionality qtest.

2014-07-07 Thread John Snow
Currently, there is no qtest to test the functionality of the AHCI functionality present within the Q35 machine type. This patch adds a skeleton for an AHCI test suite, and adds a simple sanity-check test case where we identify that the AHCI device is present, then disengage the virtual machine.

[Qemu-devel] [PATCH 08/28] ide: simplify start_transfer callbacks

2014-07-07 Thread John Snow
From: Paolo Bonzini Drop the unused return value and make the callback optional. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 4 +--- hw/ide/core.c | 10 +++--- hw/ide/internal.h | 3 +-- hw/ide/macio.c| 6 -- hw/ide/pci.c | 6 --

[Qemu-devel] [PATCH 12/28] ide: move BM_STATUS bits to pci.[ch]

2014-07-07 Thread John Snow
From: Paolo Bonzini They are not used by AHCI, and should not be even available there. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/internal.h | 11 --- hw/ide/pci.c | 4 hw/ide/pci.h | 7 +++ 3 files changed, 11 insertions(+), 11 deletions(-)

[Qemu-devel] [PATCH 04/28] ide: stash aiocb for flushes

2014-07-07 Thread John Snow
From: Paolo Bonzini This ensures that operations are completed after a reset Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 3a38f1e..506db88 100644 --- a/hw/ide/

[Qemu-devel] [PATCH] tests: Add missing 'static' attributes (fix warnings from smatch)

2014-07-07 Thread Stefan Weil
Smatch also complains about 0 used for pointers, so replace those by NULL in test-visitor-serialization.c, too. Signed-off-by: Stefan Weil --- tests/fdc-test.c |2 +- tests/test-aio.c |2 +- tests/test-qemu-opts.c |2 +- tests/test-thro

[Qemu-devel] [PATCH 09/28] ide: wrap start_dma callback

2014-07-07 Thread John Snow
From: Paolo Bonzini Make it optional and prepare for the next patches. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/atapi.c| 6 ++ hw/ide/core.c | 15 --- hw/ide/internal.h | 1 + 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH] Fix new typos in comments (found by codespell)

2014-07-07 Thread Stefan Weil
arbitary -> arbitrary basicly -> basically Signed-off-by: Stefan Weil --- hw/i386/pc_piix.c |2 +- hw/i386/pc_q35.c |2 +- include/libdecnumber/decNumberLocal.h |2 +- xen-hvm.c |2 +- 4 files changed, 4 inserti

Re: [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field

2014-07-07 Thread Eric Blake
On 07/05/2014 11:47 AM, Max Reitz wrote: > When a block job signals readiness, this is currently reported only > through QMP. If qemu wants to use block jobs for internal tasks, there > needs to be another way to correctly detect when a block job may be > completed. > > For this reason, introduce

Re: [Qemu-devel] [PATCH] Handle G_IO_HUP in tcp_chr_read for tcp chardev

2014-07-07 Thread Nikolay Nikolaev
On Tue, Jul 1, 2014 at 2:52 PM, Kirill Batuzov wrote: > Due to GLib limitations it is not possible to create several watches on one > channel on Windows hosts. See bug #338943 in GNOME bugzilla for details: > https://bugzilla.gnome.org/show_bug.cgi?id=338943 > > Handle G_IO_HUP in tcp_chr_read. It

Re: [Qemu-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-07-07 Thread Daniel Vetter
On Mon, Jul 07, 2014 at 07:58:30PM +0200, Paolo Bonzini wrote: > Il 07/07/2014 19:54, Daniel Vetter ha scritto: > >On Mon, Jul 07, 2014 at 04:57:45PM +0200, Paolo Bonzini wrote: > >>Il 07/07/2014 16:49, Daniel Vetter ha scritto: > >>>So the correct fix to forward intel gpus to guests is indeed to s

[Qemu-devel] [PATCH 28/28] ahci: Add test_identify case to ahci-test.

2014-07-07 Thread John Snow
Utilizing all of the bring-up code in pci_enable and hba_enable, this test issues a simple IDENTIFY command via the HBA and retrieves the response via the PIO receive mechanisms of the HBA. Signed-off-by: John Snow --- tests/ahci-test.c | 296 +

[Qemu-devel] [PATCH for-2.1] pc_piix: Reuse pc_compat_1_2() for pc-0.1[0123]

2014-07-07 Thread Eduardo Habkost
pc-0.13 and older were missing some compat code that was present on newer machine-types: * x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC); (pc-i440fx-1.7 and older) (added by commit ef02ef5f4536dba090b12360a6c862ef0e57e3bc) * x86_cpu_compat_set_features("n270", FEAT_1_ECX, 0

Re: [Qemu-devel] [RFC PATCH v1 1/5] QEMUSizedBuffer/QEMUFile

2014-07-07 Thread Eric Blake
On 07/07/2014 11:18 AM, Sanidhya Kashyap wrote: > From: "Dr. David Alan Gilbert" You are attributing the patch to David... > > Using the patch of Stefan Berger for memory buffer based QEMUFile. > > http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html > > In the words of David: >

[Qemu-devel] [PATCH 21/28] libqtest: Correct small memory leak.

2014-07-07 Thread John Snow
Fixes a small memory leak inside of libqtest. After we produce a test path and glib copies the string for itself, we should clean up our temporary copy. Signed-off-by: John Snow --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index e52

[Qemu-devel] [PATCH 27/28] ahci: Add test_hba_enable to ahci-test.

2014-07-07 Thread John Snow
This test engages the HBA functionality and initializes values to sane defaults to allow for minimal HBA functionality. Buffers are allocated and pointers are updated to allow minimal I/O commands to complete as expected. Error registers and responses are sanity checked for specification adherence

[Qemu-devel] [PATCH 26/28] ahci: Add test_hba_spec to ahci-test.

2014-07-07 Thread John Snow
Add a test routine that checks the boot-up values of the HBA configuration memory space against the AHCI 1.3 specification and Intel ICH9 data sheet (for Q35 machines) for adherence and sane values. The HBA is not yet engaged or put into the idle state. Signed-off-by: John Snow --- tests/ahci-t

[Qemu-devel] [PATCH 24/28] ahci: Add test_pci_spec to ahci-test.

2014-07-07 Thread John Snow
Adds a specification adherence test for AHCI where the boot-up values for the PCI configuration space are compared against the AHCI 1.3 specification. This test does not itself attempt to engage the device. Signed-off-by: John Snow --- tests/ahci-test.c | 271 +++

[Qemu-devel] [PATCH 02/28] libqtest: add QTEST_LOG for debugging qtest testcases

2014-07-07 Thread John Snow
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- tests/libqtest.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 98e8f4b..4a75cd3 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -167,11 +1

[Qemu-devel] [PATCH 11/28] ide: fold add_status callback into set_inactive

2014-07-07 Thread John Snow
From: Paolo Bonzini It is now called only after the set_inactive callback. Put the two together. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 9 - hw/ide/atapi.c| 2 +- hw/ide/core.c | 12 hw/ide/internal.h | 6 +++--- hw/ide/m

[Qemu-devel] [PATCH 15/15] target-tricore: Add instructions of SR opcode format

2014-07-07 Thread Bastian Koppelmann
Add instructions of SR opcode format. Add micro-op generator functions for saturate and rsubi. Add helper return from exception (rfe). Signed-off-by: Bastian Koppelmann --- target-tricore/helper.h| 1 + target-tricore/op_helper.c | 58 ++ target-tricore/translate.c | 144 +

Re: [Qemu-devel] [Bug 1338563] Re: README refers to a non-extant file

2014-07-07 Thread Peter Maydell
On 7 July 2014 18:57, Stefan Weil <1338...@bugs.launchpad.net> wrote: > The QEMU wiki which is mentioned in the README includes documention, and > there is a link to qemu-doc.html on http://wiki.qemu-project.org/Manual. This is true, but I think it would be helpful if we specifically pointed the u

[Qemu-devel] [PATCH 11/15] target-tricore: Add instructions of SBC and SBRN opcode format

2014-07-07 Thread Bastian Koppelmann
Add instructions of SBC and SBRN opcode format. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index f32e1d1

Re: [Qemu-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-07-07 Thread Daniel Vetter
On Mon, Jul 07, 2014 at 04:57:45PM +0200, Paolo Bonzini wrote: > Il 07/07/2014 16:49, Daniel Vetter ha scritto: > >So the correct fix to forward intel gpus to guests is indeed to somehow > >fake the pch pci ids since the driver really needs them. Gross design, but > >that's how the hardware works.

[Qemu-devel] [PATCH 07/15] target-tricore: Add instructions of SRR opcode format

2014-07-07 Thread Bastian Koppelmann
Add instructions of SRR opcode format. Add micro-op generator function for ssov. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 140 - 1 file changed, 139 insertions(+), 1 deletion(-) diff --git a/target-tricore/translate.c b/targe

[Qemu-devel] [PATCH 00/15] TriCore architecture guest implementation

2014-07-07 Thread Bastian Koppelmann
Hi, my aim is to add Infineon's TriCore architecture to QEMU. This series of patches adds the target stubs, a basic testboard and a softmmu for system mode emulation. Furthermore it adds all the 16 bit long instructions of the architecture grouped by opcode format. After this series of patches

[Qemu-devel] [Bug 1338563] Re: README refers to a non-extant file

2014-07-07 Thread Stefan Weil
The QEMU wiki which is mentioned in the README includes documention, and there is a link to qemu-doc.html on http://wiki.qemu-project.org/Manual. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [Qemu-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-07-07 Thread Paolo Bonzini
Il 07/07/2014 19:54, Daniel Vetter ha scritto: On Mon, Jul 07, 2014 at 04:57:45PM +0200, Paolo Bonzini wrote: Il 07/07/2014 16:49, Daniel Vetter ha scritto: So the correct fix to forward intel gpus to guests is indeed to somehow fake the pch pci ids since the driver really needs them. Gross des

Re: [Qemu-devel] [RFC PATCH v1 2/5] VMState test: basic vmstate testing mechanism

2014-07-07 Thread Eric Blake
On 07/07/2014 11:18 AM, Sanidhya Kashyap wrote: > This patch introduces the mechanism to test the devices state by storing > and dumping in in the QEMUFile pointer. > > The testing is done as follows: > 1) The VM is halted. > 2) guest state is synchronized. > 3) Then the device state is dumped to

[Qemu-devel] [Bug 1338563] Re: README refers to a non-extant file

2014-07-07 Thread Daniel U. Thibault
Having qemu-doc.html appear once QEMU is built and installed (in the source folder and in /usr/local/share/doc/qemu) defeats the purpose of the README, which is the very first place a new user looks for building and installation instructions. The README needs to instruct the user to first run './c

[Qemu-devel] [PATCH 13/15] target-tricore: Add instructions of SC opcode format

2014-07-07 Thread Bastian Koppelmann
Add instructions of SC opcode format. Add makro to generate helper with 1 arg. Add micro-op generator functions for indirect loads. Signed-off-by: Bastian Koppelmann --- target-tricore/helper.h| 2 +- target-tricore/op_helper.c | 40 + target-tricore/tran

[Qemu-devel] [PATCH 04/15] target-tricore: Add initialization for translation

2014-07-07 Thread Bastian Koppelmann
Add tcg and cpu model initialization. Add gen_intermediate_code function. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 160 +++- target-tricore/translate_init.c | 30 2 files changed, 189 insertions(+), 1 deletion(-) diff

[Qemu-devel] [Bug 1338277] Re: QEmu makes Windows 2008 guests to crash (BSOD)

2014-07-07 Thread Thiago Martins
** Description changed: Guys, I'm trying to run Windows 2008 as a QEmu guest on my Ubuntu 14.04 but, after lots of tests, I figured out that it doesn't work, QEmu makes Windows 2008 to crash, and it is not a Windows fault, I'm pretty sure that it is a QEmu bug. Lab environment (5

[Qemu-devel] [PATCH 06/15] target-tricore: Add instructions of SRC opcode format

2014-07-07 Thread Bastian Koppelmann
Add instructions of SRC opcode format. Add helper for sh arithmetic carry. Add micro-op generator functions for conditional add/sub/mov and sh. Signed-off-by: Bastian Koppelmann --- target-tricore/helper.h| 19 + target-tricore/op_helper.c | 36 + target-tricore/translate.c | 1

[Qemu-devel] [RFC PATCH v1 5/5] VMState test: cancel mechanism for an already running vmstate testing process

2014-07-07 Thread Sanidhya Kashyap
This patch helps in cancelling an already executing vmstate testing process. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 14 ++ hmp.c| 6 ++ hmp.h| 1 + qapi-schema.json | 9 + qmp-commands.hx | 20 savevm.c

[Qemu-devel] [RFC PATCH v1 4/5] VMState test: set the frequency of the vmstate testing process

2014-07-07 Thread Sanidhya Kashyap
This patch introduces the mechanism to update the sleep interval - sinterval. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 15 +++ hmp.c| 14 ++ hmp.h| 1 + qapi-schema.json | 10 ++ qmp-commands.hx | 22 ++

[Qemu-devel] [RFC PATCH v1 2/5] VMState test: basic vmstate testing mechanism

2014-07-07 Thread Sanidhya Kashyap
This patch introduces the mechanism to test the devices state by storing and dumping in in the QEMUFile pointer. The testing is done as follows: 1) The VM is halted. 2) guest state is synchronized. 3) Then the device state is dumped to a temporary memory. 4) The guest state is reset. 5) Then the d

[Qemu-devel] [RFC PATCH v1 3/5] VMState test: hmp interface for vmstate testing

2014-07-07 Thread Sanidhya Kashyap
Added hmp interface. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 15 +++ hmp.c | 14 ++ hmp.h | 1 + 3 files changed, 30 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index d0943b1..c492f3f 100644 --- a/hmp-commands.hx +++ b/

  1   2   3   >