Hi,
> Subject: Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more
> idiomatic writing style
>
> Andreas Färber writes:
>
> > Am 01.08.2014 05:32, schrieb Gonglei (Arei):
> >> Hi,
> >>
> >>> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more
> >>> idiomatic writing
Andreas Färber writes:
> Am 01.08.2014 05:32, schrieb Gonglei (Arei):
>> Hi,
>>
>>> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more
>>> idiomatic writing
>>> style
>>>
>>> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
From: Gonglei
Signed-off-by: Gonglei
Il 01/08/2014 05:09, Ming Lei ha scritto:
>>> >> Per virtio spec, only the feature is set, the VM can be allowed to
>>> >> access the 'num_queues' field, and I didn't see any problem from
>>> >> VM's view point.
>>> >>
>>> >> So could you explain why both dataplane and non-dataplane have
>>> >> to
On Mon, Jul 21, 2014 at 02:18:10PM +0400, Maria Kustova wrote:
> +def random_from_intervals(intervals):
> +"""Select a random integer number from the list of specified intervals
> +
> +Each interval is a tuple of lower and upper limits of the interval. The
> +limits are included. Interv
On Mon, Jul 21, 2014 at 02:18:09PM +0400, Maria Kustova wrote:
> +def execute(self, input_commands=None, fuzz_config=None):
> +""" Execute a test.
> +
> +The method creates backing and test images, runs test app and
> analyzes
> +its exit status. If the application was
On Thu, Jul 24, 2014 at 04:32:29PM +0400, Maria Kustova wrote:
> ['>I', offset, 0x6803f857, 'ext_magic'],
> -['>I', offset + UINT32_S, len(feature_tables)*48,
> 'ext_length']
> +# Length of one feature table equals to 3 fields and 48 bytes
> +
Signed-off-by: Benoit Canet
---
monitor-system.c | 283 +++
monitor.c| 281 --
2 files changed, 283 insertions(+), 281 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
ind
Since qmp-command-olds.h is generated from qmp-commands.hx we will sometime want
to include only a subset of it. For example when linking qapi block commands
with qemu-nbd.
Signed-off-by: Benoit Canet
---
Makefile | 7 +++
scripts/filter_qmp_commands_old.py | 93 ++
Signed-off-by: Benoit Canet
---
Makefile.target | 1 +
disas.c | 10 ++
include/monitor/monitor-system.h | 3 ++
include/monitor/monitor.h| 2 --
monitor-system.c | 69
monitor.c
This will allow monitor.c to access these functions once they are moved in
monitor-system.c
Signed-off-by: Benoit Canet
---
include/monitor/monitor-system.h | 37 ++
monitor-system.c | 1163 ++
monitor.c| 1162
Signed-off-by: Benoit Canet
---
monitor.c | 35 ---
1 file changed, 35 deletions(-)
diff --git a/monitor.c b/monitor.c
index 85484c3..bc7f3d3 100644
--- a/monitor.c
+++ b/monitor.c
@@ -22,64 +22,29 @@
* THE SOFTWARE.
*/
#include
-#include "hw/hw.h"
-#include
Also add sizeof variables for mon_cmd_t arrays for cross modules usage.
Signed-off-by: Benoit Canet
---
monitor-system.c | 984
monitor.c| 1010 ++
2 files changed, 1007 insertions(+
This patch add a -qmp parameter to the qemu-nbd command line in order to be able
to manipulate the qemu-nbd block devices via qmp.
This could be used with containers to easily migrate from qemu to a container.
Signed-off-by: Benoit Canet
---
Makefile.objs | 3 +-
include/moni
Hi,
Here are the follow up patches to the block QAPI extractions patches.
After this patchset the qemu-nbd command has a -qmp parameters allowing the user
to execute block related qmp commands.
Best regards
Benoît
Benoît Canet (24):
qmp: Extract system emulation related code from qmp.c into
Signed-off-by: Benoit Canet
---
monitor.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index d2e56f8..560d5e4 100644
--- a/monitor.c
+++ b/monitor.c
@@ -173,10 +173,10 @@ static QLIST_HEAD(mon_list, Monitor) mon_list;
static QLIST_HEAD(mo
Signed-off-by: Benoit Canet
---
monitor-system.c | 7 +++
monitor.c| 7 ---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
index d5abf73..9bbf128 100644
--- a/monitor-system.c
+++ b/monitor-system.c
@@ -2513,3 +2513,10 @@ void ne
Signed-off-by: Benoit Canet
---
monitor-system.c | 12
monitor.c| 12
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
index 2d49c76..9e9a4ac 100644
--- a/monitor-system.c
+++ b/monitor-system.c
@@ -1399,3 +1399
The move from monitor.c to monitor-system.c is done these functions no longer
needs to be public.
Signed-off-by: Benoit Canet
---
include/monitor/monitor-system.h | 46 ---
monitor-system.c | 95
2 files changed, 48 inserti
The functions made public are: help_cmd, do_help_cmd, do_trace_event_set_state
and do_trace_file.
Put the header declaration in monitor/monitor-system.h directly to avoid a
type conflict.
Signed-off-by: Benoit Canet
---
include/monitor/monitor-system.h | 4
monitor.c
This patch will allow to link qmp.o with utility binaries without dragging too
much unrelated object files and externals dependencies.
Signed-off-by: Benoit Canet
---
Makefile.objs | 2 +-
qmp-system.c | 376 ++
qmp.c | 361 +
The extracted function are help_cmd, do_help_cmd, do_trace_event_set_state,
and do_trace_file.
Signed-off-by: Benoit Canet
---
monitor-system.c | 121 +++
monitor.c| 121 ---
2 files c
Signed-off-by: Benoit Canet
---
monitor-system.c | 5 +
monitor.c| 5 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
index 25a132a..f5fb15a 100644
--- a/monitor-system.c
+++ b/monitor-system.c
@@ -231,3 +231,8 @@ void do_trace_
With this move the monitor.c/monitor-system.c split is complete.
Signed-off-by: Benoit Canet
---
monitor-system.c | 49 +
monitor.c| 49 -
2 files changed, 49 insertions(+), 49 deletions(-)
d
Signed-off-by: Benoit Canet
---
monitor-system.c | 69
monitor.c| 69
2 files changed, 69 insertions(+), 69 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
inde
Signed-off-by: Benoit Canet
---
include/monitor/monitor-system.h | 1 +
monitor.c| 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/monitor/monitor-system.h b/include/monitor/monitor-system.h
index 6cbf2a4..76d87c7 100644
--- a/include/monitor/mo
Signed-off-by: Benoit Canet
---
include/monitor/monitor-system.h | 1 +
monitor.c| 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/monitor/monitor-system.h b/include/monitor/monitor-system.h
index 2e98091..3bc7167 100644
--- a/include/monitor/mo
Signed-off-by: Benoit Canet
---
disas.c | 10 --
include/monitor/monitor.h | 2 ++
monitor.c | 4 ++--
3 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/disas.c b/disas.c
index 44a019a..b174f26 100644
--- a/disas.c
+++ b/disas.c
@@ -435,16
Compile and link QAPI block core code into qemu-nbd.
This patch circle around unwanted dependecies by stubing some functions in
the stubs directory.
Signed-off-by: Benoit Canet
---
Makefile| 33 +++--
Makefile.objs
This header will allow to split monitor in two parts.
Signed-off-by: Benoit Canet
---
include/monitor/monitor-system.h | 99
monitor.c| 57 ++-
2 files changed, 102 insertions(+), 54 deletions(-)
create mode 10
Next commits will split monitor.c in monitor.c and monitor-system.c.
Change some function from static to public in order to prepare this.
Signed-off-by: Benoit Canet
---
include/monitor/monitor.h | 10 ++
monitor.c | 24 ++--
2 files changed, 20 inser
Signed-off-by: Benoit Canet
---
monitor-system.c | 43 +++
monitor.c| 44
2 files changed, 43 insertions(+), 44 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
index 51ca21f..90758db 100644
On (Tue) 29 Jul 2014 [19:28:56], John Snow wrote:
> My previous commit, 713e8a10, did not address the fact that
> the error checking pathways do not attempt to call
> virtio_cleanup and thus can leak memory in hotplug scenarios.
>
> This patchset shuffles around the error checking so it does not
>
I choose b)
在2014年08月01 11时15分, "Gareth"写道:
Hi all
What does '-enable-kvm' option mean? I have heard two versions of answers:
a) guest OS would have /dev/kvm device and which could help vm in guest OS
(nested vm)
b) use /dev/kvm and intel-vt on host OS which could help vm run more fast
Hi Anshul,
Thanks for your test.
On 07/30/2014 10:31 PM, Anshul Makkar wrote:
> Hi,
>
> I am testing the cpu-hotunplug patches. I observed that after the
> deletion of the cpu with id = x, if I cpu-add the same cpu again id =
> x, then qemu exits with the error that file descriptor already exist
Why are you guys merging requests in qemu at all? Just submit them to the
kernel and let the kernel do it.
On Wed, Jul 30, 2014 at 1:11 AM, Stefan Hajnoczi wrote:
> On Tue, Jul 29, 2014 at 4:11 PM, Eric Blake wrote:
> > On 07/29/2014 06:41 AM, Stefan Hajnoczi wrote:
> >> This test case covers
Hi,
> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
> style
>
> Am 01.08.2014 05:32, schrieb Gonglei (Arei):
> > Hi,
> >
> >> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
> >> style
> >>
> >> On 07/31/2014 08:32 PM, are
Am 01.08.2014 05:32, schrieb Gonglei (Arei):
> Hi,
>
>> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
>> writing
>> style
>>
>> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
>>> From: Gonglei
>>>
>>> Signed-off-by: Gonglei
>>> ---
>>> hw/usb/dev-audio.c | 2
On Thu, Jul 31, 2014 at 5:38 PM, Paolo Bonzini wrote:
> Il 31/07/2014 04:07, Ming Lei ha scritto:
>> On Wed, Jul 30, 2014 at 9:51 PM, Paolo Bonzini wrote:
>>> Il 30/07/2014 13:39, Ming Lei ha scritto:
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index a60104c..94
Hi,
> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
> style
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Signed-off-by: Gonglei
> > ---
> > hw/usb/dev-audio.c | 2 +-
> > hw/usb/dev-mtp.c | 4 ++--
> > hw/usb/hcd-
Hi,
> Subject: Re: [PATCH v2 1/8] CODING_STYLE: Section about conditional
> statement
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Yoda conidtions lack of readability, and QEMU have a
>
> s/conidtions/conditions/
> s/of //
> s/have/has/
>
OK.
> > strict
On Fri, Aug 1, 2014 at 11:09 AM, Ming Lei wrote:
> On Thu, Jul 31, 2014 at 4:52 PM, Paolo Bonzini wrote:
>>
>> It doesn't matter, changing features between dataplane and non-dataplane
>> is not something that you can do.
>
> Actually it is easy to support multi virtqueue for non-dataplane,
> and
Hi,
> Subject: Re: [PATCH v2 for-2.2 0/8] about Yoda conditions
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual
Hi all
What does '-enable-kvm' option mean? I have heard two versions of answers:
a) guest OS would have /dev/kvm device and which could help vm in guest OS
(nested vm)
b) use /dev/kvm and intel-vt on host OS which could help vm run more fast
than pure emulator.
Thanks
--
Gareth
*Cloud Comput
No functional change except the variable name -- frequency has been modified
to period.
Signed-off-by: Sanidhya Kashyap
---
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi-schema.json | 12
qmp-commands.hx | 24 ++
The file not only extracts the bitmap from the file but also draws the figure
if required. Currently, figure is drawn for all the bitmaps. Later, I'll make
the change to draw for different blocks.
The picture is drawn by generating a matrix of 0s and 1s from the bitmap. The
dimensions are calculat
Signed-off-by: Sanidhya Kashyap
---
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 9 +
qmp-commands.hx | 20
savevm.c | 14 ++
6 files changed, 63 insertions(+)
diff --git a/hmp-co
No functional change except the variable name.
Signed-off-by: Sanidhya Kashyap
---
hmp-commands.hx | 2 ++
hmp.c| 19 +++
hmp.h| 1 +
monitor.c| 7 +++
qapi-schema.json | 28
qmp-commands.hx | 25 ++
In this patch, I have incorporated an enum named QemuProcess
which defines what kind of process is being executed i.e.
none --> no other process except the VM execution
migration --> migration is being executed
bitmap-dump --> bitmap dump process is undergoing
Besides this, I have tried to incorpo
I have modified the functions to be more generic i.e. I have used the
counter variable which stores the required value. If the value of counter
is 0, it means bitmap dump process whereas the value of 1 means migration.
Signed-off-by: Sanidhya Kashyap
---
arch_init.c | 21
Hi,
The following patches introduce the support of the dirty bitmap logging and
dumping to a specified file. This patch series addresses the previous issues
raised by David and Eric.
v4 --> v5
* Removed the runstates code (Eric's and David's advice).
* Now, using global variable to resolve the is
On Thu, Jul 31, 2014 at 4:52 PM, Paolo Bonzini wrote:
> Il 31/07/2014 05:47, Ming Lei ha scritto:
>> On Wed, Jul 30, 2014 at 11:25 PM, Paolo Bonzini wrote:
>>> Il 30/07/2014 17:12, Michael S. Tsirkin ha scritto:
>>
>> Dataplane must not be a change to the guest ABI. If you implement this
On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Signed-off-by: Gonglei
> ---
> hw/usb/dev-audio.c | 2 +-
> hw/usb/dev-mtp.c | 4 ++--
> hw/usb/hcd-ehci.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-a
On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Yoda conidtions lack of readability, and QEMU have a
s/conidtions/conditions/
s/of //
s/have/has/
> strict compiler configuration for checking a common
> mistake like "if (dev = NULL)". Make it a written rule.
>
> Signe
On Fri, Aug 1, 2014 at 12:30 AM, Paolo Bonzini wrote:
> Il 31/07/2014 18:13, Ming Lei ha scritto:
>> Follows 'perf report' result on cycles event for with/without bypass
>> coroutine:
>>
>> http://pastebin.com/ae0vnQ6V
>>
>> From the profiling result, looks bdrv_co_do_preadv() is a bit slow
>>
On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> $WHATEVER: don't use 'Yoda conditions'
>
> 'Yoda conditions' are not part of idiomatic QEMU coding
> style, so rewrite them in the more usual order.
>
> v2:
> - add more specific commit messages suggested by PMM, thanks
On 2014/7/31 23:47, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 08:10:53PM +0800, Chen, Tiejun wrote:
On 2014/7/31 18:12, Chen, Tiejun wrote:
On 2014/7/31 17:53, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote:
On 2014/7/31 17:10, Michael S. Tsirki
From: Gonglei
Signed-off-by: Gonglei
---
hw/isa/isa-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c
index b28981b..851f953 100644
--- a/hw/isa/isa-bus.c
+++ b/hw/isa/isa-bus.c
@@ -50,7 +50,7 @@ ISABus *isa_bus_new(DeviceState *dev, M
On 2014/7/31 23:44, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 06:12:32PM +0800, Chen, Tiejun wrote:
On 2014/7/31 17:53, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote:
On 2014/7/31 17:10, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 02:31:3
From: Gonglei
Signed-off-by: Gonglei
---
qdev-monitor.c | 2 +-
qemu-char.c | 2 +-
util/qemu-sockets.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index f87f3d8..3e30d38 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@
From: Gonglei
Signed-off-by: Gonglei
---
vl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index fe451aa..69f0f20 100644
--- a/vl.c
+++ b/vl.c
@@ -1136,7 +1136,7 @@ static int drive_init_func(QemuOpts *opts, void *opaque)
static int drive_enable_snapsh
From: Gonglei
Signed-off-by: Gonglei
---
hw/usb/dev-audio.c | 2 +-
hw/usb/dev-mtp.c | 4 ++--
hw/usb/hcd-ehci.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
index bfebfe9..988f6cc 100644
--- a/hw/usb/dev-audio.c
+++ b/hw/usb/
From: Gonglei
Yoda conidtions lack of readability, and QEMU have a
strict compiler configuration for checking a common
mistake like "if (dev = NULL)". Make it a written rule.
Signed-off-by: Gonglei
---
CODING_STYLE | 19 +++
1 file changed, 19 insertions(+)
diff --git a/CODING
From: Gonglei
Signed-off-by: Gonglei
---
ui/spice-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 7bb91e6..ff54dac 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -677,7 +677,7 @@ void qemu_spice_init(void)
if (
From: Gonglei
$WHATEVER: don't use 'Yoda conditions'
'Yoda conditions' are not part of idiomatic QEMU coding
style, so rewrite them in the more usual order.
v2:
- add more specific commit messages suggested by PMM, thanks.
- introduce section of conditional statement to CODING_STYLE.
Gongle
From: Gonglei
Signed-off-by: Gonglei
---
hw/net/vmxnet3.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 77bea6f..34c5aff 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1009,7 +1009,7 @@ vmxnet3_indicate_p
From: Gonglei
Signed-off-by: Gonglei
---
hw/audio/gus.c | 2 +-
hw/audio/hda-codec.c | 3 ++-
hw/audio/sb16.c | 6 +++---
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/hw/audio/gus.c b/hw/audio/gus.c
index bba6840..4a43ce7 100644
--- a/hw/audio/gus.c
+++ b/hw/audio/g
On Fri, 08/01 01:46, chen.fan.f...@cn.fujitsu.com wrote:
> Hi, I think this should be "视图".
>
Yes, I have already posted V2. Please review.
Thanks,
Fam
On Thu, 2014-07-31 at 10:44 +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
> ---
> po/zh_CN.po | 86
> +
> 1 file changed, 86 insertions(+)
> create mode 100644 po/zh_CN.po
>
> diff --git a/po/zh_CN.po b/po/zh_CN.po
> new file mo
Hi Alex,
2014-07-30 22:46 GMT+08:00 Alex Williamson :
> On Wed, 2014-07-30 at 22:16 +0800, Le Tan wrote:
>> Hi Michael,
>>
>> 2014-07-30 21:16 GMT+08:00 Michael S. Tsirkin :
>> > On Wed, Jul 30, 2014 at 08:24:04PM +0800, Le Tan wrote:
>> >> Hi,
>> >> I am testing vfio in L1 with my VT-d emulation
From: KONRAD Frederic
This adds cpu_icount_to_ns function which is needed for reverse execution.
It returns the time for a specific instruction.
Signed-off-by: KONRAD Frederic
Reviewed-by: Paolo Bonzini
---
cpus.c | 9 +++--
include/qemu/timer.h | 1 +
2 files changed, 8 in
From: KONRAD Frederic
Notify events on icount clock when CPU loop exits.
Signed-off-by: KONRAD Frederic
Reviewed-by: Paolo Bonzini
---
cpus.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/cpus.c b/cpus.c
index e8971e3..8bd3423 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1028,6 +1028,11 @@
From: KONRAD Frederic
This introduces a new timer based only on instruction counter and without any
compensation.
Signed-off-by: KONRAD Frederic
---
cpus.c | 21 +
include/qemu/timer.h | 9 -
qemu-timer.c | 8 +++-
stubs/cpu-get-ico
From: KONRAD Frederic
This makes qemu_savevm_state public for reverse-execution.
Signed-off-by: KONRAD Frederic
Reviewed-by: Amit Shah
Reviewed-by: Juan Quintela
---
include/sysemu/sysemu.h | 1 +
savevm.c| 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/i
From: KONRAD Frederic
This puts qemu_icount and qemu_icount_bias into TimerState structure to allow
them to be migrated.
Signed-off-by: KONRAD Frederic
Reviewed-by: Paolo Bonzini
---
cpus.c | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/cpu
From: KONRAD Frederic
This fixes a bug where qemu_icount and qemu_icount_bias are not migrated.
It adds a subsection "timer/icount" to vmstate_timers so icount is migrated only
when needed.
Signed-off-by: KONRAD Frederic
Reviewed-by: Amit Shah
Reviewed-by: Juan Quintela
---
cpus.c | 27 +
From: KONRAD Frederic
This takes icount clock in account for icount extra computation so icount
clock's timers will be triggered at the exact time.
Signed-off-by: KONRAD Frederic
Reviewed-by: Paolo Bonzini
---
cpus.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/cpus.c b/cpu
From: KONRAD Frederic
Those are some icount patches required for reverse execution.
It introduces an icount clock which is only growing with icount.
It allows QEMU to migrate icount so virtual clock is kept if the VM is migrated
in icount mode (which is mandatory for migration based snapshot).
On 07/31/2014 08:23 AM, Stefan Hajnoczi wrote:
On Mon, Jul 07, 2014 at 02:17:56PM -0400, John Snow wrote:
From: Paolo Bonzini
This will provide a hook for sending the result of the command via the
FIS receive area.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/core.c |
On 07/31/2014 06:58 AM, Stefan Hajnoczi wrote:
On Mon, Jul 07, 2014 at 02:17:44PM -0400, John Snow wrote:
+static void test_retry_flush(void)
+{
+uint8_t data;
+const char *s;
+
+prepare_blkdebug_script(debug_path, "flush_to_disk");
+
+ide_test_start(
+"-vnc none "
+
On 07/31/2014 06:13 AM, Stefan Hajnoczi wrote:
On Wed, Jul 30, 2014 at 06:28:28PM -0400, John Snow wrote:
+#define bitany(X, MASK) ((X) & (MASK))
+#define bitset(X, MASK) (bitany((X), (MASK)) == (MASK))
This is subjective but macros like this should be avoided. This macro does not
encapsulate
On 07/31/2014 10:01 AM, Stefan Hajnoczi wrote:
On Mon, Jul 07, 2014 at 02:18:07PM -0400, John Snow wrote:
+if (bitset(cap, AHCI_CAP_SAM)) {
+g_test_message("Supports AHCI-Only Mode: GHC_AE is Read-Only.");
+assert_bit_set(reg, AHCI_GHC_AE);
+} else {
+g_test_mess
I believe this bug may be breaking Salt by breaking ZeroMQ in certain
virtualized environments. Additional information here:
https://github.com/saltstack/salt/issues/12248
** Also affects: salt
Importance: Undecided
Status: New
--
You received this bug notification because you are a me
On Wed, Jul 30, 2014 at 3:51 AM, Fam Zheng wrote:
> On Mon, 07/07 10:54, Milos Vyletel wrote:
>> VMDK's streamOptimized format is different that regular sparse format.
>
> s/that/from/
>
>> L1(GD) and L2(GT) tables are not predefined but rather generated and
>> written during image creation mainly
I will update description in v2 with more info.
On Wed, Jul 30, 2014 at 4:09 AM, Stefan Hajnoczi wrote:
> On Tue, Jul 29, 2014 at 3:49 PM, Milos Vyletel
> wrote:
>> On Tue, Jul 29, 2014 at 10:37 AM, Stefan Hajnoczi wrote:
>>> On Tue, Jul 29, 2014 at 2:46 PM, Milos Vyletel
>>> wrote:
On
On 07/31/2014 09:19 AM, Stefan Hajnoczi wrote:
On Mon, Jul 07, 2014 at 02:18:05PM -0400, John Snow wrote:
+#ifdef AHCI_13_STRICT
Please drop the #ifdef. #ifdefs mean dead code that is not being
compiled or tested. Just decide which case we should take and keep that
one.
OK. It might be nice
** Changed in: qemu (Ubuntu)
Status: New => Confirmed
** Changed in: qemu (Ubuntu)
Importance: High => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1350435
Title:
tcg.c:1693: t
Il 31/07/2014 18:13, Ming Lei ha scritto:
> Follows 'perf report' result on cycles event for with/without bypass
> coroutine:
>
> http://pastebin.com/ae0vnQ6V
>
> From the profiling result, looks bdrv_co_do_preadv() is a bit slow
> without bypass coroutine.
Yeah, I can count at least 3.3% ti
Pavel Dovgalyuk writes:
> This patch adds instructions count fields to cpu structure and
> invents several functions for increasing this counter while executing
> translation blocks.
>
> @@ -1186,6 +1188,7 @@ void qemu_init_vcpu(CPUState *cpu)
> cpu->nr_cores = smp_cores;
> cpu->nr_thr
Il 31/07/2014 17:49, Pavel Dovgalyuk ha scritto:
> We cannot calculate timers in post_load, because it requires correct
> value of virtual clock. And at that moment replay data structures could
> be not loaded yet.
Then this patch (and similarly others in this early part of the series)
should be p
Pavel Dovgalyuk writes:
> This patch adds calls to update_fp_status() function from several
> places where FPU state is changed.
>
> Signed-off-by: Pavel Dovgalyuk
> ---
> target-i386/cpu.c|1 +
> target-i386/cpu.h|1 +
> target-i386/fpu_helper.c |5 -
> target-i
On Thu, Jul 31, 2014 at 5:15 PM, Paolo Bonzini wrote:
> Il 31/07/2014 10:59, Ming Lei ha scritto:
>>> > No guesses please. Actually that's also my guess, but since you are
>>> > submitting the patch you must do better and show profiles where stack
>>> > switching disappears after the patches.
>>
Pavel Dovgalyuk writes:
> MMU helper functions are called from generated code and other helper
> functions. In both cases they try to get function's return address for
> using it while restoring virtual CPU state.
>
> When MMU helper is called from some other helper function
> (like helper_maskmo
[meta-comment]
On 07/31/2014 09:49 AM, Pavel Dovgalyuk wrote:
> We cannot calculate timers in post_load, because it requires correct value of
> virtual clock. And at that moment replay data structures could be not loaded
> yet.
>
>
> Sent from mobile device
Your mobile device is breaking thre
We cannot calculate timers in post_load, because it requires correct value of
virtual clock. And at that moment replay data structures could be not loaded
yet.
Sent from mobile device
Исходное сообщение
От: Paolo Bonzini
Дата:31.07.2014 18:14 (GMT+04:00)
Кому: Pavel Do
On Thu, Jul 31, 2014 at 08:10:53PM +0800, Chen, Tiejun wrote:
> On 2014/7/31 18:12, Chen, Tiejun wrote:
> >On 2014/7/31 17:53, Michael S. Tsirkin wrote:
> >>On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote:
> >>>On 2014/7/31 17:10, Michael S. Tsirkin wrote:
> On Thu, Jul 31, 2014 at
On Thu, Jul 31, 2014 at 06:12:32PM +0800, Chen, Tiejun wrote:
> On 2014/7/31 17:53, Michael S. Tsirkin wrote:
> >On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote:
> >>On 2014/7/31 17:10, Michael S. Tsirkin wrote:
> >>>On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote:
> We
Il 31/07/2014 17:21, Pavel Dovgalyuk ha scritto:
> Pre load is necessary, because we switched off resetting VM while
> loading in the replay mode.
Then you should not add it now, but rather when you add replay. Treat
this part of the series as merely fixing migration bugs. In fact, I
suggest tha
I tried to separate all reverse execution code from deterministic replay.
I'll add the comment in the next version.
Sent from mobile device
Исходное сообщение
От: Eric Blake
Дата:31.07.2014 17:08 (GMT+04:00)
Кому: Pavel Dovgalyuk ,qemu-devel@nongnu.org
Копия:
peter.may
Pre load is necessary, because we switched off resetting VM while loading in
the replay mode. Calling reset handlers generates irqs, that make loading
process non-deterministic.
Sent from mobile device
Исходное сообщение
От: Paolo Bonzini
Дата:31.07.2014 17:01 (GMT+04:0
On Mon, Jul 07, 2014 at 02:18:09PM -0400, John Snow wrote:
> +free(d2h);
> +free(pio);
Should be g_free() since memory was allocated with g_malloc0().
pgpcuhKtk6RGI.pgp
Description: PGP signature
1 - 100 of 288 matches
Mail list logo
