Re: [Qemu-devel] [PATCH v3 for-2.2 0/8] don't use Yoda conditions

2014-08-06 Thread Markus Armbruster
Gonglei (Arei) arei.gong...@huawei.com writes: Hi, $WHATEVER: don't use 'Yoda conditions' 'Yoda conditions' are not part of idiomatic QEMU coding style, so rewrite them in the more usual order. OK but why stop at these files? How about this instead? I just search c files by

[Qemu-devel] [PATCH v2 2/4] monitor: fix access freed memory

2014-08-06 Thread zhanghailiang
The function monitor_fdset_dup_fd_find_remove() references member of 'mon_fdset' which may be freed in function monitor_fdset_cleanup() Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- monitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/monitor.c

[Qemu-devel] [PATCH v2 1/4] l2cap: fix access freed memory

2014-08-06 Thread zhanghailiang
Pointer 'ch' will be used in function 'l2cap_channel_open_req_msg' after it was previously freed in 'l2cap_channel_open'. Assigned it to NULL after it is freed. Reviewed-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- hw/bt/l2cap.c | 2 +- 1

[Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fstat()

2014-08-06 Thread zhanghailiang
The function fstat() may fail, so check its return value. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- hw/misc/ivshmem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 768e528..5d939d2 100644 ---

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-06 Thread Markus Armbruster
William Dauchy wdau...@gmail.com writes: On Tue, Aug 5, 2014 at 8:57 PM, Dr. David Alan Gilbert dgilb...@redhat.com wrote: Can you confirm this is on the final 2.1 release (there was a fix that went in just around rc5). for the receiver, I'm using 2.1 # qemu-system-x86_64 --version QEMU

[Qemu-devel] [PATCH v2 3/4] virtio-blk: fix reference a pointer which might be freed

2014-08-06 Thread zhanghailiang
In function virtio_blk_handle_request, it may freed memory pointed by req, So do not access member of req after calling this function. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- hw/block/virtio-blk.c | 5 +++-- 1 file changed,

Re: [Qemu-devel] [v3][PATCH 2/4] hw:i386:pc_piix: split pc_init1()

2014-08-06 Thread Chen, Tiejun
On 2014/8/4 21:48, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 08:09:32PM +0800, Tiejun Chen wrote: We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen tiejun.c...@intel.com With patch 1 in place, this should not be necessary - just

[Qemu-devel] [PATCH v2 0/4] fix several bugs about use-after-free and an api abuse

2014-08-06 Thread zhanghailiang
v1 - v2: -ivshmem: modified the log message according to reviewing suggestion of Michael zhanghailiang (4): l2cap: fix access freed memory monitor: fix access freed memory virtio-blk: fix reference a pointer which might be freed ivshmem: check the value returned by fstat()

Re: [Qemu-devel] [questions] about qemu log

2014-08-06 Thread Markus Armbruster
Zhang Haoyu zhan...@sangfor.com writes: The output is on qemu's stderr. You are in control of what that stderr is. I don't get why we can configure -D /path/to/unique/file/name.log but we also have to redirect stderr (I didn't checked if the daemonize option was closing it). What's the

Re: [Qemu-devel] [v3][PATCH 1/4] i440fx: make types configurable at run-time

2014-08-06 Thread Chen, Tiejun
On 2014/8/4 21:48, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 08:09:31PM +0800, Tiejun Chen wrote: Xen wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Tiejun Chen

Re: [Qemu-devel] [v3][PATCH 3/4] xen:hw:pci-host:piix: create host bridge to passthrough

2014-08-06 Thread Chen, Tiejun
On 2014/8/4 21:50, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 08:09:33PM +0800, Tiejun Chen wrote: Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. This is based on http://patchwork.ozlabs.org/patch/363810/. Signed-off-by: Tiejun Chen

Re: [Qemu-devel] [v3][PATCH 0/5] xen: introduce new machine for IGD passthrough

2014-08-06 Thread Chen, Tiejun
On 2014/8/4 21:51, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 08:09:30PM +0800, Tiejun Chen wrote: v3: * Drop patch #4 * Add one patch #1 from Michael * Rebase You added my patch but don't use it, so most of my comment weren't addressed. I guess I should cover those comments and

[Qemu-devel] [Bug 1353149] [NEW] qemu 2.1.0 fails to start if number of cores is greater than 1.

2014-08-06 Thread asavah
Public bug reported: qemu (kvm) 2.1.0 (built from sources) fails to start if number of cores is greater than 1. relevant part of commandline arguments: /usr/bin/qemu-system-x86_64 -name test3 -S -machine pc- i440fx-2.1,accel=kvm,usb=off -cpu Westmere -m 4096 -realtime mlock=off -smp

Re: [Qemu-devel] about -enable-kvm options

2014-08-06 Thread Gareth
Thanks Richard :) On Sat, Aug 2, 2014 at 4:47 AM, Richard W.M. Jones rjo...@redhat.com wrote: On Fri, Aug 01, 2014 at 11:15:29AM +0800, Gareth wrote: Hi all What does '-enable-kvm' option mean? I have heard two versions of answers: It's a shortcut for: $qemu -machine accel=kvm

[Qemu-devel] [v4][PATCH 1/5] i440fx: make types configurable at run-time

2014-08-06 Thread Tiejun Chen
From: Michael S. Tsirkin m...@redhat.com Xen wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Tiejun Chen tiejun.c...@intel.com --- hw/i386/pc_piix.c| 4 +++-

[Qemu-devel] [v4][PATCH 0/5] xen: introduce new machine for IGD passthrough

2014-08-06 Thread Tiejun Chen
v4: * Rebase on latest tree * Drop patch #2 * Regenerate patches after Michael introduce patch #1 * We need to use this pci_type as a index to reuse I440FX_PCI_DEVICE() * Test: boot with a preinstalled winxp ./i386-softmmu/qemu-system-i386 -hda winxp-32.img -m 2560 -boot c -machine pc v3: *

[Qemu-devel] [v4][PATCH 4/5] xen:hw:pci-host:piix: create host bridge to passthrough

2014-08-06 Thread Tiejun Chen
Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. This is based on http://patchwork.ozlabs.org/patch/363810/. Signed-off-by: Tiejun Chen tiejun.c...@intel.com --- hw/pci-host/piix.c | 39 +++

Re: [Qemu-devel] [PATCH v3 for-2.2 0/8] don't use Yoda conditions

2014-08-06 Thread Michael S. Tsirkin
On Tue, Aug 05, 2014 at 07:53:51PM -0600, Eric Blake wrote: On 08/05/2014 08:02 AM, Michael S. Tsirkin wrote: On Fri, Aug 01, 2014 at 03:46:08PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com $WHATEVER: don't use 'Yoda conditions' 'Yoda conditions' are not

Re: [Qemu-devel] [questions] about qemu log

2014-08-06 Thread Zhang Haoyu
The output is on qemu's stderr. You are in control of what that stderr is. I don't get why we can configure -D /path/to/unique/file/name.log but we also have to redirect stderr (I didn't checked if the daemonize option was closing it). What's the purpose of this logfile option? Well -D

Re: [Qemu-devel] [Bug 1353149] [NEW] qemu 2.1.0 fails to start if number of cores is greater than 1.

2014-08-06 Thread David Cruz
I can confirm this in Centos 7, also. Qemu 2.1.0 with latest libvirt. David Cruz 2014-08-06 0:12 GMT+02:00 asavah irher...@gmail.com: Public bug reported: qemu (kvm) 2.1.0 (built from sources) fails to start if number of cores is greater than 1. relevant part of commandline arguments:

Re: [Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of all active devices

2014-08-06 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: On (Mon) 04 Aug 2014 [13:33:56], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: To ensure two virtserialports don't get added to the system with the same 'name' parameter, we need to access all the ports on all the devices added,

Re: [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name

2014-08-06 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: Hi, The 2nd patch prevents adding ports to the system with conflicts in the 'name' parameter. This is done by going through all the ports in the system, including ports on other virtio-serial devices. The first patch prepares for this by creating a

[Qemu-devel] [Bug 1353149] Re: qemu 2.1.0 fails to start if number of cores is greater than 1.

2014-08-06 Thread Andrey Korolyov
-smp 1,maxcpus=4,sockets=1,cores=4,threads=1 should be -smp 4,maxcpus=4,sockets=1,cores=4,threads=1 although more human-friendly error is more appropriate there (better than a silent fallback to either 1- or 4- core topology) -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of all active devices

2014-08-06 Thread Amit Shah
On (Wed) 06 Aug 2014 [09:27:02], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: On (Mon) 04 Aug 2014 [13:33:56], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: To ensure two virtserialports don't get added to the system with the same 'name'

Re: [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name

2014-08-06 Thread Amit Shah
On (Wed) 06 Aug 2014 [09:27:04], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: Hi, The 2nd patch prevents adding ports to the system with conflicts in the 'name' parameter. This is done by going through all the ports in the system, including ports on other

Re: [Qemu-devel] [questions] about qemu log

2014-08-06 Thread Markus Armbruster
Zhang Haoyu zhan...@sangfor.com writes: The output is on qemu's stderr. You are in control of what that stderr is. I don't get why we can configure -D /path/to/unique/file/name.log but we also have to redirect stderr (I didn't checked if the daemonize option was closing it). What's the

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-06 Thread Paolo Bonzini
Il 05/08/2014 20:57, Dr. David Alan Gilbert ha scritto: (CC Paolo) * William Dauchy (wdau...@gmail.com) wrote: Hello, For a qemu live migration from 2.0 to 2.1 I'm getting: qemu-system-x86_64: Length mismatch: /rom@etc/acpi/tables: 3000 in != 2 qemu-system-x86_64: Unknown ramblock

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-06 Thread Paolo Bonzini
Il 06/08/2014 08:16, Markus Armbruster ha scritto: for the receiver, I'm using 2.1 # qemu-system-x86_64 --version QEMU emulator version 2.1.0, Copyright (c) 2003-2008 Fabrice Bellar for the sender side, here is the qmp result: (QEMU) query-version { u'return': { u'package': u'',

Re: [Qemu-devel] [PATCH v3 for-2.2 0/8] don't use Yoda conditions

2014-08-06 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Aug 06, 2014 at 08:05:46AM +0200, Markus Armbruster wrote: Gonglei (Arei) arei.gong...@huawei.com writes: Hi, $WHATEVER: don't use 'Yoda conditions' 'Yoda conditions' are not part of idiomatic QEMU coding style, so rewrite

[Qemu-devel] [PATCH] linux-user: redirect openat calls

2014-08-06 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org While Mikhail fixed /proc/self/maps, it was noticed openat calls are not redirected currently. Some archs don't have open at all, so openat needs to be redirected. Fix this by consolidating open/openat code to do_openat - open is implemented using

Re: [Qemu-devel] [PATCH] linux-user: /proc/self/maps content

2014-08-06 Thread Riku Voipio
On Tue, Aug 05, 2014 at 05:24:27PM +0400, Mikhail Ilin wrote: I've tested the sample for Aarch64 myself and found that the approach should also work fine. Translation layout: $ qemu-aarch64 -strace /tmp/busybox-static cat /proc/self/maps startend size

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Ming Lei
On Wed, Aug 6, 2014 at 3:45 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 06/08/2014 07:33, Ming Lei ha scritto: I played a bit with the following, I hope it's not too naive. I couldn't see a difference with your patches, but at least one reason for this is probably that my laptop SSD

[Qemu-devel] [Bug 1353346] [NEW] ARMv7-M software-triggered interrupts-- unexpected behaviour

2014-08-06 Thread Boris Feigin
Public bug reported: The handling of the NVIC Software Triggered Interrupt Register in qemu-2.1.0/hw/intc/armv7m_nvic.c:375 isn't quite right. As things stand, writing a zero to the STIR ends up transferring control to vector table entry zero, which, on ARMv7-M, holds the reset value of the

Re: [Qemu-devel] [RFC PATCH v2 09/10] virtio-scsi-dataplane: Code to run virtio-scsi on iothread

2014-08-06 Thread Paolo Bonzini
Il 06/08/2014 07:35, Fam Zheng ha scritto: ifeq ($(CONFIG_VIRTIO),y) -obj-y += virtio-scsi.o +obj-y += virtio-scsi.o virtio-scsi-dataplane.o obj-$(CONFIG_VHOST_SCSI) += vhost-scsi.o endif I first thought that this must be conditional on CONFIG_VIRTIO_BLK_DATA_PLANE. However,

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Kevin Wolf
Am 06.08.2014 um 07:33 hat Ming Lei geschrieben: Hi Kevin, On Tue, Aug 5, 2014 at 10:47 PM, Kevin Wolf kw...@redhat.com wrote: Am 05.08.2014 um 15:48 hat Stefan Hajnoczi geschrieben: I have been wondering how to prove that the root cause is the ucontext coroutine mechanism (stack

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Paolo Bonzini
Il 06/08/2014 10:38, Ming Lei ha scritto: On Wed, Aug 6, 2014 at 3:45 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 06/08/2014 07:33, Ming Lei ha scritto: I played a bit with the following, I hope it's not too naive. I couldn't see a difference with your patches, but at least one reason for

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-06 Thread William Dauchy
On Wed, Aug 6, 2014 at 9:47 AM, Paolo Bonzini pbonz...@redhat.com wrote: I suspect he's using -M pc on both. Is it the default value? because it's not the case in my command line. You must use -M pc-i440fx-2.0 on both if you're migrating from 2.0 to a different version. wow. I wasn't

Re: [Qemu-devel] [RFC PATCH v2 09/10] virtio-scsi-dataplane: Code to run virtio-scsi on iothread

2014-08-06 Thread Fam Zheng
On Wed, 08/06 10:45, Paolo Bonzini wrote: Il 06/08/2014 07:35, Fam Zheng ha scritto: ifeq ($(CONFIG_VIRTIO),y) -obj-y += virtio-scsi.o +obj-y += virtio-scsi.o virtio-scsi-dataplane.o obj-$(CONFIG_VHOST_SCSI) += vhost-scsi.o endif I first thought that this must be conditional on

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-08-06 Thread Kevin Wolf
Am 05.08.2014 um 23:14 hat John Snow geschrieben: On 08/05/2014 04:30 AM, Kevin Wolf wrote: Am 01.08.2014 um 22:10 hat John Snow geschrieben: On 06/12/2014 05:03 AM, Markus Armbruster wrote: -drive mixes up configuration of backend and frontend (a.k.a. device model), as follows: 1.

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-06 Thread William Dauchy
On Wed, Aug 6, 2014 at 9:49 AM, Paolo Bonzini pbonz...@redhat.com wrote: This is a development version between 2.0.0 and 2.0.0-rc1; it may have bugs such as the one that was fixed in 2.0.0-rc5. you mean 2.1.0-rc5 Migration from development versions is not supported. You must either upgrade

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-06 Thread Dr. David Alan Gilbert
* William Dauchy (wdau...@gmail.com) wrote: On Wed, Aug 6, 2014 at 9:47 AM, Paolo Bonzini pbonz...@redhat.com wrote: I suspect he's using -M pc on both. Is it the default value? because it's not the case in my command line. You must use -M pc-i440fx-2.0 on both if you're migrating from

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-06 Thread William Dauchy
On Wed, Aug 6, 2014 at 11:17 AM, Dr. David Alan Gilbert dgilb...@redhat.com wrote: The trick is to pick a -M value and stick with it; then you should be able to keep migrating to newer QEMU versions easily (just don't go with dev versions because things are often broken in them). ok for dev

[Qemu-devel] [PATCH] test-coroutine: add baseline test that times the cost of function calls

2014-08-06 Thread Paolo Bonzini
This can be used to compute the cost of coroutine operations. In the end the cost of the function call is a few clock cycles, so it's pretty cheap for now, but it may become more relevant as the coroutine code is optimized. For example, here are the results on my machine: Function call

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Ming Lei
On Wed, Aug 6, 2014 at 4:48 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.08.2014 um 07:33 hat Ming Lei geschrieben: Hi Kevin, On Tue, Aug 5, 2014 at 10:47 PM, Kevin Wolf kw...@redhat.com wrote: Am 05.08.2014 um 15:48 hat Stefan Hajnoczi geschrieben: I have been wondering how to prove that

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 01:33:36PM +0800, Ming Lei wrote: With coroutine, the running time for same loading is increased ~50%(1.325s vs. 0.903s), and dcache load events is increased I agree with Paolo about microbenchmarks. We need to do I/O to get a realistic picture of performance, since

[Qemu-devel] [Bug 1353149] Re: qemu 2.1.0 fails to start if number of cores is greater than 1.

2014-08-06 Thread asavah
I forgot to mention that VM was created and managed remotely via virt-manager 0.9.5 from another host. I used custom cpu topology. however this config worked fine on qemu 2.0.0 with virt-manager 0.9.5 just tried virt-manager 1.0.1 - it creates the proper argument -smp

Re: [Qemu-devel] [v4][PATCH 4/5] xen:hw:pci-host:piix: create host bridge to passthrough

2014-08-06 Thread Michael S. Tsirkin
On Wed, Aug 06, 2014 at 02:50:34PM +0800, Tiejun Chen wrote: Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. This is based on http://patchwork.ozlabs.org/patch/363810/. Signed-off-by: Tiejun Chen tiejun.c...@intel.com ---

Re: [Qemu-devel] [PATCH v2 00/30] AHCI test suite framework

2014-08-06 Thread Stefan Hajnoczi
On Mon, Aug 04, 2014 at 05:11:01PM -0400, John Snow wrote: This patch series introduces a number of small fixes and tweaks to help support an AHCI test suite that in the future I hope to expand to a fuller regression suite to help guide the development of the AHCI device support under, in

Re: [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index

2014-08-06 Thread Michael S. Tsirkin
On Wed, Aug 06, 2014 at 02:50:33PM +0800, Tiejun Chen wrote: We need to use this index to reuse this macro later Signed-off-by: Tiejun Chen tiejun.c...@intel.com Which index? Most users don't need to change. Just open-code OBJECT_CHECK where necessary, or add a new wrapper. ---

Re: [Qemu-devel] [v4][PATCH 4/5] xen:hw:pci-host:piix: create host bridge to passthrough

2014-08-06 Thread Chen, Tiejun
On 2014/8/6 17:42, Michael S. Tsirkin wrote: On Wed, Aug 06, 2014 at 02:50:34PM +0800, Tiejun Chen wrote: Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. This is based on http://patchwork.ozlabs.org/patch/363810/. Signed-off-by: Tiejun Chen

[Qemu-devel] [PATCH v3] po: Add Chinese translation

2014-08-06 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Amos Kong ak...@redhat.com Reviewed-by: Dongsheng Song songdongsh...@live.cn Reviewed-by: Wei Huang wehu...@redhat.com --- v3: Add a missing space for msgid - Press Ctrl+Alt+G to release grab As pointed out by Amos. Meanwhile

Re: [Qemu-devel] [questions] about KVM asaMicrosoft-compatiblehypervisor

2014-08-06 Thread Vadim Rozenfeld
On Mon, 2014-08-04 at 14:29 +0800, Zhang Haoyu wrote: Hi Zhang, No I haven't seen such problem Which kernel version are you running? Host kernel: RHEL7-RC1(linux-3.10.0). Does it include the latest lazy eli changes? lazy eli or lazy eoi? EOI How to confirm whether lazy eli has been

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Kevin Wolf
Am 06.08.2014 um 11:37 hat Ming Lei geschrieben: On Wed, Aug 6, 2014 at 4:48 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.08.2014 um 07:33 hat Ming Lei geschrieben: Hi Kevin, On Tue, Aug 5, 2014 at 10:47 PM, Kevin Wolf kw...@redhat.com wrote: Am 05.08.2014 um 15:48 hat Stefan Hajnoczi

Re: [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index

2014-08-06 Thread Chen, Tiejun
On 2014/8/6 17:45, Michael S. Tsirkin wrote: On Wed, Aug 06, 2014 at 02:50:33PM +0800, Tiejun Chen wrote: We need to use this index to reuse this macro later Signed-off-by: Tiejun Chen tiejun.c...@intel.com Which index? Most users don't need to change. Just open-code OBJECT_CHECK where

Re: [Qemu-devel] [edk2] license for binary drivers

2014-08-06 Thread Laszlo Ersek
On 08/06/14 09:40, Reza Jelveh wrote: Hello, EDK2 integrates FAT as a binary driver. What is the license of the FAT driver? https://svn.code.sf.net/p/edk2/code/trunk/edk2/FatBinPkg/License.txt What are the guidelines for use of binary drivers with EDK2? Specifically if you want to bundle

Re: [Qemu-devel] [questions] about qemu log

2014-08-06 Thread William Dauchy
On Wed, Aug 6, 2014 at 12:40 AM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Well -D will log to file only loggable (i.e. qemu_log()) information (which has all sorts of options and switches). Stderr, is a little more static and should in theory be limited to genuine errors. But if

Re: [Qemu-devel] [PATCH RFC v2 01/12] QEMUSizedBuffer/QEMUFile

2014-08-06 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Stefan Berger's to create a QEMUFile that goes to a memory buffer; Missing something. Maybe you meant: This is based on Stefan Berger's patch to

[Qemu-devel] QEMU with KVM does not start Win8 on kernel 3.4.67 and core2duo

2014-08-06 Thread Erik Rull
Hi all, I did already several tests and I'm not completely sure what's going wrong, but here my scenario: When I start up QEMU w/ KVM 1.7.0 on a Core2Duo machine running a vanilla kernel 3.4.67 to run a Windows 8.0 guest, the guest freezes at boot without any error. When I dump the CPU registers

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Ming Lei
On Wed, Aug 6, 2014 at 6:09 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.08.2014 um 11:37 hat Ming Lei geschrieben: On Wed, Aug 6, 2014 at 4:48 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.08.2014 um 07:33 hat Ming Lei geschrieben: Hi Kevin, On Tue, Aug 5, 2014 at 10:47 PM, Kevin Wolf

Re: [Qemu-devel] [PATCH v2 00/30] AHCI test suite framework

2014-08-06 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: On Mon, Aug 04, 2014 at 05:11:01PM -0400, John Snow wrote: This patch series introduces a number of small fixes and tweaks to help support an AHCI test suite that in the future I hope to expand to a fuller regression suite to help guide the

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Ming Lei
On Wed, Aug 6, 2014 at 7:28 PM, Ming Lei ming@canonical.com wrote: On Wed, Aug 6, 2014 at 6:09 PM, Kevin Wolf kw...@redhat.com wrote: I use the /dev/nullb0 block device to test, which is available in linux kernel 3.13+, and follows the difference, which looks not very big( 10%): And I

Re: [Qemu-devel] [questions] about qemu log

2014-08-06 Thread Peter Crosthwaite
On Wed, Aug 6, 2014 at 5:42 PM, Markus Armbruster arm...@redhat.com wrote: Zhang Haoyu zhan...@sangfor.com writes: The output is on qemu's stderr. You are in control of what that stderr is. I don't get why we can configure -D /path/to/unique/file/name.log but we also have to redirect

Re: [Qemu-devel] [PATCH v5 1/6] exec: add parameter errp to qemu_ram_alloc and qemu_ram_alloc_from_ptr

2014-08-06 Thread Peter Crosthwaite
On Wed, Aug 6, 2014 at 3:36 PM, Hu Tao hu...@cn.fujitsu.com wrote: Add parameter errp to qemu_ram_alloc and qemu_ram_alloc_from_ptr so that we can handler errors. handle Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- exec.c | 32 +++-

Re: [Qemu-devel] [PATCH v5 2/6] memory: add parameter errp to memory_region_init_ram

2014-08-06 Thread Peter Crosthwaite
On Wed, Aug 6, 2014 at 3:36 PM, Hu Tao hu...@cn.fujitsu.com wrote: Add parameter errp to memory_region_init_ram and update all call sites to pass in error_abort. Signed-off-by: Hu Tao hu...@cn.fujitsu.com Liking it. Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com ---

Re: [Qemu-devel] [PATCH v5 3/6] memory: add parameter errp to memory_region_init_ram_ptr

2014-08-06 Thread Peter Crosthwaite
On Wed, Aug 6, 2014 at 3:36 PM, Hu Tao hu...@cn.fujitsu.com wrote: Add parameter errp to memory_region_init_ram_ptr and update all call sites to pass in error_abort. Signed-off-by: Hu Tao hu...@cn.fujitsu.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com ---

[Qemu-devel] [Bug 1353456] [NEW] qemu-io: Failure on a qcow2 image with the fuzzed refcount table

2014-08-06 Thread Maria Kustova
Public bug reported: 'qemu-io -c write' and 'qemu-io -c aio_write' crashes on a qcow2 image with a fuzzed refcount table. Sequence: 1. Unpack the attached archive, make a copy of test.img 2. Put copy.img and backing_img.file in the same directory 3. Execute qemu-io copy.img -c write

Re: [Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fstat()

2014-08-06 Thread Levente Kurusa
The function fstat() may fail, so check its return value. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- hw/misc/ivshmem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 768e528..5d939d2 100644 ---

Re: [Qemu-devel] [PATCH v5 4/6] memory: add parameter errp to memory_region_init_rom_device

2014-08-06 Thread Peter Crosthwaite
On Wed, Aug 6, 2014 at 3:36 PM, Hu Tao hu...@cn.fujitsu.com wrote: Add parameter errp to memory_region_init_rom_device and update all call sites to pass in error_abort. Signed-off-by: Hu Tao hu...@cn.fujitsu.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com ---

Re: [Qemu-devel] [PATCH v5 5/6] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big

2014-08-06 Thread Peter Crosthwaite
On Wed, Aug 6, 2014 at 3:36 PM, Hu Tao hu...@cn.fujitsu.com wrote: When using monitor command object_add to add a memory backend whose size is way too big to allocate memory for it, qemu just exits. In the case we'd better give an error message and keep guest running. The problem can be

Re: [Qemu-devel] [PATCH v5 6/6] exec: improve error handling and reporting in file_ram_alloc() and gethugepagesize()

2014-08-06 Thread Peter Crosthwaite
You subject line is excessively long. How about just improve RAM file error handling and elaborate in a commit msg para? On Wed, Aug 6, 2014 at 3:36 PM, Hu Tao hu...@cn.fujitsu.com wrote: This patch fixes two problems of memory-backend-file: It looks like two self contained changes. Any reason

[Qemu-devel] [PATCH V5 0/5] tests: Add the image fuzzer with qcow2 support

2014-08-06 Thread Maria Kustova
This patch series introduces the image fuzzer, a tool for stability and reliability testing. Its approach is to run large amount of tests in background. During every test a program (e.g. qemu-img) is called to read or modify an invalid test image. A test image has valid inner structure defined by

[Qemu-devel] [PATCH V5 5/5] package: Public API for image-fuzzer/runner/runner.py

2014-08-06 Thread Maria Kustova
__init__.py provides the public API required by the test runner Signed-off-by: Maria Kustova mari...@catit.be --- tests/image-fuzzer/qcow2/__init__.py | 1 + 1 file changed, 1 insertion(+) create mode 100644 tests/image-fuzzer/qcow2/__init__.py diff --git a/tests/image-fuzzer/qcow2/__init__.py

[Qemu-devel] [PATCH V5 1/5] docs: Specification for the image fuzzer

2014-08-06 Thread Maria Kustova
'Overall fuzzer requirements' chapter contains the current product vision and features done and to be done. This chapter is still in progress. Signed-off-by: Maria Kustova mari...@catit.be --- tests/image-fuzzer/docs/image-fuzzer.txt | 239 +++ 1 file changed, 239

[Qemu-devel] [PATCH V5 4/5] layout: Generator of fuzzed qcow2 images

2014-08-06 Thread Maria Kustova
The layout submodule of the qcow2 package creates a random valid image, randomly selects some amount of its fields, fuzzes them and write the fuzzed image to the file. Fuzzing process can be controlled by an external configuration. Signed-off-by: Maria Kustova mari...@catit.be ---

[Qemu-devel] [PATCH V5 2/5] runner: Tool for fuzz tests execution

2014-08-06 Thread Maria Kustova
The purpose of the test runner is to prepare the test environment (e.g. create a work directory, a test image, etc), execute a program under test with parameters, indicate a test failure if the program was killed during the test execution and collect core dumps, logs and other test artifacts. The

[Qemu-devel] [PATCH V5 3/5] fuzz: Fuzzing functions for qcow2 images

2014-08-06 Thread Maria Kustova
The fuzz submodule of the qcow2 image generator contains fuzzing functions for image fields. Each fuzzing function contains a list of constraints and a call of a helper function that randomly selects a fuzzed value satisfied to one of constraints. For now constraints include only known as invalid

Re: [Qemu-devel] [edk2] license for binary drivers

2014-08-06 Thread Paolo Bonzini
Il 06/08/2014 12:34, Laszlo Ersek ha scritto: So no, you can't ship an OVMF binary (or source tarball) that contains the FAT driver, bundled as part of the GPLv2 (+compatible) QEMU distribution, either in source or in binary form. What Laszlo said is mostly my understanding too (IANAL etc.).

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Ming Lei
On Wed, Aug 6, 2014 at 4:50 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 06/08/2014 10:38, Ming Lei ha scritto: On Wed, Aug 6, 2014 at 3:45 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 06/08/2014 07:33, Ming Lei ha scritto: I played a bit with the following, I hope it's not too naive. I

[Qemu-devel] [PATCH V2 0/3] image-fuzzer: Support L1/L2 tables in the qcow2 image generator

2014-08-06 Thread Maria Kustova
This patch series adds support of L1/L2 tables to the qcow2 image generator. This patch series was created for the 'block-next' branch and based on the next series: [PATCH V5 0/5] tests: Add the image fuzzer with qcow2 support. v1 - v2: * Rebased to the new version of the parent

[Qemu-devel] [PATCH V2 1/3] docs: Expand the list of supported image elements with L1/L2 tables

2014-08-06 Thread Maria Kustova
Signed-off-by: Maria Kustova mari...@catit.be --- tests/image-fuzzer/docs/image-fuzzer.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/image-fuzzer/docs/image-fuzzer.txt b/tests/image-fuzzer/docs/image-fuzzer.txt index efe0ed4..2e8e3b9 100644 ---

[Qemu-devel] [PATCH V2 3/3] layout: Add generators of L1/L2 tables

2014-08-06 Thread Maria Kustova
Valid L2 entries contain offsets to image clusters filled with random data. L2 entries have random positions inside L2 tables. L1 entries contain offsets to generated L2 tables and also have random positions inside the L1 table. Clusters for L1/L2 tables and guest data are selected randomly.

[Qemu-devel] [PATCH V2 2/3] fuzz: Add fuzzing functions for L1/L2 table entries

2014-08-06 Thread Maria Kustova
Signed-off-by: Maria Kustova mari...@catit.be --- tests/image-fuzzer/qcow2/fuzz.py | 28 1 file changed, 28 insertions(+) diff --git a/tests/image-fuzzer/qcow2/fuzz.py b/tests/image-fuzzer/qcow2/fuzz.py index a53c84f..57527f9 100644 ---

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-06 Thread Kevin Wolf
Am 06.08.2014 um 13:28 hat Ming Lei geschrieben: On Wed, Aug 6, 2014 at 6:09 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.08.2014 um 11:37 hat Ming Lei geschrieben: On Wed, Aug 6, 2014 at 4:48 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.08.2014 um 07:33 hat Ming Lei geschrieben: Hi

[Qemu-devel] [PATCH] layout: Reduce number of generator functions in __init__

2014-08-06 Thread Maria Kustova
Some issues can be found only when a fuzzed image has a partial structure, e.g. has L1/L2 tables but no refcount ones. Generation of an entirely defined image limits these cases. Now the Image constructor creates only a header and a backing file name (if any), other image elements are generated in

Re: [Qemu-devel] [PATCH v2 1/2] hw/misc/arm_sp810: Create SP810 device

2014-08-06 Thread Aggeler Fabian
On 06 Aug 2014, at 01:03, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Tue, Aug 5, 2014 at 7:32 PM, Fabian Aggeler aggel...@ethz.ch wrote: This adds a device model for the PrimeXsys System Controller (SP810) which is present in the Versatile Express motherboards. It is so far

[Qemu-devel] [Bug 1285708] Re: FreeBSD Guest crash on boot due to xsave instruction issue

2014-08-06 Thread Chris J Arges
** Changed in: linux (Ubuntu Precise) Status: New = Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1285708 Title: FreeBSD Guest crash on boot due to xsave instruction issue Status

[Qemu-devel] [PULL 02/11] icount: put icount variables into TimerState.

2014-08-06 Thread Paolo Bonzini
From: KONRAD Frederic fred.kon...@greensocs.com This puts qemu_icount and qemu_icount_bias into TimerState structure to allow them to be migrated. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 00/11] KVM, icount changes for 2014-08-06

2014-08-06 Thread Paolo Bonzini
The following changes since commit 41a1a9c42c4e0fb5f1b94aa8b72e42f66ebde3d9: po: Update German translation (2014-07-28 23:37:17 +0200) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

[Qemu-devel] [PULL 03/11] migration: migrate icount fields.

2014-08-06 Thread Paolo Bonzini
From: KONRAD Frederic fred.kon...@greensocs.com This fixes a bug where qemu_icount and qemu_icount_bias are not migrated. It adds a subsection timer/icount to vmstate_timers so icount is migrated only when needed. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Amit Shah

[Qemu-devel] [PULL 08/11] cpu-exec: Add sleeping algorithm

2014-08-06 Thread Paolo Bonzini
From: Sebastian Tanase sebastian.tan...@openwide.fr The goal is to sleep qemu whenever the guest clock is in advance compared to the host clock (we use the monotonic clocks). The amount of time to sleep is calculated in the execution loop in cpu_exec. At first, we tried to approximate at each

[Qemu-devel] [PULL 05/11] icount: Fix virtual clock start value on ARM

2014-08-06 Thread Paolo Bonzini
From: Sebastian Tanase sebastian.tan...@openwide.fr When using the icount option on ARM, the virtual clock starts counting at realtime clock but it should start at 0. The reason why the virtual clock starts at realtime clock is because the first time we call qemu_clock_warp (which calls

[Qemu-devel] [PULL 04/11] timer: add cpu_icount_to_ns function.

2014-08-06 Thread Paolo Bonzini
From: KONRAD Frederic fred.kon...@greensocs.com This adds cpu_icount_to_ns function which is needed for reverse execution. It returns the time for a specific instruction. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo

[Qemu-devel] [PULL 06/11] icount: Add QemuOpts for icount

2014-08-06 Thread Paolo Bonzini
From: Sebastian Tanase sebastian.tan...@openwide.fr Make icount parameter use QemuOpts style options in order to easily add other suboptions. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille Bégué camille.be...@openwide.fr Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 09/11] cpu-exec: Print to console if the guest is late

2014-08-06 Thread Paolo Bonzini
From: Sebastian Tanase sebastian.tan...@openwide.fr If the align option is enabled, we print to the user whenever the guest clock is behind the host clock in order for he/she to have a hint about the actual performance. The maximum print interval is 2s and we limit the number of messages to 100.

[Qemu-devel] [PULL 01/11] backends: Introduce chr-testdev

2014-08-06 Thread Paolo Bonzini
From: Paolo Bonzini pbonz...@redhat.com chr-testdev enables a virtio serial channel to be used for guest initiated qemu exits. hw/misc/debugexit already enables guest initiated qemu exits, but only for PC targets. chr-testdev supports any virtio-capable target. kvm-unit-tests/arm is already

[Qemu-devel] [PULL 07/11] icount: Add align option to icount

2014-08-06 Thread Paolo Bonzini
From: Sebastian Tanase sebastian.tan...@openwide.fr The align option is used for activating the align algorithm in order to synchronise the host clock and the guest clock. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille Bégué camille.be...@openwide.fr

[Qemu-devel] [PULL 11/11] target-mips: Ignore unassigned accesses with KVM

2014-08-06 Thread Paolo Bonzini
From: James Hogan james.ho...@imgtec.com MIPS registers an unassigned access handler which raises a guest bus error exception. However this causes QEMU to crash when KVM is enabled as it isn't called from the main execution loop so longjmp() gets called without a corresponding setjmp(). Until

[Qemu-devel] [PULL 10/11] monitor: Add drift info to 'info jit'

2014-08-06 Thread Paolo Bonzini
From: Sebastian Tanase sebastian.tan...@openwide.fr Show in 'info jit' the current delay between the host clock and the guest clock. In addition, print the maximum advance and delay of the guest compared to the host. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille

[Qemu-devel] [Bug 1285708] Re: FreeBSD Guest crash on boot due to xsave instruction issue

2014-08-06 Thread Paolo Bonzini
You don't need +xsave, -cpu host just works. The bug is invalid. You are requesting a CPU that doesn't exist (a core2duo that supports XSAVE), and the guest's behavior is probably not going to be well defined. ** Changed in: qemu Status: New = Invalid -- You received this bug

Re: [Qemu-devel] [PATCH v2] vmdk: improve streamOptimized vmdk support

2014-08-06 Thread Milos Vyletel
On Tue, Aug 5, 2014 at 9:44 PM, Fam Zheng f...@redhat.com wrote: On Tue, 08/05 12:44, Milos Vyletel wrote: On Tue, Aug 5, 2014 at 1:27 AM, Fam Zheng f...@redhat.com wrote: Does putting a monolithicSparse into the OVA work in this case? It does not. I did not try to import it to OVM but ESXi

  1   2   3   >