Re: [Qemu-devel] [PATCH 1/9] l2tpv3: fix fd leak

2014-11-18 Thread Gonglei
On 2014/11/18 15:50, Markus Armbruster wrote: Michael Tokarev m...@tls.msk.ru writes: 15.11.2014 13:06, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com In this false branch, fd will leak when it is zero. Change the testing condition. Why fd==0 is a concern here? It

Re: [Qemu-devel] [RFC][PATCH v2] block: add write threshold reporting for block devices

2014-11-18 Thread Francesco Romani
- Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Francesco Romani from...@redhat.com Cc: kw...@redhat.com, lcapitul...@redhat.com, qemu-devel@nongnu.org, stefa...@redhat.com, mdr...@linux.vnet.ibm.com Sent: Monday, November 17, 2014 5:49:36 PM Subject: Re:

Re: [Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ?

2014-11-18 Thread Amit Shah
On (Mon) 17 Nov 2014 [17:15:03], dcb wrote: Public bug reported: hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!vrng-conf.period_ms 0) { error_setg(errp, 'period' parameter expects a

Re: [Qemu-devel] [PATCH v3 for-2.2 3/3] raw-posix: The SEEK_HOLE code is flawed, rewrite it

2014-11-18 Thread Max Reitz
On 2014-11-17 at 17:43, Eric Blake wrote: On 11/17/2014 03:18 AM, Markus Armbruster wrote: On systems where SEEK_HOLE in a trailing hole seeks to EOF (Solaris, but not Linux), try_seek_hole() reports trailing data instead. Maybe worth a comment that this is not fatal, but also not optimal.

Re: [Qemu-devel] [PATCH v3 for-2.2 0/3] raw-posix: Get rid of FIEMAP, fix SEEK_HOLE

2014-11-18 Thread Max Reitz
On 2014-11-17 at 11:18, Markus Armbruster wrote: PATCH 1 is just a comment fix. PATCH 2 drops FIEMAP use and explains why it needs to go. PATCH 3 carefully rewrites the SEEK_HOLE code. Why 2.2? The series fixes bugs, but the bugs are either not terribly severe, or not particularly likely to

Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

2014-11-18 Thread Amit Shah
On (Wed) 12 Nov 2014 [11:44:35], Michael S. Tsirkin wrote: This patchset fixes CVE-2014-7840: invalid migration stream can cause arbitrary qemu memory overwrite. First patch includes the minimal fix for the issue. Follow-up patches on top add extra checking to reduce the chance this kind of

Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

2014-11-18 Thread Amit Shah
On (Mon) 17 Nov 2014 [14:36:45], Michael S. Tsirkin wrote: On Mon, Nov 17, 2014 at 05:50:34PM +0530, Amit Shah wrote: On (Mon) 17 Nov 2014 [13:48:58], Michael S. Tsirkin wrote: On Mon, Nov 17, 2014 at 04:37:50PM +0530, Amit Shah wrote: On (Mon) 17 Nov 2014 [12:52:59], Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

2014-11-18 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: On (Wed) 12 Nov 2014 [11:44:35], Michael S. Tsirkin wrote: This patchset fixes CVE-2014-7840: invalid migration stream can cause arbitrary qemu memory overwrite. First patch includes the minimal fix for the issue. Follow-up patches on top add

[Qemu-devel] mute button not work

2014-11-18 Thread li
Hi all, i use qemu-system-x86_64 to run windows 7, and fund that mute/unmute button in the right bottom of guest desktop not work. related info is as below: $qemu-system-x86_64 --version QEMU emulator version 1.4.0, Copyright (c) 2003-2008 Fabrice Bellard $ps -elf | grep

Re: [Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to BB

2014-11-18 Thread Max Reitz
On 2014-11-17 at 18:26, Paolo Bonzini wrote: On 17/11/2014 16:30, Max Reitz wrote: Because all BlockDriverStates behind a single BlockBackend reside in a single AioContext, it is fine to just pass these functions (blk_add_aio_context_notifier() and blk_remove_aio_context_notifier()) through to

Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

2014-11-18 Thread Michael S. Tsirkin
On Tue, Nov 18, 2014 at 02:31:34PM +0530, Amit Shah wrote: On (Wed) 12 Nov 2014 [11:44:35], Michael S. Tsirkin wrote: This patchset fixes CVE-2014-7840: invalid migration stream can cause arbitrary qemu memory overwrite. First patch includes the minimal fix for the issue. Follow-up

Re: [Qemu-devel] [PATCH 5/5] nbd: Use BlockBackend internally

2014-11-18 Thread Max Reitz
On 2014-11-17 at 18:29, Paolo Bonzini wrote: On 17/11/2014 16:30, Max Reitz wrote: With all externally visible functions changed to use BlockBackend, this patch makes nbd use BlockBackend for everything internally as well. While touching them, substitute 512 by BDRV_SECTOR_SIZE in the calls

Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

2014-11-18 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: On Tue, Nov 18, 2014 at 02:31:34PM +0530, Amit Shah wrote: On (Wed) 12 Nov 2014 [11:44:35], Michael S. Tsirkin wrote: This patchset fixes CVE-2014-7840: invalid migration stream can cause arbitrary qemu memory overwrite. First patch

Re: [Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to BB

2014-11-18 Thread Paolo Bonzini
On 18/11/2014 10:26, Max Reitz wrote: However, when you consider (as far as I looked into it) that a BDS is only closed when there are either no references to it (which will not happen as long as it has a BB) or when it is ejected, it suddenly does make sense: Ejecting really is something for

[Qemu-devel] hotremoving a disk qmp/hmp

2014-11-18 Thread William Dauchy
Hello, When hotremoving a disk I'm using the QMP API with device_del command; Previous query-block command result: { u'device': u'disk1', u'inserted': { u'backing_file_depth': 0, u'bps': 0, u'bps_rd': 0, u'bps_wr': 0,

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Paolo Bonzini
On 17/11/2014 22:20, Don Slutz wrote: The other callers to blk_set_enable_write_cache() in this file already check for s-blk == NULL. Signed-off-by: Don Slutz dsl...@verizon.com --- I think this is a bugfix that should be back ported to stable releases. I also think this should be

[Qemu-devel] [PATCH for-2.2 0/3] block/raw-posix: Fixes for preallocation

2014-11-18 Thread Max Reitz
This series brings some (minor) fixes for full preallocation in raw-posix; thanks to László for finding these bugs. Since the fixes are not too grave, I would be fine with not getting them into 2.2. But because they are rather simple and they are bug fixes after all, I sent this series with the

[Qemu-devel] [PATCH for-2.2 2/3] block/raw-posix: Only sync after successful preallocation

2014-11-18 Thread Max Reitz
The loop which filled the file with zeroes may have been left early due to an error. In that case, the fsync() should be skipped. Signed-off-by: Max Reitz mre...@redhat.com --- block/raw-posix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/raw-posix.c

[Qemu-devel] [PATCH for-2.2 1/3] block/raw-posix: Fix preallocating write() loop

2014-11-18 Thread Max Reitz
write() may write less bytes than requested; in this case, the number of bytes written is returned. This is the byte count we should be subtracting from the number of bytes still to be written, and not the byte count we requested to write. Reported-by: László Érsek ler...@redhat.com

[Qemu-devel] [PATCH for-2.2 3/3] block/raw-posix: Catch fsync() errors

2014-11-18 Thread Max Reitz
fsync() may fail, and that case should be handled. Reported-by: László Érsek ler...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com --- block/raw-posix.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index f67fb11..666cdec

Re: [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-11-18 Thread Vladimir Sementsov-Ogievskiy
(2) File Format Some standard file magic, which includes: - Some magic byte(s) - Dirty flag. Needed to tell if we can trust this data or not. - The size of the bitmap - The granularity of the bitmap - The offset to the first sector of bitmap data (Maybe? It can't hurt if we give ourselves a

Re: [Qemu-devel] [PATCH for-2.2 0/3] block/raw-posix: Fixes for preallocation

2014-11-18 Thread Kevin Wolf
Am 18.11.2014 um 11:23 hat Max Reitz geschrieben: This series brings some (minor) fixes for full preallocation in raw-posix; thanks to László for finding these bugs. Since the fixes are not too grave, I would be fine with not getting them into 2.2. But because they are rather simple and they

Re: [Qemu-devel] [PATCH] exec: Handle multipage ranges in invalidate_and_set_dirty()

2014-11-18 Thread Peter Maydell
On 17 November 2014 11:03, Paolo Bonzini pbonz...@redhat.com wrote: On 16/11/2014 20:44, Peter Maydell wrote: The code in invalidate_and_set_dirty() needs to handle addr/length combinations which cross guest physical page boundaries. This can happen, for example, when disk I/O reads large

[Qemu-devel] [PATCH v2 3/6] block: Add blk_add_close_notifier() for BB

2014-11-18 Thread Max Reitz
Adding something like a delete notifier to a BlockBackend would not make much sense, because whoever is interested in registering there will probably hold a reference to that BlockBackend; therefore, the notifier will never be called (or only when the notifiee already relinquished its reference

[Qemu-devel] [PATCH v2 4/6] nbd: Change external interface to BlockBackend

2014-11-18 Thread Max Reitz
Substitute BlockDriverState by BlockBackend in every globally visible function provided by nbd. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- blockdev-nbd.c | 15 --- include/block/nbd.h | 7 +++ nbd.c | 11

[Qemu-devel] [PATCH v2 0/6] nbd: Use BlockBackend

2014-11-18 Thread Max Reitz
From the block layer's perspective, the nbd server is pretty similar to a guest device. Therefore, it should use BlockBackend to access block devices, just like any other guest device does. This series consequently makes the nbd server use BlockBackend for referencing block devices. v2: - Added

[Qemu-devel] [PATCH v2 5/6] nbd: Use BlockBackend internally

2014-11-18 Thread Max Reitz
With all externally visible functions changed to use BlockBackend, this patch makes nbd use BlockBackend for everything internally as well. While touching them, substitute 512 by BDRV_SECTOR_SIZE in the calls to blk_read(), blk_write() and blk_co_discard(). Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v2 6/6] qemu-nbd: Use BlockBackend where reasonable

2014-11-18 Thread Max Reitz
Because qemu-nbd creates the BlockBackend by itself, it should create the according BlockDriverState tree by itself as well; that means, it has call bdrv_open() on its own. This is one of the places where qemu-nbd still needs to use a BlockDriverState directly (the root BDS below the BB); other

[Qemu-devel] [PATCH v2 1/6] block: Lift more functions into BlockBackend

2014-11-18 Thread Max Reitz
There are already some blk_aio_* functions, so we might as well have blk_co_* functions (as far as we need them). This patch adds blk_co_flush(), blk_co_discard(), and also blk_invalidate_cache() (which is not a blk_co_* function but is needed nonetheless). Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v2 2/6] block: Add AioContextNotifier functions to BB

2014-11-18 Thread Max Reitz
Because all BlockDriverStates behind a single BlockBackend reside in a single AioContext, it is fine to just pass these functions (blk_add_aio_context_notifier() and blk_remove_aio_context_notifier()) through to the root BlockDriverState. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by:

[Qemu-devel] [PATCH 1/1] migration: fix parameter validation on ram load

2014-11-18 Thread Amit Shah
From: Michael S. Tsirkin m...@redhat.com During migration, the values read from migration stream during ram load are not validated. Especially offset in host_from_stream_offset() and also the length of the writes in the callers of said function. To fix this, we need to make sure that the

[Qemu-devel] [PULL] migration: fix for CVE-2014-7840

2014-11-18 Thread Amit Shah
The following changes since commit d6be29e3fb5659102ac0e48e295d177cb67e32c5: target-arm: handle address translations that start at level 3 (2014-11-17 19:30:28 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/for-2.2 for you to

[Qemu-devel] [PULL 2/6] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-18 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Commit 5500316 (May 2012) implemented raw_co_is_allocated() as follows: 1. If defined(CONFIG_FIEMAP), use the FS_IOC_FIEMAP ioctl 2. Else if defined(SEEK_HOLE) defined(SEEK_DATA), use lseek() 3. Else pretend there are no holes Later on,

[Qemu-devel] [PULL 6/6] block/raw-posix: Catch fsync() errors

2014-11-18 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com fsync() may fail, and that case should be handled. Reported-by: László Érsek ler...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/raw-posix.c | 7 ++- 1 file changed, 6 insertions(+), 1

[Qemu-devel] [PULL 1/6] raw-posix: Fix comment for raw_co_get_block_status()

2014-11-18 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Missed in commit 705be72. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com

[Qemu-devel] [PULL 0/6] Block patches for 2.2.0-rc2

2014-11-18 Thread Kevin Wolf
The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-17 17:22:03 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

[Qemu-devel] [PULL 3/6] raw-posix: The SEEK_HOLE code is flawed, rewrite it

2014-11-18 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com On systems where SEEK_HOLE in a trailing hole seeks to EOF (Solaris, but not Linux), try_seek_hole() reports trailing data instead. Additionally, unlikely lseek() failures are treated badly: * When SEEK_HOLE fails, try_seek_hole() reports trailing data.

[Qemu-devel] [PULL 5/6] block/raw-posix: Only sync after successful preallocation

2014-11-18 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com The loop which filled the file with zeroes may have been left early due to an error. In that case, the fsync() should be skipped. Signed-off-by: Max Reitz mre...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/raw-posix.c | 4 +++- 1 file

[Qemu-devel] [PULL 4/6] block/raw-posix: Fix preallocating write() loop

2014-11-18 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com write() may write less bytes than requested; in this case, the number of bytes written is returned. This is the byte count we should be subtracting from the number of bytes still to be written, and not the byte count we requested to write. Reported-by: László

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Stefan Hajnoczi
On Mon, Nov 17, 2014 at 04:20:39PM -0500, Don Slutz wrote: The other callers to blk_set_enable_write_cache() in this file already check for s-blk == NULL. Signed-off-by: Don Slutz dsl...@verizon.com --- I think this is a bugfix that should be back ported to stable releases. I also

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Kevin Wolf
Am 17.11.2014 um 22:20 hat Don Slutz geschrieben: The other callers to blk_set_enable_write_cache() in this file already check for s-blk == NULL. Signed-off-by: Don Slutz dsl...@verizon.com --- I think this is a bugfix that should be back ported to stable releases. Please remember to

Re: [Qemu-devel] [PATCH 4/5] memory: interface to allocate device ram

2014-11-18 Thread Michael S. Tsirkin
On Mon, Nov 17, 2014 at 08:21:00PM +, Peter Maydell wrote: On 17 November 2014 20:08, Michael S. Tsirkin m...@redhat.com wrote: Add API to allocate on-device RAM. This looks just like regular RAM from migration POV, but has two special properties internally: - it is never exposed to

Re: [Qemu-devel] [PATCH v2 6/6] qemu-nbd: Use BlockBackend where reasonable

2014-11-18 Thread Paolo Bonzini
On 18/11/2014 12:21, Max Reitz wrote: Because qemu-nbd creates the BlockBackend by itself, it should create the according BlockDriverState tree by itself as well; that means, it has call bdrv_open() on its own. This is one of the places where qemu-nbd still needs to use a BlockDriverState

Re: [Qemu-devel] [PATCH] linux-headers: update to 3.18-rc5

2014-11-18 Thread Peter Maydell
On 18 November 2014 05:19, Paolo Bonzini pbonz...@redhat.com wrote: On 17/11/2014 19:32, Peter Maydell wrote: On 17 November 2014 18:28, Ard Biesheuvel ard.biesheu...@linaro.org wrote: This updates the Linux header to version 3.18-rc5, adding support for (among other things) read-only

[Qemu-devel] [PATCH 0/4] MAINTAINERS: add myself to migration, rng; update others

2014-11-18 Thread Amit Shah
Hello, These patches add myself to the migration maintainers list, and a new entry for virtio-rng. Also update the virtio-serial entry for an include file. Please ack. Amit Shah (4): MAINTAINERS: Add myself to migration maintainers MAINTAINERS: migration: add vmstate static checker files

[Qemu-devel] [PATCH 1/4] MAINTAINERS: Add myself to migration maintainers

2014-11-18 Thread Amit Shah
Signed-off-by: Amit Shah amit.s...@redhat.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bcb69e8..e517c41 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -928,6 +928,7 @@ F: scripts/checkpatch.pl Migration M: Juan Quintela

[Qemu-devel] [PATCH 2/4] MAINTAINERS: migration: add vmstate static checker files

2014-11-18 Thread Amit Shah
Signed-off-by: Amit Shah amit.s...@redhat.com --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e517c41..af8d856 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -935,6 +935,8 @@ F: migration* F: savevm.c F: arch_init.c F: vmstate.c +F:

[Qemu-devel] [PATCH 3/4] MAINTAINERS: add entry for virtio-rng

2014-11-18 Thread Amit Shah
Signed-off-by: Amit Shah amit.s...@redhat.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index af8d856..4c46cfe 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -697,6 +697,13 @@ S: Supported F: hw/char/virtio-serial-bus.c F:

[Qemu-devel] [PATCH 4/4] MAINTAINERS: add include files to virtio-serial entry

2014-11-18 Thread Amit Shah
Signed-off-by: Amit Shah amit.s...@redhat.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4c46cfe..d2f4a11 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -696,6 +696,7 @@ M: Amit Shah amit.s...@redhat.com S: Supported F:

Re: [Qemu-devel] [PATCH Part1 1/5] acpi, pc: Add hotunplug request cb for pc machine.

2014-11-18 Thread Igor Mammedov
On Mon, 17 Nov 2014 13:03:13 +0800 Tang Chen tangc...@cn.fujitsu.com wrote: in subj s/cb/callback|handler/ Memory and CPU hot unplug are both asynchronize procedures. s/asynchronize/asynchronous/ They both need unplug request cb when the unplug operation happens. s/cb when the unplug operation

Re: [Qemu-devel] [PATCH 1/3] s390: Add PCI bus support

2014-11-18 Thread Frank Blaschka
On Mon, Nov 10, 2014 at 04:14:16PM +0100, Alexander Graf wrote: On 10.11.14 15:20, Frank Blaschka wrote: From: Frank Blaschka frank.blasc...@de.ibm.com This patch implements a pci bus for s390x together with infrastructure to generate and handle hotplug events, to

Re: [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-11-18 Thread Vladimir Sementsov-Ogievskiy
(3) Data Integrity The dirty flag could work something like: - If, on first open, the file has the dirty flag set, we need to discard the bitmap data because we can no longer trust it. - If the bitmap file is clean, proceed as normal, but take a lock against any of the bitmap functions to

Re: [Qemu-devel] runtime configurable semihosting

2014-11-18 Thread Peter Maydell
On 13 November 2014 09:44, Liviu Ionescu i...@livius.net wrote: Peter Maydell wrote: I took a quick look at the syntax of command options and monitor commands, and I would suggest the following: - extend the option -semihosting with an optional target=native|gdb|auto, default auto

Re: [Qemu-devel] [PULL] migration: fix for CVE-2014-7840

2014-11-18 Thread Peter Maydell
On 18 November 2014 11:29, Amit Shah amit.s...@redhat.com wrote: The following changes since commit d6be29e3fb5659102ac0e48e295d177cb67e32c5: target-arm: handle address translations that start at level 3 (2014-11-17 19:30:28 +) are available in the git repository at:

Re: [Qemu-devel] [PATCH 00/13] linux-aio/virtio-scsi: support AioContext wide IO submission as batch

2014-11-18 Thread Paolo Bonzini
On 09/11/2014 08:42, Ming Lei wrote: This patch implements AioContext wide IO submission as batch, and the idea behind is very simple: - linux native aio(io_submit) supports to enqueue read/write requests to different files - in one AioContext, I/O requests from VM can

Re: [Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to uint64_t in virtio

2014-11-18 Thread Stefan Hajnoczi
On Mon, Nov 17, 2014 at 04:25:50PM +0100, Andreas Färber wrote: Am 17.11.2014 um 16:19 schrieb Marc Marí: El Mon, 17 Nov 2014 15:16:21 + Stefan Hajnoczi stefa...@gmail.com escribió: On Sat, Nov 01, 2014 at 06:02:26PM +0100, Marc Marí wrote: Convert use of pointers in functions of

Re: [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enabled binary traces

2014-11-18 Thread Stefan Hajnoczi
On Mon, Nov 17, 2014 at 07:57:08PM -0600, Lluís Vilanova wrote: Stefan Hajnoczi writes: On Sun, Nov 02, 2014 at 10:37:59PM +0100, christoph.seif...@posteo.de wrote: From: Christoph Seifert christoph.seif...@posteo.de simpletrace.py does not recognize the tcg option while reading

Re: [Qemu-devel] [PATCH v3 2/3] linux-aio: handling -EAGAIN for !s-io_q.plugged case

2014-11-18 Thread Paolo Bonzini
On 06/11/2014 16:10, Ming Lei wrote: +/* don't submit until next completion for -EAGAIN of non plug case */ +if (unlikely(!s-io_q.plugged)) { +return 0; +} + Is this an optimization or a fix for something? +/* + * Switch to queue mode until -EAGAIN is

Re: [Qemu-devel] [PATCH v3 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb'

2014-11-18 Thread Paolo Bonzini
On 06/11/2014 16:10, Ming Lei wrote: No one uses the 'node' field any more, so remove it from 'struct qemu_laiocb', and this can save 16byte for the struct on 64bit arch. Signed-off-by: Ming Lei ming@canonical.com --- block/linux-aio.c |1 - 1 file changed, 1 deletion(-)

Re: [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enabled binary traces

2014-11-18 Thread Stefan Hajnoczi
On Sun, Nov 02, 2014 at 10:37:59PM +0100, christoph.seif...@posteo.de wrote: From: Christoph Seifert christoph.seif...@posteo.de simpletrace.py does not recognize the tcg option while reading trace-events file. In result simpletrace does not work on binary traces and tcg enabled events.

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Stefano Stabellini
Konrad, I think we should have this fix in Xen 4.5. Should I go ahead and backport it? On Mon, 17 Nov 2014, Don Slutz wrote: The other callers to blk_set_enable_write_cache() in this file already check for s-blk == NULL. Signed-off-by: Don Slutz dsl...@verizon.com --- I think this is a

Re: [Qemu-devel] [PATCH v3 1/3] linux-aio: fix submit aio as a batch

2014-11-18 Thread Paolo Bonzini
@@ -137,6 +145,12 @@ static void qemu_laio_completion_bh(void *opaque) } } +static void qemu_laio_start_retry(struct qemu_laio_state *s) +{ +if (s-io_q.idx) +qemu_bh_schedule(s-io_q.retry); +} + static void qemu_laio_completion_cb(EventNotifier *e) {

Re: [Qemu-devel] hotremoving a disk qmp/hmp

2014-11-18 Thread Markus Armbruster
William Dauchy will...@gandi.net writes: Hello, When hotremoving a disk I'm using the QMP API with device_del command; Previous query-block command result: { u'device': u'disk1', u'inserted': { u'backing_file_depth': 0, u'bps': 0,

Re: [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-11-18 Thread Vladimir Sementsov-Ogievskiy
Also, if we sync not the last level, bitmap.dirty_flag should be related to syncing level, not to the whole bitmap, to reduce sync overhead. Or, if we implement difficult sync policy, there should be dirty flags for each bitmap level. Despite this, only one level is needed to be saved in the

Re: [Qemu-devel] [PULL 0/6] Block patches for 2.2.0-rc2

2014-11-18 Thread Peter Maydell
On 18 November 2014 11:35, Kevin Wolf kw...@redhat.com wrote: The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-17 17:22:03 +) are available in the git repository at:

Re: [Qemu-devel] exec.c:invalidate_and_set_dirty() only checks whether first page in its range is dirty...

2014-11-18 Thread Stefan Hajnoczi
On Sun, Nov 16, 2014 at 06:11:48PM +, Peter Maydell wrote: I'm trying to track down a bug in ARM TCG where we: * boot a guest * run 'shutdown -r now' to trigger a reboot * on reboot, crash when running userspace because the contents of physical RAM have changed but the translated

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Michael S. Tsirkin
On Tue, Nov 18, 2014 at 03:47:16PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: At the moment we migrate ROMs which reside in fw cfg, which allows changing ROM code at will, and supports migrating largish blocks early, with good performance. However, we are

[Qemu-devel] [PULL 1/2] Tracing docs fix configure option and description

2014-11-18 Thread Stefan Hajnoczi
From: Dr. David Alan Gilbert dgilb...@redhat.com Fix the example trace configure option. Update the text to say that multiple backends are allowed and what happens when multiple backends are enabled. Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Message-id:

[Qemu-devel] [PULL 0/2] Tracing patches

2014-11-18 Thread Stefan Hajnoczi
The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-17 17:22:03 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for

[Qemu-devel] [PULL 2/2] Tracing: Fix simpletrace.py error on tcg enabled binary traces

2014-11-18 Thread Stefan Hajnoczi
From: Christoph Seifert christoph.seif...@posteo.de simpletrace.py does not recognize the tcg option while reading trace-events file. In result simpletrace does not work on binary traces and tcg enabled events. Moved transformation of tcg enabled events to _read_events() which is used by

Re: [Qemu-devel] hotremoving a disk qmp/hmp

2014-11-18 Thread William Dauchy
On Nov18 15:22, Markus Armbruster wrote: This is block backend disk1. yes indeed. I presume you're deleting the device using backend disk1. yes What kind of device is this? PCI, perhaps? Please show us a complete QMP conversation. Here it is: live vm with one disk: (QEMU) query-block {

[Qemu-devel] [PULL] Net patches

2014-11-18 Thread Stefan Hajnoczi
The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-17 17:22:03 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: At the moment we migrate ROMs which reside in fw cfg, which allows changing ROM code at will, and supports migrating largish blocks early, with good performance. However, we are running into a problem: changing size breaks migration every time.

[Qemu-devel] [PULL] net: The third parameter of getsockname should be initialized

2014-11-18 Thread Stefan Hajnoczi
From: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-11-18 Thread John Snow
On 11/18/2014 08:09 AM, Vladimir Sementsov-Ogievskiy wrote: (3) Data Integrity The dirty flag could work something like: - If, on first open, the file has the dirty flag set, we need to discard the bitmap data because we can no longer trust it. - If the bitmap file is clean, proceed as

[Qemu-devel] Fwd: [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize Date: Tue, 18 Nov 2014 17:09:56 +0100 From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com,

[Qemu-devel] Fwd: [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions Date: Tue, 18 Nov 2014 17:09:57 +0100 From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com To: arm...@redhat.com, pbonz...@redhat.com,

[Qemu-devel] Fwd: [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry Date: Tue, 18 Nov 2014 17:09:58 +0100 From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com To: arm...@redhat.com, pbonz...@redhat.com,

[Qemu-devel] Fwd: [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize Date: Tue, 18 Nov 2014 17:10:00 +0100 From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com To: arm...@redhat.com, pbonz...@redhat.com,

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2014-11-18 Thread Peter Maydell
On 18 November 2014 15:04, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-17 17:22:03 +) are available in the git repository

[Qemu-devel] Fwd: [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing Date: Tue, 18 Nov 2014 17:09:59 +0100 From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com To: arm...@redhat.com, pbonz...@redhat.com,

[Qemu-devel] Fwd: [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing Date: Tue, 18 Nov 2014 17:10:01 +0100 From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com To: arm...@redhat.com, pbonz...@redhat.com,

[Qemu-devel] Fwd: [PATCH v2 0/6] Geometry and blocksize support for backing devices

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 0/6] Geometry and blocksize support for backing devices Date: Tue, 18 Nov 2014 17:09:55 +0100 From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com,

Re: [Qemu-devel] Sending packets up to VM using vhost-net User.

2014-11-18 Thread Anshul Makkar
Sorry, forgot to mention I am using git clone -b vhost-user-v5 https://github.com/virtualopensystems/qemu.git; for vhost-user backend implementation. and git clone https://github.com/virtualopensystems/vapp.git for reference implementation. Anshul Makkar On Tue, Nov 18, 2014 at 5:29 PM,

[Qemu-devel] Sending packets up to VM using vhost-net User.

2014-11-18 Thread Anshul Makkar
Hi, I am developing an application that is using vhost-user backend for packet transfer. The architecture: 1) VM1 is using Vhost-user and executing on server1. .qemu-system-x86_64 -m 1024 -mem-path /dev/hugepages,prealloc=on,share=on -drive

[Qemu-devel] qmp-commands.hx and inherited types (Was: Re: [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove)

2014-11-18 Thread John Snow
On 11/07/2014 08:00 AM, Eric Blake wrote: On 10/30/2014 04:22 AM, Fam Zheng wrote: [snip] +++ b/qapi/block-core.json @@ -865,6 +865,61 @@ '*on-target-error': 'BlockdevOnError' } } ## +# @BlockDirtyBitmap +# +# @device: name of device which the bitmap is tracking +# +#

Re: [Qemu-devel] runtime configurable semihosting

2014-11-18 Thread Liviu Ionescu
On 18 Nov 2014, at 15:31, Peter Maydell peter.mayd...@linaro.org wrote: Sorry, yes, you're right; I should have looked more carefully. So we do need a new option; or we should fix the parser. if the current keyword is not in the list, it can be pushed back, and defaults used.

[Qemu-devel] Tunneled Migration with Non-Shared Storage

2014-11-18 Thread Gary R Hook
What I really need to figure out is why, when performing a migration using non-shared storage, an entire VM is copied into memory before it’s sent across the wire using this method. A copy-on-read operation is performed first, then the disk is sent, then the dirty pages, then the RAM. The odd

Re: [Qemu-devel] runtime configurable semihosting

2014-11-18 Thread Peter Maydell
On 18 November 2014 16:46, Liviu Ionescu i...@livius.net wrote: On 18 Nov 2014, at 15:31, Peter Maydell peter.mayd...@linaro.org wrote: Sorry, yes, you're right; I should have looked more carefully. So we do need a new option; or we should fix the parser. if the current keyword is not in

Re: [Qemu-devel] [PATCH 1/3] s390: Add PCI bus support

2014-11-18 Thread Alexander Graf
On 18.11.14 13:50, Frank Blaschka wrote: On Mon, Nov 10, 2014 at 04:14:16PM +0100, Alexander Graf wrote: On 10.11.14 15:20, Frank Blaschka wrote: From: Frank Blaschka frank.blasc...@de.ibm.com This patch implements a pci bus for s390x together with infrastructure to generate and handle

Re: [Qemu-devel] qmp-commands.hx and inherited types (Was: Re: [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove)

2014-11-18 Thread Eric Blake
On 11/18/2014 09:44 AM, John Snow wrote: Is it worth using type inheritance, as in: { 'type': 'BlockDirtyBitmapAdd', 'base': 'BlockDirtyBitmap', 'data': { '*granularity': 'int' } } Strictly speaking, I would argue against inheritance here because BlockDirtyBitmapAdd is not isa

Re: [Qemu-devel] hotremoving a disk qmp/hmp

2014-11-18 Thread Markus Armbruster
William Dauchy will...@gandi.net writes: On Nov18 15:22, Markus Armbruster wrote: This is block backend disk1. yes indeed. I presume you're deleting the device using backend disk1. yes What kind of device is this? PCI, perhaps? Please show us a complete QMP conversation. Here it is:

Re: [Qemu-devel] [PULL] Net patches

2014-11-18 Thread Peter Maydell
On 18 November 2014 15:04, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-17 17:22:03 +) are available in the git repository

Re: [Qemu-devel] [PATCH v2 18/21] qcow2: Add function for refcount order amendment

2014-11-18 Thread Eric Blake
On 11/14/2014 06:06 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c | 457 + block/qcow2.h

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Peter Maydell
On 18 November 2014 11:41, Kevin Wolf kw...@redhat.com wrote: Am 17.11.2014 um 22:20 hat Don Slutz geschrieben: The other callers to blk_set_enable_write_cache() in this file already check for s-blk == NULL. Signed-off-by: Don Slutz dsl...@verizon.com --- I think this is a bugfix that

Re: [Qemu-devel] [PATCH v2 18/21] qcow2: Add function for refcount order amendment

2014-11-18 Thread Max Reitz
On 18.11.2014 18:55, Eric Blake wrote: On 11/14/2014 06:06 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c | 457

[Qemu-devel] [PATCH] add semihosting-config option

2014-11-18 Thread Liviu Ionescu
- allow to define where the semihosting calls will be addressed Signed-off-by: Liviu Ionescu i...@livius.net --- gdbstub.c | 12 include/sysemu/sysemu.h | 6 ++ qemu-options.hx | 12 +++- vl.c| 49

[Qemu-devel] [PATCH] pass semihosting exit code back to system

2014-11-18 Thread Liviu Ionescu
Signed-off-by: Liviu Ionescu i...@livius.net --- target-arm/arm-semi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c index ebb5235..4b982ad 100644 --- a/target-arm/arm-semi.c +++ b/target-arm/arm-semi.c @@ -58,6

[Qemu-devel] [PATCH] pass ARM semihosting exit code back to system

2014-11-18 Thread Liviu Ionescu
In order to run unit tests under semihosting, it is necessary to pass the application exit code back to the system. ARM defines only the code to be used for non-error application exit (ADP_Stopped_ApplicationExit), all other codes should return non-zero exit codes. This patch checks if the

[Qemu-devel] [PATCH] add -semihosting-config option

2014-11-18 Thread Liviu Ionescu
The usual semihosting behaviour is to process the system calls locally and return; unfortuantelly the initial implementation dinamically changed the target to GDB during debug sessions, which, for the usual arm-none-eabi-gdb, is not implemented. The result was that during debug sessions the

  1   2   >