Re: [Qemu-devel] [RFC PATCH 2/4] pcie-aer: Fix command pcie_aer_inject_error is invalid

2015-01-14 Thread Chen Fan
On 01/12/2015 09:56 PM, Marcel Apfelbaum wrote: On 01/12/2015 05:04 AM, Chen Fan wrote: in spec "PCI Express 3.0" section 6.2.6 Figure 6-3 virtual bridge part, the flowchart showing tell us SERR# enable at Bridge Control register associate with system error at Secondary Status register can send

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: selectable object size support

2015-01-14 Thread Hitoshi Mitake
At Tue, 13 Jan 2015 17:41:12 +0900, Teruaki Ishizaki wrote: > > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additional

[Qemu-devel] [PATCH] qemu-iotests: Fix supported_oses check

2015-01-14 Thread Fam Zheng
There is a bug in the recently added sys.platform test and we no longer run python tests, because "linux2" is the value to compare here. So do a prefix match, although the python documentation claims Linux is always linux2. Signed-off-by: Fam Zheng --- tests/qemu-iotests/iotests.py | 2 +- 1 fil

Re: [Qemu-devel] question about live migration with storage

2015-01-14 Thread Zhang Haoyu
On 2015-01-14 17:07:08, Paolo Bonzini wrote: > > > On 14/01/2015 08:58, Zhang Haoyu wrote: > >> 2) Finer-grain control the parameters of block migration (dirty bitmap > >> granularity). > >> > >> 3) Block and RAM migration do not share the same socket and thus can > >> more easily be parallelize

Re: [Qemu-devel] [PATCH v15 1/2] sPAPR: Implement EEH RTAS calls

2015-01-14 Thread Gavin Shan
On Thu, Jan 15, 2015 at 12:33:59PM +1100, David Gibson wrote: >On Thu, Jan 15, 2015 at 11:14:36AM +1100, Gavin Shan wrote: >> On Wed, Jan 14, 2015 at 12:39:35PM +1100, David Gibson wrote: >> >On Mon, Jan 05, 2015 at 11:26:27AM +1100, Gavin Shan wrote: >> >> The emulation for EEH RTAS requests from

Re: [Qemu-devel] [PATCH v15 1/2] sPAPR: Implement EEH RTAS calls

2015-01-14 Thread David Gibson
On Thu, Jan 15, 2015 at 11:14:36AM +1100, Gavin Shan wrote: > On Wed, Jan 14, 2015 at 12:39:35PM +1100, David Gibson wrote: > >On Mon, Jan 05, 2015 at 11:26:27AM +1100, Gavin Shan wrote: > >> The emulation for EEH RTAS requests from guest isn't covered > >> by QEMU yet and the patch implements them

Re: [Qemu-devel] [PATCH] pseries: Limit PCI host bridge "index" value

2015-01-14 Thread David Gibson
On Wed, Jan 14, 2015 at 11:23:10AM -0600, Michael Roth wrote: > Quoting David Gibson (2015-01-13 20:33:39) > > pseries guests can have large numbers of PCI host bridges. To avoid the > > user having to specify a number of different configuration values for every > > one, the device supports an "in

Re: [Qemu-devel] [virtio] virtqueue allocation and thread-safety

2015-01-14 Thread Fam Zheng
On Wed, 01/14 14:01, Vasile Catalin-B50542 wrote: > Hi, > > I'm trying to make a new virtio device. > I got it running (I made a functional dummy device & guest driver). > Now I'm trying to build some communication between the device and guest > driver. > I can't seem to find where the actual allo

Re: [Qemu-devel] [PATCH v15 2/2] sPAPR: Implement sPAPRPHBClass::eeh_handler

2015-01-14 Thread Gavin Shan
On Wed, Jan 14, 2015 at 12:41:59PM +1100, David Gibson wrote: >On Mon, Jan 05, 2015 at 11:26:28AM +1100, Gavin Shan wrote: >> The patch implements sPAPRPHBClass::eeh_handler so that the >> EEH RTAS requests can be routed to VFIO for further handling. >> >> Signed-off-by: Gavin Shan >> --- >> hw/

Re: [Qemu-devel] [PATCH v15 1/2] sPAPR: Implement EEH RTAS calls

2015-01-14 Thread Gavin Shan
On Wed, Jan 14, 2015 at 12:39:35PM +1100, David Gibson wrote: >On Mon, Jan 05, 2015 at 11:26:27AM +1100, Gavin Shan wrote: >> The emulation for EEH RTAS requests from guest isn't covered >> by QEMU yet and the patch implements them. >> >> The patch defines constants used by EEH RTAS calls and adds

Re: [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device

2015-01-14 Thread Scott Feldman
On Mon, Jan 12, 2015 at 4:57 AM, Paolo Bonzini wrote: > > > On 11/01/2015 04:57, sfel...@gmail.com wrote: >> +static const MemoryRegionOps rocker_mmio_ops = { >> +.read = rocker_mmio_read, >> +.write = rocker_mmio_write, >> +.endianness = DEVICE_LITTLE_ENDIAN, >> +.valid = { >> +

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-14 Thread Gerhard Wiesinger
On 14.01.2015 18:52, Juan Quintela wrote: Juan Quintela wrote: I forgot tell on the previous patch, I am using 2vcpus. with a single vcpu I have been unable to trigger this bug. There is already a fix with a new patched kernel available for the guest, see the bugzilla entry and my posts in

[Qemu-devel] [Bug 1410288] Re: qemu-img conversion to qcow2 hangs with blank image less than 100kiB

2015-01-14 Thread Serge Hallyn
Went ahead and tested - it is in fact fixed in the v2.2 version. ** Changed in: qemu (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [Bug 1410288] Re: qemu-img conversion to qcow2 hangs with blank image less than 100kiB

2015-01-14 Thread Serge Hallyn
Does it also fail with the qemu from https://launchpad.net/~ubuntu-virt/+archive/ubuntu/virt-daily-upstream ? (This isn't quite git head, but it is qemu v2.2) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

[Qemu-devel] [Bug 1292234] Re: qcow2 image corruption in trusty (qemu 1.7 and 2.0 candidate)

2015-01-14 Thread Chris J Arges
FWIW, just re-reproduced this with latest upstream kernel / qemu / fresh qcow2 image. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1292234 Title: qcow2 image corruption in trusty (qemu 1.7 and 2.0

Re: [Qemu-devel] [PULL 00/15] Misc patches for 2015-01-14

2015-01-14 Thread Peter Maydell
On 14 January 2015 at 09:41, Paolo Bonzini wrote: > The following changes since commit f1c5831ca3e3eafb89331233221768b64db113e8: > > Merge remote-tracking branch 'remotes/amit-virtio-rng/tags/rng-for-2.3' > into staging (2015-01-09 18:55:29 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] Fixes several full screen issues on Mac OS X

2015-01-14 Thread Peter Maydell
On 14 January 2015 at 18:59, Programmingkid wrote: > > On Jan 14, 2015, at 1:29 PM, Peter Maydell wrote: > >> On 14 January 2015 at 18:18, Programmingkid >> wrote: >>> >>> On Jan 14, 2015, at 12:19 PM, Peter Maydell wrote: (2) Having done this I find that all my other application windows >>

Re: [Qemu-devel] [PATCH v4 37/47] Page request: Consume pages off the post-copy queue

2015-01-14 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:43PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > When transmitting RAM pages, consume pages that have been queued by > > MIG_RPCOMM_REQPAGE commands and send them ahead of

Re: [Qemu-devel] [PATCH] Machine menu patch for Mac OS X

2015-01-14 Thread Programmingkid
On Jan 14, 2015, at 1:42 PM, Peter Maydell wrote: > On 14 January 2015 at 18:34, Programmingkid wrote: >> >> On Jan 14, 2015, at 12:42 PM, Peter Maydell wrote: >> >>> On 13 January 2015 at 01:49, Programmingkid >>> wrote: This patch adds a Machine menu to QEMU. This menu gives the user

[Qemu-devel] state of micro-checkpointing in qemu

2015-01-14 Thread guillaume LE LOUËT
Hello. Mr Hines implemented a version of micro-checkpointing (MC), known as High-Availability(HA) in VMWare. The implementation is in the mc branch of the git repo http://github.com/hinesmr/qemu.git, described at http://wiki.qemu.org/Features/MicroCheckpointing My question is : will qemu suppor

Re: [Qemu-devel] [PATCH] Fixes several full screen issues on Mac OS X

2015-01-14 Thread Programmingkid
On Jan 14, 2015, at 1:29 PM, Peter Maydell wrote: > On 14 January 2015 at 18:18, Programmingkid wrote: >> >> On Jan 14, 2015, at 12:19 PM, Peter Maydell wrote: >>> (2) Having done this I find that all my other application windows >>> have been squashed down into a corner of my screen, presumabl

Re: [Qemu-devel] [PATCH] Machine menu patch for Mac OS X

2015-01-14 Thread Peter Maydell
On 14 January 2015 at 18:34, Programmingkid wrote: > > On Jan 14, 2015, at 12:42 PM, Peter Maydell wrote: > >> On 13 January 2015 at 01:49, Programmingkid >> wrote: >>> This patch adds a Machine menu to QEMU. This menu gives the user the >>> ability to easily work with floppy and CD image files

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Richard Henderson
On 01/14/2015 10:15 AM, Lluís Vilanova wrote: > Sorry I wasn't clear. I meant that it might be better to remove tcg/README and > instead document all the operations (those in the readme and the additional > ones) in the header. If we did that, it would go somewhere else. There are two different (

Re: [Qemu-devel] [PATCH] Machine menu patch for Mac OS X

2015-01-14 Thread Programmingkid
On Jan 14, 2015, at 12:42 PM, Peter Maydell wrote: > On 13 January 2015 at 01:49, Programmingkid wrote: >> This patch adds a Machine menu to QEMU. This menu gives the user the ability >> to easily work with floppy and CD image files. >> >> Features: >> Menu items to switch floppy and CD image

Re: [Qemu-devel] [PATCH] Fixes several full screen issues on Mac OS X

2015-01-14 Thread Peter Maydell
On 14 January 2015 at 18:18, Programmingkid wrote: > > On Jan 14, 2015, at 12:19 PM, Peter Maydell wrote: >> (2) Having done this I find that all my other application windows >> have been squashed down into a corner of my screen, presumably because >> we've told MacOSX "the screen is 640x480" and

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Peter Maydell
On 14 January 2015 at 18:15, Lluís Vilanova wrote: > Sorry I wasn't clear. I meant that it might be better to remove tcg/README and > instead document all the operations (those in the readme and the additional > ones) in the header. I think the IR is worth documenting in itself, rather than mergi

Re: [Qemu-devel] [PATCH v6] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-14 Thread Programmingkid
On Jan 14, 2015, at 12:02 PM, Peter Maydell wrote: > On 13 January 2015 at 20:07, Programmingkid wrote: >> Allows QEMU on Mac OS X to use a real cdrom again. >> >> Signed-off-by: John Arbuckle >> >> --- >> Added fallback code - uses lseek() if ioctl() fails. >> >> block/raw-posix.c | 25 ++

Re: [Qemu-devel] [PATCH v2] Makes -full-screen option work on Mac OS X

2015-01-14 Thread Programmingkid
On Jan 14, 2015, at 12:09 PM, Peter Maydell wrote: > On 12 January 2015 at 16:46, Programmingkid wrote: >> This patch makes the -full-screen option actually instruct QEMU to enter >> fullscreen at startup. >> >> Signed-off-by: John Arbuckle >> >> --- >> Removed the set_to_full_screen variabl

Re: [Qemu-devel] [PATCH] Fixes several full screen issues on Mac OS X

2015-01-14 Thread Programmingkid
On Jan 14, 2015, at 12:19 PM, Peter Maydell wrote: > On 4 January 2015 at 23:44, Programmingkid wrote: >> This patch makes several changes: >> - Fixes issue of returning to window mode and QEMU not setting >> the right graphic settings if there was a change during full screen mode. >> - Eliminat

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Lluís Vilanova
Bastian Koppelmann writes: > On 01/14/2015 03:36 PM, Lluís Vilanova wrote: >> Bastian Koppelmann writes: >> >>> There is no overview, that shows all the frontend operation one can use, as >>> found on the wiki. Unfortunatly the wiki is out of date, so let's try to >>> move >>> this documentation

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Bastian Koppelmann
On 01/14/2015 03:51 PM, Bastian Koppelmann wrote: There is no overview, that shows all the frontend operation one can use, as found on the wiki. Unfortunatly the wiki is out of date, so let's try to move this documentation to the source files, which has the benefit, that it is easy to update the

Re: [Qemu-devel] [PATCH 19/19] block/parallels: optimize linear image expansion

2015-01-14 Thread Denis V. Lunev
On 14/01/15 20:56, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:12PM +0300, Denis V. Lunev wrote: Plain image expansion spends a lot of time to update image file size. This seriously affects the performance. The following simple test qemu_img create -f parallels -o cluster_size=64k ./1.hd

Re: [Qemu-devel] [PATCH 19/19] block/parallels: optimize linear image expansion

2015-01-14 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:12PM +0300, Denis V. Lunev wrote: > Plain image expansion spends a lot of time to update image file size. > This seriously affects the performance. The following simple test > qemu_img create -f parallels -o cluster_size=64k ./1.hds 64G > qemu_io -n -c "write -P 0x

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Bastian Koppelmann
On 01/14/2015 04:55 PM, Thomas Huth wrote: On Wed, 14 Jan 2015 16:36:26 +0100 Lluís Vilanova wrote: ... Also, AFAIR it was decided to use gtk-doc instead of doxygen. If there's a consensus about which source code documentation style should be used for QEMU, could you (or somebody else) maybe

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-14 Thread Juan Quintela
Juan Quintela wrote: > Gerhard Wiesinger wrote: >> On 12.01.2015 12:41, Gerhard Wiesinger wrote: >>> On 08.01.2015 23:28, Gerhard Wiesinger wrote: I'll keep you up to date in the next days whether it happens again or not. >>> >>> With qemu-kvm 2.2.0 release from the above repositor

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Bastian Koppelmann
On 01/14/2015 03:36 PM, Lluís Vilanova wrote: Bastian Koppelmann writes: There is no overview, that shows all the frontend operation one can use, as found on the wiki. Unfortunatly the wiki is out of date, so let's try to move this documentation to the source files, which has the benefit, that

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-14 Thread Juan Quintela
Gerhard Wiesinger wrote: > On 12.01.2015 12:41, Gerhard Wiesinger wrote: >> On 08.01.2015 23:28, Gerhard Wiesinger wrote: >>> >>> I'll keep you up to date in the next days whether it happens again >>> or not. >> >> With qemu-kvm 2.2.0 release from the above repository the 100% usage >> didn't happ

Re: [Qemu-devel] [PATCH] Machine menu patch for Mac OS X

2015-01-14 Thread Peter Maydell
On 13 January 2015 at 01:49, Programmingkid wrote: > This patch adds a Machine menu to QEMU. This menu gives the user the ability > to easily work with floppy and CD image files. > > Features: > Menu items to switch floppy and CD image files. > Menu items to eject floppy and CD image files. > Men

Re: [Qemu-devel] [PATCH] pseries: Limit PCI host bridge "index" value

2015-01-14 Thread Michael Roth
Quoting David Gibson (2015-01-13 20:33:39) > pseries guests can have large numbers of PCI host bridges. To avoid the > user having to specify a number of different configuration values for every > one, the device supports an "index" property which is a shorthand setting > the various window and co

Re: [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-01-14 Thread Roman Kagan
On Wed, Jan 14, 2015 at 05:31:20PM +0300, Denis V. Lunev wrote: > On 14/01/15 17:26, Roman Kagan wrote: > >On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote: > >>This is preparational commit for tweaks in Parallels image expansion. > >>The idea is that enlarge via truncate by one data

Re: [Qemu-devel] [PATCH] Fixes several full screen issues on Mac OS X

2015-01-14 Thread Peter Maydell
On 4 January 2015 at 23:44, Programmingkid wrote: > This patch makes several changes: > - Fixes issue of returning to window mode and QEMU not setting > the right graphic settings if there was a change during full screen mode. > - Eliminated distorted full screen display. > - Makes full screen mo

Re: [Qemu-devel] [PATCH v2] Makes -full-screen option work on Mac OS X

2015-01-14 Thread Peter Maydell
On 12 January 2015 at 16:46, Programmingkid wrote: > This patch makes the -full-screen option actually instruct QEMU to enter > fullscreen at startup. > > Signed-off-by: John Arbuckle > > --- > Removed the set_to_full_screen variable. > Removed the scanForFullScreenOption() function. > > ui/co

Re: [Qemu-devel] [PATCH v6] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-14 Thread Peter Maydell
On 13 January 2015 at 20:07, Programmingkid wrote: > Allows QEMU on Mac OS X to use a real cdrom again. > > Signed-off-by: John Arbuckle > > --- > Added fallback code - uses lseek() if ioctl() fails. > > block/raw-posix.c | 25 - > 1 files changed, 24 insertions(+), 1 d

Re: [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity

2015-01-14 Thread Thomas Huth
On Wed, 14 Jan 2015 16:20:47 +0100 Frank Blaschka wrote: > Signed-off-by: Frank Blaschka > --- > hw/s390x/s390-pci-bus.c | 1 + > hw/s390x/s390-pci-inst.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > index 1201b

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Thomas Huth
On Wed, 14 Jan 2015 16:36:26 +0100 Lluís Vilanova wrote: ... > > Also, AFAIR it was decided to use gtk-doc instead of doxygen. If there's a consensus about which source code documentation style should be used for QEMU, could you (or somebody else) maybe add an appropriate paragraph to the CODING

Re: [Qemu-devel] [PATCH 6/9] block-migration: tiny refactoring

2015-01-14 Thread John Snow
On 01/14/2015 07:26 AM, Vladimir Sementsov-Ogievskiy wrote: On 09.01.2015 00:23, John Snow wrote: On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add blk_create and blk_free to remove code duplicates. Otherwise, duplicates will rise in the following patches because of BlkMigBloc

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Denis V. Lunev
On 14/01/15 17:29, Denis V. Lunev wrote: On 14/01/15 16:34, Roman Kagan wrote: On Wed, Jan 14, 2015 at 04:08:50PM +0300, Denis V. Lunev wrote: On 14/01/15 16:03, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: +static int cache_bat(BlockDriverState *bs, uint3

Re: [Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-14 Thread Stefan Hajnoczi
On Wed, Jan 07, 2015 at 03:19:13PM +0100, Peter Wu wrote: > On Wednesday 07 January 2015 13:19:34 Stefan Hajnoczi wrote: > > On Tue, Jan 06, 2015 at 06:48:04PM +0100, Peter Wu wrote: > > > DMG files have a variable length with a UDIF trailer at the end of a > > > file. This UDIF trailer is essentia

Re: [Qemu-devel] [PATCH v2 00/12] block/dmg: (compatibility) fixes and bzip2 support

2015-01-14 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 06:48:03PM +0100, Peter Wu wrote: > Hi, > > This is the second revision of improvements to DMG image file support. > See [1] for an overview of the previous patchset. > > Thanks to John Snow for his efforts in reviewing patches and providing > suggestions. The errp suggest

Re: [Qemu-devel] cpu hotplug and windows guest (win2012r2)

2015-01-14 Thread Andrey Korolyov
On Fri, Jan 9, 2015 at 4:35 PM, Andrey Korolyov wrote: > On Fri, Jan 9, 2015 at 1:26 PM, Alexandre DERUMIER > wrote: >> Hi, >> >> I'm currently testing cpu hotplug with a windows 2012R2 standard guest, >> >> and I can't get it too work. (works fine with linux guest). >> >> host kernel : rhel7 3.

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Lluís Vilanova
Bastian Koppelmann writes: > There is no overview, that shows all the frontend operation one can use, as > found on the wiki. Unfortunatly the wiki is out of date, so let's try to move > this documentation to the source files, which has the benefit, that it is easy > to update the documentation, i

Re: [Qemu-devel] [PATCH 0/4] block: Cleanups around error reporting

2015-01-14 Thread Eric Blake
On 01/14/2015 07:31 AM, Markus Armbruster wrote: > Markus Armbruster (4): > blockdev: Give find_block_job() an Error ** parameter > blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro > block: New bdrv_add_key(), convert monitor to use it > block: Eliminate silly QERR_ macros used for

[Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity

2015-01-14 Thread Frank Blaschka
Signed-off-by: Frank Blaschka --- hw/s390x/s390-pci-bus.c | 1 + hw/s390x/s390-pci-inst.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 1201b8d..546dcf1 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bu

[Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Bastian Koppelmann
There is no overview, that shows all the frontend operation one can use, as found on the wiki. Unfortunatly the wiki is out of date, so let's try to move this documentation to the source files, which has the benefit, that it is easy to update the documentation, if the frontend is changed. This patc

[Qemu-devel] [PATCH 2/4] blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro

2015-01-14 Thread Markus Armbruster
From: Markus Armbruster The QERR_ macros are leftovers from the days of "rich" error objects. They're used with error_set() and qerror_report(), and expand into the first *two* arguments. This trickiness has become pointless. Clean this one up. Signed-off-by: Markus Armbruster --- blockdev.c

Re: [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test

2015-01-14 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2015 10:50 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> balloon.c | 29 +++-- >> 1 file changed, 15 insertions(+), 14 deletions(-) >> >> diff --git a/balloon.c b/balloon.c >> index 2884c2d..aa30617 100644 >> --

[Qemu-devel] [PATCH 3/4] block: New bdrv_add_key(), convert monitor to use it

2015-01-14 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.c | 29 + blockdev.c| 24 ++-- include/block/block.h | 1 + monitor.c | 16 +++- qmp.c | 8 5 files changed, 47 insertions(+), 31

[Qemu-devel] [PATCH 1/4] blockdev: Give find_block_job() an Error ** parameter

2015-01-14 Thread Markus Armbruster
When find_block_job() fails, all its callers build the same Error object. Build it in find_block_job() instead. Signed-off-by: Markus Armbruster --- blockdev.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/blockdev.c b/blockdev.c index d59efd3..8d6ca35

[Qemu-devel] [PATCH 0/4] block: Cleanups around error reporting

2015-01-14 Thread Markus Armbruster
Markus Armbruster (4): blockdev: Give find_block_job() an Error ** parameter blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro block: New bdrv_add_key(), convert monitor to use it block: Eliminate silly QERR_ macros used for encryption keys block.c | 31 +

[Qemu-devel] [PATCH 4/4] block: Eliminate silly QERR_ macros used for encryption keys

2015-01-14 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. They're used with error_set() and qerror_report(), and expand into the first *two* arguments. This trickiness has become pointless. Clean up QERR_DEVICE_ENCRYPTED and QERR_DEVICE_NOT_ENCRYPTED. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-01-14 Thread Denis V. Lunev
On 14/01/15 17:26, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote: This is preparational commit for tweaks in Parallels image expansion. The idea is that enlarge via truncate by one data block is slow. It would be much better to use fallocate via bdrv_write_zer

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Markus Armbruster
Paolo Bonzini writes: > On 14/01/2015 11:20, Kevin Wolf wrote: >>> > The same problem applies to coroutine stacks, and those cannot be >>> > throttled down as easily. But I guess if you limit the number of >>> > threads, the guest gets slowed down and doesn't create as many coroutines. >> Should

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Denis V. Lunev
On 14/01/15 16:34, Roman Kagan wrote: On Wed, Jan 14, 2015 at 04:08:50PM +0300, Denis V. Lunev wrote: On 14/01/15 16:03, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: +static int cache_bat(BlockDriverState *bs, uint32_t idx, uint32_t new_data_off) +{ +i

Re: [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-01-14 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote: > This is preparational commit for tweaks in Parallels image expansion. > The idea is that enlarge via truncate by one data block is slow. It > would be much better to use fallocate via bdrv_write_zeroes and > expand by some significan

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Alexander Graf
On 01/14/15 15:07, Kevin Wolf wrote: Am 14.01.2015 um 14:49 hat Paolo Bonzini geschrieben: On 14/01/2015 14:38, Kevin Wolf wrote: Well, what do you want to use it for? I thought it would only be for a one-time check where we usually end up rather than something that would be enabled in product

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Kevin Wolf
Am 14.01.2015 um 14:49 hat Paolo Bonzini geschrieben: > > > On 14/01/2015 14:38, Kevin Wolf wrote: > > Well, what do you want to use it for? I thought it would only be for a > > one-time check where we usually end up rather than something that would > > be enabled in production, but maybe I misun

Re: [Qemu-devel] [PATCH 1/2] qed: check for header size overflow

2015-01-14 Thread Kevin Wolf
Am 12.01.2015 um 13:31 hat Stefan Hajnoczi geschrieben: > Header size is denoted in clusters. The maximum cluster size is 64 MB > but there is no limit on header size. Check for uint32_t overflow in > case the header size field has a whacky value. > > Signed-off-by: Stefan Hajnoczi > --- > blo

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-14 Thread Stefan Hajnoczi
On Tue, Jan 13, 2015 at 08:07:15PM +0100, Christian Borntraeger wrote: > Am 13.01.2015 um 17:04 schrieb Stefan Hajnoczi: > [...] > > I'm really starting to get worried that you are going to break things. > > This DASD hack is a layering violation but okay, go ahead if you want. > > But now you are

Re: [Qemu-devel] [PATCH 1/9] qmp hmp: Factor out common "using spice" test

2015-01-14 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2015 10:50 AM, Markus Armbruster wrote: >> Into qemu_using_spice(). For want of a better place, put it next the >> existing monitor command handler dummies in qemu-spice.h. >> >> Signed-off-by: Markus Armbruster >> --- >> include/ui/qemu-spice.h | 10 ++ >

Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use

2015-01-14 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2015 10:50 AM, Markus Armbruster wrote: >> Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, >> probably because adding another error seemed cumbersome overkill. >> Produces "No spice device has been activated", which is awkward. >> >> We've since aband

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 14:38, Kevin Wolf wrote: > Well, what do you want to use it for? I thought it would only be for a > one-time check where we usually end up rather than something that would > be enabled in production, but maybe I misunderstood. No, you didn't. Though I guess we could limit the chec

Re: [Qemu-devel] [RFC v3 2/2] hw/arm/virt: add generic-pci PCI host controller

2015-01-14 Thread alvise rigo
Hi Claudio, On Wed, Jan 14, 2015 at 2:10 PM, Claudio Fontana wrote: > On 14.01.2015 11:16, Alvise Rigo wrote: >> The platform memory map has now three more memory ranges to map the >> device's memory regions (Configuration region, I/O region and Memory >> region). >> >> The dt node interrupt-map

Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts

2015-01-14 Thread Eduardo Habkost
On Wed, Jan 14, 2015 at 02:24:57PM +0100, Paolo Bonzini wrote: > On 14/01/2015 14:17, Eduardo Habkost wrote: > >>> > > Do we have (or will patch 4/4 introduce) the same bug on the > >>> > > tcg_gen_addi_ptr() calls that don't use the XMM_Q macro? > >> > > >> > No, they all call into helpers that u

[Qemu-devel] [Bug 1410288] Re: qemu-img conversion to qcow2 hangs with blank image less than 100kiB

2015-01-14 Thread Neil Wilson
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1410288 Title: qemu-img conversion to qcow2 hangs with blank image less than 100kiB

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Kevin Wolf
Am 14.01.2015 um 12:18 hat Paolo Bonzini geschrieben: > > > On 14/01/2015 11:20, Kevin Wolf wrote: > >> > The same problem applies to coroutine stacks, and those cannot be > >> > throttled down as easily. But I guess if you limit the number of > >> > threads, the guest gets slowed down and doesn

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Roman Kagan
On Wed, Jan 14, 2015 at 04:08:50PM +0300, Denis V. Lunev wrote: > On 14/01/15 16:03, Roman Kagan wrote: > >On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: > >>+static int cache_bat(BlockDriverState *bs, uint32_t idx, uint32_t > >>new_data_off) > >>+{ > >>+int ret, i, off, cache

[Qemu-devel] [virtio] virtqueue allocation and thread-safety

2015-01-14 Thread Vasile Catalin-B50542
Hi, I'm trying to make a new virtio device. I got it running (I made a functional dummy device & guest driver). Now I'm trying to build some communication between the device and guest driver. I can't seem to find where the actual allocation of virtqueues are made. I've looked inside virtio_init

Re: [Qemu-devel] [PATCH 9/9] balloon: Eliminate silly QERR_ macros

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > They're used with error_set() and qerror_report(), and expand into the > first *two* arguments. This trickiness has become pointless. Clean > up. I like your wording in 6/9

Re: [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > balloon.c | 29 +++-- > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/balloon.c b/balloon.c > index 2884c2d..aa30617 100644 > --- a/balloon.c > +++ b/balloon.c

Re: [Qemu-devel] [PATCH 4/9] qmp: Clean up qmp_query_spice() #ifndef !CONFIG_SPICE dummy

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > QMP command query-spice exists only #ifdef CONFIG_SPICE. Due to QAPI > limitations, we need a dummy function anyway, but it's unreachable. > > Our current dummy function goes out of its way to produce the exact > same error as the QMP core does f

Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 14:17, Eduardo Habkost wrote: >>> > > Do we have (or will patch 4/4 introduce) the same bug on the >>> > > tcg_gen_addi_ptr() calls that don't use the XMM_Q macro? >> > >> > No, they all call into helpers that use the XMM_Q macro themselves. > tcg_gen_addi_ptr() is called sometimes

Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts

2015-01-14 Thread Eduardo Habkost
On Tue, Jan 13, 2015 at 08:49:19PM +0100, Paolo Bonzini wrote: > > > On 13/01/2015 19:48, Eduardo Habkost wrote: > >> > if (b1 & 1) { > >> > -gen_stq_env_A0(s, offsetof(CPUX86State, xmm_regs[reg])); > >> > +gen_stq_env_A0(s, offsetof(CPUX86State, > >>

Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, > probably because adding another error seemed cumbersome overkill. > Produces "No spice device has been activated", which is awkward. > > We've since abandoned our quest for "rich" er

Re: [Qemu-devel] [RFC v3 1/2] pci/pci-host: Add generic-pci PCI host controller device

2015-01-14 Thread Claudio Fontana
On 14.01.2015 11:16, Alvise Rigo wrote: > Add a generic PCI host controller for virtual platforms, based on the > previous work by Rob Herring: > http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03482.html > > The controller relies on a configuration memory region and provides two > PCI mem

Re: [Qemu-devel] [PATCH 1/9] qmp hmp: Factor out common "using spice" test

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Into qemu_using_spice(). For want of a better place, put it next the > existing monitor command handler dummies in qemu-spice.h. > > Signed-off-by: Markus Armbruster > --- > include/ui/qemu-spice.h | 10 ++ > monitor.c |

Re: [Qemu-devel] [RFC v3 2/2] hw/arm/virt: add generic-pci PCI host controller

2015-01-14 Thread Claudio Fontana
On 14.01.2015 11:16, Alvise Rigo wrote: > The platform memory map has now three more memory ranges to map the > device's memory regions (Configuration region, I/O region and Memory > region). > > The dt node interrupt-map property tells how to route the PCI interrupts > to system interrupts. In th

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Denis V. Lunev
On 14/01/15 16:03, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: The idea is that we do not need to immediately sync BAT to the image as from the guest point of view there is a possibility that IO is lost even in the physical controller until flush command wa

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: > The idea is that we do not need to immediately sync BAT to the image as > from the guest point of view there is a possibility that IO is lost > even in the physical controller until flush command was finished. > bdrv_co_flush_to_os i

Re: [Qemu-devel] [PATCH 16/19] block/parallels: no need to flush on each block allocation table update

2015-01-14 Thread Denis V. Lunev
On 14/01/15 15:01, Roman Kagan wrote: On Tue, Jan 13, 2015 at 11:16:04PM +0300, Denis V. Lunev wrote: On 13/01/15 18:17, Denis V. Lunev wrote: On 13/01/15 17:50, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:09PM +0300, Denis V. Lunev wrote: --- a/block/parallels.c +++ b/block/parallels.c

Re: [Qemu-devel] [PATCH 6/9] block-migration: tiny refactoring

2015-01-14 Thread Vladimir Sementsov-Ogievskiy
On 09.01.2015 00:23, John Snow wrote: On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add blk_create and blk_free to remove code duplicates. Otherwise, duplicates will rise in the following patches because of BlkMigBlock sturcture extendin. Signed-off-by: Vladimir Sementsov-Ogievs

Re: [Qemu-devel] [PATCH] pseries: Limit PCI host bridge "index" value

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 03:33, David Gibson wrote: > pseries guests can have large numbers of PCI host bridges. To avoid the > user having to specify a number of different configuration values for every > one, the device supports an "index" property which is a shorthand setting > the various window and co

Re: [Qemu-devel] [PATCH 16/19] block/parallels: no need to flush on each block allocation table update

2015-01-14 Thread Roman Kagan
On Tue, Jan 13, 2015 at 11:16:04PM +0300, Denis V. Lunev wrote: > On 13/01/15 18:17, Denis V. Lunev wrote: > >On 13/01/15 17:50, Roman Kagan wrote: > >>On Tue, Dec 30, 2014 at 01:07:09PM +0300, Denis V. Lunev wrote: > >>>--- a/block/parallels.c > >>>+++ b/block/parallels.c > >>>@@ -194,7 +194,7 @@

Re: [Qemu-devel] [RFH PATCH 2/2] xen: add a lock for the mapcache

2015-01-14 Thread Stefano Stabellini
On Wed, 14 Jan 2015, Paolo Bonzini wrote: > Extend the existing dummy mapcache_lock/unlock macros to cover all of > xen-mapcache.c. This prepares for unlocked memory access, when parts > of exec.c will not be protected by the BQL. > > Signed-off-by: Paolo Bonzini Acked-by: Stefano Stabellini

Re: [Qemu-devel] [RFH PATCH 1/2] xen: do not use __-named variables in mapcache

2015-01-14 Thread Stefano Stabellini
On Wed, 14 Jan 2015, Paolo Bonzini wrote: > Keep the namespace clean. > > Signed-off-by: Paolo Bonzini Acked-by: Stefano Stabellini > xen-mapcache.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a/xen-mapcache.c b/xen-mapca

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-14 Thread Stefano Stabellini
On Tue, 13 Jan 2015, Don Slutz wrote: > On 01/13/15 13:07, Stefano Stabellini wrote: > > On Mon, 12 Jan 2015, Stefano Stabellini wrote: > >> On Wed, 3 Dec 2014, Don Slutz wrote: > >>> From: Stefano Stabellini > >>> > >>> Increase maxmem before calling xc_domain_populate_physmap_exact to > >>> avoi

Re: [Qemu-devel] [PATCH 5/9] block: BdrvDirtyBitmap store/restore interface

2015-01-14 Thread Vladimir Sementsov-Ogievskiy
As in previous patch, rename store/restore to serialize/deserialize... Hmm. In this case, isn't it be better to include serialization of granularity, name and name length in these functions? Best regards, Vladimir On 11.12.2014 17:17, Vladimir Sementsov-Ogievskiy wrote: Several functions to

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 11:20, Kevin Wolf wrote: >> > The same problem applies to coroutine stacks, and those cannot be >> > throttled down as easily. But I guess if you limit the number of >> > threads, the guest gets slowed down and doesn't create as many coroutines. > Shouldn't we rather try and decrea

Re: [Qemu-devel] [PATCH] block: update string sizes for filename, backing_file, exact_filename

2015-01-14 Thread Kevin Wolf
Am 13.01.2015 um 21:49 hat John Snow geschrieben: > > > On 01/13/2015 12:03 PM, Jeff Cody wrote: > >The string field entries 'filename', 'backing_file', and > >'exact_filename' in the BlockDriverState struct are defined as 1024 > >bytes. > > > >However, most places that use these values accept a

Re: [Qemu-devel] [PATCH 4/9] hbitmap: store / restore

2015-01-14 Thread Vladimir Sementsov-Ogievskiy
Best regards, Vladimir On 13.01.2015 20:08, John Snow wrote: On 01/13/2015 07:59 AM, Vladimir Sementsov-Ogievskiy wrote: On 09.01.2015 00:21, John Snow wrote: On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: +/** + * hbitmap_restore_finish + * @hb: HBitmap to operate on. + *

Re: [Qemu-devel] [RFC PATCH v7 08/21] replay: interrupts and exceptions

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 11:06, Pavel Dovgaluk wrote: >> > I think it is okay. INIT executes cpu_loop_exit() on x86 because >> > processors other than the boot processor are halted after they receive >> > INIT. > Then I cannot put everything in one if-else chain because it will change the > behavior of t

  1   2   >