Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD

2015-01-20 Thread Markus Armbruster
Programmingkid programmingk...@gmail.com writes: Subject was: Re: [PATCH v7] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD Patch history information goes... This patch allows Mac OS X to use a real CDROM disc in QEMU. Testing

Re: [Qemu-devel] [RFC 42/47] acpi: make tables linker-loader available to other targets

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 00:05:15 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 19, 2014 at 02:02:37AM +, Igor Mammedov wrote: keeping bios-linker-loader.c i386 specific would break build of mips target which is built with CONFIG_ACPI which would dependend on it in following

Re: [Qemu-devel] [v6][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support

2015-01-20 Thread Gerd Hoffmann
On Di, 2015-01-20 at 11:14 +0800, Chen, Tiejun wrote: On 2015/1/19 19:45, Gerd Hoffmann wrote: On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote: +DEF(gfx_passthru, 0, QEMU_OPTION_gfx_passthru, +-gfx_passthru enable Intel IGD passthrough by XEN\n, +QEMU_ARCH_ALL) +STEXI

Re: [Qemu-devel] [PATCH v3 7/8] acpi: drop min-bytes in build_package()

2015-01-20 Thread Claudio Fontana
Reviewed-by: Claudio Fontana claudio.font...@huawei.com On 19.12.2014 12:47, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/acpi_gen_utils.c | 14 -- hw/i386/acpi-build.c | 13 ++--- include/hw/acpi/acpi_gen_utils.h

[Qemu-devel] [PATCH v2 1/1] Print PID and time in stderr traces

2015-01-20 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com When debugging migration it's useful to know the PID of each trace message so you can figure out if it came from the source or the destination. Printing the time makes it easy to do latency measurements or timings between trace points.

Re: [Qemu-devel] [RFC 41/47] pc: acpi-build: create PCI0._CRS dynamically

2015-01-20 Thread Igor Mammedov
On Mon, 19 Jan 2015 23:55:37 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jan 19, 2015 at 01:42:25PM +0100, Paolo Bonzini wrote: On 19/12/2014 03:02, Igor Mammedov wrote: Replace template patching and runtime calculation in _CRS() method with static _CRS defined in

[Qemu-devel] [PATCH] qdev: Don't exit when running into bad -global

2015-01-20 Thread Markus Armbruster
-global lets you set a nice booby-trap for yourself: $ qemu-system-x86_64 -nodefaults -S -display none -usb -monitor stdio -global usb-mouse.usb_version=l QEMU 2.1.94 monitor - type 'help' for more information (qemu) device_add usb-mouse Parameter 'usb_version' expects an int64

Re: [Qemu-devel] [PATCH v11 03/13] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-01-20 Thread Markus Armbruster
John Snow js...@redhat.com writes: On 01/19/2015 05:08 AM, Markus Armbruster wrote: John Snow js...@redhat.com writes: On 01/16/2015 10:36 AM, Max Reitz wrote: On 2015-01-12 at 11:30, John Snow wrote: From: Fam Zheng f...@redhat.com The new command pair is added to manage user created

Re: [Qemu-devel] [RFC 41/47] pc: acpi-build: create PCI0._CRS dynamically

2015-01-20 Thread Marcel Apfelbaum
On 01/19/2015 11:55 PM, Michael S. Tsirkin wrote: On Mon, Jan 19, 2015 at 01:42:25PM +0100, Paolo Bonzini wrote: On 19/12/2014 03:02, Igor Mammedov wrote: Replace template patching and runtime calculation in _CRS() method with static _CRS defined in SSDT. It also drops manual hole patching

Re: [Qemu-devel] [PATCH v3 2/8] pc: acpi: decribe bridge device as not hotpluggable

2015-01-20 Thread Igor Mammedov
On Mon, 19 Jan 2015 14:46:38 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 19, 2014 at 11:46:58AM +, Igor Mammedov wrote: when bridge hotplug is disabled, i.e. for machine types less then 2.0, bridge device was created as hotpluggable by mistake since commit 133a2da

Re: [Qemu-devel] [PATCH v3 5/8] acpi: move generic aml building helpers into dedictated file

2015-01-20 Thread Igor Mammedov
On Mon, 19 Jan 2015 17:08:43 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 19, 2014 at 11:47:01AM +, Igor Mammedov wrote: the will be later used for composing AML primitives and all that could be reused later for ARM machines as well. Signed-off-by: Igor Mammedov

[Qemu-devel] target-tricore: Possible bug in get_mtcr()

2015-01-20 Thread Markus Armbruster
Coverity[*] points out: *** CID 1264337: Logically dead code (DEADCODE) /target-tricore/translate.c: 348 in gen_mtcr() 342 #define E(ADDRESS, REG, FEATURE) A(ADDRESS, REG, FEATURE) 343 static inline void gen_mtcr(CPUTriCoreState *env, DisasContext *ctx, TCGv r1, 344

Re: [Qemu-devel] [RFC 14/47] acpi: add acpi_notify() term

2015-01-20 Thread Igor Mammedov
On Mon, 19 Jan 2015 13:32:48 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 19/12/2014 03:02, Igor Mammedov wrote: +AcpiAml var = aml_allocate_internal(0, NON_BLOCK); +build_append_byte(var.buf, 0x86); /* NotifyOp */ \ Extra backslash. Thanks, I'll fix it. Paolo +

[Qemu-devel] [PATCH] qemu-ga-win: Document 'guest-set-time' limitation

2015-01-20 Thread Michal Privoznik
The command implementation for Windows guest has this limitation. If no time to set has been provided the documentation for the command states that time should be read from RTC. However, on Windows bare GetSystemTime() is used, which does not read anything from RTC rather than return system time.

Re: [Qemu-devel] [PATCH v3 5/8] acpi: move generic aml building helpers into dedictated file

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 10:24:41AM +0100, Igor Mammedov wrote: On Mon, 19 Jan 2015 17:08:43 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 19, 2014 at 11:47:01AM +, Igor Mammedov wrote: the will be later used for composing AML primitives and all that could be reused

Re: [Qemu-devel] [PATCH v3 8/8] pc: acpi-build: simplify PCI bus tree generation

2015-01-20 Thread Igor Mammedov
On Mon, 19 Jan 2015 17:23:41 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 19, 2014 at 11:47:04AM +, Igor Mammedov wrote: it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops

Re: [Qemu-devel] [v6][PATCH 01/10] i440fx: make types configurable at run-time

2015-01-20 Thread Gerd Hoffmann
On Di, 2015-01-20 at 10:48 +0800, Chen, Tiejun wrote: On 2015/1/19 19:36, Gerd Hoffmann wrote: On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote: From: Michael S. Tsirkin m...@redhat.com Xen wants to supply a different pci and host devices, inheriting i440fx devices. Make types

Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions

2015-01-20 Thread Markus Armbruster
This patch makes Coverity unhappy: *** CID 1264326: Unintended sign extension (SIGN_EXTENSION) /hw/s390x/s390-pci-inst.c: 787 in stpcifc_service_call() 781 stq_p(fib.pal, pbdev-pal); 782 stq_p(fib.iota, pbdev-g_iota); 783 stq_p(fib.aibv, pbdev-routes.adapter.ind_addr);

Re: [Qemu-devel] [PATCH] s390: Plug memory leak on s390_pci_generate_event() error path

2015-01-20 Thread Paolo Bonzini
On 20/01/2015 10:56, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/s390x/s390-pci-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 1201b8d..d25ac74 100644 ---

Re: [Qemu-devel] [PATCH RFC v6 08/20] dataplane: allow virtio-1 devices

2015-01-20 Thread Cornelia Huck
On Tue, 20 Jan 2015 10:43:31 + Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Dec 11, 2014 at 02:25:10PM +0100, Cornelia Huck wrote: Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. Signed-off-by: Cornelia

Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions

2015-01-20 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Cornelia Huck cornelia.h...@de.ibm.com writes: On Tue, 20 Jan 2015 10:45:41 +0100 Markus Armbruster arm...@redhat.com wrote: This patch makes Coverity unhappy: *** CID 1264326: Unintended sign extension (SIGN_EXTENSION)

Re: [Qemu-devel] [PATCH] kvm/apic: fix 2.2-2.1 migration

2015-01-20 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The wait_for_sipi field is set back to 1 after an INIT, so it was not effective to reset it in kvm_apic_realize. Introduce a reset callback and reset wait_for_sipi there. Reported-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v2 1/4] pc: append ssdt-misc.dsl to the DSDT

2015-01-20 Thread Igor Mammedov
On Mon, 19 Jan 2015 21:29:57 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jan 19, 2015 at 06:26:55PM +0100, Paolo Bonzini wrote: On 19/01/2015 18:14, Igor Mammedov wrote: I'm fine with moving SMC out of the per-machine-type AML, should be a separate patch anyway. But

Re: [Qemu-devel] [PATCH 0/2] qcow2: Add two more unalignment checks

2015-01-20 Thread Kevin Wolf
Am 19.01.2015 um 22:09 hat Max Reitz geschrieben: On 2015-01-19 at 16:04, Eric Blake wrote: On 01/19/2015 01:49 PM, Max Reitz wrote: With the series adding unalignment checks and the series reworking the zero cluster expansion code overlapping, the unalignment checks have not been implemented

Re: [Qemu-devel] [PATCH 0/5] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-01-20 Thread Sergey Fedorov
On 20.01.2015 01:30, Greg Bellows wrote: Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64 execution state

[Qemu-devel] [Bug 1323001] Re: Netlink socket support for MIPS*

2015-01-20 Thread Luca Falavigna
** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1323001 Title: Netlink socket support for MIPS* Status in QEMU: Fix Released Bug

Re: [Qemu-devel] [PATCH v3 0/5] Migration Deciphering aid

2015-01-20 Thread Amit Shah
On (Fri) 26 Dec 2014 [15:42:43], Alexander Graf wrote: Migration is a black hole to most people. One of the biggest reasons for this is that its protocol is a secret, undocumented sauce of code rolling around random parts of the QEMU code base. But what if we simply exposed the description

Re: [Qemu-devel] [PATCH v2 1/4] pc: append ssdt-misc.dsl to the DSDT

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 10:59:43AM +0100, Igor Mammedov wrote: On Mon, 19 Jan 2015 21:29:57 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jan 19, 2015 at 06:26:55PM +0100, Paolo Bonzini wrote: On 19/01/2015 18:14, Igor Mammedov wrote: I'm fine with moving SMC out of

Re: [Qemu-devel] [PATCH 1/7] isa: add memory space parameter to isa_bus_new

2015-01-20 Thread Paolo Bonzini
On 19/01/2015 22:28, Hervé Poussineau wrote: diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f0a3201..8f932c9 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -208,7 +208,7 @@ static void pc_init1(MachineState *machine, } else { pci_bus = NULL;

Re: [Qemu-devel] [PATCH v2 4/7] console-gl: add opengl rendering helper functions

2015-01-20 Thread Gerd Hoffmann
Hi, +static GLchar texture_blit_vert_src[] = +\n +#version 300 es\n +\n +in vec2 in_position;\n +in vec2 in_tex_coord;\n You could calculate the texture coordinate from the position in the shader, but this is mostly my premature optimization instinct

Re: [Qemu-devel] [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote: From: Thomas Huth th...@linux.vnet.ibm.com Handle the virtio-ccw revision according to what the guest sets. When revision 1 is selected, we have a virtio-1 standard device with byteswapping for the virtio rings. When a channel

Re: [Qemu-devel] [PATCH RFC v6 11/20] s390x/virtio-ccw: support virtio-1 set_vq format

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:13PM +0100, Cornelia Huck wrote: Support the new CCW_CMD_SET_VQ format for virtio-1 devices. While we're at it, refactor the code a bit and enforce big endian fields (which had always been required, even for legacy). Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264

2015-01-20 Thread Peter Maydell
On 20 January 2015 at 09:59, Markus Armbruster arm...@redhat.com wrote: Commit fecd264 added a number of fall-throughs, but neglected to properly document them as intentional. Commit d922445 cleaned that up for many, but not all cases. Take care of the remaining ones. Spotted by Coverity.

[Qemu-devel] [PULL 0/4] Xen tree 2015-01-20

2015-01-20 Thread Stefano Stabellini
The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1' into staging (2015-01-19 13:37:05 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions

2015-01-20 Thread Cornelia Huck
On Tue, 20 Jan 2015 10:45:41 +0100 Markus Armbruster arm...@redhat.com wrote: This patch makes Coverity unhappy: *** CID 1264326: Unintended sign extension (SIGN_EXTENSION) /hw/s390x/s390-pci-inst.c: 787 in stpcifc_service_call() 781 stq_p(fib.pal, pbdev-pal); 782

Re: [Qemu-devel] [PATCH v0 1/2] pc: Fix DIMMs capacity calculation

2015-01-20 Thread Igor Mammedov
On Mon, 12 Jan 2015 09:32:33 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: pc_existing_dimms_capacity() is returning DIMMs count rather than capacity. Fix this to return the capacity. Also consider only realized devices for capacity calculation. Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [PATCH 0/2] virtio-blk: Switch to blk_aio_ioctl

2015-01-20 Thread Paolo Bonzini
On 20/01/2015 04:28, Fam Zheng wrote: There are user complaints on guest's unresponsiveness when ioctl is blocked due to the lost connection to backend or other issues. This series changes scsi request processing of virtio-blk to an asynchronous manner. Fam Zheng (2): virtio-blk:

Re: [Qemu-devel] [PULL 00/16] Block patches

2015-01-20 Thread Stefan Hajnoczi
On Sat, Jan 17, 2015 at 11:41:59AM +0100, Peter Wu wrote: On Friday 16 January 2015 16:46:39 Peter Maydell wrote: CentOS5: ../block/dmg.o: In function `dmg_read_plist_xml': /home/petmay01/linaro/qemu-for-merges/block/dmg.c:414: undefined reference to `g_base64_decode_inplace' Should

Re: [Qemu-devel] [PATCH 0/5] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-01-20 Thread Peter Maydell
On 20 January 2015 at 10:21, Sergey Fedorov serge.f...@gmail.com wrote: aarch64-softmmu/qemu-system-aarch64 -M virt -cpu cortex-a57,-aarch64 ... It seems a little confusing for me to specify '-aarch64' when forcing AArch32 execution state. Why don't just specify 'aarch32' in command line

Re: [Qemu-devel] [v6][PATCH 07/10] xen, gfx passthrough: register a isa bridge

2015-01-20 Thread Michael S. Tsirkin
On Mon, Jan 19, 2015 at 05:28:40PM +0800, Tiejun Chen wrote: Currently IGD drivers always need to access PCH by 1f.0. But we don't want to poke that directly to get ID, and although in real world different GPU should have different PCH. But actually the different PCH DIDs likely map to

Re: [Qemu-devel] [v6][PATCH 07/10] xen, gfx passthrough: register a isa bridge

2015-01-20 Thread Michael S. Tsirkin
On Mon, Jan 19, 2015 at 05:28:40PM +0800, Tiejun Chen wrote: Currently IGD drivers always need to access PCH by 1f.0. But we don't want to poke that directly to get ID, and although in real world different GPU should have different PCH. But actually the different PCH DIDs likely map to

Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2015-01-20 Thread Stefan Hajnoczi
On Fri, Dec 12, 2014 at 12:25:47PM +0100, Thomas Huth wrote: On Fri, 12 Dec 2014 12:18:25 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Fri, 12 Dec 2014 11:55:38 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: On Thu, 11 Dec 2014 14:25:14 +0100 Cornelia Huck

Re: [Qemu-devel] [PATCH v2 7/7] sdl2: add support for display rendering using opengl.

2015-01-20 Thread Gerd Hoffmann
Hi, +void sdl2_gl_switch(DisplayChangeListener *dcl, +DisplaySurface *new_surface) +{ +struct sdl2_console *scon = container_of(dcl, struct sdl2_console, dcl); +DisplaySurface *old_surface = scon-surface; + +assert(scon-opengl); + +

Re: [Qemu-devel] [v6][PATCH 03/10] piix: create host bridge to passthrough

2015-01-20 Thread Jike Song
On 01/20/2015 10:52 AM, Chen, Tiejun wrote: On 2015/1/19 19:40, Gerd Hoffmann wrote: On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote: +static void xen_igd_passthrough_i440fx_class_init(ObjectClass *klass, + void *data) +{ +DeviceClass

Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264

2015-01-20 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 20 January 2015 at 09:59, Markus Armbruster arm...@redhat.com wrote: Commit fecd264 added a number of fall-throughs, but neglected to properly document them as intentional. Commit d922445 cleaned that up for many, but not all cases. Take

Re: [Qemu-devel] [PATCH 2/2] m48t59: add mem_base value to m48t59_init_isa()

2015-01-20 Thread Artyom Tarasenko
On Mon, Jan 19, 2015 at 9:03 PM, Andreas Färber afaer...@suse.de wrote: Am 19.01.2015 um 16:22 schrieb Artyom Tarasenko: On Mon, Jan 19, 2015 at 4:01 PM, Andreas Färber afaer...@suse.de wrote: Am 19.01.2015 um 13:57 schrieb Artyom Tarasenko: On Mon, Jan 19, 2015 at 1:45 PM, Paolo Bonzini

Re: [Qemu-devel] [PATCH v3 4/5] migration: Append JSON description of migration stream

2015-01-20 Thread Amit Shah
On (Fri) 26 Dec 2014 [15:42:47], Alexander Graf wrote: One of the annoyances of the current migration format is the fact that it's not self-describing. In fact, it's not properly describing at all. Some code randomly scattered throughout QEMU elaborates roughly how to read and write a stream

Re: [Qemu-devel] [PATCH RFC v6 06/20] virtio: endianness checks for virtio 1.0 devices

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:08PM +0100, Cornelia Huck wrote: Add code that checks for the VERSION_1 feature bit in order to make decisions about the device's endianness. This allows us to support transitional devices. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug.

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 11:03:02AM +0100, Igor Mammedov wrote: On Mon, 19 Jan 2015 23:29:37 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jan 07, 2015 at 02:49:40PM +0800, Tang Chen wrote: Memory and CPU hot unplug are both asynchronize procedures. When the unplug operation

Re: [Qemu-devel] [v6][PATCH 08/10] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2015-01-20 Thread Michael S. Tsirkin
On Mon, Jan 19, 2015 at 05:28:41PM +0800, Tiejun Chen wrote: Some registers of Intel IGD are mapped in host bridge, so it needs to passthrough these registers of physical host bridge to guest because emulated host bridge in guest doesn't have these mappings. Signed-off-by: Tiejun Chen

[Qemu-devel] [PULL 2/4] Xen: Use the ioreq-server API when available

2015-01-20 Thread Stefano Stabellini
From: Paul Durrant paul.durr...@citrix.com The ioreq-server API added to Xen 4.5 offers better security than the existing Xen/QEMU interface because the shared pages that are used to pass emulation request/results back and forth are removed from the guest's memory space before any requests are

[Qemu-devel] [PULL 1/4] Add device listener interface

2015-01-20 Thread Stefano Stabellini
From: Paul Durrant paul.durr...@citrix.com The Xen ioreq-server API, introduced in Xen 4.5, requires that PCI device models explicitly register with Xen for config space accesses. This patch adds a listener interface into qdev-core which can be used by the Xen interface code to monitor for

Re: [Qemu-devel] [PATCH v2 1/4] pc: append ssdt-misc.dsl to the DSDT

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 12:35:47 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jan 20, 2015 at 10:59:43AM +0100, Igor Mammedov wrote: On Mon, 19 Jan 2015 21:29:57 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jan 19, 2015 at 06:26:55PM +0100, Paolo Bonzini wrote:

Re: [Qemu-devel] [PATCH v2 1/4] pc: append ssdt-misc.dsl to the DSDT

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 01:41:16PM +0100, Igor Mammedov wrote: On Tue, 20 Jan 2015 12:35:47 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jan 20, 2015 at 10:59:43AM +0100, Igor Mammedov wrote: On Mon, 19 Jan 2015 21:29:57 +0200 Michael S. Tsirkin m...@redhat.com wrote:

[Qemu-devel] [PATCH] apic: do not dereference pointer before it is checked for NULL

2015-01-20 Thread Paolo Bonzini
Right now you only get to apic_init_reset if you have an APIC (do_cpu_init is reached only if CPU_INTERRUPT_INIT is set and that only happens in hw/intc/apic.c). However, this is wrong because for example a port 92 or keyboard controller reset is really an INIT, and that can happen also with no

Re: [Qemu-devel] [PATCH v3 0/5] Migration Deciphering aid

2015-01-20 Thread Alexander Graf
On 20.01.15 11:31, Amit Shah wrote: On (Fri) 26 Dec 2014 [15:42:43], Alexander Graf wrote: Migration is a black hole to most people. One of the biggest reasons for this is that its protocol is a secret, undocumented sauce of code rolling around random parts of the QEMU code base. But what

Re: [Qemu-devel] [v6][PATCH 01/10] i440fx: make types configurable at run-time

2015-01-20 Thread Jike Song
On 01/20/2015 04:25 PM, Gerd Hoffmann wrote: On Di, 2015-01-20 at 10:48 +0800, Chen, Tiejun wrote: On 2015/1/19 19:36, Gerd Hoffmann wrote: On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote: From: Michael S. Tsirkin m...@redhat.com Xen wants to supply a different pci and host devices,

Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions

2015-01-20 Thread Markus Armbruster
Cornelia Huck cornelia.h...@de.ibm.com writes: On Tue, 20 Jan 2015 10:45:41 +0100 Markus Armbruster arm...@redhat.com wrote: This patch makes Coverity unhappy: *** CID 1264326: Unintended sign extension (SIGN_EXTENSION) /hw/s390x/s390-pci-inst.c: 787 in stpcifc_service_call() 781

Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug.

2015-01-20 Thread Igor Mammedov
On Mon, 19 Jan 2015 23:29:37 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jan 07, 2015 at 02:49:40PM +0800, Tang Chen wrote: Memory and CPU hot unplug are both asynchronize procedures. When the unplug operation happens, unplug request cb is called first. And when ghest OS

Re: [Qemu-devel] [PATCH RFC v6 08/20] dataplane: allow virtio-1 devices

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:10PM +0100, Cornelia Huck wrote: Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/block/dataplane/virtio-blk.c |

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Xu, Quan wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Tuesday, January 20, 2015 1:15 AM To: Xu, Quan Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; stefano.stabell...@eu.citrix.com Subject: Re:

Re: [Qemu-devel] [PATCH RFC v6 09/20] s390x/css: Add a callback for when subchannel gets disabled

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:11PM +0100, Cornelia Huck wrote: From: Thomas Huth th...@linux.vnet.ibm.com We need a possibility to run code when a subchannel gets disabled. This patch adds the necessary infrastructure. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by:

[Qemu-devel] [PULL 4/4] xen: add a lock for the mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini pbonz...@redhat.com Extend the existing dummy mapcache_lock/unlock macros to cover all of xen-mapcache.c. This prepares for unlocked memory access, when parts of exec.c will not be protected by the BQL. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- xen-mapcache.c |

Re: [Qemu-devel] [PULL 0/4] Xen tree 2015-01-20

2015-01-20 Thread Peter Maydell
On 20 January 2015 at 11:19, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1' into staging (2015-01-19 13:37:05 +) are

[Qemu-devel] [PATCH] s390: Plug memory leak on s390_pci_generate_event() error path

2015-01-20 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/s390x/s390-pci-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 1201b8d..d25ac74 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@

Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Xu, Quan wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Tuesday, January 20, 2015 1:15 AM To: Xu, Quan Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; stefano.stabell...@eu.citrix.com Subject: Re:

Re: [Qemu-devel] [PATCH RFC v6 15/20] virtio-net: no writeable mac for virtio-1

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:17PM +0100, Cornelia Huck wrote: Devices operating as virtio 1.0 may not allow writes to the mac address in config space. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/net/virtio-net.c |1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264

2015-01-20 Thread Markus Armbruster
Commit fecd264 added a number of fall-throughs, but neglected to properly document them as intentional. Commit d922445 cleaned that up for many, but not all cases. Take care of the remaining ones. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com ---

Re: [Qemu-devel] [PATCH 0/2] m48t59: add year offset and MMIO ISA mapping

2015-01-20 Thread Artyom Tarasenko
On Mon, Jan 19, 2015 at 10:59 PM, Hervé Poussineau hpous...@reactos.org wrote: Le 19/01/2015 12:35, Mark Cave-Ayland a écrit : This patch lays the groundwork for switching sun4u over from ioport NVRAM access to MMIO NVRAM access. Patch 1 introduces a new year_offset property which is the

Re: [Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-20 Thread Igor Mammedov
On Mon, 12 Jan 2015 09:32:34 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed by PowerPC memory hotplug code too. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- hw/i386/pc.c | 24

Re: [Qemu-devel] [PATCH v2 1/4] pc: append ssdt-misc.dsl to the DSDT

2015-01-20 Thread Paolo Bonzini
On 20/01/2015 10:59, Igor Mammedov wrote: Yes, trimming is better than putting it in the DSDT, at least for simple devices such as SMC and pvpanic. So are we dropping 1-2/4 from this series? I need to know on top of what to rebase. I'll take care of moving SMC to SSDT. Do not rebase on

Re: [Qemu-devel] [PATCH v3 0/3] move ssdt-misc.dsl to the DSDT

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 08:05:04 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 19/01/2015 22:31, Michael S. Tsirkin wrote: On Mon, Jan 19, 2015 at 05:56:24PM +0100, Paolo Bonzini wrote: See v2 for motivation. v2-v3: dropped pointer passing and patch 4. Thanks! Igor - ok with

Re: [Qemu-devel] [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote: @@ -608,6 +631,25 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) } } break; +case CCW_CMD_SET_VIRTIO_REV: +len = sizeof(revinfo); +if (ccw.count len || (check_len

Re: [Qemu-devel] [PATCH RFC v6 14/20] s390x/virtio-ccw: enable virtio 1.0

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:16PM +0100, Cornelia Huck wrote: virtio-ccw should now have everything in place to operate virtio 1.0 devices, so let's enable revision 1. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/virtio-ccw.h |2 +- 1 file changed, 1

[Qemu-devel] [PULL 3/4] xen: do not use __-named variables in mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini pbonz...@redhat.com Keep the namespace clean. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- xen-mapcache.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c index

Re: [Qemu-devel] [PATCH] apic: do not dereference pointer before it is checked for NULL

2015-01-20 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Right now you only get to apic_init_reset if you have an APIC (do_cpu_init is reached only if CPU_INTERRUPT_INIT is set and that only happens in hw/intc/apic.c). However, this is wrong because for example a port 92 or keyboard controller reset is

Re: [Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrupt

2015-01-20 Thread Paolo Bonzini
On 08/01/2015 19:38, Frediano Ziglio wrote: Test behaviour of timers and interrupts related to timeouts. Signed-off-by: Frediano Ziglio fredd...@gmail.com --- tests/Makefile | 2 +- tests/rtl8139-test.c | 181 +++ 2 files

[Qemu-devel] [PATCH] target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT

2015-01-20 Thread Peter Maydell
The LDT/STT (load/store unprivileged) instruction decode was using the wrong MMU index value. This meant that instead of these insns being always access as if user-mode regardless of current privilege they were always access as if kernel-mode regardless of current privilege. This went unnoticed

[Qemu-devel] [PULL v2 2/4] Xen: Use the ioreq-server API when available

2015-01-20 Thread Stefano Stabellini
From: Paul Durrant paul.durr...@citrix.com The ioreq-server API added to Xen 4.5 offers better security than the existing Xen/QEMU interface because the shared pages that are used to pass emulation request/results back and forth are removed from the guest's memory space before any requests are

[Qemu-devel] [PULL v2 3/4] xen: do not use __-named variables in mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini pbonz...@redhat.com Keep the namespace clean. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- xen-mapcache.c | 40 1 file changed, 20 insertions(+), 20

Re: [Qemu-devel] [PATCH 0/2] target-s390x: fixes for GMP testsuite

2015-01-20 Thread Paolo Bonzini
On 08/01/2015 18:01, Paolo Bonzini wrote: Reported and tested by Torbjorn. One patch is mine, one is his. Paolo Bonzini (1): target-s390x: support OC and NC in the EX instruction Torbjorn Granlund (1): target-s390x: fix and optimize slb* and slbg* computation of carry/borrow

[Qemu-devel] Exposing different e1000 models through cmdline

2015-01-20 Thread Peter Lieven
Hi, I found that vmware emulates a 82545em per default and so some special crafted appliances only work with that card. I was wondering if the below is the right approach to make the models selectable via cmdline without changing the default: diff --git a/hw/pci/pci.c b/hw/pci/pci.c index

Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD

2015-01-20 Thread Programmingkid
On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote: Programmingkid programmingk...@gmail.com writes: Subject was: Re: [PATCH v7] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD Patch history information goes... This patch

Re: [Qemu-devel] KVM call for agenda for 2015-01-20

2015-01-20 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: By popular demand, a google calendar public entry with it As there are no agenda, call gets cancelled. Sorry for the late notification.

Re: [Qemu-devel] [PATCH v2 4/7] console-gl: add opengl rendering helper functions

2015-01-20 Thread Gerd Hoffmann
Hi, This looks like a list for GL_TRIANGLES instead of GL_TRIANGLE_STRIP. For GL_TRIANGLE_STRIP, you first define one whole triangle (by specifying each of the three vertices) and after that, each vertex results in a new triangle drawn (whose two other vertices are the two vertices

Re: [Qemu-devel] [PATCH 4/7] ppc: move sdr1 value change detection logic to helper_store_sdr1()

2015-01-20 Thread Paolo Bonzini
On 23/12/2014 01:36, Mark Cave-Ayland wrote: Otherwise when cpu_post_load calls ppc_store_sdr1() when restoring a VM snapshot the value is deemed unchanged and so the internal env-htab* variables aren't set correctly. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk CC: Paolo

Re: [Qemu-devel] [PATCH 5/7] ppc: force update of all msr bits in cpu_post_load

2015-01-20 Thread Paolo Bonzini
On 23/12/2014 01:36, Mark Cave-Ayland wrote: Since env-msr has already been restored by the time cpu_post_load is called, make sure that ppc_store_msr() is explicitly called with all msr bits marked as invalid. This solves the issue where MSR flags aren't set correctly when restoring a VM

Re: [Qemu-devel] [PATCH 0/2] qcow2: Add two more unalignment checks

2015-01-20 Thread Max Reitz
On 2015-01-20 at 05:09, Kevin Wolf wrote: Am 19.01.2015 um 22:09 hat Max Reitz geschrieben: On 2015-01-19 at 16:04, Eric Blake wrote: On 01/19/2015 01:49 PM, Max Reitz wrote: With the series adding unalignment checks and the series reworking the zero cluster expansion code overlapping, the

Re: [Qemu-devel] Exposing different e1000 models through cmdline

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 03:08:04PM +0100, Peter Lieven wrote: Hi, I found that vmware emulates a 82545em per default and so some special crafted appliances only work with that card. I was wondering if the below is the right approach to make the models selectable via cmdline without

Re: [Qemu-devel] [PATCH v2 4/7] console-gl: add opengl rendering helper functions

2015-01-20 Thread Max Reitz
On 2015-01-20 at 06:00, Gerd Hoffmann wrote: Hi, +static GLchar texture_blit_vert_src[] = +\n +#version 300 es\n +\n +in vec2 in_position;\n +in vec2 in_tex_coord;\n You could calculate the texture coordinate from the position in the shader, but this is mostly my

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-20 Thread Xu, Quan
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Tuesday, January 20, 2015 6:50 PM To: Xu, Quan Cc: Stefano Stabellini; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: RE: [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend

Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions

2015-01-20 Thread Frank Blaschka
On Tue, Jan 20, 2015 at 01:56:09PM +0100, Markus Armbruster wrote: Markus Armbruster arm...@redhat.com writes: Cornelia Huck cornelia.h...@de.ibm.com writes: On Tue, 20 Jan 2015 10:45:41 +0100 Markus Armbruster arm...@redhat.com wrote: This patch makes Coverity unhappy: *** CID

Re: [Qemu-devel] [PULL 0/4] Xen tree 2015-01-20

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Peter Maydell wrote: On 20 January 2015 at 11:19, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1'

[Qemu-devel] [PATCH 2/3] Migration: Add lots of trace events

2015-01-20 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Mostly on the load side, so that when we get a complaint about a migration failure we can figure out what it didn't like. Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- migration/vmstate.c | 22 +++--- savevm.c

Re: [Qemu-devel] [PATCH RFC v6 16/20] virtio-net: support longer header

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:18PM +0100, Cornelia Huck wrote: diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index ebbea60..7ee2bd6 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -373,15 +373,21 @@ static int peer_has_ufo(VirtIONet *n) return n-has_ufo; }

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Alex Bennée
Greg Bellows greg.bell...@linaro.org writes: Adds a CPU feature parsing function and assigns to the CPU class. The only feature added was -aarch64 which disabled the AArch64 execution state on a 64-bit ARM CPU. Also adds stripping of features from CPU model string in acquiring the ARM CPU

Re: [Qemu-devel] [PATCH 0/2] m48t59: add year offset and MMIO ISA mapping

2015-01-20 Thread Mark Cave-Ayland
On 19/01/15 21:59, Hervé Poussineau wrote: Le 19/01/2015 12:35, Mark Cave-Ayland a écrit : This patch lays the groundwork for switching sun4u over from ioport NVRAM access to MMIO NVRAM access. Patch 1 introduces a new year_offset property which is the offset between the year value stored

[Qemu-devel] [PULL v2 0/4] Xen tree 2015-01-20 v2

2015-01-20 Thread Stefano Stabellini
The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1' into staging (2015-01-19 13:37:05 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

Re: [Qemu-devel] [PATCH] target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT

2015-01-20 Thread Greg Bellows
On Tue, Jan 20, 2015 at 7:58 AM, Peter Maydell peter.mayd...@linaro.org wrote: The LDT/STT (load/store unprivileged) instruction decode was using the wrong MMU index value. This meant that instead of these insns being always access as if user-mode regardless of current privilege they were

Re: [Qemu-devel] [PATCH 0/2] qcow2: Add two more unalignment checks

2015-01-20 Thread Kevin Wolf
Am 20.01.2015 um 14:49 hat Max Reitz geschrieben: On 2015-01-20 at 05:09, Kevin Wolf wrote: Am 19.01.2015 um 22:09 hat Max Reitz geschrieben: On 2015-01-19 at 16:04, Eric Blake wrote: On 01/19/2015 01:49 PM, Max Reitz wrote: With the series adding unalignment checks and the series reworking

  1   2   3   >