[Qemu-devel] [PATCH 3/4] Add GDB qAttached support

2015-02-07 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com With this patch QEMU handles qAttached request from gdb. When QEMU replies 1, GDB sends a detach command at the end of a debugging session otherwise GDB sends kill. The default value for qAttached is 1 on system emulation and 0 on user emulation. Based on

[Qemu-devel] [PATCH 1/4] gdbstub: Fix qOffsets packet detection

2015-02-07 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com qOffsets has no additional optional parameters. So match the complete string to avoid stumbling over possible future commands with identical prefix. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH 4/4] Revert gdbstub: Do not kill target in system emulation mode

2015-02-07 Thread Jan Kiszka
From: Fabien Chouteau chout...@adacore.com The requirements described in this patch are implemented by Add GDB qAttached support. This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8. Signed-off-by: Fabien Chouteau chout...@adacore.com --- gdbstub.c | 2 -- 1 file changed, 2

[Qemu-devel] [PATCH 0/4] gdbstub: improve query packet parsing, add qAttached support

2015-02-07 Thread Jan Kiszka
This addresses the review comments on the previews two patches to add qAttached support. No longer trivial, so maybe you can pick it up, Peter. Jan CC: Fabien Chouteau chout...@adacore.com CC: Jan Kiszka jan.kis...@siemens.com Fabien Chouteau (1): Revert gdbstub: Do not kill target in system

Re: [Qemu-devel] [PATCH/RFC] vl.c: fix memory leak spotted by valgrind

2015-02-07 Thread Michael Tokarev
28.01.2015 18:18, Paolo Bonzini wrote: Reviewed-by: Paolo Bonzini pbonz...@redhat.com Applied to -trivial, thank you! /mjt On 28/01/2015 16:07, Christian Borntraeger wrote: valgrind complains about: ==42062== 16 bytes in 1 blocks are definitely lost in loss record 387 of 1,048 ==42062==

Re: [Qemu-devel] [PATCH v2] Fix ABI incompatibility between Qemu-aarch64 and Linux Kernel in signal handling.

2015-02-07 Thread Michael Tokarev
02.02.2015 17:18, Maxim Ostapenko wrote: From 5b035df58f9f17e64b35311b6b5f55097c7f8ce1 Mon Sep 17 00:00:00 2001 From: Max Ostapenko m.ostape...@partner.samsung.com Date: Mon, 2 Feb 2015 12:03:20 +0400 Subject: [PATCH] linux-user: wrong TARGET_SI_PAD_SIZE value for some targets. Fix

[Qemu-devel] [PATCH] qemu-coroutine-lock: fix co_queue multi-adding bug

2015-02-07 Thread w00214312
From: Bin Wu wu.wu...@huawei.com When a coroutine holds a lock, other coroutines who want to get the lock must wait on a co_queue by adding themselves to the CoQueue. However, if a waiting coroutine is woken up with the lock still be holding by other coroutine, this waiting coroutine will add

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/7] Six coverity fixes and a cleanup

2015-02-07 Thread Michael Tokarev
26.01.2015 14:12, Paolo Bonzini wrote: Patch 2 is the cleanup. The other six patches make the tcg, utils and migration components clean. Applied to -trivial patches 1,2,3,4 and 6, not applied 5 (due to questionable errno checking addition) and 7, due to a discussion. Thanks, /mjt Paolo

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-sockets: Fix buffer overflow in inet_parse()

2015-02-07 Thread Michael Tokarev
30.01.2015 22:37, Kevin Wolf wrote: The size of the stack allocated host[] array didn't account for the terminating '\0' byte that sscanf() writes. Fix the array size. Applied to -trivial, thank you! /mjt

[Qemu-devel] [PATCH 2/4] gdbstub: Introduce and is is_query_packet helper

2015-02-07 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com This helper supports parsing of query packets with optional extensions. The separator can be specified so that we can use it already for both qqemu.sstep[=] and qSupported[:feature]. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- gdbstub.c | 12

Re: [Qemu-devel] [Qemu-trivial] [PATCH 5/7] cutils: refine strtol error handling in parse_debug_env

2015-02-07 Thread Michael Tokarev
26.01.2015 14:12, Paolo Bonzini wrote: Avoid truncation of a 64-bit long to a 32-bit int, and check for errno (especially ERANGE). Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- util/cutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/cutils.c

[Qemu-devel] [PATCH] fix the co_queue multi-adding bug

2015-02-07 Thread w00214312
From: Bin Wu wu.wu...@huawei.com When we test the drive_mirror between different hosts by ndb devices, we find that, during the cancel phase the qemu process crashes sometimes. By checking the crash core file, we find the stack as follows, which means a coroutine re-enter error occurs: (gdb) bt

[Qemu-devel] [PATCH 02/10] disas/sh4: Fix warning caused by missing 'static' attribute

2015-02-07 Thread Stefan Weil
Warning from the Sparse static analysis tool: disas/sh4.c:335:22: warning: symbol 'sh_table' was not declared. Should it be static? Signed-off-by: Stefan Weil s...@weilnetz.de --- disas/sh4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/sh4.c b/disas/sh4.c index

[Qemu-devel] [PATCH 07/10] spice: Add missing 'static' attribute

2015-02-07 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- spice-qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 7e0d300..a4f4e57 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -158,7 +158,7 @@ static gboolean

[Qemu-devel] [PATCH 05/10] moxie: Fix warning caused by missing include statement

2015-02-07 Thread Stefan Weil
Warning from the Sparse static analysis tool: target-moxie/machine.c:4:26: warning: symbol 'vmstate_moxie_cpu' was not declared. Should it be static? machine.h includes the missing declaration. Cc: Anthony Green gr...@moxielogic.com Signed-off-by: Stefan Weil s...@weilnetz.de ---

[Qemu-devel] [PATCH 09/10] vga: Fix warning caused by missing 'static' attribute

2015-02-07 Thread Stefan Weil
Warning from the Sparse static analysis tool: hw/display/vga.c:2012:26: warning: symbol 'vmstate_vga_endian' was not declared. Should it be static? Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/display/vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 00/10] Fix warnings (undeclared global symbols)

2015-02-07 Thread Stefan Weil
All warnings were reported by the Sparse static analysis tool. [PATCH 01/10] disas/cris: Fix warning caused by missing 'static' [PATCH 02/10] disas/sh4: Fix warning caused by missing 'static' [PATCH 03/10] migration: Fix warning caused by missing declaration of [PATCH 04/10] migration: Fix

[Qemu-devel] [PATCH 10/10] virtio: Fix warning caused by missing 'static' attribute

2015-02-07 Thread Stefan Weil
Warning from the Sparse static analysis tool: hw/char/virtio-serial-bus.c:31:3: warning: symbol 'vserdevices' was not declared. Should it be static? Cc: Amit Shah amit.s...@redhat.com Cc: Anthony Liguori aligu...@amazon.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Stefan Weil

Re: [Qemu-devel] [question] the patch which affect performance of virtio-scsi

2015-02-07 Thread Wangting (Kathy)
OK, Thank you very much for your detailed explanation. But I have another question about the big change from qemu-1.5.3 to qemu-1.6.0-rc0. When I use ramdisk for IO performance testing, the result is as follows. [fio-test] rw bs iodepthjobs bw iops

[Qemu-devel] [PATCH] Fix name error in migration stream analyzation script

2015-02-07 Thread Greg Kurz
It fixes the following error: Traceback (most recent call last): File ./scripts/analyze-migration.py, line 584, in module dump.read(dump_memory = args.memory) File ./scripts/analyze-migration.py, line 528, in read self.sections[section_id].read() File ./scripts/analyze-migration.py,

[Qemu-devel] [PATCH 08/10] stubs: Fix warning caused by missing include statement

2015-02-07 Thread Stefan Weil
Warning from the Sparse static analysis tool: stubs/qtest.c:14:6: warning: symbol 'qtest_allowed' was not declared. Should it be static? Add the missing include statement which declares qtest_allowed. Signed-off-by: Stefan Weil s...@weilnetz.de --- stubs/qtest.c | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH 04/10] migration: Fix warnings caused by missing 'static' attribute

2015-02-07 Thread Stefan Weil
Warnings from the Sparse static analysis tool: migration-rdma.c:151:12: warning: symbol 'wrid_desc' was not declared. Should it be static? migration-rdma.c:190:12: warning: symbol 'control_desc' was not declared. Should it be static? migration-rdma.c:3301:19: warning: symbol 'rdma_read_ops'

[Qemu-devel] [PATCH 03/10] migration: Fix warning caused by missing declaration of vmstate_dummy

2015-02-07 Thread Stefan Weil
Warning from the Sparse static analysis tool: stubs/vmstate.c:4:26: warning: symbol 'vmstate_dummy' was not declared. Should it be static? Cc: Juan Quintela quint...@redhat.com Cc: Amit Shah amit.s...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de --- include/migration/vmstate.h | 2 --

[Qemu-devel] [PATCH 06/10] serial: Fix warnings caused by missing 'static' attribute

2015-02-07 Thread Stefan Weil
Warnings from the Sparse static analysis tool: hw/char/serial.c:630:26: warning: symbol 'vmstate_serial_thr_ipending' was not declared. Should it be static? hw/char/serial.c:646:26: warning: symbol 'vmstate_serial_tsr' was not declared. Should it be static? hw/char/serial.c:665:26: warning:

[Qemu-devel] [PATCH] QJSON: fix typo in author's email address

2015-02-07 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- qjson.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qjson.c b/qjson.c index b24..0cda269 100644 --- a/qjson.c +++ b/qjson.c @@ -4,7 +4,7 @@ * Copyright Alexander Graf * * Authors: - * Alexander Graf

[Qemu-devel] [PATCH 01/10] disas/cris: Fix warning caused by missing 'static' attribute

2015-02-07 Thread Stefan Weil
Warning from the Sparse static analysis tool: disas/cris.c:1218:26: warning: symbol 'cris_cond15s' was not declared. Should it be static? Signed-off-by: Stefan Weil s...@weilnetz.de --- disas/cris.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/cris.c b/disas/cris.c

Re: [Qemu-devel] [PATCH] libcacard: stop linking against every single 3rd party library

2015-02-07 Thread Michael Tokarev
03.02.2015 14:31, Daniel P. Berrange wrote: Building QEMU results in a libcacard.so that links against practically the entire world [..] Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 0/4] Pair g_malloc() with g_free(), not free()

2015-02-07 Thread Michael Tokarev
28.01.2015 17:54, Markus Armbruster wrote: Markus Armbruster (4): qemu-option: Replace pointless use of g_malloc0() by g_malloc() qemu-option: Pair g_malloc() with g_free(), not free() spapr_vio: Pair g_malloc() with g_free(), not free() usb: Pair g_malloc() with g_free(), not free()

Re: [Qemu-devel] [PATCH v3 0/3] vfio: free data and unmap BARs in instance_finalize

2015-02-07 Thread Paolo Bonzini
On 07/02/2015 02:39, Alex Williamson wrote: I'm not sure where it's coming from yet, but I did extensive testing for my last pull request based on ec6f25e because if I updated to d5fbb4c vfio hotplug broke immediately. I'll keep looking, but I thought I'd share in case you have some ideas.

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/7] Six coverity fixes and a cleanup

2015-02-07 Thread Paolo Bonzini
On 07/02/2015 10:00, Michael Tokarev wrote: Patch 2 is the cleanup. The other six patches make the tcg, utils and migration components clean. Applied to -trivial patches 1,2,3,4 and 6, not applied 5 (due to questionable errno checking addition) and 7, due to a discussion. Thanks, will

[Qemu-devel] [PATCH] memsave: Add a space after address in error message

2015-02-07 Thread Borislav Petkov
From: Borislav Petkov b...@suse.de Add the missing space to separate address from specified. Cc: Anthony Liguori aligu...@amazon.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Borislav Petkov b...@suse.de --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/7] Six coverity fixes and a cleanup

2015-02-07 Thread Michael Tokarev
07.02.2015 23:01, Paolo Bonzini wrote: On 07/02/2015 10:00, Michael Tokarev wrote: Patch 2 is the cleanup. The other six patches make the tcg, utils and migration components clean. Applied to -trivial patches 1,2,3,4 and 6, not applied 5 (due to questionable errno checking addition) and 7,

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/3] util/uri: Cleanups and a bug fix

2015-02-07 Thread Michael Tokarev
27.01.2015 19:13, Markus Armbruster wrote: Note: checkpatch is unhappy with the first patch, because I refrained from cleaning up the ugly return(NULL). They're all over the place. Markus Armbruster (3): util/uri: uri_new() can't fail, drop dead error handling util/uri: realloc2n()

Re: [Qemu-devel] [PATCH] Fix name error in migration stream analyzation script

2015-02-07 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] QJSON: fix typo in author's email address

2015-02-07 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-02-07 Thread James J Myers
I'm having the same problem here on Windows 7 x64 host trying to run Raspbian. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1404278 Title: tap connections not working on windows host Status in