[Qemu-devel] [Bug 1301047] Re: Windows guest freezes while using passthrough on USB audio recorder.

2015-02-09 Thread zelluz
** Changed in: qemu Status: In Progress = Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1301047 Title: Windows guest freezes while using passthrough on USB audio recorder. Status

Re: [Qemu-devel] [PATCH v3 2/7] qom/cpu: move register_vmstate to common CPUClass.realizefn

2015-02-09 Thread Chen Fan
On 01/29/2015 10:04 PM, Igor Mammedov wrote: On Wed, 14 Jan 2015 15:27:25 +0800 Zhu Guihua zhugh.f...@cn.fujitsu.com wrote: From: Gu Zheng guz.f...@cn.fujitsu.com Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, and use cc-get_arch_id as the instance id that suggested

Re: [Qemu-devel] [PATCH v2 0/7] isa: remove isa_mem_base variable

2015-02-09 Thread Leon Alrae
On 01/02/2015 08:12, Hervé Poussineau wrote: Hi, This patchset removes the isa_mem_base variable in VGA display devices. This variable is a global variable telling at which address is the ISA memory base address in the system memory address space. Once removed, we're paving the way to new

Re: [Qemu-devel] [PATCH] fix the co_queue multi-adding bug

2015-02-09 Thread Paolo Bonzini
On 07/02/2015 10:51, w00214312 wrote: From: Bin Wu wu.wu...@huawei.com When we test the drive_mirror between different hosts by ndb devices, we find that, during the cancel phase the qemu process crashes sometimes. By checking the crash core file, we find the stack as follows, which means

Re: [Qemu-devel] [PATCH] Makefile: Allow make cscope TAGS in unconfigured source tree

2015-02-09 Thread Fam Zheng
On Mon, 02/09 08:25, Peter Maydell wrote: On 9 February 2015 at 08:08, Fam Zheng f...@redhat.com wrote: It doesn't make much sense to ask one to switch to build dir in order to make these two targets. Signed-off-by: Fam Zheng f...@redhat.com --- Makefile | 13 - 1 file

Re: [Qemu-devel] [PATCH v2 0/3] fix qemu crash about vnc

2015-02-09 Thread Gonglei
On 2015/2/9 16:33, Gerd Hoffmann wrote: Hi, It seems that Gerd is not in maillist recently. Was sick, back online now, I'll try to have a closer look ASAP but I have a big email backlog now ... Hope you feel better now :) Regards, -Gonglei

Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs

2015-02-09 Thread Cornelia Huck
On Mon, 09 Feb 2015 15:10:17 +0800 Chen, Tiejun tiejun.c...@intel.com wrote: On 2015/2/9 15:02, Michael S. Tsirkin wrote: On Mon, Feb 09, 2015 at 03:01:15PM +0800, Chen, Tiejun wrote: On 2015/2/8 18:48, Michael S. Tsirkin wrote: On Fri, Feb 06, 2015 at 01:14:46PM +0100, Cornelia Huck

Re: [Qemu-devel] [PATCH v2] qemu-coroutine: segfault when restarting co_queue

2015-02-09 Thread Paolo Bonzini
On 09/02/2015 07:50, Bin Wu wrote: From: Bin Wu wu.wu...@huawei.com We tested VMs migration with their disk images by drive_mirror. With migration, two VMs copyed large files between each other. During the test, a segfault occured. The stack was as follow: (gdb) bt

Re: [Qemu-devel] [PATCH 0/4] target-arm: fix various clang UB sanitizer warnings

2015-02-09 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 6 February 2015 at 17:37, Eric Blake ebl...@redhat.com wrote: On 02/06/2015 07:34 AM, Peter Maydell wrote: HACKING already implies we assume sane 2's complement behavior of shifts (maybe it's worth another line for this particular case of

Re: [Qemu-devel] [PATCH 0/7] NUMA code cleanup

2015-02-09 Thread Paolo Bonzini
On 08/02/2015 19:51, Eduardo Habkost wrote: This cleans up some of the NUMA code: moves declarations to numa.h, rename some functions, and remove some existing code that was inside main(). Eduardo Habkost (7): numa: Move NUMA declarations from sysemu.h to numa.h vl.c: Remove

Re: [Qemu-devel] Definition of the UI layer's key number ?

2015-02-09 Thread Gerd Hoffmann
On Mo, 2015-02-09 at 08:31 +, Peter Maydell wrote: On 9 February 2015 at 08:27, Gerd Hoffmann kra...@redhat.com wrote: Well, we have two ways to represent a key code in qemu, unfortunately in the QMP api (see KeyValue in qapi-schema.json). One is QKeyCode (defined in qapi-schema.json

Re: [Qemu-devel] [PATCH] qemu-coroutine-lock: fix co_queue multi-adding bug

2015-02-09 Thread Bin Wu
On 2015/2/9 16:12, Fam Zheng wrote: On Sat, 02/07 17:51, w00214312 wrote: From: Bin Wu wu.wu...@huawei.com When a coroutine holds a lock, other coroutines who want to get the lock must wait on a co_queue by adding themselves to the CoQueue. However, if a waiting coroutine is woken up with

Re: [Qemu-devel] [PATCH] hmp: Fix warning from smatch (wrong argument in function call)

2015-02-09 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Fix this warning: hmp.c:414:38: warning: Using plain integer as NULL pointer qmp_query_block expects a pointer argument, so passing false is wrong. Cc: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by:

Re: [Qemu-devel] [PATCH] fix the co_queue multi-adding bug

2015-02-09 Thread Bin Wu
On 2015/2/9 17:23, Paolo Bonzini wrote: On 07/02/2015 10:51, w00214312 wrote: From: Bin Wu wu.wu...@huawei.com When we test the drive_mirror between different hosts by ndb devices, we find that, during the cancel phase the qemu process crashes sometimes. By checking the crash core file,

[Qemu-devel] CPU TLB flush with multithread TCG.

2015-02-09 Thread Frederic Konrad
Hi everybody, In multithread tlb_flush is broken as CPUA can flush an other CPUB and CPUB can be executing code, and fixing this can be quite hard: * We need to exit the CPU which is flushed. * Makes sure the CPU is stopped. * Then we can flush tlb. The big issues are: * Two threads

Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel ## is not a valid modifier

2015-02-09 Thread Don Slutz
On 02/09/15 10:08, Christian Borntraeger wrote: Am 09.02.2015 um 15:31 schrieb Paolo Bonzini: On 09/02/2015 13:18, Christian Borntraeger wrote: From: Andy Whitcroft a...@canonical.com checkpatch currently loops on fpu/softfloat.c Turns out this is fixed in the Linux version of checkpatch.

Re: [Qemu-devel] [PATCH 1/7] numa: Move NUMA declarations from sysemu.h to numa.h

2015-02-09 Thread Michael S. Tsirkin
On Sun, Feb 08, 2015 at 04:51:16PM -0200, Eduardo Habkost wrote: Not all sysemu.h users need the NUMA declarations, and keeping them in a separate file makes easier to see what are the interfaces provided by s/makes easier/makes it easier/ numa.c. Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH 0/7] NUMA code cleanup

2015-02-09 Thread Paolo Bonzini
On 09/02/2015 15:53, Eduardo Habkost wrote: Thanks! Do you think this should go through Michael's tree, like past NUMA patches, or through yours? Through Michael's tree or yours :) Paolo

[Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-09 Thread Kevin Wolf
The CHS calculation as done per the VHD spec imposes a maximum image size of ~127 GB. Real VHD images exist that are larger than that. Apparently there are two separate non-standard ways to achieve this: You could use more heads than the spec does - this is the option that qemu-img create

Re: [Qemu-devel] [PATCH 0/7] NUMA code cleanup

2015-02-09 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 12:53:37PM -0200, Eduardo Habkost wrote: On Mon, Feb 09, 2015 at 10:16:08AM +0100, Paolo Bonzini wrote: On 08/02/2015 19:51, Eduardo Habkost wrote: This cleans up some of the NUMA code: moves declarations to numa.h, rename some functions, and remove some

Re: [Qemu-devel] [PATCH 7/7] target-mips: Add IEEE 754-2008 features support

2015-02-09 Thread Leon Alrae
On 09/12/2014 01:56, Maciej W. Rozycki wrote: +if (info-elf_flags EF_MIPS_NAN2008) +env-active_fpu.fcr31 |= +(1 FCR31_NAN2008) env-active_fpu.fcr31_rw_bitmask; +else +env-active_fpu.fcr31 = +~((1 FCR31_NAN2008)

Re: [Qemu-devel] [PATCH v2 2/3] iotests: Add wait functionality to _cleanup_qemu

2015-02-09 Thread Max Reitz
On 2015-02-09 at 10:01, Stefan Hajnoczi wrote: On Fri, Feb 06, 2015 at 04:06:17PM -0500, Max Reitz wrote: diff --git a/tests/qemu-iotests/common.qemu b/tests/qemu-iotests/common.qemu index 8e618b5..4e1996c 100644 --- a/tests/qemu-iotests/common.qemu +++ b/tests/qemu-iotests/common.qemu @@

Re: [Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces

2015-02-09 Thread Nathan Fontenot
On 01/27/2015 06:42 PM, Michael Roth wrote: Quoting Tyrel Datwyler (2015-01-27 16:05:52) On 01/27/2015 01:36 PM, Michael Roth wrote: Quoting David Gibson (2015-01-26 23:24:11) On Sun, Jan 25, 2015 at 11:21:26PM -0600, Michael Roth wrote: Quoting David Gibson (2015-01-16 00:21:55) On Tue, Dec

[Qemu-devel] [PATCH 2/2] vhost-user: add reply for set_mem_table

2015-02-09 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com If u64 is not 0 we should return -1 to tell qemu not going on. Signed-off-by: Linhaifeng haifeng@huawei.com --- hw/virtio/vhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c

Re: [Qemu-devel] [PATCH 2/2] vhost-user: add reply for set_mem_table

2015-02-09 Thread Gonglei
On 2015/2/10 11:24, linhaifeng wrote: From: Linhaifeng haifeng@huawei.com If u64 is not 0 we should return -1 to tell qemu not going on. Signed-off-by: Linhaifeng haifeng@huawei.com --- hw/virtio/vhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v1 2/2] vhost-user: add reply for set_mem_table

2015-02-09 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com If u64 is not 0 we should return -1 to tell qemu not going on. Remove some unnecessary '\n' in error_report. Signed-off-by: Linhaifeng haifeng@huawei.com --- hw/virtio/vhost-user.c | 33 ++--- 1 file changed, 22

Re: [Qemu-devel] [PATCH v10 2/5] stm32f2xx_USART: Add the stm32f2xx USART Controller

2015-02-09 Thread Peter Crosthwaite
On Thu, Jan 29, 2015 at 4:31 AM, Alistair Francis alistai...@gmail.com wrote: This patch adds the stm32f2xx USART controller (UART also uses the same controller). Signed-off-by: Alistair Francis alist...@alistair23.me Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- V8: -

Re: [Qemu-devel] [PATCH v4 0/2] Reworked Zynq GPIO model

2015-02-09 Thread Peter Crosthwaite
On Sun, Jan 25, 2015 at 11:51 AM, Colin Leitner colin.leit...@googlemail.com wrote: Hello everyone, this is the fourth version of the Zynq GPIO model patch. It includes * removal of unneeded memset in zynq_gpio_realize * some minor code cleanup * fixes for all remaining checkpatch

Re: [Qemu-devel] [PATCH v10 1/5] stm32f2xx_timer: Add the stm32f2xx Timer

2015-02-09 Thread Peter Crosthwaite
On Thu, Jan 29, 2015 at 4:31 AM, Alistair Francis alistai...@gmail.com wrote: This patch adds the stm32f2xx timers: TIM2, TIM3, TIM4 and TIM5 to QEMU. Signed-off-by: Alistair Francis alist...@alistair23.me Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- V10: - Correct

Re: [Qemu-devel] [PATCH] fix the co_queue multi-adding bug

2015-02-09 Thread Bin Wu
On 2015/2/9 17:23, Paolo Bonzini wrote: On 07/02/2015 10:51, w00214312 wrote: From: Bin Wu wu.wu...@huawei.com When we test the drive_mirror between different hosts by ndb devices, we find that, during the cancel phase the qemu process crashes sometimes. By checking the crash core file,

Re: [Qemu-devel] [PATCH v1 2/2] vhost-user: add reply for set_mem_table

2015-02-09 Thread Gonglei
On 2015/2/10 13:48, linhaifeng wrote: From: Linhaifeng haifeng@huawei.com If u64 is not 0 we should return -1 to tell qemu not going on. Remove some unnecessary '\n' in error_report. Hi, haifeng: You'd better split a single patch to do this work, and using '--cover' argument for patch

[Qemu-devel] [PULL 07/46] vl: Fix bogus error message for implied mon ID clashing

2015-02-09 Thread Michael Tokarev
From: Markus Armbruster arm...@redhat.com monitor_parse() desugars --monitor, --qmp and -qmp-pretty to --mon. The ID it picks can clash with a user-specified ID. When it happens, the error message is misleading. Reproducer: $ qemu --mon id=compat_monitor0 --monitor stdio Message before

[Qemu-devel] [PULL 01/46] target-mips: Clean up switch fall through after commit fecd264

2015-02-09 Thread Michael Tokarev
From: Markus Armbruster arm...@redhat.com Commit fecd264 added a number of fall-throughs, but neglected to properly document them as intentional. Commit d922445 cleaned that up for many, but not all cases. Take care of the remaining ones. Spotted by Coverity. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 1/2] xen-pt: fix Negative array index read

2015-02-09 Thread Stefano Stabellini
On Sat, 31 Jan 2015, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Coverity spot: Function xen_pt_bar_offset_to_index() may returns a negative number (-1) value index, which as an index to array d-io_regions. Let's directly and simply pass index as an argument to

[Qemu-devel] [PATCH v12 06/17] block: Add bitmap successors

2015-02-09 Thread John Snow
A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to be created just prior to a sensitive operation (e.g. Incremental Backup) that can either succeed or fail, but during the course of which we still want a bitmap tracking writes. On creating a successor, we freeze the parent

[Qemu-devel] [PATCH v12 09/17] qapi: Add transaction support to block-dirty-bitmap operations

2015-02-09 Thread John Snow
This adds four qmp commands to transactions. Users can stop a dirty bitmap, start backup of it, and start another dirty bitmap atomically, so that the dirty bitmap is tracked incrementally and we don't miss any write. For starting a new incremental backup chain, users can also chain together a

[Qemu-devel] [PATCH v12 07/17] qmp: Add support of dirty-bitmap sync mode for drive-backup

2015-02-09 Thread John Snow
For dirty-bitmap sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of top sync mode. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: John Snow

[Qemu-devel] [PATCH v12 02/17] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-02-09 Thread John Snow
The new command pair is added to manage user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. The granularity is an optional field. If it is not specified, we will choose a default

[Qemu-devel] [PATCH v12 03/17] block: Introduce bdrv_dirty_bitmap_granularity()

2015-02-09 Thread John Snow
This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Small adjustments are made to ensure that granularity-- in bytes-- is handled consistently as a uint64_t throughout the code. Signed-off-by: John Snow js...@redhat.com ---

Re: [Qemu-devel] [PATCH v10 5/5] netduino2: Add the Netduino 2 Machine

2015-02-09 Thread Peter Crosthwaite
On Thu, Jan 29, 2015 at 4:31 AM, Alistair Francis alistai...@gmail.com wrote: This patch adds the Netduino 2 Machine. This is a Cortex-M3 based machine. Information can be found at: http://www.netduino.com/netduino2/specs.htm Signed-off-by: Alistair Francis alist...@alistair23.me

[Qemu-devel] [PULL 04/46] Add trace to ps2.c.

2015-02-09 Thread Michael Tokarev
From: Don Koch dk...@verizon.com Signed-off-by: Don Koch dk...@verizon.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/input/ps2.c | 16 trace-events | 17 + 2 files changed, 33 insertions(+) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index

[Qemu-devel] [PULL 08/46] virtfs-proxy-helper: Fix possible socket leak.

2015-02-09 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- fsdev/virtfs-proxy-helper.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/2] xen-pt: fix Out-of-bounds read

2015-02-09 Thread Stefano Stabellini
On Sat, 31 Jan 2015, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com The array length of s-real_device.io_regions[] is PCI_NUM_REGIONS - 1. Add a check, just make Coverity happy. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/xen/xen_pt_config_init.c | 5

[Qemu-devel] [PULL 26/46] util/uri: uri_new() can't fail, drop dead error handling

2015-02-09 Thread Michael Tokarev
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- util/uri.c | 36 +++- 1 file changed, 11 insertions(+), 25 deletions(-) diff --git a/util/uri.c b/util/uri.c index

[Qemu-devel] [PULL 29/46] QJSON: fix typo in author's email address

2015-02-09 Thread Michael Tokarev
From: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- qjson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qjson.c b/qjson.c index b24..0cda269 100644 --- a/qjson.c +++ b/qjson.c @@

[Qemu-devel] [PULL 38/46] disas/sh4: Fix warning caused by missing 'static' attribute

2015-02-09 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de Warning from the Sparse static analysis tool: disas/sh4.c:335:22: warning: symbol 'sh_table' was not declared. Should it be static? Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael Tokarev m...@tls.msk.ru --- disas/sh4.c | 2 +- 1 file

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-09 Thread Liu Yuan
On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle block_size_shift value for calculating VDI object size. When you start qemu, you don't need to specify additional

[Qemu-devel] [PATCH v12 16/17] blkdebug: fix once rule

2015-02-09 Thread John Snow
Background: The blkdebug scripts are currently engineered so that when a debug event occurs, a prefilter browses a master list of parsed rules for a certain event and adds them to an active list of rules to be used for the forthcoming action, provided the events and state numbers match. Then,

[Qemu-devel] [PATCH 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-09 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com Slave should reply to master and set u64 to 0 if mmap all regions success otherwise set u64 to 1. Signed-off-by: Linhaifeng haifeng@huawei.com --- docs/specs/vhost-user.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/specs/vhost-user.txt

[Qemu-devel] [PATCH v12 13/17] iotests: add invalid input incremental backup tests

2015-02-09 Thread John Snow
Signed-off-by: John Snow js...@redhat.com --- tests/qemu-iotests/112 | 89 ++ tests/qemu-iotests/112.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 95 insertions(+) create mode 100644 tests/qemu-iotests/112 create mode 100644

[Qemu-devel] [PATCH v12 05/17] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable

2015-02-09 Thread John Snow
This allows to put the dirty bitmap into a disabled state where it is read only. A disabled bitmap will ignore any attempts to set or reset any of its bits, but can otherwise be renamed, deleted, or re-enabled. It will be used before backup or writing to persistent file. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v12 15/17] iotests: add transactional incremental backup test

2015-02-09 Thread John Snow
Signed-off-by: John Snow js...@redhat.com --- tests/qemu-iotests/112 | 45 + tests/qemu-iotests/112.out | 4 ++-- 2 files changed, 47 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/112 b/tests/qemu-iotests/112 index 31431ad..7d1a6ec

Re: [Qemu-devel] [PATCH v2] qemu-coroutine: segfault when restarting co_queue

2015-02-09 Thread Bin Wu
On 2015/2/10 11:16, Wen Congyang wrote: On 02/09/2015 10:48 PM, Stefan Hajnoczi wrote: On Mon, Feb 09, 2015 at 02:50:39PM +0800, Bin Wu wrote: From: Bin Wu wu.wu...@huawei.com We tested VMs migration with their disk images by drive_mirror. With migration, two VMs copyed large files between

[Qemu-devel] [PATCH v12 11/17] block: add BdrvDirtyBitmap documentation

2015-02-09 Thread John Snow
Signed-off-by: John Snow js...@redhat.com --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 3c0989c..e065694 100644 --- a/block.c +++ b/block.c @@ -60,11 +60,11 @@ * or enabled. A frozen bitmap can only abdicate() or

[Qemu-devel] [PATCH v12 10/17] qmp: Add dirty bitmap status fields in query-block

2015-02-09 Thread John Snow
Adds the disabled and frozen status booleans. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: John Snow js...@redhat.com --- block.c | 2 ++ qapi/block-core.json | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v12 04/17] hbitmap: add hbitmap_merge

2015-02-09 Thread John Snow
We add a bitmap merge operation to assist in error cases where we wish to combine two bitmaps together. This is algorithmically O(bits) provided HBITMAP_LEVELS remains constant. For a full bitmap on a 64bit machine: sum(bits/64^k, k, 0, HBITMAP_LEVELS) ~= 1.01587 * bits We may be able to improve

[Qemu-devel] [PATCH v12 08/17] qmp: add block-dirty-bitmap-clear

2015-02-09 Thread John Snow
Add bdrv_clear_dirty_bitmap and a matching QMP command, qmp_block_dirty_bitmap_clear that enables a user to reset the bitmap attached to a drive. This allows us to reset a bitmap in the event of a full drive backup. Signed-off-by: John Snow js...@redhat.com --- block.c | 7

[Qemu-devel] [PATCH v12 14/17] iotests: add simple incremental backup case

2015-02-09 Thread John Snow
Signed-off-by: John Snow js...@redhat.com --- tests/qemu-iotests/112| 120 +- tests/qemu-iotests/112.out| 4 +- tests/qemu-iotests/iotests.py | 18 --- 3 files changed, 133 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH v12 17/17] iotests: add incremental backup failure recovery test

2015-02-09 Thread John Snow
To test the failure case, we modify iotests.py to allow us to specify that we'd like to allow failures when we wait for block job events. Signed-off-by: John Snow js...@redhat.com --- tests/qemu-iotests/112| 55 ++- tests/qemu-iotests/112.out|

Re: [Qemu-devel] [PATCH 2/2] vhost-user: add reply for set_mem_table

2015-02-09 Thread Linhaifeng
On 2015/2/10 11:57, Gonglei wrote: On 2015/2/10 11:24, linhaifeng wrote: From: Linhaifeng haifeng@huawei.com If u64 is not 0 we should return -1 to tell qemu not going on. Signed-off-by: Linhaifeng haifeng@huawei.com --- hw/virtio/vhost-user.c | 13 - 1 file

Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls

2015-02-09 Thread Pavel Dovgaluk
From: Stefan Weil [mailto:s...@weilnetz.de] Am 09.02.2015 um 09:07 schrieb Pavel Dovgaluk: From: Stefan Weil [mailto:s...@weilnetz.de] Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: On w64, setjmp is implemented by _setjmp which needs a second parameter. This parameter should be NULL to

[Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-09 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com Slave should reply to master and set u64 to 0 if mmap all regions success otherwise set u64 to 1. Signed-off-by: Linhaifeng haifeng@huawei.com --- docs/specs/vhost-user.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/specs/vhost-user.txt

Re: [Qemu-devel] [PATCH v10 4/5] stm32f205: Add the stm32f205 SoC

2015-02-09 Thread Peter Crosthwaite
On Thu, Jan 29, 2015 at 4:31 AM, Alistair Francis alistai...@gmail.com wrote: This patch adds the stm32f205 SoC. This will be used by the Netduino 2 to create a machine. Signed-off-by: Alistair Francis alist...@alistair23.me --- V6: - Correct the number of USART/UART devices - Use macros

[Qemu-devel] [PATCH] vfio: Fix debug message compile error

2015-02-09 Thread Alexey Kardashevskiy
This fixes a compiler error which occurs if DEBUG_VFIO is defined. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/vfio/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 29caabc..cfc087a 100644 --- a/hw/vfio/pci.c +++

[Qemu-devel] [PULL 37/46] disas/cris: Fix warning caused by missing 'static' attribute

2015-02-09 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de Warning from the Sparse static analysis tool: disas/cris.c:1218:26: warning: symbol 'cris_cond15s' was not declared. Should it be static? Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael Tokarev m...@tls.msk.ru --- disas/cris.c | 2 +- 1

[Qemu-devel] [PULL 36/46] translate-all: Use g_try_malloc() for dynamic translator buffer

2015-02-09 Thread Michael Tokarev
From: Markus Armbruster arm...@redhat.com The USE_MMAP code can fail, and the caller handles the failure already. Let the !USE_MMAP code fail as well, for consistency. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Gonglei

[Qemu-devel] [PULL 12/46] linux-user/syscall.c: do_ioctl_dm: Need to call unlock_user() before going to failure return in default case

2015-02-09 Thread Michael Tokarev
From: Chen Gang S gang.c...@sunrus.com.cn In abi_long do_ioctl_dm(), after lock_user() call, the code does not call unlock_user() before going to failure return in default case. Signed-off-by: Chen Gang gang.chen.5...@gmail.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by:

[Qemu-devel] [PULL 41/46] moxie: Fix warning caused by missing include statement

2015-02-09 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de Warning from the Sparse static analysis tool: target-moxie/machine.c:4:26: warning: symbol 'vmstate_moxie_cpu' was not declared. Should it be static? machine.h includes the missing declaration. Cc: Anthony Green gr...@moxielogic.com Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH v1 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2015-02-09 Thread Peter Crosthwaite
On Wed, Jan 21, 2015 at 5:06 PM, Alistair Francis alistair.fran...@xilinx.com wrote: This patch adds the Cortex-A9 ARM CPU to the A9MPCore. The CPU is only created if the num-cpu property is set. This patch relies on Stefan Hajnoczi's v3 'virtio-blk: use alias properties in transport

Re: [Qemu-devel] [PATCH 2/2] xen-pt: fix Out-of-bounds read

2015-02-09 Thread Gonglei
On 2015/2/10 14:39, Stefano Stabellini wrote: On Sat, 31 Jan 2015, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com The array length of s-real_device.io_regions[] is PCI_NUM_REGIONS - 1. Add a check, just make Coverity happy. Signed-off-by: Gonglei

[Qemu-devel] [PULL 45/46] vga: Fix warning caused by missing 'static' attribute

2015-02-09 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de Warning from the Sparse static analysis tool: hw/display/vga.c:2012:26: warning: symbol 'vmstate_vga_endian' was not declared. Should it be static? Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael Tokarev m...@tls.msk.ru ---

Re: [Qemu-devel] [PATCH] vfio: Fix debug message compile error

2015-02-09 Thread Eric Auger
Hi Alexey, Thanks for pointing that issue. Best Regards Eric On 02/10/2015 07:14 AM, Alexey Kardashevskiy wrote: This fixes a compiler error which occurs if DEBUG_VFIO is defined. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/vfio/pci.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 11/46] linux-user/main.c: Use TARGET_SIG* instead of SIG*

2015-02-09 Thread Michael Tokarev
From: Chen Gang S gang.c...@sunrus.com.cn In main.c, all SIG* should be TARGET_SIG*, since the relevant functions (queue_signal() and gdb_handlesig()) expect TARGET_SIG*. The corresponding vi command is 1,$ s/\SIG/TARGET_SIG/g. Signed-off-by: Chen Gang gang.chen.5...@gmail.com Reviewed-by:

Re: [Qemu-devel] [PATCH v1 2/2] vhost-user: add reply for set_mem_table

2015-02-09 Thread Linhaifeng
On 2015/2/10 14:35, Gonglei wrote: On 2015/2/10 13:48, linhaifeng wrote: From: Linhaifeng haifeng@huawei.com If u64 is not 0 we should return -1 to tell qemu not going on. Remove some unnecessary '\n' in error_report. Hi, haifeng: You'd better split a single patch to do this work,

[Qemu-devel] [PULL 42/46] serial: Fix warnings caused by missing 'static' attribute

2015-02-09 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de Warnings from the Sparse static analysis tool: hw/char/serial.c:630:26: warning: symbol 'vmstate_serial_thr_ipending' was not declared. Should it be static? hw/char/serial.c:646:26: warning: symbol 'vmstate_serial_tsr' was not declared. Should it be static?

Re: [Qemu-devel] [PATCH 2/2] xen-pt: fix Out-of-bounds read

2015-02-09 Thread Stefano Stabellini
On Tue, 10 Feb 2015, Gonglei wrote: On 2015/2/10 14:39, Stefano Stabellini wrote: On Sat, 31 Jan 2015, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com The array length of s-real_device.io_regions[] is PCI_NUM_REGIONS - 1. Add a check, just make Coverity happy.

[Qemu-devel] [PATCH v12 01/17] qapi: Add optional field name to block dirty bitmap

2015-02-09 Thread John Snow
From: Fam Zheng f...@redhat.com This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-09 Thread Liu Yuan
On Tue, Feb 10, 2015 at 11:10:51AM +0800, Liu Yuan wrote: On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle block_size_shift value for calculating VDI object size.

Re: [Qemu-devel] [PATCH v1 2/2] zynq: Update Zynq to init the CPU in the a9mpcore device

2015-02-09 Thread Peter Crosthwaite
On Wed, Jan 21, 2015 at 5:06 PM, Alistair Francis alistair.fran...@xilinx.com wrote: This patch removes the initialisation of the ARM Cortex-A9 in Zynq and instead allows the a9mpcore device to init the CPU. This also updates components that rely on the CPU and GIC, as they are now initialised

[Qemu-devel] [PULL 02/46] fw_cfg: fix typos in comments: patch - path

2015-02-09 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/core/fw-path-provider.c | 2 +- hw/ppc/spapr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/fw-path-provider.c

Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel ## is not a valid modifier

2015-02-09 Thread Christian Borntraeger
Am 09.02.2015 um 15:31 schrieb Paolo Bonzini: On 09/02/2015 13:18, Christian Borntraeger wrote: From: Andy Whitcroft a...@canonical.com checkpatch currently loops on fpu/softfloat.c Turns out this is fixed in the Linux version of checkpatch. So this is a port of Andy Whitcrofts fix from

[Qemu-devel] [PATCH v2 00/37] blockdev: BlockBackend and media

2015-02-09 Thread Max Reitz
This series reworks a lot regarding BlockBackend and media. It is essentially a v3 to the blockdev: Add blockdev-change-medium with read-only option series (which is in fact a part of this series), but of course does a lot more. Basically, this series allows empty BlockBackends, that is BBs

[Qemu-devel] [PATCH v2 18/37] blockdev: Use BB for blockdev-backup transaction

2015-02-09 Thread Max Reitz
When preparing a blockdev-backup transaction, the BlockBackend should be used because there may be no medium associated to the BB (which would make bdrv_find() fail, whereas blk_by_name() does not). This does not make a real difference because blockdev-backup will fail without a medium anyway;

[Qemu-devel] [PATCH v2 21/37] blockdev: Do not create BDS for empty drive

2015-02-09 Thread Max Reitz
Do not use rudimentary BDSs for empty drives any longer (for freshly created drives). With this change, bdrv_close_all() has no effect on empty drives (whose media were not changed) any longer. This breaks some test outputs, fix them. After a follow-up patch, empty drives will generally use a

[Qemu-devel] [PATCH v2 14/37] block: Add BlockBackendRootState

2015-02-09 Thread Max Reitz
This structure will store some of the state of the root BDS if the BDS tree is removed, so that state can be restored once a new BDS tree is inserted. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/block-backend.c | 26

[Qemu-devel] [PATCH v2 37/37] iotests: Add test for change-related QMP commands

2015-02-09 Thread Max Reitz
Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/118 | 653 + tests/qemu-iotests/118.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 659 insertions(+) create mode 100755 tests/qemu-iotests/118 create mode 100644

[Qemu-devel] [PATCH v2 32/37] qmp: Introduce blockdev-change-medium

2015-02-09 Thread Max Reitz
Introduce a new QMP command 'blockdev-change-medium' which is intended to replace the 'change' command for block devices. The existing function qmp_change_blockdev() is accordingly renamed to qmp_blockdev_change_medium(). Signed-off-by: Max Reitz mre...@redhat.com --- blockdev.c|

Re: [Qemu-devel] [PATCH v2 0/3] nbd: Drop BDS backpointer

2015-02-09 Thread Stefan Hajnoczi
On Fri, Feb 06, 2015 at 04:06:15PM -0500, Max Reitz wrote: Right now, bdrv_swap() on NBD BDSs results in a segmentation fault pretty much all of the time. This series fixes this. Note that this is not a common case, as bdrv_swap() is generally only performed on root BDSs (there are

Re: [Qemu-devel] [PATCH v2 01/37] blockdev: Allow creation of BDS trees without BB

2015-02-09 Thread Max Reitz
On 2015-02-09 at 13:17, Eric Blake wrote: On 02/09/2015 10:11 AM, Max Reitz wrote: If the id field is missing from the options given to blockdev-add, just omit the BlockBackend and create the BlockDriverState tree alone. However, if id is missing, node-name must be specified; otherwise, the

[Qemu-devel] [PATCH v2 08/22] block: Use blk_remove_bs() in blk_delete()

2015-02-09 Thread Max Reitz
Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/block-backend.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index 98f4af9..bcad1dc 100644 --- a/block/block-backend.c +++

[Qemu-devel] [PATCH v2 19/22] block: Remove bdrv_states

2015-02-09 Thread Max Reitz
Every entry in this list should be a root BDS and as such either be anchored to a BlockBackend or be owned by the monitor. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 21 + include/block/block.h | 1 - include/block/block_int.h | 2 -- 3

[Qemu-devel] [PATCH v2 10/22] block: Make bdrv_close() static

2015-02-09 Thread Max Reitz
There are no users of bdrv_close() left, except for one of bdrv_open()'s failure paths, bdrv_close_all() and bdrv_delete(), and that is good. Make bdrv_close() static so nobody makes the mistake of directly using bdrv_close() again. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric

[Qemu-devel] [PATCH v3 01/12] qcow2: Add new overlap check functions

2015-02-09 Thread Max Reitz
The existing qcow2 metadata overlap detection function used existing structures to determine the location of the image metadata, from plain fields such as l1_table_offset and l1_size in the BDRVQcowState, over image structures in memory such as the L1 table for the L2 tables' positions, or it even

[Qemu-devel] [PATCH v3 07/12] qcow2/overlaps: Protect active L1 table

2015-02-09 Thread Max Reitz
Keep track of the active L1 table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/qcow2-cluster.c | 11 +++ block/qcow2-snapshot.c | 10 ++ block/qcow2.c

Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls

2015-02-09 Thread Stefan Weil
Am 09.02.2015 um 09:07 schrieb Pavel Dovgaluk: From: Stefan Weil [mailto:s...@weilnetz.de] Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: On w64, setjmp is implemented by _setjmp which needs a second parameter. This parameter should be NULL to allow using longjump from generated code. This

[Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-09 Thread Michael S. Tsirkin
It doesn't make sense to copy values manually: the only issue with getting headers from linux seems to be dealing with linux/types, we can easily fix that automatically while importing. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- FYI this is what I propose instead of the recently

[Qemu-devel] [Bug 1392504] Re: USB Passthrough is not working anymore

2015-02-09 Thread Leen Keus
Hi Serge, Following error message appears after I teared down apparmor and when I tried to start the vm: $sudo virsh start vm error: Failed to start domain vm error: error from service: ListActivatableNames: Failed to query AppArmor policy: No such file or directory Can anybody provide me a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] openpic: convert to vmstate

2015-02-09 Thread Mark Cave-Ayland
On 09/02/15 13:50, Juan Quintela wrote: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: On 09/02/15 12:43, Alexander Graf wrote: Ha! I did actually do this but I accidentally messed up a rebase just before sending out the patchset so it got lost. But yes, I agree a version bump to 3

Re: [Qemu-devel] [PATCH v2 08/37] block: Make bdrv_is_inserted() recursive

2015-02-09 Thread Eric Blake
On 02/09/2015 10:11 AM, Max Reitz wrote: If bdrv_is_inserted() is called on the top level BDS, it should make sure all nodes in the BDS tree are actually inserted. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v3 06/12] qcow2/overlaps: Protect refcount blocks

2015-02-09 Thread Max Reitz
Keep track of the refcount blocks in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/qcow2-refcount.c | 38 +- 1 file changed, 37 insertions(+),

  1   2   3   4   >