[Qemu-devel] [PATCH 3/6] target-tricore: Add instructions of RRR2 opcode format

2015-02-10 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de --- target-tricore/translate.c | 149 +++ target-tricore/tricore-opcodes.h | 2 +- 2 files changed, 136 insertions(+), 15 deletions(-) diff --git a/target-tricore/translate.c

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp = migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 14:58, Peter Lieven wrote: Yes, but it is still not ready. It only works with 3.18 and 3.16. Okay, but for testing I will use 3.19 with the patch for testing if the assertion disappears?! If you use 3.19 in the host, you don't need kvm-kmod. If you use 3.19 with kvm-kmod,

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-10 Thread Kevin Wolf
Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am 10.02.2015 um 14:54 schrieb Kevin Wolf: Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote: Am 10.02.2015 um 12:41 hat Peter Lieven geschrieben: Am 09.02.2015 um 17:09 schrieb

[Qemu-devel] [PATCH 0/6] TriCore: Add RRR1 and RRR2 instructions

2015-02-10 Thread Bastian Koppelmann
Hi, the patchset fixes two minor bugs and takes care of all the packed/fixed point mac instructions. So far I only implemented all the multiply-add instructions, since the multiply-sub instructions are similar and I don't want the reviewers to find the same mistakes twice. Once these are reviewed

Re: [Qemu-devel] [PATCH] block:Fix FIXED base vpc be probed to raw format

2015-02-10 Thread Xiaodong Gong
On Mon, Feb 9, 2015 at 10:54 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sun, Feb 08, 2015 at 08:39:52PM +0800, Xiaodong Gong wrote: When open the vpc snapshot based FIXED format, its backing file, this FIXED vpc image, could be probed as a raw image, because that the

Re: [Qemu-devel] [PATCH 7/7] target-mips: Add IEEE 754-2008 features support

2015-02-10 Thread Maciej W. Rozycki
On Tue, 10 Feb 2015, Leon Alrae wrote: These cases could be addressed by either replacing subtraction from 0.0 with multiplication by -1.0, or by tweaking the rounding mode as needed temporarily. Given that the computational cost of multiplication is uncertain and likely higher or at

[Qemu-devel] [PATCH 5/6] target-tricore: Add instructions of RRR1 opcode format, which have 0x43 as first opcode

2015-02-10 Thread Bastian Koppelmann
Add helpers: * madd64_q_ssov: multiply two 32 bit q-format number, add them with a 64 bit q-format number and saturate. * madd32_q_add_ssov: add two 64 bit q-format numbers and return a 32 bit result. * maddr_q_ssov: multiplay two 32 bit

Re: [Qemu-devel] [PATCH v2 16/17] ahci: Recompute cur_cmd on migrate post load

2015-02-10 Thread John Snow
On 02/10/2015 04:56 AM, Stefan Hajnoczi wrote: On Tue, Dec 16, 2014 at 08:36:06PM -0500, John Snow wrote: When the AHCI HBA device is migrated, all of the information that led to the request being created is stored in the AHCIDevice structures, except for pointers into guest data where return

[Qemu-devel] [PATCH 2/6] target-tricore: fix msub32_suov return wrong results

2015-02-10 Thread Bastian Koppelmann
If the signed result of the multiplication overflows, we would get a negative value, which would result in a addition instead of a subtraction. Now we do the overflow calculation and saturation by hand instead of using suov32_neg. Signed-off-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de

[Qemu-devel] [PATCH 4/6] target-tricore: Add instructions of RRR1 opcode format, which have 0x83 as first opcode

2015-02-10 Thread Bastian Koppelmann
Add helpers: * add64_ssov: adds two 64 bit values and saturates the result. * addr_h/_ssov: adds two halfwords with two words in q-format with rounding / and saturates each result independetly. Add microcode generator: * gen_add64_d: adds two 64 bit values. *

Re: [Qemu-devel] QEMU data passing between modules

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 15:02, boddu pavan wrote: Does all the hw_peripherals has any root node kind of thing. Which makes all our nodes connected ? The common superclass of the devices is DeviceState. The root object that connects the devices is the QEMUMachine. Paolo

[Qemu-devel] [PATCH V12 0/3] Virtual Machine Generation ID

2015-02-10 Thread Gal Hammer
Hi, Resending patches after a bug was found in the call to the bios_linker_loader_add_pointer function. Please note that this patch set doesn't include the *.hex.generated files and the binary ACPI tables (make check will fail). Thanks, Gal. V12 - Fixed bios_linker_loader_add_pointer call

[Qemu-devel] [PATCH V12 2/3] i386: Add a Virtual Machine Generation ID device

2015-02-10 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global vmgenid.uuid parameter. Signed-off-by: Gal Hammer gham...@redhat.com ---

[Qemu-devel] [PATCH V12 1/3] docs: vm generation id device's description

2015-02-10 Thread Gal Hammer
Signed-off-by: Gal Hammer gham...@redhat.com --- docs/specs/vmgenid.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index

[Qemu-devel] [PATCH 6/6] target-tricore: Add instructions of RRR1 opcode format, which have 0xc3 as first opcode

2015-02-10 Thread Bastian Koppelmann
Add helpers helper_addsur_h/_ssov which adds one halfword and subtracts one halfword, rounds / and saturates each half word independently. Add microcode helper functions: * gen_maddsu_h/sus_h: multiply two halfwords left justified and add to the first one word and

Re: [Qemu-devel] [PATCH] savevm: Improve error message for blocked migration

2015-02-10 Thread Eric Blake
On 02/10/2015 06:25 AM, Kevin Wolf wrote: If an internal snapshot can't be saved because migration is blocked (most commonly probably because of AHCI), we had a really bad error message: $ echo -e savevm foo\nquit | qemu -M q35 /tmp/test.qcow2 -monitor stdio You know, 'echo -e' is

Re: [Qemu-devel] [PATCH v2 02/12] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus.

2015-02-10 Thread Igor Mammedov
On Wed, 4 Feb 2015 10:51:16 +0800 Zhu Guihua zhugh.f...@cn.fujitsu.com wrote: From: Tang Chen tangc...@cn.fujitsu.com Add a new API named acpi_memory_get_slot_status_descriptor() to obtain a single memory slot status. Doing this is because this procedure will be used by other functions in

[Qemu-devel] [PATCH V12 3/3] tests: add a unit test for the vmgenid device.

2015-02-10 Thread Gal Hammer
Signed-off-by: Gal Hammer gham...@redhat.com --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 48 2 files changed, 50 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index

Re: [Qemu-devel] [PATCH 2/2] e1000: unconditionally enable bus mastering

2015-02-10 Thread Amos Kong
On Fri, Feb 06, 2015 at 01:46:36PM +, Stefan Hajnoczi wrote: On Wed, Jan 07, 2015 at 04:08:29PM +, Stefan Hajnoczi wrote: On Thu, Dec 18, 2014 at 05:22:19PM +0800, Amos Kong wrote: After enabled network debug of e1000 in Win2012-64r2 guest, Bus mastering of e1000 can't be enabled

[Qemu-devel] block: low level read from disk for IDE_DMA_READ

2015-02-10 Thread Shailesh Kumar
Hi, I am implementing read equivalent routine in qemu. Can some one help me understand control flow of the qemu read/write implementation. I am using xen-4.2.0 and qemu-1.6.1 My requirement is simple: I have a 1024*1024 buffer already filled with some useful data. Now when windows (my

[Qemu-devel] [v5 01/12] docs: Add a doc about multiple thread compression

2015-02-10 Thread Liang Li
Give some details about the multiple thread (de)compression and how to use it in live migration. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Reviewed-by: Dr.David Alan Gilbert dgilb...@redhat.com --- docs/multi-thread-compression.txt | 149

[Qemu-devel] [v5 03/12] migration: Add the framework of multi-thread decompression

2015-02-10 Thread Liang Li
Add the code to create and destroy the multiple threads those will be used to do data decompression. Left some functions empty just to keep clearness, and the code will be added later. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Reviewed-by:

[Qemu-devel] [PATCH v17 1/2] sPAPR: Implement EEH RTAS calls

2015-02-10 Thread Gavin Shan
The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callbacks sPAPRPHBClass::{eeh_set_option, eeh_get_state, eeh_reset, eeh_configure}, which are going to be used as follows: * RTAS

[Qemu-devel] [PATCH v17 2/2] sPAPR: Implement sPAPRPHBClass EEH callbacks

2015-02-10 Thread Gavin Shan
The patch implements sPAPRPHBClass EEH callbacks so that the EEH RTAS requests can be routed to VFIO for further handling. Signed-off-by: Gavin Shan gws...@linux.vnet.ibm.com --- hw/ppc/spapr_pci_vfio.c | 98 + hw/vfio/common.c| 1 + 2

Re: [Qemu-devel] [PATCH 8/9] exec: convert ram_list to QLIST

2015-02-10 Thread Fam Zheng
On Fri, 02/06 17:55, Paolo Bonzini wrote: From: Mike Day ncm...@ncultra.org QLIST has RCU-friendly primitives, so switch to it. Signed-off-by: Mike Day ncm...@ncultra.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- arch_init.c | 19 exec.c

Re: [Qemu-devel] [PATCH v1] add intel restricted transactional memory test case.

2015-02-10 Thread Xin Tong
Please someone review this patch. Thanks, Xin On Thu, Feb 5, 2015 at 2:04 PM, Xin Tong trent.t...@gmail.com wrote: I am planning to implement support for Intel RTM. similar to what is done for PowerPC. we can default to fault (transaction abort) to the fallback code path. Would like to check

Re: [Qemu-devel] [PATCH v4 3/4] target-arm: Add 32/64-bit register sync

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 10:50, Greg Bellows greg.bell...@linaro.org wrote: Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows

Re: [Qemu-devel] [PATCH v4 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 10:50, Greg Bellows greg.bell...@linaro.org wrote: Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows greg.bell...@linaro.org --- v3 - v4 - Add check that to make sure

[Qemu-devel] [PATCH 02/11] a9gtimer: remove superfluous '\n' around error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/timer/a9gtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/a9gtimer.c b/hw/timer/a9gtimer.c index 435142a..b087bbd 100644 --- a/hw/timer/a9gtimer.c +++

[Qemu-devel] [PATCH 11/11] vhost: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/virtio/vhost-backend.c | 2 +- net/vhost-user.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c index

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Peter Maydell
On 11 February 2015 at 01:36, Chen, Tiejun tiejun.c...@intel.com wrote: On 2015/2/10 3:56, Michael S. Tsirkin wrote: It doesn't make sense to copy values manually: the only issue with getting headers from linux seems to be dealing with linux/types, we can easily fix that automatically while

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-10 Thread Chen, Tiejun
On 2015/2/9 19:05, Ian Campbell wrote: On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: What about this? I've not read the code in detail,since I'm travelling but from a quick glance it looks to be implementing the sort of thing I meant, thanks. Thanks for your time. A couple of

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Peter Maydell
On 11 February 2015 at 02:50, Chen, Tiejun tiejun.c...@intel.com wrote: On 2015/2/11 10:03, Peter Maydell wrote: The linux-headers/ directory contains header files which can only validly be included if the host we're compiling on is Linux. Some of them will cause compile failures on OSX or

[Qemu-devel] [PATCH 03/11] pl330.c: remove superfluous '\n' around error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/dma/pl330.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c index 16cf77e..0f72b59 100644 --- a/hw/dma/pl330.c +++ b/hw/dma/pl330.c @@ -1566,7

[Qemu-devel] [PATCH 08/11] xtensa: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/xtensa/sim.c| 2 +- hw/xtensa/xtfpga.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c index 37ea9ae..328d209 100644 ---

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Chen, Tiejun
On 2015/2/10 3:56, Michael S. Tsirkin wrote: It doesn't make sense to copy values manually: the only issue with getting headers from linux seems to be dealing with linux/types, we can easily fix that automatically while importing. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- FYI this

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Chen, Tiejun
On 2015/2/11 10:03, Peter Maydell wrote: On 11 February 2015 at 01:36, Chen, Tiejun tiejun.c...@intel.com wrote: On 2015/2/10 3:56, Michael S. Tsirkin wrote: It doesn't make sense to copy values manually: the only issue with getting headers from linux seems to be dealing with linux/types, we

[Qemu-devel] [PATCH 09/11] tpm: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/tpm/tpm_passthrough.c | 12 ++-- tpm.c| 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c index

[Qemu-devel] [PATCH 05/11] Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- exec.c | 2 +- hw/ide/pci.c | 2 +- hw/microblaze/boot.c | 2 +- migration/rdma.c | 2 +- qemu-img.c | 2 +- target-s390x/kvm.c | 2 +- trace/control.c | 2 +- 7

Re: [Qemu-devel] [PATCH v4 1/4] target-arm: Add CPU property to disable AArch64

2015-02-10 Thread Greg Bellows
On Tue, Feb 10, 2015 at 10:03 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 10 February 2015 at 10:50, Greg Bellows greg.bell...@linaro.org wrote: Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 20:04, Michael S. Tsirkin wrote: So that's not good. We need a way to negotiate the capability, we can't just deadlock with legacy slaves. Should we wait many seconds if slave not reply we just return error? -- Regards, Haifeng

Re: [Qemu-devel] [PATCH 6/9] exec: protect mru_block with RCU

2015-02-10 Thread Fam Zheng
On Fri, 02/06 17:55, Paolo Bonzini wrote: Hence, freeing a RAMBlock has to be switched to call_rcu. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com

[Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-02-10 Thread Liang Li
Implement the core logic of the multiple thread compression. At this point, multiple thread compression can't co-work with xbzrle yet. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com --- arch_init.c | 193

[Qemu-devel] [v5 10/12] migration: Add the core code for decompression

2015-02-10 Thread Liang Li
Implement the core logic of multiple thread decompression, the decompression can work now. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com --- arch_init.c | 50 -- 1 file changed, 48 insertions(+), 2

[Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Yestoday, I found that some files have superflous '\n' charactor around error_report/error_setg when reviewed patches. By a simply script, the below files were listed. Classify and fix them. It's suitable for appling via qemu-trivial IMHO. Gonglei (11):

[Qemu-devel] [PATCH 06/11] vhost-scsi: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/scsi/vhost-scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index dcb2bc5..54f916e 100644 --- a/hw/scsi/vhost-scsi.c +++

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Peter Maydell
On 9 February 2015 at 19:56, Michael S. Tsirkin m...@redhat.com wrote: +rm -rf $output/standard-headers/linux +mkdir -p $output/standard-headers/linux +for f in $tmpdir/include/linux/virtio*h; do +header=$(expr $f : '.*/\(.*\)'); +sed -e 's/__u\([0-9][0-9]*\)/uint\1_t/g' \ +

Re: [Qemu-devel] [PATCH 7/9] cosmetic changes preparing for the following patches

2015-02-10 Thread Fam Zheng
On Fri, 02/06 17:55, Paolo Bonzini wrote: From: Mike Day ncm...@ncultra.org Signed-off-by: Mike Day ncm...@ncultra.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com

[Qemu-devel] [v5 06/12] arch_init: Add and free data struct for decompression

2015-02-10 Thread Liang Li
Define the data structure and variables used to do multiple thread decompression, and add the code to initialize and free them. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Reviewed-by: Dr.David Alan Gilbert dgilb...@redhat.com --- arch_init.c |

[Qemu-devel] [v5 02/12] migration: Add the framework of multi-thread compression

2015-02-10 Thread Liang Li
Add the code to create and destroy the multiple threads those will be used to do data compression. Left some functions empty to keep clearness, and the code will be added later. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Reviewed-by: Dr.David

[Qemu-devel] [PATCH v5 0/12] migration: Add a new feature to do live migration

2015-02-10 Thread Liang Li
This feature can help to reduce the data transferred about 60%, and the migration time can also be reduced about 70%. Summary of changed from v4-v5 -Fix some typo errors -Fix the bug related with XBZRLE -Added some comments -Squash setting and querying commands into one

[Qemu-devel] [v5 04/12] qemu-file: Add compression functions to QEMUFile

2015-02-10 Thread Liang Li
qemu_put_compression_data() compress the data and put it to QEMUFile. qemu_put_qemu_file() put the data in the buffer of source QEMUFile to destination QEMUFile. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com --- include/migration/qemu-file.h | 3

[Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-02-10 Thread Liang Li
Add the qmp and hmp commands to tune and query the parameters used in live migration. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com --- hmp-commands.hx | 17 hmp.c | 56 + hmp.h

Re: [Qemu-devel] CPU TLB flush with multithread TCG.

2015-02-10 Thread Alex Bennée
Frederic Konrad fred.kon...@greensocs.com writes: Hi everybody, In multithread tlb_flush is broken as CPUA can flush an other CPUB and CPUB can be executing code, and fixing this can be quite hard: * We need to exit the CPU which is flushed. * Makes sure the CPU is stopped. *

Re: [Qemu-devel] [PATCH v4 1/4] target-arm: Add CPU property to disable AArch64

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 10:50, Greg Bellows greg.bell...@linaro.org wrote: Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the

[Qemu-devel] [PATCH 07/11] vfio: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/vfio/common.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index e71385e..6c49cc4 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c

[Qemu-devel] [PATCH 01/11] block: remove superfluous '\n' around error_report/error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/archipelago.c | 6 +++--- hw/block/nand.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/archipelago.c b/block/archipelago.c index a8114b5..855655c 100644 ---

[Qemu-devel] [PATCH 04/11] numa: remove superfluous '\n' around error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- numa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/numa.c b/numa.c index afd2866..6decd13 100644 --- a/numa.c +++ b/numa.c @@ -59,7 +59,7 @@ static void

[Qemu-devel] [v5 05/12] arch_init: Alloc and free data struct for compression

2015-02-10 Thread Liang Li
Define the data structure and variables used to do multiple thread compression, and add the code to initialize and free them. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Reviewed-by: Dr.David Alan Gilbert dgilb...@redhat.com --- arch_init.c | 34

[Qemu-devel] [v5 07/12] migration: Split the function ram_save_page

2015-02-10 Thread Liang Li
Split the function ram_save_page for code reuse purpose. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com --- arch_init.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git

[Qemu-devel] [v5 11/12] migration: Add interface to control compression

2015-02-10 Thread Liang Li
The multiple compression threads can be turned on/off through qmp and hmp interface before doing live migration. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Reviewed-by: Dr.David Alan Gilbert dgilb...@redhat.com Reviewed-by: Eric Blake

[Qemu-devel] [v5 09/12] migration: Make compression co-work with xbzrle

2015-02-10 Thread Liang Li
Now, multiple thread compression can co-work with xbzrle. when xbzrle is on, multiple thread compression will only work at the first round of RAM data sync. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Reviewed-by: Dr.David Alan Gilbert

[Qemu-devel] [PATCH v17 0/2] EEH Support for VFIO Devices

2015-02-10 Thread Gavin Shan
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support, which was merged during 3.17 merge window. This patchset has been rebased to Alex Graf's QEMU repository: git://github.com/agraf/qemu.git (branch: ppc-next) The

[Qemu-devel] [Xen-devel] [Block dev] : Qemu block ide_dma_read call routine

2015-02-10 Thread Shailesh Kumar
Hi, I am implementing read equivalent routine in qemu. Can some one help me understand control flow of the qemu read/write implementation. I am using xen-4.2.0 and qemu-1.6.1 My requirement is simple: I have a 1024*1024 buffer already filled with some useful data. Now when windows (my

Re: [Qemu-devel] [RFC v3 03/10] aer: introduce pcie_aer_setup to setup aer related bits

2015-02-10 Thread Alex Williamson
On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote: because function pcie_aer_init() is for adding a new aer capability, but for vfio device, we only need to capture the aer capability from vfio device configuration space, so here we introduce pcie_aer_setup() to init all raw devices. I don't

Re: [Qemu-devel] [RFC v3 04/10] vfio: add pcie extanded capability support

2015-02-10 Thread Alex Williamson
On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote: when we detect extanded capability in vfio device, then we should initialize the vfio device corresponding feature register bits. so guest OS can find it and set those bits as needed. and initialize aer capability. Signed-off-by: Chen Fan

[Qemu-devel] [PATCH 9/9] qemu-char: Avoid qerror_report_err() outside QMP command handlers

2015-02-10 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in legacy chardev parser qemu_chr_parse_compat(). Legacy chardev syntax is not to be used in QMP. Signed-off-by: Markus

Re: [Qemu-devel] [PATCH] memory: unregister AddressSpace MemoryListener within BQL

2015-02-10 Thread Alex Williamson
On Tue, 2015-02-10 at 13:52 +0100, Paolo Bonzini wrote: address_space_destroy_dispatch is called from an RCU callback and hence outside the iothread mutex (BQL). However, after address_space_destroy no new accesses can hit the destroyed AddressSpace so it is not necessary to observe changes

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-10 Thread Eric Blake
On 02/10/2015 09:34 AM, Markus Armbruster wrote: I've typed error_report(%s, error_get_pretty(ERR)) too many times already, and I've fixed too many instances of qerror_report_err(ERR) to error_report(%s, error_get_pretty(ERR)) as well. Capture the pattern in a convenience function. Since

Re: [Qemu-devel] [PATCH] memory: unregister AddressSpace MemoryListener within BQL

2015-02-10 Thread Alex Williamson
On Tue, 2015-02-10 at 18:13 +0100, Paolo Bonzini wrote: On 10/02/2015 18:11, Alex Williamson wrote: Reported-by: Alex Williamson alex.william...@redhat.com Fixes: 374f2981d1f10bc4307f250f24b2a7ddb9b14be0 Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- exec.c

[Qemu-devel] [PATCH 1/3] Add -incoming pause

2015-02-10 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com -incoming pause causes qemu to wait for an incoming migration to be specified later. The monitor can be used to set migraiton capabilities that may affect the incoming connection process. Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com

[Qemu-devel] [PATCH 3/3] Document -incoming options

2015-02-10 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Document the various URI formats for -incoming, the previous manpage and help text was wrong (out of date?) Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- qemu-options.hx | 29 ++--- 1 file changed, 26

[Qemu-devel] [PATCH 7/9] vl: Avoid qerror_report_err() outside QMP command handlers

2015-02-10 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helpers machine_set_property() and object_create(). Signed-off-by: Markus Armbruster arm...@redhat.com ---

Re: [Qemu-devel] [RFC v3 08/10] vfio-pci: add VFIO_FEATURE_ENABLE_AER_CAP feature

2015-02-10 Thread Alex Williamson
On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote: add a new aercap feature in vfio device, for controlling whether expose aer capability. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/vfio/pci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] vhost-scsi: Improve error reporting for invalid vhostfd

2015-02-10 Thread Paolo Bonzini
On 09/02/2015 11:52, Markus Armbruster wrote: We get two error messages: one from monitor_handle_fd_param2(), and another one from vhost_scsi_realize(). The second one gets suppressed in QMP context. That's because monitor_handle_fd_param() calls qerror_report_err(). Calling

Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause

2015-02-10 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: On Tue, Feb 10, 2015 at 04:16:38PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Once a qemu has been started with -incoming pause the migration can be started by issuing: migrate -u

[Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err()

2015-02-10 Thread Markus Armbruster
Tree-wide cleanup, but the tree-wide changes are mechanical. If nobody objects, I'll route it through my own tree. Depends on my [PATCH] vhost-scsi: Improve error reporting for invalid vhostfd. PATCH 01 is responsible for the bulk of the diffstat. I could split off one or more of block, arm,

[Qemu-devel] [PATCH 5/9] numa: Avoid qerror_report_err() outside QMP command handlers

2015-02-10 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helper numa_init_func() and board setup helper memory_region_allocate_system_memory(). Signed-off-by:

[Qemu-devel] [PATCH 8/9] qemu-img: Avoid qerror_report_err() outside QMP command handlers

2015-02-10 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err(). Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-img.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[Qemu-devel] [PATCH 4/9] net: Avoid qerror_report_err() outside QMP command handlers

2015-02-10 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in HMP command handler hmp_host_net_add() and initial startup helpers net_init_client(), net_init_netdev(). Keep it in QMP

Re: [Qemu-devel] [PATCH 1/3] Add -incoming pause

2015-02-10 Thread Juan Quintela
Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com -incoming pause causes qemu to wait for an incoming migration to be specified later. The monitor can be used to set migraiton capabilities that may affect the incoming connection process.

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 17:34, Markus Armbruster wrote: I've typed error_report(%s, error_get_pretty(ERR)) too many times already, and I've fixed too many instances of qerror_report_err(ERR) to error_report(%s, error_get_pretty(ERR)) as well. Capture the pattern in a convenience function. Since

Re: [Qemu-devel] [PATCH 3/3] Document -incoming options

2015-02-10 Thread Juan Quintela
Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Document the various URI formats for -incoming, the previous manpage and help text was wrong (out of date?) Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Reviewed-by: Juan

Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause

2015-02-10 Thread Juan Quintela
Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Once a qemu has been started with -incoming pause the migration can be started by issuing: migrate -u uri Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com -

[Qemu-devel] [PATCH 6/9] tpm: Avoid qerror_report_err() outside QMP command handlers

2015-02-10 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helper configure_tpm(). Signed-off-by: Markus Armbruster arm...@redhat.com --- tpm.c | 6 ++ 1 file

[Qemu-devel] [PATCH 3/9] monitor: Avoid qerror_report_err() outside QMP command handlers

2015-02-10 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in HMP command handler hmp_trace_event(). Signed-off-by: Markus Armbruster arm...@redhat.com --- monitor.c | 3 +-- 1 file

[Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param()

2015-02-10 Thread Markus Armbruster
monitor_handle_fd_param() is a wrapper around monitor_handle_fd_param2() that feeds errors to qerror_report_err() instead of returning them. qerror_report_err() is inappropriate in many contexts. monitor_handle_fd_param() looks simpler than monitor_handle_fd_param2(), which tempts use. Remove

Re: [Qemu-devel] [RFC v3 06/10] piix: disable all vfio device aercap property

2015-02-10 Thread Alex Williamson
On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote: because at i440FX platform, all pcie device don't support aer capability, so for all vfio device, we don't need to expose the aer capability. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/i386/pc_piix.c | 16

Re: [Qemu-devel] [RFC v3 07/10] vfio_pci: change vfio device features bit macro to enum definition

2015-02-10 Thread Alex Williamson
On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote: Introduce an independent enum structure to define the features bitmap, it would be good for adding new features definition. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/vfio/pci.c | 8 ++-- 1 file changed, 6

Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause

2015-02-10 Thread Eric Blake
On 02/10/2015 09:47 AM, Daniel P. Berrange wrote: On Tue, Feb 10, 2015 at 04:16:38PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Once a qemu has been started with -incoming pause the s/pause the/pause, the/ migration can be started by

Re: [Qemu-devel] [PATCH] memory: unregister AddressSpace MemoryListener within BQL

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 18:11, Alex Williamson wrote: Reported-by: Alex Williamson alex.william...@redhat.com Fixes: 374f2981d1f10bc4307f250f24b2a7ddb9b14be0 Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- exec.c | 6 +- include/exec/memory-internal.h | 1 +

[Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause

2015-02-10 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Once a qemu has been started with -incoming pause the migration can be started by issuing: migrate -u uri Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- hmp-commands.hx | 11 +++ hmp.c | 6 --

[Qemu-devel] [PATCH 0/3] -incoming pause

2015-02-10 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com This patchset provides a way of setting options on an incoming migration before the fd/process/socket has been created. start qemu with -incoming pause use the monitor to set whatever you need migrate -u theuri Dave Dr. David Alan

Re: [Qemu-devel] [PULL 0/4] coverity: Improve and extend model

2015-02-10 Thread Paolo Bonzini
On 05/02/2015 18:11, Peter Maydell wrote: On 5 February 2015 at 16:24, Markus Armbruster arm...@redhat.com wrote: The following changes since commit ec6f25e788ef57ce1e9f734984ef8885172fd9e2: Merge remote-tracking branch 'remotes/rth/tags/pull-tg-s390-20150203' into staging (2015-02-03

Re: [Qemu-devel] [PATCH v12 00/17] block: incremental backup series

2015-02-10 Thread John Snow
On 02/09/2015 08:35 PM, John Snow wrote: Welcome to the incremental backup newsletter, where we discuss exciting developments in non-redundant backup technology. This patchset enables the in-memory part of the incremental backup feature. There are two series on the mailing list now by

[Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-10 Thread Markus Armbruster
I've typed error_report(%s, error_get_pretty(ERR)) too many times already, and I've fixed too many instances of qerror_report_err(ERR) to error_report(%s, error_get_pretty(ERR)) as well. Capture the pattern in a convenience function. Since it's almost invariably followed by error_free(), stuff

Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause

2015-02-10 Thread Daniel P. Berrange
On Tue, Feb 10, 2015 at 04:16:38PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Once a qemu has been started with -incoming pause the migration can be started by issuing: migrate -u uri Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v3 2/6] block: vmdk - move string allocations from stack to the heap

2015-02-10 Thread Paolo Bonzini
On 22/01/2015 14:03, Jeff Cody wrote: Functions 'vmdk_parse_extents' and 'vmdk_create' allocate several PATH_MAX sized arrays on the stack. Make these dynamically allocated. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vmdk.c | 39 +++ 1 file

[Qemu-devel] [PATCH RFC v5 5/5] qemu-iotests: s390x: fix test 051

2015-02-10 Thread Xiao Guang Chen
The tests for device type ide_cd should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and virtio0 set for the s390 platform. A x86 platform specific output file is also needed. A

[Qemu-devel] [PATCH RFC v5 4/5] qemu-iotests: s390x: fix test 055

2015-02-10 Thread Xiao Guang Chen
There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Signed-off-by: Xiao Guang Chen,che...@linux.vnet.ibm.com --- tests/qemu-iotests/055 | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/qemu-iotests/055

  1   2   3   4   >