Re: [Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: On 12/02/2015 14:20, Peter Lieven wrote: I have a Windows system which fails to migrate with this error almost reliably when migrating from one host to another (both qemu-2.2.0). The error seems to be gone in master, but I was unable to track the

[Qemu-devel] [PATCH v3 0/4] NUMA: Validate CPU configuration

2015-02-12 Thread Eduardo Habkost
This adds extra checks to the NUMA code to make sure the CPU configuration is consistent. This needs to be applied on top of the following series: Message-Id: 1423421482-11619-1-git-send-email-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH 0/7] NUMA code cleanup From: Eduardo Habkost

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Eduardo Habkost
On Thu, Feb 12, 2015 at 05:01:54PM +0100, Igor Mammedov wrote: On Thu, 12 Feb 2015 13:24:26 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Thu, Feb 12, 2015 at 04:01:49PM +0100, Igor Mammedov wrote: [...] +DECLARE_BITMAP(present_cpus, MAX_CPUMASK_BITS); naming is a bit

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 18:18 schrieb Charles Arnold carn...@suse.com: On 2/12/2015 at 03:23 AM, Kevin Wolf kw...@redhat.com wrote: Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: Am 12.02.2015 um

[Qemu-devel] [PATCH] hw/arm/virt: bus-range/end is off by one

2015-02-12 Thread Laszlo Ersek
According to PCI Bus Binding to IEEE Std 1275-1994, 3.1.2. Bus-specific Properties for Bus Nodes, the second integer in bus-range is an inclusive limit. This seems to be consistent with several *.dtsi files in the kernel tree, where examples like bus-range = 0 0; are visible. In addition,

Re: [Qemu-devel] [PATCH] hw/arm/virt: bus-range/end is off by one

2015-02-12 Thread Wei Huang
On 02/12/2015 12:50 PM, Laszlo Ersek wrote: According to PCI Bus Binding to IEEE Std 1275-1994, 3.1.2. Bus-specific Properties for Bus Nodes, the second integer in bus-range is an inclusive limit. This seems to be consistent with several *.dtsi files in the kernel tree, where examples

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
On 12 Feb 2015, at 16:31, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Mark Burton (mark.bur...@greensocs.com) wrote: On 12 Feb 2015, at 16:01, Peter Maydell peter.mayd...@linaro.org wrote: On 12 February 2015 at 14:45, Alexander Graf ag...@suse.de wrote: On 12.02.2015, at

Re: [Qemu-devel] [PATCH] memory: Fix double unref of flatview

2015-02-12 Thread Matthew Rosato
On 02/12/2015 12:34 PM, Paolo Bonzini wrote: On 12/02/2015 17:21, Matthew Rosato wrote: Since 374f2981d1 memory: protect current_map by RCU, address_space_update_topology unrefs the old_flatview twice, once by call_rcu and once by direct call. This patch removes the direct call in favor

[Qemu-devel] [PATCH v3 3/4] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Eduardo Habkost
Each CPU can appear in only one NUMA node on the NUMA config. Reject configuration if a CPU appears in multiple nodes. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- v1 - v2: (no changes) v2 - v3: * Rename present_cpus to seen_cpus, to make it less confusing * Use GString and

[Qemu-devel] [PATCH v3 1/4] numa: Fix off-by-one error at MAX_CPUMASK_BITS check

2015-02-12 Thread Eduardo Habkost
Fix the CPU index check to ensure we don't go beyond the size of the node_cpu bitmap. CPU index is always less than MAX_CPUMASK_BITS, as documented at sysemu.h: The following shall be true for all CPUs: cpu-cpu_index max_cpus = MAX_CPUMASK_BITS Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH v3 2/4] numa: Reject CPU indexes max_cpus

2015-02-12 Thread Eduardo Habkost
CPU index is always less than max_cpus, as documented at sysemu.h: The following shall be true for all CPUs: cpu-cpu_index max_cpus = MAX_CPUMASK_BITS Reject configuration which uses invalid CPU indexes. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- v1 - v2: (no changes) v2 - v3:

[Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-12 Thread Eduardo Habkost
Instead of silently assigning CPU to node 0 when it is omitted from the command-line, check if all CPUs up to max_cpus are present in the NUMA configuration. I am making this a warning and not a fatal error, to allow management software to be updated if necessary. Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 18:50, Eduardo Habkost wrote: + +if (!bitmap_full(seen_cpus, max_cpus)) { +char *msg; +bitmap_complement(seen_cpus, seen_cpus, max_cpus); +msg = enumerate_cpus(seen_cpus, max_cpus); +error_report(warning: CPU(s) not present in any NUMA

Re: [Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 18:53 schrieb Juan Quintela quint...@redhat.com: Paolo Bonzini pbonz...@redhat.com wrote: On 12/02/2015 14:20, Peter Lieven wrote: I have a Windows system which fails to migrate with this error almost reliably when migrating from one host to another (both

Re: [Qemu-devel] [PATCH v3 4/4] bootdevice: update boot_order in MachineState

2015-02-12 Thread Markus Armbruster
arei.gong...@huawei.com writes: From: Dinar Valeev dval...@suse.com on sPAPR we need to update boot_order in MachineState in case it got changed on reset. Signed-off-by: Dinar Valeev dval...@suse.com Reviewed-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Gonglei

[Qemu-devel] [PATCH v8 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-12 Thread Greg Bellows
Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64 execution state hereby forcing EL1 to be AArch32. The new CPU

Re: [Qemu-devel] [RFC] net: 'Remove vhostforce option in addition to vhost param'

2015-02-12 Thread Michael S. Tsirkin
On Thu, Feb 12, 2015 at 11:50:05AM +0530, Pankaj Gupta wrote: vhostforce was added to enable use of vhost when guest don't have MSI-X support. Now, we have scenarios which dont use interrupts like DPDK and still use vhost. Also, performance of guests without MSI-X support is getting

Re: [Qemu-devel] [PATCH RFC v2 4/8] block: add dirty-dirty bitmaps

2015-02-12 Thread Vladimir Sementsov-Ogievskiy
On 11.02.2015 00:30, John Snow wrote: I had hoped it wouldn't come to this :) On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: A dirty-dirty bitmap is a dirty bitmap for BdrvDirtyBitmap. It tracks set/unset changes of BdrvDirtyBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH RFC v2 5/8] block: add bdrv_dirty_bitmap_enabled()

2015-02-12 Thread Vladimir Sementsov-Ogievskiy
On 11.02.2015 00:30, John Snow wrote: On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy vsement...@parallels.com --- block.c | 5 + include/block/block.h | 1 + 2 files changed, 6 insertions(+) diff --git a/block.c

Re: [Qemu-devel] [v5 05/12] arch_init: Alloc and free data struct for compression

2015-02-12 Thread Juan Quintela
Li, Liang Z liang.z...@intel.com wrote: Hi Juan, Have you reviewed the 04 patch of the patch series? I didn't see the reply email. It is ok, going to put the review-by Liang -Original Message- From: Juan Quintela [mailto:quint...@redhat.com] Sent: Wednesday, February 11,

Re: [Qemu-devel] [v5 04/12] qemu-file: Add compression functions to QEMUFile

2015-02-12 Thread Juan Quintela
Liang Li liang.z...@intel.com wrote: qemu_put_compression_data() compress the data and put it to QEMUFile. qemu_put_qemu_file() put the data in the buffer of source QEMUFile to destination QEMUFile. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Teruaki Ishizaki
(2015/02/12 16:42), Liu Yuan wrote: On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: At Thu, 12 Feb 2015 15:00:49 +0800, Liu Yuan wrote: On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: At Tue, 10 Feb 2015 18:35:58 +0800, Liu Yuan wrote: On Tue, Feb 10, 2015

Re: [Qemu-devel] [PATCH v2 0/5] qga: add three logical memory hotplug related commands

2015-02-12 Thread zhanghailiang
ping... Any comments/feedbacks are warmly welcomed. Michael? What's your opinion? ;) Thanks. On 2015/1/22 10:40, zhanghailiang wrote: This patch series add three guest commands about memory block: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. With these three

[Qemu-devel] Google Summer of Code application submitted

2015-02-12 Thread Stefan Hajnoczi
Hi, I have submitted our Google Summer of Code application for QEMU, libvirt, and KVM. Accepted organizations will be announced on March 2nd at 19:00 UTC on http://google-melange.com/. You can still add project ideas if you wish to mentor: http://qemu-project.org/Google_Summer_of_Code_2015

[Qemu-devel] [PATCH v2] vpc: Implement bdrv_co_get_block_status()

2015-02-12 Thread Kevin Wolf
This implements bdrv_co_get_block_status() for VHD images. This can significantly speed up qemu-img convert operation because only with this function implemented sparseness can be considered. (Before, converting a 1 TB empty image took several minutes for me, now it's instantaneous.)

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Liu Yuan
On Thu, Feb 12, 2015 at 05:13:55PM +0900, Hitoshi Mitake wrote: At Thu, 12 Feb 2015 15:42:17 +0800, Liu Yuan wrote: On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: At Thu, 12 Feb 2015 15:00:49 +0800, Liu Yuan wrote: On Thu, Feb 12, 2015 at 03:19:21PM +0900,

Re: [Qemu-devel] [PATCH v7 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-12 Thread Edgar E. Iglesias
On Thu, Feb 12, 2015 at 02:49:06PM +0800, Greg Bellows wrote: Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64

Re: [Qemu-devel] [PATCH] vpc: Implement bdrv_co_get_status()

2015-02-12 Thread Kevin Wolf
Am 11.02.2015 um 23:51 hat Max Reitz geschrieben: On 2015-02-11 at 11:23, Kevin Wolf wrote: This implements bdrv_co_get_status() for VHD images. This can significantly speed up qemu-img convert operation because only with this function implemented sparseness can be considered. (Before,

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Fam Zheng
On Thu, 02/12 17:33, Wen Congyang wrote: On 02/12/2015 04:44 PM, Fam Zheng wrote: On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: Hi Congyang, On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following is the image of block replication

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am

[Qemu-devel] [PATCH 3/3] hmp: Name HMP info handler functions hmp_info_SUBCOMMAND()

2015-02-12 Thread Markus Armbruster
Some are called do_info_SUBCOMMAND() (old ones, usually), some hmp_info_SUBCOMMAND(), some SUBCOMMAND_info(), sometimes SUBCOMMAND pointlessly differs in spelling. Normalize to hmp_info_SUBCOMMAND(), where SUBCOMMAND is exactly the subcommand name with '-' replaced by '_'. Exceptions: *

[Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names

2015-02-12 Thread Markus Armbruster
When I can't guess a handler's name, I have to look it up in hmp-commands.hx. Happens often enough to annoy me. Let's make them more predictable. Touches several subsystems because HMP command handlers are still spread far and wide, but the changes are trivial. Speak up if you want your

Re: [Qemu-devel] [PATCH v2 00/11] cpu: add i386 cpu hot remove support

2015-02-12 Thread Zhu Guihua
On Tue, 2015-02-10 at 20:38 +0800, Zhi Yong Wu wrote: On Fri, Feb 6, 2015 at 3:54 PM, Zhu Guihua zhugh.f...@cn.fujitsu.com wrote: On Tue, 2015-02-03 at 16:41 +0800, Zhi Yong Wu wrote: HI, Can you push the patchset to a branch on github? It will be convenient for other guys to do some

Re: [Qemu-devel] [PATCH v3 1/4] bootdevice: remove the check about boot_set_handler

2015-02-12 Thread Markus Armbruster
arei.gong...@huawei.com writes: From: Gonglei arei.gong...@huawei.com The reset logic can be done by both machine reset and boot handler. So we shouldn't return error when the boot handler callback don't be set. Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Alexander Graf

Re: [Qemu-devel] [PATCH v3 2/4] bootdevice: check boot order argument validation before vm running

2015-02-12 Thread Markus Armbruster
arei.gong...@huawei.com writes: From: Gonglei arei.gong...@huawei.com Either 'once' option or 'order' option can take effect for -boot at the same time, that is say initial startup processing can check only one. And pc.c's set_boot_dev() fails when its boot order argument is invalid. This

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread famz
On Thu, 02/12 18:11, Wen Congyang wrote: On 02/12/2015 05:44 PM, Fam Zheng wrote: On Thu, 02/12 17:33, Wen Congyang wrote: On 02/12/2015 04:44 PM, Fam Zheng wrote: On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: Hi Congyang, On Thu, 02/12 11:07, Wen

[Qemu-devel] [PATCH 2/3] hmp: Name HMP command handler functions hmp_COMMAND()

2015-02-12 Thread Markus Armbruster
Some are called do_COMMAND() (old ones, usually), some hmp_COMMAND(), and sometimes COMMAND pointlessly differs in spelling. Normalize to hmp_COMMAND(), where COMMAND is exactly the command name with '-' replaced by '_'. Exceptions: * do_device_add() and client_migrate_info() *not* renamed to

[Qemu-devel] [PATCH 1/3] hmp: Clean up declarations for long-gone info handlers

2015-02-12 Thread Markus Armbruster
Leftovers from d1f2964 qapi: Convert query-spice 791e7c8 qapi: Convert query-migrate 0fe6a7f slirp: Drop statistic code Signed-off-by: Markus Armbruster arm...@redhat.com --- include/migration/migration.h | 4 include/sysemu/sysemu.h | 3 --- include/ui/qemu-spice.h | 3 --- 3

Re: [Qemu-devel] [RFC] net: 'Remove vhostforce option in addition to vhost param'

2015-02-12 Thread Pankaj Gupta
On Thu, Feb 12, 2015 at 11:50:05AM +0530, Pankaj Gupta wrote: vhostforce was added to enable use of vhost when guest don't have MSI-X support. Now, we have scenarios which dont use interrupts like DPDK and still use vhost. Also, performance of guests without MSI-X support is

[Qemu-devel] [PATCH v8 2/4] target-arm: Add feature parsing to virt

2015-02-12 Thread Greg Bellows
Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- v3 - v4 - Fix misspelling v1 - v2 - Fix multiple property

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 11:23 schrieb Kevin Wolf: Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am

[Qemu-devel] [PATCH v8 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-12 Thread Greg Bellows
Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows greg.bell...@linaro.org --- v7 - v8 - Fix dynamic cast object v4 - v5 - Fix target check v3 - v4 - Add check that to make sure KVM64 is only being

Re: [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 11:52 hat Markus Armbruster geschrieben: When I can't guess a handler's name, I have to look it up in hmp-commands.hx. Happens often enough to annoy me. Let's make them more predictable. Touches several subsystems because HMP command handlers are still spread far and

[Qemu-devel] [PATCH v8 1/4] target-arm: Add CPU property to disable AArch64

2015-02-12 Thread Greg Bellows
Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU invocation would have AArch64 execution state

[Qemu-devel] [PATCH v8 3/4] target-arm: Add 32/64-bit register sync

2015-02-12 Thread Greg Bellows
Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- v6 - v7

[Qemu-devel] [PATCH 4/5] linux-user: Support tile architecture in syscall

2015-02-12 Thread Chen Gang S
Add tile architecture in syscall_defs.h, all related features (ioctrl, and stat) are based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- linux-user/syscall_defs.h | 34 +++--- 1 file changed, 31 insertions(+), 3

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Peter Maydell
On 12 February 2015 at 15:19, Alexander Graf ag...@suse.de wrote: On 12.02.15 16:08, Mark Burton wrote: Our question is - do we need this ‘sync’ (before the flush), or can we actually allow CPU’s to flush themselves asynchronously…. The respective target architecture specs will tell you. And

[Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Juan Quintela
20150212-225320-Mb1E4VV7 for 1 times.

[Qemu-devel] [PATCH 3/6] ram_save_page: change calling covention

2015-02-12 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 57 ++--- 1 file changed, 38 insertions(+), 19 deletions(-) diff

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Lucas Meneghel Rodrigues
the register status 22:58:14 DEBUG| Thread quit. Used to failed to get register info from guest 20150212-225320-Mb1E4VV7 for 1 times. -- Lucas -- Lucas

Re: [Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 21:45 schrieb Paolo Bonzini pbonz...@redhat.com: Has this gone to qemu-stable? it should be in 2.2.1 if there will be such a Release?! It was not CCed, I'll forward it. thanks! do you know if there is a 2.2.1 planned? Peter Paolo

[Qemu-devel] [PATCH 5/5] linux-user: Support tile architecture in linux-user

2015-02-12 Thread Chen Gang S
Add main working flow feature and loading elf64 tilegx binary feature, based on Linux kernel tilegx 64-bit implementation. After this patch, qemu can successfully load elf64 tilegx binary for linux-user, and the working flow reaches 1st instruction __start. Signed-off-by: Chen Gang

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Lluís Vilanova
Mark Burton writes: On 12 Feb 2015, at 16:38, Alexander Graf ag...@suse.de wrote: On 12.02.15 15:58, Peter Maydell wrote: On 12 February 2015 at 14:45, Alexander Graf ag...@suse.de wrote: almost nobody except x86 does global flushes All ARM TLB maintenance operations have both this

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Charles Arnold
On 2/12/2015 at 12:05 PM, Peter Lieven p...@kamp.de wrote: Am 12.02.2015 um 18:18 schrieb Charles Arnold carn...@suse.com: On 2/12/2015 at 03:23 AM, Kevin Wolf kw...@redhat.com wrote: Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am

[Qemu-devel] [PATCH 3/5] linux-user: tile: Add target features support within qemu

2015-02-12 Thread Chen Gang S
They are for target features within qemu which independent from outside. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- linux-user/tile/target_cpu.h | 35 + linux-user/tile/target_signal.h | 28 +++ linux-user/tile/target_structs.h | 48

[Qemu-devel] [PATCH 4/6] save_xbzrle_page: change calling convention

2015-02-12 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 44 +--- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chris Metcalf
On 2/11/2015 10:32 PM, Chen Gang S wrote: + */ +#define TARGET_NR_io_setup 0 +#define TARGET_NR_io_destroy1 +#define TARGET_NR_io_submit 2 [...] Isn't there a way to say use the asm-generic syscalls? What does ARM64 do, for

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Lucas Meneghel Rodrigues
status 22:58:14 DEBUG| Thread quit. Used to failed to get register info from guest 20150212-225320-Mb1E4VV7 for 1 times. -- Lucas -- Lucas -- Lucas

[Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-12 Thread Chen Gang S
It almost likes a template for adding an architecture target. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- configure | 7 ++ default-configs/tilegx-linux-user.mak | 1 + target-tile/Makefile.objs | 1 + target-tile/cpu-qom.h

[Qemu-devel] [PATCH 5/6] save_block_hdr: we can recalculate the cont parameter here

2015-02-12 Thread Juan Quintela
No need to pass it through all the callers. Once there, update last_sent_block here. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/arch_init.c b/arch_init.c

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Peter Maydell
On 12 February 2015 at 15:38, Alexander Graf ag...@suse.de wrote: On 12.02.15 15:58, Peter Maydell wrote: All ARM TLB maintenance operations have both this CPU only and all TLBs in the Inner Shareable domain [that's ARM-speak for every CPU core in the cluster] variants (the latter being the

[Qemu-devel] [PATCH 1/6] ram: make all save_page functions take a uint64_t parameter

2015-02-12 Thread Juan Quintela
It used to be an int, but then we can't pass directly the bytes_transferred parameter, that would happen later in the series. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 11 --- include/migration/migration.h | 2 +- include/migration/qemu-file.h

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Lucas Meneghel Rodrigues
is not alive. Can not query the register status 22:58:14 DEBUG| Thread quit. Used to failed to get register info from guest 20150212-225320-Mb1E4VV7 for 1 times. -- Lucas

Re: [Qemu-devel] [PATCH] memory: Fix double unref of flatview

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 20:32, Matthew Rosato wrote: Could it be that the order in which flatview_unref (and therefore memory_region_unref) vs object_unparent(mr) matters (ie, object_unparent should always happen last)? Prior to RCUification, seems like the old_view was always unreferenced prior to

[Qemu-devel] [PATCH 2/6] ram_find_and_save_block: change calling convention

2015-02-12 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git

[Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header

2015-02-12 Thread Juan Quintela
It has always been a page header, not a block header. Once there, the flag argument was only passed to make a bit or with it, just do the or on the caller. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 27 +++ 1 file changed, 19 insertions(+), 8

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-12 Thread Eduardo Habkost
On Thu, Feb 12, 2015 at 07:22:37PM +0100, Paolo Bonzini wrote: On 12/02/2015 18:50, Eduardo Habkost wrote: + +if (!bitmap_full(seen_cpus, max_cpus)) { +char *msg; +bitmap_complement(seen_cpus, seen_cpus, max_cpus); +msg = enumerate_cpus(seen_cpus, max_cpus);

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-02-12 Thread Davanum Srinivas (DIMS)
Marking as Wont-Fix. ** Changed in: nova Status: In Progress = Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Alexander Graf
On 13.02.15 01:29, Lucas Meneghel Rodrigues wrote: Copying Alex. OK, after bisecting, this is what I've got: 8118f0950fc77cce7873002a5021172dd6e040b5 is the first bad commit commit 8118f0950fc77cce7873002a5021172dd6e040b5 Author: Alexander Graf ag...@suse.de mailto:ag...@suse.de Date:

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-12 Thread Fam Zheng
On Thu, 02/12 15:29, Paolo Bonzini wrote: On 12/02/2015 06:21, Fam Zheng wrote: Before processing a request, virtio-scsi dataplane will check if the backend runs on the same context with it. If not, it has to be moved, with bdrv_set_aio_context. However this function is unsafe to

Re: [Qemu-devel] [PATCH] hw/arm/virt: bus-range/end is off by one

2015-02-12 Thread Alexander Graf
On 12.02.15 19:50, Laszlo Ersek wrote: According to PCI Bus Binding to IEEE Std 1275-1994, 3.1.2. Bus-specific Properties for Bus Nodes, the second integer in bus-range is an inclusive limit. This seems to be consistent with several *.dtsi files in the kernel tree, where examples like

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Teruaki Ishizaki
(2015/02/12 11:55), Liu Yuan wrote: On Thu, Feb 12, 2015 at 11:33:16AM +0900, Teruaki Ishizaki wrote: (2015/02/12 11:19), Liu Yuan wrote: On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki Ishizaki wrote: (2015/02/10 20:12), Liu Yuan wrote: On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Lucas Meneghel Rodrigues
is not alive. Can not query the register status 22:58:14 DEBUG| Thread quit. Used to failed to get register info from guest 20150212-225320-Mb1E4VV7 for 1 times. -- Lucas -- Lucas -- Lucas

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-12 Thread Chen, Tiejun
Ian, Just ping this, or do you think I should send this as a patch? Thanks Tiejun On 2015/2/11 10:45, Chen, Tiejun wrote: On 2015/2/9 19:05, Ian Campbell wrote: On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: What about this? I've not read the code in detail,since I'm travelling

[Qemu-devel] Fwd: [PATCH 2/5] linux-user: tile: Firstly add architecture related features

2015-02-12 Thread Chen Gang S
Excuse me, I have to foward this mail, for the original mail failed to send to qemu-devel mailing list (so try again). Thanks. Forwarded Message Subject: [PATCH 2/5] linux-user: tile: Firstly add architecture related features Date: Fri, 13 Feb 2015 05:16:52 +0800 From: Chen

Re: [Qemu-devel] [PATCH] hw/arm/virt: bus-range/end is off by one

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 01:12, Alexander Graf ag...@suse.de wrote: On 12.02.15 19:50, Laszlo Ersek wrote: According to PCI Bus Binding to IEEE Std 1275-1994, 3.1.2. Bus-specific Properties for Bus Nodes, the second integer in bus-range is an inclusive limit. This seems to be consistent with

Re: [Qemu-devel] [PATCH v3 1/4] bootdevice: remove the check about boot_set_handler

2015-02-12 Thread Gonglei
On 2015/2/12 18:19, Markus Armbruster wrote: arei.gong...@huawei.com writes: From: Gonglei arei.gong...@huawei.com The reset logic can be done by both machine reset and boot handler. So we shouldn't return error when the boot handler callback don't be set. Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chris Metcalf
On 2/11/2015 10:48 PM, Chen Gang S wrote: On 2/12/15 11:32, Chen Gang S wrote: +#define EM_TILE 191 /* Tile */ +#define EM_TILE_OLD 0x2597 /* Tile compat */ No need for EM_TILE_OLD - it never really got out into the wild. Also, 191 is EM_TILEGX in elf.h, so you really should

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Liu Yuan
On Fri, Feb 13, 2015 at 10:33:04AM +0900, Teruaki Ishizaki wrote: (2015/02/12 11:55), Liu Yuan wrote: On Thu, Feb 12, 2015 at 11:33:16AM +0900, Teruaki Ishizaki wrote: (2015/02/12 11:19), Liu Yuan wrote: On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki Ishizaki wrote: (2015/02/10 20:12), Liu

Re: [Qemu-devel] [PATCH] vnc: fix coverity warning

2015-02-12 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: +assert(vs); return vnc_socket_local_addr(%s:%s, vs-lsock); } If you want, I can just silence the warning in Coverity. I think in the source code is better, human readers might wonder too. And in case the calling code ever

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am 10.02.2015 um 14:54 schrieb Kevin Wolf: Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: On

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Wen Congyang
On 02/12/2015 05:44 PM, Fam Zheng wrote: On Thu, 02/12 17:33, Wen Congyang wrote: On 02/12/2015 04:44 PM, Fam Zheng wrote: On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: Hi Congyang, On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Hitoshi Mitake
At Thu, 12 Feb 2015 15:42:17 +0800, Liu Yuan wrote: On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: At Thu, 12 Feb 2015 15:00:49 +0800, Liu Yuan wrote: On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: At Tue, 10 Feb 2015 18:35:58 +0800, Liu Yuan

Re: [Qemu-devel] [PATCH 3/8] leon3: Replace unchecked qdev_init() by qdev_init_nofail()

2015-02-12 Thread Fabien Chouteau
On 02/04/2015 06:33 PM, Markus Armbruster wrote: grlib_irqmp_create(), grlib_gptimer_create() and grlib_apbuart_create() are helpers to create and realize GRLIB devices. Their only caller leon3_generic_hw_init() doesn't check for failure. Only the first can actually fail, and only when the

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Wen Congyang
On 02/12/2015 04:44 PM, Fam Zheng wrote: On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: Hi Congyang, On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following is the image of block replication workflow: + ++--+

Re: [Qemu-devel] [PATCH] vpc: Fix size in fixed image creation

2015-02-12 Thread Kevin Wolf
Am 11.02.2015 um 23:32 hat Max Reitz geschrieben: On 2015-02-11 at 11:22, Kevin Wolf wrote: If total_sectors is rounded to match the geometry, total_size needs to be changed as well. Otherwise we end up with an image whose geometry describes a disk larger than the image file,

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-12 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 22/01/2015 09:53, Pavel Dovgalyuk wrote: +if (replay_mode != REPLAY_MODE_PLAY) { +evt = qemu_input_event_new_key(key, down); +if (QTAILQ_EMPTY(kbd_queue)) { +

Re: [Qemu-devel] [PULL 2/4] coverity: Model GLib string allocation partially

2015-02-12 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 05/02/2015 17:24, Markus Armbruster wrote: + +char *g_strdup(const char *s) +{ +char *dup; +size_t i; + +if (!s) { +return NULL; +} + +__coverity_string_null_sink__(s); +__coverity_string_size_sink__(s);

Re: [Qemu-devel] [PATCH 1/3] rcu: do not let RCU callbacks pile up indefinitely

2015-02-12 Thread Fam Zheng
On Wed, 02/11 18:14, Paolo Bonzini wrote: Always process them within half a second. Even though waiting a little is useful, it is not okay to delay e.g. qemu_opts_del forever. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- util/rcu.c | 14 -- 1 file changed, 8

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Fam Zheng
On Thu, 02/12 17:36, Hongyang Yang wrote: Hi Fam, 在 02/12/2015 04:44 PM, Fam Zheng 写道: On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: Hi Congyang, On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following is the image of block

Re: [Qemu-devel] [PATCH v7 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-12 Thread Greg Bellows
On Thu, Feb 12, 2015 at 5:10 PM, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Thu, Feb 12, 2015 at 02:49:06PM +0800, Greg Bellows wrote: Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am 10.02.2015 um 14:54 schrieb Kevin Wolf: Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote: Am 10.02.2015 um 12:41 hat Peter Lieven

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Hongyang Yang
Hi Fam, 在 02/12/2015 04:44 PM, Fam Zheng 写道: On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: Hi Congyang, On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following is the image of block replication workflow: + ++--+

Re: [Qemu-devel] [PATCH 1/1] block/raw-posix: fix compilation warning on OSX

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 06:35 hat Denis V. Lunev geschrieben: block/raw-posix.c:947:19: warning: unused variable 's' [-Wunused-variable] BDRVRawState *s = aiocb-bs-opaque; This variable is used only when on of the following macros are defined CONFIG_XFS, CONFIG_FALLOCATE,

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am 10.02.2015 um 14:54 schrieb Kevin Wolf: Am

Re: [Qemu-devel] [PULL 0/4] coverity: Improve and extend model

2015-02-12 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: \ It seems like Coverity Scan doesn't like the new model. Possibly the fault of the third patch. Works for me with a local 7.0.3 installation. Which I just realized is outdated. I'll recheck with 7.6.0. Will check

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-02-12 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 09/02/2015 13:15, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:pbonz...@redhat.com] break; case QEMU_OPTION_audio_help: AUD_help (); @@ -3244,6 +3254,7 @@ int main(int argc, char

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am 10.02.2015 um 14:54 schrieb Kevin Wolf: Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin

Re: [Qemu-devel] [PATCH v3 2/4] bootdevice: check boot order argument validation before vm running

2015-02-12 Thread Gonglei
On 2015/2/12 18:19, Markus Armbruster wrote: arei.gong...@huawei.com writes: From: Gonglei arei.gong...@huawei.com Either 'once' option or 'order' option can take effect for -boot at the same time, that is say initial startup processing can check only one. And pc.c's set_boot_dev() fails

  1   2   3   >