Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 19/23] spapr: CPU hot unplug support

2015-04-07 Thread Alexey Kardashevskiy
On 03/24/2015 12:36 AM, Bharata B Rao wrote: Support hot removal of CPU for sPAPR guests by sending the hot unplug notification to the guest via EPOW interrupt. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- hw/ppc/spapr.c| 78

Re: [Qemu-devel] qemu-img behavior for locating backing files

2015-04-07 Thread Kevin Wolf
Am 07.04.2015 um 02:31 hat John Snow geschrieben: On 04/02/2015 05:38 AM, Kevin Wolf wrote: Am 01.04.2015 um 18:16 hat John Snow geschrieben: Kevin, what's the correct behavior for qemu-img and relative paths when creating a new qcow2 file? Example: (in e.g. /home/qemu/build/ or

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: Am 06.04.2015 um 21:02 schrieb Peter Lieven: Am 06.04.2015 um 20:50 schrieb John Snow: On 04/06/2015 02:47 PM, Peter Lieven wrote: Hi all, is there a known issue in Qemu 2.2.1 where IDE stalls sometimes after a migration with Qemu 2.2.1? The

Re: [Qemu-devel] [virtio] qemu vs vhost virtqueue consumer

2015-04-07 Thread Greg Kurz
On Tue, 7 Apr 2015 11:10:07 +0300 Catalin Vasile catalinvasil...@gmail.com wrote: I am using the virtio-net vhost-net model to make another virtio/vhost solution. I can't seem to find how does one make a virtqueue to only be consumed by vhost when adding notifiers to vhost.

Re: [Qemu-devel] [PATCH v3 6/6] virtio-input: evdev passthrough

2015-04-07 Thread Gerd Hoffmann
On Fr, 2015-04-03 at 00:24 +0200, Marc-André Lureau wrote: Hi On Thu, Mar 26, 2015 at 12:26 PM, Gerd Hoffmann kra...@redhat.com wrote: This allows to assign host input devices to the guest: qemu -device virto-input-host-pci,evdev=/dev/input/eventnr

[Qemu-devel] [virtio] qemu vs vhost virtqueue consumer

2015-04-07 Thread Catalin Vasile
I am using the virtio-net vhost-net model to make another virtio/vhost solution. I can't seem to find how does one make a virtqueue to only be consumed by vhost when adding notifiers to vhost. virtio_add_queue() seems to always ask for a valid handle for qemu, and I don't see any disable function

Re: [Qemu-devel] [virtio] qemu vs vhost virtqueue consumer

2015-04-07 Thread Catalin Vasile
Awesome. Thanks On Tue, Apr 7, 2015 at 11:51 AM, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Tue, 7 Apr 2015 11:10:07 +0300 Catalin Vasile catalinvasil...@gmail.com wrote: I am using the virtio-net vhost-net model to make another virtio/vhost solution. I can't seem to find how does one

Re: [Qemu-devel] [PATCH 2/3] tpm: Probe for connected TPM 1.2 or TPM 2

2015-04-07 Thread Xu, Quan
-Original Message- From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] Sent: Wednesday, April 01, 2015 3:40 AM To: qemu-devel@nongnu.org; m...@redhat.com Cc: Xu, Quan; Stefan Berger; Stefan Berger Subject: [PATCH 2/3] tpm: Probe for connected TPM 1.2 or TPM 2 In the TPM

Re: [Qemu-devel] [RFC PATCH v2 00/23] CPU and Memory hotplug for PowerPC sPAPR guests

2015-04-07 Thread Igor Mammedov
On Mon, 6 Apr 2015 15:49:24 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: On Mon, Mar 23, 2015 at 07:05:41PM +0530, Bharata B Rao wrote: Hi, This is the version 2 of the patchset that provides CPU and memory hotplug support for PowerPC sPAPR guests. [snip] TODOs -

Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-04-07 Thread Peter Maydell
On 7 April 2015 at 03:43, Shannon Zhao zhaoshengl...@huawei.com wrote: The dts node is: ranges = 0x100 0x0 0x0 0x0 0x3eff 0x0 0x1 0x200 0x0 0x1000 0x0 0x1000 0x0 0x2eff; reg = 0x0 0x3f00 0x0 0x100;

Re: [Qemu-devel] block-commit dropping privs

2015-04-07 Thread Kevin Wolf
Am 06.04.2015 um 17:37 hat Michael Tokarev geschrieben: 02.04.2015 16:19, Kevin Wolf wrote: Am 02.04.2015 um 14:04 hat Michael Tokarev geschrieben: 02.04.2015 14:24, Kevin Wolf wrote: [] But overall, I think qemu-system should not modify backing file name in this case. So you would

Re: [Qemu-devel] block-commit dropping privs

2015-04-07 Thread Kevin Wolf
Am 03.04.2015 um 05:59 hat Jeff Cody geschrieben: On Thu, Apr 02, 2015 at 01:24:02PM +0200, Kevin Wolf wrote: Am 02.04.2015 um 12:58 hat Michael Tokarev geschrieben: When performing commit, does qemu mark the areas in the overlay file as free after writing contents to the backing file,

Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-04-07 Thread Michael S. Tsirkin
On Tue, Apr 07, 2015 at 10:19:22AM +0100, Peter Maydell wrote: On 7 April 2015 at 03:43, Shannon Zhao zhaoshengl...@huawei.com wrote: The dts node is: ranges = 0x100 0x0 0x0 0x0 0x3eff 0x0 0x1 0x200 0x0 0x1000 0x0 0x1000 0x0

Re: [Qemu-devel] [PATCH 3/3] TPM2 ACPI table support

2015-04-07 Thread Xu, Quan
-Original Message- From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] Sent: Wednesday, April 01, 2015 3:40 AM To: qemu-devel@nongnu.org; m...@redhat.com Cc: Xu, Quan; Stefan Berger Subject: [PATCH 3/3] TPM2 ACPI table support Add a TPM2 ACPI table if a TPM2 is used

Re: [Qemu-devel] [Snapshot Bug?]Qcow2 meta data corruption

2015-04-07 Thread Kevin Wolf
Am 03.04.2015 um 12:04 hat leijian geschrieben: Hi all, There was a problem about qcow2 image file happened in my serval vms and I could not figure it out, so have to ask for some help. [...] I think the problem is relate to the snapshot create, delete. But I cant reproduce it . Can

Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-04-07 Thread Peter Maydell
On 7 April 2015 at 10:32, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 07, 2015 at 10:19:22AM +0100, Peter Maydell wrote: On 7 April 2015 at 03:43, Shannon Zhao zhaoshengl...@huawei.com wrote: The dts node is: ranges = 0x100 0x0 0x0 0x0 0x3eff 0x0 0x1

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Paolo Bonzini
On 07/04/2015 12:15, Andreas Färber wrote: diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b2d1c95..03b33cf 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2714,9 +2714,7 @@ static void x86_cpu_reset(CPUState *s) #if !defined(CONFIG_USER_ONLY) /* We

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Andreas Färber
Am 07.04.2015 um 12:34 schrieb Paolo Bonzini: On 07/04/2015 12:15, Andreas Färber wrote: diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b2d1c95..03b33cf 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2714,9 +2714,7 @@ static void x86_cpu_reset(CPUState *s) #if

[Qemu-devel] [PATCH 3/3] dataplane/virtio-scsi: new API to enable host notifiers

2015-04-07 Thread Michael S. Tsirkin
Switch to new API. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio.h | 1 - hw/scsi/virtio-scsi-dataplane.c | 14 -- hw/virtio/virtio.c | 8 +++- 3 files changed, 11 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH 2/3] dataplane/virtio-blk.c: new API to enable notifiers

2015-04-07 Thread Michael S. Tsirkin
Switch to new API, no functional changes. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/block/dataplane/virtio-blk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index cd41478..c9ac70e

Re: [Qemu-devel] [PATCH 1/3] virtio: interface to enable/disable host notifiers

2015-04-07 Thread Cornelia Huck
On Tue, 7 Apr 2015 12:45:56 +0200 Michael S. Tsirkin m...@redhat.com wrote: generalize and move these from vhost to virtio. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio.h | 3 +++ hw/virtio/vhost.c | 45 ++--

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Andreas Färber
+Eduardo as target-i386 maintainer Am 02.04.2015 um 14:34 schrieb Paolo Bonzini: On 02/04/2015 01:58, Nadav Amit wrote: Since the BSP bit is writable on real hardware, during reset all the CPUs which were not chosen to be the BSP should have their BSP bit cleared. This fix is required

Re: [Qemu-devel] [PATCH] PING - add 1394 support

2015-04-07 Thread Andreas Färber
Hi, Am 07.04.2015 um 10:18 schrieb Itamar Tal: Hi, Haven't got any response to this patch and couldn't find relevant maintainer as well. Can anyone direct me to the right guy? Thanks, Itamar Tal, Guardicore On Mon, Mar 23, 2015 at 6:07 PM, Itamar Tal ita...@guardicore.com

[Qemu-devel] virtio/vhost find queues, which virtqueue is which

2015-04-07 Thread Catalin Vasile
How can I tell which virtqueue is which? I'm trying to make 2 virtqueues: 1) control vq between qemu and guest 2) data/job vq between vhost and guest I went through find_vqs() inside the guest (virtio-net), but I can't tell how it associates which one is the rx queue, which one is tx, and which

[Qemu-devel] [PATCH 1/3] virtio: interface to enable/disable host notifiers

2015-04-07 Thread Michael S. Tsirkin
generalize and move these from vhost to virtio. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio.h | 3 +++ hw/virtio/vhost.c | 45 ++-- hw/virtio/virtio.c | 51 ++ 3

[Qemu-devel] [PATCH 0/3] virtio: host notifier API cleanup

2015-04-07 Thread Michael S. Tsirkin
This refactors the code for enabling/disabling host notifiers. Not useful by itself, but seems to be needed for other projects. So I'm not merging this yet, will be included with other patches. Posting now for early review. Michael S. Tsirkin (3): virtio: interface to enable/disable host

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Paolo Bonzini
On 07/04/2015 12:44, Andreas Färber wrote: It can change at runtime, though, if you're using the KVM in-kernel LAPIC. Got a pointer? A quick git-grep doesn't show anything in hw/ or kvm-all.c or target-i386/ assigning cpu_index, so it'll always have the initial value. Not cpu_index,

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Andreas Färber
Am 07.04.2015 um 12:54 schrieb Paolo Bonzini: On 07/04/2015 12:44, Andreas Färber wrote: It can change at runtime, though, if you're using the KVM in-kernel LAPIC. Got a pointer? A quick git-grep doesn't show anything in hw/ or kvm-all.c or target-i386/ assigning cpu_index, so it'll always

Re: [Qemu-devel] [PATCH 2/3] dataplane/virtio-blk.c: new API to enable notifiers

2015-04-07 Thread Cornelia Huck
On Tue, 7 Apr 2015 12:45:58 +0200 Michael S. Tsirkin m...@redhat.com wrote: Switch to new API, no functional changes. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/block/dataplane/virtio-blk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-04-07 Thread Shannon Zhao
On 2015/4/7 17:19, Peter Maydell wrote: On 7 April 2015 at 03:43, Shannon Zhao zhaoshengl...@huawei.com wrote: The dts node is: ranges = 0x100 0x0 0x0 0x0 0x3eff 0x0 0x1 0x200 0x0 0x1000 0x0 0x1000 0x0 0x2eff;

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Andreas Färber
Am 07.04.2015 um 13:09 schrieb Andreas Färber: Am 07.04.2015 um 12:54 schrieb Paolo Bonzini: On 07/04/2015 12:44, Andreas Färber wrote: It can change at runtime, though, if you're using the KVM in-kernel LAPIC. Got a pointer? A quick git-grep doesn't show anything in hw/ or kvm-all.c or

Re: [Qemu-devel] [PATCH 3/3] dataplane/virtio-scsi: new API to enable host notifiers

2015-04-07 Thread Cornelia Huck
On Tue, 7 Apr 2015 12:46:01 +0200 Michael S. Tsirkin m...@redhat.com wrote: Switch to new API. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio.h | 1 - hw/scsi/virtio-scsi-dataplane.c | 14 -- hw/virtio/virtio.c | 8 +++-

Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-04-07 Thread Peter Maydell
On 7 April 2015 at 03:43, Shannon Zhao zhaoshengl...@huawei.com wrote: The ACPI table entry: Method (_CBA, 0, NotSerialized) // _CBA: Configuration Base Address { Return (0x3F00) } Method (_CRS, 0, NotSerialized) //

Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-04-07 Thread Shannon Zhao
On 2015/4/7 20:07, Peter Maydell wrote: On 7 April 2015 at 03:43, Shannon Zhao zhaoshengl...@huawei.com wrote: The ACPI table entry: Method (_CBA, 0, NotSerialized) // _CBA: Configuration Base Address { Return (0x3F00) }

Re: [Qemu-devel] QEMU IPMI support

2015-04-07 Thread Corey Minyard
On 04/04/2015 09:02 PM, Corey Minyard wrote: Ok, done. It's at https://github.com/cminyard/qemu on github. There are two branches at the moment, stable-2.2-ipmi is based on the 2.2 release and will not rebase. master-ipmi-rebase will rebase on master as it moves. I haven't done extensive

[Qemu-devel] cpu modelling and hotplug (was: [PATCH RFC 0/4] target-i386: PC socket/core/thread modeling, part 1)

2015-04-07 Thread Christian Borntraeger
We had a call and I was asked to write a summary about our conclusion. The more I wrote, there more I became uncertain if we really came to a conclusion and became more certain that we want to define the QMP/HMP/CLI interfaces first (or quite early in the process) As discussed I will provide an

Re: [Qemu-devel] QEMU IPMI support

2015-04-07 Thread Corey Minyard
On 04/07/2015 07:24 AM, Longever, Joseph wrote: Hi Corey, Thanks so much for the support. I pulled down the 2.2-ipmi stable snapshot and everything compiled with no issues. Could you help confirm my configuration? Can you send your complete configuration file and startup command file?

Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP

2015-04-07 Thread Alberto Garcia
On Thu, Apr 02, 2015 at 01:31:46PM -0600, Eric Blake wrote: So instead, this patch creates a new QObject subtype: QNull. The code looks good, but Markus's approach of using a single instance seems probably a bit better for this case. --- /dev/null +++ b/include/qapi/qmp/qnull.h @@ -0,0

[Qemu-devel] [PATCH for-2.3] qcow2: Fix header update with overridden backing file

2015-04-07 Thread Kevin Wolf
In recent qemu versions, it is possible to override the backing file name and format that is stored in the image file with values given at runtime. In such cases, the temporary override could end up in the image header if the qcow2 header was updated, while obviously correct behaviour would be to

Re: [Qemu-devel] [Qemu-block] [PATCH v4 15/20] block: Resize bitmaps on bdrv_truncate

2015-04-07 Thread Stefan Hajnoczi
On Thu, Apr 02, 2015 at 11:57:59AM -0400, John Snow wrote: On 04/02/2015 09:37 AM, Stefan Hajnoczi wrote: On Fri, Mar 20, 2015 at 03:16:58PM -0400, John Snow wrote: +void hbitmap_truncate(HBitmap *hb, uint64_t size) +{ +bool shrink; +unsigned i; +uint64_t num_elements =

Re: [Qemu-devel] [PATCH v4 19/20] iotests: add simple incremental backup case

2015-04-07 Thread Stefan Hajnoczi
On Mon, Apr 06, 2015 at 05:49:10PM -0400, John Snow wrote: Is it really that unsafe? I could add in an explicit pause/resume barrier around the check if that would help inspire some confidence in the test. There are many cases where it happens to work, but we always tell users never to do this

Re: [Qemu-devel] [PATCH for-2.3] qcow2: Fix header update with overridden backing file

2015-04-07 Thread Kevin Wolf
Am 07.04.2015 um 14:51 hat Kevin Wolf geschrieben: In recent qemu versions, it is possible to override the backing file name and format that is stored in the image file with values given at runtime. In such cases, the temporary override could end up in the image header if the qcow2 header was

[Qemu-devel] [PATCH for-2.3 v2] qcow2: Fix header update with overridden backing file

2015-04-07 Thread Kevin Wolf
In recent qemu versions, it is possible to override the backing file name and format that is stored in the image file with values given at runtime. In such cases, the temporary override could end up in the image header if the qcow2 header was updated, while obviously correct behaviour would be to

Re: [Qemu-devel] QEMU IPMI support

2015-04-07 Thread Longever, Joseph
I'm sure this all works and it's just me... Attached is the config, I also pasted the text below: The startcmd starts a QEMU instance which then PXE boots Linux kernel 2.6.34 with IPMI drivers enabled in the kernel: startcmd qemu-system-x86_64 -vnc :1 --enable-kvm -chardev

Re: [Qemu-devel] QEMU IPMI support

2015-04-07 Thread Longever, Joseph
Hi Corey, Thanks so much for the support. I pulled down the 2.2-ipmi stable snapshot and everything compiled with no issues. Could you help confirm my configuration? I ran lanserv with the serial parameter to create the socket that will communicate with the QEMU IPMI device over port 9002:

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Denis V. Lunev
On 07/04/15 16:29, Paolo Bonzini wrote: On 07/04/2015 15:26, Denis V. Lunev wrote: On 07/04/15 16:18, Paolo Bonzini wrote: On 07/04/2015 13:57, Andreas Färber wrote: If this is some issue with sync'ing state back and forth before QEMU and KVM then the real issue has not been explained.

Re: [Qemu-devel] [PATCH] thread-pool: clean up thread_pool_completion_bh()

2015-04-07 Thread Stefan Hajnoczi
On Thu, Apr 02, 2015 at 05:39:22PM +0100, Stefan Hajnoczi wrote: This patch simplifies thread_pool_completion_bh(). The function first checks elem-state: if (elem-state != THREAD_DONE) { continue; } It then goes on to check elem-state == THREAD_DONE although we already know

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Paolo Bonzini
On 07/04/2015 13:57, Andreas Färber wrote: If this is some issue with sync'ing state back and forth before QEMU and KVM then the real issue has not been explained. Hm, hw/intc/apic_common.c:apic_reset_common() has: bsp = cpu_is_bsp(s-cpu); s-apicbase = APIC_DEFAULT_ADDRESS |

Re: [Qemu-devel] [PATCH 1/1] apic_common: improve readability of apic_reset_common

2015-04-07 Thread Paolo Bonzini
On 07/04/2015 15:53, Denis V. Lunev wrote: Replace call of cpu_is_bsp(s-cpu) which really returns !!(s-apicbase MSR_IA32_APICBASE_BSP) with directly collected value. Due to this the tracepoint trace_cpu_get_apic_base((uint64_t)s-apicbase); will not be hit anymore in

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Andreas Färber
Am 07.04.2015 um 15:14 schrieb Igor Mammedov: On Tue, 07 Apr 2015 13:57:34 +0200 Andreas Färber afaer...@suse.de wrote: Am 07.04.2015 um 13:09 schrieb Andreas Färber: Am 07.04.2015 um 12:54 schrieb Paolo Bonzini: On 07/04/2015 12:44, Andreas Färber wrote: It can change at runtime, though,

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Andreas Färber
Am 07.04.2015 um 15:44 schrieb Denis V. Lunev: On 07/04/15 16:29, Paolo Bonzini wrote: On 07/04/2015 15:26, Denis V. Lunev wrote: On 07/04/15 16:18, Paolo Bonzini wrote: On 07/04/2015 13:57, Andreas Färber wrote: If this is some issue with sync'ing state back and forth before QEMU and

Re: [Qemu-devel] QEMU IPMI support

2015-04-07 Thread Longever, Joseph
Hi Corey, I got it working now. The port wasn't listening on the correct address when set to localhost but when I set the address to 0.0.0.0 it started listening on 127.0.0.1. Set serial parameters to: serial 15 0.0.0.0 9002 codec VM ipmb 0x20 [ 10.025336] ipmi message handler version

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Paolo Bonzini
On 07/04/2015 15:24, Andreas Färber wrote: /* We hard-wire the BSP to the first CPU. */ if (s-cpu_index == 0) { apic_designate_bsp(cpu-apic_state); } I know, that's what this patch is changing, and I am saying that by the same logic the CPU has no business fiddling

Re: [Qemu-devel] [PATCH v2 2/4] block: Pause block jobs in bdrv_drain_all

2015-04-07 Thread Alberto Garcia
On Fri, Apr 03, 2015 at 10:05:19PM +0800, Fam Zheng wrote: +QTAILQ_FOREACH(bs, bdrv_states, device_list) { +AioContext *aio_context = bdrv_get_aio_context(bs); + +aio_context_acquire(aio_context); +if (bs-job) { +block_job_pause(bs-job); +}

Re: [Qemu-devel] [PULL 0/5 for-2.3] Trivial patches for 2015-04-04

2015-04-07 Thread Peter Maydell
On 4 April 2015 at 08:10, Michael Tokarev m...@tls.msk.ru wrote: Here's a very small trivial-patches pull request for the upcoming 2.3 release. There's nothing urgent here, so things can wait past 2.3, but these things are also safe. Only one questionable code change is the removal of

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Peter Lieven
Hi David, Am 07.04.2015 um 10:43 schrieb Dr. David Alan Gilbert: Any particular workload or reproducer? Workload is almost zero. I try to figure out if there is a way to trigger it. Maybe playing a role: Machine type is -M pc1.2 and we set -kvmclock as CPU flag since kvmclock seemed to be

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Denis V. Lunev
On 07/04/15 16:18, Paolo Bonzini wrote: On 07/04/2015 13:57, Andreas Färber wrote: If this is some issue with sync'ing state back and forth before QEMU and KVM then the real issue has not been explained. Hm, hw/intc/apic_common.c:apic_reset_common() has: bsp = cpu_is_bsp(s-cpu);

Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-04-07 Thread Igor Mammedov
On Tue, 7 Apr 2015 13:07:31 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 7 April 2015 at 03:43, Shannon Zhao zhaoshengl...@huawei.com wrote: The ACPI table entry: Method (_CBA, 0, NotSerialized) // _CBA: Configuration Base Address { Return

Re: [Qemu-devel] [PATCH v2 3/4] qemu-iotests: Test that stop doesn't drain block jobs

2015-04-07 Thread Alberto Garcia
On Fri, Apr 03, 2015 at 10:05:20PM +0800, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/129 | 86 ++ tests/qemu-iotests/129.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 92

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Igor Mammedov
On Tue, 07 Apr 2015 13:57:34 +0200 Andreas Färber afaer...@suse.de wrote: Am 07.04.2015 um 13:09 schrieb Andreas Färber: Am 07.04.2015 um 12:54 schrieb Paolo Bonzini: On 07/04/2015 12:44, Andreas Färber wrote: It can change at runtime, though, if you're using the KVM in-kernel LAPIC.

[Qemu-devel] Getting VM state from outside QEMU?

2015-04-07 Thread Erik Rull
Hi all, I need a pretty simple way to get the current state of the VM running in QEMU - I only need the VM state (e.g. running, paused,...). Since my environment does not have any perl, python or other high level scripting capabilities, a simple way e.g. via a shell script would be nice. QEMU is

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Paolo Bonzini
On 07/04/2015 15:26, Denis V. Lunev wrote: On 07/04/15 16:18, Paolo Bonzini wrote: On 07/04/2015 13:57, Andreas Färber wrote: If this is some issue with sync'ing state back and forth before QEMU and KVM then the real issue has not been explained. Hm,

Re: [Qemu-devel] [PATCH v2 for-2.3] virtio-blk: correctly dirty guest memory

2015-04-07 Thread Stefan Hajnoczi
On Thu, Apr 02, 2015 at 07:50:44PM +0200, Paolo Bonzini wrote: After qemu_iovec_destroy, the QEMUIOVector's size is zeroed and the zero size ultimately is used to compute virtqueue_push's len argument. Therefore, reads from virtio-blk devices did not migrate their results correctly. (Writes

Re: [Qemu-devel] Getting VM state from outside QEMU?

2015-04-07 Thread Paulo Ricardo Paz Vital
On Tue, 2015-04-07 at 15:31 +0200, Erik Rull wrote: Hi all, I need a pretty simple way to get the current state of the VM running in QEMU - I only need the VM state (e.g. running, paused,...). Since my environment does not have any perl, python or other high level scripting capabilities, a

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Andreas Färber
Am 07.04.2015 um 15:29 schrieb Paolo Bonzini: On 07/04/2015 15:24, Andreas Färber wrote: /* We hard-wire the BSP to the first CPU. */ if (s-cpu_index == 0) { apic_designate_bsp(cpu-apic_state); } I know, that's what this patch is changing, and I am saying that by the

Re: [Qemu-devel] [PATCH v2 4/4] blockjob: Update function name in comments

2015-04-07 Thread Alberto Garcia
On Fri, Apr 03, 2015 at 10:05:21PM +0800, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- block/backup.c | 2 +- block/mirror.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Alberto Garcia be...@igalia.com Berto

Re: [Qemu-devel] [PATCH v2] tcg: optimise memory layout of TCGTemp

2015-04-07 Thread Alex Bennée
Emilio G. Cota c...@braap.org writes: This brings down the size of the struct from 56 to 32 bytes on 64-bit, and to 20 bytes on 32-bit. This leads to memory savings: Before: $ find . -name 'tcg.o' | xargs size textdata bss dec hex filename 41131 29800 88

Re: [Qemu-devel] cpu modelling and hotplug (was: [PATCH RFC 0/4] target-i386: PC socket/core/thread modeling, part 1)

2015-04-07 Thread Igor Mammedov
On Tue, 07 Apr 2015 14:43:43 +0200 Christian Borntraeger borntrae...@de.ibm.com wrote: We had a call and I was asked to write a summary about our conclusion. The more I wrote, there more I became uncertain if we really came to a conclusion and became more certain that we want to define the

[Qemu-devel] [PATCH 1/1] apic_common: improve readability of apic_reset_common

2015-04-07 Thread Denis V. Lunev
Replace call of cpu_is_bsp(s-cpu) which really returns !!(s-apicbase MSR_IA32_APICBASE_BSP) with directly collected value. Due to this the tracepoint trace_cpu_get_apic_base((uint64_t)s-apicbase); will not be hit anymore in apic_reset_common. Signed-off-by: Denis V. Lunev d...@openvz.org

Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-07 Thread Paolo Bonzini
On 07/04/2015 15:40, Andreas Färber wrote: Am 07.04.2015 um 15:29 schrieb Paolo Bonzini: On 07/04/2015 15:24, Andreas Färber wrote: /* We hard-wire the BSP to the first CPU. */ if (s-cpu_index == 0) { apic_designate_bsp(cpu-apic_state); } I know, that's what this patch

Re: [Qemu-devel] [PATCH for-2.3 v2] qcow2: Fix header update with overridden backing file

2015-04-07 Thread Eric Blake
On 04/07/2015 07:03 AM, Kevin Wolf wrote: In recent qemu versions, it is possible to override the backing file name and format that is stored in the image file with values given at runtime. In such cases, the temporary override could end up in the image header if the qcow2 header was updated,

Re: [Qemu-devel] qemu-img behavior for locating backing files

2015-04-07 Thread John Snow
On 04/07/2015 04:44 AM, Kevin Wolf wrote: Am 07.04.2015 um 02:31 hat John Snow geschrieben: On 04/02/2015 05:38 AM, Kevin Wolf wrote: Am 01.04.2015 um 18:16 hat John Snow geschrieben: Kevin, what's the correct behavior for qemu-img and relative paths when creating a new qcow2 file?

Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP

2015-04-07 Thread Eric Blake
On 04/07/2015 06:46 AM, Alberto Garcia wrote: On Thu, Apr 02, 2015 at 01:31:46PM -0600, Eric Blake wrote: So instead, this patch creates a new QObject subtype: QNull. The code looks good, but Markus's approach of using a single instance seems probably a bit better for this case. It's what

[Qemu-devel] [PATCH] aio: strengthen memory barriers for bottom half scheduling

2015-04-07 Thread Paolo Bonzini
There are two problems with memory barriers in async.c. The fix is to use atomic_xchg in order to achieve sequential consistency between the scheduling of a bottom half and the corresponding execution. First, if bh-scheduled is already 1 in qemu_bh_schedule, QEMU does not execute a memory

Re: [Qemu-devel] [Qemu-block] [PATCH v4 15/20] block: Resize bitmaps on bdrv_truncate

2015-04-07 Thread John Snow
On 04/07/2015 08:57 AM, Stefan Hajnoczi wrote: On Thu, Apr 02, 2015 at 11:57:59AM -0400, John Snow wrote: On 04/02/2015 09:37 AM, Stefan Hajnoczi wrote: On Fri, Mar 20, 2015 at 03:16:58PM -0400, John Snow wrote: +void hbitmap_truncate(HBitmap *hb, uint64_t size) +{ +bool shrink; +

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Paolo Bonzini
On 07/04/2015 17:11, Peter Lieven wrote: I'm not sure at what kernel version the switch is, but newer kernels use some code shared with the newer SATA world (libata?) where as older kernels had separate IDE code, so the behaviour of the two can be quite different. Thats a good point.

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015 um 10:43 schrieb Dr. David Alan Gilbert: Any particular workload or reproducer? Workload is almost zero. I try to figure out if there is a way to trigger it. Maybe playing a role: Machine type is -M pc1.2 and we set

Re: [Qemu-devel] [Snapshot Bug?]Qcow2 meta data corruption

2015-04-07 Thread Eric Blake
On 04/07/2015 03:33 AM, Kevin Wolf wrote: More specifically, did you take care to never access your image from more than one process (except if both are read-only)? It happens occasionally that people use 'qemu-img snapshot' while the VM is running. This is wrong and can corrupt the image.

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-07 Thread Alexander Graf
On 04/01/2015 10:15 AM, Jason Wang wrote: This patch increases the maximum number of virtqueues for pci from 64 to 513. This will allow booting a virtio-net-pci device with 256 queue pairs. To keep migration compatibility, 64 was kept for legacy machine types. This is because qemu in fact

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Peter Lieven
Am 07.04.2015 um 17:14 schrieb Paolo Bonzini: On 07/04/2015 17:11, Peter Lieven wrote: I'm not sure at what kernel version the switch is, but newer kernels use some code shared with the newer SATA world (libata?) where as older kernels had separate IDE code, so the behaviour of the two can

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread John Snow
On 04/07/2015 02:44 PM, Peter Lieven wrote: Am 07.04.2015 um 17:29 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015 um 10:43 schrieb Dr. David Alan Gilbert: Any particular workload or reproducer? Workload is almost zero. I try to figure out if

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Peter Lieven
Am 07.04.2015 um 21:01 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 07.04.2015 um 17:29 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015 um 10:43 schrieb Dr. David Alan Gilbert: Any particular workload or reproducer?

Re: [Qemu-devel] Getting VM state from outside QEMU?

2015-04-07 Thread John Snow
On 04/07/2015 09:31 AM, Erik Rull wrote: Hi all, I need a pretty simple way to get the current state of the VM running in QEMU - I only need the VM state (e.g. running, paused,...). Since my environment does not have any perl, python or other high level scripting capabilities, a simple way

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-07 Thread Alexander Graf
On 04/07/2015 08:06 PM, Luigi Rizzo wrote: On Tue, Apr 7, 2015 at 6:54 PM, Alexander Graf ag...@suse.de mailto:ag...@suse.de wrote: On 04/01/2015 10:15 AM, Jason Wang wrote: This patch increases the maximum number of virtqueues for pci from 64 to 513. This will

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Peter Lieven
Am 07.04.2015 um 20:56 schrieb John Snow: On 04/07/2015 02:44 PM, Peter Lieven wrote: Am 07.04.2015 um 17:29 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015 um 10:43 schrieb Dr. David Alan Gilbert: Any particular workload or reproducer?

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: Am 07.04.2015 um 17:29 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015 um 10:43 schrieb Dr. David Alan Gilbert: Any particular workload or reproducer? Workload is almost zero. I try to figure out if

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-07 Thread Luigi Rizzo
On Tue, Apr 7, 2015 at 6:54 PM, Alexander Graf ag...@suse.de wrote: On 04/01/2015 10:15 AM, Jason Wang wrote: This patch increases the maximum number of virtqueues for pci from 64 to 513. This will allow booting a virtio-net-pci device with 256 queue pairs. ... * configuration space */

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread Peter Lieven
Am 07.04.2015 um 17:29 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015 um 10:43 schrieb Dr. David Alan Gilbert: Any particular workload or reproducer? Workload is almost zero. I try to figure out if there is a way to trigger it. Maybe playing

[Qemu-devel] [PATCH 08/15] ipmi: Add documentation

2015-04-07 Thread minyard
From: Corey Minyard cminy...@mvista.com Add some basic documentation for the IPMI device. Signed-off-by: Corey Minyard cminy...@mvista.com --- qemu-options.hx | 38 ++ 1 file changed, 38 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index

[Qemu-devel] [PATCH 13/15] configure: Copy some items from default configs to target configs

2015-04-07 Thread minyard
From: Corey Minyard cminy...@mvista.com This is to get CONFIG_ACPI into the target config so devices that may use ACPI know to do this or not. Signed-off-by: Corey Minyard cminy...@mvista.com --- configure | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure b/configure index

[Qemu-devel] [PATCH 04/15] ipmi: Add a BT low-level interface

2015-04-07 Thread minyard
From: Corey Minyard cminy...@mvista.com This provides the simulation of the BT hardware interface for IPMI. Signed-off-by: Corey Minyard cminy...@mvista.com --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 +

[Qemu-devel] [PATCH 12/15] ipmi: Add SMBIOS table entry

2015-04-07 Thread minyard
From: Corey Minyard cminy...@mvista.com Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard cminy...@mvista.com --- hw/ipmi/isa_ipmi.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/hw/ipmi/isa_ipmi.c b/hw/ipmi/isa_ipmi.c

[Qemu-devel] [PATCH 06/15] ipmi: Add an external connection simulation interface

2015-04-07 Thread minyard
From: Corey Minyard cminy...@mvista.com This adds an interface for IPMI that connects to a remote BMC over a chardev (generally a TCP socket). The OpenIPMI lanserv simulator describes this interface, see that for interface details. Signed-off-by: Corey Minyard cminy...@mvista.com ---

[Qemu-devel] [Bug 1438144] Re: Page sizes are not interpreted correctly for E500/E500MC

2015-04-07 Thread Scott Wood
This is not a bug. MMU v2 (implemented in e6500) extended the TSIZE field so that 1K TSIZE is correct. The extension was on the LSB side so that it works fine as long as the low bit of the new TSIZE (which is reserved on e500v2/mc) is zero. ** Changed in: qemu Status: New = Invalid

[Qemu-devel] [PATCH 10/14] target-arm: Honour NS bits in page tables

2015-04-07 Thread Peter Maydell
Honour the NS bit in ARM page tables: * when adding entries to the TLB, include the Secure/NonSecure transaction attribute * set the NS bit in the PAR when doing ATS operations Note that we don't yet correctly use the NSTable bit to cause the page table walk itself to use the right

[Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-07 Thread Peter Maydell
Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- dma-helpers.c| 3 ++- exec.c | 51 ++--

[Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-07 Thread minyard
From: Corey Minyard cminy...@mvista.com There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler adding it's SMBIOS table entry. Signed-off-by: Corey Minyard

[Qemu-devel] [PATCH 13/14] target-arm: Use attribute info to handle user-only watchpoints

2015-04-07 Thread Peter Maydell
Now that we have memory access attribute information in the watchpoint checking code, we can correctly implement handling of watchpoints which should match only on userspace accesses, where LDRT/STRT/LDT/STT from EL1 are treated as userspace accesses. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 6/6] scripts: x86-cpu-model-dump script

2015-04-07 Thread Eduardo Habkost
This is an example script that can be used to help generate a config file that will reproduce a given CPU model from QEMU. The generated config file can be loaded using -readconfig to make QEMU create CPUs that will look exactly like the one used when cpu-model-dump was run. A

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-07 Thread John Snow
On 04/07/2015 03:02 PM, Peter Lieven wrote: Am 07.04.2015 um 20:56 schrieb John Snow: On 04/07/2015 02:44 PM, Peter Lieven wrote: Am 07.04.2015 um 17:29 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015 um 10:43 schrieb Dr. David Alan Gilbert:

  1   2   >