Re: [Qemu-devel] [PATCH] Use Aff1 with mpidr

2015-06-01 Thread Pavel Fedin
Hi! I think we should take Igor's comment into account. The CPUS_PER_CLUSTER should not be a constant, and maybe should be initialized in arm_cpu_initfn and aarch64_{a53|a57}_initfn, as psci need to know it. Yes, of course. Just replace a #define with something like: int

[Qemu-devel] [Bug 1460523] [NEW] target-arm/op_helper.c:424: bad assert

2015-06-01 Thread dcb
Public bug reported: /home/dcb/qemu/trunk/qemu/target-arm/op_helper.c: In function ‘helper_access_check_cp_reg’: /home/dcb/qemu/trunk/qemu/target-arm/op_helper.c:424:52: error: comparison of constant ‘3’ with boolean expression is always false [-Werror=bool-compare]

[Qemu-devel] Ping: [PATCH] xen/pass-through: ROM BAR handling adjustments

2015-06-01 Thread Jan Beulich
Ping? On 15.05.15 at 14:41, jbeul...@suse.com wrote: Expecting the ROM BAR to be written with an all ones value when sizing the region is wrong - the low bit has another meaning (enable/disable) and bits 1..10 are reserved. The PCI spec also mandates writing all ones to just the address

[Qemu-devel] Ping: [PATCH] xen/pass-through: fold host PCI command register writes

2015-06-01 Thread Jan Beulich
Ping? On 15.05.15 at 14:46, jbeul...@suse.com wrote: The code introduced to address XSA-126 allows simplification of other code in xen_pt_initfn(): All we need to do is update cmd suitably, as it'll be written back to the host register near the end of the function anyway. Signed-off-by:

[Qemu-devel] [PATCH] net: fix insecure temporary file creation in SLiRP

2015-06-01 Thread mrezanin
From: Miroslav Rezanina mreza...@redhat.com Qemu's user mode networking stack(-net user) is vulnerable to a predictable temporary file creation flaw. This patch uses mkdtemp(3) routine to fix it. Fixes CVE-2015-4037. Signed-off-by: P J P p...@fedoraproject.org Signed-off-by: Miroslav Rezanina

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Laszlo Ersek
On 05/31/15 20:10, Michael S. Tsirkin wrote: On Wed, Apr 29, 2015 at 11:21:53AM -0400, Gabriel L. Somlo wrote: Allow user supplied files to be inserted into the fw_cfg device before starting the guest. Since fw_cfg_add_file() already disallows duplicate fw_cfg file names, qemu will exit with

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-06-01 Thread Liviu Ionescu
On 01 Jun 2015, at 05:26, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: to see a developers' changes ... do this (bash): git diff $(git merge-base target-branch master) target-branch :-) I was a 'unix typist' for more than 25 years, now I'm getting old and getting lazy.

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/3] target-i386: reserve RCRB mmio space in ACPI DSDT table

2015-06-01 Thread Gerd Hoffmann
On Sa, 2015-05-30 at 07:57 -0300, Paulo Alcantara wrote: Hi Gerd, On Thu, 28 May 2015 09:13:35 +0200 Gerd Hoffmann kra...@redhat.com wrote: +Scope(\_SB) { +OperationRegion (RCRB, SystemMemory, 0xfed1c000, 0x4000) Where does this address come from? This address is reserved

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-06-01 Thread Paolo Bonzini
On 31/05/2015 16:05, Liviu Ionescu wrote: I followed your advice and I ended up with the following: - I added a new type cortexm-mcu that I use as parent for all Cortex-M MCU objects (like STM32F103RB) - I added the following properties to this type:

[Qemu-devel] [PATCH v7 3/3] target-mips: Misaligned memory accesses for MSA

2015-06-01 Thread Yongbok Kim
MIPS SIMD Architecture vector loads and stores require misalignment support. MSA Memory access should work as an atomic operation. Therefore, it has to check validity of all addresses for a vector store access if it is spanning into two pages. Separating helper functions for each data format as

[Qemu-devel] [PATCH v7 0/3] target-mips: Add support for misaligned accesses

2015-06-01 Thread Yongbok Kim
This patch set adds support for misaligned memory accesses in MIPS architecture Release 6 and MIPS SIMD Architecture. The behaviour, semantics, and architecture specifications of misaligned memory accesses are described in: MIPS Architecture For Programmers Volume I-A: Introduction to the MIPS64

Re: [Qemu-devel] [PATCH] slirp: use less predictable directory name in /tmp for smb config (CVE-2015-4037)

2015-06-01 Thread Miroslav Rezanina
On Thu, May 28, 2015 at 02:15:43PM +0300, Michael Tokarev wrote: In this version I used mkdtemp(3) which is: _BSD_SOURCE || /* Since glibc 2.10: */ (_POSIX_C_SOURCE = 200809L || _XOPEN_SOURCE = 700) so should be available on systems we care about.

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Gerd Hoffmann
On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: On 05/31/2015 09:12 PM, Michael S. Tsirkin wrote: On Mon, May 25, 2015 at 06:34:01PM +0300, Marcel Apfelbaum wrote: PXB does not work with unsupported bioses, but should not interfere with normal OS operation. We don't ship them

Re: [Qemu-devel] [PULL 00/57] pc, pci, tpm, virtio enhancements and fixes

2015-06-01 Thread Peter Maydell
On 31 May 2015 at 19:34, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit 97af820f539efe80b87615a04f9de11ea585f725: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150529' into staging (2015-05-29 17:10:57 +0100) are available in the git

[Qemu-devel] [PULL v2 14/60] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com The compat property was added by commit 9dbcca5aa13cb9ab40788ac4c56bc227d94ca920, and the pc-0.12 and older machine-types were not changed because virtio-9p-pci was introduced on QEMU 0.13 (commit 9f10751365b26b13b8a9b67e0e90536ae3d282df). The only

[Qemu-devel] [PULL v2 07/60] spapr: Move commas inside SPAPR_COMPAT_* macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Gerd Hoffmann
On Mo, 2015-06-01 at 14:17 +0200, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: On 05/31/2015 09:12 PM, Michael S. Tsirkin wrote: On Mon, May 25, 2015 at 06:34:01PM +0300, Marcel

[Qemu-devel] [PULL v2 48/60] TPM2 ACPI table support

2015-06-01 Thread Michael S. Tsirkin
From: Stefan Berger stef...@linux.vnet.ibm.com Add a TPM2 ACPI table if a TPM 2 is used in the backend. Also add an SSDT for the TPM 2. Rename tpm_find() to tpm_get_version() and have this function return the version of the TPM found, TPMVersion_Unspec if no TPM is found. Use the version number

[Qemu-devel] [PULL v2 38/60] virtio: rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang jasow...@redhat.com VIRTIO_PCI_QUEUE_MAX is not only used for pci, so rename it be generic. Cc: Amit Shah amit.s...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by:

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 03:21:19PM +0300, Marcel Apfelbaum wrote: On 06/01/2015 03:17 PM, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: On 05/31/2015 09:12 PM, Michael S. Tsirkin wrote: On

[Qemu-devel] [PULL v2 46/60] Extend TPM TIS interface to support TPM 2

2015-06-01 Thread Michael S. Tsirkin
From: Stefan Berger stef...@linux.vnet.ibm.com Following the recent upgrade to version 1.3, extend the TPM TIS interface with capabilities introduced for support of a TPM 2. TPM TIS for TPM 2 introduced the following extensions beyond the TPM TIS 1.3 (used for TPM 1.2): - A new 32bit interface

[Qemu-devel] [PULL v2 51/60] acpi: add aml_index() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Shannon Zhao shannon.z...@linaro.org ---

[Qemu-devel] [PULL v2 58/60] qdev: add 64bit properties

2015-06-01 Thread Michael S. Tsirkin
From: Gerd Hoffmann kra...@redhat.com Needed for virtio features which go from 32bit to 64bit with virtio 1.0 Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/qdev-properties.h | 10

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 02:24:02PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-01 at 14:17 +0200, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: On 05/31/2015 09:12 PM, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-06-01 Thread Dmitry Monakhov
Paolo Bonzini pbonz...@redhat.com writes: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01/06/2015 12:34, Dmitry Monakhov wrote: Yes. Improvement is not huge, but it can be detected for old qemu unpatched kernel: 728 MiB/sec ± 20Mb patched kernel : 748 MiB/sec ± 10Mb Ok, so

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 14:41, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 02:39:17PM +0200, Paolo Bonzini wrote: On 01/06/2015 14:38, Michael S. Tsirkin wrote: I'm sorry - I don't understand. It's easy to do the right thing. Just add the opt prefix. Why insist on user doing the right thing,

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Marcel Apfelbaum
On 06/01/2015 03:27 PM, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 03:21:19PM +0300, Marcel Apfelbaum wrote: On 06/01/2015 03:17 PM, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: On

Re: [Qemu-devel] [PATCH 1/1] Add -incoming help text

2015-06-01 Thread Markus Armbruster
Dr. David Alan Gilbert dgilb...@redhat.com writes: * Markus Armbruster (arm...@redhat.com) wrote: Michael Tokarev m...@tls.msk.ru writes: 29.05.2015 21:52, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The help/man text for -incoming defer

Re: [Qemu-devel] [PATCH 0/6] pci/isa: QOMify

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 12:25, Michael S. Tsirkin wrote: Hi, Michael, Paolo Can you please ack or review those patches? Regards, -Gonglei I think this belongs in the QOM tree, not mine. Recently Gerd at least has taken similar patches, so I guess it belongs all over the place, including

[Qemu-devel] [PULL v2 26/60] pc: Generate init functions with a macro

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com All pc-i440fx and pc-q35 init functions simply call the corresponding compat function and then call the main init function. Use a macro to generate that code. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 02:39:17PM +0200, Paolo Bonzini wrote: On 01/06/2015 14:38, Michael S. Tsirkin wrote: I'm sorry - I don't understand. It's easy to do the right thing. Just add the opt prefix. Why insist on user doing the right thing, and punish violations with failing at

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 12:50:50PM +0200, Paolo Bonzini wrote: On 01/06/2015 12:48, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 12:43:35PM +0200, Paolo Bonzini wrote: On 01/06/2015 12:23, Michael S. Tsirkin wrote: Still, reserving part of the namespace for QEMU internal use

Re: [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mpidr

2015-06-01 Thread Shlomo Pongratz
-Original Message- From: Igor Mammedov [mailto:imamm...@redhat.com] Sent: Wednesday, 27 May, 2015 7:12 PM To: shlomopongr...@gmail.com Cc: qemu-devel@nongnu.org; peter.mayd...@linaro.org; Shlomo Pongratz Subject: Re: [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mpidr On Wed, 6

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 13:00, Michael S. Tsirkin wrote: If it's just for playing games, add a configure switch to enable it, and disable by default. Don't set traps for users. What is for playing games? What is the feature useful for, except for developers. OK so if it's a dveloper

Re: [Qemu-devel] [PULL 0/3] tricore-patches

2015-06-01 Thread Peter Maydell
On 30 May 2015 at 15:59, Bastian Koppelmann kbast...@mail.uni-paderborn.de wrote: The following changes since commit 97af820f539efe80b87615a04f9de11ea585f725: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150529' into staging (2015-05-29 17:10:57 +0100) are

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/3] target-i386: reserve RCRB mmio space in ACPI DSDT table

2015-06-01 Thread Paulo Alcantara
On Mon, June 1, 2015 4:16 am, Gerd Hoffmann wrote: On Sa, 2015-05-30 at 07:57 -0300, Paulo Alcantara wrote: Hi Gerd, On Thu, 28 May 2015 09:13:35 +0200 Gerd Hoffmann kra...@redhat.com wrote: +Scope(\_SB) { +OperationRegion (RCRB, SystemMemory, 0xfed1c000, 0x4000) Where does

[Qemu-devel] [PULL v2 17/60] pc: Define MACHINE_OPTIONS macros consistently for all machines

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Define a MACHINE_OPTIONS macro for each PC machine, and move every field inside the QEMUMachine structs to the macros, except for name, init, and compat_props. This also ensures that all MACHINE_OPTIONS inherit the fields from the next version, so their

[Qemu-devel] [PULL v2 06/60] pc: Move commas inside PC_COMPAT_* macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL v2 02/60] hw/virtio/virtio-pci: use alias property for virtio-balloon-pci

2015-06-01 Thread Michael S. Tsirkin
From: Shannon Zhao shannon.z...@linaro.org Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com

[Qemu-devel] [PULL v2 21/60] pc: Don't use QEMUMachine anymore

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Now that we have a DEFINE_PC_MACHINE helper macro that just requires an initialization function, it is trivial to convert them to register a QOM machine class directly, instead of using QEMUMachine. Signed-off-by: Eduardo Habkost ehabk...@redhat.com

[Qemu-devel] [PULL v2 08/60] hw: Define empty HW_COMPAT_2_[23] macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Now we can make everything consistent and define the macros even if they are still empty. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL v2 18/60] pc: Define machines using a DEFINE_PC_MACHINE macro

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com This will automatically generate the existing QEMUMachine structs based on the *_MACHINE_OPTIONS macros, and automatically add registration code for them. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL v2 09/60] pc: Define PC_COMPAT_2_[123] macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Once we start adding compat code for pc-2.3, the usage of HW_COMPAT_2_1 in pc-*-2.2 won't be enough, as it also has to include PC_COMPAT_2_3 inside it. To ensure that, define PC_COMPAT_2_3, PC_COMPAT_2_2, and PC_COMPAT_2_1 macros. Signed-off-by: Eduardo

[Qemu-devel] [PULL v2 28/60] virtio: move host_features

2015-06-01 Thread Michael S. Tsirkin
From: Cornelia Huck cornelia.h...@de.ibm.com Move host_features from the individual transport proxies into the virtio device. Transports may continue to add feature bits during device plugging. This should it make easier to offer different sets of host features for virtio-1/transitional support.

[Qemu-devel] [PULL v2 57/60] virtio-mmio: ioeventfd support

2015-06-01 Thread Michael S. Tsirkin
From: Ying-Shiuan Pan yingshiuan@gmail.com set_host_notifier and set_guest_notifiers supported by virtio-mmio now. Most code copied from virtio-pci. This makes it possible to use vhost-net with virtio-mmio, improving performance by about 30%. The kvm-arm does not yet support irqfd, need to

[Qemu-devel] [PULL v2 54/60] acpi: add aml_increment() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Add encoding for ACPI DefIncrement Opcode. Reviewed-by: Shannon Zhao zhaoshengl...@huawei.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by:

Re: [Qemu-devel] [Qemu-block] [PATCH] mirror: Skip block_job_defer_to_main_loop if already in the main context

2015-06-01 Thread Stefan Hajnoczi
On Mon, Jun 01, 2015 at 09:46:39AM +0800, Fam Zheng wrote: On Fri, 05/29 13:37, Stefan Hajnoczi wrote: On Fri, May 29, 2015 at 10:22:13AM +0800, Fam Zheng wrote: mirror_exit does the replacing, which requires source and target to be in sync, unfortunately we can't guarantee that before we

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Gerd Hoffmann
Hi, Devices behind pxb wouldn't be working because they didn't got resources assigned, yes. I mean that there's no way to get old seabios+pxb when bisecting. When bisecting in qemu (with bundled seabios) yes. But when bisection in seabios ... Anyway, at the end of the day it doesn't

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Gabriel L. Somlo
On Mon, Jun 01, 2015 at 12:50:50PM +0200, Paolo Bonzini wrote: Someone writes a tool using a specific path. We then add same path upstream, script breaks. Who cares. We documented it. One usecase of this feature is to avoid recompiling QEMU while playing with firmware. If you cannot

Re: [Qemu-devel] [PULL 00/57] pc, pci, tpm, virtio enhancements and fixes

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 01:04:03PM +0100, Peter Maydell wrote: On 31 May 2015 at 19:34, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit 97af820f539efe80b87615a04f9de11ea585f725: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150529'

[Qemu-devel] [PULL v2 05/60] hw: Move commas inside HW_COMPAT_2_1 macro

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL v2 24/60] piix: Add kvmclock_enabled, pci_enabled globals

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com This looks like a step backwards, but it will allow pc-0.1[0123] and isapc to follow the same compat+init pattern used by the other machine-types, allowing us to generate all init function using the same macro later. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL v2 22/60] pc: Remove qemu_register_pc_machine() function

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com The helper is not needed anymore, as the PC machine classes are registered using QOM directly. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL v2 16/60] piix: Define PC_COMPAT_0_10

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Move compat_props from pc-0.10 to the macro, to make it consistent with the other machines. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL v2 34/60] virtio-ccw: introduce ccw specific queue limit

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang jasow...@redhat.com Cc: Alexander Graf ag...@suse.de Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Christian Borntraeger borntrae...@de.ibm.com Cc: Richard Henderson r...@twiddle.net Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL v2 10/60] spapr: Use HW_COMPAT_* inside SPAPR_COMPAT_* macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com SPAPR_COMPAT_2_1 will need to include both HW_COMPAT_2_2 and HW_COMPAT_2_1, so include HW_COMPAT_2_1 inside SPAPR_COMPAT_2_1 and HW_COMPAT_2_2 inside SPAPR_COMPAT_2_2. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 29/60] virtio-ccw: Don't advertise VIRTIO_F_BAD_FEATURE

2015-06-01 Thread Michael S. Tsirkin
From: Cornelia Huck cornelia.h...@de.ibm.com This was copied from virtio-pci, but it doesn't make much sense for ccw, as it doesn't have to handle the broken implementations this bit is supposed to deal with. Remove it. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Reviewed-by: Michael

[Qemu-devel] [PULL v2 39/60] virtio: increase the queue limit to 1024

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang jasow...@redhat.com Increase the queue limit to 1024. But virtio-ccw and s390-virtio won't support this, this is done through failing device_plugged() for those two transports if the number of virtqueues is greater than 64. Signed-off-by: Jason Wang jasow...@redhat.com

[Qemu-devel] [PULL v2 44/60] acpi: Simplify printing to dynamic string

2015-06-01 Thread Michael S. Tsirkin
From: Markus Armbruster arm...@redhat.com build_append_namestringv() and aml_string() first calculate the resulting string's length with vsnprintf(NULL, ...), then allocate, then print for real. Simply use g_strdup_vprintf() or g_vasprintf() instead. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL v2 15/60] piix: Move pc-0.1[23] rombar compat props to PC_COMPAT_0_13

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com The VGA and vmware-svga rombar compat properties were added by commit 281a26b15b4adcecb8604216738975abd754bea8, but only to pc-0.13 and pc-0.12. This breaks the PC_COMPAT_* nesting pattern we currently follow. The new variables will now be inherited by

[Qemu-devel] [PULL v2 52/60] acpi: add aml_shiftleft() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Add encoding for ACPI DefShiftLeft Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by:

[Qemu-devel] [PULL v2 36/60] virtio-s390: introduce virito s390 queue limit

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang jasow...@redhat.com Cc: Alexander Graf ag...@suse.de Cc: Richard Henderson r...@twiddle.net Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/s390x/s390-virtio-bus.c | 6 --

Re: [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-06-01 Thread Dmitry Monakhov
#secure method=pgpmime mode=sign Paolo Bonzini pbonz...@redhat.com writes: On 01/06/2015 13:16, Dmitry Monakhov wrote: 259,0 31 385 0.719283423 10729 Q WS 29376775 + 248 [qemu-io] 259,0 31 388 0.719287600 10729 Q WS 29377023 + 8 [qemu-io] 259,0 31 391

[Qemu-devel] [PATCH v7 2/3] softmmu: Add probe_write()

2015-06-01 Thread Yongbok Kim
Probe for whether the specified guest write access is permitted. If it is not permitted then an exception will be taken in the same way as if this were a real write access (and we will not return). Otherwise the function will return, and there will be a valid entry in the TLB for this access.

[Qemu-devel] [PATCH v7 1/3] target-mips: Misaligned memory accesses for R6

2015-06-01 Thread Yongbok Kim
Release 6 requires misaligned memory access support for all ordinary memory access instructions (for example, LW/SW, LWC1/SWC1). However misaligned support is not provided for certain special memory accesses such as atomics (for example, LL/SC). Signed-off-by: Yongbok Kim yongbok@imgtec.com

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Mon, Jun 01, 2015 at 12:43:35PM +0200, Paolo Bonzini wrote: On 01/06/2015 12:23, Michael S. Tsirkin wrote: Still, reserving part of the namespace for QEMU internal use is *not* policy, it's just good engineering. How about we forbid

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 13:20, Markus Armbruster wrote: If it's just for playing games, add a configure switch to enable it, and disable by default. Don't set traps for users. Document development aids as use at your own risk, spit out scary warnings on use if you like, hide them from the

Re: [Qemu-devel] [PATCH 09/10] Sort destination RAMBlocks to be the same as the source

2015-06-01 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 04/20/2015 10:57 AM, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Use the order of incoming RAMBlocks from the source to record an index number; that then allows us to sort the destination

[Qemu-devel] [PULL v2 25/60] piix: Eliminate pc_init_pci()

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com The function is not needed anymore, we can simply call pc_init1() directly. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/pc_piix.c | 31

[Qemu-devel] [PULL v2 23/60] machine: Remove unused fields from QEMUMachine

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com This removes the following fields from QEMUMachine: family, alias, reset, hot_add_cpu, units_per_default_bus, no_serial, no_parallel, use_virtcon, use_sclp, no_floppy, no_cdrom, default_display, compat_props, and hw_version. The only users of those

[Qemu-devel] [PULL v2 41/60] i386/pc: '-drive if=floppy' should imply a board-default FDC

2015-06-01 Thread Michael S. Tsirkin
From: Laszlo Ersek ler...@redhat.com Even if board code decides not to request the creation of the FDC (keyed off board-level factors, to be determined later), we should create the FDC nevertheless if the user passes '-drive if=floppy' on the command line. Otherwise '-drive if=floppy' would

[Qemu-devel] [PULL v2 31/60] virtio-net: adding all queues in .realize()

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang jasow...@redhat.com Instead of adding queues for multiqueue during feature set. This patch did this in .realize(), this will help the following patches that count the number of virtqueues used in .device_plugged() callback. Signed-off-by: Jason Wang jasow...@redhat.com

[Qemu-devel] [PULL v2 13/60] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11 breaks the PC_COMPAT_* nesting pattern we currently use. As those variables are overwritten in pc-0.10 too, they can be inherited by pc-0.10 with no side-effects at all. Cc: Gerd

[Qemu-devel] [PULL v2 37/60] virtio-s390: introduce virtio_s390_device_plugged()

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang jasow...@redhat.com This patch introduce a virtio-s390 specific device_plugged() function and doing the number of virtqueue validation inside. Cc: Alexander Graf ag...@suse.de Cc: Richard Henderson r...@twiddle.net Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by:

[Qemu-devel] [PULL v2 55/60] acpi: add aml_while() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Add encoding for ACPI DefWhile Opcode. Reviewed-by: Shannon Zhao zhaoshengl...@huawei.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by:

[Qemu-devel] [PULL v2 49/60] acpi: add aml_add() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Add encoding for ACPI DefAdd Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Shannon

[Qemu-devel] [PULL v2 59/60] virtio: make features 64bit wide

2015-06-01 Thread Michael S. Tsirkin
From: Gerd Hoffmann kra...@redhat.com Make features 64bit wide everywhere. On migration a full 64bit guest_features field is sent if one of the high bits is set, in addition to the lower 32bit guest_features field which must stay for compatibility reasons. That way we send the lower 32 feature

[Qemu-devel] [PULL v2 47/60] tpm: Probe for connected TPM 1.2 or TPM 2

2015-06-01 Thread Michael S. Tsirkin
From: Stefan Berger stef...@linux.vnet.ibm.com In the TPM passthrough backend driver, modify the probing code so that we can check whether a TPM 1.2 or TPM 2 is being used and adapt the behavior of the TPM TIS accordingly. Move the code that tested for a TPM 1.2 into tpm_utils.c and extend it

Re: [Qemu-devel] [PATCH 1/2] target-arm/kvm64: Add cortex-a53 cpu support

2015-06-01 Thread Shannon Zhao
On 2015/6/1 18:54, Peter Crosthwaite wrote: On Mon, Jun 1, 2015 at 3:34 AM, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Say more about the changes. Why the gap to index 4? You mean why the KVM_ARM_TARGET_CORTEX_A53 is 4? linux-headers/asm-arm64/kvm.h

Re: [Qemu-devel] VirtIO windows driver: viostor.sys not post-installable

2015-06-01 Thread Philipp Hahn
Hello, On 31.05.2015 12:58, Vadim Rozenfeld wrote: On Sun, 2015-05-31 at 11:26 +0300, Yan Vugenfirer wrote: On May 29, 2015, at 5:43 PM, Philipp Hahn h...@univention.de wrote: ... we tried to migrate some Windows 2008 and 2012 VMs from Xen to KVM, but installing the VirtIO viostor.sys

Re: [Qemu-devel] [PATCH] slirp: use less predictable directory name in /tmp for smb config (CVE-2015-4037)

2015-06-01 Thread Markus Armbruster
Michael Tokarev m...@tls.msk.ru writes: 01.06.2015 11:01, Markus Armbruster wrote: [] -snprintf(s-smb_dir, sizeof(s-smb_dir), /tmp/qemu-smb.%ld-%d, - (long)getpid(), instance++); -if (mkdir(s-smb_dir, 0700) 0) { +strcpy(s-smb_dir, /tmp/qemu-smb.XX); +if

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Laszlo Ersek
On 06/01/15 12:43, Paolo Bonzini wrote: On 01/06/2015 12:23, Michael S. Tsirkin wrote: Still, reserving part of the namespace for QEMU internal use is *not* policy, it's just good engineering. How about we forbid adding files under etc/ ? That would be enough to avoid conflicts. I do

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: On 05/31/2015 09:12 PM, Michael S. Tsirkin wrote: On Mon, May 25, 2015 at 06:34:01PM +0300, Marcel Apfelbaum wrote: PXB does not work with unsupported bioses, but

[Qemu-devel] [PULL v2 01/60] hw/virtio/virtio-balloon: move adding property to virtio_balloon_instance_init

2015-06-01 Thread Michael S. Tsirkin
From: Shannon Zhao shannon.z...@linaro.org This is in preparation for using alias property in virtio-balloon-pci and virtio-balloon-ccw. Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org Reviewed-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL v2 00/60] pc, pci, tpm, virtio, vhost enhancements and fixes

2015-06-01 Thread Michael S. Tsirkin
The following changes since commit 97af820f539efe80b87615a04f9de11ea585f725: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150529' into staging (2015-05-29 17:10:57 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL v2 04/60] pc: Replace tab with spaces

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Coding style change only. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 12 ++-- hw/i386/pc_piix.c| 2 +- 2

[Qemu-devel] [PULL v2 32/60] virtio: device_plugged() can fail

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang jasow...@redhat.com This patch passes error pointer to transport specific device_plugged() callback. Through this way, device_plugged() can do some transport specific check and fail. This will be uesd by following patches that check the number of virtqueues against the transport

[Qemu-devel] [PULL v2 11/60] spapr: define SPAPR_COMPAT_2_3

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Don't add the pseries-2.3 machine yet, but define the corresponding SPAPR_COMPAT macro to make sure both pseries-2.2 and pseries-2.1 will inherit HW_COMPAT_2_3. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 30/60] virtio: move VIRTIO_F_NOTIFY_ON_EMPTY into core

2015-06-01 Thread Michael S. Tsirkin
From: Cornelia Huck cornelia.h...@de.ibm.com Nearly all transports have been offering VIRTIO_F_NOTIFY_ON_EMPTY, s390-virtio being the exception. There's no reason why it shouldn't offer it as well, though (handling is done in core anyway), so let's move it to the common virtio features. While

[Qemu-devel] [PULL v2 35/60] virtio-ccw: validate the number of queues against bus limitation

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang jasow...@redhat.com Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Christian Borntraeger borntrae...@de.ibm.com Cc: Richard Henderson r...@twiddle.net Cc: Alexander Graf ag...@suse.de Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL v2 12/60] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com Those properties were introduced by commit 3827cdb1c3aa17a792d1658161195b9d7173c26b. They were not duplicated into pc-0.13 and older because 0.14 was the first QEMU version supporting qxl. The only problem is that this breaks the PC_COMPAT_* nesting

[Qemu-devel] [PULL v2 27/60] pc: acpi: fix pvpanic for buggy guests

2015-06-01 Thread Michael S. Tsirkin
From: Radim Krčmář rkrc...@redhat.com In the old times, we always had pvpanic in ACPI and a _STA method told the guest not to use it. Automatic generation dropped the _STA method as the specification says that missing _STA means enabled and working. Some guests (Linux) had buggy drivers and this

[Qemu-devel] [PULL v2 45/60] Add stream ID to MSI write

2015-06-01 Thread Michael S. Tsirkin
From: Pavel Fedin p.fe...@samsung.com GICv3 ITS distinguishes between devices by using hardwired device IDs passed on the bus. This patch implements passing these IDs in qemu. SMMU is also known to use stream IDs, therefore this addition can also be useful for implementing platforms with SMMU.

[Qemu-devel] [PULL v2 40/60] i386/pc: pc_basic_device_init(): delegate FDC creation request

2015-06-01 Thread Michael S. Tsirkin
From: Laszlo Ersek ler...@redhat.com This patch introduces no observable change, but it allows the callers of pc_basic_device_init(), ie. pc_init1() and pc_q35_init(), to request (or not request) the creation of the FDC explicitly. At the moment both callers pass constant create_fdctrl=true

[Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper

2015-06-01 Thread Leon Yu
as comparing boolean with constant 3 is always false. Signed-off-by: Leon Yu chianglun...@gmail.com --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index 3f5b9ab..30f2374 100644 ---

[Qemu-devel] [PULL v2 42/60] i386/pc_q35: don't insist on board FDC if there's no default floppy

2015-06-01 Thread Michael S. Tsirkin
From: Laszlo Ersek ler...@redhat.com The no_floppy = 1 machine class setting causes default_floppy in main() to become zero. Consequently, default_drive() will not call drive_add() and drive_new() for IF_FLOPPY, index=0, meaning that no default floppy drive will be created for the virtual

[Qemu-devel] [PULL v2 50/60] acpi: add aml_lless() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Add encoding for ACPI DefLLess Opcode. Reviewed-by: Shannon Zhao zhaoshengl...@huawei.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by:

[Qemu-devel] [PULL v2 56/60] hw/acpi/aml-build: Fix memory leak

2015-06-01 Thread Michael S. Tsirkin
From: Shannon Zhao shannon.z...@linaro.org Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com ---

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 01:26:53PM +0200, Laszlo Ersek wrote: On 06/01/15 12:48, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 12:43:35PM +0200, Paolo Bonzini wrote: On 01/06/2015 12:23, Michael S. Tsirkin wrote: Still, reserving part of the namespace for QEMU internal use is

Re: [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-06-01 Thread Dmitry Monakhov
Paolo Bonzini pbonz...@redhat.com writes: On 13/05/2015 18:46, Denis V. Lunev wrote: I agree with this. Kernel guys are aware and may be we will have the fix after a while... I have heard (not tested) that performance loss over multi-queue SSD is around 30%. I came up with this patch... can

  1   2   3   4   5   >