[Qemu-devel] [RFC PATCH v0 1/3] pc-dimm: Add a field to PCDIMMDevice to mark device deletion state

2015-08-18 Thread Bharata B Rao
Add a field to PCDIMMDevice to note that the device has been marked for removal. This will be used by PowerPC memory hotplug code to honour the LMB removal requests of only those LMBs that belong to PCDIMMDevice that has been marked for removal. This will be set from -unplug() handler. Signed-off-

[Qemu-devel] [RFC PATCH v0 0/3] sPAPR: Memory hot removal support

2015-08-18 Thread Bharata B Rao
This patchset enables memory hot unplug for PowerPC sPAPR guests. This applies against spapr-next branch of David Gibson's tree that currently contains the memory hotplug code for sPAPR. Currently with drmgr, it is not possible to attempt just the removal of those LMBs that form the DIMM device wh

[Qemu-devel] [RFC PATCH v0 3/3] spapr: Memory hot-unplug support

2015-08-18 Thread Bharata B Rao
Add support to hot remove pc-dimm memory devices. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 114 - hw/ppc/spapr_drc.c | 21 + include/hw/ppc/spapr.h | 2 + 3 files changed, 136 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v10 4/5] hw/intc: Initial implementation of vGICv3

2015-08-18 Thread Pavel Fedin
Hello! > > Signed-off-by: Pavel Fedin > in v8 you got Peter's R-b. Did you omit it willingly or did you make any > changes since that. A changelog would ease the review in any case. Oops, i just forgot it. Thanks. Will fixup your notes and add it in v11. Kind regards, Pavel Fedin Expert Engin

Re: [Qemu-devel] [PATCH v14 0/8] i.MX: Add i.MX25 support through the PDK evaluation board

2015-08-18 Thread Jean-Christophe DUBOIS
Hi Peter, Do you expect more work on this series? JC Le 11/08/2015 00:02, Jean-Christophe Dubois a écrit : This series of patches is generated against Peter Maydell GIT tree: https://git.linaro.org/people/peter.maydell/qemu-arm.git branch target-arm-post-2.4 This series of patches add the

Re: [Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some reusable vGIC code

2015-08-18 Thread Pavel Fedin
Hello! > I think it would be worth justifying the changes in signature: > removal of GICState* due to the introduction of GICV3State and also > justify replacement of uint32_t *val into void*. I described it in the cover letter. Right now you don't see usage for it, but here i started prototy

Re: [Qemu-devel] [PULL v2] Queued TCG improvements

2015-08-18 Thread Richard Henderson
On 08/18/2015 04:23 PM, Peter Maydell wrote: Hi. I'm afraid this fails 'make check' on 32-bit ARM for me: ... (i386-softmmu doesn't segv, so probably it's a 64-bit-ops-on-32-bit thing.) Sadly, this doesn't fail on 32-bit x86 host. I've started a build on an arm host, but it may be a while b

Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added

2015-08-18 Thread Hannes Reinecke
On 08/19/2015 01:50 AM, Thomas Huth wrote: > On 17/08/15 16:42, Alexander Bezzubikov wrote: >> Signed-off-by: Alexander Bezzubikov >> --- >> hw/ide/internal.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/hw/ide/internal.h b/hw/ide/internal.h >> index f2999ce..3ebc63c 100644 >> -

Re: [Qemu-devel] [PATCH] Block: don't do copy-on-read in before_write_notifier

2015-08-18 Thread Wen Congyang
On 08/19/2015 01:41 PM, Paolo Bonzini wrote: > On 18/08/2015 19:54, Wen Congyang wrote: >> We will copy data in before_write_notifier to do backup. >> It is a nested I/O request, so we cannot do copy-on-read. > > Can you explain why? What is the bug that this is fixing? (gdb) bt #0 0x7fd53a

Re: [Qemu-devel] [PATCH] Block: don't do copy-on-read in before_write_notifier

2015-08-18 Thread Paolo Bonzini
On 18/08/2015 19:54, Wen Congyang wrote: > We will copy data in before_write_notifier to do backup. > It is a nested I/O request, so we cannot do copy-on-read. Can you explain why? What is the bug that this is fixing? Paolo > Signed-off-by: Wen Congyang

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-18 Thread Dennis Luehring
Am 18.08.2015 um 21:06 schrieb Karel Gardas: Thanks a lot for doing this. It looks like g++ is memory-bound in this case, isn't it? What does stream[1] benchmark tell on host and emulated as 32/64bit sparc binary? Let's see if the ratio is kind of similar to the time you get... [1]:https://www.c

[Qemu-devel] [PATCH] Block: don't do copy-on-read in before_write_notifier

2015-08-18 Thread Wen Congyang
We will copy data in before_write_notifier to do backup. It is a nested I/O request, so we cannot do copy-on-read. Signed-off-by: Wen Congyang --- block/backup.c| 19 +-- block/io.c| 11 ++- include/block/block.h | 3 +++ trace-events | 1 +

Re: [Qemu-devel] quorum: validate vote threshold against num_children even if read-pattern is fifo

2015-08-18 Thread Wen Congyang
Ping... On 07/03/2015 02:45 PM, Wen Congyang wrote: > We need to use threshold to check if too many write operation fails. > If threshold is larger than num children, we always get write error > event even if all write operations success. > > Signed-off-by: Wen Congyang > --- > block/quorum.c |

Re: [Qemu-devel] [PATCH v3] more check for replaced node

2015-08-18 Thread Wen Congyang
Ping... On 07/17/2015 10:12 AM, Wen Congyang wrote: > We use mirror+replace to fix quorum's broken child. bs/s->common.bs > is quorum, and to_replace is the broken child. The new child is target_bs. > Without this patch, the replace node can be any node, and it can be > top BDS with BB, or another

Re: [Qemu-devel] [PATCH v5 4/4] sPAPR: Support RTAS call ibm, errinjct

2015-08-18 Thread David Gibson
On Wed, Aug 19, 2015 at 10:26:04AM +1000, Gavin Shan wrote: > On Tue, Aug 18, 2015 at 11:04:59AM -0700, Thomas Huth wrote: > >On 17/08/15 18:47, Gavin Shan wrote: > >> The patch supports RTAS call "ibm,errinjct" to allow injecting > >> EEH errors to VFIO PCI devices. The implementation is similiar

Re: [Qemu-devel] [PATCH v5 3/4] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-18 Thread David Gibson
On Wed, Aug 19, 2015 at 09:52:00AM +1000, Gavin Shan wrote: > On Tue, Aug 18, 2015 at 10:32:13AM -0700, Thomas Huth wrote: > >On 17/08/15 18:47, Gavin Shan wrote: > >> The patch supports RTAS calls "ibm,{open,close}-errinjct" to > >> manupliate the token, which is passed to RTAS call "ibm,errinjct"

Re: [Qemu-devel] [Qemu-ppc] [PATCH 19/19] ppc: Rename ELF_MACHINE to be PPC specific

2015-08-18 Thread Laurent Vivier
I'm wondering if the existing behavior is good: what I have understood is we define ppc32 guests in ppc64 target to be able to run 32bit guest with 64bit qemu, but I don't think it means an oldworld mac is able to run a ppc64 kernel. So I think we could use directly EM_PPC with e500, ppc440, virt

Re: [Qemu-devel] [PATCH 7/12] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers

2015-08-18 Thread Denis V. Lunev
On 08/18/2015 05:41 PM, Wanpeng Li wrote: On 7/3/15 8:01 PM, Denis V. Lunev wrote: From: Andrey Smetanin Added hyper-v crash msr's(HV_X64_MSR_CRASH*) data and control geters and setters. Userspace should check that such msr's available by check of KVM_CAP_HYPERV_MSR_CRASH capability. I didn'

Re: [Qemu-devel] [PATCH 7/12] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers

2015-08-18 Thread Wanpeng Li
On 7/3/15 8:01 PM, Denis V. Lunev wrote: From: Andrey Smetanin Added hyper-v crash msr's(HV_X64_MSR_CRASH*) data and control geters and setters. Userspace should check that such msr's available by check of KVM_CAP_HYPERV_MSR_CRASH capability. I didn't see the KVM_CAP_HYPERV_MSR_CRASH in this

Re: [Qemu-devel] [PATCH v5 4/4] sPAPR: Support RTAS call ibm, errinjct

2015-08-18 Thread Gavin Shan
On Tue, Aug 18, 2015 at 11:04:59AM -0700, Thomas Huth wrote: >On 17/08/15 18:47, Gavin Shan wrote: >> The patch supports RTAS call "ibm,errinjct" to allow injecting >> EEH errors to VFIO PCI devices. The implementation is similiar >> to EEH support for VFIO PCI devices: The RTAS request is captured

Re: [Qemu-devel] [PATCH v2 for 2.5 0/3] Move target- and device specific code from monitor

2015-08-18 Thread Denis V. Lunev
On 08/12/2015 04:50 AM, Denis V. Lunev wrote: The monivation of this set is simple. Recently we have proposed patch to monitor.c with specific x86 APIC HMP commands. The patchset was denied with the main motivation "No more arch specific code in monitor.c" This patchset is the first step to move

Re: [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h

2015-08-18 Thread David Gibson
On Wed, Aug 19, 2015 at 12:46:26AM +0100, Peter Maydell wrote: > On 18 August 2015 at 23:53, David Gibson wrote: > > On Tue, Aug 18, 2015 at 01:26:39PM +0100, Peter Maydell wrote: > >> Please just have a commit which does a "sync linux headers > >> from kernel version $WHATEVER". The whole point o

[Qemu-devel] [PATCH] qemu-img: Fix crash in amend invocation

2015-08-18 Thread Max Reitz
Example: $ ./qemu-img create -f qcow2 /tmp/t.qcow2 64M $ ./qemu-img amend -f qcow2 -o backing_file=/tmp/t.qcow2, -o help \ /tmp/t.qcow2 This should not crash. This actually is tested by iotest 082, but not caught due to the segmentation fault being silent (which is something that needs to be f

[Qemu-devel] QEMU produces invalid JSON due to locale-dependent code

2015-08-18 Thread Alberto Garcia
We have this code in qjson.c to produce JSON from a QFloat: QFloat *val = qobject_to_qfloat(obj); char buffer[1024]; int len; len = snprintf(buffer, sizeof(buffer), "%f", qfloat_get_double(val)); while (len > 0 && buffer[len - 1] == '0') { len--

Re: [Qemu-devel] [PATCH v5 3/4] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-18 Thread Gavin Shan
On Tue, Aug 18, 2015 at 10:32:13AM -0700, Thomas Huth wrote: >On 17/08/15 18:47, Gavin Shan wrote: >> The patch supports RTAS calls "ibm,{open,close}-errinjct" to >> manupliate the token, which is passed to RTAS call "ibm,errinjct" >> to indicate the valid context for error injection. Each VM is >>

Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added

2015-08-18 Thread Thomas Huth
On 17/08/15 16:42, Alexander Bezzubikov wrote: > Signed-off-by: Alexander Bezzubikov > --- > hw/ide/internal.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/ide/internal.h b/hw/ide/internal.h > index f2999ce..3ebc63c 100644 > --- a/hw/ide/internal.h > +++ b/hw/ide/internal.h > @

Re: [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h

2015-08-18 Thread Peter Maydell
On 18 August 2015 at 23:53, David Gibson wrote: > On Tue, Aug 18, 2015 at 01:26:39PM +0100, Peter Maydell wrote: >> Please just have a commit which does a "sync linux headers >> from kernel version $WHATEVER". The whole point of the script >> is to keep our headers completely synchronized with the

Re: [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h

2015-08-18 Thread Gavin Shan
On Tue, Aug 18, 2015 at 03:53:25PM -0700, David Gibson wrote: >On Tue, Aug 18, 2015 at 01:26:39PM +0100, Peter Maydell wrote: >> On 18 August 2015 at 02:47, Gavin Shan wrote: >> > The header file was introduced by following Linux upstream commits: >> > >> > commit ed3e81f ("powerpc/eeh: Move P

Re: [Qemu-devel] [PATCH] Add another sanity check to smp_parse() function

2015-08-18 Thread Thomas Huth
On 22/07/15 06:59, Thomas Huth wrote: > The code in smp_parse already checks the topology information for > sockets * cores * threads < cpus and bails out with an error in > that case. However, it is still possible to supply a bad configuration > the other way round, e.g. with: > > qemu-system-xx

Re: [Qemu-devel] [PULL v2] Queued TCG improvements

2015-08-18 Thread Peter Maydell
e commit 074a9925e1cfd659d5376dcaccd1436d3840e611: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2015-08-14 16:52:34 +0100) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-tcg-

Re: [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h

2015-08-18 Thread David Gibson
On Tue, Aug 18, 2015 at 01:26:39PM +0100, Peter Maydell wrote: > On 18 August 2015 at 02:47, Gavin Shan wrote: > > The header file was introduced by following Linux upstream commits: > > > > commit ed3e81f ("powerpc/eeh: Move PE state constants around") > > commit ec33d36 ("powerpc/eeh: In

[Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-18 Thread Eduardo Habkost
Migration with q35 was not possible before commit 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates an ich9-ahci device, that was marked as unmigratable. So all q35 machines before pc-q35-2.4 were unmigratable, and there's no point in keeping compatibility code for them.

[Qemu-devel] [PATCH v4 5/6] block: Drop BlockDriverState.filename

2015-08-18 Thread Max Reitz
That field is now only used during initialization of BlockDriverStates (opening images) and for error or warning messages. Performance is not that much of an issue here, so we can drop the field and replace its use by a call to bdrv_filename() or bdrv_filename_alloc(). By doing so we can ensure the

[Qemu-devel] [PATCH v4 4/6] qemu-img: Use bdrv_filename_alloc() for map

2015-08-18 Thread Max Reitz
Replaces bs->filename by the result of bdrv_filename_alloc() in the qemu-img map subcommand. Since that value is queried relatively often, however, it should be cached. Signed-off-by: Max Reitz --- qemu-img.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/qemu

[Qemu-devel] [PATCH v4 6/6] iotests: Test changed Quorum filename

2015-08-18 Thread Max Reitz
After drive-mirror replacing a Quorum child, the filename of the Quorum BDS should reflect the change. This patch replaces the existing test for whether the operation did actually exchange the BDS (which simply tested whether the new BDS existed) by a test which examines the children list contained

[Qemu-devel] [PATCH v4 3/6] block: Add bdrv_filename()

2015-08-18 Thread Max Reitz
Split the part which actually refreshes the BlockDriverState.filename field off of bdrv_refresh_filename() into a more generic function bdrv_filename(), which first calls bdrv_refresh_filename() and then stores a qemu-usable filename into the given buffer instead of BlockDriverState.filename. Sinc

[Qemu-devel] [PATCH v4 1/6] block: Change bdrv_get_encrypted_filename()

2015-08-18 Thread Max Reitz
Instead of returning a pointer to the filename, copy it into a buffer specified by the caller. Signed-off-by: Max Reitz --- block.c | 25 ++--- include/block/block.h | 2 +- monitor.c | 6 +- 3 files changed, 24 insertions(+), 9 deletions(-) d

[Qemu-devel] [PATCH v4 2/6] block: Avoid BlockDriverState.filename

2015-08-18 Thread Max Reitz
In places which directly pass a filename to the OS, we should not use the filename field at all but exact_filename instead (although the former currently equals the latter if that is set). In raw_open_common(), we do not need to access BDS.filename because we already have a local variable pointing

[Qemu-devel] [PATCH v4 0/6] block: Drop BDS.filename

2015-08-18 Thread Max Reitz
The BDS filename field is generally only used when opening disk images or emitting error or warning messages, the only exception to this rule is the map command of qemu-img. However, using exact_filename there instead should not be a problem. Therefore, we can drop the filename field from the Block

Re: [Qemu-devel] [PATCH 05/19] m68k: Remove ELF_MACHINE from cpu.h

2015-08-18 Thread Laurent Vivier
On 15/08/2015 16:28, Peter Crosthwaite wrote: > From: Peter Crosthwaite > > The only generic code relying on this is linux-user, but linux users' > default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle > this. > > The machine model bootloaders can just pass EM_68K directly, as th

Re: [Qemu-devel] [Consult] tilegx: About floating point instructions

2015-08-18 Thread Chen Gang
OK, thanks. What you said sounds reasonable to me. I shall try to send patches to qemu, firstly. :-) On 8/19/15 06:15, Peter Maydell wrote: > On 18 August 2015 at 22:29, Chen Gang wrote: >> On 8/18/15 22:32, Peter Maydell wrote: >>> On 18 August 2015 at 15:27, Chen Gang wrote: Welcome any

Re: [Qemu-devel] [Consult] tilegx: About floating point instructions

2015-08-18 Thread Peter Maydell
On 18 August 2015 at 22:29, Chen Gang wrote: > On 8/18/15 22:32, Peter Maydell wrote: >> On 18 August 2015 at 15:27, Chen Gang wrote: >>> Welcome any ideas, suggestions and completions. >> >> You should stop working on adding new features and instructions, >> and concentrate on getting a coherent

[Qemu-devel] [PATCH v2] hmp: Allow for error message hints on HMP

2015-08-18 Thread Eric Blake
Commits 7216ae3d and d2828429 disabled some error message hints, all because a change to use modern error reporting meant that the hint would be output prior to the actual error. Fix this by making hints a first-class member of Error. For example, we are now back to the pleasant: $ qemu-system-

[Qemu-devel] [PATCH v2 6/7] [RFC] Use DEFINE_MACHINE to register all machines

2015-08-18 Thread Eduardo Habkost
I am sending a single patch for all machines to get some feedback, but in the final patch series I will separate them by architecture. Signed-off-by: Eduardo Habkost --- (Sending v2 of just patch 6/7 to avoid resending the whole series) Changes v1 -> v2: * Fix trailing spaces and newlines * Don'

Re: [Qemu-devel] [Consult] tilegx: About floating point instructions

2015-08-18 Thread Chen Gang
On 8/18/15 22:32, Peter Maydell wrote: > On 18 August 2015 at 15:27, Chen Gang wrote: >> Welcome any ideas, suggestions and completions. > > You should stop working on adding new features and instructions, > and concentrate on getting a coherent set of patches for some > subset of the instruction

Re: [Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines

2015-08-18 Thread Eduardo Habkost
On Tue, Aug 18, 2015 at 12:08:53PM -0700, Eduardo Habkost wrote: [...] > -env->gregs[1] = 0; // Memory start > -env->gregs[2] = ram_size; // Memory size > -env->gregs[3] = 0; // Machine description XXX > +env->gregs[1] = 0; /* Memory start */ > +env->gregs[2] = ram_size; /* Memo

Re: [Qemu-devel] [PATCH] exec-all: Translate TCI return addresses backwards too

2015-08-18 Thread Stefan Weil
Am 18.08.2015 um 05:28 schrieb Peter Crosthwaite: > This subtraction of return addresses applies directly to TCI as well as > host-TCG. This fixes Linux boots for at least Microblaze, CRIS, ARM and > SH4 when using TCI. > > Reviewed-by: Richard Henderson > Signed-off-by: Peter Crosthwaite > ---

Re: [Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines

2015-08-18 Thread Eduardo Habkost
On Tue, Aug 18, 2015 at 12:08:53PM -0700, Eduardo Habkost wrote: > I am sending a single patch for all machines to get some feedback, but > in the final patch series I will separate them by architecture. There are some checkpatch.pl issues introduced by this (long lines and trailing spaces), I wil

Re: [Qemu-devel] [PATCH] hmp: Allow for error message hints on HMP

2015-08-18 Thread Paolo Bonzini
On 18/08/2015 11:19, Eric Blake wrote: > Commits 7216ae3d and d2828429 disabled some error message hints, > all because a change to use modern error reporting meant that the > hint would be output prior to the actual error. Fix this by making > hints a first-class member of Error. > > For examp

[Qemu-devel] [PATCH 7/7] machine: Eliminate QEMUMachine and qemu_register_machine()

2015-08-18 Thread Eduardo Habkost
The struct is not used anymore and can be eliminated. Signed-off-by: Eduardo Habkost --- include/hw/boards.h | 27 --- include/qemu/typedefs.h | 1 - include/sysemu/blockdev.h | 2 +- include/sysemu/sysemu.h | 2 +- vl.c | 37

[Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines

2015-08-18 Thread Eduardo Habkost
I am sending a single patch for all machines to get some feedback, but in the final patch series I will separate them by architecture. Cc: Richard Henderson Cc: Peter Maydell Cc: Li Guang Cc: Antony Pavlov Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Cc: Rob

[Qemu-devel] [PATCH 2/7] exynos4: Use MachineClass instead of exynos4_machines array

2015-08-18 Thread Eduardo Habkost
We don't need a QEMUMachine array to query max_cpus, if we can get the corresponding MachineClass. Cc: Peter Maydell Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Signed-off-by: Eduardo Habkost --- hw/arm/exynos4_boards.c | 4 +++- 1 file changed, 3 insertions

[Qemu-devel] [PATCH 4/7] machine: DEFINE_MACHINE macro

2015-08-18 Thread Eduardo Habkost
The macro will allow easy registration of a TYPE_MACHINE subclass, using only the machine name and a MachineClass initialization function as parameter. Signed-off-by: Eduardo Habkost --- include/hw/boards.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/hw/boards

[Qemu-devel] [PATCH 3/7] exynos4: Declare each QEMUMachine as a separate variable

2015-08-18 Thread Eduardo Habkost
This will make the code follow the same pattern used for other machines, and will make it easier to automatically convert the code to be QOM-based. Cc: Peter Maydell Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Signed-off-by: Eduardo Habkost --- hw/arm/exynos

[Qemu-devel] [PATCH 0/7] machine registration: Use QOM, eliminate QEMUMachine

2015-08-18 Thread Eduardo Habkost
This converts all code using QEMUMachine to register a QOM class directly, using a new macro: DEFINE_MACHINE. Python script used to convert all machines automatically can be seen at: https://gist.github.com/ehabkost/582fe4969205975febb2#file-qemumachine-eliminate-py Cc: Richard Henderson Cc:

[Qemu-devel] [PATCH 1/7] exynos4: Use EXYNOS4210_NCPUS instead of max_cpus on error message

2015-08-18 Thread Eduardo Habkost
The code is checking smp_cpus against EXYNOS4210_NCPUS, not against max_cpus, so use EXYNOS4210_NCPUS in the error message for consistency. Cc: Peter Maydell Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Signed-off-by: Eduardo Habkost --- hw/arm/exynos4_boards

[Qemu-devel] [PATCH 5/7] pc: Use DEFINE_MACHINE to implement DEFINE_PC_MACHINE

2015-08-18 Thread Eduardo Habkost
DEFINE_PC_MACHINE should be eventually replaced by DEFINE_MACHINE, we just need to eliminate the pc_compat_*() functions first. Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/include/hw/i386/pc.h b/incl

Re: [Qemu-devel] [PULL v3 00/19] SCSI, build, TCG, RCU, misc patches for 2015-08-12

2015-08-18 Thread Peter Maydell
On 14 August 2015 at 22:43, Paolo Bonzini wrote: > The following changes since commit cb48f67ad8c7b33c617d4f8144a27706e69fd688: > > bsd-user: Fix operand to cpu_x86_exec (2015-07-30 12:38:49 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstr

Re: [Qemu-devel] [PATCH] hmp: Allow for error message hints on HMP

2015-08-18 Thread Eric Blake
[adding some potential maintainers in cc; ./scripts/get_maintainer.pl struck out in spite of the patch touching multiple files. Maybe that means we need a MAINTAINERS update?] On 08/18/2015 11:19 AM, Eric Blake wrote: > Commits 7216ae3d and d2828429 disabled some error message hints, > all because

Re: [Qemu-devel] [PATCH 11/19] tricore: Remove ELF_MACHINE from cpu.h

2015-08-18 Thread Bastian Koppelmann
Am 15.08.2015 um 16:28 schrieb Peter Crosthwaite: From: Peter Crosthwaite The bootloader can just pass EM_TRICORE directly, as that is architecture specific code. This removes another architecture specific definition from the global namespace. Cc: Bastian Koppelmann Signed-off-by: Peter Cros

[Qemu-devel] [PATCH] hmp: Allow for error message hints on HMP

2015-08-18 Thread Eric Blake
Commits 7216ae3d and d2828429 disabled some error message hints, all because a change to use modern error reporting meant that the hint would be output prior to the actual error. Fix this by making hints a first-class member of Error. For example, we are now back to the pleasant: $ qemu-system-

[Qemu-devel] [PULL 3/3] target-alpha: Inline hw_ret

2015-08-18 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target-alpha/helper.h | 2 -- target-alpha/sys_helper.c | 8 target-alpha/translate.c | 15 ++- 3 files changed, 10 insertions(+), 15 deletions(-) diff --git a/target-alpha/helper.h b/target-alpha/helpe

[Qemu-devel] [PULL 2/3] target-alpha: Inline call_pal

2015-08-18 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target-alpha/helper.h | 1 - target-alpha/sys_helper.c | 8 target-alpha/translate.c | 33 - 3 files changed, 24 insertions(+), 18 deletions(-) diff --git a/target-alpha/helper.h b/t

[Qemu-devel] [PULL 0/3] target-alpha PALcode improvments

2015-08-18 Thread Richard Henderson
Posted and reviewed back in June, queued for 2.5 development. r~ The following changes since commit 074a9925e1cfd659d5376dcaccd1436d3840e611: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2015-08-14 16:52:34 +0100) are available in the git repository at:

[Qemu-devel] [PULL 1/3] target-alpha: Use separate TCGv temporaries for the shadow registers

2015-08-18 Thread Richard Henderson
This avoids having to manually swap them around when swapping to and from PALmode. We simply encode the shadow registers into the translation. The VMStateDescription version changes, because the meaning of "shadow" changes in the save file when in PALmode. It would be possible to fix this, but I

Re: [Qemu-devel] [PATCH v2 1/4] ahci: Separate the AHCI state structure into the header

2015-08-18 Thread John Snow
On 08/17/2015 05:40 PM, Alistair Francis wrote: > Pull the AHCI state structure out into the header. This allows > other containers to access the struct. This is required to add > the device to modern SoC containers. > > Signed-off-by: Alistair Francis > Reviewed-by: Sai Pavan Boddu > Reviewed

Re: [Qemu-devel] [PATCH v5 4/4] sPAPR: Support RTAS call ibm, errinjct

2015-08-18 Thread Thomas Huth
On 17/08/15 18:47, Gavin Shan wrote: > The patch supports RTAS call "ibm,errinjct" to allow injecting > EEH errors to VFIO PCI devices. The implementation is similiar > to EEH support for VFIO PCI devices: The RTAS request is captured > by QEMU and routed to sPAPRPHBClass::eeh_inject_error() where

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-18 Thread Richard Henderson
On 08/18/2015 02:24 AM, Artyom Tarasenko wrote: > The unoptimized case is a sequence of multiple cmp and branch > operations (likely created by a "case" statement in the original > source code), especially where cmp is in a delay slot of a branch > instruction. Interesting. > I wonder whether we

[Qemu-devel] [PATCH] target-mips: remove wrong checks for recip.fmt and rsqrt.fmt

2015-08-18 Thread Petar Jovanovic
From: Petar Jovanovic Instructions recip.{s|d} and rsqrt.{s|d} do not require 64-bit FPU neither they require any particular mode for its FPU. This patch removes the checks that may break a program that uses these instructions. Signed-off-by: Petar Jovanovic --- target-mips/translate.c |4

Re: [Qemu-devel] [PATCH v5 3/4] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-18 Thread Thomas Huth
On 17/08/15 18:47, Gavin Shan wrote: > The patch supports RTAS calls "ibm,{open,close}-errinjct" to > manupliate the token, which is passed to RTAS call "ibm,errinjct" > to indicate the valid context for error injection. Each VM is > permitted to have only one token at once and we simply have one >

Re: [Qemu-devel] [PATCH 2/2] target-alpha: Special case cmpbge with zero

2015-08-18 Thread Richard Henderson
On 08/17/2015 03:03 PM, Richard Henderson wrote: > +uint64_t c = (a - 0x0101010101010101ULL) & ~a & 0x8080808080808080ULL; Ho hum. I was mislead. This formulation is good for noticing *some* zero in a word, but not which particular bytes contain zeros. This difference is hard to spot in how

Re: [Qemu-devel] [PULL 0/3] Net patches

2015-08-18 Thread Peter Maydell
On 14 August 2015 at 16:02, Stefan Hajnoczi wrote: > The following changes since commit e95edefbd0559e1d0aa09549641b5d9af1f96fac: > > Merge remote-tracking branch > 'remotes/sstabellini/tags/xen-migration-2.4-tag' into staging (2015-08-03 > 17:33:35 +0100) > > are available in the git reposito

Re: [Qemu-devel] [PATCH v10 4/5] hw/intc: Initial implementation of vGICv3

2015-08-18 Thread Eric Auger
Hi Pavel, On 08/18/2015 03:33 PM, Pavel Fedin wrote: > This is the initial version of KVM-accelerated GICv3 support. > State load and save are not yet supported, live migration is > not possible. > > In order to get correct class name in a simpler way, gicv3_class_name() > function is implemented,

[Qemu-devel] [PATCH RFC v3 12/20] qapi: Avoid use of 'data' member of qapi unions

2015-08-18 Thread Eric Blake
qapi code generators currently create a 'void *data' member as part of the anonymous union embedded in the C struct corresponding to a qapi union. However, directly assigning to this member of the union feels a bit fishy, when we can directly use the rest of the struct instead. Signed-off-by: Eri

[Qemu-devel] [PATCH RFC v3 17/20] qapi: Change visit_type_XXX() to no longer return partial objects

2015-08-18 Thread Eric Blake
Returning a partial object on error is an invitation for a careless caller to leak memory. As no one outside the testsuite was actually relying on these semantics, it is cleaner to just document and guarantee that ALL visit_type_XXX() functions do not alter *obj when an error is encountered during

[Qemu-devel] [PATCH RFC v3 14/20] qapi: Drop useless 'data' member of unions

2015-08-18 Thread Eric Blake
Now that we no longer have any clients of the 'void *data' member injected into unions, we can drop it. Update the testsuite to prove that we no longer have a name collision. Signed-off-by: Eric Blake --- scripts/qapi-types.py | 9 - tests/qapi-schema/qapi-schema-test.

[Qemu-devel] [PATCH RFC v3 13/20] qapi: Forbid empty unions and useless alternates

2015-08-18 Thread Eric Blake
Empty unions serve no purpose, and while we compile with gcc which permits them, strict C99 forbids them. We could inject a dummy member (and in fact, we do for empty structs), but while empty structs make sense in qapi, empty unions don't add any expressiveness to the QMP language. So prohibit t

[Qemu-devel] [PATCH RFC v3 18/20] qapi: Plumb in 'box' to qapi generator lower levels

2015-08-18 Thread Eric Blake
A future patch will add support for passing a qapi union type as the 'data' of a command. But to do that, the user function for implementing the command, as called by the generated marshal command, must take the corresponding C struct as a single boxed pointer, rather than a breakdown into one par

[Qemu-devel] [PATCH RFC v3 16/20] qapi: Document visitor interfaces

2015-08-18 Thread Eric Blake
The visitor interface for mapping between QObject and qapi has formerly been documented only by reading source code, making it difficult to propose changes to either scripts/qapi*.py or to clients without knowing whether those changes would be safe. This tries to add documentation, including menti

[Qemu-devel] [PATCH RFC v3 19/20] qapi: Implement boxed structs for commands/events

2015-08-18 Thread Eric Blake
Turn on the ability to pass command and event arguments in a single boxed parameter. This patch merely tests the use of the feature on structs. With this patch, we still reject union types, and crash on { 'command':'foo', 'data': { anonymous...}, 'box':true }; that will be addressed in the next p

[Qemu-devel] [PATCH RFC v3 15/20] qapi: Remove dead visitor code

2015-08-18 Thread Eric Blake
Commit cbc95538 removed unused start_handle() and end_handle(), but forgot got remove their declarations. Commit 4e27e819 introduced optional visitor callbacks for all sorts of int types, but except for type_uint64 and type_size, none of them have ever been supplied (the generic implementation bas

[Qemu-devel] [PATCH RFC v3 20/20] qapi: Support boxed unions

2015-08-18 Thread Eric Blake
This patch completes support for boxed types, by allowing union types to be used when 'box':true is specified. It also avoids a python crash when attempting to use boxing on an anonymous type. While it was possible to support 'box':true on an empty event, it was easier to just reject missing 'dat

Re: [Qemu-devel] [PATCH v10 3/5] arm_kvm: Do not assume particular GIC type in kvm_arch_irqchip_create()

2015-08-18 Thread Eric Auger
Reviewed-by: Eric Auger On 08/18/2015 03:33 PM, Pavel Fedin wrote: > This allows to use different GIC types from v2. There are no kernels which > could advertise KVM_CAP_DEVICE_CTRL without the actual ability to create > GIC with it. > > Signed-off-by: Pavel Fedin > --- > target-arm/kvm.c | 10

[Qemu-devel] [RFC PATCH v2 5/5] ide: ATAPI-SCSI bridge transfer is treated as PIO

2015-08-18 Thread Alexander Bezzubikov
This patch is necessary because ATAPI-SCSI bridge transfer uses ide_transfer_start/stop and ide_data_read function check if PIO transfer is running, so bridge function should be added to this check Signed-off-by: Alexander Bezzubikov --- hw/ide/core.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Qemu-devel] [RFC PATCH v2 2/5] ide: necessary checks corrected to treat ATAPI-SCSI bridge as CDROM

2015-08-18 Thread Alexander Bezzubikov
hw/ide/qdev.c: corrected to treat bridge as CDROM hw/ide/core.c: same corrections as in qdev.c hw/ide/atapi.c: skip some CDROM checks because bridge has only fake drive Signed-off-by: Alexander Bezzubikov --- hw/ide/atapi.c | 4 +++- hw/ide/core.c | 24 ++-- hw/ide/qdev.c

[Qemu-devel] [RFC PATCH v2 1/5] ide: ATAPI-SCSI bridge TypeInfo and init function created

2015-08-18 Thread Alexander Bezzubikov
Signed-off-by: Alexander Bezzubikov --- hw/ide/bridge.h | 9 + hw/ide/internal.h | 4 +++- hw/ide/qdev.c | 41 + 3 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 hw/ide/bridge.h diff --git a/hw/ide/bridge.h b/hw/ide/brid

[Qemu-devel] [RFC PATCH v2 3/5] ATAPI-SCSI bridge functions created an can be used by bridge

2015-08-18 Thread Alexander Bezzubikov
ide: bridge functions created ide: Makefile corrected due to bridge creation scsi: added function to enable bridge send SCSI requests ide: bridge can now forward requests to SCSI ide: bridge functions assigned to SCSIBusInfo Signed-off-by: Alexander Bezzubikov --- hw/ide/Makefile.objs | 2 +-

Re: [Qemu-devel] [PATCH v10 1/5] hw/intc: Implement GIC-500 base class

2015-08-18 Thread Eric Auger
On 08/18/2015 03:33 PM, Pavel Fedin wrote: > From: Shlomo Pongratz > > This class is to be used by both software and KVM implementations of GICv3 > > Currently it is mostly a placeholder, but in future it is supposed to hold > qemu's representation of GICv3 state, which is necessary for migratio

Re: [Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some reusable vGIC code

2015-08-18 Thread Eric Auger
Hi Pavel, On 08/18/2015 03:33 PM, Pavel Fedin wrote: > These functions are useful also for vGICv3 implementation. Make them > accessible > from within other modules. I think it would be worth justifying the changes in signature: removal of GICState* due to the introduction of GICV3State and also

[Qemu-devel] [RFC PATCH v2 4/5] scsi: SCSIDiskReq declaration moved to header

2015-08-18 Thread Alexander Bezzubikov
Signed-off-by: Alexander Bezzubikov --- hw/scsi/scsi-disk.c| 12 include/hw/scsi/scsi.h | 13 + 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index f67d816..9d5f0a4 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/

[Qemu-devel] [RFC PATCH v2 0/5] QEMU ATAPI-SCSI bridge GSoC project

2015-08-18 Thread Alexander Bezzubikov
This is my QEMU Google Summer of Code project. Here I introduce new device - ATAPI-SCSI bridge. Its purpose is to unify IDE ATAPI CD-ROM emulation with SCSI CD-ROM emulation to reduce code duplication and squash bugs. It's purpose is simple - it just forwards ATAPI commands to SCSI side for parsing

Re: [Qemu-devel] Help debugging a regression in KVM Module

2015-08-18 Thread Peter Lieven
> Am 18.08.2015 um 17:25 schrieb Radim Krčmář : > > 2015-08-18 16:54+0200, Peter Lieven: >> After some experiments I was able to find out the bad commit that introduced >> the regression: >> >> commit f30ebc312ca9def25650b4e1d01cdb425c310dca >> Author: Radim Krčmář >> Date: Thu Oct 30 15:06

Re: [Qemu-devel] Help debugging a regression in KVM Module

2015-08-18 Thread Radim Krčmář
2015-08-18 16:54+0200, Peter Lieven: > After some experiments I was able to find out the bad commit that introduced > the regression: > > commit f30ebc312ca9def25650b4e1d01cdb425c310dca > Author: Radim Krčmář > Date: Thu Oct 30 15:06:47 2014 +0100 > > It seems that this optimisation is not wo

Re: [Qemu-devel] [PATCH v7 09/11] target-i386: exception handling for seg_helper functions

2015-08-18 Thread Richard Henderson
On 07/10/2015 02:57 AM, Pavel Dovgalyuk wrote: > This patch fixes exception handling for seg_helper functions. > > Signed-off-by: Pavel Dovgalyuk > --- > target-i386/helper.h |4 > target-i386/seg_helper.c | 616 > -- > target-i386/translate

Re: [Qemu-devel] [PATCH 4/4] target-sparc: Convert to VMStateDescription

2015-08-18 Thread Paolo Bonzini
On 10/08/2015 05:34, Peter Maydell wrote: > -// if env->cwp == env->nwindows - 1, this will set the ins of the last > -// window as the outs of the first window > -cpu_set_cwp(env, env->cwp); Out of curiosity, what migrates env->cwp for SPARC64? Paolo

Re: [Qemu-devel] [PATCH v1 3/3] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP

2015-08-18 Thread Alistair Francis
On Sat, Aug 15, 2015 at 2:29 PM, Peter Crosthwaite wrote: > On Mon, Jul 27, 2015 at 11:37 AM, Alistair Francis > wrote: >> Connect the Sysbus AHCI device to ZynqMP. >> >> Signed-off-by: Alistair Francis >> Reviewed-by: Sai Pavan Boddu >> --- >> hw/arm/xlnx-zynqmp.c | 20 +

Re: [Qemu-devel] [PATCH] exec-all: Translate TCI return addresses backwards too

2015-08-18 Thread Paolo Bonzini
On 17/08/2015 20:28, Peter Crosthwaite wrote: > This subtraction of return addresses applies directly to TCI as well as > host-TCG. This fixes Linux boots for at least Microblaze, CRIS, ARM and > SH4 when using TCI. > > Reviewed-by: Richard Henderson > Signed-off-by: Peter Crosthwaite > --- >

[Qemu-devel] [PULL v2] Queued TCG improvements

2015-08-18 Thread Richard Henderson
2:34 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20150818 for you to fetch changes up to 2e58c34d4c9c61f311b5468f05b0ad63b77645c1: tcg/aarch64: Use softmmu fast path for unaligned accesses (

Re: [Qemu-devel] Help debugging a regression in KVM Module

2015-08-18 Thread Peter Lieven
Am 14.08.2015 um 22:01 schrieb Alex Bennée: Peter Lieven writes: Hi, some time a go I stumbled across a regression in the KVM Module that has been introduced somewhere between 3.17 and 3.19. I have a rather old openSUSE guest with an XFS filesystem which realiably crashes after some live m

Re: [Qemu-devel] Runtime-modified DIMMs and live migration issue

2015-08-18 Thread Andrey Korolyov
"Fixed" with cherry-pick of the 7a72f7a140bfd3a5dae73088947010bfdbcf6a40 and its predecessor 7103f60de8bed21a0ad5d15d2ad5b7a333dda201. Of course this is not a real fix as the only race precondition is shifted/disappeared by a clear assumption. Though there are not too many hotplug users around, I h

  1   2   >