Re: [Qemu-devel] [PATCH v3 06/12] qga: move option parsing to separate function

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Move option parsing out of giant main(). Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/main.c | 165

Re: [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 09:07 PM, Marc-André Lureau wrote: Hi On Wed, Aug 26, 2015 at 7:55 PM, Denis V. Lunev den-li...@parallels.com wrote: it would be much better to declare this helper as split_list(const gchar *str, ... and make temporary copy of parameter inside. Without this the function as NASTY

Re: [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function

2015-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2015 at 8:30 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: the list must then be g_list_free_full() Actually, the ga_command_blacklist_init() doesn't dup the string, so it will have to do it too..tbh, I don't mind either way. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH] block/nfs: fix calculation of allocated file size

2015-08-26 Thread Jeff Cody
On Thu, Aug 20, 2015 at 12:46:47PM +0200, Peter Lieven wrote: st.st_blocks is always counted in 512 byte units. Do not use st.st_blksize as multiplicator which may be larger. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block/nfs.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Peter Lieven
Am 26.08.2015 um 17:54 schrieb Eduardo Habkost: On Mon, Aug 24, 2015 at 11:17:04AM +0200, Peter Lieven wrote: this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help output. The idea is to know a priory which CPU modules can be exposed to the user without

Re: [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 09:30 PM, Marc-André Lureau wrote: Hi On Wed, Aug 26, 2015 at 8:23 PM, Denis V. Lunev den-li...@parallels.com wrote: I think that this side effect is visible if the code remains in place and becomes invisible since you move it to the function. This could create problem if

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Peter Maydell
On 26 August 2015 at 18:16, Programmingkid programmingk...@gmail.com wrote: That is assuming they have the time and/or the interest in solving this problem. I suppose giving them some time to respond would be reasonable. I'm thinking if no consensus has been reached in one weeks time

Re: [Qemu-devel] [PATCH v3 10/12] qga: add an optionnal qemu-ga.conf system configuration

2015-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2015 at 8:41 PM, Denis V. Lunev den-li...@parallels.com wrote: sequential calling of config_load/config_parse means memory leak in config_parse if the option is present in the file and overwritten during parsing. true, I'll add some g_free() calls. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH v3 11/12] qga: add --dump-conf option

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com This new option allows to review the agent configuration, and ease the task of writing a configuration file. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by:

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2015 at 08:46:42PM +0200, Peter Lieven wrote: Am 26.08.2015 um 20:38 schrieb Eduardo Habkost: On Mon, Aug 24, 2015 at 09:36:23PM +0200, Peter Lieven wrote: Am 24.08.2015 um 17:46 schrieb Eric Blake: On 08/24/2015 03:17 AM, Peter Lieven wrote: this patch adds a probe that

Re: [Qemu-devel] QEMU developers on DebConf15?

2015-08-26 Thread Stefan Weil
Am 05.08.2015 um 13:08 schrieb Peter Maydell: If there are multiple QEMU maintainers going to Debconf, it would be great if you could arrange to meet up and sign each others' GPG keys at some point -- that would help us increase the web of trust for signed pull requests. Done with three QEMU

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Jeff Cody
On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote: On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at 06:31:57PM +0200, Markus Armbruster wrote: Did you drop cc's intentionally? I put them right back. Programmingkid programmingk...@gmail.com writes:

[Qemu-devel] [PATCH v2 4/7] arm: clarify the use of muldiv64()

2015-08-26 Thread Laurent Vivier
muldiv64() is used to convert microseconds into CPU ticks. But it is not clear and not commented. This patch uses macro to clearly identify what is used: time, CPU frequency and ticks. For an elapsed time and a given frequency, we compute how many ticks we have. Signed-off-by: Laurent Vivier

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 09:41 PM, Marc-André Lureau wrote: On Wed, Aug 26, 2015 at 8:27 PM, Denis V. Lunev den-li...@parallels.com wrote: lets consider this patch. You have done 2 things: - changed initialisation order and dropped nasty temporary variables - introduced alloc/free code But in the next

Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files

2015-08-26 Thread Jeff Cody
On Wed, Aug 26, 2015 at 08:49:06PM +0200, Peter Lieven wrote: Am 26.08.2015 um 17:31 schrieb Jeff Cody: On Mon, Aug 24, 2015 at 10:13:16PM +0200, Max Reitz wrote: On 24.08.2015 21:34, Peter Lieven wrote: Am 24.08.2015 um 20:39 schrieb Max Reitz: On 24.08.2015 10:06, Peter Lieven wrote:

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Peter Lieven
Am 26.08.2015 um 21:00 schrieb Eduardo Habkost ehabk...@redhat.com: On Wed, Aug 26, 2015 at 08:46:42PM +0200, Peter Lieven wrote: Am 26.08.2015 um 20:38 schrieb Eduardo Habkost: On Mon, Aug 24, 2015 at 09:36:23PM +0200, Peter Lieven wrote: Am 24.08.2015 um 17:46 schrieb Eric Blake: On

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Eduardo Habkost
On Mon, Aug 24, 2015 at 09:36:23PM +0200, Peter Lieven wrote: Am 24.08.2015 um 17:46 schrieb Eric Blake: On 08/24/2015 03:17 AM, Peter Lieven wrote: this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help output. The idea is to know a priory which

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Peter Lieven
Am 26.08.2015 um 20:38 schrieb Eduardo Habkost: On Mon, Aug 24, 2015 at 09:36:23PM +0200, Peter Lieven wrote: Am 24.08.2015 um 17:46 schrieb Eric Blake: On 08/24/2015 03:17 AM, Peter Lieven wrote: this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help

[Qemu-devel] [ARM SMBIOS V5 PATCH 1/2] smbios: add smbios 3.0 support

2015-08-26 Thread Wei Huang
This patch adds support for SMBIOS 3.0 entry point. When caller invokes smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then smbios_get_tables() will return the entry point table in right format. Acked-by: Gabriel Somlo so...@cmu.edu Tested-by: Gabriel Somlo so...@cmu.edu

[Qemu-devel] [ARM SMBIOS V5 PATCH 2/2] smbios: implement smbios support for mach-virt

2015-08-26 Thread Wei Huang
This patch generates smbios tables for ARM mach-virt. Also add CONFIG_SMBIOS=y for ARM default config. Acked-by: Gabriel Somlo so...@cmu.edu Tested-by: Gabriel Somlo so...@cmu.edu Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Shannon Zhao shannon.z...@linaro.org Tested-by: Leif

Re: [Qemu-devel] [PATCH] block: Override the driver in the filename with the user-specified one

2015-08-26 Thread Alberto Garcia
On Wed 26 Aug 2015 04:53:06 PM CEST, Max Reitz wrote: Yet another thing is the problem described in the patch's commit message. Why and how is the driver option inherited by the snapshot? I think you're right and my description was wrong, this happens before the snapshot is created, when

[Qemu-devel] [PATCH v2 0/2] rtl8139: Fix buffer overflow in standard mode

2015-08-26 Thread Vladislav Yasevich
When rtl8139 card is running in standard mode, it is very easy to overlflow and the receive buffer and get into a siutation where all packets are dropped. Simply reproduction case is to ping the guest from the host with 6500 byte packets. There are actually 2 problems here. 1) When the

[Qemu-devel] [PATCH 1/2] rtl8139: Do not consume the packet during overflow in standard mode.

2015-08-26 Thread Vladislav Yasevich
When operation in standard mode, we currently return the size of packet during buffer overflow. This consumes the overflow packet. Return 0 instead so we can re-process the overflow packet when we have room. This fixes issues with lost/dropped fragments of large messages. Signed-off-by:

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com A following patch will return allocated string. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/main.c | 57

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Marc-André Lureau
Hi - Original Message - On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com A following patch will return allocated string. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by: Michael Roth

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote: On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at 06:31:57PM +0200, Markus Armbruster wrote: Did you drop cc's intentionally? I put them right back.

Re: [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function

2015-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2015 at 8:23 PM, Denis V. Lunev den-li...@parallels.com wrote: I think that this side effect is visible if the code remains in place and becomes invisible since you move it to the function. This could create problem if somebody will reuse this call. what about replacing it

Re: [Qemu-devel] [PATCH v3 09/12] qga: free a bit more

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Now that main() has a single exit point, we can free a few more allocations. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com --- qga/main.c | 6 -- 1 file changed,

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Marc-André Lureau
On Wed, Aug 26, 2015 at 8:27 PM, Denis V. Lunev den-li...@parallels.com wrote: lets consider this patch. You have done 2 things: - changed initialisation order and dropped nasty temporary variables - introduced alloc/free code But in the next patch each line with alloc/free code will be

Re: [Qemu-devel] [PATCH v3 10/12] qga: add an optionnal qemu-ga.conf system configuration

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Learn to configure the agent with a system configuration. This may simplify command-line handling, especially when the blacklist is long. Among the other benefits, this may

[Qemu-devel] [ARM SMBIOS V5 PATCH 0/2]SMBIOS Support for ARM

2015-08-26 Thread Wei Huang
SMBIOS tables present userful system hardware info to management applications, such as DMI tools. Even though SMBIOS was originally developed for Intel x86, it has been extended to both Itanium and ARM (32bit 64bit). More and more ARM server releases, such as RHEL Server for ARM, start to

[Qemu-devel] [PULL 0/1] tci queue

2015-08-26 Thread Stefan Weil
The following changes since commit 47c9dfee808f9455d732aea7c4390ad0972bbd84: Merge remote-tracking branch 'remotes/kraxel/tags/pull-cve-2015-5225-20150826-1' into staging (2015-08-26 17:45:09 +0100) are available in the git repository at: git://qemu.weilnetz.de/qemu.git tags/pull-tci

[Qemu-devel] [PULL 1/1] exec-all: Translate TCI return addresses backwards too

2015-08-26 Thread Stefan Weil
From: Peter Crosthwaite crosthwaitepe...@gmail.com This subtraction of return addresses applies directly to TCI as well as host-TCG. This fixes Linux boots for at least Microblaze, CRIS, ARM and SH4 when using TCI. [sw: Removed indentation for preprocessor statement] [sw: The patch also fixes

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-26 Thread Richard Henderson
On 08/26/2015 09:17 AM, Artyom Tarasenko wrote: After some debugging I think it's caused by memory faults. On every MMU miss / access fault TB is re-translated multiple times till the faulting instruction is found. That shouldn't happen. Are you certain it's not multiple MMU misses/faults?

[Qemu-devel] [Bug 1488363] Re: qemu 2.4.0 hangs using vfio for pci passthrough of graphics card

2015-08-26 Thread Peter Maloney
I ran a bisect, and here's the result: b8eb5512fd8a115f164edbbe897cdf8884920ccb is the first bad commit commit b8eb5512fd8a115f164edbbe897cdf8884920ccb Author: Nadav Amit na...@cs.technion.ac.il Date: Mon Apr 13 02:32:08 2015 +0300 target-i386: disable LINT0 after reset Due to

Re: [Qemu-devel] [PATCH v3 07/12] qga: fill default options in main()

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Fill all default options during main(). This is a preparation patch to allow to dump the configuration. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by:

Re: [Qemu-devel] [PATCH v2 0/3] SysFS driver for QEMU fw_cfg device

2015-08-26 Thread Christopher Covington
Hi Gabriel, On 08/19/2015 04:49 PM, Gabriel L. Somlo wrote: Hi Ard, On Wed, Aug 19, 2015 at 11:42:02AM +0200, Ard Biesheuvel wrote: (missed some cc's) On 19 August 2015 at 11:38, Ard Biesheuvel ard.biesheu...@linaro.org wrote: From: Gabriel L. Somlo so...@cmu.edu Several different

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 09:17 PM, Marc-André Lureau wrote: Hi - Original Message - On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com A following patch will return allocated string. Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v3 11/12] qga: add --dump-conf option

2015-08-26 Thread Marc-André Lureau
- Original Message - On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com This new option allows to review the agent configuration, and ease the task of writing a configuration file. Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v3 12/12] qga: start a man page

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Add a simple man page for the qemu agent. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile | 14

[Qemu-devel] [PATCH 2/2] rtl8139: correctly track full receive buffer in standard mode

2015-08-26 Thread Vladislav Yasevich
In standard operation mode, when the receive ring buffer is full, the buffer actually appears empty to the driver since the RxBufAddr (the location we wirte new data to) and RxBufPtr (the location guest would stat reading from) are the same. As a result, the call to rtl8139_RxBufferEmpty ends up

[Qemu-devel] [PATCH v2 6/7] bt: remove muldiv64()

2015-08-26 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds. As

Re: [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function

2015-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2015 at 7:55 PM, Denis V. Lunev den-li...@parallels.com wrote: it would be much better to declare this helper as split_list(const gchar *str, ... and make temporary copy of parameter inside. Without this the function as NASTY side-effect and trashes the string passed in.

Re: [Qemu-devel] MTTCG next version?

2015-08-26 Thread Emilio G. Cota
On Wed, Aug 26, 2015 at 14:18:24 +0200, Frederic Konrad wrote: Do that make sense? A few decisions here don't make that much sense to me, but maybe I'm missing context: I'm trying to do the next version of the MTTCG work: I would like to rebase on Alvise atomic instruction branch: -

Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files

2015-08-26 Thread Peter Lieven
Am 26.08.2015 um 17:31 schrieb Jeff Cody: On Mon, Aug 24, 2015 at 10:13:16PM +0200, Max Reitz wrote: On 24.08.2015 21:34, Peter Lieven wrote: Am 24.08.2015 um 20:39 schrieb Max Reitz: On 24.08.2015 10:06, Peter Lieven wrote: If the file is readonly its not expected to grow so save the

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2015 at 08:38:35PM +0200, Peter Lieven wrote: Am 26.08.2015 um 17:54 schrieb Eduardo Habkost: On Mon, Aug 24, 2015 at 11:17:04AM +0200, Peter Lieven wrote: this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help output. The idea is to

Re: [Qemu-devel] [PATCH v2 4/8] s390x: Dump storage keys qmp command

2015-08-26 Thread Jason J. Herne
On 08/25/2015 12:51 PM, Eric Blake wrote: On 08/25/2015 10:10 AM, Cornelia Huck wrote: From: Jason J. Herne jjhe...@linux.vnet.ibm.com Provide a dump-skeys qmp command to allow the end user to dump storage keys. This is useful for debugging problems with guest storage key support within Qemu

Re: [Qemu-devel] [PATCH v3 08/12] qga: move agent run in a separate function

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Once the options are populated, move the running state to a run_agent() function. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by: Michael Roth

Re: [Qemu-devel] [PATCH v2 RFC 0/8] block: persistent dirty bitmaps

2015-08-26 Thread Vladimir Sementsov-Ogievskiy
On 12.06.2015 13:36, Stefan Hajnoczi wrote: On Fri, Jun 12, 2015 at 12:58:35PM +0300, Denis V. Lunev wrote: On 11/06/15 23:06, Stefan Hajnoczi wrote: The load/store API is not scalable when bitmaps are 1 MB or larger. For example, a 500 GB disk image with 64 KB granularity requires a 1 MB

Re: [Qemu-devel] Created virtio-vsock wiki page

2015-08-26 Thread Christoffer Dall
On Tue, Aug 25, 2015 at 04:43:13PM +0100, Stefan Hajnoczi wrote: I have created a wiki page for virtio-vsock. It links to my git repos and the draft virtio specification: http://qemu-project.org/Features/VirtioVsock I'll expand and update it over the coming days and weeks. Please let me

Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code

2015-08-26 Thread Gerd Hoffmann
Hi, It seems the only thing that we really care about being localized is the messages catalogue, so the GTK UI gets internationalization in its menus / dialogs / etc. As such I think that we should do the opposite of (C). ie run every LC_* in the C locale, except for LC_MESSAGES which

Re: [Qemu-devel] Should we auto-generate IDs? (was: [PATCH] qdev-monitor.c: Add device id generation)

2015-08-26 Thread Daniel P. Berrange
On Tue, Aug 25, 2015 at 02:38:17PM +0200, Markus Armbruster wrote: You're proposing to revise a qdev design decision, namely the purpose of IDs. This has been discussed before, and IDs remained unchanged. Perhaps it's time to revisit this issue. Cc'ing a few more people. Relevant prior

[Qemu-devel] [PATCH 2/5] block: Drop drv parameter from bdrv_open()

2015-08-26 Thread Max Reitz
Now that this parameter is effectively unused, we can drop it and just pass NULL on to bdrv_open_inherit(). Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 9 - block/block-backend.c | 2 +- block/parallels.c | 2 +- block/qcow.c | 2 +- block/qcow2.c

[Qemu-devel] [PATCH 5/5] block: Drop bdrv_find_whitelisted_format()

2015-08-26 Thread Max Reitz
It is unused by now, so we can drop it. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 7 --- include/block/block.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/block.c b/block.c index 434f43c..461eb94 100644 --- a/block.c +++ b/block.c @@ -313,13 +313,6 @@

[Qemu-devel] [PATCH 3/5] block: Drop drv parameter from bdrv_open_inherit()

2015-08-26 Thread Max Reitz
Now that this parameter is effectively unused, we can drop it and just pass NULL to bdrv_fill_options(). Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/block.c b/block.c index ac89487..8aa5f25 100644

Re: [Qemu-devel] [PATCH] Add another sanity check to smp_parse() function

2015-08-26 Thread Eduardo Habkost
On Wed, Jul 22, 2015 at 03:59:50PM +0200, Thomas Huth wrote: The code in smp_parse already checks the topology information for sockets * cores * threads cpus and bails out with an error in that case. However, it is still possible to supply a bad configuration the other way round, e.g. with:

[Qemu-devel] [PULL 0/1] vnc: fix memory corruption (CVE-2015-5225)

2015-08-26 Thread Gerd Hoffmann
repository at: git://git.kraxel.org/qemu tags/pull-cve-2015-5225-20150826-1 for you to fetch changes up to eb8934b0418b3b1d125edddc4fc334a54334a49b: vnc: fix memory corruption (CVE-2015-5225) (2015-08-26 17:54:33 +0200) vnc: fix memory

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at 06:31:57PM +0200, Markus Armbruster wrote: Did you drop cc's intentionally? I put them right back. Programmingkid programmingk...@gmail.com writes: On Aug 25, 2015, at 8:38 AM, Markus Armbruster wrote: You're

[Qemu-devel] [PATCH v2 5/7] hpet: remove muldiv64()

2015-08-26 Thread Laurent Vivier
hpet defines a clock period in femtoseconds but then converts it to nanoseconds to use the internal timers. We can define the period in nanoseconds and use it directly, this allows to remove muldiv64(). We only need to convert the period to femtoseconds to put it in internal hpet capability

[Qemu-devel] [PATCH v2 7/7] net: remove muldiv64()

2015-08-26 Thread Laurent Vivier
muldiv64() is used to convert nanoseconds to microseconds. x = muldiv64(qemu_clock_get_ns(..), 100, get_ticks_per_sec()); As get_ticks_per_sec() is 10^9, it can be replaced by: x = qemu_clock_get_us(..); Signed-off-by: Laurent Vivier lviv...@redhat.com --- v2: use

Re: [Qemu-devel] [RESEND PATCH v9 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2015 at 11:27:08AM -0400, Paolo Bonzini wrote: [...] +if (tcg_enabled()) { +memory_region_add_subregion_overlap(cpu-cpu_as_root, +apic-apicbase +

Re: [Qemu-devel] [PATCH v8 00/11] Add a netfilter object and netbuffer filter

2015-08-26 Thread Markus Armbruster
Yang Hongyang yan...@cn.fujitsu.com writes: This patch add a new object netfilter, capture all network packets. Also implement a netbuffer based on this object. the buffer netfilter could be used by VM FT solutions like MicroCheckpointing, to buffer/release packets. Or to simulate packet

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 12:31 PM, Markus Armbruster wrote: Did you drop cc's intentionally? I put them right back. Sorry I didn't think they would care so I removed them. Will keep them in the loop for now on. Programmingkid programmingk...@gmail.com writes: On Aug 25, 2015, at 8:38 AM,

Re: [Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-08-26 Thread Chris Metcalf
I have queued both this and the 06/33 patch in the linux-tile tree as a single patch for the kernel when the 4.3 merge window opens, with Richard's Reported-By. Thanks! Both of these appear to be cut-and-paste errors from the tilepro versions of the files. On 08/24/2015 12:17 PM, Richard

Re: [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com The function is going to be reused in a later patch. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/main.c

Re: [Qemu-devel] [PATCH v3 04/12] qga: rename 'path' to 'channel_path'

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com 'path' is already a global function, rename the variable since it's going to be in global scope in a later patch. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com

[Qemu-devel] [PATCH v2 0/7] remove useless muldiv64()

2015-08-26 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by

[Qemu-devel] [PATCH v2 1/7] PCI: remove muldiv64()

2015-08-26 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by

[Qemu-devel] [PATCH v2 2/7] mips: remove muldiv64()

2015-08-26 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Eduardo Habkost
On Mon, Aug 24, 2015 at 11:17:04AM +0200, Peter Lieven wrote: this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help output. The idea is to know a priory which CPU modules can be exposed to the user without loosing any feature flags. Signed-off-by:

Re: [Qemu-devel] [PATCH v8 10/11] filter/buffer: update command description and help

2015-08-26 Thread Markus Armbruster
Yang Hongyang yan...@cn.fujitsu.com writes: now that we have a buffer netfilter, update the command description and help. Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com CC: Luiz Capitulino lcapitul...@redhat.com CC: Markus Armbruster arm...@redhat.com --- v8: add more description for

Re: [Qemu-devel] [FIX PATCH] pc-dimm: Fail pc-dimm realization for invalid nodes in non-NUMA configuration

2015-08-26 Thread Eduardo Habkost
Applied to the numa tree, with the following changes in the commit message: Subject was changed to: pc-dimm: Fail realization for invalid nodes in non-NUMA config to make it shorter. On Fri, Jul 17, 2015 at 06:19:40PM +0530, Bharata B Rao wrote: pc_dimm_realize() validates the NUMA node to

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Markus Armbruster
Did you drop cc's intentionally? I put them right back. Programmingkid programmingk...@gmail.com writes: On Aug 25, 2015, at 8:38 AM, Markus Armbruster wrote: You're proposing to revise a qdev design decision, namely the purpose of IDs. This has been discussed before, and IDs remained

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-26 Thread Serge Hallyn
** Changed in: qemu (Ubuntu Trusty) Importance: Medium = High ** Changed in: qemu (Ubuntu Trusty) Assignee: (unassigned) = Serge Hallyn (serge-hallyn) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Jeff Cody
On Wed, Aug 26, 2015 at 06:31:57PM +0200, Markus Armbruster wrote: Did you drop cc's intentionally? I put them right back. Programmingkid programmingk...@gmail.com writes: On Aug 25, 2015, at 8:38 AM, Markus Armbruster wrote: You're proposing to revise a qdev design decision, namely

Re: [Qemu-devel] Should we auto-generate IDs? (was: [PATCH] qdev-monitor.c: Add device id generation)

2015-08-26 Thread Daniel P. Berrange
On Wed, Aug 26, 2015 at 01:46:43PM -0400, Programmingkid wrote: On Aug 26, 2015, at 1:28 PM, Daniel P. Berrange wrote: On Tue, Aug 25, 2015 at 02:38:17PM +0200, Markus Armbruster wrote: You're proposing to revise a qdev design decision, namely the purpose of IDs. This has been

Re: [Qemu-devel] [PULL 0/1] vnc: fix memory corruption (CVE-2015-5225)

2015-08-26 Thread Peter Maydell
' into staging (2015-08-25 16:24:06 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-cve-2015-5225-20150826-1 for you to fetch changes up to eb8934b0418b3b1d125edddc4fc334a54334a49b: vnc: fix memory corruption (CVE-2015-5225) (2015-08-26 17:54:33 +0200

[Qemu-devel] [PATCH v2 3/7] openrisc: remove muldiv64()

2015-08-26 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by

Re: [Qemu-devel] [PATCH v2] virtio dataplane: adapt dataplane for virtio Version 1

2015-08-26 Thread Cornelia Huck
On Wed, 26 Aug 2015 15:24:42 +0200 Pierre Morel pmo...@linux.vnet.ibm.com wrote: Let dataplane allocate different region for the desc/avail/used s/region/regions/ ring regions. Signed-off-by: Pierre Morel pmo...@linux.vnet.ibm.com Acked-by: Greg Kurz gk...@linux.vnet.ibm.com Tested-by:

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-26 Thread Artyom Tarasenko
Hi Richard, On Sun, Aug 23, 2015 at 2:41 AM, Richard Henderson r...@twiddle.net wrote: On Aug 22, 2015 9:45 AM, Artyom Tarasenko atar4q...@gmail.com wrote: For my test case tcg-indirect brings more performance gain than for Dennis: git master: 18m31s tcg-indirect: 16m50s #undef

Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support

2015-08-26 Thread Wei Huang
On 08/25/2015 11:01 AM, Peter Maydell wrote: On 25 August 2015 at 16:59, Wei Huang w...@redhat.com wrote: On 08/25/2015 10:29 AM, Leif Lindholm wrote: Wei - is there actually any particular point in renaming this structure? In all versions of the specification before 3.0, this was only known

[Qemu-devel] [PULL 1/1] vnc: fix memory corruption (CVE-2015-5225)

2015-08-26 Thread Gerd Hoffmann
The _cmp_bytes variable added by commit bea60dd ui/vnc: fix potential memory corruption issues can become negative. Result is (possibly exploitable) memory corruption. Reason for that is it uses the stride instead of bytes per scanline to apply limits. For the server surface is is actually

Re: [Qemu-devel] [PULL 0/1] vnc: fix memory corruption (CVE-2015-5225)

2015-08-26 Thread Peter Maydell
' into staging (2015-08-25 16:24:06 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-cve-2015-5225-20150826-1 for you to fetch changes up to eb8934b0418b3b1d125edddc4fc334a54334a49b: vnc: fix memory corruption (CVE-2015-5225) (2015-08-26 17:54:33 +0200

Re: [Qemu-devel] [PATCH v5 3/9] crypto: introduce new base module for TLS credentials

2015-08-26 Thread Eric Blake
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote: Introduce a QCryptoTLSCreds class to act as the base class for storing TLS credentials. This will be later subclassed to provide handling of anonymous and x509 credential types. The subclasses will be user creatable objects, so instances can be

[Qemu-devel] [PATCH 0/5] block: Drop drv parameter from bdrv_open()

2015-08-26 Thread Max Reitz
We don't really need that parameter, so let's drop it. Doing so may even fix some bugs, see http://lists.nongnu.org/archive/html/qemu-block/2015-08/msg00171.html. In the course of writing this series, I had to decide whether the make sure all callers of bdrv_find_whitelisted_format() would still

[Qemu-devel] [PATCH 1/5] block: Always pass NULL as drv for bdrv_open()

2015-08-26 Thread Max Reitz
Change all callers of bdrv_open() to pass the driver name in the options QDict instead of passing its BlockDriver pointer. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 24 ++-- block/qcow2.c | 16 - block/vvfat.c | 8 +-- blockdev.c| 72

[Qemu-devel] [PATCH 4/5] block: Drop drv parameter from bdrv_fill_options()

2015-08-26 Thread Max Reitz
Now that this parameter is effectively unused, we can drop it and change the function accordingly. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 59 ++- 1 file changed, 22 insertions(+), 37 deletions(-) diff --git a/block.c

Re: [Qemu-devel] [PATCH v3 01/12] qga: misc spelling

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Denis V. Lunev den@openvz s/den@openvz/d...@openvz.org/

[Qemu-devel] [PATCH] target-i386: Enable check mode by default

2015-08-26 Thread Eduardo Habkost
Current default behavior of QEMU is to silently disable features that are not supported by the host when a CPU model is requested in the command-line. This means that in addition to risking breaking guest ABI by default, we are silent about it. I would like to enable enforce by default, but this

Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support

2015-08-26 Thread Leif Lindholm
Hi Wei, On Wed, Aug 26, 2015 at 11:41:26AM -0500, Wei Huang wrote: While fixing up the patches, I started to lean towards keeping -21 in smbios-entry-point naming. Here are my points: 1) It is very easy to get confused the union SmbiosEntryPoint with struct smbios_entry_point if we remove

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-26 Thread Andrey Korolyov
On Thu, May 14, 2015 at 4:42 PM, Andrey Korolyov and...@xdel.ru wrote: On Wed, Aug 27, 2014 at 9:43 AM, Chris Friesen chris.frie...@windriver.com wrote: On 08/25/2014 03:50 PM, Chris Friesen wrote: I think I might have a glimmering of what's going on. Someone please correct me if I get

Re: [Qemu-devel] [PATCH 7/7] maint: avoid useless if (foo) free(foo) pattern

2015-08-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 08/26/2015 06:02 AM, Markus Armbruster wrote: Daniel P. Berrange berra...@redhat.com writes: The free() and g_free() functions both happily accept NULL on any platform QEMU builds on. Do systems where free(NULL) doesn't work even exist? Even C89

Re: [Qemu-devel] [PATCH 10/10] machine: Set MachineClass::name automatically

2015-08-26 Thread Marcel Apfelbaum
On 08/26/2015 06:02 PM, Eduardo Habkost wrote: On Tue, Aug 25, 2015 at 11:50:11AM +0300, Marcel Apfelbaum wrote: On 08/21/2015 12:54 AM, Eduardo Habkost wrote: Now all TYPE_MACHINE subclasses use MACHINE_TYPE_NAME to generate the class name. So instead of requiring each subclass to set

Re: [Qemu-devel] [PATCH COLO-Frame v8 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2015-08-26 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/8/24 22:38, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: This is the 8th version of COLO. I'm seeing an occasional error: pcibus_reset: Assertion `bus-irq_count[i] == 0' failed.

[Qemu-devel] [PATCH] tile: correct some typos in opcode type names

2015-08-26 Thread Chris Metcalf
These particular opcode names are not used in the kernel directly, so updating them just has the effect of making downstream consumers more like to end up using better names; this was reported from the qemu community. Reported-by: Richard Henderson r...@twiddle.net Signed-off-by: Chris Metcalf

Re: [Qemu-devel] Should we auto-generate IDs? (was: [PATCH] qdev-monitor.c: Add device id generation)

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 1:28 PM, Daniel P. Berrange wrote: On Tue, Aug 25, 2015 at 02:38:17PM +0200, Markus Armbruster wrote: You're proposing to revise a qdev design decision, namely the purpose of IDs. This has been discussed before, and IDs remained unchanged. Perhaps it's time to revisit

Re: [Qemu-devel] Should we auto-generate IDs? (was: [PATCH] qdev-monitor.c: Add device id generation)

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 1:53 PM, Daniel P. Berrange wrote: On Wed, Aug 26, 2015 at 01:46:43PM -0400, Programmingkid wrote: On Aug 26, 2015, at 1:28 PM, Daniel P. Berrange wrote: On Tue, Aug 25, 2015 at 02:38:17PM +0200, Markus Armbruster wrote: You're proposing to revise a qdev design

Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type

2015-08-26 Thread John Snow
On 08/26/2015 05:02 PM, Peter Crosthwaite wrote: On Wed, Aug 26, 2015 at 1:36 PM, Alistair Francis alistair.fran...@xilinx.com wrote: On Tue, Aug 25, 2015 at 12:43 AM, Peter Crosthwaite crosthwaitepe...@gmail.com wrote: On Mon, Aug 24, 2015 at 4:36 PM, Alistair Francis

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 2:45 PM, Peter Maydell wrote: On 26 August 2015 at 18:16, Programmingkid programmingk...@gmail.com wrote: That is assuming they have the time and/or the interest in solving this problem. I suppose giving them some time to respond would be reasonable. I'm thinking if no

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread John Snow
On 08/26/2015 06:01 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote: On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote: On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at

  1   2   3   4   >