[Qemu-devel] [Bug 1481272] Re: main-loop: WARNING: I/O thread spun for 1000 iterations

2015-09-04 Thread Arghya Banerjee
We are hitting this bug as well. With Ceph storage back end running in OpenStack environment. Ubuntu 14.04 Kernel - 3.13.0-52-generic Qemu: QEMU emulator version 2.0.0 (Debian 2.0.0+dfsg-2ubuntu1.11) Please provide a workaround or solution or if a patch is being worked on. Thank you, Arghya -

[Qemu-devel] [PATCH RFC v4 02.5/32] qapi: Hide internal data members of schema objects.

2015-09-04 Thread Eric Blake
We have a few fields that exist mainly to hold information from __init__() until check() (matching the fact that parsing is two-pass; the first to find type names, the second to associate types together while honoring forward references), or which should only be used through accessor methods. We s

Re: [Qemu-devel] [PATCH v6 4/4] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP

2015-09-04 Thread Alistair Francis
On Fri, Sep 4, 2015 at 12:59 PM, John Snow wrote: > > > On 09/04/2015 09:42 AM, Peter Maydell wrote: >> On 31 August 2015 at 22:28, Alistair Francis >> wrote: >>> On Mon, Aug 31, 2015 at 1:54 PM, John Snow wrote: For some reason, this patch never made it to the qemu-devel archives for

Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.

2015-09-04 Thread Alistair Francis
On Fri, Sep 4, 2015 at 3:50 PM, Frederic Konrad wrote: > On 01/09/2015 22:58, Alistair Francis wrote: >> >> On Tue, Jul 21, 2015 at 10:17 AM, wrote: >>> >>> From: KONRAD Frederic >>> >>> Seems this field is not needed. >> >> The commit message should be updated to represent the patch. > > Hmmm

Re: [Qemu-devel] [PATCH v2 09/49] qapi: support nested structs in OptsVisitor

2015-09-04 Thread Eric Blake
On 08/21/2015 09:37 AM, Kővágó, Zoltán wrote: > The current OptsVisitor flattens the whole structure, if there are same > named fields under different paths (like `in' and `out' in `Audiodev'), > the current visitor can't cope with them (for example setting > `frequency=44100' will set the in's fre

Re: [Qemu-devel] [PATCH v2 07/49] qapi: reorder NetdevBase and Netdev

2015-09-04 Thread Eric Blake
On 08/21/2015 09:37 AM, Kővágó, Zoltán wrote: > Probably more logical if NetdevBase comes before Netdev. > No schematic changes. > > Signed-off-by: Kővágó, Zoltán > --- > qapi-schema.json | 46 +++--- > 1 file changed, 23 insertions(+), 23 deletions(-) Ju

Re: [Qemu-devel] [PATCH v3 0/6] ARM: enable TZ in the GIC

2015-09-04 Thread Edgar E. Iglesias
On Fri, Sep 04, 2015 at 05:22:56PM +0100, Peter Maydell wrote: > This patchset enables the TZ support in the GIC for the systems > where we enable TZ support in the CPU. In practice that means > just the "virt" and "vexpress" boards, since all the others > disable the CPU TZ support. > > There are

Re: [Qemu-devel] [PATCH v2 06/49] qapi: change Netdev into a flat union

2015-09-04 Thread Eric Blake
On 08/21/2015 09:37 AM, Kővágó, Zoltán wrote: > Except qapi-schema.json, this patch was generated by: > > find . -name .git -prune -o -type f \! -name '*~' -print0 | \ > xargs -0 sed -i \ > -e 's/NetClientOptionsKind/NetClientDriver/g' \ > -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER

Re: [Qemu-devel] [PATCH V4 4/8] introduce dpcd module.

2015-09-04 Thread Frederic Konrad
On 02/09/2015 01:19, Alistair Francis wrote: On Tue, Jul 21, 2015 at 10:17 AM, wrote: From: KONRAD Frederic This introduces a DPCD module. It wires on a aux-bus and can be accessed by driver to get lane-speed, etc. "the driver" Also, the commit titles are a little messy. The capitalisation

Re: [Qemu-devel] [PATCH V4 2/8] Introduce AUX bus.

2015-09-04 Thread Frederic Konrad
On 02/09/2015 02:00, Alistair Francis wrote: On Tue, Sep 1, 2015 at 2:48 PM, Alistair Francis wrote: On Tue, Jul 21, 2015 at 10:17 AM, wrote: From: KONRAD Frederic This introduces a new bus: aux-bus. It contains an address space for aux slaves devices and a bridge to an I2C bus for I2C th

Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.

2015-09-04 Thread Frederic Konrad
On 01/09/2015 22:58, Alistair Francis wrote: On Tue, Jul 21, 2015 at 10:17 AM, wrote: From: KONRAD Frederic Seems this field is not needed. The commit message should be updated to represent the patch. Hmmm what do you mean? It's not precise? Thanks, Fred Signed-off-by: KONRAD Frederic

Re: [Qemu-devel] [PATCH] configure: Require Python 2.6

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 20:53, Markus Armbruster wrote: > RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back > to 10.6. > > Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell I wonder if we're ever going to need to add that Python 3 support the error message alludes t

Re: [Qemu-devel] [PATCH] vl.c: don't try to insert malloc tracepoints on newer glib (v2)

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 20:09, Serge Hallyn wrote: > Because it has deprecated it with commit > 3be6ed60aa58095691bd697344765e715a327fc1. This prevents the warning > > (process:3535): GLib-WARNING **: > /build/glib2.0-3tdlHy/glib2.0-2.45.6/./glib/gmem.c:482: custom memory > allocation vtable not

Re: [Qemu-devel] [PATCH v2] linux-user: add signalfd/signalfd4 syscalls

2015-09-04 Thread Laurent Vivier
Le 04/09/2015 15:35, Peter Maydell a écrit : > On 3 September 2015 at 00:58, Laurent Vivier wrote: >> This patch introduces a system very similar to the one used in the kernel >> to attach specific functions to a given file descriptor. >> >> In this case, we attach a specific "host_to_target()"

Re: [Qemu-devel] [PATCH] qom/object.h: remove some child/parent doc

2015-09-04 Thread Peter Crosthwaite
On Fri, Sep 4, 2015 at 2:42 PM, Marc-André Lureau wrote: > Hi > > On Fri, Sep 4, 2015 at 11:25 PM, Peter Crosthwaite > wrote: >> On Fri, Sep 4, 2015 at 2:01 PM, wrote: >>> From: Marc-André Lureau >>> >>> It looks like this documentation is obsolete: a child object may lookup >>> its parent sto

Re: [Qemu-devel] [PATCH v2 05/49] net: use Netdev instead of NetClientOptions in client init

2015-09-04 Thread Eric Blake
On 09/04/2015 03:36 PM, Eric Blake wrote: > On 08/21/2015 09:37 AM, Kővágó, Zoltán wrote: >> This way we no longer need NetClientOptions and can convert Netdev >> into a flat union. >> >> Signed-off-by: Kővágó, Zoltán >> --- >> net/clients.h| 20 ++-- >> net/dump.c | 6

Re: [Qemu-devel] [PATCH] qom/object.h: remove some child/parent doc

2015-09-04 Thread Marc-André Lureau
Hi On Fri, Sep 4, 2015 at 11:25 PM, Peter Crosthwaite wrote: > On Fri, Sep 4, 2015 at 2:01 PM, wrote: >> From: Marc-André Lureau >> >> It looks like this documentation is obsolete: a child object may lookup >> its parent stored in the Object struct. >> > > Using a function wrapper or direct ac

Re: [Qemu-devel] [PATCH RFC 1/7] qom: allow properties to be registered against classes

2015-09-04 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2015 at 2:03 PM, Daniel P. Berrange wrote: > +ObjectProperty * > +object_class_property_add(ObjectClass *klass, > + const char *name, > + const char *type, > + ObjectPropertyAccessor *get, > +

Re: [Qemu-devel] [PATCH v2 05/49] net: use Netdev instead of NetClientOptions in client init

2015-09-04 Thread Eric Blake
On 08/21/2015 09:37 AM, Kővágó, Zoltán wrote: > This way we no longer need NetClientOptions and can convert Netdev > into a flat union. > > Signed-off-by: Kővágó, Zoltán > --- > net/clients.h| 20 ++-- > net/dump.c | 6 +++--- > net/hub.c| 6 +++--- > net/l2tp

Re: [Qemu-devel] [PATCH] qom/object.h: remove some child/parent doc

2015-09-04 Thread Peter Crosthwaite
On Fri, Sep 4, 2015 at 2:01 PM, wrote: > From: Marc-André Lureau > > It looks like this documentation is obsolete: a child object may lookup > its parent stored in the Object struct. > Using a function wrapper or direct access to Object structure field? The latter would indicate they are worka

Re: [Qemu-devel] [PATCH v2 04/49] net: remove NetLegacy struct

2015-09-04 Thread Eric Blake
On 08/21/2015 09:37 AM, Kővágó, Zoltán wrote: > NetLegacy is just Netdev with some extra fields (name, vlan) and an > optional id. This patch merges the two structs, and net_client_init1 > got some extra checks to make sure only accept valid -netdev command > lines. This is some extra work, but a

Re: [Qemu-devel] [PATCH v2 03/49] qapi: convert NumaOptions into a flat union

2015-09-04 Thread Eric Blake
On 08/26/2015 09:31 AM, Eduardo Habkost wrote: > As long as somebody who understands QAPI says the changes make sense and > should work, I am OK with them if the following is changed: That would be me, right? See my other mail for my tentative R-b; although if you start renaming things due to this

Re: [Qemu-devel] [PATCH v1 1/1] cadence_gem: Correct Marvell PHY SPCFC reset value

2015-09-04 Thread Edgar E. Iglesias
On Fri, Sep 04, 2015 at 07:12:23PM +0100, Peter Maydell wrote: > On 4 September 2015 at 19:00, Alistair Francis > wrote: > > On Thu, Sep 3, 2015 at 3:56 PM, Edgar E. Iglesias > > wrote: > >> On Thu, Sep 03, 2015 at 03:10:52PM -0700, Alistair Francis wrote: > >>> Bit 15 of the PHY Specific Status

Re: [Qemu-devel] [PATCH v2 03/49] qapi: convert NumaOptions into a flat union

2015-09-04 Thread Eric Blake
On 08/21/2015 09:36 AM, Kővágó, Zoltán wrote: > Signed-off-by: Kővágó, Zoltán The subject line is a one-line "what", and the commit body should be the "why" - all but the most trivial "what" deserve a non-empty commit body. In particular, I think you NEED to mention in the commit body that the c

[Qemu-devel] [PATCH] qom/object.h: remove some child/parent doc

2015-09-04 Thread marcandre . lureau
From: Marc-André Lureau It looks like this documentation is obsolete: a child object may lookup its parent stored in the Object struct. Signed-off-by: Marc-André Lureau --- include/qom/object.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h in

Re: [Qemu-devel] [PATCH v2 02/49] qapi: support implicit structs in OptsVisitor

2015-09-04 Thread Eric Blake
On 08/21/2015 09:36 AM, Kővágó, Zoltán wrote: > They are required for flat unions (you still have to allocate the > structs). > > Signed-off-by: Kővágó, Zoltán > --- > qapi/opts-visitor.c | 15 +++ > 1 file changed, 15 insertions(+) > Reviewed-by: Eric Blake However, note that I

[Qemu-devel] [PULL 13/16] qcow2: add option to clean unused cache entries after some time

2015-09-04 Thread Kevin Wolf
From: Alberto Garcia This adds a new 'cache-clean-interval' option that cleans all qcow2 cache entries that haven't been used in a certain interval, given in seconds. This allows setting a large L2 cache size so it can handle scenarios with lots of I/O and at the same time use little memory duri

[Qemu-devel] [PULL 12/16] qcow2: mark the memory as no longer needed after qcow2_cache_empty()

2015-09-04 Thread Kevin Wolf
From: Alberto Garcia After having emptied the cache, the data in the cache tables is no longer useful, so we can tell the kernel that we are done with it. In Linux this frees the resources associated with it. The effect of this can be seen in the HMP commit operation: it moves data from the top

Re: [Qemu-devel] [PATCH v2 01/49] opts: produce valid command line in qemu_opts_print

2015-09-04 Thread Eric Blake
On 08/21/2015 09:36 AM, Kővágó, Zoltán wrote: > This will let us print options in a format that the user would actually > write it on the command line (foo=bar,baz=asd,etc=def), without > prepending a spurious comma at the beginning of the list, or quoting > values unnecessarily. This patch provid

[Qemu-devel] [PULL 14/16] docs: document how to configure the qcow2 L2/refcount caches

2015-09-04 Thread Kevin Wolf
From: Alberto Garcia QEMU has options to configure the size of the L2 and refcount caches for the qcow2 format. However, choosing the right sizes for a particular disk image is not a straightforward operation since the ratio between the cache size and the allocated disk space is not obvious and d

Re: [Qemu-devel] [PATCH v4 3/3] Use help sub-sections to create sub-help options

2015-09-04 Thread Eric Blake
On 09/04/2015 01:30 PM, Laurent Vivier wrote: > As '-help' output is 400 lines long it is not easy > to find information, but generally we know from > which area we want the information. > > As sections already exist in the help description, > add some options to only display the wanted section. >

[Qemu-devel] [PULL 11/16] iotests: Warn if python subprocess is killed

2015-09-04 Thread Kevin Wolf
From: Max Reitz Currently, if a subprocess of a python test (i.e. qemu-io, qemu-img, or qemu) receives a signal and is subsequently aborted, this is not logged. This patch makes python tests always check the exit code of these subprocesses, and emit a message if they have been killed. Signed-of

[Qemu-devel] [PULL 08/16] iotests: More options for VM.add_drive()

2015-09-04 Thread Kevin Wolf
From: Max Reitz This patch allows specifying the interface to be used for the drive, and makes specifying a path optional (if the path is None, the "file" option will be omitted, thus creating an empty drive). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tes

[Qemu-devel] [PULL 16/16] quorum: validate vote threshold against num_children even if read-pattern is fifo

2015-09-04 Thread Kevin Wolf
From: Wen Congyang We need to use threshold to check if too many write operation fails. If threshold is larger than num children, we always get write error event even if all write operations success. Signed-off-by: Wen Congyang Message-id: 55962f72.3060...@cn.fujitsu.com Reviewed-by: Alberto Ga

[Qemu-devel] [PULL 10/16] iotests: Do not suppress segfaults in bash tests

2015-09-04 Thread Kevin Wolf
From: Max Reitz Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a segmentation fault, that message is invisible in most cases since the output is generally filtered and bash suppresses the segmentation fault notice for any but the last element of a pipe. Most of the time, the

[Qemu-devel] [PULL 06/16] block/raw-posix: Use raw_normalize_devicepath()

2015-09-04 Thread Kevin Wolf
From: Max Reitz The filename given to qemu_open() in block/raw-posix.c should generally have been processed by raw_normalize_devicepath(); unless we are only probing (in which case the caller often checks whether the file is a block device or not, and this property will be changed by raw_normaliz

[Qemu-devel] [PULL 15/16] qcow2: reorder fields in Qcow2CachedTable to reduce padding

2015-09-04 Thread Kevin Wolf
From: Alberto Garcia Changing the current ordering saves 8 bytes per cache entry in x86_64. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Message-id: 0bd55291211df3dfb514d0e7d2031dd5c4f9f807.1438690126.git.be...@igalia.com Signed-off-by

[Qemu-devel] [PULL 09/16] iotests: Respect -nodefaults in tests 41 and 55

2015-09-04 Thread Kevin Wolf
From: Max Reitz While -nodefaults is set in $QEMU_OPTIONS, this is currently (wrongly) ignored for Python iotests. In order to be prepared for when this is fixed, we should explicitly add an IDE CD-ROM drive instead of relying on it being created automatically. Signed-off-by: Max Reitz Reviewed

[Qemu-devel] [PULL 07/16] qemu-img: Fix crash in amend invocation

2015-09-04 Thread Kevin Wolf
From: Max Reitz Example: $ ./qemu-img create -f qcow2 /tmp/t.qcow2 64M $ ./qemu-img amend -f qcow2 -o backing_file=/tmp/t.qcow2, -o help \ /tmp/t.qcow2 This should not crash. This actually is tested by iotest 082, but not caught due to the segmentation fault being silent (which is something

[Qemu-devel] [PULL 03/16] qemu-iotests: s390x: fix test 041 and 055

2015-09-04 Thread Kevin Wolf
From: Bo Tu There is no 'ide-cd' device defined on non-pc platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Reviewed-by: Sascha Silbe Signed-off-by: Xiao Guang Chen Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041 | 6 +

[Qemu-devel] [PULL 05/16] qemu-iotests: s390x: fix test 130

2015-09-04 Thread Kevin Wolf
From: Bo Tu The default device id of hard disk on the s390 platform is "virtio0" which differs to the "ide0-hd0" for the x86 platform. Setting id in the drive definition, ie:"qemu -drive id=testdisk", will be the same on all platforms. Reviewed-by: Max Reitz Signed-off-by: Bo Tu Signed-off-by:

[Qemu-devel] [PULL 04/16] qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts

2015-09-04 Thread Kevin Wolf
From: Bo Tu when creating an image qemu-img enable us specifying the size of the image using -o size=xx options. But when we specify an invalid size such as a negtive size then different platform gives different result. parse_option_size() function in util/qemu-option.c will be called to parse t

[Qemu-devel] [PULL 01/16] qemu-iotests: qemu machine type support

2015-09-04 Thread Kevin Wolf
From: Bo Tu This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type and alias of the default machine type the reference output file can now vary from the default to a machine specific output file if necessary. When using a machine specific reference

[Qemu-devel] [PULL 02/16] qemu-iotests: disable default qemu devices for cross-platform compatibility

2015-09-04 Thread Kevin Wolf
From: Bo Tu This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy and cdrom. Output files for test cas

[Qemu-devel] [PULL 00/16] Block patches

2015-09-04 Thread Kevin Wolf
The following changes since commit b597aa037dbd98014c8dec3d69a5e2240f432533: Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2015-09-04' into staging (2015-09-04 17:37:50 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for yo

Re: [Qemu-devel] [PATCH v4 1/3] vl: Add a flags to define parameters with optional arguments.

2015-09-04 Thread Eric Blake
On 09/04/2015 01:55 PM, Stefan Weil wrote: > Am 04.09.2015 um 21:42 schrieb Eric Blake: >> On 09/04/2015 01:30 PM, Laurent Vivier wrote: >>> The goal is to be able to use '-help' alone, or with >>> a sub-section, i.e. '-help network,usb'. >> Uggh. I hate reinventing the wheel. We aren't using geto

Re: [Qemu-devel] [PATCH v6 4/4] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP

2015-09-04 Thread John Snow
On 09/04/2015 09:42 AM, Peter Maydell wrote: > On 31 August 2015 at 22:28, Alistair Francis > wrote: >> On Mon, Aug 31, 2015 at 1:54 PM, John Snow wrote: >>> For some reason, this patch never made it to the qemu-devel archives for >>> either v5 or v6. I only received a direct copy to my inbox,

Re: [Qemu-devel] [PATCH v4 1/3] vl: Add a flags to define parameters with optional arguments.

2015-09-04 Thread Stefan Weil
Am 04.09.2015 um 21:42 schrieb Eric Blake: > On 09/04/2015 01:30 PM, Laurent Vivier wrote: >> The goal is to be able to use '-help' alone, or with >> a sub-section, i.e. '-help network,usb'. > Uggh. I hate reinventing the wheel. We aren't using getopt_long_only(); > but if we were, the ONLY way to

Re: [Qemu-devel] [PATCH v4 1/3] vl: Add a flags to define parameters with optional arguments.

2015-09-04 Thread Eric Blake
On 09/04/2015 01:42 PM, Eric Blake wrote: > On 09/04/2015 01:30 PM, Laurent Vivier wrote: >> The goal is to be able to use '-help' alone, or with >> a sub-section, i.e. '-help network,usb'. > > Uggh. I hate reinventing the wheel. We aren't using getopt_long_only(); > but if we were, the ONLY way

[Qemu-devel] [PATCH] configure: Require Python 2.6

2015-09-04 Thread Markus Armbruster
RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back to 10.6. Signed-off-by: Markus Armbruster --- configure | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 21c4089..bce1769 100755 --- a/configure +++ b/configure @@ -11

Re: [Qemu-devel] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests

2015-09-04 Thread Max Reitz
On 04.09.2015 19:18, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/137 | 143 > + > tests/qemu-iotests/137.out | 43 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 187 insertions(+) > create mod

Re: [Qemu-devel] [PATCH RESEND v6 4/4] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP

2015-09-04 Thread Peter Crosthwaite
On Fri, Sep 4, 2015 at 8:17 AM, Alistair Francis wrote: > Connect the Sysbus AHCI device to ZynqMP. > > Signed-off-by: Alistair Francis > Reviewed-by: Sai Pavan Boddu Reviewed-by: Peter Crosthwaite > --- > V6: > - Fix up Macros > V2: > - Marcoify the number of SATA prts > - Change the erro

Re: [Qemu-devel] [PATCH RESEND v6 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-09-04 Thread Peter Crosthwaite
On Fri, Sep 4, 2015 at 8:17 AM, Alistair Francis wrote: > The AHCIState struct can either have AHCIPCIState or SysbusAHCIState > as a parent. The ahci_irq_lower() and ahci_irq_raise() functions > assume that it is always AHCIPCIState, which is not always the > case, which causes a seg fault. Verif

Re: [Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc

2015-09-04 Thread Eric Blake
On 09/04/2015 01:41 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The legacy<> type is no longer used since 7ce7ffe02. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > @@ -1689,10 +16

Re: [Qemu-devel] [PATCH v4 1/3] vl: Add a flags to define parameters with optional arguments.

2015-09-04 Thread Eric Blake
On 09/04/2015 01:30 PM, Laurent Vivier wrote: > The goal is to be able to use '-help' alone, or with > a sub-section, i.e. '-help network,usb'. Uggh. I hate reinventing the wheel. We aren't using getopt_long_only(); but if we were, the ONLY way to specify optional arguments to a long option is by

[Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc

2015-09-04 Thread marcandre . lureau
From: Marc-André Lureau The legacy<> type is no longer used since 7ce7ffe02. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 67fef37..884d476 100644 --- a/qapi-sc

Re: [Qemu-devel] [PATCH v4 2/3] help: fix typo

2015-09-04 Thread Eric Blake
On 09/04/2015 01:30 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake Subject line might have been more obvious as 'help: add missing newline' > > diff --git a/qemu-options.hx b/qe

[Qemu-devel] [PATCH v4 3/3] Use help sub-sections to create sub-help options

2015-09-04 Thread Laurent Vivier
As '-help' output is 400 lines long it is not easy to find information, but generally we know from which area we want the information. As sections already exist in the help description, add some options to only display the wanted section. '-help' now can take an optional parameter, which is a com

[Qemu-devel] [PATCH v4 2/3] help: fix typo

2015-09-04 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 77f5853..ab1af02 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3510,7 +3510,7 @@ DEF("dump-vmstate", HAS_ARG, QEMU_OPTION_dump_vms

[Qemu-devel] [PATCH v4 0/3] Improve -help

2015-09-04 Thread Laurent Vivier
This series allows to only display a given list of help sections (and fix a typo). v4: as proposed by Eric, provide a list of sections, restore default -help v3: add a 2nd patch to add an help section, -help displays only this section v2: simplify the dance of #define/#undef, thanks to Marc-André.

[Qemu-devel] [PATCH v4 1/3] vl: Add a flags to define parameters with optional arguments.

2015-09-04 Thread Laurent Vivier
The goal is to be able to use '-help' alone, or with a sub-section, i.e. '-help network,usb'. Signed-off-by: Laurent Vivier --- vl.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 584ca88..a4fa7e5 100644 --- a/vl.c +++ b/vl.c @@ -1932,

Re: [Qemu-devel] [PATCH v2 12/13] qemu-iotests: Reopen qcow2 with lazy-refcounts change

2015-09-04 Thread Max Reitz
On 04.09.2015 19:18, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/039 | 27 +++ > tests/qemu-iotests/039.out | 18 ++ > 2 files changed, 45 insertions(+) > > diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039 > ind

Re: [Qemu-devel] [PATCH v2 11/13] qcow2: Support updating driver-specific options in reopen

2015-09-04 Thread Max Reitz
On 04.09.2015 19:18, Kevin Wolf wrote: > For updating the cache sizes or disabling lazy refcounts there is a bit > more to do than just changing the variables, but otherwise we're all set > for changing options during bdrv_reopen(). > > Just implement the missing pieces and hook the functions up i

[Qemu-devel] [PATCH] vl.c: don't try to insert malloc tracepoints on newer glib (v2)

2015-09-04 Thread Serge Hallyn
Because it has deprecated it with commit 3be6ed60aa58095691bd697344765e715a327fc1. This prevents the warning (process:3535): GLib-WARNING **: /build/glib2.0-3tdlHy/glib2.0-2.45.6/./glib/gmem.c:482: custom memory allocation vtable not supported Changelog (v2): consolidate #ifdefs Signed-off-by

[Qemu-devel] [PATCH v3 6/7] Use DEFINE_MACHINE to register all machines

2015-09-04 Thread Eduardo Habkost
Convert all machines to use DEFINE_MACHINE instead of QEMUMachine automatically using a script. Cc: Richard Henderson Cc: Peter Maydell Cc: Li Guang Cc: Antony Pavlov Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Cc: Rob Herring Cc: Peter Chubb Cc: Jan Kisz

[Qemu-devel] [PATCH v3 7/7] machine: Eliminate QEMUMachine and qemu_register_machine()

2015-09-04 Thread Eduardo Habkost
The struct is not used anymore and can be eliminated. Signed-off-by: Eduardo Habkost --- include/hw/boards.h | 27 --- include/qemu/typedefs.h | 1 - include/sysemu/blockdev.h | 2 +- include/sysemu/sysemu.h | 2 +- vl.c | 36

[Qemu-devel] [PATCH v3 5/7] mac_world: Break long line

2015-09-04 Thread Eduardo Habkost
Coding style change only. Signed-off-by: Eduardo Habkost --- hw/ppc/mac_oldworld.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c index 06fdbaf..b72d67d 100644 --- a/hw/ppc/mac_oldworld.c +++ b/hw/ppc/mac_oldworld.c @@ -365,7 +

[Qemu-devel] [PATCH v3 3/7] exynos4: Declare each QEMUMachine as a separate variable

2015-09-04 Thread Eduardo Habkost
This will make the code follow the same pattern used for other machines, and will make it easier to automatically convert the code to be QOM-based. Cc: Peter Maydell Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Signed-off-by: Eduardo Habkost --- hw/arm/exynos

[Qemu-devel] [PATCH v3 4/7] machine: DEFINE_MACHINE macro

2015-09-04 Thread Eduardo Habkost
The macro will allow easy registration of a TYPE_MACHINE subclass, using only the machine name and a MachineClass initialization function as parameter. Signed-off-by: Eduardo Habkost --- Changes series v1 -> series v2: none Changes series v2 -> series v3: * Don't set MachineClass::name explicitl

[Qemu-devel] [PATCH v3 2/7] exynos4: Use MachineClass instead of exynos4_machines array

2015-09-04 Thread Eduardo Habkost
We don't need a QEMUMachine array to query max_cpus, if we can get the corresponding MachineClass. Cc: Peter Maydell Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Signed-off-by: Eduardo Habkost --- hw/arm/exynos4_boards.c | 4 +++- 1 file changed, 3 insertions

[Qemu-devel] [PATCH v3 1/7] exynos4: Use EXYNOS4210_NCPUS instead of max_cpus on error message

2015-09-04 Thread Eduardo Habkost
The code is checking smp_cpus against EXYNOS4210_NCPUS, not against max_cpus, so use EXYNOS4210_NCPUS in the error message for consistency. Cc: Peter Maydell Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Signed-off-by: Eduardo Habkost --- hw/arm/exynos4_boards

[Qemu-devel] [PATCH v3 0/7] machine registration: Use QOM, eliminate QEMUMachine

2015-09-04 Thread Eduardo Habkost
This converts all code using QEMUMachine to register a QOM class directly, using a new macro: DEFINE_MACHINE. Python script used to convert all machines automatically can be seen at: https://gist.github.com/ehabkost/582fe4969205975febb2#file-qemumachine-eliminate-py Git branch: git://github.

Re: [Qemu-devel] [PATCH v2 04/13] qcow2: Improve error message

2015-09-04 Thread Max Reitz
On 04.09.2015 19:18, Kevin Wolf wrote: > Eric says that "any" sounds better than "either", and my non-native > feeling says the same, so let's change it. > > Suggested-by: Eric Blake > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Revie

Re: [Qemu-devel] [PATCH v2 03/13] qemu-io: Add command 'reopen'

2015-09-04 Thread Max Reitz
On 04.09.2015 19:18, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > qemu-io-cmds.c | 90 > ++ > 1 file changed, 90 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v1 1/1] cadence_gem: Correct Marvell PHY SPCFC reset value

2015-09-04 Thread Alistair Francis
On Fri, Sep 4, 2015 at 11:12 AM, Peter Maydell wrote: > On 4 September 2015 at 19:00, Alistair Francis > wrote: >> On Thu, Sep 3, 2015 at 3:56 PM, Edgar E. Iglesias >> wrote: >>> On Thu, Sep 03, 2015 at 03:10:52PM -0700, Alistair Francis wrote: Bit 15 of the PHY Specific Status Register is

Re: [Qemu-devel] [RFC PATCH] sdhci: Move sdhci.h to include/

2015-09-04 Thread Sai Pavan Boddu
> -Original Message- > From: Alistair Francis [mailto:alistai...@gmail.com] > Sent: Friday, September 04, 2015 11:51 PM > To: Sai Pavan Boddu > Cc: qemu-devel@nongnu.org Developers; Sai Pavan Boddu; Peter Maydell; > Peter Crosthwaite; Alistair Francis; Edgar Iglesias > Subject: Re: [Qemu-

Re: [Qemu-devel] [PATCH V4 6/8] Introduce xilinx dpdma.

2015-09-04 Thread Alistair Francis
On Fri, Sep 4, 2015 at 2:01 AM, Frederic Konrad wrote: > On 04/09/2015 01:34, Alistair Francis wrote: >> >> On Thu, Sep 3, 2015 at 12:28 AM, Frederic Konrad >> wrote: >>> >>> On 02/09/2015 23:39, Alistair Francis wrote: On Tue, Jul 21, 2015 at 10:17 AM, wrote: > > From: KONRAD

Re: [Qemu-devel] [RFC PATCH] sdhci: Move sdhci.h to include/

2015-09-04 Thread Alistair Francis
On Fri, Sep 4, 2015 at 12:12 AM, Sai Pavan Boddu wrote: > For a easy creation of device directly form sdhci, without building a wrapper > around. Can you fix the commit message? > > Signed-off-by: Sai Pavan Boddu > --- > hw/sd/sdhci.c | 2 +- > {hw/sd => include/hw}/sdhci.h |

Re: [Qemu-devel] [PATCH v1 1/1] cadence_gem: Correct Marvell PHY SPCFC reset value

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 19:00, Alistair Francis wrote: > On Thu, Sep 3, 2015 at 3:56 PM, Edgar E. Iglesias > wrote: >> On Thu, Sep 03, 2015 at 03:10:52PM -0700, Alistair Francis wrote: >>> Bit 15 of the PHY Specific Status Register is reserved and >>> should remain 0. Fix the reset value to ensure

Re: [Qemu-devel] [PATCH 1/1] vl.c: don't try to insert malloc tracepoints on newer glib

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 18:58, Serge Hallyn wrote: > Because it has deprecated it with commit > 3be6ed60aa58095691bd697344765e715a327fc1. This prevents the warning > > (process:3535): GLib-WARNING **: > /build/glib2.0-3tdlHy/glib2.0-2.45.6/./glib/gmem.c:482: custom memory > allocation vtable not

Re: [Qemu-devel] [PATCH v2 02/13] qemu-io: Remove duplicate 'open' error message

2015-09-04 Thread Max Reitz
On 04.09.2015 19:18, Kevin Wolf wrote: > qemu_opts_parse_noisily() already prints an error message with the exact > reason why the parsing failed. No need to add another less specific one. > > Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signatu

Re: [Qemu-devel] [PATCH v1 1/1] cadence_gem: Correct Marvell PHY SPCFC reset value

2015-09-04 Thread Alistair Francis
On Thu, Sep 3, 2015 at 3:56 PM, Edgar E. Iglesias wrote: > On Thu, Sep 03, 2015 at 03:10:52PM -0700, Alistair Francis wrote: >> Bit 15 of the PHY Specific Status Register is reserved and >> should remain 0. Fix the reset value to ensure that the 15th >> bit is not set. >> >> Signed-off-by: Alistai

[Qemu-devel] [PATCH 1/1] vl.c: don't try to insert malloc tracepoints on newer glib

2015-09-04 Thread Serge Hallyn
Because it has deprecated it with commit 3be6ed60aa58095691bd697344765e715a327fc1. This prevents the warning (process:3535): GLib-WARNING **: /build/glib2.0-3tdlHy/glib2.0-2.45.6/./glib/gmem.c:482: custom memory allocation vtable not supported as reported at https://bugs.launchpad.net/ubuntu/+

Re: [Qemu-devel] [PULL 0/2] Monitor patches

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 15:24, Markus Armbruster wrote: > The following changes since commit b041066421e8dcc7d080dfcfd83551c9c9f24ade: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2015-09-03 16:17:28 +0100) > > are available in the git repository

Re: [Qemu-devel] [PATCH v12 5/5] hw/arm/virt: Add gic-version option to virt machine

2015-09-04 Thread Diana Craciun
Hi Pavel, On 09/04/2015 10:26 AM, Pavel Fedin wrote: It is more convenient for ITS implementation. I already have the code for it, and for ITS device it is useful to have two separate sysbus-mmio regions, one for control and one for translation. Do you plan posting the ITS patches on the l

Re: [Qemu-devel] QEMU+Aarch64: in_asm log skips instructions of loop-programs

2015-09-04 Thread Sergey Smolov
03.09.2015 19:35, Peter Maydell пишет: On 3 September 2015 at 15:31, Sergey Smolov wrote: Do you think it is possible to implement another QEMU logger which will make a record for every executed block, Yes (this would just need to disable the TB linking optimisation, which we've discussed p

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 18:20, Richard Purdie wrote: > On Fri, 2015-09-04 at 13:43 +0100, Richard Purdie wrote: >> On Fri, 2015-09-04 at 12:31 +0100, Peter Maydell wrote: >> > On 4 September 2015 at 12:24, Richard Purdie >> > wrote: >> > > So just based on that, yes, seems that the rx_fifo looks t

[Qemu-devel] [PATCH v2 11/13] qcow2: Support updating driver-specific options in reopen

2015-09-04 Thread Kevin Wolf
For updating the cache sizes or disabling lazy refcounts there is a bit more to do than just changing the variables, but otherwise we're all set for changing options during bdrv_reopen(). Just implement the missing pieces and hook the functions up in bdrv_reopen(). Signed-off-by: Kevin Wolf ---

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

2015-09-04 Thread Richard Purdie
On Fri, 2015-09-04 at 13:43 +0100, Richard Purdie wrote: > On Fri, 2015-09-04 at 12:31 +0100, Peter Maydell wrote: > > On 4 September 2015 at 12:24, Richard Purdie > > wrote: > > > So just based on that, yes, seems that the rx_fifo looks to be > > > overrunning. I can add the asserts but I think i

[Qemu-devel] [PATCH v2 08/13] qcow2: Leave s unchanged on qcow2_update_options() failure

2015-09-04 Thread Kevin Wolf
On return, either all new options should be applied to BDRVQcowState (on success), or all of the old settings should be preserved (on failure). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block/qcow2.c | 52

[Qemu-devel] [PATCH v2 06/13] qcow2: Move qcow2_update_options() call up

2015-09-04 Thread Kevin Wolf
qcow2_update_options() only updates some variables in BDRVQcowState and doesn't really depend on other parts of it being initialised yet, so it can be moved so that it immediately follows the other half of option handling code in qcow2_open(). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Re

[Qemu-devel] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests

2015-09-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/137 | 143 + tests/qemu-iotests/137.out | 43 ++ tests/qemu-iotests/group | 1 + 3 files changed, 187 insertions(+) create mode 100755 tests/qemu-iotests/137 create mode 100644 test

[Qemu-devel] [PATCH v2 03/13] qemu-io: Add command 'reopen'

2015-09-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qemu-io-cmds.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 53477e1..d6572a8 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -1979,6 +1979,95 @@ static const

[Qemu-devel] [PATCH v2 10/13] qcow2: Make qcow2_update_options() suitable for transactions

2015-09-04 Thread Kevin Wolf
Before we can allow updating options at runtime with bdrv_reopen(), we need to split the function into prepare/commit/abort parts. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block/qcow2.c | 101 ++ 1 file

[Qemu-devel] [PATCH v2 12/13] qemu-iotests: Reopen qcow2 with lazy-refcounts change

2015-09-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/039 | 27 +++ tests/qemu-iotests/039.out | 18 ++ 2 files changed, 45 insertions(+) diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039 index 617f397..9e9b379 100755 --- a/tests/qemu-iotests/039

[Qemu-devel] [PATCH v2 09/13] qcow2: Fix memory leak in qcow2_update_options() error path

2015-09-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block/qcow2.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 9b67334..24acefd 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -549,8 +549,8 @@ st

[Qemu-devel] [PATCH v2 07/13] qcow2: Move rest of option handling to qcow2_update_options()

2015-09-04 Thread Kevin Wolf
With this commit, the handling of driver-specific options in qcow2_open() is completely separated out into qcow2_update_options(). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block/qcow2.c | 111 +- 1 file

[Qemu-devel] [PATCH v2 00/13] qcow2: reopen: Change driver-specific runtime options

2015-09-04 Thread Kevin Wolf
This is part two of what I had sent earlier as "[PATCH 00/34] block: Cache mode for children, reopen overhaul and more". Most of the patches were actually already reviewed in v1. Apart from a few addressed review comments, there are no functional changes compared to v1. Some rebasing was necessary

[Qemu-devel] [PATCH v2 01/13] block: Allow specifying driver-specific options to reopen

2015-09-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c | 42 +++--- block/commit.c| 4 ++-- include/block/block.h | 4 +++- 3 files changed, 44 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 090923c..a2cd9b8 1

[Qemu-devel] [PATCH v2 04/13] qcow2: Improve error message

2015-09-04 Thread Kevin Wolf
Eric says that "any" sounds better than "either", and my non-native feeling says the same, so let's change it. Suggested-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 76c331b..e1

  1   2   3   4   >