Re: [Qemu-devel] [PATCH 10/10] machine: Set MachineClass::name automatically

2015-09-18 Thread Andreas Färber
Am 19.09.2015 um 08:23 schrieb Andreas Färber: > Am 20.08.2015 um 23:54 schrieb Eduardo Habkost: >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >> index 5ba4b80..af985f6 100644 >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -960,7 +960,6 @@ static void virt_class_init(ObjectClass *oc, void *dat

Re: [Qemu-devel] [PATCH 03/10] vexpress: Rename machine classes to use MACHINE_TYPE_NAME

2015-09-18 Thread Andreas Färber
Am 19.09.2015 um 08:30 schrieb Andreas Färber: > Am 20.08.2015 um 23:54 schrieb Eduardo Habkost: >> Machine class names should use the "-machine" suffix to allow >> class-name-based machine class lookup to work. Rename the vexpress >> machine classes using the MACHINE_TYPE_NAME macro. >> >> Cc: Pet

Re: [Qemu-devel] Compiling Qemu from Cygwin

2015-09-18 Thread Stefan Weil
Am 19.09.2015 um 04:49 schrieb Mike Ladouceur: > I tried from Ubuntu in Virtualbox and this is the error I now get and it > appears to be similar to the error from Cygwin. Configure seems to run > fine. Make fails. I'm officially lost. > > ./configure --cross-prefix=x86_64-w64-mingw32 > (...) >

Re: [Qemu-devel] [PATCH 03/10] vexpress: Rename machine classes to use MACHINE_TYPE_NAME

2015-09-18 Thread Andreas Färber
Am 20.08.2015 um 23:54 schrieb Eduardo Habkost: > Machine class names should use the "-machine" suffix to allow > class-name-based machine class lookup to work. Rename the vexpress > machine classes using the MACHINE_TYPE_NAME macro. > > Cc: Peter Maydell > Signed-off-by: Eduardo Habkost > --- >

Re: [Qemu-devel] [PATCH RFC 0/4] sPAPR: Support multiple PEs in one PHB

2015-09-18 Thread David Gibson
On Fri, Sep 18, 2015 at 04:30:12PM +1000, Gavin Shan wrote: > This patchset bases on David Gibson's git tree: > git://github.com/dgibson/qemu.git > (branch: vfio). And it requires host kernel changes which is being reviewed > this moment. > > https://patchwork.ozlabs.org/patch/519135/ > https://p

Re: [Qemu-devel] [PATCH 10/10] machine: Set MachineClass::name automatically

2015-09-18 Thread Andreas Färber
Am 20.08.2015 um 23:54 schrieb Eduardo Habkost: > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 5ba4b80..af985f6 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -960,7 +960,6 @@ static void virt_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc = MACHINE_CLASS(oc); >

Re: [Qemu-devel] Compiling Qemu from Cygwin

2015-09-18 Thread Mike Ladouceur
I tried from Ubuntu in Virtualbox and this is the error I now get and it appears to be similar to the error from Cygwin. Configure seems to run fine. Make fails. I'm officially lost. ./configure --cross-prefix=x86_64-w64-mingw32 (...) CCqga/commands-win32.o qga/commands-win32.c: In function

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v1multu instruction

2015-09-18 Thread Richard Henderson
On 09/18/2015 05:14 PM, gang.chen.5...@gmail.com wrote: From: Chen Gang Only according to v1add implementation. Signed-off-by: Chen Gang --- target-tilegx/helper.h | 1 + target-tilegx/simd_helper.c | 13 + target-tilegx/translate.c | 4 3 files changed, 18 insert

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v*add and v*sub instructions

2015-09-18 Thread Richard Henderson
On 09/18/2015 05:03 PM, gang.chen.5...@gmail.com wrote: +uint64_t helper_v1add(uint64_t a, uint64_t b) +{ +uint64_t r = 0; +int i; + +for (i = 0; i < 64; i += 8) { +int64_t ae = (int8_t)(a >> i); +int64_t be = (int8_t)(b >> i); +r |= ((ae + be) & 0xff) << i; +

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v*shl, v*shru, and v*shrs instructions

2015-09-18 Thread Richard Henderson
On 09/18/2015 04:41 PM, gang.chen.5...@gmail.com wrote: +uint64_t helper_v4shl(uint64_t a, uint64_t b) +{ +uint64_t m; + +b &= 63; 31. All of the v4 functions have the same error. r~

Re: [Qemu-devel] [PATCH v2 20/22] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-18 Thread Richard Henderson
On 09/18/2015 03:44 PM, Peter Maydell wrote: Well, if we're going to add a margin we need to add the worst-case margin. I guess the worst case is that deltas of the insn_data words between each insn are useless, and we need full 64-bit values to represent them -- 9 bytes for the sleb128. The

[Qemu-devel] [Bug 1497479] Re: memory corruption with migrate/savevm in TCG mode

2015-09-18 Thread Pavel Boldin
** Description changed: [ISSUE] QEMU releases 2.3.1 and lower are forgetting to flush TLBs before enabling the global dirty pages log and entering the final stage of saving the VM. [DESCRIPTION] The situation is the following: 1. TLB misses is the only way for page dirtying

[Qemu-devel] [Bug 1006655] Re: Can't convert to vmdk with the streamOptimized subformat

2015-09-18 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.3+dfsg-5ubuntu6 --- qemu (1:2.3+dfsg-5ubuntu6) wily; urgency=medium * Make qemu-system-common and qemu-utils depend on qemu-block-extra to fix errors with missing block backends. (LP: #1495895) * Cherry pick fixes for vmdk stream-op

[Qemu-devel] [PATCH] target-tilegx: Implement v1multu instruction

2015-09-18 Thread gang . chen . 5i5j
From: Chen Gang Only according to v1add implementation. Signed-off-by: Chen Gang --- target-tilegx/helper.h | 1 + target-tilegx/simd_helper.c | 13 + target-tilegx/translate.c | 4 3 files changed, 18 insertions(+) diff --git a/target-tilegx/helper.h b/target-tilegx

[Qemu-devel] [Bug 1497479] [NEW] memory corruption with migrate/savevm in TCG mode

2015-09-18 Thread Pavel Boldin
Public bug reported: [ISSUE] QEMU releases 2.3.1 and lower are forgetting to flush TLBs before enabling the global dirty pages log and entering the final stage of saving the VM. [DESCRIPTION] The situation is the following: 1. TLB misses is the only way for page dirtying in the TCG mode. 2. If

[Qemu-devel] [PATCH] target-tilegx: Implement v*add and v*sub instructions

2015-09-18 Thread gang . chen . 5i5j
From: Chen Gang Only according to helper_v1shrs. Signed-off-by: Chen Gang --- target-tilegx/helper.h | 8 + target-tilegx/simd_helper.c | 77 + target-tilegx/translate.c | 26 +-- 3 files changed, 109 insertions(+), 2 deletion

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Kevin O'Connor
On Fri, Sep 18, 2015 at 11:47:52PM +0100, Peter Maydell wrote: > On 18 September 2015 at 19:25, Kevin O'Connor wrote: > > +Additionaly, if the DMA interface is available then a read to the DMA > > +Address will return 0x51454d5520434647 ("QEMU CFG" in big-endian > > +format). > > + > > I don't th

[Qemu-devel] [PATCH] target-tilegx: Implement v*shl, v*shru, and v*shrs instructions

2015-09-18 Thread gang . chen . 5i5j
From: Chen Gang Only according to the v1shl, v1shru, and v1shrs implementations. Signed-off-by: Chen Gang --- target-tilegx/helper.h | 6 + target-tilegx/simd_helper.c | 62 + target-tilegx/translate.c | 20 +++ 3 files change

[Qemu-devel] PATCH] ui/cocoa.m: verify with user before quitting QEMU

2015-09-18 Thread Programmingkid
This patch prevents the user from accidentally quitting QEMU by pushing Command-Q or by pushing the close button on the main window. When the user does one of these two things, a dialog box appears verifying with the user if he wants to quit QEMU. Signed-off-by: John Arbuckle --- ui/cocoa.m |

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 22:24, Marc Marí wrote: > On Fri, 18 Sep 2015 22:16:46 +0200 > Laszlo Ersek wrote: > >> On 09/18/15 10:58, Marc Marí wrote: >>> Enable the fw_cfg DMA interface for the ARM virt machine. >>> >>> Based on Gerd Hoffman's initial implementation. >>> >>> Signed-off-by: Marc Marí >>> --- >

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 19:25, Kevin O'Connor wrote: > On Fri, Sep 18, 2015 at 10:58:44AM +0200, Marc Marí wrote: >> Implement host-side of the FW CFG DMA interface both for x86 and ARM. >> >> Based on Gerd Hoffman's initial implementation. > > Thanks for working on this Marc! > > Any chance you c

Re: [Qemu-devel] [PATCH v2 20/22] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 17:18, Richard Henderson wrote: > On 09/18/2015 06:08 AM, Peter Maydell wrote: >> You're still not allowing for your worst-case datatable size when we >> calculate tcg_ctx.code_gen_buffer_max_size. > > Hum. What factor do you suggest? > > The maximum table expansion is of

Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

2015-09-18 Thread Richard Purdie
On Fri, 2015-09-18 at 11:14 -0700, Peter Crosthwaite wrote: > On Fri, Sep 18, 2015 at 10:23 AM, Richard Purdie > wrote: > > On Fri, 2015-09-18 at 09:46 -0700, Peter Crosthwaite wrote: > >> >> My biggest fear is testing of the changes for the affected boards. > >> >> Peter, do you much coverage of

[Qemu-devel] [PATCH] spapr: generate DT node names

2015-09-18 Thread Laurent Vivier
When DT node names for PCI devices are generated by SLOF, they are generated according to the type of the device (for instance, ethernet for virtio-net-pci device). Node name for hotplugged devices is generated by QEMU. This patch adds the mechanic to QEMU to create the node name according to the

[Qemu-devel] [PATCH] ui/cocoa.m: prevent stuck key situation

2015-09-18 Thread Programmingkid
When the user puts QEMU in the background while holding down a key, QEMU will not receive the keyup event when the user lets go of the key. When the user goes back to QEMU, QEMU will think the key is still down causing stuck key symptoms. This patch fixes this problem by releasing all keys when QE

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-18 Thread chandrasekar kannan
http://wiki.qemu.org/Features/vhost-user-ovs-dpdk I'm running to problems attempting to try this out. qemu errors out with qemu-system-x86_64: -object memory-backend-file,id=mem,size=1024M,mem-path=/dev/hugepages,share=on: unable to map backing store for hugepages: Cannot allocate memory http://

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-18 Thread Paolo Bonzini
On 18/09/2015 18:29, Claudio Fontana wrote: > > this is a first RFC for virtio-peer 0.1, which is still very much a work in > progress: > > https://github.com/hw-claudio/virtio-peer/wiki > > It is also available as PDF there, but the text is reproduced here for > commenting: > > Peer shared

Re: [Qemu-devel] How to make USB work with Mac OS X

2015-09-18 Thread Alexander Graf
> Am 18.09.2015 um 20:38 schrieb Programmingkid : > > >> On Sep 18, 2015, at 2:33 PM, Alexander Graf wrote: >> >> >> >>> Am 18.09.2015 um 15:55 schrieb Programmingkid : >>> >>> On Sep 18, 2015, at 2:14 AM, Alexander Graf wrote: > Am 17.09.2015 um 14:42 schrieb Pr

Re: [Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common

2015-09-18 Thread Peter Crosthwaite
On Fri, Sep 18, 2015 at 11:52 AM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> From: Peter Crosthwaite >> >> Move the size and mask globals for the "real" host page size to >> translate-common. This is to allow system-level code to use >> REAL_HOST_PAGE_ALIGN an

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Marc Marí
On Fri, 18 Sep 2015 22:16:46 +0200 Laszlo Ersek wrote: > On 09/18/15 10:58, Marc Marí wrote: > > Enable the fw_cfg DMA interface for the ARM virt machine. > > > > Based on Gerd Hoffman's initial implementation. > > > > Signed-off-by: Marc Marí > > --- > > hw/arm/virt.c | 9 + > > 1 fi

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 10:58, Marc Marí wrote: > Enable the fw_cfg DMA interface for the ARM virt machine. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/virt.c

Re: [Qemu-devel] [PATCH v5 22/38] block: Prepare for NULL BDS

2015-09-18 Thread Eric Blake
On 09/18/2015 09:22 AM, Max Reitz wrote: > blk_bs() will not necessarily return a non-NULL value any more (unless > blk_is_available() is true or it can be assumed to otherwise, e.g. > because it is called immediately after a successful blk_new_with_bs() or > blk_new_open()). > > Signed-off-by: Ma

[Qemu-devel] [PATCH v2 2/4] target-i386: Move TCG initialization check to tcg_x86_init()

2015-09-18 Thread Eduardo Habkost
Instead of requiring cpu.c to check if TCG was already initialized, simply let the function be called multiple times. Suggested-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 +--- target-i386/translate.c | 6 ++ 2 files changed, 7 insertions(+), 3 deletion

[Qemu-devel] [PATCH v2 4/4] target-i386: Call cpu_exec_init() on realize

2015-09-18 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Calling cpu_exec_init() also affects QEMU's ability to handle errors during CPU creation, as some actions done by

[Qemu-devel] [PATCH v2 1/4] target-i386: Rename optimize_flags_init()

2015-09-18 Thread Eduardo Habkost
Rename the function so that the reason for its existence is clearer: it does x86-specific initialization of TCG structures. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- target-i386/cpu.h | 2 +- target-i386/translate.c | 2 +- 3 files changed, 3 insertions(+), 3 delet

[Qemu-devel] [PATCH v2 0/4] target-i386: Remove side-effects from X86CPU::instance_init

2015-09-18 Thread Eduardo Habkost
To allow new code to ask the CPU classes for CPU model information and allow QOM properties to be queried by qmp_device_list_properties(), we need to be able to safely instantiate a X86CPU object without any side-effects. This series moves some code from x86_cpu_initfn() to x86_cpu_realizefn(), so

[Qemu-devel] [PATCH v2 3/4] target-i386: Move TCG initialization to realize time

2015-09-18 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Move TCG initialization to realize time so it won't be called when just doing object_new() on a X86CPU subclass.

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 10:58, Marc Marí wrote: > Enable the fw_cfg DMA interface for the ARM virt machine. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/virt.c

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-18 Thread Eduardo Habkost
On Fri, Sep 18, 2015 at 08:42:54PM +0200, Thomas Huth wrote: > On 18/09/15 14:00, Markus Armbruster wrote: > > Several devices don't survive object_unref(object_new(T)): they crash > > or hang during cleanup, or they leave dangling pointers behind. > > > > This breaks at least device-list-properti

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Marc Marí
On Fri, 18 Sep 2015 14:25:09 -0400 "Kevin O'Connor" wrote: > On Fri, Sep 18, 2015 at 10:58:44AM +0200, Marc Marí wrote: > > Implement host-side of the FW CFG DMA interface both for x86 and > > ARM. > > > > Based on Gerd Hoffman's initial implementation. > > Thanks for working on this Marc! > >

Re: [Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common

2015-09-18 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > From: Peter Crosthwaite > > Move the size and mask globals for the "real" host page size to > translate-common. This is to allow system-level code to use > REAL_HOST_PAGE_ALIGN and friends in builds which hide translate-all > behind arch-obj. Are yo

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-18 Thread Thomas Huth
On 18/09/15 14:00, Markus Armbruster wrote: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > This breaks at least device-list-properties, because > qmp_device_list_properties() needs to create a device to

Re: [Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-18 Thread Eduardo Habkost
On Wed, Sep 16, 2015 at 10:57:57AM +0200, Paolo Bonzini wrote: [...] > Otherwise looks good, I'll write a kvm-unit-tests patch for this. I am planning to apply the series as soon as we get kvm-unit-tests results. If you think this is ready to get included as-is, even before we have it tested by k

Re: [Qemu-devel] How to make USB work with Mac OS X

2015-09-18 Thread Programmingkid
On Sep 18, 2015, at 2:33 PM, Alexander Graf wrote: > > >> Am 18.09.2015 um 15:55 schrieb Programmingkid : >> >> >>> On Sep 18, 2015, at 2:14 AM, Alexander Graf wrote: >>> >>> >>> Am 17.09.2015 um 14:42 schrieb Programmingkid : Is there a way to make USB work with Mac OS X o

Re: [Qemu-devel] How to make USB work with Mac OS X

2015-09-18 Thread Alexander Graf
> Am 18.09.2015 um 15:55 schrieb Programmingkid : > > >> On Sep 18, 2015, at 2:14 AM, Alexander Graf wrote: >> >> >> >>> Am 17.09.2015 um 14:42 schrieb Programmingkid : >>> >>> Is there a way to make USB work with Mac OS X on qemu-system-ppc? I used >>> the -usb option, but mounting a flas

[Qemu-devel] [PATCH] ui/cocoa.m: Make boot image loading code compatible with GCC 4.9

2015-09-18 Thread Programmingkid
When QEMU is launched on Mac OS X without any arguments, an open file dialog appears. The user is then expected to select a file to boot QEMU with. This code was not compatible with GCC 4.9 (user-built, not Apple supplied). This patch greatly simplifes the open file dialog feature and makes it comp

Re: [Qemu-devel] [PATCH 2/8] target-i386: Make check_hw_breakpoints static

2015-09-18 Thread Eduardo Habkost
On Tue, Sep 15, 2015 at 11:45:07AM -0700, Richard Henderson wrote: > The function is now only used from within a single file. > > Signed-off-by: Richard Henderson Reviewed-by: Eduardo Habkost Applied to x86 tree. Thanks! -- Eduardo

Re: [Qemu-devel] [PATCH v3 3/5] Implement fw_cfg DMA interface

2015-09-18 Thread Kevin O'Connor
On Fri, Sep 18, 2015 at 10:58:47AM +0200, Marc Marí wrote: > Based on the specifications on docs/specs/fw_cfg.txt > > This interface is an addon. The old interface can still be used as usual. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c

Re: [Qemu-devel] [PATCH 1/8] target-i386: Move breakpoint related functions to new file

2015-09-18 Thread Eduardo Habkost
On Tue, Sep 15, 2015 at 11:45:06AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Eduardo Habkost Applied to x86 tree. Thanks! -- Eduardo

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Kevin O'Connor
On Fri, Sep 18, 2015 at 10:58:44AM +0200, Marc Marí wrote: > Implement host-side of the FW CFG DMA interface both for x86 and ARM. > > Based on Gerd Hoffman's initial implementation. Thanks for working on this Marc! Any chance you could add the patch below to the series (or merge it into your se

Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

2015-09-18 Thread Peter Crosthwaite
On Fri, Sep 18, 2015 at 10:23 AM, Richard Purdie wrote: > On Fri, 2015-09-18 at 09:46 -0700, Peter Crosthwaite wrote: >> >> My biggest fear is testing of the changes for the affected boards. >> >> Peter, do you much coverage of these boards in your regressions? Do you >> >> have automated tests in

Re: [Qemu-devel] [PATCH 2/4] target-i386: Convert kvm_default_*features to property/value pairs

2015-09-18 Thread Eduardo Habkost
On Mon, Sep 14, 2015 at 10:32:14AM +0200, Paolo Bonzini wrote: > On 11/09/2015 21:25, Eduardo Habkost wrote: > > Convert the kvm_default_features and kvm_default_unset_features arrays > > into a simple list of property/value pairs that will be applied to > > X86CPU objects when using KVM. > > > >

Re: [Qemu-devel] [PATCH] cocoa: Suppress Cocoa window with -display

2015-09-18 Thread Peter Maydell
On 9 September 2015 at 15:11, Andreas Färber wrote: > Am 09.09.2015 um 16:08 schrieb Rainer Müller: >> Do not open a Cocoa window when another display is selected that will be >> initialized later. The Cocoa display cannot be selected with -display, >> so there is no need to check its argument. >>

Re: [Qemu-devel] [PULL 00/11] Ide patches

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 16:04, John Snow wrote: > The following changes since commit 16a1b6e97c2a2919fd296db4bea2f9da2ad3cc4d: > > target-cris: update CPU state save/load to use VMStateDescription > (2015-09-17 14:31:38 +0100) > > are available in the git repository at: > > https://github.com

Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

2015-09-18 Thread Richard Purdie
On Fri, 2015-09-18 at 09:46 -0700, Peter Crosthwaite wrote: > >> My biggest fear is testing of the changes for the affected boards. > >> Peter, do you much coverage of these boards in your regressions? Do you > >> have automated tests in a git repo somewhere? > > > > The answers to these questions

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Sergey Fedorov
On 18.09.2015 19:36, Peter Maydell wrote: > On 18 September 2015 at 17:33, Sergey Fedorov wrote: >> On 18.09.2015 17:14, Peter Maydell wrote: >>> On 18 September 2015 at 15:07, Sergey Fedorov wrote: On 18.09.2015 16:50, Peter Maydell wrote: > On 14 September 2015 at 11:51, Sergey Fedorov

Re: [Qemu-devel] [PATCH v3 0/3] virtio-mmio: introduce eventfd support

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 17:56, Yingshiuan Pan wrote: > Hi Peter, > > I think this patch set was already merged by Michael in Jun. :). > http://git.qemu.org/?p=qemu.git;a=commit;h=434027badb421863b85ffdb4769966533c001cfa That answers that question :-). Thanks for digging up the git commit for me.

Re: [Qemu-devel] [PATCH v2 04/22] target-*: Introduce and use cpu_breakpoint_test

2015-09-18 Thread Sergey Fedorov
On 18.09.2015 18:40, Richard Henderson wrote: > On 09/18/2015 03:32 AM, Peter Maydell wrote: >>> +if (unlikely(cpu_breakpoint_test(cs, dc->pc, BP_ANY))) { >>> +gen_exception_internal_insn(dc, 0, EXCP_DEBUG); >>> +/* Advance PC so that clearing the breakpoint will >>>

Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 17:46, Peter Crosthwaite wrote: > The other one I have in need of a review is: > > http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg05891.html Ah, data-driven device registers. I think I decided I didn't personally care enough about that to put it into my to-revi

Re: [Qemu-devel] [PATCH v5 14/38] block: Remove wr_highest_sector from BlockAcctStats

2015-09-18 Thread Eric Blake
On 09/18/2015 09:22 AM, Max Reitz wrote: > BlockAcctStats contains statistics about the data transferred from and > to the device; wr_highest_sector does not fit in with the rest. > > Furthermore, those statistics are supposed to be specific for a certain > device and not necessarily for a BDS (se

Re: [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci"

2015-09-18 Thread Pavel Butsykin
On 18.09.2015 19:26, Eric Blake wrote: On 09/18/2015 10:06 AM, Pavel Butsykin wrote: The hmp command "info pci" accidentally lost when moving from monitor.c Signed-off-by: Pavel Butsykin --- hmp-commands-info.hx | 14 ++ 1 file changed, 14 insertions(+) Paolo's variant has a b

Re: [Qemu-devel] [PATCH] hmp: Restore "info pci"

2015-09-18 Thread Eric Blake
On 09/18/2015 09:18 AM, Paolo Bonzini wrote: > Dropped by commit da76ee76f78b9705e2a91e3c964aef28fecededb's > transition to hmp-commands-info.hx. > > Reported-by: Markus Armbruster > Signed-off-by: Paolo Bonzini > --- > hmp-commands-info.hx | 14 ++ > 1 file changed, 14 insertions(+

Re: [Qemu-devel] [PATCH v3 0/3] virtio-mmio: introduce eventfd support

2015-09-18 Thread Yingshiuan Pan
Hi Peter, I think this patch set was already merged by Michael in Jun. :). http://git.qemu.org/?p=qemu.git;a=commit;h=434027badb421863b85ffdb4769966533c001cfa -- Best Regards, Yingshiuan Pan 2015-09-19 0:24 GMT+08:00 Peter Maydell : > On 12 May 2015 at 09:10, Pavel Fedin wrote: > > This patch

[Qemu-devel] [PATCH v5 34/38] qmp: Introduce blockdev-change-medium

2015-09-18 Thread Max Reitz
Introduce a new QMP command 'blockdev-change-medium' which is intended to replace the 'change' command for block devices. The existing function qmp_change_blockdev() is accordingly renamed to qmp_blockdev_change_medium(). Signed-off-by: Max Reitz --- blockdev.c| 7 --- inclu

[Qemu-devel] [PATCH v5 31/38] blockdev: Implement eject with basic operations

2015-09-18 Thread Max Reitz
Implement 'eject' by calling blockdev-open-tray and blockdev-remove-medium. Signed-off-by: Max Reitz --- blockdev.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index bbcea00..2644a4a 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1952,16

[Qemu-devel] [PATCH v5 32/38] blockdev: Implement change with basic operations

2015-09-18 Thread Max Reitz
Implement 'change' on block devices by calling blockdev-open-tray, blockdev-remove-medium, blockdev-insert-medium (a variation of that which does not need a node-name) and blockdev-close-tray. Signed-off-by: Max Reitz --- blockdev.c | 181 +

[Qemu-devel] [PULL 07/11] atapi: abort transfers with 0 byte limits

2015-09-18 Thread John Snow
We're supposed to abort on transfers like this, unless we fill Word 125 of our IDENTIFY data with a default transfer size, which we don't currently do. This is an ATA error, not a SCSI/ATAPI one. See ATA8-ACS3 sections 7.17.6.49 or 7.21.5. If we don't do this, QEMU will loop forever trying to tra

[Qemu-devel] [PATCH v5 38/38] iotests: Add test for change-related QMP commands

2015-09-18 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/118 | 638 + tests/qemu-iotests/118.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 644 insertions(+) create mode 100755 tests/qemu-iotests/118 create mode

[Qemu-devel] [PULL 11/11] ahci: clean up initial d2h semantics

2015-09-18 Thread John Snow
with write_fis_d2h and signature generation tidied up, let's adjust the initial d2h semantics to make more sense. The initial d2h is considered delivered if there is guest memory to save it to. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Message-id: 1441140641-17631-5-git-send-email-j

Re: [Qemu-devel] [PATCH 6/7] Revert "qdev: Use qdev_get_device_class() for -device , help"

2015-09-18 Thread Eric Blake
On 09/18/2015 06:00 AM, Markus Armbruster wrote: > This reverts commit 31bed5509dfcbdfc293154ce81086a4dbd7a80b6. > > The reverted commit changed qdev_device_help() to reject abstract > devices and devices that have cannot_instantiate_with_device_add_yet > set, to fix crash bugs like -device x86_64

Re: [Qemu-devel] [v2 0/2] Generic PCIe host bridge INTx determination for INTx routing

2015-09-18 Thread Peter Maydell
On 30 April 2015 at 12:52, Pranavkumar Sawargaonkar wrote: > This patch adds a routine for GPEX to implement PCI bus specific function > pointer > "route_intx_to_irq" which is used during INTx routing. > > ChangeLog: > > V2: > - Drop a patch about adding an API to get irq number from qemu_irq > -

Re: [Qemu-devel] [PATCH v5 08/38] block/raw_bsd: Drop raw_is_inserted()

2015-09-18 Thread Eric Blake
On 09/18/2015 09:22 AM, Max Reitz wrote: > With the new automatically-recursive implementation of > bdrv_is_inserted() checking by default whether all the children of a BDS > are inserted, we can drop raw's own implementation. > > Signed-off-by: Max Reitz > --- > block/raw_bsd.c | 6 -- > 1

Re: [Qemu-devel] [PATCH] target-arm: implement arm_debug_target_el()

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 17:15, Sergey Fedorov wrote: > On 18.09.2015 18:57, Sergey Fedorov wrote: >> On 18.09.2015 17:11, Peter Maydell wrote: >>> On 18 September 2015 at 15:08, Peter Maydell >>> wrote: On 14 September 2015 at 11:53, Sergey Fedorov wrote: > Implement debug exception ro

[Qemu-devel] [PATCH v5 07/38] block: Make bdrv_is_inserted() recursive

2015-09-18 Thread Max Reitz
If bdrv_is_inserted() is called on the top level BDS, it should make sure all nodes in the BDS tree are actually inserted. Signed-off-by: Max Reitz --- block.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 4a089e6..c4fa299 100644 --- a/b

[Qemu-devel] [PATCH v5 11/38] hw/usb-storage: Check whether BB is inserted

2015-09-18 Thread Max Reitz
Only call bdrv_add_key() on the BlockDriverState if it is not NULL. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- hw/usb/dev-storage.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/hw/usb/dev-storage.c b/

Re: [Qemu-devel] [PATCH v5 02/38] block: Set BDRV_O_INCOMING in bdrv_fill_options()

2015-09-18 Thread Eric Blake
On 09/18/2015 09:22 AM, Max Reitz wrote: > This flag should not be set for the root BDS only, but for any BDS that > is being created while incoming migration is pending, so setting it is > moved from blockdev_init() to bdrv_fill_options(). > > Signed-off-by: Max Reitz > --- > block.c| 4 +++

[Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci"

2015-09-18 Thread Pavel Butsykin
The hmp command "info pci" accidentally lost when moving from monitor.c Signed-off-by: Pavel Butsykin --- hmp-commands-info.hx | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 9f5a158..a311b46 100644 --- a/hmp-commands-info.hx

Re: [Qemu-devel] [PATCH v3 3/5] Implement fw_cfg DMA interface

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 09:58, Marc Marí wrote: > Based on the specifications on docs/specs/fw_cfg.txt > > This interface is an addon. The old interface can still be used as usual. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí Reviewed-by: Peter Maydell thank

[Qemu-devel] [PATCH v5 10/38] hw/block/fdc: Implement tray status

2015-09-18 Thread Max Reitz
The tray of an FDD is open iff there is no medium inserted (there are only two states for an FDD: "medium inserted" or "no medium inserted"). Signed-off-by: Max Reitz --- hw/block/fdc.c | 20 tests/fdc-test.c | 4 +--- 2 files changed, 17 insertions(+), 7 deletions(-) di

Re: [Qemu-devel] [PATCH v2 20/22] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-18 Thread Richard Henderson
On 09/18/2015 06:08 AM, Peter Maydell wrote: > You're still not allowing for your worst-case datatable size when we > calculate tcg_ctx.code_gen_buffer_max_size. Hum. What factor do you suggest? The maximum table expansion is of course going to depend on the target, since the "extra words" could

Re: [Qemu-devel] [PATCH v5 04/38] iotests: Only create BB if necessary

2015-09-18 Thread Eric Blake
On 09/18/2015 09:22 AM, Max Reitz wrote: > Tests 071 and 081 test giving references in blockdev-add. It is not > necessary to create a BlockBackend here, so omit it. > > While at it, fix up some blockdev-add invocations in the vicinity > (s/raw/$IMGFMT/ in 081, drop the format BDS for blkverify's

Re: [Qemu-devel] [PATCH 3/7] device-introspect-test: New, covering device introspection

2015-09-18 Thread Eric Blake
On 09/18/2015 06:00 AM, Markus Armbruster wrote: > The test doesn't check the output makes any sense, only that QEMU Reads slightly better as: s/check/check that/ > survives. Useful since we've had an astounding number of crash bugs > around there. > > In fact, we have a bunch of them right now

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Sergey Fedorov
On 18.09.2015 17:14, Peter Maydell wrote: > On 18 September 2015 at 15:07, Sergey Fedorov wrote: >> On 18.09.2015 16:50, Peter Maydell wrote: >>> On 14 September 2015 at 11:51, Sergey Fedorov wrote: --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -11000,11 +110

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-18 Thread Eric Blake
On 09/18/2015 06:00 AM, Markus Armbruster wrote: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > Unfortunately, I can't fix the problems in these devices right now. > Instead, add DeviceClass member cann

[Qemu-devel] [PULL 09/11] ahci: fix signature generation

2015-09-18 Thread John Snow
The initial register device-to-host FIS no longer needs to specially set certain fields, as these can be handled generically by setting those fields explicitly with the signatures we want at port reset time. (1) Signatures are decomposed into their four component registers and set upon (AHCI)

[Qemu-devel] [PATCH v5 33/38] block: Inquire tray state before tray-moved events

2015-09-18 Thread Max Reitz
blk_dev_change_media_cb() is called for all potential tray movements; however, it is possible to request closing the tray but nothing actually happening (on a floppy disk drive without a medium). Thus, the actual tray status should be inquired before sending a tray-moved event (and an event should

[Qemu-devel] [PATCH v5 19/38] block: Fail requests to empty BlockBackend

2015-09-18 Thread Max Reitz
If there is no BlockDriverState in a BlockBackend or if the tray of the guest device is open, fail all requests (where that is possible) with -ENOMEDIUM. The reason the status of the guest device is taken into account is because once the guest device's tray is opened, any request on the same Block

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-18 Thread Eduardo Habkost
On Fri, Sep 18, 2015 at 02:00:38PM +0200, Markus Armbruster wrote: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > This breaks at least device-list-properties, because > qmp_device_list_properties() needs

[Qemu-devel] [PULL 10/11] ahci: remove cmd_fis argument from write_fis_d2h

2015-09-18 Thread John Snow
It's no longer used. We used to generate a D2H FIS based upon the command FIS that prompted the update, but in reality, the D2H FIS is generated purely from register state. cmd_fis is vestigial, so get rid of it. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Message-id: 1441140641-17631

[Qemu-devel] [PULL 01/11] ide: unify io_buffer_offset increments

2015-09-18 Thread John Snow
IDEState's io_buffer_offset was originally added to keep track of offsets in AHCI rather exclusively, but it was added to IDEState instead of an AHCI-specific structure. AHCI fakes all PIO transfers using DMA and a scatter-gather list. When the core or atapi layers invoke HBA-specific mechanisms f

[Qemu-devel] [PATCH v5 20/38] block: Prepare remaining BB functions for NULL BDS

2015-09-18 Thread Max Reitz
There are several BlockBackend functions which, in theory, cannot fail. This patch makes them cope with the BlockDriverState pointer being NULL by making them fall back to some default action like ignoring the value in setters and returning the default in getters. Signed-off-by: Max Reitz Reviewe

[Qemu-devel] [PATCH v5 09/38] block: Invoke change media CB before NULLing drv

2015-09-18 Thread Max Reitz
In order to handle host device passthrough, some guest device models may call blk_is_inserted() to check whether the medium is inserted on the host, when checking the guest tray status. This tray status is inquired by blk_dev_change_media_cb(); because bdrv_is_inserted() (invoked by blk_is_inserte

[Qemu-devel] [PATCH v5 16/38] block: Move I/O status and error actions into BB

2015-09-18 Thread Max Reitz
These options are only relevant for the user of a whole BDS tree (like a guest device or a block job) and should thus be moved into the BlockBackend. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block.c| 125 - block/backup

[Qemu-devel] [PULL 02/11] qtest/ahci: use generate_pattern everywhere

2015-09-18 Thread John Snow
Fix the pattern generation to actually be interesting, and make sure all buffers in the ahci-test actually use it. Signed-off-by: John Snow Message-id: 1441926555-19471-2-git-send-email-js...@redhat.com --- tests/ahci-test.c | 23 ++- 1 file changed, 6 insertions(+), 17 delet

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 17:33, Sergey Fedorov wrote: > On 18.09.2015 17:14, Peter Maydell wrote: >> On 18 September 2015 at 15:07, Sergey Fedorov wrote: >>> On 18.09.2015 16:50, Peter Maydell wrote: On 14 September 2015 at 11:51, Sergey Fedorov wrote: > --- a/target-arm/translate-a64.c

[Qemu-devel] [PULL 08/11] ahci: remove dead reset code

2015-09-18 Thread John Snow
This check is dead due to an earlier conditional. AHCI does not currently support hotplugging, so checks to see if devices are present or not are useless. Remove it. Reported-by: Stefan Hajnoczi Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Message-id: 1441140641-17631-2-git-send-email

[Qemu-devel] [PATCH v5 28/38] blockdev: Add blockdev-close-tray

2015-09-18 Thread Max Reitz
Signed-off-by: Max Reitz --- blockdev.c | 23 +++ qapi/block-core.json | 16 qmp-commands.hx | 35 +++ 3 files changed, 74 insertions(+) diff --git a/blockdev.c b/blockdev.c index 6bc5841..d07bf8a 100644 --- a/bl

Re: [Qemu-devel] [PULL 0/8] Error reporting patches

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 14:22, Markus Armbruster wrote: > The following changes since commit 16a1b6e97c2a2919fd296db4bea2f9da2ad3cc4d: > > target-cris: update CPU state save/load to use VMStateDescription > (2015-09-17 14:31:38 +0100) > > are available in the git repository at: > > git://repo

Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

2015-09-18 Thread Peter Crosthwaite
On Fri, Sep 18, 2015 at 9:28 AM, Peter Maydell wrote: > On 14 June 2015 at 23:36, Peter Crosthwaite > wrote >> This series introduced support for multi QOM properties with the same >> name and then moves the ARM CPUs to the MPCore container objects (yes! >> they are related!) >> >> The applicati

Re: [Qemu-devel] [PATCH] target-arm: implement arm_debug_target_el()

2015-09-18 Thread Sergey Fedorov
On 18.09.2015 18:57, Sergey Fedorov wrote: > On 18.09.2015 17:11, Peter Maydell wrote: >> On 18 September 2015 at 15:08, Peter Maydell >> wrote: >>> On 14 September 2015 at 11:53, Sergey Fedorov wrote: Implement debug exception routing according to ARM ARM D2.3.1 Pseudocode description

  1   2   3   4   >